omap_crtc.c 17.3 KB
Newer Older
1
/*
R
Rob Clark 已提交
2
 * drivers/gpu/drm/omapdrm/omap_crtc.c
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
 *
 * Copyright (C) 2011 Texas Instruments
 * Author: Rob Clark <rob@ti.com>
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 */

20 21
#include <linux/completion.h>

22 23
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
24 25
#include <drm/drm_crtc.h>
#include <drm/drm_crtc_helper.h>
26
#include <drm/drm_mode.h>
27
#include <drm/drm_plane_helper.h>
28 29

#include "omap_drv.h"
30 31 32 33 34

#define to_omap_crtc(x) container_of(x, struct omap_crtc, base)

struct omap_crtc {
	struct drm_crtc base;
35

36
	const char *name;
37 38
	enum omap_channel channel;
	struct omap_overlay_manager_info info;
39
	struct drm_encoder *current_encoder;
40 41 42 43 44 45 46

	/*
	 * Temporary: eventually this will go away, but it is needed
	 * for now to keep the output's happy.  (They only need
	 * mgr->id.)  Eventually this will be replaced w/ something
	 * more common-panel-framework-y
	 */
47
	struct omap_overlay_manager *mgr;
48 49 50 51

	struct omap_video_timings timings;
	bool enabled;

52
	struct omap_drm_irq vblank_irq;
53 54
	struct omap_drm_irq error_irq;

55 56
	/* pending event */
	struct drm_pending_vblank_event *event;
57
	wait_queue_head_t flip_wait;
58

59 60
	struct completion completion;

61
	bool ignore_digit_sync_lost;
62 63
};

64 65 66 67
/* -----------------------------------------------------------------------------
 * Helper Functions
 */

68 69 70 71 72 73 74
uint32_t pipe2vbl(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

	return dispc_mgr_get_vsync_irq(omap_crtc->channel);
}

75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
const struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return &omap_crtc->timings;
}

enum omap_channel omap_crtc_channel(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return omap_crtc->channel;
}

/* -----------------------------------------------------------------------------
 * DSS Manager Functions
 */

91 92 93 94 95 96 97 98 99
/*
 * Manager-ops, callbacks from output when they need to configure
 * the upstream part of the video pipe.
 *
 * Most of these we can ignore until we add support for command-mode
 * panels.. for video-mode the crtc-helpers already do an adequate
 * job of sequencing the setup of the video pipe in the proper order
 */

100 101 102
/* ovl-mgr-id -> crtc */
static struct omap_crtc *omap_crtcs[8];

103
/* we can probably ignore these until we support command-mode panels: */
104
static int omap_crtc_dss_connect(struct omap_overlay_manager *mgr,
105
		struct omap_dss_device *dst)
106 107 108 109 110 111 112 113 114 115 116 117 118
{
	if (mgr->output)
		return -EINVAL;

	if ((mgr->supported_outputs & dst->id) == 0)
		return -EINVAL;

	dst->manager = mgr;
	mgr->output = dst;

	return 0;
}

119
static void omap_crtc_dss_disconnect(struct omap_overlay_manager *mgr,
120
		struct omap_dss_device *dst)
121 122 123 124 125
{
	mgr->output->manager = NULL;
	mgr->output = NULL;
}

126
static void omap_crtc_dss_start_update(struct omap_overlay_manager *mgr)
127 128 129
{
}

130
/* Called only from omap_crtc_setup and suspend/resume handlers. */
131 132 133 134 135 136 137 138 139 140 141 142
static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)
{
	struct drm_device *dev = crtc->dev;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	enum omap_channel channel = omap_crtc->channel;
	struct omap_irq_wait *wait;
	u32 framedone_irq, vsync_irq;
	int ret;

	if (dispc_mgr_is_enabled(channel) == enable)
		return;

143 144 145 146 147 148 149
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		/*
		 * Digit output produces some sync lost interrupts during the
		 * first frame when enabling, so we need to ignore those.
		 */
		omap_crtc->ignore_digit_sync_lost = true;
	}
150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179

	framedone_irq = dispc_mgr_get_framedone_irq(channel);
	vsync_irq = dispc_mgr_get_vsync_irq(channel);

	if (enable) {
		wait = omap_irq_wait_init(dev, vsync_irq, 1);
	} else {
		/*
		 * When we disable the digit output, we need to wait for
		 * FRAMEDONE to know that DISPC has finished with the output.
		 *
		 * OMAP2/3 does not have FRAMEDONE irq for digit output, and in
		 * that case we need to use vsync interrupt, and wait for both
		 * even and odd frames.
		 */

		if (framedone_irq)
			wait = omap_irq_wait_init(dev, framedone_irq, 1);
		else
			wait = omap_irq_wait_init(dev, vsync_irq, 2);
	}

	dispc_mgr_enable(channel, enable);

	ret = omap_irq_wait(dev, wait, msecs_to_jiffies(100));
	if (ret) {
		dev_err(dev->dev, "%s: timeout waiting for %s\n",
				omap_crtc->name, enable ? "enable" : "disable");
	}

180 181 182 183 184
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		omap_crtc->ignore_digit_sync_lost = false;
		/* make sure the irq handler sees the value above */
		mb();
	}
185 186
}

187

188
static int omap_crtc_dss_enable(struct omap_overlay_manager *mgr)
189
{
190 191 192 193 194
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];

	dispc_mgr_setup(omap_crtc->channel, &omap_crtc->info);
	dispc_mgr_set_timings(omap_crtc->channel,
			&omap_crtc->timings);
195
	omap_crtc_set_enabled(&omap_crtc->base, true);
196

197 198 199
	return 0;
}

200
static void omap_crtc_dss_disable(struct omap_overlay_manager *mgr)
201
{
202 203
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];

204
	omap_crtc_set_enabled(&omap_crtc->base, false);
205 206
}

207
static void omap_crtc_dss_set_timings(struct omap_overlay_manager *mgr,
208 209
		const struct omap_video_timings *timings)
{
210
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
211 212 213 214
	DBG("%s", omap_crtc->name);
	omap_crtc->timings = *timings;
}

215
static void omap_crtc_dss_set_lcd_config(struct omap_overlay_manager *mgr,
216 217
		const struct dss_lcd_mgr_config *config)
{
218
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
219 220 221 222
	DBG("%s", omap_crtc->name);
	dispc_mgr_set_lcd_config(omap_crtc->channel, config);
}

223
static int omap_crtc_dss_register_framedone(
224 225 226 227 228 229
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
	return 0;
}

230
static void omap_crtc_dss_unregister_framedone(
231 232 233 234 235 236
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
}

static const struct dss_mgr_ops mgr_ops = {
237 238 239 240 241 242 243 244 245
	.connect = omap_crtc_dss_connect,
	.disconnect = omap_crtc_dss_disconnect,
	.start_update = omap_crtc_dss_start_update,
	.enable = omap_crtc_dss_enable,
	.disable = omap_crtc_dss_disable,
	.set_timings = omap_crtc_dss_set_timings,
	.set_lcd_config = omap_crtc_dss_set_lcd_config,
	.register_framedone_handler = omap_crtc_dss_register_framedone,
	.unregister_framedone_handler = omap_crtc_dss_unregister_framedone,
246 247
};

248
/* -----------------------------------------------------------------------------
249
 * Setup, Flush and Page Flip
250 251
 */

252 253 254
void omap_crtc_cancel_page_flip(struct drm_crtc *crtc, struct drm_file *file)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
255
	struct drm_pending_vblank_event *event;
256 257 258
	struct drm_device *dev = crtc->dev;
	unsigned long flags;

259 260 261 262
	/* Destroy the pending vertical blanking event associated with the
	 * pending page flip, if any, and disable vertical blanking interrupts.
	 */

263 264
	spin_lock_irqsave(&dev->event_lock, flags);

265 266 267 268 269 270
	event = omap_crtc->event;
	omap_crtc->event = NULL;

	if (event && event->base.file_priv == file) {
		event->base.destroy(&event->base);
		drm_crtc_vblank_put(crtc);
271 272 273 274 275
	}

	spin_unlock_irqrestore(&dev->event_lock, flags);
}

276
static void omap_crtc_complete_page_flip(struct drm_crtc *crtc)
277 278
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
279
	struct drm_pending_vblank_event *event;
280
	struct drm_device *dev = crtc->dev;
281
	unsigned long flags;
282

283
	spin_lock_irqsave(&dev->event_lock, flags);
284

285 286
	event = omap_crtc->event;
	omap_crtc->event = NULL;
287

288 289
	if (event) {
		drm_crtc_send_vblank_event(crtc, event);
290
		wake_up(&omap_crtc->flip_wait);
291 292 293 294
		drm_crtc_vblank_put(crtc);
	}

	spin_unlock_irqrestore(&dev->event_lock, flags);
295 296 297 298 299 300 301 302 303 304
}

static bool omap_crtc_page_flip_pending(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	struct drm_device *dev = crtc->dev;
	unsigned long flags;
	bool pending;

	spin_lock_irqsave(&dev->event_lock, flags);
305
	pending = omap_crtc->event != NULL;
306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321
	spin_unlock_irqrestore(&dev->event_lock, flags);

	return pending;
}

static void omap_crtc_wait_page_flip(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

	if (wait_event_timeout(omap_crtc->flip_wait,
			       !omap_crtc_page_flip_pending(crtc),
			       msecs_to_jiffies(50)))
		return;

	dev_warn(crtc->dev->dev, "page flip timeout!\n");

322
	omap_crtc_complete_page_flip(crtc);
323 324
}

325 326 327 328
static void omap_crtc_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
{
	struct omap_crtc *omap_crtc =
			container_of(irq, struct omap_crtc, error_irq);
329 330 331 332 333 334 335

	if (omap_crtc->ignore_digit_sync_lost) {
		irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT;
		if (!irqstatus)
			return;
	}

336
	DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_crtc->name, irqstatus);
337 338
}

339
static void omap_crtc_vblank_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
340 341
{
	struct omap_crtc *omap_crtc =
342 343
			container_of(irq, struct omap_crtc, vblank_irq);
	struct drm_device *dev = omap_crtc->base.dev;
344

345 346 347 348 349 350 351
	if (dispc_mgr_go_busy(omap_crtc->channel))
		return;

	DBG("%s: apply done", omap_crtc->name);
	__omap_irq_unregister(dev, &omap_crtc->vblank_irq);

	/* wakeup userspace */
352
	omap_crtc_complete_page_flip(&omap_crtc->base);
353 354

	complete(&omap_crtc->completion);
355 356
}

357
int omap_crtc_flush(struct drm_crtc *crtc)
358
{
359
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
360

361
	DBG("%s: GO", omap_crtc->name);
362

363 364
	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
	WARN_ON(omap_crtc->vblank_irq.registered);
365

366
	dispc_runtime_get();
367

368 369 370
	if (dispc_mgr_is_enabled(omap_crtc->channel)) {
		dispc_mgr_go(omap_crtc->channel);
		omap_irq_register(crtc->dev, &omap_crtc->vblank_irq);
371

372 373 374 375
		WARN_ON(!wait_for_completion_timeout(&omap_crtc->completion,
						     msecs_to_jiffies(100)));
		reinit_completion(&omap_crtc->completion);
	}
376

377
	dispc_runtime_put();
378 379 380 381

	return 0;
}

382
static void omap_crtc_setup(struct drm_crtc *crtc)
383
{
384
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
385 386 387 388 389 390
	struct omap_drm_private *priv = crtc->dev->dev_private;
	struct drm_encoder *encoder = NULL;
	unsigned int i;

	DBG("%s: enabled=%d", omap_crtc->name, omap_crtc->enabled);

391 392
	dispc_runtime_get();

393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416
	for (i = 0; i < priv->num_encoders; i++) {
		if (priv->encoders[i]->crtc == crtc) {
			encoder = priv->encoders[i];
			break;
		}
	}

	if (omap_crtc->current_encoder && encoder != omap_crtc->current_encoder)
		omap_encoder_set_enabled(omap_crtc->current_encoder, false);

	omap_crtc->current_encoder = encoder;

	if (!omap_crtc->enabled) {
		if (encoder)
			omap_encoder_set_enabled(encoder, false);
	} else {
		if (encoder) {
			omap_encoder_set_enabled(encoder, false);
			omap_encoder_update(encoder, omap_crtc->mgr,
					&omap_crtc->timings);
			omap_encoder_set_enabled(encoder, true);
		}
	}

417
	dispc_runtime_put();
418 419 420 421
}

/* -----------------------------------------------------------------------------
 * CRTC Functions
422 423
 */

424 425 426
static void omap_crtc_destroy(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
427 428 429

	DBG("%s", omap_crtc->name);

430
	WARN_ON(omap_crtc->vblank_irq.registered);
431 432
	omap_irq_unregister(crtc->dev, &omap_crtc->error_irq);

433
	drm_crtc_cleanup(crtc);
434

435 436 437
	kfree(omap_crtc);
}

438 439 440 441 442 443 444 445
static bool omap_crtc_mode_fixup(struct drm_crtc *crtc,
		const struct drm_display_mode *mode,
		struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void omap_crtc_enable(struct drm_crtc *crtc)
446
{
447
	struct omap_drm_private *priv = crtc->dev->dev_private;
448
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
449
	unsigned int i;
450

451
	DBG("%s", omap_crtc->name);
452

453
	if (omap_crtc->enabled)
454
		return;
455

456
	/* Enable all planes associated with the CRTC. */
457 458 459 460
	for (i = 0; i < priv->num_planes; i++) {
		struct drm_plane *plane = priv->planes[i];

		if (plane->crtc == crtc)
461
			WARN_ON(omap_plane_set_enable(plane, true));
462
	}
463

464
	omap_crtc->enabled = true;
465 466 467

	omap_crtc_setup(crtc);
	omap_crtc_flush(crtc);
468

469 470 471
	dispc_runtime_get();
	drm_crtc_vblank_on(crtc);
	dispc_runtime_put();
472 473
}

474
static void omap_crtc_disable(struct drm_crtc *crtc)
475
{
476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501
	struct omap_drm_private *priv = crtc->dev->dev_private;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	unsigned int i;

	DBG("%s", omap_crtc->name);

	if (!omap_crtc->enabled)
		return;

	omap_crtc_wait_page_flip(crtc);
	dispc_runtime_get();
	drm_crtc_vblank_off(crtc);
	dispc_runtime_put();

	/* Disable all planes associated with the CRTC. */
	for (i = 0; i < priv->num_planes; i++) {
		struct drm_plane *plane = priv->planes[i];

		if (plane->crtc == crtc)
			WARN_ON(omap_plane_set_enable(plane, false));
	}

	omap_crtc->enabled = false;

	omap_crtc_setup(crtc);
	omap_crtc_flush(crtc);
502 503
}

504
static void omap_crtc_mode_set_nofb(struct drm_crtc *crtc)
505 506
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
507
	struct drm_display_mode *mode = &crtc->state->adjusted_mode;
508 509

	DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
510 511 512 513 514
	    omap_crtc->name, mode->base.id, mode->name,
	    mode->vrefresh, mode->clock,
	    mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
	    mode->vdisplay, mode->vsync_start, mode->vsync_end, mode->vtotal,
	    mode->type, mode->flags);
515 516

	copy_timings_drm_to_omap(&omap_crtc->timings, mode);
517 518
}

519 520
static void omap_crtc_atomic_begin(struct drm_crtc *crtc)
{
521
	struct drm_pending_vblank_event *event = crtc->state->event;
522
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
523
	struct drm_device *dev = crtc->dev;
524
	unsigned long flags;
525

526
	dispc_runtime_get();
527

528 529 530
	if (event) {
		WARN_ON(omap_crtc->event);
		WARN_ON(drm_crtc_vblank_get(crtc) != 0);
531

532 533
		spin_lock_irqsave(&dev->event_lock, flags);
		omap_crtc->event = event;
534
		spin_unlock_irqrestore(&dev->event_lock, flags);
535
	}
536
}
537

538 539 540
static void omap_crtc_atomic_flush(struct drm_crtc *crtc)
{
	omap_crtc_flush(crtc);
541

542
	dispc_runtime_put();
543 544 545

	crtc->invert_dimensions = !!(crtc->primary->state->rotation &
				    (BIT(DRM_ROTATE_90) | BIT(DRM_ROTATE_270)));
546 547
}

548 549 550 551
static int omap_crtc_atomic_set_property(struct drm_crtc *crtc,
					 struct drm_crtc_state *state,
					 struct drm_property *property,
					 uint64_t val)
552
{
553 554 555 556 557 558 559 560 561 562 563 564 565 566
	struct drm_plane_state *plane_state;
	struct drm_plane *plane = crtc->primary;

	/*
	 * Delegate property set to the primary plane. Get the plane state and
	 * set the property directly.
	 */

	plane_state = drm_atomic_get_plane_state(state->state, plane);
	if (!plane_state)
		return -EINVAL;

	return drm_atomic_plane_set_property(plane, plane_state, property, val);
}
567

568 569 570 571 572 573 574 575 576 577 578 579 580
static int omap_crtc_atomic_get_property(struct drm_crtc *crtc,
					 const struct drm_crtc_state *state,
					 struct drm_property *property,
					 uint64_t *val)
{
	/*
	 * Delegate property get to the primary plane. The
	 * drm_atomic_plane_get_property() function isn't exported, but can be
	 * called through drm_object_property_get_value() as that will call
	 * drm_atomic_get_property() for atomic drivers.
	 */
	return drm_object_property_get_value(&crtc->primary->base, property,
					     val);
581 582
}

583
static const struct drm_crtc_funcs omap_crtc_funcs = {
584
	.reset = drm_atomic_helper_crtc_reset,
585
	.set_config = drm_atomic_helper_set_config,
586
	.destroy = omap_crtc_destroy,
587
	.page_flip = drm_atomic_helper_page_flip,
588
	.set_property = drm_atomic_helper_crtc_set_property,
589 590
	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
591 592
	.atomic_set_property = omap_crtc_atomic_set_property,
	.atomic_get_property = omap_crtc_atomic_get_property,
593 594 595 596
};

static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = {
	.mode_fixup = omap_crtc_mode_fixup,
597
	.mode_set_nofb = omap_crtc_mode_set_nofb,
598 599
	.disable = omap_crtc_disable,
	.enable = omap_crtc_enable,
600 601
	.atomic_begin = omap_crtc_atomic_begin,
	.atomic_flush = omap_crtc_atomic_flush,
602 603
};

604 605 606
/* -----------------------------------------------------------------------------
 * Init and Cleanup
 */
607

608
static const char *channel_names[] = {
609 610 611 612
	[OMAP_DSS_CHANNEL_LCD] = "lcd",
	[OMAP_DSS_CHANNEL_DIGIT] = "tv",
	[OMAP_DSS_CHANNEL_LCD2] = "lcd2",
	[OMAP_DSS_CHANNEL_LCD3] = "lcd3",
613 614
};

615 616 617 618 619
void omap_crtc_pre_init(void)
{
	dss_install_mgr_ops(&mgr_ops);
}

620 621 622 623 624
void omap_crtc_pre_uninit(void)
{
	dss_uninstall_mgr_ops();
}

625 626
/* initialize crtc */
struct drm_crtc *omap_crtc_init(struct drm_device *dev,
627
		struct drm_plane *plane, enum omap_channel channel, int id)
628 629
{
	struct drm_crtc *crtc = NULL;
630 631
	struct omap_crtc *omap_crtc;
	struct omap_overlay_manager_info *info;
632
	int ret;
633 634

	DBG("%s", channel_names[channel]);
635

636
	omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL);
637
	if (!omap_crtc)
638
		return NULL;
639 640

	crtc = &omap_crtc->base;
641

642
	init_waitqueue_head(&omap_crtc->flip_wait);
643
	init_completion(&omap_crtc->completion);
644

645 646 647
	omap_crtc->channel = channel;
	omap_crtc->name = channel_names[channel];

648 649
	omap_crtc->vblank_irq.irqmask = pipe2vbl(crtc);
	omap_crtc->vblank_irq.irq = omap_crtc_vblank_irq;
650 651 652 653 654 655 656

	omap_crtc->error_irq.irqmask =
			dispc_mgr_get_sync_lost_irq(channel);
	omap_crtc->error_irq.irq = omap_crtc_error_irq;
	omap_irq_register(dev, &omap_crtc->error_irq);

	/* temporary: */
657
	omap_crtc->mgr = omap_dss_get_overlay_manager(channel);
658 659 660 661 662 663 664

	/* TODO: fix hard-coded setup.. add properties! */
	info = &omap_crtc->info;
	info->default_color = 0x00000000;
	info->trans_key = 0x00000000;
	info->trans_key_type = OMAP_DSS_COLOR_KEY_GFX_DST;
	info->trans_enabled = false;
665

666 667 668 669 670 671 672
	ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
					&omap_crtc_funcs);
	if (ret < 0) {
		kfree(omap_crtc);
		return NULL;
	}

673 674
	drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs);

675
	omap_plane_install_properties(crtc->primary, &crtc->base);
676

677 678
	omap_crtcs[channel] = omap_crtc;

679 680
	return crtc;
}