1. 11 8月, 2011 1 次提交
  2. 28 6月, 2011 1 次提交
  3. 22 6月, 2011 1 次提交
  4. 13 4月, 2011 1 次提交
    • J
      vxge: spin-lock issue · 9f9b1645
      Jon Mason 提交于
      In vxge_hw_vpath_close, __vxge_hw_vp_terminate memsets the vpath which
      clobbers the spin lock state, then the driver attempts to acquire the
      spin lock.  Resolve this by not zeroing the lock part of vpath struct,
      clean-up vpath locking in init, close, and fix locking hole in fw_api
      call.
      
      Issue found by Bob Picco <bpicco@redhat.com>
      Signed-off-by: NJon Mason <jdmason@kudzu.us>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9f9b1645
  5. 31 3月, 2011 1 次提交
  6. 02 2月, 2011 1 次提交
    • S
      vxge: Fix wrong boolean operator · 48bc9a2c
      Stefan Weil 提交于
      This error is reported by cppcheck:
      drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?
      
      It looks like cppcheck is correct, so fix this. No test was run.
      
      Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
      Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
      Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
      Cc: Jon Mason <jon.mason@exar.com>
      Cc: netdev@vger.kernel.org
      Cc: linux-kernel@vger.kernel.org
      Signed-off-by: NStefan Weil <weil@mail.berlios.de>
      Acked-by: NRam Vepa <ram.vepa@exar.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      48bc9a2c
  7. 20 1月, 2011 2 次提交
  8. 11 12月, 2010 2 次提交
  9. 29 11月, 2010 1 次提交
  10. 28 11月, 2010 1 次提交
  11. 12 11月, 2010 8 次提交
  12. 25 10月, 2010 1 次提交
  13. 16 7月, 2010 1 次提交
  14. 14 5月, 2010 1 次提交
    • J
      drivers/net: Remove unnecessary returns from void function()s · a4b77097
      Joe Perches 提交于
      This patch removes from drivers/net/ all the unnecessary
      return; statements that precede the last closing brace of
      void functions.
      
      It does not remove the returns that are immediately
      preceded by a label as gcc doesn't like that.
      
      It also does not remove null void functions with return.
      
      Done via:
      $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
        xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
      
      with some cleanups by hand.
      
      Compile tested x86 allmodconfig only.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a4b77097
  15. 08 4月, 2010 1 次提交
  16. 30 3月, 2010 3 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
    • S
      vxge: Set function-0 as the privilaged function for normal function. · 1dc47a9b
      Sreenivasa Honnur 提交于
      -  For Normal function (MR-IOV disabled, SR-IOV disabled) Function-0 is the
         privilaged function.
      Signed-off-by: NSreenivasa Honnur <sreenivasa.honnur@neterion.com>
      Signed-off-by: NRamkrishna Vepa <ram.vepa@neterion.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1dc47a9b
    • S
      vxge: Fix starvation of receive ring controller when blasted by short packets. · 3363276f
      Sreenivasa Honnur 提交于
      - Fix starvation of receive ring controller when blasted by short packets. This was because the driver was posting 64 rxds initially while the ring controller
      was expecting to read 256 replenished rxds. While the driver was coming up,
      the internal rxd memory filled up the 64 buffers provided and the ring
      controller was left waiting for the remaining 192 rxds to complete the write
      back of completed rxds to the host and generation of an interrupt.
      Signed-off-by: NSreenivasa Honnur <sreenivasa.honnur@neterion.com>
      Signed-off-by: NRamkrishna Vepa <ram.vepa@neterion.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3363276f
  17. 07 10月, 2009 5 次提交
  18. 06 7月, 2009 1 次提交
  19. 17 6月, 2009 1 次提交
  20. 11 6月, 2009 1 次提交
  21. 02 4月, 2009 1 次提交
    • R
      Neterion: New driver: Hardware init & configuration · 40a3a915
      Ramkrishna Vepa 提交于
      This patch takes care of Initialization and configuration steps of
      Neterion Inc's X3100 Series 10GbE PCIe I/O Virtualized Server Adapter.
      - Device Initialization.
      - Verification and setting of device config parameters.
      - Allocation of Tx FIFO and Rx Ring descriptors (DTR).
      - APIs to get various type of hw stats
      - APIs to configure RTS (Receive Traffic Steering)
      
      - Changes in this submission -
              - Include vmalloc header without which a compilation error occured
                on sparc64, ppc64 and IA64 plaforms.
      	- Fixed compilation warning in register_poll, write32_upper,
                write32_lower and the special write64 functions on ppc64.
              - General cleanup - removed redundant includes and defines.
      
      - Changes in previous submissions -
              - Add readq/writeq implementation for the driver for 32 bit systems -
                reported by Dave Miller.
      - Incorporated following comments from Ben Hutchings
              - Start a comment with "/**" to make it a kernel-doc comment.
              - Use prefix, "__vxge" in front of hw functions to make them globally
                unique.
              - Fixed unnecessary clearing members of *channel just before freeing
              - Use backslashes only for macro definitions and not in multi-line
                statements.
              - Used pci_find_capability instead of redefining it.
              - Used device and revision ids that are already in pdev - no need to
                read them again.
              - Used pci_save_state() and pci_restore_state() around resets.
              - Used udelay and mdelay directly instead of wrapper.
              - In __vxge_hw_device_register_poll() reset i to 0 after the
                microsecond delay loop to commence the millisecond delay loop.
              - Corrected spelling "sapper" - should be "swapper"
              - Remove too much vertical whitespace.
              - Replaced magic numbers with appropriate macros
      - Incorporated following comments from Andi Kleen [andi@firstfloor.org]
              - Reduced the arguments in functions or refactored them into smaller
              functions.
              - Allocate page sized memories used in slow path with vmalloc.
              - Use asserts where necessary.
              - Use macros instead of magic numbers.
              - Use the pci layer code instead of defining own functions
              - Remove driver wrappers such as xge_hw_device_private_set().
              - Fixed sparse warnings.
      Signed-off-by: NSivakumar Subramani <sivakumar.subramani@neterion.com>
      Signed-off-by: NRastapur Santosh <santosh.rastapur@neterion.com>
      Signed-off-by: NRamkrishna Vepa <ram.vepa@neterion.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      40a3a915