1. 29 8月, 2017 2 次提交
  2. 23 8月, 2017 1 次提交
    • Y
      Cache the number of open issues and merge requests · 6ec53f5d
      Yorick Peterse 提交于
      Every project page displays a navigation menu that in turn displays the
      number of open issues and merge requests. This means that for every
      project page we run two COUNT(*) queries, each taking up roughly 30
      milliseconds on GitLab.com. By caching these numbers and refreshing them
      whenever necessary we can reduce loading times of all these pages by up
      to roughly 60 milliseconds.
      
      The number of open issues does not include confidential issues. This is
      a trade-off to keep the code simple and to ensure refreshing the data
      only needs 2 COUNT(*) queries instead of 3. A downside is that if a
      project only has 5 confidential issues the counter will be set to 0.
      
      Because we now have 3 similar counting service classes the code
      previously used in Projects::ForksCountService has mostly been moved to
      Projects::CountService, which in turn is reused by the various service
      classes.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36622
      6ec53f5d
  3. 13 8月, 2017 1 次提交
  4. 11 8月, 2017 1 次提交
  5. 09 8月, 2017 1 次提交
  6. 08 8月, 2017 1 次提交
  7. 03 8月, 2017 1 次提交
  8. 01 8月, 2017 1 次提交
  9. 27 7月, 2017 1 次提交
  10. 24 7月, 2017 1 次提交
  11. 07 7月, 2017 2 次提交
    • S
      Speed up `all_commit_shas` for new merge requests · 4c0864fd
      Sean McGivern 提交于
      For merge requests created after 9.4, we have a `merge_request_diff_commits`
      table we can get all the SHAs from very quickly. We just need to exclude these
      when we load from the legacy format, by ignoring diffs with no serialised
      commits.
      
      Once these have been migrated in the background, every MR will see this
      improvement.
      4c0864fd
    • S
      Add table for merge request commits · aff5c9f3
      Sean McGivern 提交于
      This is an ID-less table with just three columns: an association to the merge
      request diff the commit belongs to, the relative order of the commit within the
      merge request diff, and the commit SHA itself.
      
      Previously we stored much more information about the commits, so that we could
      display them even when they were deleted from the repo. Since 8.0, we ensure
      that those commits are kept around for as long as the target repo itself is, so
      we don't need to duplicate that data in the database.
      aff5c9f3
  12. 06 7月, 2017 1 次提交
    • Y
      Add many foreign keys to the projects table · c63e3221
      Yorick Peterse 提交于
      This removes the need for relying on Rails' "dependent" option for data
      removal, which is _incredibly_ slow (even when using :delete_all) when
      deleting large amounts of data. This also ensures data consistency is
      enforced on DB level and not on application level (something Rails is
      really bad at).
      
      This commit also includes various migrations to add foreign keys to
      tables that eventually point to "projects" to ensure no rows get
      orphaned upon removing a project.
      c63e3221
  13. 26 6月, 2017 1 次提交
  14. 21 6月, 2017 2 次提交
  15. 15 6月, 2017 2 次提交
  16. 01 6月, 2017 1 次提交
  17. 30 5月, 2017 1 次提交
  18. 24 5月, 2017 2 次提交
  19. 23 5月, 2017 1 次提交
  20. 13 5月, 2017 1 次提交
    • S
      Fix conflict resolution from corrupted upstream · ad2bfeb8
      Sean McGivern 提交于
      I don't know why this happens exactly, but given an upstream and fork repository
      from a customer, both of which required GC, resolving conflicts would corrupt
      the fork so badly that it couldn't be cloned.
      
      This isn't a perfect fix for that case, because the MR may still need to be
      merged manually, but it does ensure that the repository is at least usable.
      
      My best guess is that when we generate the index for the conflict
      resolution (which we previously did in the target project), we obtain a
      reference to an OID that doesn't exist in the source, even though we already
      fetch the refs from the target into the source.
      
      Explicitly setting the source project as the place to get the merge index from
      seems to prevent repository corruption in this way.
      ad2bfeb8
  21. 12 5月, 2017 1 次提交
  22. 09 5月, 2017 1 次提交
  23. 08 5月, 2017 2 次提交
  24. 04 5月, 2017 2 次提交
  25. 25 4月, 2017 1 次提交
    • S
      Show correct size when MR diff overflows · a0979c05
      Sean McGivern 提交于
      The problem is that we often go via a diff object constructed from the diffs
      stored in the DB. Those diffs, by definition, don't overflow, so we don't have
      access to the 'correct' `real_size` - that is stored on the MR diff object
      iself.
      a0979c05
  26. 20 4月, 2017 1 次提交
  27. 06 4月, 2017 4 次提交
  28. 04 4月, 2017 1 次提交
  29. 15 3月, 2017 1 次提交
  30. 06 3月, 2017 1 次提交
    • S
      Fix issues mentioned but not closed for JIRA · 9f612cc4
      Sean McGivern 提交于
      The `ReferenceExtractor` would return an array of `ExternalIssue`
      objects, and then perform `Array#-` to remove the issues
      closed. `ExternalIssue`s had `==` defined, but not `hash` or `eql?`,
      which are used by `Array#-`.
      9f612cc4