feature_gate.rs 46.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

S
Steven Fackler 已提交
25
use self::Status::*;
26
use self::AttributeType::*;
27
use self::AttributeGate::*;
28

N
Niko Matsakis 已提交
29
use abi::Abi;
N
Nick Cameron 已提交
30 31 32 33
use ast::NodeId;
use ast;
use attr;
use attr::AttrMetaMethods;
C
Corey Richardson 已提交
34
use codemap::{CodeMap, Span};
N
Nick Cameron 已提交
35 36
use diagnostic::SpanHandler;
use visit;
37
use visit::{FnKind, Visitor};
38
use parse::token::InternedString;
39

40
use std::ascii::AsciiExt;
41
use std::cmp;
42

B
Brian Anderson 已提交
43 44 45 46 47 48 49
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.
50 51 52 53
const KNOWN_FEATURES: &'static [(&'static str, &'static str, Option<u32>, Status)] = &[
    ("globs", "1.0.0", None, Accepted),
    ("macro_rules", "1.0.0", None, Accepted),
    ("struct_variant", "1.0.0", None, Accepted),
A
Aaron Turon 已提交
54
    ("asm", "1.0.0", Some(29722), Active),
55
    ("managed_boxes", "1.0.0", None, Removed),
A
Aaron Turon 已提交
56 57 58 59 60 61 62 63 64
    ("non_ascii_idents", "1.0.0", Some(28979), Active),
    ("thread_local", "1.0.0", Some(29594), Active),
    ("link_args", "1.0.0", Some(29596), Active),
    ("plugin_registrar", "1.0.0", Some(29597), Active),
    ("log_syntax", "1.0.0", Some(29598), Active),
    ("trace_macros", "1.0.0", Some(29598), Active),
    ("concat_idents", "1.0.0", Some(29599), Active),

    // rustc internal, for now:
65 66 67 68 69
    ("intrinsics", "1.0.0", None, Active),
    ("lang_items", "1.0.0", None, Active),

    ("simd", "1.0.0", Some(27731), Active),
    ("default_type_params", "1.0.0", None, Accepted),
A
Aaron Turon 已提交
70 71 72
    ("quote", "1.0.0", Some(29601), Active),
    ("link_llvm_intrinsics", "1.0.0", Some(29602), Active),
    ("linkage", "1.0.0", Some(29603), Active),
73 74 75 76
    ("struct_inherit", "1.0.0", None, Removed),

    ("quad_precision_float", "1.0.0", None, Removed),

A
Aaron Turon 已提交
77
    // rustc internal
78
    ("rustc_diagnostic_macros", "1.0.0", None, Active),
A
Aaron Turon 已提交
79 80
    ("unboxed_closures", "1.0.0", Some(29625), Active),
    ("reflect", "1.0.0", Some(27749), Active),
81
    ("import_shadowing", "1.0.0", None, Removed),
A
Aaron Turon 已提交
82
    ("advanced_slice_patterns", "1.0.0", Some(23121), Active),
83 84
    ("tuple_indexing", "1.0.0", None, Accepted),
    ("associated_types", "1.0.0", None, Accepted),
A
Aaron Turon 已提交
85
    ("visible_private_types", "1.0.0", Some(29627), Active),
86
    ("slicing_syntax", "1.0.0", None, Accepted),
87 88
    ("box_syntax", "1.0.0", Some(27779), Active),
    ("placement_in_syntax", "1.0.0", Some(27779), Active),
A
Aaron Turon 已提交
89 90

    // rustc internal.
91
    ("pushpop_unsafe", "1.2.0", None, Active),
A
Aaron Turon 已提交
92 93 94 95 96 97

    ("on_unimplemented", "1.0.0", Some(29628), Active),
    ("simd_ffi", "1.0.0", Some(27731), Active),
    ("allocator", "1.0.0", Some(27389), Active),
    ("needs_allocator", "1.4.0", Some(27389), Active),
    ("linked_from", "1.3.0", Some(29629), Active),
98 99 100 101

    ("if_let", "1.0.0", None, Accepted),
    ("while_let", "1.0.0", None, Accepted),

A
Aaron Turon 已提交
102 103 104
    ("plugin", "1.0.0", Some(29597), Active),
    ("start", "1.0.0", Some(29633), Active),
    ("main", "1.0.0", Some(29634), Active),
105

A
Aaron Turon 已提交
106
    ("fundamental", "1.0.0", Some(29635), Active),
107

108 109
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
110
    ("issue_5723_bootstrap", "1.0.0", None, Accepted),
111

112
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
113
    ("opt_out_copy", "1.0.0", None, Removed),
114

115
    // OIBIT specific features
A
Aaron Turon 已提交
116
    ("optin_builtin_traits", "1.0.0", Some(13231), Active),
117

J
Joseph Crail 已提交
118
    // macro reexport needs more discussion and stabilization
A
Aaron Turon 已提交
119
    ("macro_reexport", "1.0.0", Some(29638), Active),
120

121 122
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
123 124
    ("test_accepted_feature", "1.0.0", None, Accepted),
    ("test_removed_feature", "1.0.0", None, Removed),
125 126

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
127
    // rustc internal
128
    ("staged_api", "1.0.0", None, Active),
129 130

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
131
    // rustc internal
132
    ("unmarked_api", "1.0.0", None, Active),
K
Keegan McAllister 已提交
133 134

    // Allows using #![no_std]
135
    ("no_std", "1.0.0", None, Accepted),
136

A
Alex Crichton 已提交
137
    // Allows using #![no_core]
A
Aaron Turon 已提交
138
    ("no_core", "1.3.0", Some(29639), Active),
A
Alex Crichton 已提交
139

140
    // Allows using `box` in patterns; RFC 469
A
Aaron Turon 已提交
141
    ("box_patterns", "1.0.0", Some(29641), Active),
142

143 144
    // Allows using the unsafe_no_drop_flag attribute (unlikely to
    // switch to Accepted; see RFC 320)
145
    ("unsafe_no_drop_flag", "1.0.0", None, Active),
146

147 148 149
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
    ("dropck_parametricity", "1.3.0", Some(28498), Active),
150

151
    // Allows the use of custom attributes; RFC 572
A
Aaron Turon 已提交
152
    ("custom_attribute", "1.0.0", Some(29642), Active),
M
Manish Goregaokar 已提交
153

154 155
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
A
Aaron Turon 已提交
156
    ("custom_derive", "1.0.0", Some(29644), Active),
157

M
Manish Goregaokar 已提交
158
    // Allows the use of rustc_* attributes; RFC 572
A
Aaron Turon 已提交
159
    ("rustc_attrs", "1.0.0", Some(29642), Active),
H
Huon Wilson 已提交
160

161 162 163 164
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
165 166
    //
    // rustc internal
167
    ("allow_internal_unstable", "1.0.0", None, Active),
168 169

    // #23121. Array patterns have some hazards yet.
A
Aaron Turon 已提交
170
    ("slice_patterns", "1.0.0", Some(23121), Active),
171 172

    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
A
Aaron Turon 已提交
173
    ("negate_unsigned", "1.0.0", Some(29645), Active),
174 175 176

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
A
Aaron Turon 已提交
177
    ("associated_consts", "1.0.0", Some(29646), Active),
N
Niko Matsakis 已提交
178 179

    // Allows the definition of `const fn` functions.
A
Aaron Turon 已提交
180
    ("const_fn", "1.2.0", Some(24111), Active),
181

182 183 184
    // Allows indexing into constant arrays.
    ("const_indexing", "1.4.0", Some(29947), Active),

185
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
186 187
    //
    // rustc internal
188
    ("prelude_import", "1.2.0", None, Active),
189 190

    // Allows the definition recursive static items.
A
Aaron Turon 已提交
191
    ("static_recursion", "1.3.0", Some(29719), Active),
B
Brian Anderson 已提交
192 193

    // Allows default type parameters to influence type inference.
A
Aaron Turon 已提交
194
    ("default_type_parameter_fallback", "1.3.0", Some(27336), Active),
195 196

    // Allows associated type defaults
A
Aaron Turon 已提交
197
    ("associated_type_defaults", "1.2.0", Some(29661), Active),
J
Jared Roesch 已提交
198

A
Aaron Turon 已提交
199
    // Allows macros to appear in the type position.
200
    ("type_macros", "1.3.0", Some(27336), Active),
201 202

    // allow `repr(simd)`, and importing the various simd intrinsics
203
    ("repr_simd", "1.4.0", Some(27731), Active),
204 205

    // Allows cfg(target_feature = "...").
A
Aaron Turon 已提交
206
    ("cfg_target_feature", "1.4.0", Some(29717), Active),
207 208

    // allow `extern "platform-intrinsic" { ... }`
209
    ("platform_intrinsics", "1.4.0", Some(27731), Active),
210 211

    // allow `#[unwind]`
A
Aaron Turon 已提交
212
    // rust runtime internal
213
    ("unwind_attributes", "1.4.0", None, Active),
V
Vadim Petrochenkov 已提交
214

215
    // allow empty structs and enum variants with braces
A
Aaron Turon 已提交
216
    ("braced_empty_structs", "1.5.0", Some(29720), Active),
217 218

    // allow overloading augmented assignment operations like `a += b`
A
Aaron Turon 已提交
219
    ("augmented_assignments", "1.5.0", Some(28235), Active),
220 221

    // allow `#[no_debug]`
A
Aaron Turon 已提交
222
    ("no_debug", "1.5.0", Some(29721), Active),
223 224

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
225
    // rustc internal.
226
    ("omit_gdb_pretty_printer_section", "1.5.0", None, Active),
227 228

    // Allows cfg(target_vendor = "...").
A
Aaron Turon 已提交
229
    ("cfg_target_vendor", "1.5.0", Some(29718), Active),
230 231 232

    // Allow attributes on expressions and non-item statements
    ("stmt_expr_attributes", "1.6.0", Some(15701), Active),
233 234 235

    // Allows `#[deprecated]` attribute
    ("deprecated", "1.6.0", Some(29935), Active),
236
];
237
// (changing above list without updating src/doc/reference.md makes @cmr sad)
238 239 240 241 242 243 244 245 246 247 248 249 250

enum Status {
    /// Represents an active feature that is currently being implemented or
    /// currently being considered for addition/removal.
    Active,

    /// Represents a feature which has since been removed (it was once Active)
    Removed,

    /// This language feature has since been Accepted (it was once Active)
    Accepted,
}

251
// Attributes that have a special meaning to rustc or rustdoc
252
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
253 254
    // Normal attributes

255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
285

A
Alex Crichton 已提交
286
    // Not used any more, but we can't feature gate it
287 288 289 290 291
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
                                  and possibly buggy")),
292
    ("no_std", CrateLevel, Ungated),
293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316
    ("no_core", CrateLevel, Gated("no_core",
                                  "no_core is experimental")),
    ("lang", Normal, Gated("lang_items",
                           "language items are subject to change")),
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
                                    and not portable across platforms")),
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
                                         model")),

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
                                              is an experimental feature")),
    ("allocator", Whitelisted, Gated("allocator",
                                     "the `#[allocator]` attribute is an experimental feature")),
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
                                       feature")),
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
317 318
                                      is just used for rustc unit tests \
                                      and will never be stable")),
319 320
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
321 322
                                        is just used for rustc unit tests \
                                        and will never be stable")),
323 324
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
325 326 327 328 329 330
                                            is just used for rustc unit tests \
                                            and will never be stable")),
    ("rustc_mir", Normal, Gated("rustc_attrs",
                                "the `#[rustc_mir]` attribute \
                                 is just used for rustc unit tests \
                                 and will never be stable")),
331 332 333 334 335 336 337 338 339 340 341

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE)),

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
                                        is an experimental feature")),

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
                                   is an experimental feature")),
342

343
    // FIXME: #14408 whitelist docs since rustdoc looks at them
344
    ("doc", Whitelisted, Ungated),
345 346 347

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
348 349 350 351 352 353 354 355
    ("cold", Whitelisted, Ungated),
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
356 357 358 359 360 361 362
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
                                     is an experimental feature")),
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
                                                        suite")),
363 364 365
    ("unsafe_no_drop_flag", Whitelisted, Gated("unsafe_no_drop_flag",
                                               "unsafe_no_drop_flag has unstable semantics \
                                                and may be removed in the future")),
366 367
    ("unsafe_destructor_blind_to_params",
     Normal,
368
     Gated("dropck_parametricity",
369 370
           "unsafe_destructor_blind_to_params has unstable semantics \
            and may be removed in the future")),
371
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental")),
372 373

    // used in resolve
374 375
    ("prelude_import", Whitelisted, Gated("prelude_import",
                                          "`#[prelude_import]` is for use by rustc only")),
376 377 378

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
379
    ("rustc_deprecated", Whitelisted, Ungated),
380 381 382
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
V
Vadim Petrochenkov 已提交
383
    ("deprecated", Normal, Gated("deprecated", "`#[deprecated]` attribute is unstable")),
384

385 386 387 388
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
                                        "unboxed_closures are still evolving")),
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
                                              "defining reflective traits is still evolving")),
389 390

    // Crate level attributes
391 392 393 394 395 396 397 398
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
399 400
];

401 402 403 404 405 406 407 408 409 410 411 412
macro_rules! cfg_fn {
    (|$x: ident| $e: expr) => {{
        fn f($x: &Features) -> bool {
            $e
        }
        f as fn(&Features) -> bool
    }}
}
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
    ("target_feature", "cfg_target_feature", cfg_fn!(|x| x.cfg_target_feature)),
413
    ("target_vendor", "cfg_target_vendor", cfg_fn!(|x| x.cfg_target_vendor)),
414 415
];

416 417 418 419 420 421
#[derive(Debug, Eq, PartialEq)]
pub enum GatedCfgAttr {
    GatedCfg(GatedCfg),
    GatedAttr(Span),
}

422 423 424 425 426
#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
427

428 429 430 431 432 433 434 435 436 437 438
impl Ord for GatedCfgAttr {
    fn cmp(&self, other: &GatedCfgAttr) -> cmp::Ordering {
        let to_tup = |s: &GatedCfgAttr| match *s {
            GatedCfgAttr::GatedCfg(ref gated_cfg) => {
                (gated_cfg.span.lo.0, gated_cfg.span.hi.0, gated_cfg.index)
            }
            GatedCfgAttr::GatedAttr(ref span) => {
                (span.lo.0, span.hi.0, GATED_CFGS.len())
            }
        };
        to_tup(self).cmp(&to_tup(other))
439 440
    }
}
441

442 443
impl PartialOrd for GatedCfgAttr {
    fn partial_cmp(&self, other: &GatedCfgAttr) -> Option<cmp::Ordering> {
444 445 446 447
        Some(self.cmp(other))
    }
}

448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466
impl GatedCfgAttr {
    pub fn check_and_emit(&self, diagnostic: &SpanHandler, features: &Features) {
        match *self {
            GatedCfgAttr::GatedCfg(ref cfg) => {
                cfg.check_and_emit(diagnostic, features);
            }
            GatedCfgAttr::GatedAttr(span) => {
                if !features.stmt_expr_attributes {
                    emit_feature_err(diagnostic,
                                     "stmt_expr_attributes",
                                     span,
                                     GateIssue::Language,
                                     EXPLAIN_STMT_ATTR_SYNTAX);
                }
            }
        }
    }
}

467 468 469 470 471 472 473 474 475 476 477 478
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
479
    fn check_and_emit(&self, diagnostic: &SpanHandler, features: &Features) {
480 481 482
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
        if !has_feature(features) {
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
483
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
484 485 486 487 488
        }
    }
}


N
Niko Matsakis 已提交
489
#[derive(PartialEq, Copy, Clone, Debug)]
490 491 492 493 494 495 496 497 498 499
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,

    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,

500 501 502 503 504 505
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeGate {
M
Manish Goregaokar 已提交
506 507 508
    /// Is gated by a given feature gate and reason
    Gated(&'static str, &'static str),

509 510
    /// Ungated attribute, can be used on all release channels
    Ungated,
511 512
}

513 514
/// A set of features to be used by later passes.
pub struct Features {
515
    pub unboxed_closures: bool,
N
Nick Cameron 已提交
516
    pub rustc_diagnostic_macros: bool,
517
    pub visible_private_types: bool,
518 519
    pub allow_quote: bool,
    pub allow_asm: bool,
520 521 522
    pub allow_log_syntax: bool,
    pub allow_concat_idents: bool,
    pub allow_trace_macros: bool,
523
    pub allow_internal_unstable: bool,
524
    pub allow_custom_derive: bool,
525 526
    pub allow_placement_in: bool,
    pub allow_box: bool,
527
    pub allow_pushpop_unsafe: bool,
528
    pub simd_ffi: bool,
529
    pub unmarked_api: bool,
530
    pub negate_unsigned: bool,
531 532 533
    /// spans of #![feature] attrs for stable language features. for error reporting
    pub declared_stable_lang_features: Vec<Span>,
    /// #![feature] attrs for non-language (library) features
534 535
    pub declared_lib_features: Vec<(InternedString, Span)>,
    pub const_fn: bool,
536
    pub const_indexing: bool,
J
Jared Roesch 已提交
537 538
    pub static_recursion: bool,
    pub default_type_parameter_fallback: bool,
J
Jared Roesch 已提交
539
    pub type_macros: bool,
540
    pub cfg_target_feature: bool,
541
    pub cfg_target_vendor: bool,
542
    pub augmented_assignments: bool,
543
    pub braced_empty_structs: bool,
V
Vadim Petrochenkov 已提交
544
    pub staged_api: bool,
545
    pub stmt_expr_attributes: bool,
546
    pub deprecated: bool,
547 548 549 550 551
}

impl Features {
    pub fn new() -> Features {
        Features {
552
            unboxed_closures: false,
N
Nick Cameron 已提交
553
            rustc_diagnostic_macros: false,
554
            visible_private_types: false,
555 556
            allow_quote: false,
            allow_asm: false,
557 558 559
            allow_log_syntax: false,
            allow_concat_idents: false,
            allow_trace_macros: false,
560
            allow_internal_unstable: false,
561
            allow_custom_derive: false,
562 563
            allow_placement_in: false,
            allow_box: false,
564
            allow_pushpop_unsafe: false,
565
            simd_ffi: false,
566
            unmarked_api: false,
567
            negate_unsigned: false,
568
            declared_stable_lang_features: Vec::new(),
569 570
            declared_lib_features: Vec::new(),
            const_fn: false,
571
            const_indexing: false,
J
Jared Roesch 已提交
572 573
            static_recursion: false,
            default_type_parameter_fallback: false,
J
Jared Roesch 已提交
574
            type_macros: false,
575
            cfg_target_feature: false,
576
            cfg_target_vendor: false,
577
            augmented_assignments: false,
578
            braced_empty_structs: false,
V
Vadim Petrochenkov 已提交
579
            staged_api: false,
580
            stmt_expr_attributes: false,
581
            deprecated: false,
582 583 584 585
        }
    }
}

586 587 588 589 590 591 592 593 594
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";

const EXPLAIN_PUSHPOP_UNSAFE: &'static str =
    "push/pop_unsafe macros are experimental and subject to change.";

595 596 597
const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
    "attributes on non-item statements and expressions are experimental.";

598 599 600 601
pub fn check_for_box_syntax(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_box: true, .. }) = f {
        return;
    }
602
    emit_feature_err(diag, "box_syntax", span, GateIssue::Language, EXPLAIN_BOX_SYNTAX);
603 604 605 606 607 608
}

pub fn check_for_placement_in(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_placement_in: true, .. }) = f {
        return;
    }
609
    emit_feature_err(diag, "placement_in_syntax", span, GateIssue::Language, EXPLAIN_PLACEMENT_IN);
610 611
}

612 613 614 615
pub fn check_for_pushpop_syntax(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_pushpop_unsafe: true, .. }) = f {
        return;
    }
616
    emit_feature_err(diag, "pushpop_unsafe", span, GateIssue::Language, EXPLAIN_PUSHPOP_UNSAFE);
617 618
}

E
Eduard Burtescu 已提交
619 620
struct Context<'a> {
    features: Vec<&'static str>,
N
Nick Cameron 已提交
621
    span_handler: &'a SpanHandler,
C
Corey Richardson 已提交
622
    cm: &'a CodeMap,
623
    plugin_attributes: &'a [(String, AttributeType)],
624 625
}

E
Eduard Burtescu 已提交
626
impl<'a> Context<'a> {
627 628 629 630 631
    fn enable_feature(&mut self, feature: &'static str) {
        debug!("enabling feature: {}", feature);
        self.features.push(feature);
    }

632
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
633 634 635
        let has_feature = self.has_feature(feature);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", feature, span, has_feature);
        if !has_feature {
636
            emit_feature_err(self.span_handler, feature, span, GateIssue::Language, explain);
637 638
        }
    }
639
    fn has_feature(&self, feature: &str) -> bool {
640
        self.features.iter().any(|&n| n == feature)
641
    }
642

643
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
644 645
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
646
        for &(n, ty, gateage) in KNOWN_ATTRIBUTES {
647
            if n == name {
648
                if let Gated(gate, desc) = gateage {
649 650
                    self.gate_feature(gate, attr.span, desc);
                }
651
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
652 653 654
                return;
            }
        }
655
        for &(ref n, ref ty) in self.plugin_attributes {
656 657
            if &*n == name {
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
658 659
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
660 661 662 663
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
664 665 666 667 668
        if name.starts_with("rustc_") {
            self.gate_feature("rustc_attrs", attr.span,
                              "unless otherwise specified, attributes \
                               with the prefix `rustc_` \
                               are reserved for internal compiler diagnostics");
669 670
        } else if name.starts_with("derive_") {
            self.gate_feature("custom_derive", attr.span,
671
                              "attributes of the form `#[derive_*]` are reserved \
672
                               for the compiler");
673
        } else {
M
Manish Goregaokar 已提交
674 675 676 677
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
678 679 680 681 682 683 684 685
            if !is_macro {
                self.gate_feature("custom_attribute", attr.span,
                           &format!("The attribute `{}` is currently \
                                    unknown to the compiler and \
                                    may have meaning \
                                    added to it in the future",
                                    name));
            }
686 687
        }
    }
688 689
}

690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
    let info = KNOWN_FEATURES.iter()
                              .find(|t| t.0 == feature)
                              .unwrap();
    let issue = info.2;
    if let Active = info.3 {
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
    }
    issue
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

pub fn emit_feature_err(diag: &SpanHandler, feature: &str, span: Span, issue: GateIssue,
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

    if let Some(n) = issue {
        diag.span_err(span, &format!("{} (see issue #{})", explain, n));
    } else {
        diag.span_err(span, explain);
    }
719 720

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
721
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() { return; }
722
    diag.fileline_help(span, &format!("add #![feature({})] to the \
723
                                   crate attributes to enable",
724
                                  feature));
725 726
}

727 728 729
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

730 731 732 733 734 735 736 737
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
738 739
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
740

741 742 743
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

C
Corey Richardson 已提交
744 745 746 747 748
struct MacroVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a, 'v> Visitor<'v> for MacroVisitor<'a> {
K
Keegan McAllister 已提交
749
    fn visit_mac(&mut self, mac: &ast::Mac) {
750
        let path = &mac.node.path;
751
        let name = path.segments.last().unwrap().identifier.name.as_str();
C
Corey Richardson 已提交
752

753 754 755 756 757 758 759 760
        // Issue 22234: If you add a new case here, make sure to also
        // add code to catch the macro during or after expansion.
        //
        // We still keep this MacroVisitor (rather than *solely*
        // relying on catching cases during or after expansion) to
        // catch uses of these macros within conditionally-compiled
        // code, e.g. `#[cfg]`-guarded functions.

761
        if name == "asm" {
762
            self.context.gate_feature("asm", path.span, EXPLAIN_ASM);
C
Corey Richardson 已提交
763 764
        }

765
        else if name == "log_syntax" {
766
            self.context.gate_feature("log_syntax", path.span, EXPLAIN_LOG_SYNTAX);
C
Corey Richardson 已提交
767 768
        }

769
        else if name == "trace_macros" {
770
            self.context.gate_feature("trace_macros", path.span, EXPLAIN_TRACE_MACROS);
C
Corey Richardson 已提交
771 772
        }

773
        else if name == "concat_idents" {
774
            self.context.gate_feature("concat_idents", path.span, EXPLAIN_CONCAT_IDENTS);
C
Corey Richardson 已提交
775 776
        }
    }
777 778

    fn visit_attribute(&mut self, attr: &'v ast::Attribute) {
779
        self.context.check_attribute(attr, true);
780
    }
781 782 783 784 785 786 787 788 789 790

    fn visit_expr(&mut self, e: &ast::Expr) {
        // Issue 22181: overloaded-`box` and placement-`in` are
        // implemented via a desugaring expansion, so their feature
        // gates go into MacroVisitor since that works pre-expansion.
        //
        // Issue 22234: we also check during expansion as well.
        // But we keep these checks as a pre-expansion check to catch
        // uses in e.g. conditionalized code.

791
        if let ast::ExprBox(_) = e.node {
792 793 794
            self.context.gate_feature("box_syntax", e.span, EXPLAIN_BOX_SYNTAX);
        }

795
        if let ast::ExprInPlace(..) = e.node {
796 797 798 799 800
            self.context.gate_feature("placement_in_syntax", e.span, EXPLAIN_PLACEMENT_IN);
        }

        visit::walk_expr(self, e);
    }
C
Corey Richardson 已提交
801 802 803
}

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
804
    context: &'a Context<'a>,
C
Corey Richardson 已提交
805 806 807 808
}

impl<'a> PostExpansionVisitor<'a> {
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
809
        if !self.context.cm.span_allows_unstable(span) {
C
Corey Richardson 已提交
810 811 812 813 814 815
            self.context.gate_feature(feature, span, explain)
        }
    }
}

impl<'a, 'v> Visitor<'v> for PostExpansionVisitor<'a> {
816 817
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
818
            self.context.check_attribute(attr, false);
819 820 821
        }
    }

822
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
823
        if !name.as_str().is_ascii() {
824 825 826 827 828
            self.gate_feature("non_ascii_idents", sp,
                              "non-ascii idents are not fully supported.");
        }
    }

829
    fn visit_item(&mut self, i: &ast::Item) {
830
        match i.node {
831
            ast::ItemExternCrate(_) => {
832
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
833 834 835
                    self.gate_feature("macro_reexport", i.span,
                                      "macros reexports are experimental \
                                       and possibly buggy");
836 837 838
                }
            }

839
            ast::ItemForeignMod(ref foreign_module) => {
840
                if attr::contains_name(&i.attrs[..], "link_args") {
841 842 843 844 845
                    self.gate_feature("link_args", i.span,
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
846 847 848 849 850 851 852 853 854 855
                let maybe_feature = match foreign_module.abi {
                    Abi::RustIntrinsic => Some(("intrinsics", "intrinsics are subject to change")),
                    Abi::PlatformIntrinsic => {
                        Some(("platform_intrinsics",
                              "platform intrinsics are experimental and possibly buggy"))
                    }
                    _ => None
                };
                if let Some((feature, msg)) = maybe_feature {
                    self.gate_feature(feature, i.span, msg)
856
                }
857 858
            }

859
            ast::ItemFn(..) => {
860
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
861 862
                    self.gate_feature("plugin_registrar", i.span,
                                      "compiler plugins are experimental and possibly buggy");
863
                }
864
                if attr::contains_name(&i.attrs[..], "start") {
865 866 867 868 869
                    self.gate_feature("start", i.span,
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
870
                if attr::contains_name(&i.attrs[..], "main") {
871 872 873 874 875
                    self.gate_feature("main", i.span,
                                      "declaration of a nonstandard #[main] \
                                       function may change over time, for now \
                                       a top-level `fn main()` is required");
                }
876 877
            }

878
            ast::ItemStruct(..) => {
879
                if attr::contains_name(&i.attrs[..], "simd") {
D
David Manescu 已提交
880 881
                    self.gate_feature("simd", i.span,
                                      "SIMD types are experimental and possibly buggy");
882 883 884 885 886 887 888 889
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
                            if item.name() == "simd" {
890
                                self.gate_feature("repr_simd", i.span,
891 892 893 894 895
                                                  "SIMD types are experimental and possibly buggy");

                            }
                        }
                    }
896
                }
D
David Manescu 已提交
897 898
            }

F
Flavio Percoco 已提交
899 900 901 902 903 904 905
            ast::ItemDefaultImpl(..) => {
                self.gate_feature("optin_builtin_traits",
                                  i.span,
                                  "default trait implementations are experimental \
                                   and possibly buggy");
            }

A
Alex Crichton 已提交
906
            ast::ItemImpl(_, polarity, _, _, _, _) => {
907 908 909 910 911 912 913 914 915
                match polarity {
                    ast::ImplPolarity::Negative => {
                        self.gate_feature("optin_builtin_traits",
                                          i.span,
                                          "negative trait bounds are not yet fully implemented; \
                                          use marker types for now");
                    },
                    _ => {}
                }
916 917
            }

918 919 920
            _ => {}
        }

921
        visit::walk_item(self, i);
922
    }
923

924
    fn visit_variant_data(&mut self, s: &'v ast::VariantData, _: ast::Ident,
925
                        _: &'v ast::Generics, _: ast::NodeId, span: Span) {
926
        if s.fields().is_empty() {
927
            if s.is_struct() {
928 929
                self.gate_feature("braced_empty_structs", span,
                                  "empty structs and enum variants with braces are unstable");
930
            } else if s.is_tuple() {
931 932 933
                self.context.span_handler.span_err(span, "empty tuple structs and enum variants \
                                                          are not allowed, use unit structs and \
                                                          enum variants instead");
934 935
                self.context.span_handler.span_help(span, "remove trailing `()` to make a unit \
                                                           struct or unit enum variant");
936 937 938 939 940
            }
        }
        visit::walk_struct_def(self, s)
    }

941
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
942
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
943
                                                                     "link_name") {
G
GuillaumeGomez 已提交
944
            Some(val) => val.starts_with("llvm."),
945 946 947 948 949 950 951
            _ => false
        };
        if links_to_llvm {
            self.gate_feature("link_llvm_intrinsics", i.span,
                              "linking to LLVM intrinsics is experimental");
        }

952
        visit::walk_foreign_item(self, i)
953 954
    }

955
    fn visit_expr(&mut self, e: &ast::Expr) {
956
        match e.node {
957
            ast::ExprBox(_) => {
958 959
                self.gate_feature("box_syntax",
                                  e.span,
960
                                  "box expression syntax is experimental; \
961 962
                                   you can call `Box::new` instead.");
            }
963 964
            _ => {}
        }
965
        visit::walk_expr(self, e);
966
    }
967

968
    fn visit_pat(&mut self, pattern: &ast::Pat) {
969 970 971 972 973 974
        match pattern.node {
            ast::PatVec(_, Some(_), ref last) if !last.is_empty() => {
                self.gate_feature("advanced_slice_patterns",
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
975
                                   `[0, ..xs, 0]`) are experimental")
976
            }
977 978 979 980 981
            ast::PatVec(..) => {
                self.gate_feature("slice_patterns",
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
982
            ast::PatBox(..) => {
983
                self.gate_feature("box_patterns",
984
                                  pattern.span,
985
                                  "box pattern syntax is experimental");
986
            }
987 988
            _ => {}
        }
989
        visit::walk_pat(self, pattern)
990 991
    }

992
    fn visit_fn(&mut self,
993
                fn_kind: FnKind<'v>,
994 995
                fn_decl: &'v ast::FnDecl,
                block: &'v ast::Block,
996
                span: Span,
997
                _node_id: NodeId) {
N
Niko Matsakis 已提交
998 999
        // check for const fn declarations
        match fn_kind {
1000
            FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
N
Niko Matsakis 已提交
1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
                self.gate_feature("const_fn", span, "const fn is unstable");
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1011
        match fn_kind {
1012
            FnKind::ItemFn(_, _, _, _, abi, _) if abi == Abi::RustIntrinsic => {
1013 1014 1015 1016
                self.gate_feature("intrinsics",
                                  span,
                                  "intrinsics are subject to change")
            }
1017 1018
            FnKind::ItemFn(_, _, _, _, abi, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) if abi == Abi::RustCall => {
N
Niko Matsakis 已提交
1019 1020 1021 1022
                self.gate_feature("unboxed_closures",
                                  span,
                                  "rust-call ABI is subject to change")
            }
1023 1024
            _ => {}
        }
1025
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1026
    }
1027 1028 1029 1030 1031 1032 1033 1034

    fn visit_trait_item(&mut self, ti: &'v ast::TraitItem) {
        match ti.node {
            ast::ConstTraitItem(..) => {
                self.gate_feature("associated_consts",
                                  ti.span,
                                  "associated constants are experimental")
            }
N
Niko Matsakis 已提交
1035 1036 1037 1038 1039
            ast::MethodTraitItem(ref sig, _) => {
                if sig.constness == ast::Constness::Const {
                    self.gate_feature("const_fn", ti.span, "const fn is unstable");
                }
            }
1040 1041 1042 1043
            ast::TypeTraitItem(_, Some(_)) => {
                self.gate_feature("associated_type_defaults", ti.span,
                                  "associated type defaults are unstable");
            }
1044 1045 1046 1047 1048 1049 1050
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

    fn visit_impl_item(&mut self, ii: &'v ast::ImplItem) {
        match ii.node {
1051
            ast::ImplItemKind::Const(..) => {
1052 1053 1054 1055
                self.gate_feature("associated_consts",
                                  ii.span,
                                  "associated constants are experimental")
            }
1056
            ast::ImplItemKind::Method(ref sig, _) => {
N
Niko Matsakis 已提交
1057 1058 1059 1060
                if sig.constness == ast::Constness::Const {
                    self.gate_feature("const_fn", ii.span, "const fn is unstable");
                }
            }
1061 1062 1063 1064
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1065 1066
}

1067 1068
fn check_crate_inner<F>(cm: &CodeMap, span_handler: &SpanHandler,
                        krate: &ast::Crate,
1069
                        plugin_attributes: &[(String, AttributeType)],
C
Corey Richardson 已提交
1070
                        check: F)
1071
                       -> Features
C
Corey Richardson 已提交
1072 1073
    where F: FnOnce(&mut Context, &ast::Crate)
{
1074
    let mut cx = Context {
1075
        features: Vec::new(),
N
Nick Cameron 已提交
1076
        span_handler: span_handler,
C
Corey Richardson 已提交
1077
        cm: cm,
1078
        plugin_attributes: plugin_attributes,
1079 1080
    };

1081
    let mut accepted_features = Vec::new();
N
Nick Cameron 已提交
1082 1083
    let mut unknown_features = Vec::new();

1084
    for attr in &krate.attrs {
S
Steven Fackler 已提交
1085
        if !attr.check_name("feature") {
1086 1087
            continue
        }
1088 1089 1090

        match attr.meta_item_list() {
            None => {
N
Nick Cameron 已提交
1091 1092
                span_handler.span_err(attr.span, "malformed feature attribute, \
                                                  expected #![feature(...)]");
1093 1094
            }
            Some(list) => {
1095
                for mi in list {
1096
                    let name = match mi.node {
1097
                        ast::MetaWord(ref word) => (*word).clone(),
1098
                        _ => {
N
Nick Cameron 已提交
1099 1100 1101
                            span_handler.span_err(mi.span,
                                                  "malformed feature, expected just \
                                                   one word");
1102 1103 1104
                            continue
                        }
                    };
1105
                    match KNOWN_FEATURES.iter()
1106 1107
                                        .find(|& &(n, _, _, _)| name == n) {
                        Some(&(name, _, _, Active)) => {
1108
                            cx.enable_feature(name);
1109
                        }
1110
                        Some(&(_, _, _, Removed)) => {
N
Nick Cameron 已提交
1111
                            span_handler.span_err(mi.span, "feature has been removed");
1112
                        }
1113
                        Some(&(_, _, _, Accepted)) => {
1114
                            accepted_features.push(mi.span);
1115 1116
                        }
                        None => {
1117
                            unknown_features.push((name, mi.span));
1118 1119 1120 1121 1122 1123 1124
                        }
                    }
                }
            }
        }
    }

C
Corey Richardson 已提交
1125
    check(&mut cx, krate);
1126

1127 1128 1129
    // FIXME (pnkfelix): Before adding the 99th entry below, change it
    // to a single-pass (instead of N calls to `.has_feature`).

1130
    Features {
1131
        unboxed_closures: cx.has_feature("unboxed_closures"),
N
Nick Cameron 已提交
1132
        rustc_diagnostic_macros: cx.has_feature("rustc_diagnostic_macros"),
1133
        visible_private_types: cx.has_feature("visible_private_types"),
1134 1135
        allow_quote: cx.has_feature("quote"),
        allow_asm: cx.has_feature("asm"),
1136 1137 1138
        allow_log_syntax: cx.has_feature("log_syntax"),
        allow_concat_idents: cx.has_feature("concat_idents"),
        allow_trace_macros: cx.has_feature("trace_macros"),
1139
        allow_internal_unstable: cx.has_feature("allow_internal_unstable"),
1140
        allow_custom_derive: cx.has_feature("custom_derive"),
1141 1142
        allow_placement_in: cx.has_feature("placement_in_syntax"),
        allow_box: cx.has_feature("box_syntax"),
1143
        allow_pushpop_unsafe: cx.has_feature("pushpop_unsafe"),
1144
        simd_ffi: cx.has_feature("simd_ffi"),
1145
        unmarked_api: cx.has_feature("unmarked_api"),
1146
        negate_unsigned: cx.has_feature("negate_unsigned"),
1147
        declared_stable_lang_features: accepted_features,
1148 1149
        declared_lib_features: unknown_features,
        const_fn: cx.has_feature("const_fn"),
1150
        const_indexing: cx.has_feature("const_indexing"),
J
Jared Roesch 已提交
1151
        static_recursion: cx.has_feature("static_recursion"),
J
Jared Roesch 已提交
1152
        default_type_parameter_fallback: cx.has_feature("default_type_parameter_fallback"),
J
Jared Roesch 已提交
1153
        type_macros: cx.has_feature("type_macros"),
1154
        cfg_target_feature: cx.has_feature("cfg_target_feature"),
1155
        cfg_target_vendor: cx.has_feature("cfg_target_vendor"),
1156
        augmented_assignments: cx.has_feature("augmented_assignments"),
1157
        braced_empty_structs: cx.has_feature("braced_empty_structs"),
V
Vadim Petrochenkov 已提交
1158
        staged_api: cx.has_feature("staged_api"),
1159
        stmt_expr_attributes: cx.has_feature("stmt_expr_attributes"),
1160
        deprecated: cx.has_feature("deprecated"),
1161
    }
1162
}
C
Corey Richardson 已提交
1163 1164

pub fn check_crate_macros(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
1165
-> Features {
1166
    check_crate_inner(cm, span_handler, krate, &[] as &'static [_],
C
Corey Richardson 已提交
1167 1168 1169
                      |ctx, krate| visit::walk_crate(&mut MacroVisitor { context: ctx }, krate))
}

1170
pub fn check_crate(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate,
1171 1172
                   plugin_attributes: &[(String, AttributeType)],
                   unstable: UnstableFeatures) -> Features
1173
{
1174 1175
    maybe_stage_features(span_handler, krate, unstable);

1176
    check_crate_inner(cm, span_handler, krate, plugin_attributes,
C
Corey Richardson 已提交
1177 1178 1179
                      |ctx, krate| visit::walk_crate(&mut PostExpansionVisitor { context: ctx },
                                                     krate))
}
1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190

#[derive(Clone, Copy)]
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1191
    /// features. As a result, this is always required for building Rust itself.
1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
    Cheat
}

fn maybe_stage_features(span_handler: &SpanHandler, krate: &ast::Crate,
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
                let ref msg = format!("#[feature] may not be used on the {} release channel",
                                      release_channel);
                span_handler.span_err(attr.span, msg);
            }
        }
    }
}