feature_gate.rs 28.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
//! This modules implements the gating necessary for preventing certain compiler
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

S
Steven Fackler 已提交
25
use self::Status::*;
26
use self::AttributeType::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
N
Nick Cameron 已提交
29 30 31 32
use ast::NodeId;
use ast;
use attr;
use attr::AttrMetaMethods;
C
Corey Richardson 已提交
33
use codemap::{CodeMap, Span};
N
Nick Cameron 已提交
34 35 36
use diagnostic::SpanHandler;
use visit;
use visit::Visitor;
37
use parse::token::{self, InternedString};
38

39 40
use std::ascii::AsciiExt;

B
Brian Anderson 已提交
41 42 43 44 45 46 47
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.
48
const KNOWN_FEATURES: &'static [(&'static str, &'static str, Status)] = &[
B
Brian Anderson 已提交
49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74
    ("globs", "1.0.0", Accepted),
    ("macro_rules", "1.0.0", Accepted),
    ("struct_variant", "1.0.0", Accepted),
    ("asm", "1.0.0", Active),
    ("managed_boxes", "1.0.0", Removed),
    ("non_ascii_idents", "1.0.0", Active),
    ("thread_local", "1.0.0", Active),
    ("link_args", "1.0.0", Active),
    ("plugin_registrar", "1.0.0", Active),
    ("log_syntax", "1.0.0", Active),
    ("trace_macros", "1.0.0", Active),
    ("concat_idents", "1.0.0", Active),
    ("intrinsics", "1.0.0", Active),
    ("lang_items", "1.0.0", Active),

    ("simd", "1.0.0", Active),
    ("default_type_params", "1.0.0", Accepted),
    ("quote", "1.0.0", Active),
    ("link_llvm_intrinsics", "1.0.0", Active),
    ("linkage", "1.0.0", Active),
    ("struct_inherit", "1.0.0", Removed),

    ("quad_precision_float", "1.0.0", Removed),

    ("rustc_diagnostic_macros", "1.0.0", Active),
    ("unboxed_closures", "1.0.0", Active),
75
    ("reflect", "1.0.0", Active),
76
    ("import_shadowing", "1.0.0", Removed),
B
Brian Anderson 已提交
77 78 79 80
    ("advanced_slice_patterns", "1.0.0", Active),
    ("tuple_indexing", "1.0.0", Accepted),
    ("associated_types", "1.0.0", Accepted),
    ("visible_private_types", "1.0.0", Active),
81
    ("slicing_syntax", "1.0.0", Accepted),
B
Brian Anderson 已提交
82 83 84
    ("box_syntax", "1.0.0", Active),
    ("on_unimplemented", "1.0.0", Active),
    ("simd_ffi", "1.0.0", Active),
85
    ("allocator", "1.0.0", Active),
B
Brian Anderson 已提交
86 87 88 89 90 91 92

    ("if_let", "1.0.0", Accepted),
    ("while_let", "1.0.0", Accepted),

    ("plugin", "1.0.0", Active),
    ("start", "1.0.0", Active),
    ("main", "1.0.0", Active),
93

94 95
    ("fundamental", "1.0.0", Active),

96
    // Deprecate after snapshot
97
    // SNAP 5520801
98 99
    ("unsafe_destructor", "1.0.0", Active),

100 101
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
B
Brian Anderson 已提交
102
    ("issue_5723_bootstrap", "1.0.0", Accepted),
103

104
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
B
Brian Anderson 已提交
105
    ("opt_out_copy", "1.0.0", Removed),
106

107
    // OIBIT specific features
B
Brian Anderson 已提交
108
    ("optin_builtin_traits", "1.0.0", Active),
109

J
Joseph Crail 已提交
110
    // macro reexport needs more discussion and stabilization
A
Alex Crichton 已提交
111
    ("macro_reexport", "1.0.0", Active),
112

113 114
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
B
Brian Anderson 已提交
115 116
    ("test_accepted_feature", "1.0.0", Accepted),
    ("test_removed_feature", "1.0.0", Removed),
117 118 119

    // Allows use of #[staged_api]
    ("staged_api", "1.0.0", Active),
120 121

    // Allows using items which are missing stability attributes
K
Keegan McAllister 已提交
122 123 124 125
    ("unmarked_api", "1.0.0", Active),

    // Allows using #![no_std]
    ("no_std", "1.0.0", Active),
126 127 128

    // Allows using `box` in patterns; RFC 469
    ("box_patterns", "1.0.0", Active),
129

130 131 132
    // Allows using the unsafe_no_drop_flag attribute (unlikely to
    // switch to Accepted; see RFC 320)
    ("unsafe_no_drop_flag", "1.0.0", Active),
133 134

    // Allows the use of custom attributes; RFC 572
M
Manish Goregaokar 已提交
135 136
    ("custom_attribute", "1.0.0", Active),

137 138 139 140
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
    ("custom_derive", "1.0.0", Active),

M
Manish Goregaokar 已提交
141 142
    // Allows the use of rustc_* attributes; RFC 572
    ("rustc_attrs", "1.0.0", Active),
H
Huon Wilson 已提交
143 144 145

    // Allows the use of `static_assert`
    ("static_assert", "1.0.0", Active),
146 147 148 149 150 151

    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
    ("allow_internal_unstable", "1.0.0", Active),
152 153 154

    // #23121. Array patterns have some hazards yet.
    ("slice_patterns", "1.0.0", Active),
155 156 157

    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    ("negate_unsigned", "1.0.0", Active),
158
];
159
// (changing above list without updating src/doc/reference.md makes @cmr sad)
160 161 162 163 164 165 166 167 168 169 170 171 172

enum Status {
    /// Represents an active feature that is currently being implemented or
    /// currently being considered for addition/removal.
    Active,

    /// Represents a feature which has since been removed (it was once Active)
    Removed,

    /// This language feature has since been Accepted (it was once Active)
    Accepted,
}

173
// Attributes that have a special meaning to rustc or rustdoc
174
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType)] = &[
175 176 177 178 179 180 181 182 183 184 185 186 187
    // Normal attributes

    ("warn", Normal),
    ("allow", Normal),
    ("forbid", Normal),
    ("deny", Normal),

    ("macro_reexport", Normal),
    ("macro_use", Normal),
    ("macro_export", Normal),
    ("plugin_registrar", Normal),

    ("cfg", Normal),
188
    ("cfg_attr", Normal),
189 190 191 192 193 194 195 196 197 198 199 200
    ("main", Normal),
    ("start", Normal),
    ("test", Normal),
    ("bench", Normal),
    ("simd", Normal),
    ("repr", Normal),
    ("path", Normal),
    ("abi", Normal),
    ("automatically_derived", Normal),
    ("no_mangle", Normal),
    ("no_link", Normal),
    ("derive", Normal),
S
Steven Fackler 已提交
201
    ("should_panic", Normal),
202 203 204 205 206
    ("ignore", Normal),
    ("no_implicit_prelude", Normal),
    ("reexport_test_harness_main", Normal),
    ("link_args", Normal),
    ("macro_escape", Normal),
207

208 209
    ("unsafe_destructor", Gated("unsafe_destructor",
                                "`#[unsafe_destructor]` does nothing anymore")),
M
Manish Goregaokar 已提交
210 211 212 213 214 215 216 217 218
    ("staged_api", Gated("staged_api",
                         "staged_api is for use by rustc only")),
    ("plugin", Gated("plugin",
                     "compiler plugins are experimental \
                      and possibly buggy")),
    ("no_std", Gated("no_std",
                     "no_std is experimental")),
    ("lang", Gated("lang_items",
                     "language items are subject to change")),
219 220 221 222 223 224 225
    ("linkage", Gated("linkage",
                      "the `linkage` attribute is experimental \
                       and not portable across platforms")),
    ("thread_local", Gated("thread_local",
                            "`#[thread_local]` is an experimental feature, and does not \
                             currently handle destructors. There is no corresponding \
                             `#[task_local]` mapping to the task model")),
M
Manish Goregaokar 已提交
226

M
Manish Goregaokar 已提交
227 228 229
    ("rustc_on_unimplemented", Gated("on_unimplemented",
                                     "the `#[rustc_on_unimplemented]` attribute \
                                      is an experimental feature")),
230 231
    ("allocator", Gated("allocator",
                        "the `#[allocator]` attribute is an experimental feature")),
M
Manish Goregaokar 已提交
232 233 234 235 236 237 238 239 240 241
    ("rustc_variance", Gated("rustc_attrs",
                             "the `#[rustc_variance]` attribute \
                              is an experimental feature")),
    ("rustc_error", Gated("rustc_attrs",
                          "the `#[rustc_error]` attribute \
                           is an experimental feature")),
    ("rustc_move_fragments", Gated("rustc_attrs",
                                   "the `#[rustc_move_fragments]` attribute \
                                    is an experimental feature")),

242 243 244
    ("allow_internal_unstable", Gated("allow_internal_unstable",
                                      EXPLAIN_ALLOW_INTERNAL_UNSTABLE)),

245 246 247 248
    ("fundamental", Gated("fundamental",
                          "the `#[fundamental]` attribute \
                           is an experimental feature")),

249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
    // FIXME: #14408 whitelist docs since rustdoc looks at them
    ("doc", Whitelisted),

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
    ("cold", Whitelisted),
    ("export_name", Whitelisted),
    ("inline", Whitelisted),
    ("link", Whitelisted),
    ("link_name", Whitelisted),
    ("link_section", Whitelisted),
    ("no_builtins", Whitelisted),
    ("no_mangle", Whitelisted),
    ("no_stack_check", Whitelisted),
    ("packed", Whitelisted),
H
Huon Wilson 已提交
264 265
    ("static_assert", Gated("static_assert",
                            "`#[static_assert]` is an experimental feature, and has a poor API")),
266 267
    ("no_debug", Whitelisted),
    ("omit_gdb_pretty_printer_section", Whitelisted),
268 269 270
    ("unsafe_no_drop_flag", Gated("unsafe_no_drop_flag",
                                  "unsafe_no_drop_flag has unstable semantics \
                                   and may be removed in the future")),
271 272 273 274 275 276 277 278 279 280 281

    // used in resolve
    ("prelude_import", Whitelisted),

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
    ("deprecated", Whitelisted),
    ("must_use", Whitelisted),
    ("stable", Whitelisted),
    ("unstable", Whitelisted),

282 283 284 285
    ("rustc_paren_sugar", Gated("unboxed_closures",
                                "unboxed_closures are still evolving")),
    ("rustc_reflect_like", Gated("reflect",
                                 "defining reflective traits is still evolving")),
286 287 288 289

    // Crate level attributes
    ("crate_name", CrateLevel),
    ("crate_type", CrateLevel),
290
    ("crate_id", CrateLevel),
291 292 293 294
    ("feature", CrateLevel),
    ("no_start", CrateLevel),
    ("no_main", CrateLevel),
    ("no_builtins", CrateLevel),
295
    ("recursion_limit", CrateLevel),
296 297
];

N
Niko Matsakis 已提交
298
#[derive(PartialEq, Copy, Clone, Debug)]
299 300 301 302 303 304 305 306 307 308
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,

    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,

M
Manish Goregaokar 已提交
309 310 311 312
    /// Is gated by a given feature gate and reason
    /// These get whitelisted too
    Gated(&'static str, &'static str),

313 314 315 316
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

317 318
/// A set of features to be used by later passes.
pub struct Features {
319
    pub unboxed_closures: bool,
N
Nick Cameron 已提交
320
    pub rustc_diagnostic_macros: bool,
321
    pub visible_private_types: bool,
322 323
    pub allow_quote: bool,
    pub allow_asm: bool,
324 325 326
    pub allow_log_syntax: bool,
    pub allow_concat_idents: bool,
    pub allow_trace_macros: bool,
327
    pub allow_internal_unstable: bool,
328
    pub allow_custom_derive: bool,
329
    pub simd_ffi: bool,
330
    pub unmarked_api: bool,
331
    pub negate_unsigned: bool,
332 333 334 335
    /// spans of #![feature] attrs for stable language features. for error reporting
    pub declared_stable_lang_features: Vec<Span>,
    /// #![feature] attrs for non-language (library) features
    pub declared_lib_features: Vec<(InternedString, Span)>
336 337 338 339 340
}

impl Features {
    pub fn new() -> Features {
        Features {
341
            unboxed_closures: false,
N
Nick Cameron 已提交
342
            rustc_diagnostic_macros: false,
343
            visible_private_types: false,
344 345
            allow_quote: false,
            allow_asm: false,
346 347 348
            allow_log_syntax: false,
            allow_concat_idents: false,
            allow_trace_macros: false,
349
            allow_internal_unstable: false,
350
            allow_custom_derive: false,
351
            simd_ffi: false,
352
            unmarked_api: false,
353
            negate_unsigned: false,
354 355
            declared_stable_lang_features: Vec::new(),
            declared_lib_features: Vec::new()
356 357 358 359
        }
    }
}

E
Eduard Burtescu 已提交
360 361
struct Context<'a> {
    features: Vec<&'static str>,
N
Nick Cameron 已提交
362
    span_handler: &'a SpanHandler,
C
Corey Richardson 已提交
363
    cm: &'a CodeMap,
364 365
}

E
Eduard Burtescu 已提交
366
impl<'a> Context<'a> {
367
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
368 369 370
        let has_feature = self.has_feature(feature);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", feature, span, has_feature);
        if !has_feature {
371
            emit_feature_err(self.span_handler, feature, span, explain);
372 373
        }
    }
374
    fn has_feature(&self, feature: &str) -> bool {
375
        self.features.iter().any(|&n| n == feature)
376
    }
377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394

    fn check_attribute(&self, attr: &ast::Attribute) {
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
        for &(n, ty) in KNOWN_ATTRIBUTES {
            if n == name {
                if let Gated(gate, desc) = ty {
                    self.gate_feature(gate, attr.span, desc);
                }
                debug!("check_attribute: {:?} is known, {:?}", name, ty);
                return;
            }
        }
        if name.starts_with("rustc_") {
            self.gate_feature("rustc_attrs", attr.span,
                              "unless otherwise specified, attributes \
                               with the prefix `rustc_` \
                               are reserved for internal compiler diagnostics");
395 396 397 398
        } else if name.starts_with("derive_") {
            self.gate_feature("custom_derive", attr.span,
                              "attributes of the form `#[derive_*]` are reserved
                               for the compiler");
399 400
        } else {
            self.gate_feature("custom_attribute", attr.span,
401
                       &format!("The attribute `{}` is currently \
402 403 404
                                unknown to the the compiler and \
                                may have meaning \
                                added to it in the future",
405
                                name));
406 407
        }
    }
408 409
}

410 411
pub fn emit_feature_err(diag: &SpanHandler, feature: &str, span: Span, explain: &str) {
    diag.span_err(span, explain);
412 413 414 415 416 417

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
    match option_env!("CFG_RELEASE_CHANNEL") {
        Some("stable") | Some("beta") => return,
        _ => {}
    }
418
    diag.fileline_help(span, &format!("add #![feature({})] to the \
419
                                   crate attributes to enable",
420
                                  feature));
421 422
}

B
Brian Anderson 已提交
423 424
pub fn emit_feature_warn(diag: &SpanHandler, feature: &str, span: Span, explain: &str) {
    diag.span_warn(span, explain);
425 426 427 428 429 430

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
    match option_env!("CFG_RELEASE_CHANNEL") {
        Some("stable") | Some("beta") => return,
        _ => {}
    }
431
    if diag.handler.can_emit_warnings {
432
        diag.fileline_help(span, &format!("add #![feature({})] to the \
433
                                       crate attributes to silence this warning",
434
                                      feature));
435
    }
B
Brian Anderson 已提交
436 437
}

438 439 440
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

441 442 443 444 445 446 447 448
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
449 450
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
451

452 453 454
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

C
Corey Richardson 已提交
455 456 457 458 459
struct MacroVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a, 'v> Visitor<'v> for MacroVisitor<'a> {
K
Keegan McAllister 已提交
460 461
    fn visit_mac(&mut self, mac: &ast::Mac) {
        let ast::MacInvocTT(ref path, _, _) = mac.node;
C
Corey Richardson 已提交
462 463
        let id = path.segments.last().unwrap().identifier;

464 465 466 467 468 469 470 471
        // Issue 22234: If you add a new case here, make sure to also
        // add code to catch the macro during or after expansion.
        //
        // We still keep this MacroVisitor (rather than *solely*
        // relying on catching cases during or after expansion) to
        // catch uses of these macros within conditionally-compiled
        // code, e.g. `#[cfg]`-guarded functions.

K
Keegan McAllister 已提交
472
        if id == token::str_to_ident("asm") {
473
            self.context.gate_feature("asm", path.span, EXPLAIN_ASM);
C
Corey Richardson 已提交
474 475 476
        }

        else if id == token::str_to_ident("log_syntax") {
477
            self.context.gate_feature("log_syntax", path.span, EXPLAIN_LOG_SYNTAX);
C
Corey Richardson 已提交
478 479 480
        }

        else if id == token::str_to_ident("trace_macros") {
481
            self.context.gate_feature("trace_macros", path.span, EXPLAIN_TRACE_MACROS);
C
Corey Richardson 已提交
482 483 484
        }

        else if id == token::str_to_ident("concat_idents") {
485
            self.context.gate_feature("concat_idents", path.span, EXPLAIN_CONCAT_IDENTS);
C
Corey Richardson 已提交
486 487
        }
    }
488 489

    fn visit_attribute(&mut self, attr: &'v ast::Attribute) {
490
        self.context.check_attribute(attr);
491
    }
C
Corey Richardson 已提交
492 493 494 495 496 497 498 499
}

struct PostExpansionVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a> PostExpansionVisitor<'a> {
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
500
        if !self.context.cm.span_allows_unstable(span) {
C
Corey Richardson 已提交
501 502 503 504 505 506
            self.context.gate_feature(feature, span, explain)
        }
    }
}

impl<'a, 'v> Visitor<'v> for PostExpansionVisitor<'a> {
507 508 509 510 511 512
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
            self.context.check_attribute(attr);
        }
    }

513
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
G
GuillaumeGomez 已提交
514
        if !token::get_name(name).is_ascii() {
515 516 517 518 519
            self.gate_feature("non_ascii_idents", sp,
                              "non-ascii idents are not fully supported.");
        }
    }

520
    fn visit_item(&mut self, i: &ast::Item) {
521
        match i.node {
522
            ast::ItemExternCrate(_) => {
523
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
524 525 526
                    self.gate_feature("macro_reexport", i.span,
                                      "macros reexports are experimental \
                                       and possibly buggy");
527 528 529
                }
            }

530
            ast::ItemForeignMod(ref foreign_module) => {
531
                if attr::contains_name(&i.attrs[..], "link_args") {
532 533 534 535 536
                    self.gate_feature("link_args", i.span,
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
N
Niko Matsakis 已提交
537
                if foreign_module.abi == Abi::RustIntrinsic {
538 539 540 541
                    self.gate_feature("intrinsics",
                                      i.span,
                                      "intrinsics are subject to change")
                }
542 543
            }

544
            ast::ItemFn(..) => {
545
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
546 547
                    self.gate_feature("plugin_registrar", i.span,
                                      "compiler plugins are experimental and possibly buggy");
548
                }
549
                if attr::contains_name(&i.attrs[..], "start") {
550 551 552 553 554
                    self.gate_feature("start", i.span,
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
555
                if attr::contains_name(&i.attrs[..], "main") {
556 557 558 559 560
                    self.gate_feature("main", i.span,
                                      "declaration of a nonstandard #[main] \
                                       function may change over time, for now \
                                       a top-level `fn main()` is required");
                }
561 562
            }

563
            ast::ItemStruct(..) => {
564
                if attr::contains_name(&i.attrs[..], "simd") {
D
David Manescu 已提交
565 566
                    self.gate_feature("simd", i.span,
                                      "SIMD types are experimental and possibly buggy");
567
                }
D
David Manescu 已提交
568 569
            }

F
Flavio Percoco 已提交
570 571 572 573 574 575 576
            ast::ItemDefaultImpl(..) => {
                self.gate_feature("optin_builtin_traits",
                                  i.span,
                                  "default trait implementations are experimental \
                                   and possibly buggy");
            }

A
Alex Crichton 已提交
577
            ast::ItemImpl(_, polarity, _, _, _, _) => {
578 579 580 581 582 583 584 585 586
                match polarity {
                    ast::ImplPolarity::Negative => {
                        self.gate_feature("optin_builtin_traits",
                                          i.span,
                                          "negative trait bounds are not yet fully implemented; \
                                          use marker types for now");
                    },
                    _ => {}
                }
587 588
            }

589 590 591
            _ => {}
        }

592
        visit::walk_item(self, i);
593
    }
594

595
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
596
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
597
                                                                     "link_name") {
G
GuillaumeGomez 已提交
598
            Some(val) => val.starts_with("llvm."),
599 600 601 602 603 604 605
            _ => false
        };
        if links_to_llvm {
            self.gate_feature("link_llvm_intrinsics", i.span,
                              "linking to LLVM intrinsics is experimental");
        }

606
        visit::walk_foreign_item(self, i)
607 608
    }

609
    fn visit_expr(&mut self, e: &ast::Expr) {
610
        match e.node {
611 612 613
            ast::ExprBox(..) | ast::ExprUnary(ast::UnOp::UnUniq, _) => {
                self.gate_feature("box_syntax",
                                  e.span,
614
                                  "box expression syntax is experimental; \
615 616
                                   you can call `Box::new` instead.");
            }
617 618
            _ => {}
        }
619
        visit::walk_expr(self, e);
620
    }
621

622
    fn visit_pat(&mut self, pattern: &ast::Pat) {
623 624 625 626 627 628 629 630
        match pattern.node {
            ast::PatVec(_, Some(_), ref last) if !last.is_empty() => {
                self.gate_feature("advanced_slice_patterns",
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
                                   `[0, ..xs, 0]` are experimental")
            }
631 632 633 634 635
            ast::PatVec(..) => {
                self.gate_feature("slice_patterns",
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
636
            ast::PatBox(..) => {
637
                self.gate_feature("box_patterns",
638
                                  pattern.span,
639
                                  "box pattern syntax is experimental");
640
            }
641 642
            _ => {}
        }
643
        visit::walk_pat(self, pattern)
644 645
    }

646
    fn visit_fn(&mut self,
647 648 649
                fn_kind: visit::FnKind<'v>,
                fn_decl: &'v ast::FnDecl,
                block: &'v ast::Block,
650
                span: Span,
651
                _node_id: NodeId) {
652
        match fn_kind {
N
Niko Matsakis 已提交
653
            visit::FkItemFn(_, _, _, abi) if abi == Abi::RustIntrinsic => {
654 655 656 657
                self.gate_feature("intrinsics",
                                  span,
                                  "intrinsics are subject to change")
            }
N
Niko Matsakis 已提交
658 659 660 661 662 663
            visit::FkItemFn(_, _, _, abi) |
            visit::FkMethod(_, &ast::MethodSig { abi, .. }) if abi == Abi::RustCall => {
                self.gate_feature("unboxed_closures",
                                  span,
                                  "rust-call ABI is subject to change")
            }
664 665
            _ => {}
        }
666
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
667
    }
668 669
}

670 671
fn check_crate_inner<F>(cm: &CodeMap, span_handler: &SpanHandler,
                        krate: &ast::Crate,
C
Corey Richardson 已提交
672
                        check: F)
673
                       -> Features
C
Corey Richardson 已提交
674 675
    where F: FnOnce(&mut Context, &ast::Crate)
{
676
    let mut cx = Context {
677
        features: Vec::new(),
N
Nick Cameron 已提交
678
        span_handler: span_handler,
C
Corey Richardson 已提交
679
        cm: cm,
680 681
    };

682
    let mut accepted_features = Vec::new();
N
Nick Cameron 已提交
683 684
    let mut unknown_features = Vec::new();

685
    for attr in &krate.attrs {
S
Steven Fackler 已提交
686
        if !attr.check_name("feature") {
687 688
            continue
        }
689 690 691

        match attr.meta_item_list() {
            None => {
N
Nick Cameron 已提交
692 693
                span_handler.span_err(attr.span, "malformed feature attribute, \
                                                  expected #![feature(...)]");
694 695
            }
            Some(list) => {
696
                for mi in list {
697
                    let name = match mi.node {
698
                        ast::MetaWord(ref word) => (*word).clone(),
699
                        _ => {
N
Nick Cameron 已提交
700 701 702
                            span_handler.span_err(mi.span,
                                                  "malformed feature, expected just \
                                                   one word");
703 704 705
                            continue
                        }
                    };
706
                    match KNOWN_FEATURES.iter()
B
Brian Anderson 已提交
707 708
                                        .find(|& &(n, _, _)| name == n) {
                        Some(&(name, _, Active)) => {
709 710
                            cx.features.push(name);
                        }
B
Brian Anderson 已提交
711
                        Some(&(_, _, Removed)) => {
N
Nick Cameron 已提交
712
                            span_handler.span_err(mi.span, "feature has been removed");
713
                        }
B
Brian Anderson 已提交
714
                        Some(&(_, _, Accepted)) => {
715
                            accepted_features.push(mi.span);
716 717
                        }
                        None => {
718
                            unknown_features.push((name, mi.span));
719 720 721 722 723 724 725
                        }
                    }
                }
            }
        }
    }

C
Corey Richardson 已提交
726
    check(&mut cx, krate);
727

728 729 730
    // FIXME (pnkfelix): Before adding the 99th entry below, change it
    // to a single-pass (instead of N calls to `.has_feature`).

731
    Features {
732
        unboxed_closures: cx.has_feature("unboxed_closures"),
N
Nick Cameron 已提交
733
        rustc_diagnostic_macros: cx.has_feature("rustc_diagnostic_macros"),
734
        visible_private_types: cx.has_feature("visible_private_types"),
735 736
        allow_quote: cx.has_feature("quote"),
        allow_asm: cx.has_feature("asm"),
737 738 739
        allow_log_syntax: cx.has_feature("log_syntax"),
        allow_concat_idents: cx.has_feature("concat_idents"),
        allow_trace_macros: cx.has_feature("trace_macros"),
740
        allow_internal_unstable: cx.has_feature("allow_internal_unstable"),
741
        allow_custom_derive: cx.has_feature("custom_derive"),
742
        simd_ffi: cx.has_feature("simd_ffi"),
743
        unmarked_api: cx.has_feature("unmarked_api"),
744
        negate_unsigned: cx.has_feature("negate_unsigned"),
745 746
        declared_stable_lang_features: accepted_features,
        declared_lib_features: unknown_features
747
    }
748
}
C
Corey Richardson 已提交
749 750

pub fn check_crate_macros(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
751
-> Features {
752
    check_crate_inner(cm, span_handler, krate,
C
Corey Richardson 已提交
753 754 755
                      |ctx, krate| visit::walk_crate(&mut MacroVisitor { context: ctx }, krate))
}

756 757
pub fn check_crate(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
                   -> Features
758
{
759
    check_crate_inner(cm, span_handler, krate,
C
Corey Richardson 已提交
760 761 762
                      |ctx, krate| visit::walk_crate(&mut PostExpansionVisitor { context: ctx },
                                                     krate))
}