feature_gate.rs 22.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
//! This modules implements the gating necessary for preventing certain compiler
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

S
Steven Fackler 已提交
25
use self::Status::*;
26

N
Nick Cameron 已提交
27 28 29 30 31
use abi::RustIntrinsic;
use ast::NodeId;
use ast;
use attr;
use attr::AttrMetaMethods;
C
Corey Richardson 已提交
32
use codemap::{CodeMap, Span};
N
Nick Cameron 已提交
33 34 35
use diagnostic::SpanHandler;
use visit;
use visit::Visitor;
36
use parse::token::{self, InternedString};
37

38
use std::slice;
39 40
use std::ascii::AsciiExt;

B
Brian Anderson 已提交
41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.
static KNOWN_FEATURES: &'static [(&'static str, &'static str, Status)] = &[
    ("globs", "1.0.0", Accepted),
    ("macro_rules", "1.0.0", Accepted),
    ("struct_variant", "1.0.0", Accepted),
    ("asm", "1.0.0", Active),
    ("managed_boxes", "1.0.0", Removed),
    ("non_ascii_idents", "1.0.0", Active),
    ("thread_local", "1.0.0", Active),
    ("link_args", "1.0.0", Active),
    ("phase", "1.0.0", Removed),
    ("plugin_registrar", "1.0.0", Active),
    ("log_syntax", "1.0.0", Active),
    ("trace_macros", "1.0.0", Active),
    ("concat_idents", "1.0.0", Active),
    ("unsafe_destructor", "1.0.0", Active),
    ("intrinsics", "1.0.0", Active),
    ("lang_items", "1.0.0", Active),

    ("simd", "1.0.0", Active),
    ("default_type_params", "1.0.0", Accepted),
    ("quote", "1.0.0", Active),
    ("link_llvm_intrinsics", "1.0.0", Active),
    ("linkage", "1.0.0", Active),
    ("struct_inherit", "1.0.0", Removed),

    ("quad_precision_float", "1.0.0", Removed),

    ("rustc_diagnostic_macros", "1.0.0", Active),
    ("unboxed_closures", "1.0.0", Active),
77
    ("import_shadowing", "1.0.0", Removed),
B
Brian Anderson 已提交
78 79 80 81 82 83 84 85 86 87 88 89 90 91 92
    ("advanced_slice_patterns", "1.0.0", Active),
    ("tuple_indexing", "1.0.0", Accepted),
    ("associated_types", "1.0.0", Accepted),
    ("visible_private_types", "1.0.0", Active),
    ("slicing_syntax", "1.0.0", Active),
    ("box_syntax", "1.0.0", Active),
    ("on_unimplemented", "1.0.0", Active),
    ("simd_ffi", "1.0.0", Active),

    ("if_let", "1.0.0", Accepted),
    ("while_let", "1.0.0", Accepted),

    ("plugin", "1.0.0", Active),
    ("start", "1.0.0", Active),
    ("main", "1.0.0", Active),
93

94 95
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
B
Brian Anderson 已提交
96
    ("issue_5723_bootstrap", "1.0.0", Accepted),
97

98
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
B
Brian Anderson 已提交
99
    ("opt_out_copy", "1.0.0", Removed),
100 101

    // A way to temporarily opt out of the new orphan rules. This will *never* be accepted.
B
Brian Anderson 已提交
102
    ("old_orphan_check", "1.0.0", Deprecated),
103

104
    // A way to temporarily opt out of the new impl rules. This will *never* be accepted.
B
Brian Anderson 已提交
105
    ("old_impl_check", "1.0.0", Deprecated),
106

107
    // OIBIT specific features
B
Brian Anderson 已提交
108
    ("optin_builtin_traits", "1.0.0", Active),
109

110
    // int and uint are now deprecated
B
Brian Anderson 已提交
111
    ("int_uint", "1.0.0", Active),
112

J
Joseph Crail 已提交
113
    // macro reexport needs more discussion and stabilization
A
Alex Crichton 已提交
114
    ("macro_reexport", "1.0.0", Active),
115

116 117
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
B
Brian Anderson 已提交
118 119
    ("test_accepted_feature", "1.0.0", Accepted),
    ("test_removed_feature", "1.0.0", Removed),
120 121 122

    // Allows use of #[staged_api]
    ("staged_api", "1.0.0", Active),
123 124

    // Allows using items which are missing stability attributes
K
Keegan McAllister 已提交
125 126 127 128
    ("unmarked_api", "1.0.0", Active),

    // Allows using #![no_std]
    ("no_std", "1.0.0", Active),
129 130 131

    // Allows using `box` in patterns; RFC 469
    ("box_patterns", "1.0.0", Active),
132 133 134 135 136 137 138
];

enum Status {
    /// Represents an active feature that is currently being implemented or
    /// currently being considered for addition/removal.
    Active,

139 140 141 142
    /// Represents a feature gate that is temporarily enabling deprecated behavior.
    /// This gate will never be accepted.
    Deprecated,

143 144 145 146 147 148 149
    /// Represents a feature which has since been removed (it was once Active)
    Removed,

    /// This language feature has since been Accepted (it was once Active)
    Accepted,
}

150 151
/// A set of features to be used by later passes.
pub struct Features {
152
    pub unboxed_closures: bool,
N
Nick Cameron 已提交
153
    pub rustc_diagnostic_macros: bool,
154
    pub visible_private_types: bool,
155
    pub quote: bool,
156
    pub old_orphan_check: bool,
157
    pub simd_ffi: bool,
158
    pub unmarked_api: bool,
159 160 161 162
    /// spans of #![feature] attrs for stable language features. for error reporting
    pub declared_stable_lang_features: Vec<Span>,
    /// #![feature] attrs for non-language (library) features
    pub declared_lib_features: Vec<(InternedString, Span)>
163 164 165 166 167
}

impl Features {
    pub fn new() -> Features {
        Features {
168
            unboxed_closures: false,
N
Nick Cameron 已提交
169
            rustc_diagnostic_macros: false,
170
            visible_private_types: false,
171
            quote: false,
172
            old_orphan_check: false,
173
            simd_ffi: false,
174
            unmarked_api: false,
175 176
            declared_stable_lang_features: Vec::new(),
            declared_lib_features: Vec::new()
177 178 179 180
        }
    }
}

E
Eduard Burtescu 已提交
181 182
struct Context<'a> {
    features: Vec<&'static str>,
N
Nick Cameron 已提交
183
    span_handler: &'a SpanHandler,
C
Corey Richardson 已提交
184
    cm: &'a CodeMap,
185 186
}

E
Eduard Burtescu 已提交
187
impl<'a> Context<'a> {
188 189
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
        if !self.has_feature(feature) {
190
            emit_feature_err(self.span_handler, feature, span, explain);
191 192
        }
    }
193

194 195
    fn warn_feature(&self, feature: &str, span: Span, explain: &str) {
        if !self.has_feature(feature) {
B
Brian Anderson 已提交
196
            emit_feature_warn(self.span_handler, feature, span, explain);
197 198
        }
    }
199
    fn has_feature(&self, feature: &str) -> bool {
200
        self.features.iter().any(|&n| n == feature)
201 202 203
    }
}

204 205 206 207 208 209 210
pub fn emit_feature_err(diag: &SpanHandler, feature: &str, span: Span, explain: &str) {
    diag.span_err(span, explain);
    diag.span_help(span, &format!("add #![feature({})] to the \
                                   crate attributes to enable",
                                  feature)[]);
}

B
Brian Anderson 已提交
211 212
pub fn emit_feature_warn(diag: &SpanHandler, feature: &str, span: Span, explain: &str) {
    diag.span_warn(span, explain);
213 214 215 216 217
    if diag.handler.can_emit_warnings {
        diag.span_help(span, &format!("add #![feature({})] to the \
                                       crate attributes to silence this warning",
                                      feature)[]);
    }
B
Brian Anderson 已提交
218 219
}

C
Corey Richardson 已提交
220 221 222 223 224
struct MacroVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a, 'v> Visitor<'v> for MacroVisitor<'a> {
K
Keegan McAllister 已提交
225 226
    fn visit_mac(&mut self, mac: &ast::Mac) {
        let ast::MacInvocTT(ref path, _, _) = mac.node;
C
Corey Richardson 已提交
227 228
        let id = path.segments.last().unwrap().identifier;

K
Keegan McAllister 已提交
229
        if id == token::str_to_ident("asm") {
C
Corey Richardson 已提交
230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
            self.context.gate_feature("asm", path.span, "inline assembly is not \
                stable enough for use and is subject to change");
        }

        else if id == token::str_to_ident("log_syntax") {
            self.context.gate_feature("log_syntax", path.span, "`log_syntax!` is not \
                stable enough for use and is subject to change");
        }

        else if id == token::str_to_ident("trace_macros") {
            self.context.gate_feature("trace_macros", path.span, "`trace_macros` is not \
                stable enough for use and is subject to change");
        }

        else if id == token::str_to_ident("concat_idents") {
            self.context.gate_feature("concat_idents", path.span, "`concat_idents` is not \
                stable enough for use and is subject to change");
        }
    }
}

struct PostExpansionVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a> PostExpansionVisitor<'a> {
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
        if !self.context.cm.span_is_internal(span) {
            self.context.gate_feature(feature, span, explain)
        }
    }
}

impl<'a, 'v> Visitor<'v> for PostExpansionVisitor<'a> {
264
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
G
GuillaumeGomez 已提交
265
        if !token::get_name(name).is_ascii() {
266 267 268 269 270
            self.gate_feature("non_ascii_idents", sp,
                              "non-ascii idents are not fully supported.");
        }
    }

271
    fn visit_item(&mut self, i: &ast::Item) {
272
        for attr in &i.attrs {
273
            if attr.name() == "thread_local" {
D
Daniel Micay 已提交
274 275 276 277
                self.gate_feature("thread_local", i.span,
                                  "`#[thread_local]` is an experimental feature, and does not \
                                  currently handle destructors. There is no corresponding \
                                  `#[task_local]` mapping to the task model");
278
            } else if attr.name() == "linkage" {
279 280 281
                self.gate_feature("linkage", i.span,
                                  "the `linkage` attribute is experimental \
                                   and not portable across platforms")
282 283 284 285
            } else if attr.name() == "rustc_on_unimplemented" {
                self.gate_feature("on_unimplemented", i.span,
                                  "the `#[rustc_on_unimplemented]` attribute \
                                  is an experimental feature")
D
Daniel Micay 已提交
286 287
            }
        }
288
        match i.node {
289
            ast::ItemExternCrate(_) => {
290
                if attr::contains_name(&i.attrs[], "macro_reexport") {
291 292 293
                    self.gate_feature("macro_reexport", i.span,
                                      "macros reexports are experimental \
                                       and possibly buggy");
294 295 296
                }
            }

297
            ast::ItemForeignMod(ref foreign_module) => {
J
Jorge Aparicio 已提交
298
                if attr::contains_name(&i.attrs[], "link_args") {
299 300 301 302 303
                    self.gate_feature("link_args", i.span,
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
304 305 306 307 308
                if foreign_module.abi == RustIntrinsic {
                    self.gate_feature("intrinsics",
                                      i.span,
                                      "intrinsics are subject to change")
                }
309 310
            }

311
            ast::ItemFn(..) => {
J
Jorge Aparicio 已提交
312
                if attr::contains_name(&i.attrs[], "plugin_registrar") {
313 314
                    self.gate_feature("plugin_registrar", i.span,
                                      "compiler plugins are experimental and possibly buggy");
315
                }
316 317 318 319 320 321 322 323 324 325 326 327
                if attr::contains_name(&i.attrs[], "start") {
                    self.gate_feature("start", i.span,
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
                if attr::contains_name(&i.attrs[], "main") {
                    self.gate_feature("main", i.span,
                                      "declaration of a nonstandard #[main] \
                                       function may change over time, for now \
                                       a top-level `fn main()` is required");
                }
328 329
            }

330
            ast::ItemStruct(..) => {
J
Jorge Aparicio 已提交
331
                if attr::contains_name(&i.attrs[], "simd") {
D
David Manescu 已提交
332 333
                    self.gate_feature("simd", i.span,
                                      "SIMD types are experimental and possibly buggy");
334
                }
D
David Manescu 已提交
335 336
            }

A
Alex Crichton 已提交
337
            ast::ItemImpl(_, polarity, _, _, _, _) => {
338 339 340 341 342 343 344 345 346 347
                match polarity {
                    ast::ImplPolarity::Negative => {
                        self.gate_feature("optin_builtin_traits",
                                          i.span,
                                          "negative trait bounds are not yet fully implemented; \
                                          use marker types for now");
                    },
                    _ => {}
                }

348
                if attr::contains_name(&i.attrs,
349 350 351 352 353 354 355
                                       "unsafe_destructor") {
                    self.gate_feature("unsafe_destructor",
                                      i.span,
                                      "`#[unsafe_destructor]` allows too \
                                       many unsafe patterns and may be \
                                       removed in the future");
                }
356

J
Jorge Aparicio 已提交
357
                if attr::contains_name(&i.attrs[],
358 359 360 361 362 363
                                       "old_orphan_check") {
                    self.gate_feature(
                        "old_orphan_check",
                        i.span,
                        "the new orphan check rules will eventually be strictly enforced");
                }
364

J
Jorge Aparicio 已提交
365
                if attr::contains_name(&i.attrs[],
366 367 368 369 370
                                       "old_impl_check") {
                    self.gate_feature("old_impl_check",
                                      i.span,
                                      "`#[old_impl_check]` will be removed in the future");
                }
371 372
            }

373 374 375
            _ => {}
        }

376
        visit::walk_item(self, i);
377
    }
378

379
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
J
Jorge Aparicio 已提交
380
        if attr::contains_name(&i.attrs[], "linkage") {
381 382 383
            self.gate_feature("linkage", i.span,
                              "the `linkage` attribute is experimental \
                               and not portable across platforms")
384
        }
385

386
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
387
                                                                     "link_name") {
G
GuillaumeGomez 已提交
388
            Some(val) => val.starts_with("llvm."),
389 390 391 392 393 394 395
            _ => false
        };
        if links_to_llvm {
            self.gate_feature("link_llvm_intrinsics", i.span,
                              "linking to LLVM intrinsics is experimental");
        }

396
        visit::walk_foreign_item(self, i)
397 398
    }

399
    fn visit_ty(&mut self, t: &ast::Ty) {
400 401 402 403 404 405 406 407 408 409
        match t.node {
            ast::TyPath(ref p, _) => {
                match &*p.segments {

                    [ast::PathSegment { identifier, .. }] => {
                        let name = token::get_ident(identifier);
                        let msg = if name == "int" {
                            Some("the `int` type is deprecated; \
                                  use `isize` or a fixed-sized integer")
                        } else if name == "uint" {
H
Huon Wilson 已提交
410
                            Some("the `uint` type is deprecated; \
411 412 413 414 415 416 417 418 419 420 421 422 423 424
                                  use `usize` or a fixed-sized integer")
                        } else {
                            None
                        };

                        if let Some(msg) = msg {
                            self.context.warn_feature("int_uint", t.span, msg)
                        }
                    }
                    _ => {}
                }
            }
            _ => {}
        }
425
        visit::walk_ty(self, t);
426
    }
427

428
    fn visit_expr(&mut self, e: &ast::Expr) {
429
        match e.node {
430 431 432 433 434 435
            ast::ExprBox(..) | ast::ExprUnary(ast::UnOp::UnUniq, _) => {
                self.gate_feature("box_syntax",
                                  e.span,
                                  "box expression syntax is experimental in alpha release; \
                                   you can call `Box::new` instead.");
            }
436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454
            ast::ExprLit(ref lit) => {
                match lit.node {
                    ast::LitInt(_, ty) => {
                        let msg = if let ast::SignedIntLit(ast::TyIs(true), _) = ty {
                            Some("the `i` suffix on integers is deprecated; use `is` \
                                  or one of the fixed-sized suffixes")
                        } else if let ast::UnsignedIntLit(ast::TyUs(true)) = ty {
                            Some("the `u` suffix on integers is deprecated; use `us` \
                                 or one of the fixed-sized suffixes")
                        } else {
                            None
                        };
                        if let Some(msg) = msg {
                            self.context.warn_feature("int_uint", e.span, msg);
                        }
                    }
                    _ => {}
                }
            }
455 456
            _ => {}
        }
457
        visit::walk_expr(self, e);
458
    }
459

460
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
461 462 463
        if attr.check_name("staged_api") {
            self.gate_feature("staged_api", attr.span,
                              "staged_api is for use by rustc only");
464 465 466 467
        } else if attr.check_name("plugin") {
            self.gate_feature("plugin", attr.span,
                              "compiler plugins are experimental \
                               and possibly buggy");
468 469
        }

470
        if attr::contains_name(slice::ref_slice(attr), "lang") {
471 472 473 474
            self.gate_feature("lang_items",
                              attr.span,
                              "language items are subject to change");
        }
K
Keegan McAllister 已提交
475 476 477 478 479

        if attr.check_name("no_std") {
            self.gate_feature("no_std", attr.span,
                              "no_std is experimental");
        }
480 481
    }

482
    fn visit_pat(&mut self, pattern: &ast::Pat) {
483 484 485 486 487 488 489 490
        match pattern.node {
            ast::PatVec(_, Some(_), ref last) if !last.is_empty() => {
                self.gate_feature("advanced_slice_patterns",
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
                                   `[0, ..xs, 0]` are experimental")
            }
491
            ast::PatBox(..) => {
492
                self.gate_feature("box_patterns",
493
                                  pattern.span,
494
                                  "box pattern syntax is experimental");
495
            }
496 497
            _ => {}
        }
498
        visit::walk_pat(self, pattern)
499 500
    }

501
    fn visit_fn(&mut self,
502 503 504
                fn_kind: visit::FnKind<'v>,
                fn_decl: &'v ast::FnDecl,
                block: &'v ast::Block,
505
                span: Span,
506
                _node_id: NodeId) {
507 508
        match fn_kind {
            visit::FkItemFn(_, _, _, abi) if abi == RustIntrinsic => {
509 510 511 512 513 514
                self.gate_feature("intrinsics",
                                  span,
                                  "intrinsics are subject to change")
            }
            _ => {}
        }
515
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
516
    }
517 518
}

C
Corey Richardson 已提交
519 520
fn check_crate_inner<F>(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate,
                        check: F)
521
                       -> Features
C
Corey Richardson 已提交
522 523
    where F: FnOnce(&mut Context, &ast::Crate)
{
524
    let mut cx = Context {
525
        features: Vec::new(),
N
Nick Cameron 已提交
526
        span_handler: span_handler,
C
Corey Richardson 已提交
527
        cm: cm,
528 529
    };

530
    let mut accepted_features = Vec::new();
N
Nick Cameron 已提交
531 532
    let mut unknown_features = Vec::new();

533
    for attr in &krate.attrs {
S
Steven Fackler 已提交
534
        if !attr.check_name("feature") {
535 536
            continue
        }
537 538 539

        match attr.meta_item_list() {
            None => {
N
Nick Cameron 已提交
540 541
                span_handler.span_err(attr.span, "malformed feature attribute, \
                                                  expected #![feature(...)]");
542 543
            }
            Some(list) => {
544
                for mi in list {
545
                    let name = match mi.node {
546
                        ast::MetaWord(ref word) => (*word).clone(),
547
                        _ => {
N
Nick Cameron 已提交
548 549 550
                            span_handler.span_err(mi.span,
                                                  "malformed feature, expected just \
                                                   one word");
551 552 553
                            continue
                        }
                    };
554
                    match KNOWN_FEATURES.iter()
B
Brian Anderson 已提交
555 556
                                        .find(|& &(n, _, _)| name == n) {
                        Some(&(name, _, Active)) => {
557 558
                            cx.features.push(name);
                        }
B
Brian Anderson 已提交
559
                        Some(&(name, _, Deprecated)) => {
560 561 562 563 564 565
                            cx.features.push(name);
                            span_handler.span_warn(
                                mi.span,
                                "feature is deprecated and will only be available \
                                 for a limited time, please rewrite code that relies on it");
                        }
B
Brian Anderson 已提交
566
                        Some(&(_, _, Removed)) => {
N
Nick Cameron 已提交
567
                            span_handler.span_err(mi.span, "feature has been removed");
568
                        }
B
Brian Anderson 已提交
569
                        Some(&(_, _, Accepted)) => {
570
                            accepted_features.push(mi.span);
571 572
                        }
                        None => {
573
                            unknown_features.push((name, mi.span));
574 575 576 577 578 579 580
                        }
                    }
                }
            }
        }
    }

C
Corey Richardson 已提交
581
    check(&mut cx, krate);
582

583
    Features {
584
        unboxed_closures: cx.has_feature("unboxed_closures"),
N
Nick Cameron 已提交
585
        rustc_diagnostic_macros: cx.has_feature("rustc_diagnostic_macros"),
586
        visible_private_types: cx.has_feature("visible_private_types"),
587
        quote: cx.has_feature("quote"),
588
        old_orphan_check: cx.has_feature("old_orphan_check"),
589
        simd_ffi: cx.has_feature("simd_ffi"),
590
        unmarked_api: cx.has_feature("unmarked_api"),
591 592
        declared_stable_lang_features: accepted_features,
        declared_lib_features: unknown_features
593
    }
594
}
C
Corey Richardson 已提交
595 596

pub fn check_crate_macros(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
597
-> Features {
C
Corey Richardson 已提交
598 599 600 601 602
    check_crate_inner(cm, span_handler, krate,
                      |ctx, krate| visit::walk_crate(&mut MacroVisitor { context: ctx }, krate))
}

pub fn check_crate(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
603
-> Features {
C
Corey Richardson 已提交
604 605 606 607
    check_crate_inner(cm, span_handler, krate,
                      |ctx, krate| visit::walk_crate(&mut PostExpansionVisitor { context: ctx },
                                                     krate))
}
608