feature_gate.rs 44.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

S
Steven Fackler 已提交
25
use self::Status::*;
26
use self::AttributeType::*;
27
use self::AttributeGate::*;
28

N
Niko Matsakis 已提交
29
use abi::Abi;
N
Nick Cameron 已提交
30 31 32 33
use ast::NodeId;
use ast;
use attr;
use attr::AttrMetaMethods;
C
Corey Richardson 已提交
34
use codemap::{CodeMap, Span};
N
Nick Cameron 已提交
35 36
use diagnostic::SpanHandler;
use visit;
37
use visit::{FnKind, Visitor};
38
use parse::token::InternedString;
39

40
use std::ascii::AsciiExt;
41
use std::cmp;
42

B
Brian Anderson 已提交
43 44 45 46 47 48 49
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.
50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
const KNOWN_FEATURES: &'static [(&'static str, &'static str, Option<u32>, Status)] = &[
    ("globs", "1.0.0", None, Accepted),
    ("macro_rules", "1.0.0", None, Accepted),
    ("struct_variant", "1.0.0", None, Accepted),
    ("asm", "1.0.0", None, Active),
    ("managed_boxes", "1.0.0", None, Removed),
    ("non_ascii_idents", "1.0.0", None, Active),
    ("thread_local", "1.0.0", None, Active),
    ("link_args", "1.0.0", None, Active),
    ("plugin_registrar", "1.0.0", None, Active),
    ("log_syntax", "1.0.0", None, Active),
    ("trace_macros", "1.0.0", None, Active),
    ("concat_idents", "1.0.0", None, Active),
    ("intrinsics", "1.0.0", None, Active),
    ("lang_items", "1.0.0", None, Active),

    ("simd", "1.0.0", Some(27731), Active),
    ("default_type_params", "1.0.0", None, Accepted),
    ("quote", "1.0.0", None, Active),
    ("link_llvm_intrinsics", "1.0.0", None, Active),
    ("linkage", "1.0.0", None, Active),
    ("struct_inherit", "1.0.0", None, Removed),

    ("quad_precision_float", "1.0.0", None, Removed),

    ("rustc_diagnostic_macros", "1.0.0", None, Active),
    ("unboxed_closures", "1.0.0", None, Active),
    ("reflect", "1.0.0", None, Active),
    ("import_shadowing", "1.0.0", None, Removed),
    ("advanced_slice_patterns", "1.0.0", None, Active),
    ("tuple_indexing", "1.0.0", None, Accepted),
    ("associated_types", "1.0.0", None, Accepted),
    ("visible_private_types", "1.0.0", None, Active),
    ("slicing_syntax", "1.0.0", None, Accepted),
84 85
    ("box_syntax", "1.0.0", Some(27779), Active),
    ("placement_in_syntax", "1.0.0", Some(27779), Active),
86 87 88 89 90 91 92 93 94 95 96 97 98 99 100
    ("pushpop_unsafe", "1.2.0", None, Active),
    ("on_unimplemented", "1.0.0", None, Active),
    ("simd_ffi", "1.0.0", None, Active),
    ("allocator", "1.0.0", None, Active),
    ("needs_allocator", "1.4.0", None, Active),
    ("linked_from", "1.3.0", None, Active),

    ("if_let", "1.0.0", None, Accepted),
    ("while_let", "1.0.0", None, Accepted),

    ("plugin", "1.0.0", None, Active),
    ("start", "1.0.0", None, Active),
    ("main", "1.0.0", None, Active),

    ("fundamental", "1.0.0", None, Active),
101

102 103
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
104
    ("issue_5723_bootstrap", "1.0.0", None, Accepted),
105

106
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
107
    ("opt_out_copy", "1.0.0", None, Removed),
108

109
    // OIBIT specific features
110
    ("optin_builtin_traits", "1.0.0", None, Active),
111

J
Joseph Crail 已提交
112
    // macro reexport needs more discussion and stabilization
113
    ("macro_reexport", "1.0.0", None, Active),
114

115 116
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
117 118
    ("test_accepted_feature", "1.0.0", None, Accepted),
    ("test_removed_feature", "1.0.0", None, Removed),
119 120

    // Allows use of #[staged_api]
121
    ("staged_api", "1.0.0", None, Active),
122 123

    // Allows using items which are missing stability attributes
124
    ("unmarked_api", "1.0.0", None, Active),
K
Keegan McAllister 已提交
125 126

    // Allows using #![no_std]
127
    ("no_std", "1.0.0", None, Active),
128

A
Alex Crichton 已提交
129
    // Allows using #![no_core]
130
    ("no_core", "1.3.0", None, Active),
A
Alex Crichton 已提交
131

132
    // Allows using `box` in patterns; RFC 469
133
    ("box_patterns", "1.0.0", None, Active),
134

135 136
    // Allows using the unsafe_no_drop_flag attribute (unlikely to
    // switch to Accepted; see RFC 320)
137
    ("unsafe_no_drop_flag", "1.0.0", None, Active),
138

139 140 141
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
    ("dropck_parametricity", "1.3.0", Some(28498), Active),
142

143
    // Allows the use of custom attributes; RFC 572
144
    ("custom_attribute", "1.0.0", None, Active),
M
Manish Goregaokar 已提交
145

146 147
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
148
    ("custom_derive", "1.0.0", None, Active),
149

M
Manish Goregaokar 已提交
150
    // Allows the use of rustc_* attributes; RFC 572
151
    ("rustc_attrs", "1.0.0", None, Active),
H
Huon Wilson 已提交
152

153 154 155 156
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
157
    ("allow_internal_unstable", "1.0.0", None, Active),
158 159

    // #23121. Array patterns have some hazards yet.
160
    ("slice_patterns", "1.0.0", None, Active),
161 162

    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
163
    ("negate_unsigned", "1.0.0", None, Active),
164 165 166

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
167
    ("associated_consts", "1.0.0", None, Active),
N
Niko Matsakis 已提交
168 169

    // Allows the definition of `const fn` functions.
170
    ("const_fn", "1.2.0", None, Active),
171 172

    // Allows using #[prelude_import] on glob `use` items.
173
    ("prelude_import", "1.2.0", None, Active),
174 175

    // Allows the definition recursive static items.
176
    ("static_recursion", "1.3.0", None, Active),
B
Brian Anderson 已提交
177 178

    // Allows default type parameters to influence type inference.
179
    ("default_type_parameter_fallback", "1.3.0", None, Active),
180 181

    // Allows associated type defaults
182
    ("associated_type_defaults", "1.2.0", None, Active),
J
Jared Roesch 已提交
183 184
    // Allows macros to appear in the type position.

185
    ("type_macros", "1.3.0", Some(27336), Active),
186 187

    // allow `repr(simd)`, and importing the various simd intrinsics
188
    ("repr_simd", "1.4.0", Some(27731), Active),
189 190

    // Allows cfg(target_feature = "...").
191
    ("cfg_target_feature", "1.4.0", None, Active),
192 193

    // allow `extern "platform-intrinsic" { ... }`
194
    ("platform_intrinsics", "1.4.0", Some(27731), Active),
195 196 197

    // allow `#[unwind]`
    ("unwind_attributes", "1.4.0", None, Active),
V
Vadim Petrochenkov 已提交
198 199 200

    // allow empty structs/enum variants with braces
    ("braced_empty_structs", "1.5.0", None, Active),
201 202 203

    // allow overloading augmented assignment operations like `a += b`
    ("augmented_assignments", "1.5.0", None, Active),
204 205 206 207 208 209

    // allow `#[no_debug]`
    ("no_debug", "1.5.0", None, Active),

    // allow `#[omit_gdb_pretty_printer_section]`
    ("omit_gdb_pretty_printer_section", "1.5.0", None, Active),
210 211 212

    // Allows cfg(target_vendor = "...").
    ("cfg_target_vendor", "1.5.0", None, Active),
213
];
214
// (changing above list without updating src/doc/reference.md makes @cmr sad)
215 216 217 218 219 220 221 222 223 224 225 226 227

enum Status {
    /// Represents an active feature that is currently being implemented or
    /// currently being considered for addition/removal.
    Active,

    /// Represents a feature which has since been removed (it was once Active)
    Removed,

    /// This language feature has since been Accepted (it was once Active)
    Accepted,
}

228
// Attributes that have a special meaning to rustc or rustdoc
229
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
230 231
    // Normal attributes

232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
262

A
Alex Crichton 已提交
263
    // Not used any more, but we can't feature gate it
264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
    ("no_stack_check", Normal, Ungated),

    ("staged_api", CrateLevel, Gated("staged_api",
                                     "staged_api is for use by rustc only")),
    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
                                  and possibly buggy")),
    ("no_std", CrateLevel, Gated("no_std",
                                 "no_std is experimental")),
    ("no_core", CrateLevel, Gated("no_core",
                                  "no_core is experimental")),
    ("lang", Normal, Gated("lang_items",
                           "language items are subject to change")),
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
                                    and not portable across platforms")),
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
                                         model")),

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
                                              is an experimental feature")),
    ("allocator", Whitelisted, Gated("allocator",
                                     "the `#[allocator]` attribute is an experimental feature")),
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
                                       feature")),
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
297 298
                                      is just used for rustc unit tests \
                                      and will never be stable")),
299 300
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
301 302
                                        is just used for rustc unit tests \
                                        and will never be stable")),
303 304
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
305 306 307 308 309 310
                                            is just used for rustc unit tests \
                                            and will never be stable")),
    ("rustc_mir", Normal, Gated("rustc_attrs",
                                "the `#[rustc_mir]` attribute \
                                 is just used for rustc unit tests \
                                 and will never be stable")),
311 312 313 314 315 316 317 318 319 320 321

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE)),

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
                                        is an experimental feature")),

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
                                   is an experimental feature")),
322

323
    // FIXME: #14408 whitelist docs since rustdoc looks at them
324
    ("doc", Whitelisted, Ungated),
325 326 327

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
328 329 330 331 332 333 334 335
    ("cold", Whitelisted, Ungated),
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
336 337 338 339 340 341 342
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
                                     is an experimental feature")),
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
                                                        suite")),
343 344 345
    ("unsafe_no_drop_flag", Whitelisted, Gated("unsafe_no_drop_flag",
                                               "unsafe_no_drop_flag has unstable semantics \
                                                and may be removed in the future")),
346 347
    ("unsafe_destructor_blind_to_params",
     Normal,
348
     Gated("dropck_parametricity",
349 350
           "unsafe_destructor_blind_to_params has unstable semantics \
            and may be removed in the future")),
351
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental")),
352 353

    // used in resolve
354 355
    ("prelude_import", Whitelisted, Gated("prelude_import",
                                          "`#[prelude_import]` is for use by rustc only")),
356 357 358

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
359 360 361 362
    ("deprecated", Whitelisted, Ungated),
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
363

364 365 366 367
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
                                        "unboxed_closures are still evolving")),
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
                                              "defining reflective traits is still evolving")),
368 369

    // Crate level attributes
370 371 372 373 374 375 376 377
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
378 379
];

380 381 382 383 384 385 386 387 388 389 390 391
macro_rules! cfg_fn {
    (|$x: ident| $e: expr) => {{
        fn f($x: &Features) -> bool {
            $e
        }
        f as fn(&Features) -> bool
    }}
}
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
    ("target_feature", "cfg_target_feature", cfg_fn!(|x| x.cfg_target_feature)),
392
    ("target_vendor", "cfg_target_vendor", cfg_fn!(|x| x.cfg_target_vendor)),
393 394 395 396 397 398 399
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
400

401 402 403 404 405 406
impl Ord for GatedCfg {
    fn cmp(&self, other: &GatedCfg) -> cmp::Ordering {
        (self.span.lo.0, self.span.hi.0, self.index)
            .cmp(&(other.span.lo.0, other.span.hi.0, other.index))
    }
}
407

408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429
impl PartialOrd for GatedCfg {
    fn partial_cmp(&self, other: &GatedCfg) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
    pub fn check_and_emit(&self, diagnostic: &SpanHandler, features: &Features) {
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
        if !has_feature(features) {
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
430
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
431 432 433 434 435
        }
    }
}


N
Niko Matsakis 已提交
436
#[derive(PartialEq, Copy, Clone, Debug)]
437 438 439 440 441 442 443 444 445 446
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,

    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,

447 448 449 450 451 452
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeGate {
M
Manish Goregaokar 已提交
453 454 455
    /// Is gated by a given feature gate and reason
    Gated(&'static str, &'static str),

456 457
    /// Ungated attribute, can be used on all release channels
    Ungated,
458 459
}

460 461
/// A set of features to be used by later passes.
pub struct Features {
462
    pub unboxed_closures: bool,
N
Nick Cameron 已提交
463
    pub rustc_diagnostic_macros: bool,
464
    pub visible_private_types: bool,
465 466
    pub allow_quote: bool,
    pub allow_asm: bool,
467 468 469
    pub allow_log_syntax: bool,
    pub allow_concat_idents: bool,
    pub allow_trace_macros: bool,
470
    pub allow_internal_unstable: bool,
471
    pub allow_custom_derive: bool,
472 473
    pub allow_placement_in: bool,
    pub allow_box: bool,
474
    pub allow_pushpop_unsafe: bool,
475
    pub simd_ffi: bool,
476
    pub unmarked_api: bool,
477
    pub negate_unsigned: bool,
478 479 480
    /// spans of #![feature] attrs for stable language features. for error reporting
    pub declared_stable_lang_features: Vec<Span>,
    /// #![feature] attrs for non-language (library) features
481 482
    pub declared_lib_features: Vec<(InternedString, Span)>,
    pub const_fn: bool,
J
Jared Roesch 已提交
483 484
    pub static_recursion: bool,
    pub default_type_parameter_fallback: bool,
J
Jared Roesch 已提交
485
    pub type_macros: bool,
486
    pub cfg_target_feature: bool,
487
    pub cfg_target_vendor: bool,
488
    pub augmented_assignments: bool,
489 490 491 492 493
}

impl Features {
    pub fn new() -> Features {
        Features {
494
            unboxed_closures: false,
N
Nick Cameron 已提交
495
            rustc_diagnostic_macros: false,
496
            visible_private_types: false,
497 498
            allow_quote: false,
            allow_asm: false,
499 500 501
            allow_log_syntax: false,
            allow_concat_idents: false,
            allow_trace_macros: false,
502
            allow_internal_unstable: false,
503
            allow_custom_derive: false,
504 505
            allow_placement_in: false,
            allow_box: false,
506
            allow_pushpop_unsafe: false,
507
            simd_ffi: false,
508
            unmarked_api: false,
509
            negate_unsigned: false,
510
            declared_stable_lang_features: Vec::new(),
511 512
            declared_lib_features: Vec::new(),
            const_fn: false,
J
Jared Roesch 已提交
513 514
            static_recursion: false,
            default_type_parameter_fallback: false,
J
Jared Roesch 已提交
515
            type_macros: false,
516
            cfg_target_feature: false,
517
            cfg_target_vendor: false,
518
            augmented_assignments: false,
519 520 521 522
        }
    }
}

523 524 525 526 527 528 529 530 531 532 533 534 535
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";

const EXPLAIN_PUSHPOP_UNSAFE: &'static str =
    "push/pop_unsafe macros are experimental and subject to change.";

pub fn check_for_box_syntax(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_box: true, .. }) = f {
        return;
    }
536
    emit_feature_err(diag, "box_syntax", span, GateIssue::Language, EXPLAIN_BOX_SYNTAX);
537 538 539 540 541 542
}

pub fn check_for_placement_in(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_placement_in: true, .. }) = f {
        return;
    }
543
    emit_feature_err(diag, "placement_in_syntax", span, GateIssue::Language, EXPLAIN_PLACEMENT_IN);
544 545
}

546 547 548 549
pub fn check_for_pushpop_syntax(f: Option<&Features>, diag: &SpanHandler, span: Span) {
    if let Some(&Features { allow_pushpop_unsafe: true, .. }) = f {
        return;
    }
550
    emit_feature_err(diag, "pushpop_unsafe", span, GateIssue::Language, EXPLAIN_PUSHPOP_UNSAFE);
551 552
}

E
Eduard Burtescu 已提交
553 554
struct Context<'a> {
    features: Vec<&'static str>,
N
Nick Cameron 已提交
555
    span_handler: &'a SpanHandler,
C
Corey Richardson 已提交
556
    cm: &'a CodeMap,
557
    plugin_attributes: &'a [(String, AttributeType)],
558 559
}

E
Eduard Burtescu 已提交
560
impl<'a> Context<'a> {
561 562 563 564 565
    fn enable_feature(&mut self, feature: &'static str) {
        debug!("enabling feature: {}", feature);
        self.features.push(feature);
    }

566
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
567 568 569
        let has_feature = self.has_feature(feature);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", feature, span, has_feature);
        if !has_feature {
570
            emit_feature_err(self.span_handler, feature, span, GateIssue::Language, explain);
571 572
        }
    }
573
    fn has_feature(&self, feature: &str) -> bool {
574
        self.features.iter().any(|&n| n == feature)
575
    }
576

577
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
578 579
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
580
        for &(n, ty, gateage) in KNOWN_ATTRIBUTES {
581
            if n == name {
582
                if let Gated(gate, desc) = gateage {
583 584
                    self.gate_feature(gate, attr.span, desc);
                }
585
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
586 587 588
                return;
            }
        }
589
        for &(ref n, ref ty) in self.plugin_attributes {
590 591
            if &*n == name {
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
592 593
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
594 595 596 597
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
598 599 600 601 602
        if name.starts_with("rustc_") {
            self.gate_feature("rustc_attrs", attr.span,
                              "unless otherwise specified, attributes \
                               with the prefix `rustc_` \
                               are reserved for internal compiler diagnostics");
603 604
        } else if name.starts_with("derive_") {
            self.gate_feature("custom_derive", attr.span,
605
                              "attributes of the form `#[derive_*]` are reserved \
606
                               for the compiler");
607
        } else {
M
Manish Goregaokar 已提交
608 609 610 611
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
612 613 614 615 616 617 618 619
            if !is_macro {
                self.gate_feature("custom_attribute", attr.span,
                           &format!("The attribute `{}` is currently \
                                    unknown to the compiler and \
                                    may have meaning \
                                    added to it in the future",
                                    name));
            }
620 621
        }
    }
622 623
}

624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
    let info = KNOWN_FEATURES.iter()
                              .find(|t| t.0 == feature)
                              .unwrap();
    let issue = info.2;
    if let Active = info.3 {
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
    }
    issue
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

pub fn emit_feature_err(diag: &SpanHandler, feature: &str, span: Span, issue: GateIssue,
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

    if let Some(n) = issue {
        diag.span_err(span, &format!("{} (see issue #{})", explain, n));
    } else {
        diag.span_err(span, explain);
    }
653 654

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
655
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() { return; }
656
    diag.fileline_help(span, &format!("add #![feature({})] to the \
657
                                   crate attributes to enable",
658
                                  feature));
659 660
}

661 662 663
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

664 665 666 667 668 669 670 671
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
672 673
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
674

675 676 677
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

C
Corey Richardson 已提交
678 679 680 681 682
struct MacroVisitor<'a> {
    context: &'a Context<'a>
}

impl<'a, 'v> Visitor<'v> for MacroVisitor<'a> {
K
Keegan McAllister 已提交
683
    fn visit_mac(&mut self, mac: &ast::Mac) {
684
        let path = &mac.node.path;
685
        let name = path.segments.last().unwrap().identifier.name.as_str();
C
Corey Richardson 已提交
686

687 688 689 690 691 692 693 694
        // Issue 22234: If you add a new case here, make sure to also
        // add code to catch the macro during or after expansion.
        //
        // We still keep this MacroVisitor (rather than *solely*
        // relying on catching cases during or after expansion) to
        // catch uses of these macros within conditionally-compiled
        // code, e.g. `#[cfg]`-guarded functions.

695
        if name == "asm" {
696
            self.context.gate_feature("asm", path.span, EXPLAIN_ASM);
C
Corey Richardson 已提交
697 698
        }

699
        else if name == "log_syntax" {
700
            self.context.gate_feature("log_syntax", path.span, EXPLAIN_LOG_SYNTAX);
C
Corey Richardson 已提交
701 702
        }

703
        else if name == "trace_macros" {
704
            self.context.gate_feature("trace_macros", path.span, EXPLAIN_TRACE_MACROS);
C
Corey Richardson 已提交
705 706
        }

707
        else if name == "concat_idents" {
708
            self.context.gate_feature("concat_idents", path.span, EXPLAIN_CONCAT_IDENTS);
C
Corey Richardson 已提交
709 710
        }
    }
711 712

    fn visit_attribute(&mut self, attr: &'v ast::Attribute) {
713
        self.context.check_attribute(attr, true);
714
    }
715 716 717 718 719 720 721 722 723 724

    fn visit_expr(&mut self, e: &ast::Expr) {
        // Issue 22181: overloaded-`box` and placement-`in` are
        // implemented via a desugaring expansion, so their feature
        // gates go into MacroVisitor since that works pre-expansion.
        //
        // Issue 22234: we also check during expansion as well.
        // But we keep these checks as a pre-expansion check to catch
        // uses in e.g. conditionalized code.

725
        if let ast::ExprBox(_) = e.node {
726 727 728
            self.context.gate_feature("box_syntax", e.span, EXPLAIN_BOX_SYNTAX);
        }

729
        if let ast::ExprInPlace(..) = e.node {
730 731 732 733 734
            self.context.gate_feature("placement_in_syntax", e.span, EXPLAIN_PLACEMENT_IN);
        }

        visit::walk_expr(self, e);
    }
C
Corey Richardson 已提交
735 736 737
}

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
738
    context: &'a Context<'a>,
C
Corey Richardson 已提交
739 740 741 742
}

impl<'a> PostExpansionVisitor<'a> {
    fn gate_feature(&self, feature: &str, span: Span, explain: &str) {
743
        if !self.context.cm.span_allows_unstable(span) {
C
Corey Richardson 已提交
744 745 746 747 748 749
            self.context.gate_feature(feature, span, explain)
        }
    }
}

impl<'a, 'v> Visitor<'v> for PostExpansionVisitor<'a> {
750 751
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
752
            self.context.check_attribute(attr, false);
753 754 755
        }
    }

756
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
757
        if !name.as_str().is_ascii() {
758 759 760 761 762
            self.gate_feature("non_ascii_idents", sp,
                              "non-ascii idents are not fully supported.");
        }
    }

763
    fn visit_item(&mut self, i: &ast::Item) {
764
        match i.node {
765
            ast::ItemExternCrate(_) => {
766
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
767 768 769
                    self.gate_feature("macro_reexport", i.span,
                                      "macros reexports are experimental \
                                       and possibly buggy");
770 771 772
                }
            }

773
            ast::ItemForeignMod(ref foreign_module) => {
774
                if attr::contains_name(&i.attrs[..], "link_args") {
775 776 777 778 779
                    self.gate_feature("link_args", i.span,
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
780 781 782 783 784 785 786 787 788 789
                let maybe_feature = match foreign_module.abi {
                    Abi::RustIntrinsic => Some(("intrinsics", "intrinsics are subject to change")),
                    Abi::PlatformIntrinsic => {
                        Some(("platform_intrinsics",
                              "platform intrinsics are experimental and possibly buggy"))
                    }
                    _ => None
                };
                if let Some((feature, msg)) = maybe_feature {
                    self.gate_feature(feature, i.span, msg)
790
                }
791 792
            }

793
            ast::ItemFn(..) => {
794
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
795 796
                    self.gate_feature("plugin_registrar", i.span,
                                      "compiler plugins are experimental and possibly buggy");
797
                }
798
                if attr::contains_name(&i.attrs[..], "start") {
799 800 801 802 803
                    self.gate_feature("start", i.span,
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
804
                if attr::contains_name(&i.attrs[..], "main") {
805 806 807 808 809
                    self.gate_feature("main", i.span,
                                      "declaration of a nonstandard #[main] \
                                       function may change over time, for now \
                                       a top-level `fn main()` is required");
                }
810 811
            }

V
Vadim Petrochenkov 已提交
812
            ast::ItemStruct(ref def, _) => {
813
                if attr::contains_name(&i.attrs[..], "simd") {
D
David Manescu 已提交
814 815
                    self.gate_feature("simd", i.span,
                                      "SIMD types are experimental and possibly buggy");
816 817 818 819 820 821 822 823
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
                            if item.name() == "simd" {
824
                                self.gate_feature("repr_simd", i.span,
825 826 827 828 829
                                                  "SIMD types are experimental and possibly buggy");

                            }
                        }
                    }
830
                }
831
                if def.fields.is_empty() && def.kind == ast::VariantKind::Dict {
V
Vadim Petrochenkov 已提交
832 833 834
                    self.gate_feature("braced_empty_structs", i.span,
                                      "empty structs with braces are unstable");
                }
D
David Manescu 已提交
835 836
            }

F
Flavio Percoco 已提交
837 838 839 840 841 842 843
            ast::ItemDefaultImpl(..) => {
                self.gate_feature("optin_builtin_traits",
                                  i.span,
                                  "default trait implementations are experimental \
                                   and possibly buggy");
            }

A
Alex Crichton 已提交
844
            ast::ItemImpl(_, polarity, _, _, _, _) => {
845 846 847 848 849 850 851 852 853
                match polarity {
                    ast::ImplPolarity::Negative => {
                        self.gate_feature("optin_builtin_traits",
                                          i.span,
                                          "negative trait bounds are not yet fully implemented; \
                                          use marker types for now");
                    },
                    _ => {}
                }
854 855
            }

856 857 858
            _ => {}
        }

859
        visit::walk_item(self, i);
860
    }
861

862
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
863
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
864
                                                                     "link_name") {
G
GuillaumeGomez 已提交
865
            Some(val) => val.starts_with("llvm."),
866 867 868 869 870 871 872
            _ => false
        };
        if links_to_llvm {
            self.gate_feature("link_llvm_intrinsics", i.span,
                              "linking to LLVM intrinsics is experimental");
        }

873
        visit::walk_foreign_item(self, i)
874 875
    }

876
    fn visit_expr(&mut self, e: &ast::Expr) {
877
        match e.node {
878
            ast::ExprBox(_) => {
879 880
                self.gate_feature("box_syntax",
                                  e.span,
881
                                  "box expression syntax is experimental; \
882 883
                                   you can call `Box::new` instead.");
            }
V
Vadim Petrochenkov 已提交
884 885 886 887 888 889
            ast::ExprStruct(_, ref fields, ref expr) => {
                if fields.is_empty() && expr.is_none() {
                    self.gate_feature("braced_empty_structs", e.span,
                                      "empty structs with braces are unstable");
                }
            }
890 891
            _ => {}
        }
892
        visit::walk_expr(self, e);
893
    }
894

895
    fn visit_pat(&mut self, pattern: &ast::Pat) {
896 897 898 899 900 901
        match pattern.node {
            ast::PatVec(_, Some(_), ref last) if !last.is_empty() => {
                self.gate_feature("advanced_slice_patterns",
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
902
                                   `[0, ..xs, 0]`) are experimental")
903
            }
904 905 906 907 908
            ast::PatVec(..) => {
                self.gate_feature("slice_patterns",
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
909
            ast::PatBox(..) => {
910
                self.gate_feature("box_patterns",
911
                                  pattern.span,
912
                                  "box pattern syntax is experimental");
913
            }
V
Vadim Petrochenkov 已提交
914 915 916 917 918 919
            ast::PatStruct(_, ref fields, dotdot) => {
                if fields.is_empty() && !dotdot {
                    self.gate_feature("braced_empty_structs", pattern.span,
                                      "empty structs with braces are unstable");
                }
            }
920 921
            _ => {}
        }
922
        visit::walk_pat(self, pattern)
923 924
    }

925
    fn visit_fn(&mut self,
926
                fn_kind: FnKind<'v>,
927 928
                fn_decl: &'v ast::FnDecl,
                block: &'v ast::Block,
929
                span: Span,
930
                _node_id: NodeId) {
N
Niko Matsakis 已提交
931 932
        // check for const fn declarations
        match fn_kind {
933
            FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
N
Niko Matsakis 已提交
934 935 936 937 938 939 940 941 942 943
                self.gate_feature("const_fn", span, "const fn is unstable");
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

944
        match fn_kind {
945
            FnKind::ItemFn(_, _, _, _, abi, _) if abi == Abi::RustIntrinsic => {
946 947 948 949
                self.gate_feature("intrinsics",
                                  span,
                                  "intrinsics are subject to change")
            }
950 951
            FnKind::ItemFn(_, _, _, _, abi, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) if abi == Abi::RustCall => {
N
Niko Matsakis 已提交
952 953 954 955
                self.gate_feature("unboxed_closures",
                                  span,
                                  "rust-call ABI is subject to change")
            }
956 957
            _ => {}
        }
958
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
959
    }
960 961 962 963 964 965 966 967

    fn visit_trait_item(&mut self, ti: &'v ast::TraitItem) {
        match ti.node {
            ast::ConstTraitItem(..) => {
                self.gate_feature("associated_consts",
                                  ti.span,
                                  "associated constants are experimental")
            }
N
Niko Matsakis 已提交
968 969 970 971 972
            ast::MethodTraitItem(ref sig, _) => {
                if sig.constness == ast::Constness::Const {
                    self.gate_feature("const_fn", ti.span, "const fn is unstable");
                }
            }
973 974 975 976
            ast::TypeTraitItem(_, Some(_)) => {
                self.gate_feature("associated_type_defaults", ti.span,
                                  "associated type defaults are unstable");
            }
977 978 979 980 981 982 983 984 985 986 987 988
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

    fn visit_impl_item(&mut self, ii: &'v ast::ImplItem) {
        match ii.node {
            ast::ConstImplItem(..) => {
                self.gate_feature("associated_consts",
                                  ii.span,
                                  "associated constants are experimental")
            }
N
Niko Matsakis 已提交
989 990 991 992 993
            ast::MethodImplItem(ref sig, _) => {
                if sig.constness == ast::Constness::Const {
                    self.gate_feature("const_fn", ii.span, "const fn is unstable");
                }
            }
994 995 996 997
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
998 999
}

1000 1001
fn check_crate_inner<F>(cm: &CodeMap, span_handler: &SpanHandler,
                        krate: &ast::Crate,
1002
                        plugin_attributes: &[(String, AttributeType)],
C
Corey Richardson 已提交
1003
                        check: F)
1004
                       -> Features
C
Corey Richardson 已提交
1005 1006
    where F: FnOnce(&mut Context, &ast::Crate)
{
1007
    let mut cx = Context {
1008
        features: Vec::new(),
N
Nick Cameron 已提交
1009
        span_handler: span_handler,
C
Corey Richardson 已提交
1010
        cm: cm,
1011
        plugin_attributes: plugin_attributes,
1012 1013
    };

1014
    let mut accepted_features = Vec::new();
N
Nick Cameron 已提交
1015 1016
    let mut unknown_features = Vec::new();

1017
    for attr in &krate.attrs {
S
Steven Fackler 已提交
1018
        if !attr.check_name("feature") {
1019 1020
            continue
        }
1021 1022 1023

        match attr.meta_item_list() {
            None => {
N
Nick Cameron 已提交
1024 1025
                span_handler.span_err(attr.span, "malformed feature attribute, \
                                                  expected #![feature(...)]");
1026 1027
            }
            Some(list) => {
1028
                for mi in list {
1029
                    let name = match mi.node {
1030
                        ast::MetaWord(ref word) => (*word).clone(),
1031
                        _ => {
N
Nick Cameron 已提交
1032 1033 1034
                            span_handler.span_err(mi.span,
                                                  "malformed feature, expected just \
                                                   one word");
1035 1036 1037
                            continue
                        }
                    };
1038
                    match KNOWN_FEATURES.iter()
1039 1040
                                        .find(|& &(n, _, _, _)| name == n) {
                        Some(&(name, _, _, Active)) => {
1041
                            cx.enable_feature(name);
1042
                        }
1043
                        Some(&(_, _, _, Removed)) => {
N
Nick Cameron 已提交
1044
                            span_handler.span_err(mi.span, "feature has been removed");
1045
                        }
1046
                        Some(&(_, _, _, Accepted)) => {
1047
                            accepted_features.push(mi.span);
1048 1049
                        }
                        None => {
1050
                            unknown_features.push((name, mi.span));
1051 1052 1053 1054 1055 1056 1057
                        }
                    }
                }
            }
        }
    }

C
Corey Richardson 已提交
1058
    check(&mut cx, krate);
1059

1060 1061 1062
    // FIXME (pnkfelix): Before adding the 99th entry below, change it
    // to a single-pass (instead of N calls to `.has_feature`).

1063
    Features {
1064
        unboxed_closures: cx.has_feature("unboxed_closures"),
N
Nick Cameron 已提交
1065
        rustc_diagnostic_macros: cx.has_feature("rustc_diagnostic_macros"),
1066
        visible_private_types: cx.has_feature("visible_private_types"),
1067 1068
        allow_quote: cx.has_feature("quote"),
        allow_asm: cx.has_feature("asm"),
1069 1070 1071
        allow_log_syntax: cx.has_feature("log_syntax"),
        allow_concat_idents: cx.has_feature("concat_idents"),
        allow_trace_macros: cx.has_feature("trace_macros"),
1072
        allow_internal_unstable: cx.has_feature("allow_internal_unstable"),
1073
        allow_custom_derive: cx.has_feature("custom_derive"),
1074 1075
        allow_placement_in: cx.has_feature("placement_in_syntax"),
        allow_box: cx.has_feature("box_syntax"),
1076
        allow_pushpop_unsafe: cx.has_feature("pushpop_unsafe"),
1077
        simd_ffi: cx.has_feature("simd_ffi"),
1078
        unmarked_api: cx.has_feature("unmarked_api"),
1079
        negate_unsigned: cx.has_feature("negate_unsigned"),
1080
        declared_stable_lang_features: accepted_features,
1081 1082
        declared_lib_features: unknown_features,
        const_fn: cx.has_feature("const_fn"),
J
Jared Roesch 已提交
1083
        static_recursion: cx.has_feature("static_recursion"),
J
Jared Roesch 已提交
1084
        default_type_parameter_fallback: cx.has_feature("default_type_parameter_fallback"),
J
Jared Roesch 已提交
1085
        type_macros: cx.has_feature("type_macros"),
1086
        cfg_target_feature: cx.has_feature("cfg_target_feature"),
1087
        cfg_target_vendor: cx.has_feature("cfg_target_vendor"),
1088
        augmented_assignments: cx.has_feature("augmented_assignments"),
1089
    }
1090
}
C
Corey Richardson 已提交
1091 1092

pub fn check_crate_macros(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate)
1093
-> Features {
1094
    check_crate_inner(cm, span_handler, krate, &[] as &'static [_],
C
Corey Richardson 已提交
1095 1096 1097
                      |ctx, krate| visit::walk_crate(&mut MacroVisitor { context: ctx }, krate))
}

1098
pub fn check_crate(cm: &CodeMap, span_handler: &SpanHandler, krate: &ast::Crate,
1099 1100
                   plugin_attributes: &[(String, AttributeType)],
                   unstable: UnstableFeatures) -> Features
1101
{
1102 1103
    maybe_stage_features(span_handler, krate, unstable);

1104
    check_crate_inner(cm, span_handler, krate, plugin_attributes,
C
Corey Richardson 已提交
1105 1106 1107
                      |ctx, krate| visit::walk_crate(&mut PostExpansionVisitor { context: ctx },
                                                     krate))
}
1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118

#[derive(Clone, Copy)]
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1119
    /// features. As a result, this is always required for building Rust itself.
1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140
    Cheat
}

fn maybe_stage_features(span_handler: &SpanHandler, krate: &ast::Crate,
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
                let ref msg = format!("#[feature] may not be used on the {} release channel",
                                      release_channel);
                span_handler.span_err(attr.span, msg);
            }
        }
    }
}