1. 17 11月, 2016 1 次提交
    • S
      Clean Up: Removing unused interface GetTable from MinikinFont. · fd77b01f
      Seigo Nonaka 提交于
      This is 2nd attempt of Ifcd7a348d7fb5af081192899dbcdfc7fb4eebbf9
      
      After Id766ab16a8d342bf7322a90e076e801271d527d4, GetTable is no longer
      used in production due to poor performance and it is now only used in
      tests. This CL removes GetTable interface from MinikinFont and update
      tests code to use new interfaces, GetFontData, GetFontSize and
      GetFontIndex.
      
      Bug: 27860101
      Test: Manually done
      Change-Id: Ib48973ff25cdc61a4c666d28128266df0aaea83e
      fd77b01f
  2. 16 11月, 2016 1 次提交
    • S
      Implement word spacing · acd401d0
      Seigo Nonaka 提交于
      Add a wordSpacing paint parameter, which will be used for
      justification.
      
      Bug: 31707212
      Test: ran minikin_tests
      Change-Id: I91224ab8ef882ac0c87425c28ab731fead283612
      acd401d0
  3. 25 10月, 2016 1 次提交
  4. 18 10月, 2016 1 次提交
    • S
      Clean Up: Removing unused interface GetTable from MinikinFont. · 1d525df4
      Seigo Nonaka 提交于
      After Id766ab16a8d342bf7322a90e076e801271d527d4, GetTable is no longer
      used in production due to poor performance and it is now only used in
      tests. This CL removes GetTable interface from MinikinFont and update
      tests code to use new interfaces, GetFontData, GetFontSize and
      GetFontIndex.
      
      Bug: 27860101
      Test: Manually done
      
      Change-Id: Ifcd7a348d7fb5af081192899dbcdfc7fb4eebbf9
      1d525df4
  5. 06 8月, 2016 1 次提交
    • B
      Move SkTypeface::CreateXXX to SkTypeface::MakeXXX. · e6adb66a
      Ben Wagner 提交于
      Skia is moving to returning smart pointers from its factory methods.
      This updates uses of SkTypeface::CreateXXX to SkTypeface::MakeXXX and
      generally updates use of SkTypeface to sk_sp. This will allow for the
      removal of the SK_SUPPORT_LEGACY_TYPEFACE_PTR define.
      
      Change-Id: If3e600c6cb86080576667bc77d427da4f6560afa
      e6adb66a
  6. 28 6月, 2016 1 次提交
    • S
      Introduce FontCollection perftest · 5e6bc85d
      Seigo Nonaka 提交于
      This CL introduces performance tests for FontCollection.
      
      To support TTC file in /system/fonts, this CL also extends FontTestUtils
      
      Bug:29142734
      Change-Id: I9d8ad24ca55f61031b85623ab7c26234239e4f41
      5e6bc85d
  7. 21 6月, 2016 1 次提交
    • S
      Fix test utilities · 81c79d6e
      Seigo Nonaka 提交于
      This fixes following three memory leaks in test utilities.
      There is no problem in production code and this CL doesn't affect
      any production behaviors.
      
      - SkTypeface leaks due to forget calling SkSafeUnref in dtor.
      - MinikinFontForTest leaks during constructing FontCollection.
      - FontCollection leaks due to unnecessary AddRef.
      
      Change-Id: I22e1e0307f1b2499296acb1aacc3ef66076a36e9
      81c79d6e
  8. 10 6月, 2016 1 次提交
    • S
      Always use minikin namespace. · 14e2d136
      Seigo Nonaka 提交于
      Here is a new policy of the namespace of minikin.
      - All components should be in minikin namespace.
      - All tests are also in minikin namespace and no anonymous namespace.
      
      Bug: 29233740
      Change-Id: I71a8a35049bb8d624f7a78797231e90fed1e2b8c
      14e2d136
  9. 09 6月, 2016 1 次提交
    • S
      Reconstruct the directory structure of minikin tests. · c38b249e
      Seigo Nonaka 提交于
      To add perftests and reuse some utility classes, reconstruct
      test directory structure.
      
      - Move unit tests from minikin/tests to minikin/tests/unittests
      - Extract utilitiy classes to minikin/tests/utils which will be
        used by perftests eventually.
      
      Change-Id: I5026b177934e72ae67d362ee888302037da2f808
      c38b249e
  10. 12 4月, 2016 1 次提交
    • S
      Fix minikin_unittests · 6c60831c
      Seigo Nonaka 提交于
      This CL fixes following test cases in minikin_tests
      - FontFamilyTest.hasVariationSelectorTest
      - HbFontCacheTest.getHbFontLockedTest
      - HbFontCacheTest.purgeCacheTest
      
      For the fix of FontFamilyTest.hasVariationSelectorTest, removing virtual
      from GetUniqueId() in MinikinFont.  After [1], MinikinFont's destructor
      started calling purgeHbCache() which calls virtual method,
      MinikinFont::GetUniqueId().  Fortunately, the SkTypeface::uniqueID()
      returns just internal value, so we can store it at the construction time
      and use it instead of calling SkTypeface::uniqueID() every time.
      
      This patch also changes purgeHbFont to purgeHbFontLocked, as all uses of
      it were already under global mutex. This change avoids deadlock on
      explicit unref, as when invoked by a Java finalizer from the Java object
      that holds a reference to the font.
      
      Some of the tests needed to change to using the ref counting protocol
      rather than explicitly destructing font objects, as well.
      
      [1] 9afcc6e2
      
      Bug: 28105730
      Bug: 28105688
      Change-Id: Ie5983c4869147dacabdca81af1605066cd680b3f
      6c60831c
  11. 08 4月, 2016 1 次提交
    • R
      Avoid copying of font table data · aaa4e347
      Raph Levien 提交于
      The hb_font_t object holds on to tables of font data, acquired through
      the MinikinFont::GetTable interface, which is based on copying data
      into caller-owned buffers. Now that we're caching lots of hb_font_t's,
      the cost of these buffers is significant.
      
      This patch moves to a different interface, inspired by HarfBuzz's
      hb_reference_table API, where the font can provide a pointer to the
      actual font data (which will often be mmap'ed, so it doesn't even
      consume physical RAM).
      
      Bug: 27860101
      Change-Id: Id766ab16a8d342bf7322a90e076e801271d527d4
      aaa4e347
  12. 28 10月, 2015 2 次提交
    • S
      Add -Werror -Wall -Wextra to compiler option. · bae34768
      Seigo Nonaka 提交于
      This is 2nd trial of I30a0914a4633bd93eb60957cdf378770f04d8428
      
      - To suppress noisy unused parameter warnings, comment out unused
        arguments.
      - Add -Werror for suppressing further warning.
      - Add -Wall -Wextra for safety.
      - Use "z" prefix for format string of size_t.
      
      Verified that compile succeeded on all arm,arm64,mips,x86,x86_64.
      
      Change-Id: I7ad208464486b8a35da53929cb1cfe541ed0052f
      bae34768
    • B
      Revert "Add -Werror -Wall -Wextra to compiler option." · b4c79918
      Bart Sears 提交于
      This reverts commit 63635cff.
      
      Change-Id: I2b4b10e8afedc85dbe2d07f3e47315652b65cd14
      b4c79918
  13. 27 10月, 2015 1 次提交
    • S
      Add -Werror -Wall -Wextra to compiler option. · 63635cff
      Seigo Nonaka 提交于
      - To suppress noisy unused parameter warnings, comment out unused
        arguments.
      - Add -Werror for suppressing further warning.
      - Add -Wall -Wextra for safety.
      
      Change-Id: I30a0914a4633bd93eb60957cdf378770f04d8428
      63635cff
  14. 15 10月, 2015 1 次提交
  15. 18 9月, 2015 1 次提交
    • S
      Introduce unit tests for FontCollection::itemize. · 1c2bd209
      Seigo Nonaka 提交于
      Introduced tests depend on installed font list in running device.
      I verified these test passed  on Nexus 5(hammerhead), Nexus 6(shamu)
      and Nexus 9(volantis).
      
      Bug: 11256006
      Bug: 17759267
      Change-Id: I6f806370e17f6c6d3dad8df0cb70bb475a827873
      1c2bd209