Robot: Refactor BUILD files.

modules/map/data/BUILD

@@ -15,4 +15,3 @@ filegroup(
         "sunnyvale_loop/**",
     ]),
 )
-

third_party/adolc.BUILD

@@ -5,14 +5,15 @@ licenses(
     #       For ColPack, which is included by ADOL-C, is under LGPL v3.0.
     #       No derivative work or modification is made to the above two library.
     #       Only its generated binary is used.
-    ["reciprocal"])
+    ["reciprocal"],
+)
 
 cc_library(
     name = "adolc",
+    copts = ["-fPIC"],
     includes = ["."],
-    copts = [ "-fPIC" ],
     linkopts = [
         "-L/usr/local/adolc/lib64 -ladolc",
-        "-lgomp"
+        "-lgomp",
     ],
 )

third_party/adv_plat.BUILD

@@ -14,8 +14,7 @@ cc_library(
         "include/linux/bcan_defs.h",
         "include/linux/zynq_api.h",
     ],
-    include_prefix="adv_plat",
+    include_prefix = "adv_plat",
     linkopts = [
     ],
 )
-

third_party/cuda.BUILD

@@ -2,13 +2,11 @@ package(default_visibility = ["//visibility:public"])
 
 licenses(["notice"])
 
-
-
 cc_library(
     name = "cuda",
     includes = ["include"],
     linkopts = [
-	"-L/usr/lib/x86_64-linux-gnu/",
+        "-L/usr/lib/x86_64-linux-gnu/",
         "-lgomp",
         "-L/usr/local/cuda/lib64",
         "-lOpenCL",

third_party/fastrtps.BUILD

@@ -4,10 +4,8 @@ cc_library(
         "lib/*.so.*",
         "lib/*.so",
     ]),
-
     includes = [
         "include",
     ],
-
     visibility = ["//visibility:public"],
 )

third_party/ffmpeg.BUILD

@@ -4,18 +4,18 @@ licenses(["notice"])
 
 cc_library(
     name = "ffmpeg",
-    hdrs = glob(["*"]),
     srcs = glob(["lib/*.so"]),
-    includes = [
-        "include",
-    ],
+    hdrs = glob(["*"]),
     copts = [
         "-Iinclude",
     ],
+    includes = [
+        "include",
+    ],
     linkopts = [
         "-Llib",
         "-lavcodec",
         "-lavutil",
         "-lswresample",
-    ]
+    ],
 )

third_party/glog.BUILD

@@ -8,7 +8,7 @@ cc_library(
         ".",
     ],
     linkopts = [
-	"-L/usr/local/lib",
+        "-L/usr/local/lib",
         "-lglog",
         "-lgflags",
     ],

third_party/ipopt.BUILD

@@ -4,8 +4,8 @@ licenses(["notice"])
 
 cc_library(
     name = "ipopt",
+    copts = ["-fPIC"],
     includes = ["."],
-    copts = [ "-fPIC"],
     linkopts = [
         "-L/usr/local/ipopt/lib -lipopt",
         "-L/usr/local/ipopt/lib -lcoinmumps",

third_party/libprotobuf_mutator.BUILD

 package(default_visibility = ["//visibility:public"])
+
 cc_library(
     name = "mutator",
-    srcs = glob(["src/**/*.cc","src/**/*.h","port/protobuf.h"],exclude=["**/*_test.cc"]),
+    srcs = glob(
+        [
+            "src/**/*.cc",
+            "src/**/*.h",
+            "port/protobuf.h",
+        ],
+        exclude = ["**/*_test.cc"],
+    ),
     hdrs = ["src/libfuzzer/libfuzzer_macro.h"],
     deps = ["@com_google_protobuf//:protobuf"],
 )
+
 cc_binary(
     name = "libprotobuf_mutator",
-    srcs = ["src/main.cc",],
+    srcs = ["src/main.cc"],
     deps = [
         ":libprotobuf_mutator_lib",
     ],
-)
\ No newline at end of file
+)

third_party/osqp.BUILD

@@ -4,14 +4,13 @@ licenses(["notice"])
 
 cc_library(
     name = "osqp",
+    include_prefix = "osqp",
     includes = [
-	".",
+        ".",
     ],
-    include_prefix = "osqp",
     linkopts = [
-	"-L/usr/local/lib",
+        "-L/usr/local/lib",
         "-Wl,-rpath,/usr/lib/x86_64-linux-gnu/",
-	"-losqp",
+        "-losqp",
     ],
 )
-

third_party/pytorch.BUILD

@@ -4,22 +4,22 @@ licenses(["notice"])
 
 cc_library(
     name = "pytorch",
-    hdrs = glob(["*"]),
     srcs = glob(["lib/*.so"]),
-    includes = [
-        "include",
-        "include/torch/csrc/api/include",
-        "include/torch/csrc/api/include/torch"
-    ],
+    hdrs = glob(["*"]),
     copts = [
         "-Iinclude",
         "-Iinclude/torch",
         "-Iinclude/torch/csrc/api/include/torch",
     ],
+    includes = [
+        "include",
+        "include/torch/csrc/api/include",
+        "include/torch/csrc/api/include/torch",
+    ],
     linkopts = [
         "-Llib",
     ],
     deps = [
         "@python27",
-    ]
+    ],
 )

third_party/pytorch_gpu.BUILD

@@ -4,23 +4,22 @@ licenses(["notice"])
 
 cc_library(
     name = "pytorch_gpu",
-    hdrs = glob(["*"]),
     srcs = glob(["lib/*.so"]),
-    includes = [
-        "include",
-        "include/torch/csrc/api/include",
-        "include/torch/csrc/api/include/torch"
-    ],
+    hdrs = glob(["*"]),
     copts = [
         "-Iinclude",
         "-Iinclude/torch",
         "-Iinclude/torch/csrc/api/include/torch",
     ],
+    includes = [
+        "include",
+        "include/torch/csrc/api/include",
+        "include/torch/csrc/api/include/torch",
+    ],
     linkopts = [
         "-Llib",
     ],
     deps = [
         "@python27",
-    ]
+    ],
 )
-

third_party/qpOASES.BUILD

@@ -8,8 +8,6 @@ exports_files(["qpOASES/LICENSE"])
 
 cc_library(
     name = "qpOASES",
-    linkstatic = False,
-    tags = ["manual"],
     srcs = [
         "src/BLASReplacement.cpp",
         "src/Bounds.cpp",
@@ -84,5 +82,7 @@ cc_library(
         "include",
         "src",
     ],
+    linkstatic = False,
+    tags = ["manual"],
     visibility = ["//visibility:public"],
 )

third_party/qt.BUILD

 cc_library(
     name = "qt_core",
     hdrs = glob(["*"]),
-    includes = ["include", "include/QtCore"],
-    copts=[
+    copts = [
         "-Iinclude",
         "-Iinclude/QtCore",
     ],
+    includes = [
+        "include",
+        "include/QtCore",
+    ],
     linkopts = [
         "-Wl,-rpath,/usr/local/Qt5.5.1/5.5/gcc_64/lib",
         "-lQt5Core",
@@ -16,53 +19,60 @@ cc_library(
 cc_library(
     name = "qt_widgets",
     hdrs = glob(["*"]),
-    includes = ["include/QtWidgets" ],
-    deps = [":qt_core"],
-    copts=[
+    copts = [
         "-Iinclude",
-#        "-Iinclude/QtCore",
+        #        "-Iinclude/QtCore",
         "-Iinclude/QtWidgets",
     ],
+    includes = ["include/QtWidgets"],
     linkopts = [
         "-L/usr/local/Qt5.5.1/5.5/gcc_64/lib",
         "-lQt5Widgets",
     ],
     visibility = ["//visibility:public"],
+    deps = [":qt_core"],
 )
 
 cc_library(
     name = "qt_gui",
     hdrs = glob(["*"]),
-    includes = ["include/QtGui"],
-    deps = [":qt_core", ":qt_widgets"],
-    copts=[
+    copts = [
         "-Iinclude",
-       # "-Iinclude/QtCore",
+        # "-Iinclude/QtCore",
         "-Iinclude/QtGui",
-       # "-Iinclude/QtWidgets",
+        # "-Iinclude/QtWidgets",
     ],
+    includes = ["include/QtGui"],
     linkopts = [
         "-L/usr/local/Qt5.5.1/5.5/gcc_64/lib",
         "-lQt5Gui",
     ],
     visibility = ["//visibility:public"],
+    deps = [
+        ":qt_core",
+        ":qt_widgets",
+    ],
 )
 
 cc_library(
     name = "qt_opengl",
     hdrs = glob(["*"]),
-    includes = ["include/QtOpenGL"],
-    deps = [":qt_core", ":qt_widgets", ":qt_gui"],
-    copts=[
+    copts = [
         "-Iinclude",
         "-Iinclude/QtCore",
         "-Iinclude/QtWidgets",
         "-Iinclude/QtGui",
         "-Iinclude/QtOpenGL",
     ],
+    includes = ["include/QtOpenGL"],
     linkopts = [
         "-L/usr/local/Qt5.5.1/5.5/gcc_64/lib",
         "-lQt5OpenGL",
     ],
     visibility = ["//visibility:public"],
+    deps = [
+        ":qt_core",
+        ":qt_gui",
+        ":qt_widgets",
+    ],
 )

third_party/ros.BUILD

@@ -23,9 +23,9 @@ cc_library(
         "lib/libroscpp_serialization.so",
         "lib/libroslz4.so",
         "lib/librostime.so",
-#        "lib/libtf.so",
-#        "lib/libtf2.so",
-#        "lib/libtf2_ros.so",
+        #        "lib/libtf.so",
+        #        "lib/libtf2.so",
+        #        "lib/libtf2_ros.so",
         "lib/libtopic_tools.so",
         "lib/libxmlrpcpp.so",
         "lib/libmessage_filters.so",

third_party/rss/BUILD

@@ -4,15 +4,14 @@ licenses(["notice"])
 
 cc_library(
     name = "rss",
+    srcs = [
+        "lib/librss_module.so",
+        "lib/librss_support.so",
+    ],
     hdrs = glob([
-        "include/**/*.hpp"
+        "include/**/*.hpp",
     ]),
     includes = [
         "include",
     ],
-    srcs = [
-        "lib/librss_module.so",
-        "lib/librss_support.so",
-    ]
 )
-

third_party/rss_lib.BUILD

@@ -4,7 +4,6 @@ package(
 
 licenses(["notice"])
 
-
 cc_library(
     name = "ad_rss",
     srcs = [
@@ -38,8 +37,22 @@ cc_library(
         "src/world/RssObjectPositionExtractor.cpp",
     ] + glob(["src/**/*.hpp"]),
     hdrs = glob(["include/**/*.hpp"]),
-    copts = ["-fPIC","-std=c++11","-Werror","-Wall","-Wextra","-pedantic","-Wconversion", "-Wsign-conversion"],
-    includes = ["include", "include/generated", "src", "tests/test_support"], 
+    copts = [
+        "-fPIC",
+        "-std=c++11",
+        "-Werror",
+        "-Wall",
+        "-Wextra",
+        "-pedantic",
+        "-Wconversion",
+        "-Wsign-conversion",
+    ],
+    includes = [
+        "include",
+        "include/generated",
+        "src",
+        "tests/test_support",
+    ],
 )
 
 ################################################################################

third_party/tensorrt.BUILD

@@ -12,9 +12,12 @@ licenses([
     "notice",  # Portions BSD
 ])
 
-
 cc_library(
     name = "tensorrt",
+    includes = [
+        ".",
+        "/usr/include/tensorrt",
+    ],
     linkopts = [
         "-L/usr/lib/x86_64-linux-gnu/",
         "-lnvcaffe_parser",
@@ -22,7 +25,5 @@ cc_library(
         "-lnvinfer_plugin",
         "-lnvparsers",
     ],
-
-    includes = [".","/usr/include/tensorrt",],
     visibility = ["//visibility:public"],
 )

third_party/tf2/BUILD

@@ -5,17 +5,21 @@ licenses(["notice"])
 
 cc_library(
     name = "tf2",
-    hdrs = glob([
-        "include/**/*.h"
-    ]),
-    includes = [
-        "include",
-    ],
     srcs = [
         "src/buffer_core.cpp",
         "src/cache.cpp",
         "src/static_cache.cpp",
         "src/time.cpp",
     ],
-    linkopts = ["-lboost_signals -lboost_system -lboost_thread"]
+    hdrs = glob([
+        "include/**/*.h",
+    ]),
+    includes = [
+        "include",
+    ],
+    linkopts = [
+        "-lboost_signals",
+        "-lboost_system",
+        "-lboost_thread",
+    ],
 )