- 21 10月, 2015 9 次提交
-
-
由 Sean Griffin 提交于
Prior to this commit, Rails makes no differentiation between whether a query uses bind parameters, and whether or not we cache that query as a prepared statement. This leads to the cache populating extremely fast in some cases, with the statements never being reused. In particular, the two problematic cases are `where(foo: [1, 2, 3])` and `where("foo = ?", 1)`. In both cases we'll end up quoting the values rather than using a bind param, causing a cache entry for every value ever used in that query. It was noted that we can probably eventually change `where("foo = ?", 1)` to use a bind param, which would resolve that case. Additionally, on PG we can change our generated query to be `WHERE foo = ANY($1)`, and pass an array for the bind param. I hope to accomplish both in the future. For SQLite and MySQL, we still end up preparing the statements anyway, we just don't cache it. The statement will be cleaned up after it is executed. On postgres, we skip the prepare step entirely, as an API is provided to execute with bind params without preparing the statement. I'm not 100% happy on the way this ended up being structured. I was hoping to use a decorator on the visitor, rather than mixing a module into the object, but the way Arel has it's visitor pattern set up makes it very difficult to extend without inheritance. I'd like to remove the duplication from the various places that are extending it, but that'll require a larger restructuring of that initialization logic. I'm going to take another look at the structure of it soon. This changes the signature of one of the adapter's internals, and will require downstream changes from third party adapters. I'm not too worried about this, as worst case they can simply add the parameter and always ignore it, and just keep their previous behavior. Fixes #21992.
-
由 Sean Griffin 提交于
Add stored procedure test in mysql2
-
由 Sean Griffin 提交于
Fix to correctly schema dump the `tinyblob`
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Reorder application of has_many association constraints.
-
由 kal 提交于
-
由 Rafael Mendonça França 提交于
nodoc for active support protected method [CI skip]
-
- 20 10月, 2015 9 次提交
-
-
由 Yves Senn 提交于
Delete needless `require 'active_support/deprecation'`
-
由 Yves Senn 提交于
[ci skip] Replace "destroy` method" with `destroy` action`
-
由 yui-knk 提交于
Sure this is `destroy` method of PhotosController, but in this chapter these methods which mapped by the router are called "action". For example: ```ruby get '/patients/:id', to: 'patients#show' ``` is described to dispatch "controller's `show` action".
-
由 yui-knk 提交于
When `require 'active_support/rails'`, 'active_support/deprecation' is automatically loaded.
-
由 Sean Griffin 提交于
Fix #21977: Removes memoization of helpers in Rails console
-
由 Sean Griffin 提交于
Green version of moving the handling of supported arguments to `where`
-
由 Sean Griffin 提交于
Added context for running engine:migrations:install task. [ci skip]
-
由 Simon H 提交于
-
由 Claudio B. 提交于
Remove outdated documentation regarding a bundled version of TZInfo
-
- 19 10月, 2015 4 次提交
-
-
由 Santiago Pastorino 提交于
Show helpful messages on invalid param. encodings
-
由 Agis Anastasopoulos 提交于
Prior to this change, given a route: # config/routes.rb get ':a' => "foo#bar" If one pointed to http://example.com/%BE (param `a` has invalid encoding), a `BadRequest` would be raised with the following non-informative message: ActionController::BadRequest From now on the message displayed is: Invalid parameter encoding: hi => "\xBE" Fixes #21923.
-
由 jbranchaud 提交于
With `unscope!` called last, it undoes `where` constraints of the same value when the `where` is chained after the `unscope`. This is what a `rewhere` does. This is undesirable behavior. The included tests demonstrate both the `unscope(...).where(...)` behavior as well as the direct use of `rewhere(...)`. This is in reference to #21955.
-
由 Phil Ross 提交于
The bundled version of TZInfo referred to was removed from Active Support in version 3.0.
-
- 18 10月, 2015 6 次提交
-
-
由 Arthur Nogueira Neves 提交于
remove useless method
-
由 Eileen M. Uchitelle 提交于
[ci skip] Improve readability in active model basics guide
-
由 Tim Wade 提交于
* adds/removes a few words * removes an unnecessary comma
-
由 yuuji.yaginuma 提交于
`images` method has been deleted in 2bc48561, `create_images_directory` does nothing.
-
由 Rafael Mendonça França 提交于
This reverts commit 4d8f62dc. Reason: This broke the build. Please recommit again when it is green.
-
- 17 10月, 2015 9 次提交
-
-
由 Yves Senn 提交于
Suppress warnings of `assigned but unused variable`
-
由 Richard Schneeman 提交于
Use "rake time:zones:all" instead of "rake -D time" [ci skip]
-
由 yui-knk 提交于
-
由 Marat Galiev 提交于
-
由 Charles Treatman 提交于
In the Rails console, the `helper` function provides a shorthand for working with application helpers. However, `helper` memoizes the value of `ApplicationController#helpers`. This means that if a user subsequently changes helper code and calls `reload!` in the console, their code changes will not be reflected by the `helper` function, even though the helper was, in fact, reloaded.
-
由 schneems 提交于
If you can't start your queue, you won't process much. This change adds external links to the Queue backends that have Active Job specific docs.
-
由 Sean Griffin 提交于
`WhereClauseFactory` handles all other branches based on argument types, so the code fits more naturally here, and it's just where the responsibility belongs.
-
由 Matthew Draper 提交于
Fix deprecation warning messages on deprecate_methods
-
由 Sean Griffin 提交于
where raises ArgumentError on unsupported argument types
-
- 16 10月, 2015 3 次提交
-
-
由 Jake Worth 提交于
[#20473]
-
由 Yves Senn 提交于
Remove mentioned of 'readonly' options in doc for HABTM [ci skip]
-
由 Ignatius Reza 提交于
-