1. 13 2月, 2016 1 次提交
    • G
      use rails instead of rake · 33e202d3
      Gaurav Sharma 提交于
      since starting with Rails 5.x(beta) we prefer to use rails as the replacement of rake commands, may be change log will be the same
      33e202d3
  2. 11 2月, 2016 5 次提交
    • S
      Ensure prepared statement caching still occurs with Adequate Record · 2a56b2d9
      Sean Griffin 提交于
      In Rails 5, we're much more restrictive about when we do or don't cache
      a prepared statement. In particular, we never cache when we are sending
      an IN statement or a SQL string literal
      
      However, in the case of Adequate Record, we are *always* sending a raw
      SQL string, and we *always* want to cache the result.
      
      Fixes #23507
      
      /cc @tgxworld
      2a56b2d9
    • Y
      remove warnings from FinderMethods · 424b2019
      yuuji.yaginuma 提交于
      This removes the following warnings.
      
      ```
      activerecord/lib/active_record/relation/finder_methods.rb:252: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:258: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:268: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:274: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      ```
      424b2019
    • A
      build scope chain functionally and remove caching · 3553fe03
      Aaron Patterson 提交于
      This commit walks the reflection tree and builds the scope chain
      functionally.  It also removes the chain cache since the cache doesn't
      seem to have any impact on performance (I'd prefer to only cache at
      proven bottlenecks)
      3553fe03
    • B
      eaa1efe7
    • B
      rename to 'second_to_last' and 'third_to_last' · e8aeda2a
      Brian Christian 提交于
      e8aeda2a
  3. 10 2月, 2016 2 次提交
  4. 08 2月, 2016 2 次提交
  5. 07 2月, 2016 2 次提交
    • V
      fix indentation · 87f060a7
      Vijay Dev 提交于
      87f060a7
    • M
      Added numeric helper into migrations. · aa38f7d6
      Mehmet Emin İNAÇ 提交于
      With this addition, you can add a column into the table like:
      
      ```
        create_table(:numeric_types) do |t|
          t.numeric :foo, precision: 10, scale: 2, default: 2.0
        end
      ```
      
      The result of the migration above is same with:
      
      ```
        create_table(:numeric_types) do |t|
          t.decimal :foo, precision: 10, scale: 2, default: 2.0
        end
      ```
      aa38f7d6
  6. 06 2月, 2016 4 次提交
  7. 05 2月, 2016 2 次提交
  8. 04 2月, 2016 7 次提交
  9. 03 2月, 2016 6 次提交
  10. 02 2月, 2016 6 次提交
    • Y
      Remove unnecessary overriding of `#initialize` · daf0f23b
      yui-knk 提交于
      `#initialize` of `HasManyReflection`, `HasOneReflection` and
      `BelongsToReflection` only pass all arguments to `super` by passed order.
      These overriding can be removed.
      daf0f23b
    • P
      Remove unused class AttributeMethodCache · e944e670
      PareshGupta 提交于
      e944e670
    • R
      Add some Action Cable CHANGELOG entries · 60b040e3
      Rafael Mendonça França 提交于
      And improve changelongs.
      
      [ci skip]
      60b040e3
    • S
      Preparing for Rails 5.0.0.beta2 · 49f6ce63
      Sean Griffin 提交于
      49f6ce63
    • J
      Fix corrupt transaction state caused by `before_commit` exceptions · 8fd123f7
      Jeremy Daer 提交于
      When a `before_commit` callback raises, the database is rolled back but
      AR's record of the current transaction is not, leaving the connection in
      a perpetually broken state that affects all future users of the
      connection: subsequent requests, jobs, etc. They'll think a transaction
      is active when none is, so they won't BEGIN on their own. This manifests
      as missing `after_commit` callbacks and broken ROLLBACKs.
      
      This happens because `before_commit` callbacks fire before the current
      transaction is popped from the stack, but the exception-handling path
      they hit assumes that the current transaction was already popped. So the
      database ROLLBACK is issued, but the transaction stack is left intact.
      
      Common cause: deadlocked `#touch`, which is now implemented with
      `before_commit` callbacks.
      
      What's next:
      * We shouldn't allow active transaction state when checking in or out
        from the connection pool. Verify that conns are clean.
      * Closer review of txn manager sad paths. Are we missing other spots
        where we'd end up with incorrect txn state? What's the worst that can
        happen if txn state drifts? How can we guarantee it doesn't and
        contain the fallout if it does?
      
      Thanks for @tomafro for expert diagnosis!
      8fd123f7
    • S
      Revert "Merge pull request #16400 from bogdan/last-with-sql" · 0cbcae59
      Sean Griffin 提交于
      This reverts commit 9f3730a5, reversing
      changes made to 2637fb75.
      
      There are additional issues with this commit that need to be addressed
      before this change is ready (see #23377). This is a temporary revert in
      order for us to have more time to address the issues with that PR,
      without blocking the release of beta2.
      0cbcae59
  11. 01 2月, 2016 3 次提交