1. 29 12月, 2017 1 次提交
  2. 17 12月, 2017 1 次提交
    • E
      Don't include ellipsis in truncated digest output · b9e7c676
      Eugene Kenny 提交于
      Using `truncate` to limit the length of the digest has the unwanted side
      effect of adding an ellipsis when the input is longer than the limit.
      
      Also:
       - Don't instantiate a new object for every digest
       - Rename the configuration option to `hash_digest_class`
       - Update the CHANGELOG entry to describe how to use the feature
      b9e7c676
  3. 13 12月, 2017 1 次提交
  4. 12 12月, 2017 1 次提交
  5. 29 11月, 2017 1 次提交
  6. 28 11月, 2017 1 次提交
  7. 23 11月, 2017 1 次提交
  8. 21 11月, 2017 1 次提交
  9. 15 11月, 2017 2 次提交
    • A
      Handle `TZInfo::AmbiguousTime` errors · 2eea6458
      Andrew White 提交于
      Make `ActiveSupport::TimeWithZone` match Ruby's handling of ambiguous
      times by choosing the later period, e.g.
      
      Ruby:
      ```
      ENV["TZ"] = "Europe/Moscow"
      Time.local(2014, 10, 26, 1, 0, 0)   # => 2014-10-26 01:00:00 +0300
      ```
      
      Before:
      ```
      >> "2014-10-26 01:00:00".in_time_zone("Moscow")
      TZInfo::AmbiguousTime: 26/10/2014 01:00 is an ambiguous local time.
      ```
      
      After:
      ```
      >> "2014-10-26 01:00:00".in_time_zone("Moscow")
      => Sun, 26 Oct 2014 01:00:00 MSK +03:00
      ```
      
      Fixes #17395.
      2eea6458
    • B
      Fix activesupport/CHANGELOG.md [ci skip] · 703478d3
      bogdanvlviv 提交于
      703478d3
  10. 14 11月, 2017 2 次提交
    • J
      Cache: Enable compression by default for values > 1kB. · ed100166
      Jeremy Daer 提交于
      Compression has long been available, but opt-in and at a 16kB threshold.
      It wasn't enabled by default due to CPU cost. Today it's cheap and
      typical cache data is eminently compressible, such as HTML or JSON
      fragments.
      
      Compression dramatically reduces Memcached/Redis mem usage, which means
      the same cache servers can store more data, which means higher hit
      rates.
      
      To disable compression, pass `compress: false` to the initializer.
      ed100166
    • J
      Built-in Redis cache store · 9f8ec353
      Jeremy Daer 提交于
      * Supports vanilla Redis, hiredis, and Redis::Distributed.
      * Supports Memcached-like sharding across Redises with Redis::Distributed.
      * Fault tolerant. If the Redis server is unavailable, no exceptions are
        raised. Cache fetches are treated as misses and writes are dropped.
      * Local cache. Hot in-memory primary cache within block/middleware scope.
      * `read_/write_multi` support for Redis mget/mset. Use Redis::Distributed
        4.0.1+ for distributed mget support.
      * `delete_matched` support for Redis KEYS globs.
      9f8ec353
  11. 10 11月, 2017 1 次提交
  12. 08 11月, 2017 1 次提交
    • A
      Allow `Range#include?` on TWZ ranges · 2b434d6f
      Andrew White 提交于
      In #11474 we prevented TWZ ranges being iterated over which matched
      Ruby's handling of Time ranges and as a consequence `include?` stopped
      working with both Time ranges and TWZ ranges. However in
      ruby/ruby@b061634 support was added for `include?` to use `cover?` for
      'linear' objects. Since we have no way of making Ruby consider TWZ
      instances as 'linear' we have to override `Range#include?`.
      
      Fixes #30799.
      2b434d6f
  13. 06 11月, 2017 1 次提交
    • A
      Fix acronym support in `humanize` · 0ddde0a8
      Andrew White 提交于
      Acronym inflections are stored with lowercase keys in the hash but
      the match wasn't being lowercased before being looked up in the hash.
      This shouldn't have any performance impact because before it would
      fail to find the acronym and perform the `downcase` operation anyway.
      
      Fixes #31052.
      0ddde0a8
  14. 25 10月, 2017 3 次提交
  15. 24 10月, 2017 2 次提交
  16. 23 10月, 2017 1 次提交
  17. 21 10月, 2017 1 次提交
    • A
      Let Hash#slice return a Hash · 01ae3966
      Akira Matsuda 提交于
      In order to keep this method compatible with the Ruby 2.5 version of Hash#slice.
      This bahavior is actually slightly incompatibile with previous versions of Active Support
      but it might not cause a real problem, since HWIA, the biggest use case of Hash subclassing here,
      already overrides `slice` to return another HWIA.
      01ae3966
  18. 04 10月, 2017 1 次提交
  19. 29 9月, 2017 1 次提交
  20. 27 9月, 2017 1 次提交
  21. 24 9月, 2017 1 次提交
  22. 17 9月, 2017 1 次提交
  23. 12 9月, 2017 1 次提交
    • D
      Add credentials using a generic EncryptedConfiguration class (#30067) · 69f976b8
      David Heinemeier Hansson 提交于
      * WIP: Add credentials using a generic EncryptedConfiguration class
      
      This is sketch code so far.
      
      * Flesh out EncryptedConfiguration and test it
      
      * Better name
      
      * Add command and generator for credentials
      
      * Use the Pathnames
      
      * Extract EncryptedFile from EncryptedConfiguration and add serializers
      
      * Test EncryptedFile
      
      * Extract serializer validation
      
      * Stress the point about losing comments
      
      * Allow encrypted configuration to be read without parsing for display
      
      * Use credentials by default and base them on the master key
      
      * Derive secret_key_base in test/dev, source it from credentials in other envs
      
      And document the usage.
      
      * Document the new credentials setup
      
      * Stop generating the secrets.yml file now that we have credentials
      
      * Document what we should have instead
      
      Still need to make it happen, tho.
      
      * [ci skip] Keep wording to `key base`; prefer defaults.
      
      Usually we say we change defaults, not "spec" out a release.
      
      Can't use backticks in our sdoc generated documentation either.
      
      * Abstract away OpenSSL; prefer MessageEncryptor.
      
      * Spare needless new when raising.
      
      * Encrypted file test shouldn't depend on subclass.
      
      * [ci skip] Some woordings.
      
      * Ditch serializer future coding.
      
      * I said flip it. Flip it good.
      
      * [ci skip] Move require_master_key to the real production.rb.
      
      * Add require_master_key to abort the boot process.
      
      In case the master key is required in a certain environment
      we should inspect that the key is there and abort if it isn't.
      
      * Print missing key message and exit immediately.
      
      Spares us a lengthy backtrace and prevents further execution.
      
      I've verified the behavior in a test app, but couldn't figure the
      test out as loading the app just exits immediately with:
      
      ```
      /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError)
      	from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run'
      	from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method'
      	from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start'
      ```
      
      It's likely we need to capture and prevent the exit somehow.
      Kernel.stub(:exit) didn't work. Leaving it for tomorrow.
      
      * Fix require_master_key config test.
      
      Loading the app would trigger the `exit 1` per require_master_key's
      semantics, which then aborted the test.
      
      Fork and wait for the child process to finish, then inspect the
      exit status.
      
      Also check we aborted because of a missing master key, so something
      else didn't just abort the boot.
      
      Much <3 to @tenderlove for the tip.
      
      * Support reading/writing configs via methods.
      
      * Skip needless deep symbolizing.
      
      * Remove save; test config reader elsewhere.
      
      * Move secret_key_base check to when we're reading it.
      
      Otherwise we'll abort too soon since we don't assign the secret_key_base
      to secrets anymore.
      
      * Add missing string literal comments; require unneeded yaml require.
      
      * ya ya ya, rubocop.
      
      * Add master_key/credentials after bundle.
      
      Then we can reuse the existing message on `rails new bc4`.
      
      It'll look like:
      
      ```
      Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb)
      Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails`
      Using sass-rails 5.0.6
      Bundle complete! 16 Gemfile dependencies, 72 gems now installed.
      Use `bundle info [gemname]` to see where a bundled gem is installed.
      Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0
      
      Save this in a password manager your team can access.
      
      If you lose the key, no one, including you, can access anything encrypted with it.
      
            create  config/master.key
      ```
      
      And that'll be executed even if `--skip-bundle` was passed.
      
      * Ensure test app has secret_key_base.
      
      * Assign secret_key_base to app or omit.
      
      * Merge noise
      
      * Split options for dynamic delegation into its own method and use deep symbols to make it work
      
      * Update error to point to credentials instead
      
      * Appease Rubocop
      
      * Validate secret_key_base when reading it.
      
      Instead of relying on the validation in key_generator move that into
      secret_key_base itself.
      
      * Fix generator and secrets test.
      
      Manually add config.read_encrypted_secrets since it's not there by default
      anymore.
      
      Move mentions of config/secrets.yml to config/credentials.yml.enc.
      
      * Remove files I have no idea how they got here.
      
      * [ci skip] swap secrets for credentials.
      
      * [ci skip] And now, changelogs are coming.
      69f976b8
  24. 13 8月, 2017 1 次提交
    • A
      Test for the new exception of delegate_missing_to (#30191) · e6c310b3
      Anton Khamets 提交于
      * Add test for the new exception of delegate_missing_to
      
      * Add a changelog entry
      
      * Only check for nil if NoMethodError was raised
      
      * Make method private
      
      * Have to pass both target name and value
      
      * Inline the re-raise
      
      [Rafael Mendonça França + Anton Khamets]
      e6c310b3
  25. 07 8月, 2017 1 次提交
  26. 04 8月, 2017 1 次提交
  27. 03 8月, 2017 1 次提交
  28. 02 8月, 2017 1 次提交
  29. 28 7月, 2017 1 次提交
    • S
      Add missing support for modulo operations on durations · a54e13bd
      Sayan Chakraborty 提交于
      Rails 5.1 introduce an `ActiveSupport::Duration::Scalar` class as
      a wrapper around a numeric value as a way of ensuring a duration
      was the outcome of an expression. However the implementation was
      missing support for modulo operations. This commit adds support
      for those operations and should result in a duration being
      returned from expressions involving them.
      
      Fixes #29603 and #29743.
      a54e13bd
  30. 27 7月, 2017 1 次提交
    • A
      Fix division where a duration is the denominator · bfa878d3
      Andrew White 提交于
      PR #29163 introduced a change in behavior when a duration was
      the denominator in a calculation - this was incorrect as dividing
      by a duration should always return a `Numeric`. The behavior of
      previous versions of Rails has been restored.
      
      Fixes #29592.
      bfa878d3
  31. 24 7月, 2017 2 次提交
  32. 10 7月, 2017 1 次提交
  33. 12 6月, 2017 1 次提交
  34. 07 6月, 2017 1 次提交
    • J
      Cache: write_multi (#29366) · 2b96d582
      Jeremy Daer 提交于
      Rails.cache.write_multi foo: 'bar', baz: 'qux'
      
      Plus faster `fetch_multi` with stores that implement `write_multi_entries`.
      Keys that aren't found may be written to the cache store in one shot
      instead of separate writes.
      
      The default implementation simply calls `write_entry` for each entry.
      Stores may override if they're capable of one-shot bulk writes, like
      Redis `MSET`.
      2b96d582