1. 22 4月, 2018 1 次提交
  2. 19 4月, 2018 2 次提交
    • G
      Redis cache store: avoid blocking the server in `#delete_matched` · ef2af628
      Gleb Mazovetskiy 提交于
      Fixes #32610. Closes #32614.
      
      Lua scripts in redis are *blocking*, meaning that no other client can
      execute any commands while the script is running. See
      https://redis.io/commands/eval#atomicity-of-scripts.
      
      This results in the following exceptions once the number of keys is
      sufficiently large:
      
          BUSY Redis is busy running a script.
          You can only call SCRIPT KILL or SHUTDOWN NOSAVE.
      
      This commit replaces the lua-based implementation with one that uses
      `SCAN` and `DEL` in batches. This doesn't block the server.
      
      The primary limitation of `SCAN`, i.e. potential duplicate keys, is of
      no consequence here, because `DEL` ignores keys that do not exist.
      ef2af628
    • D
      Fix exception in AS::Timezone.all when any tzinfo data is missing · 7d25b651
      Dominik Sander 提交于
      Before this change missing timezone data for any of the time zones
      defined in `ActiveSupport::Timezone::MAPPING` caused a `comparison of
      NilClass with ActiveSupport::TimeZone failed` exception.
      
      Attempting to get a timezone by passing a number/duration to `[]` or
      calling `all` directly will try to sort sort the values of `zones_map`.
      Those values are initialized by the return value of `create(zonename)`
      which returns `nil` if `TZInfo` is unable to find the timezone
      information.
      
      In our case the exception was triggered by an outdated tzdata package
      which did not include information for the "recently" added time zones.
      
      Before 078421ba `zones_map` only
      returned the information that have been loaded into `@lazy_zone_map`
      which ignored time zones for which the data could not be loaded, this
      change restores the previous behaviour.
      7d25b651
  3. 12 4月, 2018 1 次提交
  4. 14 3月, 2018 1 次提交
  5. 12 3月, 2018 1 次提交
    • B
      Fix CHANGELOGs [ci skip] · dd075657
      bogdanvlviv 提交于
      - Add missing dots.
      - Remove reference to itself on GitHub.
        Usually, we add references to fixed issues only in a changelog.
      
      Follow up #32223
      dd075657
  6. 07 3月, 2018 2 次提交
    • N
      Add `before?` and `after?` methods to date and time classes · 20fa0d92
      Nick Holden 提交于
      Equality comparisons between dates and times can take some extra time to
      comprehend. I tend to think of a date or time as "before" or "after"
      another date or time, but I naturally read `<` and `>` as "less than"
      and "greater than." This change seeks to make date/time comparisons more
      human readable.
      20fa0d92
    • A
      URI.unescape handles mixed Unicode/escaped input · e52ab312
      Ashe Connor 提交于
      Previously, URI.enscape could handle Unicode input (without any actual
      escaped characters), or input with escaped characters (but no actual
      Unicode characters) - not both.
      
          URI.unescape("\xe3\x83\x90")  # => "バ"
          URI.unescape("%E3%83%90")  # => "バ"
          URI.unescape("\xe3\x83\x90%E3%83%90")  # =>
                                               # Encoding::CompatibilityError
      
      We need to let `gsub` handle this for us, and then force back to the
      original encoding of the input.  The result String will be mangled if
      the percent-encoded characters don't conform to the encoding of the
      String itself, but that goes without saying.
      Signed-off-by: NAshe Connor <ashe@kivikakk.ee>
      e52ab312
  7. 05 3月, 2018 1 次提交
  8. 28 2月, 2018 1 次提交
  9. 27 2月, 2018 2 次提交
  10. 26 2月, 2018 1 次提交
  11. 24 2月, 2018 1 次提交
  12. 19 2月, 2018 1 次提交
    • A
      Return all mappings for a timezone id in `country_zones` · 2d95956e
      Andrew White 提交于
      Some timezones like `Europe/London` have multiple mappings in
      `ActiveSupport::TimeZone::MAPPING` so return all of them instead
      of the first one found by using `Hash#value`. e.g:
      
        # Before
        ActiveSupport::TimeZone.country_zones("GB") # => ["Edinburgh"]
      
        # After
        ActiveSupport::TimeZone.country_zones("GB") # => ["Edinburgh", "London"]
      
      Fixes #31668.
      2d95956e
  13. 18 2月, 2018 3 次提交
  14. 16 2月, 2018 1 次提交
    • E
      Add test parallelization to Rails · 26821d9b
      eileencodes 提交于
      Provides both a forked process and threaded parallelization options. To
      use add `parallelize` to your test suite.
      
      Takes a `workers` argument that controls how many times the process
      is forked. For each process a new database will be created suffixed
      with the worker number; test-database-0 and test-database-1
      respectively.
      
      If `ENV["PARALLEL_WORKERS"]` is set the workers argument will be ignored
      and the environment variable will be used instead. This is useful for CI
      environments, or other environments where you may need more workers than
      you do for local testing.
      
      If the number of workers is set to `1` or fewer, the tests will not be
      parallelized.
      
      The default parallelization method is to fork processes. If you'd like to
      use threads instead you can pass `with: :threads` to the `parallelize`
      method. Note the threaded parallelization does not create multiple
      database and will not work with system tests at this time.
      
      parallelize(workers: 2, with: :threads)
      
      The threaded parallelization uses Minitest's parallel exector directly.
      The processes paralleliztion uses a Ruby Drb server.
      
      For parallelization via threads a setup hook and cleanup hook are
      provided.
      
      ```
      class ActiveSupport::TestCase
        parallelize_setup do |worker|
          # setup databases
        end
      
        parallelize_teardown do |worker|
          # cleanup database
        end
      
        parallelize(workers: 2)
      end
      ```
      
      [Eileen M. Uchitelle, Aaron Patterson]
      26821d9b
  15. 02 2月, 2018 1 次提交
  16. 31 1月, 2018 1 次提交
  17. 23 1月, 2018 1 次提交
  18. 19 1月, 2018 1 次提交
    • J
      Support hash as first argument in `assert_difference`. (#31600) · e0f0d717
      Julien Meichelbeck 提交于
      * Support hash as first argument for `assert_difference`.
      
      This allows to specify multiple numeric differences in the same assertion.
      Example:
      
          assert_difference 'Article.count' => 1, 'Notification.count' => 2 do
            # post :create, params: { article: {...} }
          end
      
      * Support error message when passing a hash as a first parameter
      
      * Format CHANGELOG properly
      
      [Julien Meichelbeck + Rafael Mendonça França]
      e0f0d717
  19. 09 1月, 2018 1 次提交
  20. 29 12月, 2017 1 次提交
  21. 17 12月, 2017 1 次提交
    • E
      Don't include ellipsis in truncated digest output · b9e7c676
      Eugene Kenny 提交于
      Using `truncate` to limit the length of the digest has the unwanted side
      effect of adding an ellipsis when the input is longer than the limit.
      
      Also:
       - Don't instantiate a new object for every digest
       - Rename the configuration option to `hash_digest_class`
       - Update the CHANGELOG entry to describe how to use the feature
      b9e7c676
  22. 13 12月, 2017 1 次提交
  23. 12 12月, 2017 1 次提交
  24. 29 11月, 2017 1 次提交
  25. 28 11月, 2017 1 次提交
  26. 23 11月, 2017 1 次提交
  27. 21 11月, 2017 1 次提交
  28. 15 11月, 2017 2 次提交
    • A
      Handle `TZInfo::AmbiguousTime` errors · 2eea6458
      Andrew White 提交于
      Make `ActiveSupport::TimeWithZone` match Ruby's handling of ambiguous
      times by choosing the later period, e.g.
      
      Ruby:
      ```
      ENV["TZ"] = "Europe/Moscow"
      Time.local(2014, 10, 26, 1, 0, 0)   # => 2014-10-26 01:00:00 +0300
      ```
      
      Before:
      ```
      >> "2014-10-26 01:00:00".in_time_zone("Moscow")
      TZInfo::AmbiguousTime: 26/10/2014 01:00 is an ambiguous local time.
      ```
      
      After:
      ```
      >> "2014-10-26 01:00:00".in_time_zone("Moscow")
      => Sun, 26 Oct 2014 01:00:00 MSK +03:00
      ```
      
      Fixes #17395.
      2eea6458
    • B
      Fix activesupport/CHANGELOG.md [ci skip] · 703478d3
      bogdanvlviv 提交于
      703478d3
  29. 14 11月, 2017 3 次提交
    • J
      Cache: Enable compression by default for values > 1kB. · ed100166
      Jeremy Daer 提交于
      Compression has long been available, but opt-in and at a 16kB threshold.
      It wasn't enabled by default due to CPU cost. Today it's cheap and
      typical cache data is eminently compressible, such as HTML or JSON
      fragments.
      
      Compression dramatically reduces Memcached/Redis mem usage, which means
      the same cache servers can store more data, which means higher hit
      rates.
      
      To disable compression, pass `compress: false` to the initializer.
      ed100166
    • J
      Built-in Redis cache store · 9f8ec353
      Jeremy Daer 提交于
      * Supports vanilla Redis, hiredis, and Redis::Distributed.
      * Supports Memcached-like sharding across Redises with Redis::Distributed.
      * Fault tolerant. If the Redis server is unavailable, no exceptions are
        raised. Cache fetches are treated as misses and writes are dropped.
      * Local cache. Hot in-memory primary cache within block/middleware scope.
      * `read_/write_multi` support for Redis mget/mset. Use Redis::Distributed
        4.0.1+ for distributed mget support.
      * `delete_matched` support for Redis KEYS globs.
      9f8ec353
    • D
      `assert_changes` should always assert some change · af0361da
      Daniel Ma 提交于
      While using `assert_changes`, I came across some unexpected behavior:
      if you provide a `to:` argument, and the expression matches but didn't
      actually change, the assertion will pass.
      
      The way `assert_changes` reads, I assumed that it would both assert
      that there was any change at all, _and_ that the expression changed to
      match my `to:` argument.
      
      In the case of just a `from:` argument, `assert_changes` does what I
      expect as well. It asserts that the before value `=== from` and that
      the after value changed.
      
      My key change is that `assert_changes` will now _always_ assert that
      expression changes, no matter what combination of `from:` and `to:`
      arguments
      af0361da
  30. 10 11月, 2017 1 次提交
  31. 08 11月, 2017 1 次提交
    • A
      Allow `Range#include?` on TWZ ranges · 2b434d6f
      Andrew White 提交于
      In #11474 we prevented TWZ ranges being iterated over which matched
      Ruby's handling of Time ranges and as a consequence `include?` stopped
      working with both Time ranges and TWZ ranges. However in
      ruby/ruby@b061634 support was added for `include?` to use `cover?` for
      'linear' objects. Since we have no way of making Ruby consider TWZ
      instances as 'linear' we have to override `Range#include?`.
      
      Fixes #30799.
      2b434d6f
  32. 06 11月, 2017 1 次提交
    • A
      Fix acronym support in `humanize` · 0ddde0a8
      Andrew White 提交于
      Acronym inflections are stored with lowercase keys in the hash but
      the match wasn't being lowercased before being looked up in the hash.
      This shouldn't have any performance impact because before it would
      fail to find the acronym and perform the `downcase` operation anyway.
      
      Fixes #31052.
      0ddde0a8