1. 21 7月, 2016 1 次提交
    • G
      Enforce minimal web-console version for Rails 5 · e072db77
      Genadi Samokovarov 提交于
      I dropped the version constraint in web-console with the idea it will be
      easier to upgrade the console between Rails releases. However, issues
      like #25899 started popping up.
      
      I'm reintroducing the constraint, but this time, I don't set an upper
      limit to the major version. This will keep the web-console in a version
      that always works for the current Rails version and can be easily
      upgraded to the last one with `bundle update`.
      
      We may need to backport this for Rails 5.0.1.
      
      Fixes #25899.
      e072db77
  2. 17 7月, 2016 1 次提交
  3. 02 7月, 2016 1 次提交
  4. 07 6月, 2016 1 次提交
  5. 04 6月, 2016 1 次提交
    • P
      Fix minor regression about old apps not getting per_form_csrf and... · a7adec93
      Prathamesh Sonpatki 提交于
      Fix minor regression about old apps not getting per_form_csrf and request_forgery_protection configs
      
      - Earlier per_form_csrf_tokens and request_forgery_protection config
        files were generated for old apps upgraded to Rails 5.
      - But when we collapsed all initializers into one file, the entire file
        does not get created for old apps.
      - This commit fixes it and also changes values for all new defaults for
        old apps so that they will not break.
      - Also added a test for `rails app:update`.
      a7adec93
  6. 01 6月, 2016 1 次提交
  7. 29 5月, 2016 1 次提交
  8. 23 4月, 2016 1 次提交
  9. 08 4月, 2016 1 次提交
  10. 22 3月, 2016 1 次提交
  11. 09 3月, 2016 1 次提交
  12. 08 3月, 2016 2 次提交
    • G
      Fix the tests after e5940003 · 61a51a5e
      Genadi Samokovarov 提交于
      61a51a5e
    • G
      Drop the explicit version requirements for web-console · e5940003
      Genadi Samokovarov 提交于
      Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
      however, the explicit 2.x requirement of `~> '2.0'` will prevent people
      from getting the fix with `bundle update` and they would have to
      explicitly set the constraint to `~> '3.0'`.
      
      For more information see: rails/web-console#178.
      
      I propose we drop the explicit version constraints in the Gemfile. Web
      Console has been relatively stable for the past couple of years, and I
      don't anticipate any major alterations, like we saw between major
      versions 1 and 2.
      e5940003
  13. 02 3月, 2016 2 次提交
  14. 01 3月, 2016 2 次提交
  15. 28 2月, 2016 1 次提交
  16. 27 2月, 2016 1 次提交
  17. 26 2月, 2016 1 次提交
  18. 25 2月, 2016 2 次提交
  19. 24 2月, 2016 1 次提交
  20. 17 2月, 2016 1 次提交
  21. 10 2月, 2016 2 次提交
  22. 04 2月, 2016 2 次提交
  23. 02 2月, 2016 1 次提交
  24. 31 1月, 2016 1 次提交
  25. 30 1月, 2016 1 次提交
    • S
      Add Default Puma Config · 5563c329
      schneems 提交于
      When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma.
      
      Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver.
      
      This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku. 
      
      We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier.
      
      cc/ @pixeltrix
      5563c329
  26. 29 1月, 2016 1 次提交
  27. 23 1月, 2016 1 次提交
  28. 22 1月, 2016 2 次提交
  29. 19 1月, 2016 2 次提交
  30. 31 12月, 2015 1 次提交
  31. 22 12月, 2015 2 次提交