- 27 7月, 2016 1 次提交
-
-
由 Santiago Pastorino 提交于
Merge pull request #25912 from stevenharman/fix_render_partial_collection_to_allow_custom_collection Changed partial rendering to allow collections which don't implement `#to_ary`.
-
- 26 7月, 2016 9 次提交
-
-
由 Steven Harman 提交于
We can safely assume we're not dealing with an infinite collection as we're about to call `each` on it and collect the results until it terminates on its own. Given that, `to_a` is implemented by the normal Array-like objects, and less Array-like objects like `Enumerator` and `Enumerator::Lazy`.
-
由 Santiago Pastorino 提交于
`load_target` is a public method
-
由 Steven Harman 提交于
This will ensure we attempt to render an empty collection, meaning we don't actually render anything at all. Allowing `nil` or a falsey value through results in calling `render_partial` rather than `render_collection`, which isn't what we want.
-
由 Steven Harman 提交于
-
由 Steven Harman 提交于
An optimization was introduced in https://github.com/rails/rails/commit/27f4ffd11a91b534fde9b484cb7c4e515ec0fe77 which tried to `#to_ary` the collection to prevent unnecessary queries for ActiveRecord scopes/relations. If the given collection did not respond to `#to_ary`, and empty collection was returned. That meant you couldn't use collections built from `Enumerator` nor `Enumerable`. With this change, `#collection_from_options` will attempt the optimization, but fall back to passing along the given collection, as-is.
-
由 Santiago Pastorino 提交于
Make `force_signal37_to_load_all_clients_of_firm` to private
-
由 Santiago Pastorino 提交于
Bump Arel to fix few failing tests on Ruby 2.4 related to the Integer unification
-
由 Ryuta Kamizono 提交于
This is not a test case.
-
由 Rafael França 提交于
Fix an exception where content-type is nil
-
- 25 7月, 2016 7 次提交
-
-
由 Julian Nadeau 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
Previously we had primarily tested the behavior of these attributes by calling `.new`, allowing this to slip through the cracks. There were a few ways in which they were behaving incorrectly. The biggest issue was that attempting to read the attribute would through a `MissingAttribute` error. We've corrected this by returning the default value when the attribute isn't backed by a database column. This is super special cased, but I don't see a way to avoid this conditional. I had considered handling this higher up in `define_default_attribute`, but we don't have the relevant information there as users can provide new defaults for database columns as well. Once I corrected this, I had noticed that the attributes were always being marked as changed. This is because the behavior of `define_default_attribute` was treating them as assigned from `Attribute::Null`. Finally, with our new implementation, `LazyAttributeHash` could no longer be marshalled, as it holds onto a proc. This has been corrected as well. I've not handled YAML in that class, as we do additional work higher up to avoid YAML dumping it at all. Fixes #25787 Close #25841
-
由 Xavier Noria 提交于
Where appropriate, prefer the more concise Regexp#match?, String#include?, String#start_with?, or String#end_with?
-
由 Xavier Noria 提交于
In Ruby ^ and $ mean start and end of *line*. A regexp that validates an email should not check if some line of the string looks like an email, and maybe be surrounded by the entire Joyce's Ulysses. What the regexp has to check is if the string itself looks like an email. This validator is used only in tests, the ^/$ anchors implied no risk.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
- 24 7月, 2016 6 次提交
-
-
由 प्रथमेश Sonpatki 提交于
Add proper description for `Rails.cache.fetch` [ci skip]
-
由 Santosh Wadghule 提交于
-
由 Prathamesh Sonpatki 提交于
* Following tests were failing on Ruby edge 2.4 version - - RelationTest#test_update_all_with_joins_and_offset_and_order: - RelationTest#test_update_all_with_joins_and_offset: - BasicsTest#test_no_limit_offset: - CalculationsTest#test_offset_is_kept: - ActiveRecord::CollectionCacheKeyTest#test_cache_key_for_queries_with_offset_which_return_0_rows: - FinderTest#test_third_to_last: * As Arel 7.1 supports Integer unification after https://github.com/rails/arel/pull/437 we can use it.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
It all started noticing some foo.method({ ... }) method calls in passing. This is a whole pass modernizing this file. While some string literals are edited where I touched code, this pass does not uniformizes quotes. A ton are left untouched on purposes. We have no defined style.
-
由 Xavier Noria 提交于
Where appropriatei, prefer the more concise Regexp#match?, String#include?, String#start_with?, or String#end_with?
-
- 23 7月, 2016 6 次提交
-
-
由 Ryuta Kamizono 提交于
`send` is unnecessary.
-
由 Kasper Timm Hansen 提交于
Explain meaning of the code very well and Remove confusion. [ci skip]
-
由 Santosh Wadghule 提交于
Code like `render(topics) => render("topics/topic")` adds confusion for the readers. On first impression, that code feels like hash kind of data, but it's not. So make it more clear and meaningful.
-
由 Rafael França 提交于
Adds `not_in?` onto Object
-
由 Xavier Noria 提交于
The exclamation mark is not a metacharacter.
-
由 Xavier Noria 提交于
Where appropriate prefer the more concise Regexp#match?, String#include?, String#start_with?, and String#end_with?
-
- 22 7月, 2016 7 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Jon McCartie 提交于
-
由 Xavier Noria 提交于
Some casual benchmarks showed a 2x factor. All credit goes to @nurse.
-
由 Xavier Noria 提交于
See the rationale in the documentation included in this patch. We are going to gradually introduce this predicate in the code base.
-
由 Bart de Water 提交于
AEAD modes like `aes-256-gcm` provide both confidentiality and data authenticity, eliminating the need to use MessageVerifier to check if the encrypted data has been tampered with. Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>
-
- 21 7月, 2016 4 次提交
-
-
由 Xavier Noria 提交于
Fix incorrect indentation in method comment
-
由 Junya Ogura 提交于
-
由 Xavier Noria 提交于
For consistency mainly. Also, some have a name that could make the reader think they enforce the opposite of what they do, because the default is not visible there.
-
由 Yves Senn 提交于
Enforce minimal web-console version for Rails 5
-