- 21 7月, 2016 1 次提交
-
-
由 Genadi Samokovarov 提交于
I dropped the version constraint in web-console with the idea it will be easier to upgrade the console between Rails releases. However, issues like #25899 started popping up. I'm reintroducing the constraint, but this time, I don't set an upper limit to the major version. This will keep the web-console in a version that always works for the current Rails version and can be easily upgraded to the last one with `bundle update`. We may need to backport this for Rails 5.0.1. Fixes #25899.
-
- 17 7月, 2016 5 次提交
-
-
由 Prathamesh Sonpatki 提交于
- By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
-
由 Prathamesh Sonpatki 提交于
Refactor the existing session_store to use keyword args and raise early when set to activerecord session store - Use keyword args as it is possible to use them now. - The error message for activerecord-session_store gem was added in 1807384c. - But it was added for a code path which gets called when we try to **access** the session store, not when we **set** it. - So the test expecting the exception started failing because now the session store is set via railtie again **after** setting it first with :active_record_store in the test. - As the error is not raised while setting the store to :active_record_store, the store gets overwritten by railtie and when we access it via `session_store` while building the default middleware stack, the exception is not raised. - This commit moves the code for raising the exception to the path where we try to set the store.
-
由 Prathamesh Sonpatki 提交于
- We need to ability to check whether the session store it is set or not so that we can set it ourselves in an internal initializer. - We can't rely on return value of `config.session_store` as it can return `nil` when set to `disabled` and we will accidentally override it and set to default cookie store. - So introduced new method which just tells us whether it is set or not.
-
由 Vipul A M 提交于
-
https://github.com/rails/rails/pull/25257由 Prathamesh Sonpatki 提交于
- Also minor weekly CHANGELOG cleanup.
-
- 14 7月, 2016 1 次提交
-
-
由 Gale Shafer 提交于
A mailer preview test description misspelled the word configuration. This commit updates the test description to spell the word correctly.
-
- 13 7月, 2016 1 次提交
-
-
由 Santosh Wadghule 提交于
-
- 12 7月, 2016 1 次提交
-
-
由 Santosh Wadghule 提交于
-
- 11 7月, 2016 1 次提交
-
-
由 Robin Dupret 提交于
Only include files that contain changes since the last generation of the API documentation. Thus, only modified files are re-generated instead of the whole API. The `created.rid` file won't contain the whole list of files anymore if we generate several times the API but we don't really care about it, only the generation date and time is important. It is possible to fall back to the previous behavior by defining the ALL environment variable running the `rake rdoc` task.
-
- 10 7月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
`class_variable_get` is public from Ruby 1.9. Ref: http://ruby-doc.org/core-2.2.0/Module.html#method-i-class_variable_get
-
- 09 7月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Cleanup Active Record CHANGELOG. - Add missing CHANGELOG for https://github.com/rails/rails/pull/25688. - Clarify that assets requests logging is suppressed.
-
- 08 7月, 2016 2 次提交
-
-
由 Abhishek Jain 提交于
-
由 Prathamesh Sonpatki 提交于
-
- 06 7月, 2016 2 次提交
-
-
由 Robin Dupret 提交于
-
由 David Feldman 提交于
-
- 05 7月, 2016 6 次提交
-
-
由 John Meehan 提交于
accidently set it to. Made the change and test still passes.
-
由 Benjamin Quorning 提交于
The options used in this file are *not* directly described in the Rails 5.0 release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but instead in section 2 of the Guide for Upgrading Ruby on Rails document (http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
-
由 John Meehan 提交于
-
由 John Meehan 提交于
Additional directories can be added using SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir") Result: rake notes will now extract notes from these directories.
-
由 Evgeny Vlasenko 提交于
-
由 Sam Sweeney 提交于
-
- 04 7月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd9. - So let's remove it and its usage.
-
- 02 7月, 2016 5 次提交
-
-
由 yuuji.yaginuma 提交于
-
由 yuuji.yaginuma 提交于
Follow up to #25431
-
由 Rafael Mendonça França 提交于
Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
-
由 Vipul A M 提交于
- Cleaned up backtrace cleaner test code and removed instaces variables
-
由 Vipul A M 提交于
Add handling of cleaning up backtrace from IRB console in case of errors
-
- 01 7月, 2016 3 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Sam Stephenson 提交于
-
- 30 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- This will nudge people in the direction of going through upgrade guides.
-
- 23 6月, 2016 4 次提交
-
-
由 Kevin McPhillips 提交于
-
由 Rafael Mendonça França 提交于
This will fix the failures fixed by 41488adb and keep this new option that is semi-private outside of the generated configurations
-
由 eileencodes 提交于
Railties tests didn't know about the new config option added in 80b416f5 so it needed to be added to the railties generators for configs.
-
由 Rafael Mendonça França 提交于
This will make easier to applications that rely on having const_missing hooks in production upgrade to Rails 5. This option is going to be remove in the future and the default behavior will be to disable the dependency loading.
-
- 20 6月, 2016 2 次提交
-
-
由 Nicholas Firth-McCoy 提交于
The /rails/info routes were inaccessible in apps with a catch-all globbing route, as they were being appended after the globbing route and would never be matched. See also ccc3ddb7.
-
由 Prathamesh Sonpatki 提交于
- As assets are removed for API only apps anyways, so we don't need any conditional upfront. - assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
-
- 19 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Railties tests related to fetching asset URL started failing after the release of sprockets 3.6.1 on Travis. - This was due to the change in https://github.com/rails/sprockets/pull/311/files which changed the logic in `concat_javascript_sources` to add `;` at the end of file if the source did not end with semicolon. - Bumped up sprockets minor version and fixed the failing tests.
-
- 17 6月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
This option is used in a initializer hook that runs before the config/initializers files so it will not work if it is set there.
-