1. 01 4月, 2018 1 次提交
  2. 14 3月, 2018 1 次提交
  3. 12 3月, 2018 1 次提交
    • B
      Fix CHANGELOGs [ci skip] · dd075657
      bogdanvlviv 提交于
      - Add missing dots.
      - Remove reference to itself on GitHub.
        Usually, we add references to fixed issues only in a changelog.
      
      Follow up #32223
      dd075657
  4. 28 2月, 2018 2 次提交
  5. 27 2月, 2018 2 次提交
  6. 18 2月, 2018 1 次提交
  7. 31 1月, 2018 1 次提交
  8. 28 12月, 2017 1 次提交
  9. 01 12月, 2017 1 次提交
  10. 29 11月, 2017 2 次提交
  11. 28 11月, 2017 1 次提交
  12. 26 11月, 2017 1 次提交
    • N
      Change `form_with` to generates ids by default · 260d6f11
      npezza93 提交于
      When `form_with` was introduced we disabled the automatic
      generation of ids that was enabled in `form_for`. This usually
      is not an good idea since labels don't work when the input
      doesn't have an id and it made harder to test with Capybara.
      
      You can still disable the automatic generation of ids setting
      `config.action_view.form_with_generates_ids` to `false.`
      260d6f11
  13. 10 11月, 2017 1 次提交
    • N
      Fix field_error_proc wrap form select optgroup and divider option tag · ead4776b
      neumayr 提交于
      ### Summary
      
      The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`.
      
      * Fix for `field_error_proc` wraps form select `optgroup`
      * Fix for `field_error_proc` wraps form select divider `option`
      * Add tests for uncovered elements with errors
      
      [Fixes #31088]
      
      #### Test coverage
      * `test_select_grouped_options_with_errors`
      * `test_time_zone_select_with_priority_zones_and_errors`
      
      #### Extend test coverage
      * `test_collection_select_with_errors`
      * `test_label_with_errors`
      * `test_check_box_with_errors`
      * `test_check_boxes_with_errors`
      * `test_radio_button_with_errors`
      * `test_radio_buttons_with_errors`
      * `test_collection_check_boxes_with_errors`
      * `test_collection_radio_buttons_with_errors`
      ead4776b
  14. 24 10月, 2017 1 次提交
  15. 18 8月, 2017 1 次提交
    • C
      Do not generate default alt text in image tags · 9a74c7b9
      Cameron Cundiff 提交于
      - Auto-generating content from the filename of an image is not suitable
        alternative text; alt text that isn't fully considered can be
        distracting and fatiguing for screen readers users (blind, low vision,
        dyslexic people).
      - Setting a filename fallback short circuits screen reader default
        behavior and configuration for blank descriptions.
      - Setting poor defaults also creates false negatives for accessibility
        linting and testing software, that makes it harder to improve
        application accessibility.
      
      ***
      
      - After this change, if authors leave images without alt text, screen
        readers will fallback to default behavior for missing alt text.
      - Also with this change, Automated linting and testing tools will
        correctly generate warnings.
      
      [Fixes #30096]
      9a74c7b9
  16. 29 6月, 2017 1 次提交
  17. 28 6月, 2017 1 次提交
  18. 20 6月, 2017 1 次提交
  19. 11 6月, 2017 1 次提交
  20. 20 5月, 2017 1 次提交
  21. 30 4月, 2017 1 次提交
  22. 28 4月, 2017 1 次提交
    • J
      Ensure input to distance_of_time_in_words is not nil · 756de667
      Jay Hayes 提交于
      * Internally all input is converted to time so that it can be treated
        uniformly.
      
      Remove now-unneeded condition
      
      * Now that all input is treated is converted to time, we no longer need
        to type check it.
      
      Rename variables to clarify their purpose
      
      Extract private method to normalize distance_of_time args to time
      
      Update actionview changelog
      756de667
  23. 22 3月, 2017 1 次提交
  24. 14 3月, 2017 2 次提交
  25. 28 2月, 2017 1 次提交
  26. 24 2月, 2017 1 次提交
  27. 25 1月, 2017 1 次提交
    • J
      Change ActionView ERB Handler from Erubis to Erubi · 7da8d762
      Jeremy Evans 提交于
      Erubi offers the following advantages for Rails:
      
      * Works with ruby's --enable-frozen-string-literal option
      * Has 88% smaller memory footprint
      * Does no freedom patching (Erubis adds a method to Kernel)
      * Has simpler internals (1 file, <150 lines of code)
      * Has an open development model (Erubis doesn't have a
        public source control repository or bug tracker)
      * Is not dead (Erubis hasn't been updated since 2011)
      
      Erubi is a simplified fork of Erubis that contains just the
      parts that are generally needed (which includes the parts
      that Rails uses).  The only intentional difference in
      behavior is that it does not include support for <%=== tags
      for debug output.  That could be added to the ActionView ERB
      handler if it is desired.
      
      The Erubis template handler remains in a deprecated state
      so that code that accesses it directly does not break.  It
      can be removed after Rails 5.1.
      7da8d762
  28. 15 1月, 2017 1 次提交
    • A
      Allow render locals to be assigned to instance variables · b5edc55d
      Andrew White 提交于
      In #26672 we blocked use of Ruby keywords as identifiers for view
      locals but inadvertently broke the use of instance variable names
      as identifiers. Whilst not explicitly documented this behavior has
      been around for a long time and there's no need to break it now.
      
      Fixes #27480.
      b5edc55d
  29. 04 1月, 2017 1 次提交
  30. 27 12月, 2016 1 次提交
  31. 07 12月, 2016 1 次提交
  32. 22 11月, 2016 1 次提交
  33. 13 11月, 2016 1 次提交
  34. 10 10月, 2016 1 次提交
  35. 02 10月, 2016 1 次提交
    • P
      Change render to support any hash keys in locals · f9960f2d
      Peter Schilling 提交于
      this lets you pass ruby keywords to templates:
      
          <%= render 'example', class: "cool" %>
      
          <%= render 'example', "spaces are" => "a-ok" %>
      
          <%= render 'example', Foo: "bar" %>
      
      Previously you'd see confusing syntax errors like this:
      
          SyntaxError (.../_example.html.erb:1: syntax error, unexpected '='
      
      Now you can reference invalid identifiers through local_assigns.
      
      If you try to use an invalid keyword (e.g. class) in your template, you
      get a syntax error on the line where you use it.
      f9960f2d
  36. 10 8月, 2016 1 次提交