relation_test.rb 11.5 KB
Newer Older
1 2
# frozen_string_literal: true

3
require "cases/helper"
4 5 6 7
require "models/post"
require "models/comment"
require "models/author"
require "models/rating"
8 9 10

module ActiveRecord
  class RelationTest < ActiveRecord::TestCase
11
    fixtures :posts, :comments, :authors, :author_addresses, :ratings
12

13
    def test_construction
14
      relation = Relation.new(FakeKlass, :b, nil)
15
      assert_equal FakeKlass, relation.klass
16
      assert_equal :b, relation.table
17
      assert !relation.loaded, "relation is not loaded"
18 19
    end

20
    def test_responds_to_model_and_returns_klass
21
      relation = Relation.new(FakeKlass, :b, nil)
22
      assert_equal FakeKlass, relation.model
23 24
    end

25
    def test_initialize_single_values
26
      relation = Relation.new(FakeKlass, :b, nil)
27
      (Relation::SINGLE_VALUE_METHODS - [:create_with, :readonly]).each do |method|
28 29
        assert_nil relation.send("#{method}_value"), method.to_s
      end
30
      assert_equal false, relation.readonly_value
31 32 33
      value = relation.create_with_value
      assert_equal({}, value)
      assert_predicate value, :frozen?
34 35 36
    end

    def test_multi_value_initialize
37
      relation = Relation.new(FakeKlass, :b, nil)
38
      Relation::MULTI_VALUE_METHODS.each do |method|
39 40 41
        values = relation.send("#{method}_values")
        assert_equal [], values, method.to_s
        assert_predicate values, :frozen?, method.to_s
42 43 44 45
      end
    end

    def test_extensions
46
      relation = Relation.new(FakeKlass, :b, nil)
47 48
      assert_equal [], relation.extensions
    end
A
Aaron Patterson 已提交
49

50
    def test_empty_where_values_hash
51
      relation = Relation.new(FakeKlass, :b, nil)
A
Aaron Patterson 已提交
52 53 54
      assert_equal({}, relation.where_values_hash)
    end

55
    def test_has_values
56
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
57 58
      relation.where!(id: 10)
      assert_equal({ "id" => 10 }, relation.where_values_hash)
59 60 61
    end

    def test_values_wrong_table
62
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
63
      relation.where! Comment.arel_table[:id].eq(10)
64 65 66
      assert_equal({}, relation.where_values_hash)
    end

67
    def test_tree_is_not_traversed
68
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
69 70
      left     = relation.table[:id].eq(10)
      right    = relation.table[:id].eq(10)
71
      combine  = left.and right
72
      relation.where! combine
73 74 75
      assert_equal({}, relation.where_values_hash)
    end

A
Aaron Patterson 已提交
76
    def test_scope_for_create
77
      relation = Relation.new(FakeKlass, :b, nil)
A
Aaron Patterson 已提交
78 79
      assert_equal({}, relation.scope_for_create)
    end
80 81

    def test_create_with_value
82
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
83 84
      relation.create_with_value = { hello: "world" }
      assert_equal({ "hello" => "world" }, relation.scope_for_create)
85 86 87
    end

    def test_create_with_value_with_wheres
88
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
89 90
      assert_equal({}, relation.scope_for_create)

91
      relation.where!(id: 10)
R
Ryuta Kamizono 已提交
92
      assert_equal({ "id" => 10 }, relation.scope_for_create)
93

94
      relation.create_with_value = { hello: "world" }
R
Ryuta Kamizono 已提交
95
      assert_equal({ "hello" => "world", "id" => 10 }, relation.scope_for_create)
96
    end
A
Aaron Patterson 已提交
97

98 99 100 101 102 103 104 105
    def test_empty_scope
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
      assert relation.empty_scope?

      relation.merge!(relation)
      assert relation.empty_scope?
    end

106 107 108 109 110 111
    def test_bad_constants_raise_errors
      assert_raises(NameError) do
        ActiveRecord::Relation::HelloWorld
      end
    end

A
Aaron Patterson 已提交
112
    def test_empty_eager_loading?
113
      relation = Relation.new(FakeKlass, :b, nil)
A
Aaron Patterson 已提交
114 115 116 117
      assert !relation.eager_loading?
    end

    def test_eager_load_values
118
      relation = Relation.new(FakeKlass, :b, nil)
119
      relation.eager_load! :b
A
Aaron Patterson 已提交
120 121
      assert relation.eager_loading?
    end
122 123

    def test_references_values
124
      relation = Relation.new(FakeKlass, :b, nil)
125 126
      assert_equal [], relation.references_values
      relation = relation.references(:foo).references(:omg, :lol)
127
      assert_equal ["foo", "omg", "lol"], relation.references_values
128 129 130
    end

    def test_references_values_dont_duplicate
131
      relation = Relation.new(FakeKlass, :b, nil)
132
      relation = relation.references(:foo).references(:foo)
133
      assert_equal ["foo"], relation.references_values
134
    end
135

136
    test "merging a hash into a relation" do
137
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder)
138
      relation = relation.merge where: { name: :lol }, readonly: true
139

140
      assert_equal({ "name" => :lol }, relation.where_clause.to_h)
141 142 143
      assert_equal true, relation.readonly_value
    end

144
    test "merging an empty hash into a relation" do
145
      assert_equal Relation::WhereClause.empty, Relation.new(FakeKlass, :b, nil).merge({}).where_clause
146
    end
J
Jon Leighton 已提交
147

148 149
    test "merging a hash with unknown keys raises" do
      assert_raises(ArgumentError) { Relation::HashMerger.new(nil, omg: "lol") }
J
Jon Leighton 已提交
150
    end
151

152
    test "merging nil or false raises" do
153 154 155 156 157 158
      relation = Relation.new(FakeKlass, :b, nil)

      e = assert_raises(ArgumentError) do
        relation = relation.merge nil
      end

159
      assert_equal "invalid argument: nil.", e.message
160 161 162 163 164

      e = assert_raises(ArgumentError) do
        relation = relation.merge false
      end

165
      assert_equal "invalid argument: false.", e.message
166 167
    end

168
    test "#values returns a dup of the values" do
169
      relation = Relation.new(Post, Post.arel_table, Post.predicate_builder).where!(name: :foo)
170 171 172
      values   = relation.values

      values[:where] = nil
173
      assert_not_nil relation.where_clause
174 175
    end

176
    test "relations can be created with a values hash" do
S
Sean Griffin 已提交
177 178
      relation = Relation.new(FakeKlass, :b, nil, select: [:foo])
      assert_equal [:foo], relation.select_values
179
    end
180

181
    test "merging a hash interpolates conditions" do
182 183
      klass = Class.new(FakeKlass) do
        def self.sanitize_sql(args)
184 185
          raise unless args == ["foo = ?", "bar"]
          "foo = bar"
186 187
        end
      end
188

189
      relation = Relation.new(klass, :b, nil)
190
      relation.merge!(where: ["foo = ?", "bar"])
191
      assert_equal Relation::WhereClause.new(["foo = bar"]), relation.where_clause
192
    end
193

194
    def test_merging_readonly_false
195
      relation = Relation.new(FakeKlass, :b, nil)
196 197 198 199 200 201
      readonly_false_relation = relation.readonly(false)
      # test merging in both directions
      assert_equal false, relation.merge(readonly_false_relation).readonly_value
      assert_equal false, readonly_false_relation.merge(relation).readonly_value
    end

202
    def test_relation_merging_with_merged_joins_as_symbols
203 204
      special_comments_with_ratings = SpecialComment.joins(:ratings)
      posts_with_special_comments_with_ratings = Post.group("posts.id").joins(:special_comments).merge(special_comments_with_ratings)
205 206 207 208
      assert_equal({ 4 => 2 }, authors(:david).posts.merge(posts_with_special_comments_with_ratings).count)
    end

    def test_relation_merging_with_merged_symbol_joins_keeps_inner_joins
Y
yuuji.yaginuma 已提交
209
      queries = capture_sql { Author.joins(:posts).merge(Post.joins(:comments)).to_a }
210 211 212 213 214 215 216 217 218 219 220 221 222 223 224

      nb_inner_join = queries.sum { |sql| sql.scan(/INNER\s+JOIN/i).size }
      assert_equal 2, nb_inner_join, "Wrong amount of INNER JOIN in query"
      assert queries.none? { |sql| /LEFT\s+(OUTER)?\s+JOIN/i.match?(sql) }, "Shouldn't have any LEFT JOIN in query"
    end

    def test_relation_merging_with_merged_symbol_joins_has_correct_size_and_count
      # Has one entry per comment
      merged_authors_with_commented_posts_relation = Author.joins(:posts).merge(Post.joins(:comments))

      post_ids_with_author = Post.joins(:author).pluck(:id)
      manual_comments_on_post_that_have_author = Comment.where(post_id: post_ids_with_author).pluck(:id)

      assert_equal manual_comments_on_post_that_have_author.size, merged_authors_with_commented_posts_relation.count
      assert_equal manual_comments_on_post_that_have_author.size, merged_authors_with_commented_posts_relation.to_a.size
225 226
    end

227 228 229 230 231
    def test_relation_merging_with_joins_as_join_dependency_pick_proper_parent
      post = Post.create!(title: "haha", body: "huhu")
      comment = post.comments.create!(body: "hu")
      3.times { comment.ratings.create! }

232
      relation = Post.joins(:comments).merge Comment.joins(:ratings)
233

234
      assert_equal 3, relation.where(id: post.id).pluck(:id).size
235 236
    end

237 238 239 240 241 242 243
    def test_merge_raises_with_invalid_argument
      assert_raises ArgumentError do
        relation = Relation.new(FakeKlass, :b, nil)
        relation.merge(true)
      end
    end

244
    def test_respond_to_for_non_selected_element
245 246 247
      post = Post.select(:title).first
      assert_equal false, post.respond_to?(:body), "post should not respond_to?(:body) since invoking it raises exception"

248
      silence_warnings { post = Post.select("'title' as post_title").first }
249
      assert_equal false, post.respond_to?(:title), "post should not respond_to?(:body) since invoking it raises exception"
250 251
    end

252
    def test_select_quotes_when_using_from_clause
253
      skip_if_sqlite3_version_includes_quoting_bug
254 255 256 257 258
      quoted_join = ActiveRecord::Base.connection.quote_table_name("join")
      selected = Post.select(:join).from(Post.select("id as #{quoted_join}")).map(&:join)
      assert_equal Post.pluck(:id), selected
    end

259 260 261 262 263 264 265 266 267 268 269
    def test_selecting_aliased_attribute_quotes_column_name_when_from_is_used
      skip_if_sqlite3_version_includes_quoting_bug
      klass = Class.new(ActiveRecord::Base) do
        self.table_name = :test_with_keyword_column_name
        alias_attribute :description, :desc
      end
      klass.create!(description: "foo")

      assert_equal ["foo"], klass.select(:description).from(klass.all).map(&:desc)
    end

270 271 272 273
    def test_relation_merging_with_merged_joins_as_strings
      join_string = "LEFT OUTER JOIN #{Rating.quoted_table_name} ON #{SpecialComment.quoted_table_name}.id = #{Rating.quoted_table_name}.comment_id"
      special_comments_with_ratings = SpecialComment.joins join_string
      posts_with_special_comments_with_ratings = Post.group("posts.id").joins(:special_comments).merge(special_comments_with_ratings)
274
      assert_equal({ 2 => 1, 4 => 3, 5 => 1 }, authors(:david).posts.merge(posts_with_special_comments_with_ratings).count)
275
    end
276 277 278 279 280 281

    class EnsureRoundTripTypeCasting < ActiveRecord::Type::Value
      def type
        :string
      end

282
      def deserialize(value)
283 284 285 286
        raise value unless value == "type cast for database"
        "type cast from database"
      end

287
      def serialize(value)
288 289 290 291 292 293
        raise value unless value == "value from user"
        "type cast for database"
      end
    end

    class UpdateAllTestModel < ActiveRecord::Base
294
      self.table_name = "posts"
295 296 297 298 299 300 301 302 303

      attribute :body, EnsureRoundTripTypeCasting.new
    end

    def test_update_all_goes_through_normal_type_casting
      UpdateAllTestModel.update_all(body: "value from user", type: nil) # No STI

      assert_equal "type cast from database", UpdateAllTestModel.first.body
    end
304 305 306

    private

307 308 309
      def skip_if_sqlite3_version_includes_quoting_bug
        if sqlite3_version_includes_quoting_bug?
          skip <<-ERROR.squish
310 311 312 313
            You are using an outdated version of SQLite3 which has a bug in
            quoted column names. Please update SQLite3 and rebuild the sqlite3
            ruby gem
          ERROR
314
        end
315 316
      end

317 318 319 320 321 322 323
      def sqlite3_version_includes_quoting_bug?
        if current_adapter?(:SQLite3Adapter)
          selected_quoted_column_names = ActiveRecord::Base.connection.exec_query(
            'SELECT "join" FROM (SELECT id AS "join" FROM posts) subquery'
          ).columns
          ["join"] != selected_quoted_column_names
        end
324
      end
325 326
  end
end