relation_test.rb 10.5 KB
Newer Older
1
require "cases/helper"
2 3
require 'models/post'
require 'models/comment'
4 5
require 'models/author'
require 'models/rating'
6 7 8

module ActiveRecord
  class RelationTest < ActiveRecord::TestCase
9
    fixtures :posts, :comments, :authors
10

11
    class FakeKlass < Struct.new(:table_name, :name)
12 13 14
      def self.connection
        Post.connection
      end
A
Aaron Patterson 已提交
15 16
    end

17
    def test_construction
18
      relation = Relation.new FakeKlass, :b
19
      assert_equal FakeKlass, relation.klass
20 21 22 23
      assert_equal :b, relation.table
      assert !relation.loaded, 'relation is not loaded'
    end

24
    def test_responds_to_model_and_returns_klass
25 26
      relation = Relation.new FakeKlass, :b
      assert_equal FakeKlass, relation.model
27 28
    end

29
    def test_initialize_single_values
30
      relation = Relation.new FakeKlass, :b
31
      (Relation::SINGLE_VALUE_METHODS - [:create_with]).each do |method|
32 33
        assert_nil relation.send("#{method}_value"), method.to_s
      end
34
      assert_equal({}, relation.create_with_value)
35 36 37
    end

    def test_multi_value_initialize
38
      relation = Relation.new FakeKlass, :b
39 40 41 42 43 44
      Relation::MULTI_VALUE_METHODS.each do |method|
        assert_equal [], relation.send("#{method}_values"), method.to_s
      end
    end

    def test_extensions
45
      relation = Relation.new FakeKlass, :b
46 47
      assert_equal [], relation.extensions
    end
A
Aaron Patterson 已提交
48

49
    def test_empty_where_values_hash
50
      relation = Relation.new FakeKlass, :b
A
Aaron Patterson 已提交
51 52
      assert_equal({}, relation.where_values_hash)

53
      relation.where! :hello
A
Aaron Patterson 已提交
54 55 56
      assert_equal({}, relation.where_values_hash)
    end

57 58
    def test_has_values
      relation = Relation.new Post, Post.arel_table
59
      relation.where! relation.table[:id].eq(10)
60 61 62 63 64
      assert_equal({:id => 10}, relation.where_values_hash)
    end

    def test_values_wrong_table
      relation = Relation.new Post, Post.arel_table
65
      relation.where! Comment.arel_table[:id].eq(10)
66 67 68
      assert_equal({}, relation.where_values_hash)
    end

69 70 71 72 73
    def test_tree_is_not_traversed
      relation = Relation.new Post, Post.arel_table
      left     = relation.table[:id].eq(10)
      right    = relation.table[:id].eq(10)
      combine  = left.and right
74
      relation.where! combine
75 76 77
      assert_equal({}, relation.where_values_hash)
    end

A
Aaron Patterson 已提交
78
    def test_table_name_delegates_to_klass
79
      relation = Relation.new FakeKlass.new('foo'), :b
A
Aaron Patterson 已提交
80 81 82 83
      assert_equal 'foo', relation.table_name
    end

    def test_scope_for_create
84
      relation = Relation.new FakeKlass, :b
A
Aaron Patterson 已提交
85 86
      assert_equal({}, relation.scope_for_create)
    end
87 88 89 90 91 92 93 94 95 96

    def test_create_with_value
      relation = Relation.new Post, Post.arel_table
      hash = { :hello => 'world' }
      relation.create_with_value = hash
      assert_equal hash, relation.scope_for_create
    end

    def test_create_with_value_with_wheres
      relation = Relation.new Post, Post.arel_table
97
      relation.where! relation.table[:id].eq(10)
98 99 100
      relation.create_with_value = {:hello => 'world'}
      assert_equal({:hello => 'world', :id => 10}, relation.scope_for_create)
    end
101 102 103 104 105 106

    # FIXME: is this really wanted or expected behavior?
    def test_scope_for_create_is_cached
      relation = Relation.new Post, Post.arel_table
      assert_equal({}, relation.scope_for_create)

107
      relation.where! relation.table[:id].eq(10)
108 109 110 111 112
      assert_equal({}, relation.scope_for_create)

      relation.create_with_value = {:hello => 'world'}
      assert_equal({}, relation.scope_for_create)
    end
A
Aaron Patterson 已提交
113 114

    def test_empty_eager_loading?
115
      relation = Relation.new FakeKlass, :b
A
Aaron Patterson 已提交
116 117 118 119
      assert !relation.eager_loading?
    end

    def test_eager_load_values
120
      relation = Relation.new FakeKlass, :b
121
      relation.eager_load! :b
A
Aaron Patterson 已提交
122 123
      assert relation.eager_loading?
    end
124 125

    def test_references_values
126
      relation = Relation.new FakeKlass, :b
127 128
      assert_equal [], relation.references_values
      relation = relation.references(:foo).references(:omg, :lol)
J
Jon Leighton 已提交
129
      assert_equal ['foo', 'omg', 'lol'], relation.references_values
130 131 132
    end

    def test_references_values_dont_duplicate
133
      relation = Relation.new FakeKlass, :b
134
      relation = relation.references(:foo).references(:foo)
J
Jon Leighton 已提交
135
      assert_equal ['foo'], relation.references_values
136
    end
137

138
    test 'merging a hash into a relation' do
139
      relation = Relation.new FakeKlass, :b
140
      relation = relation.merge where: :lol, readonly: true
141

142
      assert_equal [:lol], relation.where_values
143 144 145 146
      assert_equal true, relation.readonly_value
    end

    test 'merging an empty hash into a relation' do
147
      assert_equal [], Relation.new(FakeKlass, :b).merge({}).where_values
148
    end
J
Jon Leighton 已提交
149 150 151 152

    test 'merging a hash with unknown keys raises' do
      assert_raises(ArgumentError) { Relation::HashMerger.new(nil, omg: 'lol') }
    end
153 154

    test '#values returns a dup of the values' do
155
      relation = Relation.new(FakeKlass, :b).where! :foo
156 157 158 159 160 161 162
      values   = relation.values

      values[:where] = nil
      assert_not_nil relation.where_values
    end

    test 'relations can be created with a values hash' do
163
      relation = Relation.new(FakeKlass, :b, where: [:foo])
164
      assert_equal [:foo], relation.where_values
165 166 167
    end

    test 'merging a single where value' do
168
      relation = Relation.new(FakeKlass, :b)
169 170
      relation.merge!(where: :foo)
      assert_equal [:foo], relation.where_values
171
    end
172 173

    test 'merging a hash interpolates conditions' do
174
      klass = stub_everything
175 176 177 178 179 180
      klass.stubs(:sanitize_sql).with(['foo = ?', 'bar']).returns('foo = bar')

      relation = Relation.new(klass, :b)
      relation.merge!(where: ['foo = ?', 'bar'])
      assert_equal ['foo = bar'], relation.where_values
    end
181

182
    def test_relation_merging_with_merged_joins_as_symbols
183 184
      special_comments_with_ratings = SpecialComment.joins(:ratings)
      posts_with_special_comments_with_ratings = Post.group("posts.id").joins(:special_comments).merge(special_comments_with_ratings)
185
      assert_equal 3, authors(:david).posts.merge(posts_with_special_comments_with_ratings).count.length
186 187
    end

188
    def test_respond_to_for_non_selected_element
189 190 191
      post = Post.select(:title).first
      assert_equal false, post.respond_to?(:body), "post should not respond_to?(:body) since invoking it raises exception"

192
      silence_warnings { post = Post.select("'title' as post_title").first }
193
      assert_equal false, post.respond_to?(:title), "post should not respond_to?(:body) since invoking it raises exception"
194 195
    end

196 197 198 199 200 201 202
    def test_relation_merging_with_merged_joins_as_strings
      join_string = "LEFT OUTER JOIN #{Rating.quoted_table_name} ON #{SpecialComment.quoted_table_name}.id = #{Rating.quoted_table_name}.comment_id"
      special_comments_with_ratings = SpecialComment.joins join_string
      posts_with_special_comments_with_ratings = Post.group("posts.id").joins(:special_comments).merge(special_comments_with_ratings)
      assert_equal 3, authors(:david).posts.merge(posts_with_special_comments_with_ratings).count.length
    end

203
  end
204 205

  class RelationMutationTest < ActiveSupport::TestCase
206
    class FakeKlass < Struct.new(:table_name, :name)
207 208
      def arel_table
        Post.arel_table
209
      end
210 211 212 213

      def connection
        Post.connection
      end
214 215
    end

216
    def relation
217
      @relation ||= Relation.new FakeKlass.new('posts'), :b
218 219
    end

220
    (Relation::MULTI_VALUE_METHODS - [:references, :extending, :order]).each do |method|
221 222 223 224 225 226
      test "##{method}!" do
        assert relation.public_send("#{method}!", :foo).equal?(relation)
        assert_equal [:foo], relation.public_send("#{method}_values")
      end
    end

227 228 229 230 231 232 233
    test "#order!" do
      assert relation.order!('name ASC').equal?(relation)
      assert_equal ['name ASC'], relation.order_values
    end

    test "#order! with symbol prepends the table name" do
      assert relation.order!(:name).equal?(relation)
234 235 236 237
      node = relation.order_values.first
      assert node.ascending?
      assert_equal :name, node.expr.name
      assert_equal "posts", node.expr.relation.name
238 239
    end

240 241 242 243 244 245 246
    test "#order! on non-string does not attempt regexp match for references" do
      obj = Object.new
      obj.expects(:=~).never
      assert relation.order!(obj)
      assert_equal [obj], relation.order_values
    end

247 248 249 250 251
    test '#references!' do
      assert relation.references!(:foo).equal?(relation)
      assert relation.references_values.include?('foo')
    end

252
    test 'extending!' do
J
Jon Leighton 已提交
253
      mod, mod2 = Module.new, Module.new
254 255

      assert relation.extending!(mod).equal?(relation)
J
Jon Leighton 已提交
256
      assert_equal [mod], relation.extending_values
257
      assert relation.is_a?(mod)
J
Jon Leighton 已提交
258 259 260

      relation.extending!(mod2)
      assert_equal [mod, mod2], relation.extending_values
261 262
    end

263 264 265 266 267
    test 'extending! with empty args' do
      relation.extending!
      assert_equal [], relation.extending_values
    end

268
    (Relation::SINGLE_VALUE_METHODS - [:from, :lock, :reordering, :reverse_order, :create_with]).each do |method|
269 270 271 272 273 274
      test "##{method}!" do
        assert relation.public_send("#{method}!", :foo).equal?(relation)
        assert_equal :foo, relation.public_send("#{method}_value")
      end
    end

275 276 277 278 279
    test '#from!' do
      assert relation.from!('foo').equal?(relation)
      assert_equal ['foo', nil], relation.from_value
    end

280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
    test '#lock!' do
      assert relation.lock!('foo').equal?(relation)
      assert_equal 'foo', relation.lock_value
    end

    test '#reorder!' do
      relation = self.relation.order('foo')

      assert relation.reorder!('bar').equal?(relation)
      assert_equal ['bar'], relation.order_values
      assert relation.reordering_value
    end

    test 'reverse_order!' do
      assert relation.reverse_order!.equal?(relation)
      assert relation.reverse_order_value
      relation.reverse_order!
      assert !relation.reverse_order_value
    end

300 301 302 303
    test 'create_with!' do
      assert relation.create_with!(foo: 'bar').equal?(relation)
      assert_equal({foo: 'bar'}, relation.create_with_value)
    end
J
Jon Leighton 已提交
304

305
    def test_merge!
306 307
      assert relation.merge!(where: :foo).equal?(relation)
      assert_equal [:foo], relation.where_values
J
Jon Leighton 已提交
308
    end
309 310 311 312

    test 'merge with a proc' do
      assert_equal [:foo], relation.merge(-> { where(:foo) }).where_values
    end
313 314 315 316 317 318

    test 'none!' do
      assert relation.none!.equal?(relation)
      assert_equal [NullRelation], relation.extending_values
      assert relation.is_a?(NullRelation)
    end
319 320 321 322 323 324 325 326 327 328 329 330

    test "distinct!" do
      relation.distinct! :foo
      assert_equal :foo, relation.distinct_value
      assert_equal :foo, relation.uniq_value # deprecated access
    end

    test "uniq! was replaced by distinct!" do
      relation.uniq! :foo
      assert_equal :foo, relation.distinct_value
      assert_equal :foo, relation.uniq_value # deprecated access
    end
331
  end
332
end