has_many_associations_test.rb 79.3 KB
Newer Older
1
require "cases/helper"
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
require "models/developer"
require "models/computer"
require "models/project"
require "models/company"
require "models/contract"
require "models/topic"
require "models/reply"
require "models/category"
require "models/image"
require "models/post"
require "models/author"
require "models/essay"
require "models/comment"
require "models/person"
require "models/reader"
require "models/tagging"
require "models/tag"
require "models/invoice"
require "models/line_item"
require "models/car"
require "models/bulb"
require "models/engine"
require "models/categorization"
require "models/minivan"
require "models/speedometer"
require "models/reference"
require "models/job"
require "models/college"
require "models/student"
require "models/pirate"
require "models/ship"
require "models/ship_part"
require "models/treasure"
require "models/parrot"
require "models/tyre"
require "models/subscriber"
require "models/subscription"
require "models/zine"
require "models/interest"
41

42 43 44 45 46 47 48
class HasManyAssociationsTestForReorderWithJoinDependency < ActiveRecord::TestCase
  fixtures :authors, :posts, :comments

  def test_should_generate_valid_sql
    author = authors(:david)
    # this can fail on adapters which require ORDER BY expressions to be included in the SELECT expression
    # if the reorder clauses are not correctly handled
49
    assert author.posts_with_comments_sorted_by_comment_id.where("comments.id > 0").reorder("posts.comments_count DESC", "posts.tags_count DESC").last
50 51
  end
end
52

53 54 55 56
class HasManyAssociationsTestPrimaryKeys < ActiveRecord::TestCase
  fixtures :authors, :essays, :subscribers, :subscriptions, :people

  def test_custom_primary_key_on_new_record_should_fetch_with_query
57
    subscriber = Subscriber.new(nick: "webster132")
58 59 60 61 62 63
    assert !subscriber.subscriptions.loaded?

    assert_queries 1 do
      assert_equal 2, subscriber.subscriptions.size
    end

64
    assert_equal subscriber.subscriptions, Subscription.where(subscriber_id: "webster132")
65 66 67
  end

  def test_association_primary_key_on_new_record_should_fetch_with_query
68
    author = Author.new(name: "David")
69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
    assert !author.essays.loaded?

    assert_queries 1 do
      assert_equal 1, author.essays.size
    end

    assert_equal author.essays, Essay.where(writer_id: "David")
  end

  def test_has_many_custom_primary_key
    david = authors(:david)
    assert_equal david.essays, Essay.where(writer_id: "David")
  end

  def test_has_many_assignment_with_custom_primary_key
    david = people(:david)

    assert_equal ["A Modest Proposal"], david.essays.map(&:name)
    david.essays = [Essay.create!(name: "Remote Work" )]
    assert_equal ["Remote Work"], david.essays.map(&:name)
  end

  def test_blank_custom_primary_key_on_new_record_should_not_run_queries
    author = Author.new
    assert !author.essays.loaded?

    assert_queries 0 do
      assert_equal 0, author.essays.size
    end
  end
end
100 101 102

class HasManyAssociationsTest < ActiveRecord::TestCase
  fixtures :accounts, :categories, :companies, :developers, :projects,
103
           :developers_projects, :topics, :authors, :comments,
104
           :posts, :readers, :taggings, :cars, :jobs, :tags,
105
           :categorizations, :zines, :interests
106 107 108 109 110

  def setup
    Client.destroyed_client_ids.clear
  end

111 112 113 114 115 116
  def test_sti_subselect_count
    tag = Tag.first
    len = Post.tagged_with(tag.id).limit(10).size
    assert_operator len, :>, 0
  end

117 118
  def test_anonymous_has_many
    developer = Class.new(ActiveRecord::Base) {
119
      self.table_name = "developers"
120 121 122
      dev = self

      developer_project = Class.new(ActiveRecord::Base) {
123
        self.table_name = "developers_projects"
124
        belongs_to :developer, anonymous_class: dev
125
      }
126
      has_many :developer_projects, anonymous_class: developer_project, foreign_key: "developer_id"
127 128 129 130 131 132 133 134
    }
    dev = developer.first
    named = Developer.find(dev.id)
    assert_operator dev.developer_projects.count, :>, 0
    assert_equal named.projects.map(&:id).sort,
                 dev.developer_projects.map(&:project_id).sort
  end

135 136 137
  def test_default_scope_on_relations_is_not_cached
    counter = 0
    posts = Class.new(ActiveRecord::Base) {
138 139
      self.table_name = "posts"
      self.inheritance_column = "not_there"
140 141 142
      post = self

      comments = Class.new(ActiveRecord::Base) {
143 144
        self.table_name = "comments"
        self.inheritance_column = "not_there"
145
        belongs_to :post, anonymous_class: post
146 147
        default_scope -> {
          counter += 1
148
          where("id = :inc", inc: counter)
149 150
        }
      }
151
      has_many :comments, anonymous_class: comments, foreign_key: "post_id"
152 153 154 155 156 157 158 159 160
    }
    assert_equal 0, counter
    post = posts.first
    assert_equal 0, counter
    sql = capture_sql { post.comments.to_a }
    post.comments.reset
    assert_not_equal sql, capture_sql { post.comments.to_a }
  end

161
  def test_has_many_build_with_options
162 163
    college = College.create(name: "UFMT")
    Student.create(active: true, college_id: college.id, name: "Sarah")
164 165 166 167

    assert_equal college.students, Student.where(active: true, college_id: college.id)
  end

168
  def test_add_record_to_collection_should_change_its_updated_at
169 170
    ship = Ship.create(name: "dauntless")
    part = ShipPart.create(name: "cockpit")
171 172
    updated_at = part.updated_at

173 174 175
    travel(1.second) do
      ship.parts << part
    end
176 177 178 179 180 181 182 183

    assert_equal part.ship, ship
    assert_not_equal part.updated_at, updated_at
  end

  def test_clear_collection_should_not_change_updated_at
    # GH#17161: .clear calls delete_all (and returns the association),
    # which is intended to not touch associated objects's updated_at field
184 185
    ship = Ship.create(name: "dauntless")
    part = ShipPart.create(name: "cockpit", ship_id: ship.id)
186 187 188 189 190 191 192 193

    ship.parts.clear
    part.reload

    assert_equal nil, part.ship
    assert !part.updated_at_changed?
  end

194
  def test_create_from_association_should_respect_default_scope
195
    car = Car.create(name: "honda")
196
    assert_equal "honda", car.name
197 198

    bulb = Bulb.create
199
    assert_equal "defaulty", bulb.name
200 201

    bulb = car.bulbs.build
202
    assert_equal "defaulty", bulb.name
203 204

    bulb = car.bulbs.create
205
    assert_equal "defaulty", bulb.name
206 207 208
  end

  def test_build_and_create_from_association_should_respect_passed_attributes_over_default_scope
209
    car = Car.create(name: "honda")
210

211 212
    bulb = car.bulbs.build(name: "exotic")
    assert_equal "exotic", bulb.name
213

214 215
    bulb = car.bulbs.create(name: "exotic")
    assert_equal "exotic", bulb.name
216 217 218 219 220 221

    bulb = car.awesome_bulbs.build(frickinawesome: false)
    assert_equal false, bulb.frickinawesome

    bulb = car.awesome_bulbs.create(frickinawesome: false)
    assert_equal false, bulb.frickinawesome
222 223
  end

224 225 226 227
  def test_build_from_association_should_respect_scope
    author = Author.new

    post = author.thinking_posts.build
228
    assert_equal "So I was thinking", post.title
229 230
  end

231
  def test_create_from_association_with_nil_values_should_work
232
    car = Car.create(name: "honda")
233 234

    bulb = car.bulbs.new(nil)
235
    assert_equal "defaulty", bulb.name
236 237

    bulb = car.bulbs.build(nil)
238
    assert_equal "defaulty", bulb.name
239 240

    bulb = car.bulbs.create(nil)
241
    assert_equal "defaulty", bulb.name
242 243
  end

244
  def test_do_not_call_callbacks_for_delete_all
245
    car = Car.create(name: "honda")
246
    car.funky_bulbs.create!
247
    assert_equal 1, car.funky_bulbs.count
248
    assert_nothing_raised { car.reload.funky_bulbs.delete_all }
249
    assert_equal 0, car.funky_bulbs.count, "bulbs should have been deleted using :delete_all strategy"
250 251
  end

252 253
  def test_delete_all_on_association_is_the_same_as_not_loaded
    author = authors :david
254
    author.thinking_posts.create!(body: "test")
255 256 257
    author.reload
    expected_sql = capture_sql { author.thinking_posts.delete_all }

258
    author.thinking_posts.create!(body: "test")
259 260 261 262 263 264
    author.reload
    author.thinking_posts.inspect
    loaded_sql = capture_sql { author.thinking_posts.delete_all }
    assert_equal(expected_sql, loaded_sql)
  end

265 266
  def test_delete_all_on_association_with_nil_dependency_is_the_same_as_not_loaded
    author = authors :david
267
    author.posts.create!(title: "test", body: "body")
268 269 270
    author.reload
    expected_sql = capture_sql { author.posts.delete_all }

271
    author.posts.create!(title: "test", body: "body")
272 273 274 275 276 277
    author.reload
    author.posts.to_a
    loaded_sql = capture_sql { author.posts.delete_all }
    assert_equal(expected_sql, loaded_sql)
  end

278 279 280
  def test_building_the_associated_object_with_implicit_sti_base_class
    firm = DependentFirm.new
    company = firm.companies.build
281
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
282 283 284 285
  end

  def test_building_the_associated_object_with_explicit_sti_base_class
    firm = DependentFirm.new
286
    company = firm.companies.build(type: "Company")
287
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
288 289 290 291
  end

  def test_building_the_associated_object_with_sti_subclass
    firm = DependentFirm.new
292
    company = firm.companies.build(type: "Client")
293
    assert_kind_of Client, company, "Expected #{company.class} to be a Client"
294 295 296 297
  end

  def test_building_the_associated_object_with_an_invalid_type
    firm = DependentFirm.new
298
    assert_raise(ActiveRecord::SubclassNotFound) { firm.companies.build(type: "Invalid") }
299 300 301 302
  end

  def test_building_the_associated_object_with_an_unrelated_type
    firm = DependentFirm.new
303
    assert_raise(ActiveRecord::SubclassNotFound) { firm.companies.build(type: "Account") }
304 305
  end

306 307
  test "building the association with an array" do
    speedometer = Speedometer.new(speedometer_id: "a")
308
    data = [{ name: "first" }, { name: "second" }]
309 310 311 312 313 314 315
    speedometer.minivans.build(data)

    assert_equal 2, speedometer.minivans.size
    assert speedometer.save
    assert_equal ["first", "second"], speedometer.reload.minivans.map(&:name)
  end

316
  def test_association_keys_bypass_attribute_protection
317
    car = Car.create(name: "honda")
318 319 320 321

    bulb = car.bulbs.new
    assert_equal car.id, bulb.car_id

322
    bulb = car.bulbs.new car_id: car.id + 1
323 324
    assert_equal car.id, bulb.car_id

325 326 327
    bulb = car.bulbs.build
    assert_equal car.id, bulb.car_id

328
    bulb = car.bulbs.build car_id: car.id + 1
329 330
    assert_equal car.id, bulb.car_id

331 332
    bulb = car.bulbs.create
    assert_equal car.id, bulb.car_id
333

334
    bulb = car.bulbs.create car_id: car.id + 1
335
    assert_equal car.id, bulb.car_id
336 337
  end

338 339 340 341 342 343
  def test_association_protect_foreign_key
    invoice = Invoice.create

    line_item = invoice.line_items.new
    assert_equal invoice.id, line_item.invoice_id

344
    line_item = invoice.line_items.new invoice_id: invoice.id + 1
345 346 347 348 349
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.build
    assert_equal invoice.id, line_item.invoice_id

350
    line_item = invoice.line_items.build invoice_id: invoice.id + 1
351 352 353 354 355
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.create
    assert_equal invoice.id, line_item.invoice_id

356
    line_item = invoice.line_items.create invoice_id: invoice.id + 1
357 358 359
    assert_equal invoice.id, line_item.invoice_id
  end

360 361 362 363
  # When creating objects on the association, we must not do it within a scope (even though it
  # would be convenient), because this would cause that scope to be applied to any callbacks etc.
  def test_build_and_create_should_not_happen_within_scope
    car = cars(:honda)
364
    scope = car.foo_bulbs.where_values_hash
365

366
    bulb = car.foo_bulbs.build
367
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
368

369
    bulb = car.foo_bulbs.create
370
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
371

372
    bulb = car.foo_bulbs.create!
373
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
374 375
  end

376
  def test_no_sql_should_be_fired_if_association_already_loaded
377
    Car.create(name: "honda")
378
    bulbs = Car.first.bulbs
B
Brian Cardarella 已提交
379
    bulbs.to_a # to load all instances of bulbs
380

381 382 383 384
    assert_no_queries do
      bulbs.first()
      bulbs.first({})
    end
385

386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410
    assert_no_queries do
      bulbs.second()
      bulbs.second({})
    end

    assert_no_queries do
      bulbs.third()
      bulbs.third({})
    end

    assert_no_queries do
      bulbs.fourth()
      bulbs.fourth({})
    end

    assert_no_queries do
      bulbs.fifth()
      bulbs.fifth({})
    end

    assert_no_queries do
      bulbs.forty_two()
      bulbs.forty_two({})
    end

411
    assert_no_queries do
412 413
      bulbs.third_to_last()
      bulbs.third_to_last({})
414 415 416
    end

    assert_no_queries do
417 418
      bulbs.second_to_last()
      bulbs.second_to_last({})
419 420
    end

421 422 423 424
    assert_no_queries do
      bulbs.last()
      bulbs.last({})
    end
425 426
  end

427
  def test_create_resets_cached_counters
428
    person = Person.create!(first_name: "tenderlove")
429
    post   = Post.first
430 431

    assert_equal [], person.readers
432
    assert_nil person.readers.find_by_post_id(post.id)
433

434
    person.readers.create(post_id: post.id)
435 436 437 438 439 440 441

    assert_equal 1, person.readers.count
    assert_equal 1, person.readers.length
    assert_equal post, person.readers.first.post
    assert_equal person, person.readers.first.person
  end

442 443
  def test_update_all_respects_association_scope
    person = Person.new
444
    person.first_name = "Naruto"
445 446 447 448 449 450 451 452 453
    person.references << Reference.new
    person.id = 10
    person.references
    person.save!
    assert_equal 1, person.references.update_all(favourite: true)
  end

  def test_exists_respects_association_scope
    person = Person.new
454
    person.first_name = "Sasuke"
455 456 457 458 459 460 461
    person.references << Reference.new
    person.id = 10
    person.references
    person.save!
    assert_predicate person.references, :exists?
  end

462
  # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
463
  def test_counting_with_counter_sql
464
    assert_equal 3, Firm.all.merge!(order: "id").first.clients.count
465 466 467
  end

  def test_counting
468
    assert_equal 3, Firm.all.merge!(order: "id").first.plain_clients.count
469 470 471
  end

  def test_counting_with_single_hash
472
    assert_equal 1, Firm.all.merge!(order: "id").first.plain_clients.where(name: "Microsoft").count
473 474 475
  end

  def test_counting_with_column_name_and_hash
476
    assert_equal 3, Firm.all.merge!(order: "id").first.plain_clients.count(:name)
477 478
  end

479 480 481 482 483 484
  def test_counting_with_association_limit
    firm = companies(:first_firm)
    assert_equal firm.limited_clients.length, firm.limited_clients.size
    assert_equal firm.limited_clients.length, firm.limited_clients.count
  end

485
  def test_finding
486
    assert_equal 3, Firm.all.merge!(order: "id").first.clients.length
487 488
  end

489
  def test_finding_array_compatibility
490
    assert_equal 3, Firm.order(:id).find { |f| f.id > 0 }.clients.length
491 492
  end

493 494
  def test_find_many_with_merged_options
    assert_equal 1, companies(:first_firm).limited_clients.size
495
    assert_equal 1, companies(:first_firm).limited_clients.to_a.size
496
    assert_equal 3, companies(:first_firm).limited_clients.limit(nil).to_a.size
497 498
  end

499
  def test_find_should_append_to_association_order
500 501
    ordered_clients =  companies(:first_firm).clients_sorted_desc.order("companies.id")
    assert_equal ["id DESC", "companies.id"], ordered_clients.order_values
502 503
  end

504
  def test_dynamic_find_should_respect_association_order
505
    assert_equal companies(:another_first_firm_client), companies(:first_firm).clients_sorted_desc.where("type = 'Client'").first
506
    assert_equal companies(:another_first_firm_client), companies(:first_firm).clients_sorted_desc.find_by_type("Client")
507 508
  end

509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
  def test_taking
    posts(:other_by_bob).destroy
    assert_equal posts(:misc_by_bob), authors(:bob).posts.take
    assert_equal posts(:misc_by_bob), authors(:bob).posts.take!
    authors(:bob).posts.to_a
    assert_equal posts(:misc_by_bob), authors(:bob).posts.take
    assert_equal posts(:misc_by_bob), authors(:bob).posts.take!
  end

  def test_taking_not_found
    authors(:bob).posts.delete_all
    assert_raise(ActiveRecord::RecordNotFound) { authors(:bob).posts.take! }
    authors(:bob).posts.to_a
    assert_raise(ActiveRecord::RecordNotFound) { authors(:bob).posts.take! }
  end

525 526 527 528 529 530 531 532 533 534 535 536 537
  def test_taking_with_a_number
    # taking from unloaded Relation
    bob = Author.find(authors(:bob).id)
    assert_equal [posts(:misc_by_bob)], bob.posts.take(1)
    bob = Author.find(authors(:bob).id)
    assert_equal [posts(:misc_by_bob), posts(:other_by_bob)], bob.posts.take(2)

    # taking from loaded Relation
    bob.posts.to_a
    assert_equal [posts(:misc_by_bob)], authors(:bob).posts.take(1)
    assert_equal [posts(:misc_by_bob), posts(:other_by_bob)], authors(:bob).posts.take(2)
  end

538 539 540 541 542 543 544 545 546 547
  def test_taking_with_inverse_of
    interests(:woodsmanship).destroy
    interests(:survival).destroy

    zine = zines(:going_out)
    interest = zine.interests.take
    assert_equal interests(:hunting), interest
    assert_same zine, interest.zine
  end

548 549 550 551 552 553
  def test_cant_save_has_many_readonly_association
    authors(:david).readonly_comments.each { |c| assert_raise(ActiveRecord::ReadOnlyRecord) { c.save! } }
    authors(:david).readonly_comments.each { |c| assert c.readonly? }
  end

  def test_finding_default_orders
554
    assert_equal "Summit", Firm.all.merge!(order: "id").first.clients.first.name
555 556 557
  end

  def test_finding_with_different_class_name_and_order
558
    assert_equal "Apex", Firm.all.merge!(order: "id").first.clients_sorted_desc.first.name
559 560 561
  end

  def test_finding_with_foreign_key
562
    assert_equal "Microsoft", Firm.all.merge!(order: "id").first.clients_of_firm.first.name
563 564 565
  end

  def test_finding_with_condition
566
    assert_equal "Microsoft", Firm.all.merge!(order: "id").first.clients_like_ms.first.name
567 568 569
  end

  def test_finding_with_condition_hash
570
    assert_equal "Microsoft", Firm.all.merge!(order: "id").first.clients_like_ms_with_hash_conditions.first.name
571 572
  end

573
  def test_finding_using_primary_key
574
    assert_equal "Summit", Firm.all.merge!(order: "id").first.clients_using_primary_key.first.name
575 576
  end

577
  def test_update_all_on_association_accessed_before_save
578
    firm = Firm.new(name: "Firm")
579
    clients_proxy_id = firm.clients.object_id
580 581
    firm.clients << Client.first
    firm.save!
582
    assert_equal firm.clients.count, firm.clients.update_all(description: "Great!")
583 584 585 586 587
    assert_not_equal clients_proxy_id, firm.clients.object_id
  end

  def test_update_all_on_association_accessed_before_save_with_explicit_foreign_key
    # We can use the same cached proxy object because the id is available for the scope
588
    firm = Firm.new(name: "Firm", id: 100)
589 590 591
    clients_proxy_id = firm.clients.object_id
    firm.clients << Client.first
    firm.save!
592
    assert_equal firm.clients.count, firm.clients.update_all(description: "Great!")
593
    assert_equal clients_proxy_id, firm.clients.object_id
594 595
  end

596 597
  def test_belongs_to_sanity
    c = Client.new
598
    assert_nil c.firm, "belongs_to failed sanity check on new object"
599 600 601
  end

  def test_find_ids
602
    firm = Firm.all.merge!(order: "id").first
603

604
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find }
605 606 607 608 609 610 611 612 613 614 615 616 617

    client = firm.clients.find(2)
    assert_kind_of Client, client

    client_ary = firm.clients.find([2])
    assert_kind_of Array, client_ary
    assert_equal client, client_ary.first

    client_ary = firm.clients.find(2, 3)
    assert_kind_of Array, client_ary
    assert_equal 2, client_ary.size
    assert_equal client, client_ary.first

618
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find(2, 99) }
619 620
  end

A
Arthur Neves 已提交
621 622 623
  def test_find_ids_and_inverse_of
    force_signal37_to_load_all_clients_of_firm

624 625
    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

A
Arthur Neves 已提交
626 627 628 629 630 631 632 633 634
    firm = companies(:first_firm)
    client = firm.clients_of_firm.find(3)
    assert_kind_of Client, client

    client_ary = firm.clients_of_firm.find([3])
    assert_kind_of Array, client_ary
    assert_equal client, client_ary.first
  end

635
  def test_find_all
636
    firm = Firm.all.merge!(order: "id").first
637
    assert_equal 3, firm.clients.where("#{QUOTED_TYPE} = 'Client'").to_a.length
638
    assert_equal 1, firm.clients.where("name = 'Summit'").to_a.length
639 640
  end

641 642 643 644 645
  def test_find_each
    firm = companies(:first_firm)

    assert ! firm.clients.loaded?

646
    assert_queries(4) do
647
      firm.clients.find_each(batch_size: 1) { |c| assert_equal firm.id, c.firm_id }
648 649 650 651 652 653 654 655 656
    end

    assert ! firm.clients.loaded?
  end

  def test_find_each_with_conditions
    firm = companies(:first_firm)

    assert_queries(2) do
657
      firm.clients.where(name: "Microsoft").find_each(batch_size: 1) do |c|
658 659 660 661 662 663 664 665 666 667 668 669 670 671
        assert_equal firm.id, c.firm_id
        assert_equal "Microsoft", c.name
      end
    end

    assert ! firm.clients.loaded?
  end

  def test_find_in_batches
    firm = companies(:first_firm)

    assert ! firm.clients.loaded?

    assert_queries(2) do
672
      firm.clients.find_in_batches(batch_size: 2) do |clients|
673
        clients.each { |c| assert_equal firm.id, c.firm_id }
674 675 676 677 678 679
      end
    end

    assert ! firm.clients.loaded?
  end

680
  def test_find_all_sanitized
681
    # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
682
    firm = Firm.all.merge!(order: "id").first
683 684
    summit = firm.clients.where("name = 'Summit'").to_a
    assert_equal summit, firm.clients.where("name = ?", "Summit").to_a
685
    assert_equal summit, firm.clients.where("name = :name", name: "Summit").to_a
686 687 688
  end

  def test_find_first
689
    firm = Firm.all.merge!(order: "id").first
690
    client2 = Client.find(2)
691 692
    assert_equal firm.clients.first, firm.clients.order("id").first
    assert_equal client2, firm.clients.where("#{QUOTED_TYPE} = 'Client'").order("id").first
693 694 695
  end

  def test_find_first_sanitized
696
    firm = Firm.all.merge!(order: "id").first
697
    client2 = Client.find(2)
698 699
    assert_equal client2, firm.clients.merge!(where: ["#{QUOTED_TYPE} = ?", "Client"], order: "id").first
    assert_equal client2, firm.clients.merge!(where: ["#{QUOTED_TYPE} = :type", { type: "Client" }], order: "id").first
700 701
  end

702 703
  def test_find_all_with_include_and_conditions
    assert_nothing_raised do
704
      Developer.all.merge!(joins: :audit_logs, where: { "audit_logs.message" => nil, :name => "Smith" }).to_a
705 706 707
    end
  end

708 709
  def test_find_in_collection
    assert_equal Client.find(2).name, companies(:first_firm).clients.find(2).name
710
    assert_raise(ActiveRecord::RecordNotFound) { companies(:first_firm).clients.find(6) }
711 712 713
  end

  def test_find_grouped
714 715
    all_clients_of_firm1 = Client.all.merge!(where: "firm_id = 1").to_a
    grouped_clients_of_firm1 = Client.all.merge!(where: "firm_id = 1", group: "firm_id", select: "firm_id, count(id) as clients_count").to_a
716
    assert_equal 3, all_clients_of_firm1.size
717 718 719
    assert_equal 1, grouped_clients_of_firm1.size
  end

720
  def test_find_scoped_grouped
721
    assert_equal 1, companies(:first_firm).clients_grouped_by_firm_id.size
722
    assert_equal 1, companies(:first_firm).clients_grouped_by_firm_id.length
723 724
    assert_equal 3, companies(:first_firm).clients_grouped_by_name.size
    assert_equal 3, companies(:first_firm).clients_grouped_by_name.length
725 726
  end

727 728 729 730 731
  def test_find_scoped_grouped_having
    assert_equal 1, authors(:david).popular_grouped_posts.length
    assert_equal 0, authors(:mary).popular_grouped_posts.length
  end

732
  def test_default_select
733
    assert_equal Comment.column_names.sort, posts(:welcome).comments.first.attributes.keys.sort
734 735 736
  end

  def test_select_query_method
737
    assert_equal ["id", "body"], posts(:welcome).comments.select(:id, :body).first.attributes.keys
738 739 740 741
  end

  def test_select_with_block
    assert_equal [1], posts(:welcome).comments.select { |c| c.id == 1 }.map(&:id)
742 743
  end

744
  def test_select_without_foreign_key
745
    assert_equal companies(:first_firm).accounts.first.credit_limit, companies(:first_firm).accounts.select(:credit_limit).first.credit_limit
746
  end
747

748 749
  def test_adding
    force_signal37_to_load_all_clients_of_firm
750 751 752

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

753 754
    natural = Client.new("name" => "Natural Company")
    companies(:first_firm).clients_of_firm << natural
755
    assert_equal 3, companies(:first_firm).clients_of_firm.size # checking via the collection
756
    assert_equal 3, companies(:first_firm).clients_of_firm.reload.size # checking using the db
757 758 759 760 761 762
    assert_equal natural, companies(:first_firm).clients_of_firm.last
  end

  def test_adding_using_create
    first_firm = companies(:first_firm)
    assert_equal 3, first_firm.plain_clients.size
763
    first_firm.plain_clients.create(name: "Natural Company")
764 765
    assert_equal 4, first_firm.plain_clients.length
    assert_equal 4, first_firm.plain_clients.size
766 767 768
  end

  def test_create_with_bang_on_has_many_when_parent_is_new_raises
769
    error = assert_raise(ActiveRecord::RecordNotSaved) do
770
      firm = Firm.new
771
      firm.plain_clients.create! name: "Whoever"
772
    end
773 774

    assert_equal "You cannot call create unless the parent is saved", error.message
775 776 777
  end

  def test_regular_create_on_has_many_when_parent_is_new_raises
778
    error = assert_raise(ActiveRecord::RecordNotSaved) do
779
      firm = Firm.new
780
      firm.plain_clients.create name: "Whoever"
781
    end
782 783

    assert_equal "You cannot call create unless the parent is saved", error.message
784 785 786
  end

  def test_create_with_bang_on_has_many_raises_when_record_not_saved
787
    assert_raise(ActiveRecord::RecordInvalid) do
788
      firm = Firm.all.merge!(order: "id").first
789 790 791 792 793
      firm.plain_clients.create!
    end
  end

  def test_create_with_bang_on_habtm_when_parent_is_new_raises
794
    error = assert_raise(ActiveRecord::RecordNotSaved) do
795 796
      Developer.new("name" => "Aredridel").projects.create!
    end
797 798

    assert_equal "You cannot call create unless the parent is saved", error.message
799 800 801
  end

  def test_adding_a_mismatch_class
802 803 804
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << nil }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << 1 }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << Topic.find(1) }
805 806 807 808
  end

  def test_adding_a_collection
    force_signal37_to_load_all_clients_of_firm
809 810 811

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

812
    companies(:first_firm).clients_of_firm.concat([Client.new("name" => "Natural Company"), Client.new("name" => "Apple")])
813
    assert_equal 4, companies(:first_firm).clients_of_firm.size
814
    assert_equal 4, companies(:first_firm).clients_of_firm.reload.size
815 816
  end

817
  def test_transactions_when_adding_to_persisted
818 819
    good = Client.new(name: "Good")
    bad  = Client.new(name: "Bad", raise_on_save: true)
J
Jon Leighton 已提交
820 821 822 823 824 825

    begin
      companies(:first_firm).clients_of_firm.concat(good, bad)
    rescue Client::RaisedOnSave
    end

826
    assert !companies(:first_firm).clients_of_firm.reload.include?(good)
827 828 829
  end

  def test_transactions_when_adding_to_new_record
830
    assert_no_queries(ignore_none: false) do
J
Jon Leighton 已提交
831 832 833
      firm = Firm.new
      firm.clients_of_firm.concat(Client.new("name" => "Natural Company"))
    end
834 835
  end

836 837 838 839 840 841 842
  def test_inverse_on_before_validate
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients_of_firm << Client.new("name" => "Natural Company")
    end
  end

843 844
  def test_new_aliased_to_build
    company = companies(:first_firm)
845
    new_client = assert_no_queries(ignore_none: false) { company.clients_of_firm.new("name" => "Another Client") }
846 847 848 849 850 851 852
    assert !company.clients_of_firm.loaded?

    assert_equal "Another Client", new_client.name
    assert !new_client.persisted?
    assert_equal new_client, company.clients_of_firm.last
  end

853 854
  def test_build
    company = companies(:first_firm)
855
    new_client = assert_no_queries(ignore_none: false) { company.clients_of_firm.build("name" => "Another Client") }
856
    assert !company.clients_of_firm.loaded?
857

858
    assert_equal "Another Client", new_client.name
859
    assert !new_client.persisted?
860 861 862
    assert_equal new_client, company.clients_of_firm.last
  end

863 864 865 866
  def test_collection_size_after_building
    company = companies(:first_firm)  # company already has one client
    company.clients_of_firm.build("name" => "Another Client")
    company.clients_of_firm.build("name" => "Yet Another Client")
867
    assert_equal 4, company.clients_of_firm.size
868 869
  end

870 871 872 873 874 875 876
  def test_collection_not_empty_after_building
    company = companies(:first_firm)
    assert_predicate company.contracts, :empty?
    company.contracts.build
    assert_not_predicate company.contracts, :empty?
  end

877 878 879 880 881 882 883 884 885 886 887 888
  def test_collection_size_twice_for_regressions
    post = posts(:thinking)
    assert_equal 0, post.readers.size
    # This test needs a post that has no readers, we assert it to ensure it holds,
    # but need to reload the post because the very call to #size hides the bug.
    post.reload
    post.readers.build
    size1 = post.readers.size
    size2 = post.readers.size
    assert_equal size1, size2
  end

889 890
  def test_build_many
    company = companies(:first_firm)
891
    new_clients = assert_no_queries(ignore_none: false) { company.clients_of_firm.build([{ "name" => "Another Client" }, { "name" => "Another Client II" }]) }
892 893 894 895
    assert_equal 2, new_clients.size
  end

  def test_build_followed_by_save_does_not_load_target
896
    companies(:first_firm).clients_of_firm.build("name" => "Another Client")
897 898 899 900 901 902 903 904 905 906 907
    assert companies(:first_firm).save
    assert !companies(:first_firm).clients_of_firm.loaded?
  end

  def test_build_without_loading_association
    first_topic = topics(:first)
    Reply.column_names

    assert_equal 1, first_topic.replies.length

    assert_no_queries do
908
      first_topic.replies.build(title: "Not saved", content: "Superstars")
909 910 911 912 913 914
      assert_equal 2, first_topic.replies.size
    end

    assert_equal 2, first_topic.replies.to_ary.size
  end

915 916
  def test_build_via_block
    company = companies(:first_firm)
917
    new_client = assert_no_queries(ignore_none: false) { company.clients_of_firm.build { |client| client.name = "Another Client" } }
918 919 920
    assert !company.clients_of_firm.loaded?

    assert_equal "Another Client", new_client.name
921
    assert !new_client.persisted?
922 923 924 925 926
    assert_equal new_client, company.clients_of_firm.last
  end

  def test_build_many_via_block
    company = companies(:first_firm)
927
    new_clients = assert_no_queries(ignore_none: false) do
928
      company.clients_of_firm.build([{ "name" => "Another Client" }, { "name" => "Another Client II" }]) do |client|
929 930 931 932 933 934 935 936 937
        client.name = "changed"
      end
    end

    assert_equal 2, new_clients.size
    assert_equal "changed", new_clients.first.name
    assert_equal "changed", new_clients.last.name
  end

938 939 940 941 942
  def test_create_without_loading_association
    first_firm  = companies(:first_firm)
    Firm.column_names
    Client.column_names

943
    assert_equal 2, first_firm.clients_of_firm.size
944 945 946
    first_firm.clients_of_firm.reset

    assert_queries(1) do
947
      first_firm.clients_of_firm.create(name: "Superstars")
948 949
    end

950
    assert_equal 3, first_firm.clients_of_firm.size
951 952 953 954
  end

  def test_create
    force_signal37_to_load_all_clients_of_firm
955 956 957

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

958
    new_client = companies(:first_firm).clients_of_firm.create("name" => "Another Client")
959
    assert new_client.persisted?
960
    assert_equal new_client, companies(:first_firm).clients_of_firm.last
961
    assert_equal new_client, companies(:first_firm).clients_of_firm.reload.last
962 963 964
  end

  def test_create_many
965
    companies(:first_firm).clients_of_firm.create([{ "name" => "Another Client" }, { "name" => "Another Client II" }])
966
    assert_equal 4, companies(:first_firm).clients_of_firm.reload.size
967 968 969
  end

  def test_create_followed_by_save_does_not_load_target
970
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
971 972 973 974 975 976
    assert companies(:first_firm).save
    assert !companies(:first_firm).clients_of_firm.loaded?
  end

  def test_deleting
    force_signal37_to_load_all_clients_of_firm
977 978 979

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

980
    companies(:first_firm).clients_of_firm.delete(companies(:first_firm).clients_of_firm.first)
981
    assert_equal 1, companies(:first_firm).clients_of_firm.size
982
    assert_equal 1, companies(:first_firm).clients_of_firm.reload.size
983 984 985 986 987 988 989 990 991 992
  end

  def test_deleting_before_save
    new_firm = Firm.new("name" => "A New Firm, Inc.")
    new_client = new_firm.clients_of_firm.build("name" => "Another Client")
    assert_equal 1, new_firm.clients_of_firm.size
    new_firm.clients_of_firm.delete(new_client)
    assert_equal 0, new_firm.clients_of_firm.size
  end

993 994 995
  def test_has_many_without_counter_cache_option
    # Ship has a conventionally named `treasures_count` column, but the counter_cache
    # option is not given on the association.
996
    ship = Ship.create(name: "Countless", treasures_count: 10)
997

998
    assert_not Ship.reflect_on_association(:treasures).has_cached_counter?
999 1000 1001 1002 1003

    # Count should come from sql count() of treasures rather than treasures_count attribute
    assert_equal ship.treasures.size, 0

    assert_no_difference lambda { ship.reload.treasures_count }, "treasures_count should not be changed" do
1004
      ship.treasures.create(name: "Gold")
1005 1006 1007 1008 1009 1010 1011
    end

    assert_no_difference lambda { ship.reload.treasures_count }, "treasures_count should not be changed" do
      ship.treasures.destroy_all
    end
  end

1012
  def test_deleting_updates_counter_cache
J
Jon Leighton 已提交
1013
    topic = Topic.order("id ASC").first
1014 1015 1016 1017 1018 1019 1020
    assert_equal topic.replies.to_a.size, topic.replies_count

    topic.replies.delete(topic.replies.first)
    topic.reload
    assert_equal topic.replies.to_a.size, topic.replies_count
  end

1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050
  def test_counter_cache_updates_in_memory_after_concat
    topic = Topic.create title: "Zoom-zoom-zoom"

    topic.replies << Reply.create(title: "re: zoom", content: "speedy quick!")
    assert_equal 1, topic.replies_count
    assert_equal 1, topic.replies.size
    assert_equal 1, topic.reload.replies.size
  end

  def test_counter_cache_updates_in_memory_after_create
    topic = Topic.create title: "Zoom-zoom-zoom"

    topic.replies.create!(title: "re: zoom", content: "speedy quick!")
    assert_equal 1, topic.replies_count
    assert_equal 1, topic.replies.size
    assert_equal 1, topic.reload.replies.size
  end

  def test_counter_cache_updates_in_memory_after_create_with_array
    topic = Topic.create title: "Zoom-zoom-zoom"

    topic.replies.create!([
      { title: "re: zoom", content: "speedy quick!" },
      { title: "re: zoom 2", content: "OMG lol!" },
    ])
    assert_equal 2, topic.replies_count
    assert_equal 2, topic.replies.size
    assert_equal 2, topic.reload.replies.size
  end

1051 1052 1053 1054 1055 1056 1057 1058 1059
  def test_pushing_association_updates_counter_cache
    topic = Topic.order("id ASC").first
    reply = Reply.create!

    assert_difference "topic.reload.replies_count", 1 do
      topic.replies << reply
    end
  end

1060
  def test_deleting_updates_counter_cache_without_dependent_option
1061 1062
    post = posts(:welcome)

1063
    assert_difference "post.reload.tags_count", -1 do
1064 1065 1066 1067
      post.taggings.delete(post.taggings.first)
    end
  end

1068 1069
  def test_deleting_updates_counter_cache_with_dependent_delete_all
    post = posts(:welcome)
1070
    post.update_columns(taggings_with_delete_all_count: post.tags_count)
1071 1072 1073 1074 1075 1076

    assert_difference "post.reload.taggings_with_delete_all_count", -1 do
      post.taggings_with_delete_all.delete(post.taggings_with_delete_all.first)
    end
  end

1077 1078
  def test_deleting_updates_counter_cache_with_dependent_destroy
    post = posts(:welcome)
1079
    post.update_columns(taggings_with_destroy_count: post.tags_count)
1080 1081 1082 1083 1084 1085

    assert_difference "post.reload.taggings_with_destroy_count", -1 do
      post.taggings_with_destroy.delete(post.taggings_with_destroy.first)
    end
  end

1086 1087 1088 1089 1090 1091 1092
  def test_calling_empty_with_counter_cache
    post = posts(:welcome)
    assert_queries(0) do
      assert_not post.comments.empty?
    end
  end

1093 1094 1095 1096 1097 1098 1099 1100
  def test_custom_named_counter_cache
    topic = topics(:first)

    assert_difference "topic.reload.replies_count", -1 do
      topic.approved_replies.clear
    end
  end

1101 1102 1103 1104 1105 1106
  def test_calling_update_attributes_on_id_changes_the_counter_cache
    topic = Topic.order("id ASC").first
    original_count = topic.replies.to_a.size
    assert_equal original_count, topic.replies_count

    first_reply = topic.replies.first
1107
    first_reply.update_attributes(parent_id: nil)
1108 1109
    assert_equal original_count - 1, topic.reload.replies_count

1110
    first_reply.update_attributes(parent_id: topic.id)
1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
    assert_equal original_count, topic.reload.replies_count
  end

  def test_calling_update_attributes_changing_ids_doesnt_change_counter_cache
    topic1 = Topic.find(1)
    topic2 = Topic.find(3)
    original_count1 = topic1.replies.to_a.size
    original_count2 = topic2.replies.to_a.size

    reply1 = topic1.replies.first
    reply2 = topic2.replies.first

1123
    reply1.update_attributes(parent_id: topic2.id)
1124 1125 1126
    assert_equal original_count1 - 1, topic1.reload.replies_count
    assert_equal original_count2 + 1, topic2.reload.replies_count

1127
    reply2.update_attributes(parent_id: topic1.id)
1128 1129 1130 1131
    assert_equal original_count1, topic1.reload.replies_count
    assert_equal original_count2, topic2.reload.replies_count
  end

1132 1133
  def test_deleting_a_collection
    force_signal37_to_load_all_clients_of_firm
1134 1135 1136

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1137
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
1138 1139
    assert_equal 3, companies(:first_firm).clients_of_firm.size
    companies(:first_firm).clients_of_firm.delete([companies(:first_firm).clients_of_firm[0], companies(:first_firm).clients_of_firm[1], companies(:first_firm).clients_of_firm[2]])
1140
    assert_equal 0, companies(:first_firm).clients_of_firm.size
1141
    assert_equal 0, companies(:first_firm).clients_of_firm.reload.size
1142 1143 1144 1145
  end

  def test_delete_all
    force_signal37_to_load_all_clients_of_firm
1146 1147 1148

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1149 1150
    companies(:first_firm).dependent_clients_of_firm.create("name" => "Another Client")
    clients = companies(:first_firm).dependent_clients_of_firm.to_a
1151
    assert_equal 3, clients.count
1152 1153

    assert_difference "Client.count", -(clients.count) do
1154
      companies(:first_firm).dependent_clients_of_firm.delete_all
1155
    end
1156 1157 1158 1159
  end

  def test_delete_all_with_not_yet_loaded_association_collection
    force_signal37_to_load_all_clients_of_firm
1160 1161 1162

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1163
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
1164
    assert_equal 3, companies(:first_firm).clients_of_firm.size
1165 1166 1167
    companies(:first_firm).clients_of_firm.reset
    companies(:first_firm).clients_of_firm.delete_all
    assert_equal 0, companies(:first_firm).clients_of_firm.size
1168
    assert_equal 0, companies(:first_firm).clients_of_firm.reload.size
1169 1170
  end

1171
  def test_transaction_when_deleting_persisted
1172 1173
    good = Client.new(name: "Good")
    bad  = Client.new(name: "Bad", raise_on_destroy: true)
J
Jon Leighton 已提交
1174 1175 1176 1177 1178 1179 1180 1181

    companies(:first_firm).clients_of_firm = [good, bad]

    begin
      companies(:first_firm).clients_of_firm.destroy(good, bad)
    rescue Client::RaisedOnDestroy
    end

1182
    assert_equal [good, bad], companies(:first_firm).clients_of_firm.reload
1183 1184 1185
  end

  def test_transaction_when_deleting_new_record
1186
    assert_no_queries(ignore_none: false) do
J
Jon Leighton 已提交
1187 1188 1189 1190 1191
      firm = Firm.new
      client = Client.new("name" => "New Client")
      firm.clients_of_firm << client
      firm.clients_of_firm.destroy(client)
    end
1192 1193
  end

1194 1195 1196
  def test_clearing_an_association_collection
    firm = companies(:first_firm)
    client_id = firm.clients_of_firm.first.id
1197
    assert_equal 2, firm.clients_of_firm.size
1198

J
Jon Leighton 已提交
1199
    firm.clients_of_firm.clear
1200 1201

    assert_equal 0, firm.clients_of_firm.size
1202
    assert_equal 0, firm.clients_of_firm.reload.size
1203 1204 1205 1206
    assert_equal [], Client.destroyed_client_ids[firm.id]

    # Should not be destroyed since the association is not dependent.
    assert_nothing_raised do
1207
      assert_nil Client.find(client_id).firm
1208 1209 1210
    end
  end

1211 1212 1213
  def test_clearing_updates_counter_cache
    topic = Topic.first

1214
    assert_difference "topic.reload.replies_count", -1 do
1215 1216
      topic.replies.clear
    end
1217 1218
  end

1219 1220 1221 1222
  def test_clearing_updates_counter_cache_when_inverse_counter_cache_is_a_symbol_with_dependent_destroy
    car = Car.first
    car.engines.create!

1223
    assert_difference "car.reload.engines_count", -1 do
1224 1225 1226 1227
      car.engines.clear
    end
  end

1228 1229 1230
  def test_clearing_a_dependent_association_collection
    firm = companies(:first_firm)
    client_id = firm.dependent_clients_of_firm.first.id
1231
    assert_equal 2, firm.dependent_clients_of_firm.size
1232
    assert_equal 1, Client.find_by_id(client_id).client_of
1233

1234
    # :delete_all is called on each client since the dependent options is :destroy
1235 1236 1237
    firm.dependent_clients_of_firm.clear

    assert_equal 0, firm.dependent_clients_of_firm.size
1238
    assert_equal 0, firm.dependent_clients_of_firm.reload.size
1239
    assert_equal [], Client.destroyed_client_ids[firm.id]
1240 1241

    # Should be destroyed since the association is dependent.
1242
    assert_nil Client.find_by_id(client_id)
1243 1244 1245 1246 1247 1248
  end

  def test_delete_all_with_option_delete_all
    firm = companies(:first_firm)
    client_id = firm.dependent_clients_of_firm.first.id
    firm.dependent_clients_of_firm.delete_all(:delete_all)
1249
    assert_nil Client.find_by_id(client_id)
1250 1251
  end

1252 1253 1254 1255 1256 1257 1258
  def test_delete_all_accepts_limited_parameters
    firm = companies(:first_firm)
    assert_raise(ArgumentError) do
      firm.dependent_clients_of_firm.delete_all(:destroy)
    end
  end

1259 1260 1261
  def test_clearing_an_exclusively_dependent_association_collection
    firm = companies(:first_firm)
    client_id = firm.exclusively_dependent_clients_of_firm.first.id
1262
    assert_equal 2, firm.exclusively_dependent_clients_of_firm.size
1263 1264 1265 1266 1267 1268 1269 1270

    assert_equal [], Client.destroyed_client_ids[firm.id]

    # :exclusively_dependent means each client is deleted directly from
    # the database without looping through them calling destroy.
    firm.exclusively_dependent_clients_of_firm.clear

    assert_equal 0, firm.exclusively_dependent_clients_of_firm.size
1271
    assert_equal 0, firm.exclusively_dependent_clients_of_firm.reload.size
1272 1273 1274 1275
    # no destroy-filters should have been called
    assert_equal [], Client.destroyed_client_ids[firm.id]

    # Should be destroyed since the association is exclusively dependent.
1276
    assert_nil Client.find_by_id(client_id)
1277 1278 1279 1280
  end

  def test_dependent_association_respects_optional_conditions_on_delete
    firm = companies(:odegy)
1281 1282
    Client.create(client_of: firm.id, name: "BigShot Inc.")
    Client.create(client_of: firm.id, name: "SmallTime Inc.")
1283
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
1284
    assert_equal 2, Client.where(client_of: firm.id).size
1285 1286 1287
    assert_equal 1, firm.dependent_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
1288
    assert_equal 1, Client.where(client_of: firm.id).size
1289 1290 1291 1292
  end

  def test_dependent_association_respects_optional_sanitized_conditions_on_delete
    firm = companies(:odegy)
1293 1294
    Client.create(client_of: firm.id, name: "BigShot Inc.")
    Client.create(client_of: firm.id, name: "SmallTime Inc.")
1295
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
1296
    assert_equal 2, Client.where(client_of: firm.id).size
1297 1298 1299
    assert_equal 1, firm.dependent_sanitized_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
1300
    assert_equal 1, Client.where(client_of: firm.id).size
1301 1302
  end

1303 1304
  def test_dependent_association_respects_optional_hash_conditions_on_delete
    firm = companies(:odegy)
1305 1306
    Client.create(client_of: firm.id, name: "BigShot Inc.")
    Client.create(client_of: firm.id, name: "SmallTime Inc.")
1307
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
1308
    assert_equal 2, Client.where(client_of: firm.id).size
1309 1310 1311
    assert_equal 1, firm.dependent_sanitized_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
1312
    assert_equal 1, Client.where(client_of: firm.id).size
1313 1314
  end

1315
  def test_delete_all_association_with_primary_key_deletes_correct_records
1316
    firm = Firm.first
1317
    # break the vanilla firm_id foreign key
1318
    assert_equal 3, firm.clients.count
1319
    firm.clients.first.update_columns(firm_id: nil)
1320
    assert_equal 2, firm.clients.reload.count
1321
    assert_equal 2, firm.clients_using_primary_key_with_delete_all.count
1322
    old_record = firm.clients_using_primary_key_with_delete_all.first
1323
    firm = Firm.first
1324
    firm.destroy
1325
    assert_nil Client.find_by_id(old_record.id)
1326
  end
1327

1328 1329
  def test_creation_respects_hash_condition
    ms_client = companies(:first_firm).clients_like_ms_with_hash_conditions.build
1330

1331
    assert        ms_client.save
1332
    assert_equal  "Microsoft", ms_client.name
1333

1334 1335
    another_ms_client = companies(:first_firm).clients_like_ms_with_hash_conditions.create

1336
    assert        another_ms_client.persisted?
1337
    assert_equal  "Microsoft", another_ms_client.name
1338 1339 1340 1341 1342 1343 1344 1345
  end

  def test_clearing_without_initial_access
    firm = companies(:first_firm)

    firm.clients_of_firm.clear

    assert_equal 0, firm.clients_of_firm.size
1346
    assert_equal 0, firm.clients_of_firm.reload.size
1347 1348 1349 1350
  end

  def test_deleting_a_item_which_is_not_in_the_collection
    force_signal37_to_load_all_clients_of_firm
1351 1352 1353

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1354
    summit = Client.find_by_name("Summit")
1355
    companies(:first_firm).clients_of_firm.delete(summit)
1356
    assert_equal 2, companies(:first_firm).clients_of_firm.size
1357
    assert_equal 2, companies(:first_firm).clients_of_firm.reload.size
1358 1359 1360
    assert_equal 2, summit.client_of
  end

1361
  def test_deleting_by_integer_id
1362
    david = Developer.find(1)
1363

1364
    assert_difference "david.projects.count", -1 do
1365 1366 1367 1368 1369 1370 1371 1372 1373
      assert_equal 1, david.projects.delete(1).size
    end

    assert_equal 1, david.projects.size
  end

  def test_deleting_by_string_id
    david = Developer.find(1)

1374 1375
    assert_difference "david.projects.count", -1 do
      assert_equal 1, david.projects.delete("1").size
1376 1377 1378
    end

    assert_equal 1, david.projects.size
1379 1380 1381 1382 1383
  end

  def test_deleting_self_type_mismatch
    david = Developer.find(1)
    david.projects.reload
1384
    assert_raise(ActiveRecord::AssociationTypeMismatch) { david.projects.delete(Project.find(1).developers) }
1385 1386
  end

1387 1388 1389
  def test_destroying
    force_signal37_to_load_all_clients_of_firm

1390 1391
    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1392 1393 1394 1395
    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first)
    end

1396
    assert_equal 1, companies(:first_firm).reload.clients_of_firm.size
1397
    assert_equal 1, companies(:first_firm).clients_of_firm.reload.size
1398 1399
  end

1400
  def test_destroying_by_integer_id
1401 1402
    force_signal37_to_load_all_clients_of_firm

1403 1404
    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1405 1406 1407 1408
    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first.id)
    end

1409
    assert_equal 1, companies(:first_firm).reload.clients_of_firm.size
1410
    assert_equal 1, companies(:first_firm).clients_of_firm.reload.size
1411 1412 1413 1414 1415
  end

  def test_destroying_by_string_id
    force_signal37_to_load_all_clients_of_firm

1416 1417
    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1418 1419 1420 1421
    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first.id.to_s)
    end

1422
    assert_equal 1, companies(:first_firm).reload.clients_of_firm.size
1423
    assert_equal 1, companies(:first_firm).clients_of_firm.reload.size
1424 1425
  end

1426 1427
  def test_destroying_a_collection
    force_signal37_to_load_all_clients_of_firm
1428 1429 1430

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1431
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
1432
    assert_equal 3, companies(:first_firm).clients_of_firm.size
1433 1434 1435 1436 1437

    assert_difference "Client.count", -2 do
      companies(:first_firm).clients_of_firm.destroy([companies(:first_firm).clients_of_firm[0], companies(:first_firm).clients_of_firm[1]])
    end

1438
    assert_equal 1, companies(:first_firm).reload.clients_of_firm.size
1439
    assert_equal 1, companies(:first_firm).clients_of_firm.reload.size
1440 1441
  end

1442 1443
  def test_destroy_all
    force_signal37_to_load_all_clients_of_firm
1444 1445 1446

    assert_predicate companies(:first_firm).clients_of_firm, :loaded?

1447 1448 1449 1450
    clients = companies(:first_firm).clients_of_firm.to_a
    assert !clients.empty?, "37signals has clients after load"
    destroyed = companies(:first_firm).clients_of_firm.destroy_all
    assert_equal clients.sort_by(&:id), destroyed.sort_by(&:id)
1451
    assert destroyed.all?(&:frozen?), "destroyed clients should be frozen"
1452
    assert companies(:first_firm).clients_of_firm.empty?, "37signals has no clients after destroy all"
1453
    assert companies(:first_firm).clients_of_firm.reload.empty?, "37signals has no clients after destroy all and refresh"
1454 1455 1456 1457
  end

  def test_dependence
    firm = companies(:first_firm)
1458
    assert_equal 3, firm.clients.size
1459
    firm.destroy
1460
    assert Client.all.merge!(where: "firm_id=#{firm.id}").to_a.empty?
1461 1462
  end

1463 1464
  def test_dependence_for_associations_with_hash_condition
    david = authors(:david)
1465
    assert_difference("Post.count", -1) { assert david.destroy }
1466 1467
  end

1468
  def test_destroy_dependent_when_deleted_from_association
1469
    # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
1470
    firm = Firm.all.merge!(order: "id").first
1471
    assert_equal 3, firm.clients.size
1472 1473 1474 1475 1476 1477

    client = firm.clients.first
    firm.clients.delete(client)

    assert_raise(ActiveRecord::RecordNotFound) { Client.find(client.id) }
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find(client.id) }
1478
    assert_equal 2, firm.clients.size
1479 1480 1481 1482 1483
  end

  def test_three_levels_of_dependence
    topic = Topic.create "title" => "neat and simple"
    reply = topic.replies.create "title" => "neat and simple", "content" => "still digging it"
1484
    reply.replies.create "title" => "neat and simple", "content" => "ain't complaining"
1485 1486 1487 1488 1489 1490 1491

    assert_nothing_raised { topic.destroy }
  end

  def test_dependence_with_transaction_support_on_failure
    firm = companies(:first_firm)
    clients = firm.clients
1492
    assert_equal 3, clients.length
1493
    clients.last.instance_eval { def overwrite_to_raise() raise "Trigger rollback" end }
1494 1495 1496

    firm.destroy rescue "do nothing"

1497
    assert_equal 3, Client.all.merge!(where: "firm_id=#{firm.id}").to_a.size
1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
  end

  def test_dependence_on_account
    num_accounts = Account.count
    companies(:first_firm).destroy
    assert_equal num_accounts - 1, Account.count
  end

  def test_depends_and_nullify
    num_accounts = Account.count

    core = companies(:rails_core)
    assert_equal accounts(:rails_core_account), core.account
    assert_equal companies(:leetsoft, :jadedpixel), core.companies
    core.destroy
    assert_nil accounts(:rails_core_account).reload.firm_id
    assert_nil companies(:leetsoft).reload.client_of
    assert_nil companies(:jadedpixel).reload.client_of

    assert_equal num_accounts, Account.count
  end

1520
  def test_restrict_with_exception
1521 1522
    firm = RestrictedWithExceptionFirm.create!(name: "restrict")
    firm.companies.create(name: "child")
1523 1524 1525

    assert !firm.companies.empty?
    assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
1526 1527
    assert RestrictedWithExceptionFirm.exists?(name: "restrict")
    assert firm.companies.exists?(name: "child")
1528 1529
  end

1530 1531
  def test_restrict_with_error_is_deprecated_using_key_many
    I18n.backend = I18n::Backend::Simple.new
1532
    I18n.backend.store_translations :en, activerecord: { errors: { messages: { restrict_dependent_destroy: { many: "message for deprecated key" } } } }
1533

1534 1535
    firm = RestrictedWithErrorFirm.create!(name: "restrict")
    firm.companies.create(name: "child")
1536 1537 1538 1539 1540 1541 1542

    assert !firm.companies.empty?

    assert_deprecated { firm.destroy }

    assert !firm.errors.empty?

1543 1544 1545
    assert_equal "message for deprecated key", firm.errors[:base].first
    assert RestrictedWithErrorFirm.exists?(name: "restrict")
    assert firm.companies.exists?(name: "child")
1546 1547 1548 1549
  ensure
    I18n.backend.reload!
  end

1550
  def test_restrict_with_error
1551 1552
    firm = RestrictedWithErrorFirm.create!(name: "restrict")
    firm.companies.create(name: "child")
1553 1554 1555 1556 1557 1558 1559

    assert !firm.companies.empty?

    firm.destroy

    assert !firm.errors.empty?

1560
    assert_equal "Cannot delete record because dependent companies exist", firm.errors[:base].first
1561 1562
    assert RestrictedWithErrorFirm.exists?(name: "restrict")
    assert firm.companies.exists?(name: "child")
1563 1564
  end

1565 1566
  def test_restrict_with_error_with_locale
    I18n.backend = I18n::Backend::Simple.new
1567
    I18n.backend.store_translations "en", activerecord: { attributes: { restricted_with_error_firm: { companies: "client companies" } } }
1568 1569
    firm = RestrictedWithErrorFirm.create!(name: "restrict")
    firm.companies.create(name: "child")
1570 1571 1572 1573 1574 1575 1576 1577

    assert !firm.companies.empty?

    firm.destroy

    assert !firm.errors.empty?

    assert_equal "Cannot delete record because dependent client companies exist", firm.errors[:base].first
1578 1579
    assert RestrictedWithErrorFirm.exists?(name: "restrict")
    assert firm.companies.exists?(name: "child")
1580 1581 1582 1583
  ensure
    I18n.backend.reload!
  end

1584
  def test_included_in_collection
1585
    assert_equal true, companies(:first_firm).clients.include?(Client.find(2))
1586 1587
  end

1588
  def test_included_in_collection_for_new_records
1589
    client = Client.create(name: "Persisted")
1590
    assert_nil client.client_of
1591
    assert_equal false, Firm.new.clients_of_firm.include?(client),
1592
     "includes a client that does not belong to any firm"
1593 1594
  end

1595
  def test_adding_array_and_collection
J
Jon Leighton 已提交
1596
    assert_nothing_raised { Firm.first.clients + Firm.all.last.clients }
1597 1598 1599
  end

  def test_replace_with_less
1600
    firm = Firm.all.merge!(order: "id").first
1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613
    firm.clients = [companies(:first_client)]
    assert firm.save, "Could not save firm"
    firm.reload
    assert_equal 1, firm.clients.length
  end

  def test_replace_with_less_and_dependent_nullify
    num_companies = Company.count
    companies(:rails_core).companies = []
    assert_equal num_companies, Company.count
  end

  def test_replace_with_new
1614
    firm = Firm.all.merge!(order: "id").first
1615 1616 1617 1618
    firm.clients = [companies(:second_client), Client.new("name" => "New Client")]
    firm.save
    firm.reload
    assert_equal 2, firm.clients.length
1619
    assert_equal false, firm.clients.include?(:first_client)
1620 1621
  end

1622 1623 1624 1625 1626 1627 1628
  def test_replace_failure
    firm = companies(:first_firm)
    account = Account.new
    orig_accounts = firm.accounts.to_a

    assert !account.valid?
    assert !orig_accounts.empty?
1629
    error = assert_raise ActiveRecord::RecordNotSaved do
1630 1631
      firm.accounts = [account]
    end
1632

1633
    assert_equal orig_accounts, firm.accounts
1634 1635
    assert_equal "Failed to replace accounts because one or more of the " \
                 "new records could not be saved.", error.message
1636 1637
  end

1638 1639 1640 1641 1642 1643 1644 1645
  def test_replace_with_same_content
    firm = Firm.first
    firm.clients = []
    firm.save

    assert_queries(0, ignore_none: true) do
      firm.clients = []
    end
1646

1647
    assert_equal [], firm.send("clients=", [])
1648 1649
  end

1650
  def test_transactions_when_replacing_on_persisted
1651 1652
    good = Client.new(name: "Good")
    bad  = Client.new(name: "Bad", raise_on_save: true)
1653

J
Jon Leighton 已提交
1654 1655 1656 1657 1658 1659 1660
    companies(:first_firm).clients_of_firm = [good]

    begin
      companies(:first_firm).clients_of_firm = [bad]
    rescue Client::RaisedOnSave
    end

1661
    assert_equal [good], companies(:first_firm).clients_of_firm.reload
1662 1663 1664
  end

  def test_transactions_when_replacing_on_new_record
1665
    assert_no_queries(ignore_none: false) do
J
Jon Leighton 已提交
1666 1667 1668
      firm = Firm.new
      firm.clients_of_firm = [Client.new("name" => "New Client")]
    end
1669 1670
  end

1671
  def test_get_ids
1672
    assert_equal [companies(:first_client).id, companies(:second_client).id, companies(:another_first_firm_client).id], companies(:first_firm).client_ids
1673 1674
  end

1675 1676
  def test_get_ids_for_loaded_associations
    company = companies(:first_firm)
1677
    company.clients.reload
1678 1679 1680 1681 1682 1683 1684 1685 1686
    assert_queries(0) do
      company.client_ids
      company.client_ids
    end
  end

  def test_get_ids_for_unloaded_associations_does_not_load_them
    company = companies(:first_firm)
    assert !company.clients.loaded?
1687
    assert_equal [companies(:first_client).id, companies(:second_client).id, companies(:another_first_firm_client).id], company.client_ids
1688 1689 1690
    assert !company.clients.loaded?
  end

1691 1692 1693 1694
  def test_get_ids_ignores_include_option
    assert_equal [readers(:michael_welcome).id], posts(:welcome).readers_with_person_ids
  end

1695
  def test_get_ids_for_ordered_association
1696
    assert_equal [companies(:another_first_firm_client).id, companies(:second_client).id, companies(:first_client).id], companies(:first_firm).clients_ordered_by_name_ids
1697 1698
  end

1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713
  def test_get_ids_for_association_on_new_record_does_not_try_to_find_records
    Company.columns  # Load schema information so we don't query below
    Contract.columns # if running just this test.

    company = Company.new
    assert_queries(0) do
      company.contract_ids
    end

    assert_equal [], company.contract_ids
  end

  def test_set_ids_for_association_on_new_record_applies_association_correctly
    contract_a = Contract.create!
    contract_b = Contract.create!
1714
    Contract.create! # another contract
1715
    company = Company.new(name: "Some Company")
1716 1717 1718 1719 1720 1721 1722 1723 1724 1725

    company.contract_ids = [contract_a.id, contract_b.id]
    assert_equal [contract_a.id, contract_b.id], company.contract_ids
    assert_equal [contract_a, contract_b], company.contracts

    company.save!
    assert_equal company, contract_a.reload.company
    assert_equal company, contract_b.reload.company
  end

1726
  def test_assign_ids_ignoring_blanks
1727
    firm = Firm.create!(name: "Apple")
1728
    firm.client_ids = [companies(:first_client).id, nil, companies(:second_client).id, ""]
1729 1730
    firm.save!

1731
    assert_equal 2, firm.clients.reload.size
1732
    assert_equal true, firm.clients.include?(companies(:second_client))
1733 1734 1735 1736 1737 1738 1739 1740 1741 1742
  end

  def test_get_ids_for_through
    assert_equal [comments(:eager_other_comment1).id], authors(:mary).comment_ids
  end

  def test_modifying_a_through_a_has_many_should_raise
    [
      lambda { authors(:mary).comment_ids = [comments(:greetings).id, comments(:more_greetings).id] },
      lambda { authors(:mary).comments = [comments(:greetings), comments(:more_greetings)] },
1743
      lambda { authors(:mary).comments << Comment.create!(body: "Yay", post_id: 424242) },
1744
      lambda { authors(:mary).comments.delete(authors(:mary).comments.first) },
1745
    ].each { |block| assert_raise(ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection, &block) }
1746 1747 1748
  end

  def test_dynamic_find_should_respect_association_order_for_through
1749
    assert_equal Comment.find(10), authors(:david).comments_desc.where("comments.type = 'SpecialComment'").first
1750
    assert_equal Comment.find(10), authors(:david).comments_desc.find_by_type("SpecialComment")
1751 1752 1753 1754 1755 1756 1757 1758 1759
  end

  def test_has_many_through_respects_hash_conditions
    assert_equal authors(:david).hello_posts, authors(:david).hello_posts_with_hash_conditions
    assert_equal authors(:david).hello_post_comments, authors(:david).hello_post_comments_with_hash_conditions
  end

  def test_include_uses_array_include_after_loaded
    firm = companies(:first_firm)
J
Jon Leighton 已提交
1760
    firm.clients.load_target
1761

1762 1763 1764 1765
    client = firm.clients.first

    assert_no_queries do
      assert firm.clients.loaded?
1766
      assert_equal true, firm.clients.include?(client)
1767 1768 1769 1770 1771 1772 1773 1774 1775 1776
    end
  end

  def test_include_checks_if_record_exists_if_target_not_loaded
    firm = companies(:first_firm)
    client = firm.clients.first

    firm.reload
    assert ! firm.clients.loaded?
    assert_queries(1) do
1777
      assert_equal true, firm.clients.include?(client)
1778 1779 1780 1781 1782 1783
    end
    assert ! firm.clients.loaded?
  end

  def test_include_returns_false_for_non_matching_record_to_verify_scoping
    firm = companies(:first_firm)
1784
    client = Client.create!(name: "Not Associated")
1785 1786

    assert ! firm.clients.loaded?
1787
    assert_equal false, firm.clients.include?(client)
1788 1789
  end

1790
  def test_calling_first_nth_or_last_on_association_should_not_load_association
1791 1792
    firm = companies(:first_firm)
    firm.clients.first
1793
    firm.clients.second
1794 1795 1796 1797 1798 1799
    firm.clients.last
    assert !firm.clients.loaded?
  end

  def test_calling_first_or_last_on_loaded_association_should_not_fetch_with_query
    firm = companies(:first_firm)
J
Jon Leighton 已提交
1800
    firm.clients.load_target
1801 1802
    assert firm.clients.loaded?

1803
    assert_no_queries(ignore_none: false) do
1804 1805 1806 1807 1808 1809 1810 1811 1812
      firm.clients.first
      assert_equal 2, firm.clients.first(2).size
      firm.clients.last
      assert_equal 2, firm.clients.last(2).size
    end
  end

  def test_calling_first_or_last_on_existing_record_with_build_should_load_association
    firm = companies(:first_firm)
1813
    firm.clients.build(name: "Foo")
1814 1815 1816 1817
    assert !firm.clients.loaded?

    assert_queries 1 do
      firm.clients.first
1818
      firm.clients.second
1819 1820 1821 1822 1823 1824
      firm.clients.last
    end

    assert firm.clients.loaded?
  end

1825
  def test_calling_first_nth_or_last_on_existing_record_with_create_should_not_load_association
1826
    firm = companies(:first_firm)
1827
    firm.clients.create(name: "Foo")
1828 1829
    assert !firm.clients.loaded?

1830
    assert_queries 3 do
1831
      firm.clients.first
1832
      firm.clients.second
1833 1834 1835 1836 1837 1838
      firm.clients.last
    end

    assert !firm.clients.loaded?
  end

1839
  def test_calling_first_nth_or_last_on_new_record_should_not_run_queries
1840 1841 1842 1843
    firm = Firm.new

    assert_no_queries do
      firm.clients.first
1844
      firm.clients.second
1845 1846 1847
      firm.clients.last
    end
  end
1848

1849
  def test_calling_first_or_last_with_integer_on_association_should_not_load_association
1850
    firm = companies(:first_firm)
1851
    firm.clients.create(name: "Foo")
1852
    assert !firm.clients.loaded?
1853

1854
    assert_queries 2 do
1855 1856 1857 1858
      firm.clients.first(2)
      firm.clients.last(2)
    end

1859
    assert !firm.clients.loaded?
1860 1861
  end

1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897
  def test_calling_many_should_count_instead_of_loading_association
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.many?  # use count query
    end
    assert !firm.clients.loaded?
  end

  def test_calling_many_on_loaded_association_should_not_use_query
    firm = companies(:first_firm)
    firm.clients.collect  # force load
    assert_no_queries { assert firm.clients.many? }
  end

  def test_calling_many_should_defer_to_collection_if_using_a_block
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.expects(:size).never
      firm.clients.many? { true }
    end
    assert firm.clients.loaded?
  end

  def test_calling_many_should_return_false_if_none_or_one
    firm = companies(:another_firm)
    assert !firm.clients_like_ms.many?
    assert_equal 0, firm.clients_like_ms.size

    firm = companies(:first_firm)
    assert !firm.limited_clients.many?
    assert_equal 1, firm.limited_clients.size
  end

  def test_calling_many_should_return_true_if_more_than_one
    firm = companies(:first_firm)
    assert firm.clients.many?
1898
    assert_equal 3, firm.clients.size
1899 1900
  end

1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976
  def test_calling_none_should_count_instead_of_loading_association
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.none?  # use count query
    end
    assert !firm.clients.loaded?
  end

  def test_calling_none_on_loaded_association_should_not_use_query
    firm = companies(:first_firm)
    firm.clients.collect  # force load
    assert_no_queries { assert ! firm.clients.none? }
  end

  def test_calling_none_should_defer_to_collection_if_using_a_block
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.expects(:size).never
      firm.clients.none? { true }
    end
    assert firm.clients.loaded?
  end

  def test_calling_none_should_return_true_if_none
    firm = companies(:another_firm)
    assert firm.clients_like_ms.none?
    assert_equal 0, firm.clients_like_ms.size
  end

  def test_calling_none_should_return_false_if_any
    firm = companies(:first_firm)
    assert !firm.limited_clients.none?
    assert_equal 1, firm.limited_clients.size
  end

  def test_calling_one_should_count_instead_of_loading_association
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.one?  # use count query
    end
    assert !firm.clients.loaded?
  end

  def test_calling_one_on_loaded_association_should_not_use_query
    firm = companies(:first_firm)
    firm.clients.collect  # force load
    assert_no_queries { assert ! firm.clients.one? }
  end

  def test_calling_one_should_defer_to_collection_if_using_a_block
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.expects(:size).never
      firm.clients.one? { true }
    end
    assert firm.clients.loaded?
  end

  def test_calling_one_should_return_false_if_zero
    firm = companies(:another_firm)
    assert ! firm.clients_like_ms.one?
    assert_equal 0, firm.clients_like_ms.size
  end

  def test_calling_one_should_return_true_if_one
    firm = companies(:first_firm)
    assert firm.limited_clients.one?
    assert_equal 1, firm.limited_clients.size
  end

  def test_calling_one_should_return_false_if_more_than_one
    firm = companies(:first_firm)
    assert ! firm.clients.one?
    assert_equal 3, firm.clients.size
  end

1977 1978 1979 1980
  def test_joins_with_namespaced_model_should_use_correct_type
    old = ActiveRecord::Base.store_full_sti_class
    ActiveRecord::Base.store_full_sti_class = true

1981 1982
    firm = Namespaced::Firm.create(name: "Some Company")
    firm.clients.create(name: "Some Client")
1983

1984
    stats = Namespaced::Firm.all.merge!(
1985 1986 1987
      select: "#{Namespaced::Firm.table_name}.id, COUNT(#{Namespaced::Client.table_name}.id) AS num_clients",
      joins: :clients,
      group: "#{Namespaced::Firm.table_name}.id"
J
Jon Leighton 已提交
1988
    ).find firm.id
1989 1990 1991 1992 1993
    assert_equal 1, stats.num_clients.to_i
  ensure
    ActiveRecord::Base.store_full_sti_class = old
  end

1994 1995
  def test_association_proxy_transaction_method_starts_transaction_in_association_class
    Comment.expects(:transaction)
1996
    Post.first.comments.transaction do
1997
      # nothing
1998 1999 2000
    end
  end

2001
  def test_sending_new_to_association_proxy_should_have_same_effect_as_calling_new
2002 2003 2004 2005 2006 2007 2008 2009
    client_association = companies(:first_firm).clients
    assert_equal client_association.new.attributes, client_association.send(:new).attributes
  end

  def test_respond_to_private_class_methods
    client_association = companies(:first_firm).clients
    assert !client_association.respond_to?(:private_method)
    assert client_association.respond_to?(:private_method, true)
2010
  end
2011 2012

  def test_creating_using_primary_key
2013 2014
    firm = Firm.all.merge!(order: "id").first
    client = firm.clients_using_primary_key.create!(name: "test")
2015 2016
    assert_equal firm.name, client.firm_name
  end
2017 2018 2019

  def test_defining_has_many_association_with_delete_all_dependency_lazily_evaluates_target_class
    ActiveRecord::Reflection::AssociationReflection.any_instance.expects(:class_name).never
2020
    class_eval(<<-EOF, __FILE__, __LINE__ + 1)
2021 2022 2023 2024 2025 2026 2027 2028
      class DeleteAllModel < ActiveRecord::Base
        has_many :nonentities, :dependent => :delete_all
      end
    EOF
  end

  def test_defining_has_many_association_with_nullify_dependency_lazily_evaluates_target_class
    ActiveRecord::Reflection::AssociationReflection.any_instance.expects(:class_name).never
2029
    class_eval(<<-EOF, __FILE__, __LINE__ + 1)
2030 2031 2032 2033 2034
      class NullifyModel < ActiveRecord::Base
        has_many :nonentities, :dependent => :nullify
      end
    EOF
  end
2035 2036

  def test_attributes_are_being_set_when_initialized_from_has_many_association_with_where_clause
2037
    new_comment = posts(:welcome).comments.where(body: "Some content").build
2038 2039 2040 2041
    assert_equal new_comment.body, "Some content"
  end

  def test_attributes_are_being_set_when_initialized_from_has_many_association_with_multiple_where_clauses
2042
    new_comment = posts(:welcome).comments.where(body: "Some content").where(type: "SpecialComment").build
2043 2044 2045 2046
    assert_equal new_comment.body, "Some content"
    assert_equal new_comment.type, "SpecialComment"
    assert_equal new_comment.post_id, posts(:welcome).id
  end
2047 2048 2049 2050

  def test_include_method_in_has_many_association_should_return_true_for_instance_added_with_build
    post = Post.new
    comment = post.comments.build
2051
    assert_equal true, post.comments.include?(comment)
2052
  end
2053 2054 2055

  def test_load_target_respects_protected_attributes
    topic = Topic.create!
2056
    reply = topic.replies.create(title: "reply 1")
2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073
    reply.approved = false
    reply.save!

    # Save with a different object instance, so the instance that's still held
    # in topic.relies doesn't know about the changed attribute.
    reply2 = Reply.find(reply.id)
    reply2.approved = true
    reply2.save!

    # Force loading the collection from the db. This will merge the existing
    # object (reply) with what gets loaded from the db (which includes the
    # changed approved attribute). approved is a protected attribute, so if mass
    # assignment is used, it won't get updated and will still be false.
    first = topic.replies.to_a.first
    assert_equal reply.id, first.id
    assert_equal true, first.approved?
  end
2074 2075 2076 2077 2078 2079 2080

  def test_to_a_should_dup_target
    ary    = topics(:first).replies.to_a
    target = topics(:first).replies.target

    assert_not_equal target.object_id, ary.object_id
  end
2081 2082

  def test_merging_with_custom_attribute_writer
2083
    bulb = Bulb.new(color: "red")
2084 2085 2086 2087 2088 2089 2090
    assert_equal "RED!", bulb.color

    car = Car.create!
    car.bulbs << bulb

    assert_equal "RED!", car.bulbs.to_a.first.color
  end
2091

2092
  def test_abstract_class_with_polymorphic_has_many
2093 2094
    post = SubStiPost.create! title: "fooo", body: "baa"
    tagging = Tagging.create! taggable: post
2095 2096
    assert_equal [tagging], post.taggings
  end
F
Farley Knight 已提交
2097

2098
  def test_with_polymorphic_has_many_with_custom_columns_name
2099
    post = Post.create! title: "foo", body: "bar"
2100 2101 2102 2103 2104 2105 2106
    image = Image.create!

    post.images << image

    assert_equal [image], post.images
  end

A
Andy Lindeman 已提交
2107
  def test_build_with_polymorphic_has_many_does_not_allow_to_override_type_and_id
2108
    welcome = posts(:welcome)
2109
    tagging = welcome.taggings.build(taggable_id: 99, taggable_type: "ShouldNotChange")
2110 2111

    assert_equal welcome.id, tagging.taggable_id
2112
    assert_equal "Post", tagging.taggable_type
2113 2114
  end

F
Farley Knight 已提交
2115 2116 2117 2118 2119 2120 2121
  def test_dont_call_save_callbacks_twice_on_has_many
    firm = companies(:first_firm)
    contract = firm.contracts.create!

    assert_equal 1, contract.hi_count
    assert_equal 1, contract.bye_count
  end
2122 2123

  def test_association_attributes_are_available_to_after_initialize
2124
    car = Car.create(name: "honda")
2125 2126
    bulb = car.bulbs.build

2127
    assert_equal car.id, bulb.attributes_after_initialize["car_id"]
2128
  end
2129

2130
  def test_attributes_are_set_when_initialized_from_has_many_null_relationship
2131 2132 2133
    car  = Car.new name: "honda"
    bulb = car.bulbs.where(name: "headlight").first_or_initialize
    assert_equal "headlight", bulb.name
2134 2135 2136
  end

  def test_attributes_are_set_when_initialized_from_polymorphic_has_many_null_relationship
2137 2138
    post    = Post.new title: "title", body: "bar"
    tag     = Tag.create!(name: "foo")
2139 2140 2141 2142

    tagging = post.taggings.where(tag: tag).first_or_initialize

    assert_equal tag.id, tagging.tag_id
2143
    assert_equal "Post", tagging.taggable_type
2144 2145
  end

2146
  def test_replace
2147
    car = Car.create(name: "honda")
2148 2149 2150 2151 2152 2153 2154 2155
    bulb1 = car.bulbs.create
    bulb2 = Bulb.create

    assert_equal [bulb1], car.bulbs
    car.bulbs.replace([bulb2])
    assert_equal [bulb2], car.bulbs
    assert_equal [bulb2], car.reload.bulbs
  end
2156

2157
  def test_replace_returns_target
2158
    car = Car.create(name: "honda")
2159 2160 2161 2162 2163
    bulb1 = car.bulbs.create
    bulb2 = car.bulbs.create
    bulb3 = Bulb.create

    assert_equal [bulb1, bulb2], car.bulbs
2164
    result = car.bulbs.replace([bulb3, bulb1])
2165 2166 2167 2168
    assert_equal [bulb1, bulb3], car.bulbs
    assert_equal [bulb1, bulb3], result
  end

2169 2170 2171 2172
  def test_collection_association_with_private_kernel_method
    firm = companies(:first_firm)
    assert_equal [accounts(:signals37)], firm.accounts.open
  end
J
Jon Leighton 已提交
2173 2174

  test "first_or_initialize adds the record to the association" do
2175
    firm = Firm.create! name: "omg"
J
Jon Leighton 已提交
2176 2177 2178 2179 2180
    client = firm.clients_of_firm.first_or_initialize
    assert_equal [client], firm.clients_of_firm
  end

  test "first_or_create adds the record to the association" do
2181
    firm = Firm.create! name: "omg"
J
Jon Leighton 已提交
2182
    firm.clients_of_firm.load_target
2183
    client = firm.clients_of_firm.first_or_create name: "lol"
J
Jon Leighton 已提交
2184 2185 2186
    assert_equal [client], firm.clients_of_firm
    assert_equal [client], firm.reload.clients_of_firm
  end
2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198

  test "delete_all, when not loaded, doesn't load the records" do
    post = posts(:welcome)

    assert post.taggings_with_delete_all.count > 0
    assert !post.taggings_with_delete_all.loaded?

    # 2 queries: one DELETE and another to update the counter cache
    assert_queries(2) do
      post.taggings_with_delete_all.delete_all
    end
  end
2199

2200 2201 2202
  test "has many associations on new records use null relations" do
    post = Post.new

2203
    assert_no_queries(ignore_none: false) do
2204
      assert_equal [], post.comments
2205
      assert_equal [], post.comments.where(body: "omg")
2206
      assert_equal [], post.comments.pluck(:body)
2207
      assert_equal 0,  post.comments.sum(:id)
V
Vipul A M 已提交
2208
      assert_equal 0,  post.comments.count
2209 2210
    end
  end
2211 2212 2213 2214 2215

  test "collection proxy respects default scope" do
    author = authors(:mary)
    assert !author.first_posts.exists?
  end
J
Jon Leighton 已提交
2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227

  test "association with extend option" do
    post = posts(:welcome)
    assert_equal "lifo",  post.comments_with_extend.author
    assert_equal "hello", post.comments_with_extend.greeting
  end

  test "association with extend option with multiple extensions" do
    post = posts(:welcome)
    assert_equal "lifo",  post.comments_with_extend_2.author
    assert_equal "hello", post.comments_with_extend_2.greeting
  end
2228 2229 2230 2231 2232

  test "delete record with complex joins" do
    david = authors(:david)

    post = david.posts.first
2233
    post.type = "PostWithSpecialCategorization"
2234 2235 2236 2237 2238 2239 2240 2241 2242 2243
    post.save

    categorization = post.categorizations.first
    categorization.special = true
    categorization.save

    assert_not_equal [], david.posts_with_special_categorizations
    david.posts_with_special_categorizations = []
    assert_equal [], david.posts_with_special_categorizations
  end
2244 2245

  test "does not duplicate associations when used with natural primary keys" do
2246 2247
    speedometer = Speedometer.create!(id: "4")
    speedometer.minivans.create!(minivan_id: "a-van-red" ,name: "a van", color: "red")
2248 2249 2250 2251

    assert_equal 1, speedometer.minivans.to_a.size, "Only one association should be present:\n#{speedometer.minivans.to_a}"
    assert_equal 1, speedometer.reload.minivans.to_a.size
  end
J
Jon Leighton 已提交
2252 2253 2254 2255 2256 2257 2258 2259 2260

  test "can unscope the default scope of the associated model" do
    car = Car.create!
    bulb1 = Bulb.create! name: "defaulty", car: car
    bulb2 = Bulb.create! name: "other",    car: car

    assert_equal [bulb1], car.bulbs
    assert_equal [bulb1, bulb2], car.all_bulbs.sort_by(&:id)
  end
2261

2262
  test "can unscope and where the default scope of the associated model" do
2263
    Car.has_many :other_bulbs, -> { unscope(where: [:name]).where(name: "other") }, class_name: "Bulb"
2264 2265 2266 2267 2268 2269 2270 2271 2272
    car = Car.create!
    bulb1 = Bulb.create! name: "defaulty", car: car
    bulb2 = Bulb.create! name: "other",    car: car

    assert_equal [bulb1], car.bulbs
    assert_equal [bulb2], car.other_bulbs
  end

  test "can rewhere the default scope of the associated model" do
2273
    Car.has_many :old_bulbs, -> { rewhere(name: "old") }, class_name: "Bulb"
2274 2275 2276 2277 2278 2279 2280 2281
    car = Car.create!
    bulb1 = Bulb.create! name: "defaulty", car: car
    bulb2 = Bulb.create! name: "old",      car: car

    assert_equal [bulb1], car.bulbs
    assert_equal [bulb2], car.old_bulbs
  end

2282
  test "unscopes the default scope of associated model when used with include" do
2283 2284 2285 2286 2287 2288 2289
    car = Car.create!
    bulb = Bulb.create! name: "other", car: car

    assert_equal bulb, Car.find(car.id).all_bulbs.first
    assert_equal bulb, Car.includes(:all_bulbs).find(car.id).all_bulbs.first
  end

2290 2291 2292 2293
  test "raises RecordNotDestroyed when replaced child can't be destroyed" do
    car = Car.create!
    original_child = FailedBulb.create!(car: car)

2294
    error = assert_raise(ActiveRecord::RecordNotDestroyed) do
2295 2296 2297 2298
      car.failed_bulbs = [FailedBulb.create!]
    end

    assert_equal [original_child], car.reload.failed_bulbs
2299
    assert_equal "Failed to destroy the record", error.message
2300
  end
2301

2302
  test "updates counter cache when default scope is given" do
2303 2304 2305 2306 2307
    topic = DefaultRejectedTopic.create approved: true

    assert_difference "topic.reload.replies_count", 1 do
      topic.approved_replies.create!
    end
2308
  end
2309

2310 2311
  test "dangerous association name raises ArgumentError" do
    [:errors, "errors", :save, "save"].each do |name|
2312 2313 2314 2315 2316 2317 2318
      assert_raises(ArgumentError, "Association #{name} should not be allowed") do
        Class.new(ActiveRecord::Base) do
          has_many name
        end
      end
    end
  end
2319

2320
  test "passes custom context validation to validate children" do
2321 2322
    pirate = FamousPirate.new
    pirate.famous_ships << ship = FamousShip.new
2323 2324 2325

    assert pirate.valid?
    assert_not pirate.valid?(:conference)
2326 2327
    assert_equal "can't be blank", ship.errors[:name].first
  end
2328

2329
  test "association with instance dependent scope" do
2330 2331 2332 2333 2334 2335 2336 2337
    bob = authors(:bob)
    Post.create!(title: "signed post by bob", body: "stuff", author: authors(:bob))
    Post.create!(title: "anonymous post", body: "more stuff", author: authors(:bob))
    assert_equal ["misc post by bob", "other post by bob",
                  "signed post by bob"], bob.posts_with_signature.map(&:title).sort

    assert_equal [], authors(:david).posts_with_signature.map(&:title)
  end
2338

2339
  test "associations autosaves when object is already persisted" do
2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350
    bulb = Bulb.create!
    tyre = Tyre.create!

    car = Car.create! do |c|
      c.bulbs << bulb
      c.tyres << tyre
    end

    assert_equal 1, car.bulbs.count
    assert_equal 1, car.tyres.count
  end
2351

2352
  test "associations replace in memory when records have the same id" do
2353 2354 2355 2356 2357 2358 2359 2360 2361 2362
    bulb = Bulb.create!
    car = Car.create!(bulbs: [bulb])

    new_bulb = Bulb.find(bulb.id)
    new_bulb.name = "foo"
    car.bulbs = [new_bulb]

    assert_equal "foo", car.bulbs.first.name
  end

2363
  test "in memory replacement executes no queries" do
2364 2365 2366 2367 2368 2369 2370 2371 2372 2373
    bulb = Bulb.create!
    car = Car.create!(bulbs: [bulb])

    new_bulb = Bulb.find(bulb.id)

    assert_no_queries do
      car.bulbs = [new_bulb]
    end
  end

2374
  test "in memory replacements do not execute callbacks" do
2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394
    raise_after_add = false
    klass = Class.new(ActiveRecord::Base) do
      self.table_name = :cars
      has_many :bulbs, after_add: proc { raise if raise_after_add }

      def self.name
        "Car"
      end
    end
    bulb = Bulb.create!
    car = klass.create!(bulbs: [bulb])

    new_bulb = Bulb.find(bulb.id)
    raise_after_add = true

    assert_nothing_raised do
      car.bulbs = [new_bulb]
    end
  end

2395
  test "in memory replacements sets inverse instance" do
2396 2397 2398 2399 2400 2401 2402 2403 2404
    bulb = Bulb.create!
    car = Car.create!(bulbs: [bulb])

    new_bulb = Bulb.find(bulb.id)
    car.bulbs = [new_bulb]

    assert_same car, new_bulb.car
  end

2405
  test "in memory replacement maintains order" do
2406 2407 2408 2409 2410 2411 2412 2413 2414
    first_bulb = Bulb.create!
    second_bulb = Bulb.create!
    car = Car.create!(bulbs: [first_bulb, second_bulb])

    same_bulb = Bulb.find(first_bulb.id)
    car.bulbs = [second_bulb, same_bulb]

    assert_equal [first_bulb, second_bulb], car.bulbs
  end
2415

2416
  test "double insertion of new object to association when same association used in the after create callback of a new object" do
2417 2418 2419 2420 2421
    car = Car.create!
    car.bulbs << TrickyBulb.new
    assert_equal 1, car.bulbs.size
  end

2422 2423 2424 2425 2426
  def test_association_force_reload_with_only_true_is_deprecated
    company = Company.find(1)

    assert_deprecated { company.clients_of_firm(true) }
  end
2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456

  class AuthorWithErrorDestroyingAssociation < ActiveRecord::Base
    self.table_name = "authors"
    has_many :posts_with_error_destroying,
      class_name: "PostWithErrorDestroying",
      foreign_key: :author_id,
      dependent: :destroy
  end

  class PostWithErrorDestroying < ActiveRecord::Base
    self.table_name = "posts"
    self.inheritance_column = nil
    before_destroy -> { throw :abort }
  end

  def test_destroy_does_not_raise_when_association_errors_on_destroy
    assert_no_difference "AuthorWithErrorDestroyingAssociation.count" do
      author = AuthorWithErrorDestroyingAssociation.first

      assert_not author.destroy
    end
  end

  def test_destroy_with_bang_bubbles_errors_from_associations
    error = assert_raises ActiveRecord::RecordNotDestroyed do
      AuthorWithErrorDestroyingAssociation.first.destroy!
    end

    assert_instance_of PostWithErrorDestroying, error.record
  end
2457 2458

  def test_ids_reader_memoization
2459
    car = Car.create!(name: "Tofaş")
2460 2461 2462 2463 2464
    bulb = Bulb.create!(car: car)

    assert_equal [bulb.id], car.bulb_ids
    assert_no_queries { car.bulb_ids }
  end
2465 2466 2467 2468 2469 2470

  private

    def force_signal37_to_load_all_clients_of_firm
      companies(:first_firm).clients_of_firm.load_target
    end
2471
end