has_many_associations_test.rb 57.2 KB
Newer Older
1
require "cases/helper"
2 3 4
require 'models/developer'
require 'models/project'
require 'models/company'
F
Farley Knight 已提交
5
require 'models/contract'
6 7 8 9 10
require 'models/topic'
require 'models/reply'
require 'models/category'
require 'models/post'
require 'models/author'
11
require 'models/essay'
12 13 14
require 'models/comment'
require 'models/person'
require 'models/reader'
J
Jeremy Kemper 已提交
15
require 'models/tagging'
16
require 'models/tag'
17 18
require 'models/invoice'
require 'models/line_item'
19 20
require 'models/car'
require 'models/bulb'
21
require 'models/engine'
22

23 24
class HasManyAssociationsTestForCountWithFinderSql < ActiveRecord::TestCase
  class Invoice < ActiveRecord::Base
25 26 27
    ActiveSupport::Deprecation.silence do
      has_many :custom_line_items, :class_name => 'LineItem', :finder_sql => "SELECT line_items.* from line_items"
    end
28 29 30 31 32 33 34 35 36 37
  end
  def test_should_fail
    assert_raise(ArgumentError) do
      Invoice.create.custom_line_items.count(:conditions => {:amount => 0})
    end
  end
end

class HasManyAssociationsTestForCountWithCountSql < ActiveRecord::TestCase
  class Invoice < ActiveRecord::Base
38 39 40
    ActiveSupport::Deprecation.silence do
      has_many :custom_line_items, :class_name => 'LineItem', :counter_sql => "SELECT COUNT(*) line_items.* from line_items"
    end
41 42 43 44 45 46 47 48
  end
  def test_should_fail
    assert_raise(ArgumentError) do
      Invoice.create.custom_line_items.count(:conditions => {:amount => 0})
    end
  end
end

49
class HasManyAssociationsTestForCountWithVariousFinderSqls < ActiveRecord::TestCase
50
  class Invoice < ActiveRecord::Base
51 52
    ActiveSupport::Deprecation.silence do
      has_many :custom_line_items, :class_name => 'LineItem', :finder_sql => "SELECT DISTINCT line_items.amount from line_items"
53 54 55
      has_many :custom_full_line_items, :class_name => 'LineItem', :finder_sql => "SELECT line_items.invoice_id, line_items.amount from line_items"
      has_many :custom_star_line_items, :class_name => 'LineItem', :finder_sql => "SELECT * from line_items"
      has_many :custom_qualified_star_line_items, :class_name => 'LineItem', :finder_sql => "SELECT line_items.* from line_items"
56
    end
57 58 59 60 61 62 63 64 65 66
  end

  def test_should_count_distinct_results
    invoice = Invoice.new
    invoice.custom_line_items << LineItem.new(:amount => 0)
    invoice.custom_line_items << LineItem.new(:amount => 0)
    invoice.save!

    assert_equal 1, invoice.custom_line_items.count
  end
67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93

  def test_should_count_results_with_multiple_fields
    invoice = Invoice.new
    invoice.custom_full_line_items << LineItem.new(:amount => 0)
    invoice.custom_full_line_items << LineItem.new(:amount => 0)
    invoice.save!

    assert_equal 2, invoice.custom_full_line_items.count
  end

  def test_should_count_results_with_star
    invoice = Invoice.new
    invoice.custom_star_line_items << LineItem.new(:amount => 0)
    invoice.custom_star_line_items << LineItem.new(:amount => 0)
    invoice.save!

    assert_equal 2, invoice.custom_star_line_items.count
  end

  def test_should_count_results_with_qualified_star
    invoice = Invoice.new
    invoice.custom_qualified_star_line_items << LineItem.new(:amount => 0)
    invoice.custom_qualified_star_line_items << LineItem.new(:amount => 0)
    invoice.save!

    assert_equal 2, invoice.custom_qualified_star_line_items.count
  end
94 95
end

96 97 98 99 100 101 102 103 104 105
class HasManyAssociationsTestForReorderWithJoinDependency < ActiveRecord::TestCase
  fixtures :authors, :posts, :comments

  def test_should_generate_valid_sql
    author = authors(:david)
    # this can fail on adapters which require ORDER BY expressions to be included in the SELECT expression
    # if the reorder clauses are not correctly handled
    assert author.posts_with_comments_sorted_by_comment_id.where('comments.id > 0').reorder('posts.comments_count DESC', 'posts.taggings_count DESC').last
  end
end
106

107 108 109

class HasManyAssociationsTest < ActiveRecord::TestCase
  fixtures :accounts, :categories, :companies, :developers, :projects,
110
           :developers_projects, :topics, :authors, :comments,
111
           :people, :posts, :readers, :taggings, :cars, :essays
112 113 114 115 116

  def setup
    Client.destroyed_client_ids.clear
  end

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133
  def test_create_from_association_should_respect_default_scope
    car = Car.create(:name => 'honda')
    assert_equal 'honda', car.name

    bulb = Bulb.create
    assert_equal 'defaulty', bulb.name

    bulb = car.bulbs.build
    assert_equal 'defaulty', bulb.name

    bulb = car.bulbs.create
    assert_equal 'defaulty', bulb.name

    bulb = car.bulbs.create(:name => 'exotic')
    assert_equal 'exotic', bulb.name
  end

134 135 136 137 138 139 140 141 142 143 144 145 146
  def test_create_from_association_with_nil_values_should_work
    car = Car.create(:name => 'honda')

    bulb = car.bulbs.new(nil)
    assert_equal 'defaulty', bulb.name

    bulb = car.bulbs.build(nil)
    assert_equal 'defaulty', bulb.name

    bulb = car.bulbs.create(nil)
    assert_equal 'defaulty', bulb.name
  end

147 148 149
  def test_building_the_associated_object_with_implicit_sti_base_class
    firm = DependentFirm.new
    company = firm.companies.build
150
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
151 152 153 154 155
  end

  def test_building_the_associated_object_with_explicit_sti_base_class
    firm = DependentFirm.new
    company = firm.companies.build(:type => "Company")
156
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
157 158 159 160 161
  end

  def test_building_the_associated_object_with_sti_subclass
    firm = DependentFirm.new
    company = firm.companies.build(:type => "Client")
162
    assert_kind_of Client, company, "Expected #{company.class} to be a Client"
163 164 165 166 167 168 169 170 171 172 173 174
  end

  def test_building_the_associated_object_with_an_invalid_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.companies.build(:type => "Invalid") }
  end

  def test_building_the_associated_object_with_an_unrelated_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.companies.build(:type => "Account") }
  end

175
  def test_association_keys_bypass_attribute_protection
176 177 178 179 180
    car = Car.create(:name => 'honda')

    bulb = car.bulbs.new
    assert_equal car.id, bulb.car_id

181 182 183
    bulb = car.bulbs.new :car_id => car.id + 1
    assert_equal car.id, bulb.car_id

184 185 186
    bulb = car.bulbs.build
    assert_equal car.id, bulb.car_id

187 188 189
    bulb = car.bulbs.build :car_id => car.id + 1
    assert_equal car.id, bulb.car_id

190 191
    bulb = car.bulbs.create
    assert_equal car.id, bulb.car_id
192 193 194

    bulb = car.bulbs.create :car_id => car.id + 1
    assert_equal car.id, bulb.car_id
195 196
  end

197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218
  def test_association_protect_foreign_key
    invoice = Invoice.create

    line_item = invoice.line_items.new
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.new :invoice_id => invoice.id + 1
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.build
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.build :invoice_id => invoice.id + 1
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.create
    assert_equal invoice.id, line_item.invoice_id

    line_item = invoice.line_items.create :invoice_id => invoice.id + 1
    assert_equal invoice.id, line_item.invoice_id
  end

219 220 221 222
  # When creating objects on the association, we must not do it within a scope (even though it
  # would be convenient), because this would cause that scope to be applied to any callbacks etc.
  def test_build_and_create_should_not_happen_within_scope
    car = cars(:honda)
223
    scoped_count = car.foo_bulbs.where_values.count
224

225 226
    bulb = car.foo_bulbs.build
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
227

228 229
    bulb = car.foo_bulbs.create
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
230

231 232
    bulb = car.foo_bulbs.create!
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
233 234
  end

235
  def test_no_sql_should_be_fired_if_association_already_loaded
A
Aaron Patterson 已提交
236
    Car.create(:name => 'honda')
237
    bulbs = Car.first.bulbs
B
Brian Cardarella 已提交
238
    bulbs.to_a # to load all instances of bulbs
239

240 241 242 243
    assert_no_queries do
      bulbs.first()
      bulbs.first({})
    end
244 245 246 247 248

    assert_no_queries do
      bulbs.last()
      bulbs.last({})
    end
249 250
  end

251 252 253
  def test_create_resets_cached_counters
    person = Person.create!(:first_name => 'tenderlove')
    post   = Post.first
254 255

    assert_equal [], person.readers
256
    assert_nil person.readers.find_by_post_id(post.id)
257

258
    person.readers.create(:post_id => post.id)
259 260 261 262 263 264 265

    assert_equal 1, person.readers.count
    assert_equal 1, person.readers.length
    assert_equal post, person.readers.first.post
    assert_equal person, person.readers.first.person
  end

266 267 268 269
  def force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.each {|f| }
  end

270
  # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
271
  def test_counting_with_counter_sql
272
    assert_equal 2, Firm.all.merge!(:order => "id").first.clients.count
273 274 275
  end

  def test_counting
276
    assert_equal 2, Firm.all.merge!(:order => "id").first.plain_clients.count
277 278 279
  end

  def test_counting_with_single_hash
280
    assert_equal 1, Firm.all.merge!(:order => "id").first.plain_clients.where(:name => "Microsoft").count
281 282 283
  end

  def test_counting_with_column_name_and_hash
284
    assert_equal 2, Firm.all.merge!(:order => "id").first.plain_clients.count(:name)
285 286
  end

287 288 289 290 291 292
  def test_counting_with_association_limit
    firm = companies(:first_firm)
    assert_equal firm.limited_clients.length, firm.limited_clients.size
    assert_equal firm.limited_clients.length, firm.limited_clients.count
  end

293
  def test_finding
294
    assert_equal 2, Firm.all.merge!(:order => "id").first.clients.length
295 296
  end

297 298 299 300
  def test_finding_array_compatibility
    assert_equal 2, Firm.order(:id).find{|f| f.id > 0}.clients.length
  end

301 302
  def test_find_many_with_merged_options
    assert_equal 1, companies(:first_firm).limited_clients.size
303 304
    assert_equal 1, companies(:first_firm).limited_clients.to_a.size
    assert_equal 2, companies(:first_firm).limited_clients.limit(nil).to_a.size
305 306
  end

307
  def test_find_should_prepend_to_association_order
308
    ordered_clients =  companies(:first_firm).clients_sorted_desc.order('companies.id')
309
    assert_equal ['companies.id', 'id DESC'], ordered_clients.order_values
310 311
  end

312
  def test_dynamic_find_should_respect_association_order
313
    assert_equal companies(:second_client), companies(:first_firm).clients_sorted_desc.where("type = 'Client'").first
314 315 316 317 318 319 320 321 322
    assert_equal companies(:second_client), companies(:first_firm).clients_sorted_desc.find_by_type('Client')
  end

  def test_cant_save_has_many_readonly_association
    authors(:david).readonly_comments.each { |c| assert_raise(ActiveRecord::ReadOnlyRecord) { c.save! } }
    authors(:david).readonly_comments.each { |c| assert c.readonly? }
  end

  def test_finding_default_orders
323
    assert_equal "Summit", Firm.all.merge!(:order => "id").first.clients.first.name
324 325 326
  end

  def test_finding_with_different_class_name_and_order
327
    assert_equal "Microsoft", Firm.all.merge!(:order => "id").first.clients_sorted_desc.first.name
328 329 330
  end

  def test_finding_with_foreign_key
331
    assert_equal "Microsoft", Firm.all.merge!(:order => "id").first.clients_of_firm.first.name
332 333 334
  end

  def test_finding_with_condition
335
    assert_equal "Microsoft", Firm.all.merge!(:order => "id").first.clients_like_ms.first.name
336 337 338
  end

  def test_finding_with_condition_hash
339
    assert_equal "Microsoft", Firm.all.merge!(:order => "id").first.clients_like_ms_with_hash_conditions.first.name
340 341
  end

342
  def test_finding_using_primary_key
343
    assert_equal "Summit", Firm.all.merge!(:order => "id").first.clients_using_primary_key.first.name
344 345
  end

346
  def test_finding_using_sql
347
    firm = Firm.order("id").first
348 349 350 351
    first_client = firm.clients_using_sql.first
    assert_not_nil first_client
    assert_equal "Microsoft", first_client.name
    assert_equal 1, firm.clients_using_sql.size
352
    assert_equal 1, Firm.order("id").first.clients_using_sql.size
353 354 355
  end

  def test_finding_using_sql_take_into_account_only_uniq_ids
356
    firm = Firm.order("id").first
357 358 359 360 361 362
    client = firm.clients_using_sql.first
    assert_equal client, firm.clients_using_sql.find(client.id, client.id)
    assert_equal client, firm.clients_using_sql.find(client.id, client.id.to_s)
  end

  def test_counting_using_sql
363 364 365 366
    assert_equal 1, Firm.order("id").first.clients_using_counter_sql.size
    assert Firm.order("id").first.clients_using_counter_sql.any?
    assert_equal 0, Firm.order("id").first.clients_using_zero_counter_sql.size
    assert !Firm.order("id").first.clients_using_zero_counter_sql.any?
367 368 369
  end

  def test_counting_non_existant_items_using_sql
370
    assert_equal 0, Firm.order("id").first.no_clients_using_counter_sql.size
371 372 373 374 375 376
  end

  def test_counting_using_finder_sql
    assert_equal 2, Firm.find(4).clients_using_sql.count
  end

377 378 379 380
  def test_belongs_to_sanity
    c = Client.new
    assert_nil c.firm

381
    flunk "belongs_to failed if check" if c.firm
382 383 384
  end

  def test_find_ids
385
    firm = Firm.all.merge!(:order => "id").first
386

387
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find }
388 389 390 391 392 393 394 395 396 397 398 399 400

    client = firm.clients.find(2)
    assert_kind_of Client, client

    client_ary = firm.clients.find([2])
    assert_kind_of Array, client_ary
    assert_equal client, client_ary.first

    client_ary = firm.clients.find(2, 3)
    assert_kind_of Array, client_ary
    assert_equal 2, client_ary.size
    assert_equal client, client_ary.first

401
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find(2, 99) }
402 403
  end

404
  def test_find_string_ids_when_using_finder_sql
405
    firm = Firm.order("id").first
406 407 408 409 410 411 412 413 414 415 416 417 418 419

    client = firm.clients_using_finder_sql.find("2")
    assert_kind_of Client, client

    client_ary = firm.clients_using_finder_sql.find(["2"])
    assert_kind_of Array, client_ary
    assert_equal client, client_ary.first

    client_ary = firm.clients_using_finder_sql.find("2", "3")
    assert_kind_of Array, client_ary
    assert_equal 2, client_ary.size
    assert client_ary.include?(client)
  end

420
  def test_find_all
421 422 423
    firm = Firm.all.merge!(:order => "id").first
    assert_equal 2, firm.clients.where("#{QUOTED_TYPE} = 'Client'").to_a.length
    assert_equal 1, firm.clients.where("name = 'Summit'").to_a.length
424 425
  end

426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
  def test_find_each
    firm = companies(:first_firm)

    assert ! firm.clients.loaded?

    assert_queries(3) do
      firm.clients.find_each(:batch_size => 1) {|c| assert_equal firm.id, c.firm_id }
    end

    assert ! firm.clients.loaded?
  end

  def test_find_each_with_conditions
    firm = companies(:first_firm)

    assert_queries(2) do
442
      firm.clients.where(name: 'Microsoft').find_each(batch_size: 1) do |c|
443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
        assert_equal firm.id, c.firm_id
        assert_equal "Microsoft", c.name
      end
    end

    assert ! firm.clients.loaded?
  end

  def test_find_in_batches
    firm = companies(:first_firm)

    assert ! firm.clients.loaded?

    assert_queries(2) do
      firm.clients.find_in_batches(:batch_size => 2) do |clients|
        clients.each {|c| assert_equal firm.id, c.firm_id }
      end
    end

    assert ! firm.clients.loaded?
  end

465
  def test_find_all_sanitized
466
    # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
467 468 469 470
    firm = Firm.all.merge!(:order => "id").first
    summit = firm.clients.where("name = 'Summit'").to_a
    assert_equal summit, firm.clients.where("name = ?", "Summit").to_a
    assert_equal summit, firm.clients.where("name = :name", { :name => "Summit" }).to_a
471 472 473
  end

  def test_find_first
474
    firm = Firm.all.merge!(:order => "id").first
475
    client2 = Client.find(2)
476 477
    assert_equal firm.clients.first, firm.clients.order("id").first
    assert_equal client2, firm.clients.where("#{QUOTED_TYPE} = 'Client'").order("id").first
478 479 480
  end

  def test_find_first_sanitized
481
    firm = Firm.all.merge!(:order => "id").first
482
    client2 = Client.find(2)
483 484
    assert_equal client2, firm.clients.merge!(:where => ["#{QUOTED_TYPE} = ?", 'Client'], :order => "id").first
    assert_equal client2, firm.clients.merge!(:where => ["#{QUOTED_TYPE} = :type", { :type => 'Client' }], :order => "id").first
485 486
  end

487 488
  def test_find_all_with_include_and_conditions
    assert_nothing_raised do
489
      Developer.all.merge!(:joins => :audit_logs, :where => {'audit_logs.message' => nil, :name => 'Smith'}).to_a
490 491 492
    end
  end

493 494
  def test_find_in_collection
    assert_equal Client.find(2).name, companies(:first_firm).clients.find(2).name
495
    assert_raise(ActiveRecord::RecordNotFound) { companies(:first_firm).clients.find(6) }
496 497 498
  end

  def test_find_grouped
499 500
    all_clients_of_firm1 = Client.all.merge!(:where => "firm_id = 1").to_a
    grouped_clients_of_firm1 = Client.all.merge!(:where => "firm_id = 1", :group => "firm_id", :select => 'firm_id, count(id) as clients_count').to_a
501 502 503 504
    assert_equal 2, all_clients_of_firm1.size
    assert_equal 1, grouped_clients_of_firm1.size
  end

505
  def test_find_scoped_grouped
506
    assert_equal 1, companies(:first_firm).clients_grouped_by_firm_id.size
507
    assert_equal 1, companies(:first_firm).clients_grouped_by_firm_id.length
508
    assert_equal 2, companies(:first_firm).clients_grouped_by_name.size
509 510 511
    assert_equal 2, companies(:first_firm).clients_grouped_by_name.length
  end

512 513 514 515 516
  def test_find_scoped_grouped_having
    assert_equal 1, authors(:david).popular_grouped_posts.length
    assert_equal 0, authors(:mary).popular_grouped_posts.length
  end

517
  def test_default_select
518
    assert_equal Comment.column_names.sort, posts(:welcome).comments.first.attributes.keys.sort
519 520 521 522 523 524
  end

  def test_select_query_method
    assert_equal ['id'], posts(:welcome).comments.select(:id).first.attributes.keys
  end

525 526 527 528 529 530 531 532 533 534 535 536
  def test_adding
    force_signal37_to_load_all_clients_of_firm
    natural = Client.new("name" => "Natural Company")
    companies(:first_firm).clients_of_firm << natural
    assert_equal 2, companies(:first_firm).clients_of_firm.size # checking via the collection
    assert_equal 2, companies(:first_firm).clients_of_firm(true).size # checking using the db
    assert_equal natural, companies(:first_firm).clients_of_firm.last
  end

  def test_adding_using_create
    first_firm = companies(:first_firm)
    assert_equal 2, first_firm.plain_clients.size
537
    first_firm.plain_clients.create(:name => "Natural Company")
538 539 540 541 542
    assert_equal 3, first_firm.plain_clients.length
    assert_equal 3, first_firm.plain_clients.size
  end

  def test_create_with_bang_on_has_many_when_parent_is_new_raises
543
    assert_raise(ActiveRecord::RecordNotSaved) do
544 545 546 547 548 549
      firm = Firm.new
      firm.plain_clients.create! :name=>"Whoever"
    end
  end

  def test_regular_create_on_has_many_when_parent_is_new_raises
550
    assert_raise(ActiveRecord::RecordNotSaved) do
551 552 553 554 555 556
      firm = Firm.new
      firm.plain_clients.create :name=>"Whoever"
    end
  end

  def test_create_with_bang_on_has_many_raises_when_record_not_saved
557
    assert_raise(ActiveRecord::RecordInvalid) do
558
      firm = Firm.all.merge!(:order => "id").first
559 560 561 562 563
      firm.plain_clients.create!
    end
  end

  def test_create_with_bang_on_habtm_when_parent_is_new_raises
564
    assert_raise(ActiveRecord::RecordNotSaved) do
565 566 567 568 569
      Developer.new("name" => "Aredridel").projects.create!
    end
  end

  def test_adding_a_mismatch_class
570 571 572
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << nil }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << 1 }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << Topic.find(1) }
573 574 575 576 577 578 579 580 581
  end

  def test_adding_a_collection
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.concat([Client.new("name" => "Natural Company"), Client.new("name" => "Apple")])
    assert_equal 3, companies(:first_firm).clients_of_firm.size
    assert_equal 3, companies(:first_firm).clients_of_firm(true).size
  end

582
  def test_transactions_when_adding_to_persisted
J
Jon Leighton 已提交
583 584 585 586 587 588 589 590 591
    good = Client.new(:name => "Good")
    bad  = Client.new(:name => "Bad", :raise_on_save => true)

    begin
      companies(:first_firm).clients_of_firm.concat(good, bad)
    rescue Client::RaisedOnSave
    end

    assert !companies(:first_firm).clients_of_firm(true).include?(good)
592 593 594
  end

  def test_transactions_when_adding_to_new_record
J
Jon Leighton 已提交
595 596 597 598
    assert_no_queries do
      firm = Firm.new
      firm.clients_of_firm.concat(Client.new("name" => "Natural Company"))
    end
599 600
  end

601 602 603 604 605 606 607 608 609 610
  def test_new_aliased_to_build
    company = companies(:first_firm)
    new_client = assert_no_queries { company.clients_of_firm.new("name" => "Another Client") }
    assert !company.clients_of_firm.loaded?

    assert_equal "Another Client", new_client.name
    assert !new_client.persisted?
    assert_equal new_client, company.clients_of_firm.last
  end

611 612 613 614
  def test_build
    company = companies(:first_firm)
    new_client = assert_no_queries { company.clients_of_firm.build("name" => "Another Client") }
    assert !company.clients_of_firm.loaded?
615

616
    assert_equal "Another Client", new_client.name
617
    assert !new_client.persisted?
618 619 620
    assert_equal new_client, company.clients_of_firm.last
  end

621 622 623 624 625 626 627
  def test_collection_size_after_building
    company = companies(:first_firm)  # company already has one client
    company.clients_of_firm.build("name" => "Another Client")
    company.clients_of_firm.build("name" => "Yet Another Client")
    assert_equal 3, company.clients_of_firm.size
  end

628 629 630 631 632 633 634
  def test_collection_not_empty_after_building
    company = companies(:first_firm)
    assert_predicate company.contracts, :empty?
    company.contracts.build
    assert_not_predicate company.contracts, :empty?
  end

635 636 637 638 639 640 641 642 643 644 645 646
  def test_collection_size_twice_for_regressions
    post = posts(:thinking)
    assert_equal 0, post.readers.size
    # This test needs a post that has no readers, we assert it to ensure it holds,
    # but need to reload the post because the very call to #size hides the bug.
    post.reload
    post.readers.build
    size1 = post.readers.size
    size2 = post.readers.size
    assert_equal size1, size2
  end

647 648 649 650 651 652 653
  def test_build_many
    company = companies(:first_firm)
    new_clients = assert_no_queries { company.clients_of_firm.build([{"name" => "Another Client"}, {"name" => "Another Client II"}]) }
    assert_equal 2, new_clients.size
  end

  def test_build_followed_by_save_does_not_load_target
654
    companies(:first_firm).clients_of_firm.build("name" => "Another Client")
655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672
    assert companies(:first_firm).save
    assert !companies(:first_firm).clients_of_firm.loaded?
  end

  def test_build_without_loading_association
    first_topic = topics(:first)
    Reply.column_names

    assert_equal 1, first_topic.replies.length

    assert_no_queries do
      first_topic.replies.build(:title => "Not saved", :content => "Superstars")
      assert_equal 2, first_topic.replies.size
    end

    assert_equal 2, first_topic.replies.to_ary.size
  end

673 674 675 676 677 678
  def test_build_via_block
    company = companies(:first_firm)
    new_client = assert_no_queries { company.clients_of_firm.build {|client| client.name = "Another Client" } }
    assert !company.clients_of_firm.loaded?

    assert_equal "Another Client", new_client.name
679
    assert !new_client.persisted?
680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695
    assert_equal new_client, company.clients_of_firm.last
  end

  def test_build_many_via_block
    company = companies(:first_firm)
    new_clients = assert_no_queries do
      company.clients_of_firm.build([{"name" => "Another Client"}, {"name" => "Another Client II"}]) do |client|
        client.name = "changed"
      end
    end

    assert_equal 2, new_clients.size
    assert_equal "changed", new_clients.first.name
    assert_equal "changed", new_clients.last.name
  end

696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713
  def test_create_without_loading_association
    first_firm  = companies(:first_firm)
    Firm.column_names
    Client.column_names

    assert_equal 1, first_firm.clients_of_firm.size
    first_firm.clients_of_firm.reset

    assert_queries(1) do
      first_firm.clients_of_firm.create(:name => "Superstars")
    end

    assert_equal 2, first_firm.clients_of_firm.size
  end

  def test_create
    force_signal37_to_load_all_clients_of_firm
    new_client = companies(:first_firm).clients_of_firm.create("name" => "Another Client")
714
    assert new_client.persisted?
715 716 717 718 719 720 721 722 723 724
    assert_equal new_client, companies(:first_firm).clients_of_firm.last
    assert_equal new_client, companies(:first_firm).clients_of_firm(true).last
  end

  def test_create_many
    companies(:first_firm).clients_of_firm.create([{"name" => "Another Client"}, {"name" => "Another Client II"}])
    assert_equal 3, companies(:first_firm).clients_of_firm(true).size
  end

  def test_create_followed_by_save_does_not_load_target
725
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744
    assert companies(:first_firm).save
    assert !companies(:first_firm).clients_of_firm.loaded?
  end

  def test_deleting
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.delete(companies(:first_firm).clients_of_firm.first)
    assert_equal 0, companies(:first_firm).clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

  def test_deleting_before_save
    new_firm = Firm.new("name" => "A New Firm, Inc.")
    new_client = new_firm.clients_of_firm.build("name" => "Another Client")
    assert_equal 1, new_firm.clients_of_firm.size
    new_firm.clients_of_firm.delete(new_client)
    assert_equal 0, new_firm.clients_of_firm.size
  end

745
  def test_deleting_updates_counter_cache
J
Jon Leighton 已提交
746
    topic = Topic.order("id ASC").first
747 748 749 750 751 752 753
    assert_equal topic.replies.to_a.size, topic.replies_count

    topic.replies.delete(topic.replies.first)
    topic.reload
    assert_equal topic.replies.to_a.size, topic.replies_count
  end

754
  def test_deleting_updates_counter_cache_without_dependent_option
755 756 757 758 759 760 761
    post = posts(:welcome)

    assert_difference "post.reload.taggings_count", -1 do
      post.taggings.delete(post.taggings.first)
    end
  end

762 763
  def test_deleting_updates_counter_cache_with_dependent_delete_all
    post = posts(:welcome)
764
    post.update_columns(taggings_with_delete_all_count: post.taggings_count)
765 766 767 768 769 770

    assert_difference "post.reload.taggings_with_delete_all_count", -1 do
      post.taggings_with_delete_all.delete(post.taggings_with_delete_all.first)
    end
  end

771 772
  def test_deleting_updates_counter_cache_with_dependent_destroy
    post = posts(:welcome)
773
    post.update_columns(taggings_with_destroy_count: post.taggings_count)
774 775 776 777 778 779

    assert_difference "post.reload.taggings_with_destroy_count", -1 do
      post.taggings_with_destroy.delete(post.taggings_with_destroy.first)
    end
  end

780 781 782 783 784 785 786 787
  def test_custom_named_counter_cache
    topic = topics(:first)

    assert_difference "topic.reload.replies_count", -1 do
      topic.approved_replies.clear
    end
  end

788 789 790 791 792 793 794 795 796 797 798 799
  def test_deleting_a_collection
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
    assert_equal 2, companies(:first_firm).clients_of_firm.size
    companies(:first_firm).clients_of_firm.delete([companies(:first_firm).clients_of_firm[0], companies(:first_firm).clients_of_firm[1]])
    assert_equal 0, companies(:first_firm).clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

  def test_delete_all
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
800 801 802 803
    clients = companies(:first_firm).clients_of_firm.to_a
    assert_equal 2, clients.count
    deleted = companies(:first_firm).clients_of_firm.delete_all
    assert_equal clients.sort_by(&:id), deleted.sort_by(&:id)
804 805 806 807 808 809 810 811 812 813 814 815 816 817
    assert_equal 0, companies(:first_firm).clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

  def test_delete_all_with_not_yet_loaded_association_collection
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
    assert_equal 2, companies(:first_firm).clients_of_firm.size
    companies(:first_firm).clients_of_firm.reset
    companies(:first_firm).clients_of_firm.delete_all
    assert_equal 0, companies(:first_firm).clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

818
  def test_transaction_when_deleting_persisted
J
Jon Leighton 已提交
819 820 821 822 823 824 825 826 827 828 829
    good = Client.new(:name => "Good")
    bad  = Client.new(:name => "Bad", :raise_on_destroy => true)

    companies(:first_firm).clients_of_firm = [good, bad]

    begin
      companies(:first_firm).clients_of_firm.destroy(good, bad)
    rescue Client::RaisedOnDestroy
    end

    assert_equal [good, bad], companies(:first_firm).clients_of_firm(true)
830 831 832
  end

  def test_transaction_when_deleting_new_record
J
Jon Leighton 已提交
833 834 835 836 837 838
    assert_no_queries do
      firm = Firm.new
      client = Client.new("name" => "New Client")
      firm.clients_of_firm << client
      firm.clients_of_firm.destroy(client)
    end
839 840
  end

841 842 843 844 845
  def test_clearing_an_association_collection
    firm = companies(:first_firm)
    client_id = firm.clients_of_firm.first.id
    assert_equal 1, firm.clients_of_firm.size

J
Jon Leighton 已提交
846
    firm.clients_of_firm.clear
847 848 849 850 851 852 853

    assert_equal 0, firm.clients_of_firm.size
    assert_equal 0, firm.clients_of_firm(true).size
    assert_equal [], Client.destroyed_client_ids[firm.id]

    # Should not be destroyed since the association is not dependent.
    assert_nothing_raised do
854
      assert_nil Client.find(client_id).firm
855 856 857
    end
  end

858 859 860
  def test_clearing_updates_counter_cache
    topic = Topic.first

861 862 863
    assert_difference 'topic.reload.replies_count', -1 do
      topic.replies.clear
    end
864 865
  end

866 867 868 869 870 871 872 873 874
  def test_clearing_updates_counter_cache_when_inverse_counter_cache_is_a_symbol_with_dependent_destroy
    car = Car.first
    car.engines.create!

    assert_difference 'car.reload.engines_count', -1 do
      car.engines.clear
    end
  end

875 876 877 878 879 880 881 882 883 884 885 886 887
  def test_clearing_a_dependent_association_collection
    firm = companies(:first_firm)
    client_id = firm.dependent_clients_of_firm.first.id
    assert_equal 1, firm.dependent_clients_of_firm.size

    # :dependent means destroy is called on each client
    firm.dependent_clients_of_firm.clear

    assert_equal 0, firm.dependent_clients_of_firm.size
    assert_equal 0, firm.dependent_clients_of_firm(true).size
    assert_equal [client_id], Client.destroyed_client_ids[firm.id]

    # Should be destroyed since the association is dependent.
888
    assert_nil Client.find_by_id(client_id)
889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907
  end

  def test_clearing_an_exclusively_dependent_association_collection
    firm = companies(:first_firm)
    client_id = firm.exclusively_dependent_clients_of_firm.first.id
    assert_equal 1, firm.exclusively_dependent_clients_of_firm.size

    assert_equal [], Client.destroyed_client_ids[firm.id]

    # :exclusively_dependent means each client is deleted directly from
    # the database without looping through them calling destroy.
    firm.exclusively_dependent_clients_of_firm.clear

    assert_equal 0, firm.exclusively_dependent_clients_of_firm.size
    assert_equal 0, firm.exclusively_dependent_clients_of_firm(true).size
    # no destroy-filters should have been called
    assert_equal [], Client.destroyed_client_ids[firm.id]

    # Should be destroyed since the association is exclusively dependent.
908
    assert_nil Client.find_by_id(client_id)
909 910 911 912 913 914 915
  end

  def test_dependent_association_respects_optional_conditions_on_delete
    firm = companies(:odegy)
    Client.create(:client_of => firm.id, :name => "BigShot Inc.")
    Client.create(:client_of => firm.id, :name => "SmallTime Inc.")
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
916
    assert_equal 2, Client.where(client_of: firm.id).size
917 918 919
    assert_equal 1, firm.dependent_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
920
    assert_equal 1, Client.where(client_of: firm.id).size
921 922 923 924 925 926 927
  end

  def test_dependent_association_respects_optional_sanitized_conditions_on_delete
    firm = companies(:odegy)
    Client.create(:client_of => firm.id, :name => "BigShot Inc.")
    Client.create(:client_of => firm.id, :name => "SmallTime Inc.")
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
928
    assert_equal 2, Client.where(client_of: firm.id).size
929 930 931
    assert_equal 1, firm.dependent_sanitized_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
932
    assert_equal 1, Client.where(client_of: firm.id).size
933 934
  end

935 936 937 938 939
  def test_dependent_association_respects_optional_hash_conditions_on_delete
    firm = companies(:odegy)
    Client.create(:client_of => firm.id, :name => "BigShot Inc.")
    Client.create(:client_of => firm.id, :name => "SmallTime Inc.")
    # only one of two clients is included in the association due to the :conditions key
J
Jon Leighton 已提交
940
    assert_equal 2, Client.where(client_of: firm.id).size
941 942 943
    assert_equal 1, firm.dependent_sanitized_conditional_clients_of_firm.size
    firm.destroy
    # only the correctly associated client should have been deleted
J
Jon Leighton 已提交
944
    assert_equal 1, Client.where(client_of: firm.id).size
945 946
  end

947
  def test_delete_all_association_with_primary_key_deletes_correct_records
948
    firm = Firm.first
949 950
    # break the vanilla firm_id foreign key
    assert_equal 2, firm.clients.count
951
    firm.clients.first.update_columns(firm_id: nil)
952 953 954
    assert_equal 1, firm.clients(true).count
    assert_equal 1, firm.clients_using_primary_key_with_delete_all.count
    old_record = firm.clients_using_primary_key_with_delete_all.first
955
    firm = Firm.first
956
    firm.destroy
957
    assert_nil Client.find_by_id(old_record.id)
958
  end
959

960 961
  def test_creation_respects_hash_condition
    ms_client = companies(:first_firm).clients_like_ms_with_hash_conditions.build
962

963 964
    assert        ms_client.save
    assert_equal  'Microsoft', ms_client.name
965

966 967
    another_ms_client = companies(:first_firm).clients_like_ms_with_hash_conditions.create

968
    assert        another_ms_client.persisted?
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989
    assert_equal  'Microsoft', another_ms_client.name
  end

  def test_clearing_without_initial_access
    firm = companies(:first_firm)

    firm.clients_of_firm.clear

    assert_equal 0, firm.clients_of_firm.size
    assert_equal 0, firm.clients_of_firm(true).size
  end

  def test_deleting_a_item_which_is_not_in_the_collection
    force_signal37_to_load_all_clients_of_firm
    summit = Client.find_by_name('Summit')
    companies(:first_firm).clients_of_firm.delete(summit)
    assert_equal 1, companies(:first_firm).clients_of_firm.size
    assert_equal 1, companies(:first_firm).clients_of_firm(true).size
    assert_equal 2, summit.client_of
  end

990
  def test_deleting_by_fixnum_id
991
    david = Developer.find(1)
992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007

    assert_difference 'david.projects.count', -1 do
      assert_equal 1, david.projects.delete(1).size
    end

    assert_equal 1, david.projects.size
  end

  def test_deleting_by_string_id
    david = Developer.find(1)

    assert_difference 'david.projects.count', -1 do
      assert_equal 1, david.projects.delete('1').size
    end

    assert_equal 1, david.projects.size
1008 1009 1010 1011 1012
  end

  def test_deleting_self_type_mismatch
    david = Developer.find(1)
    david.projects.reload
1013
    assert_raise(ActiveRecord::AssociationTypeMismatch) { david.projects.delete(Project.find(1).developers) }
1014 1015
  end

1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026
  def test_destroying
    force_signal37_to_load_all_clients_of_firm

    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first)
    end

    assert_equal 0, companies(:first_firm).reload.clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048
  def test_destroying_by_fixnum_id
    force_signal37_to_load_all_clients_of_firm

    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first.id)
    end

    assert_equal 0, companies(:first_firm).reload.clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

  def test_destroying_by_string_id
    force_signal37_to_load_all_clients_of_firm

    assert_difference "Client.count", -1 do
      companies(:first_firm).clients_of_firm.destroy(companies(:first_firm).clients_of_firm.first.id.to_s)
    end

    assert_equal 0, companies(:first_firm).reload.clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061
  def test_destroying_a_collection
    force_signal37_to_load_all_clients_of_firm
    companies(:first_firm).clients_of_firm.create("name" => "Another Client")
    assert_equal 2, companies(:first_firm).clients_of_firm.size

    assert_difference "Client.count", -2 do
      companies(:first_firm).clients_of_firm.destroy([companies(:first_firm).clients_of_firm[0], companies(:first_firm).clients_of_firm[1]])
    end

    assert_equal 0, companies(:first_firm).reload.clients_of_firm.size
    assert_equal 0, companies(:first_firm).clients_of_firm(true).size
  end

1062 1063
  def test_destroy_all
    force_signal37_to_load_all_clients_of_firm
1064 1065 1066 1067 1068
    clients = companies(:first_firm).clients_of_firm.to_a
    assert !clients.empty?, "37signals has clients after load"
    destroyed = companies(:first_firm).clients_of_firm.destroy_all
    assert_equal clients.sort_by(&:id), destroyed.sort_by(&:id)
    assert destroyed.all? { |client| client.frozen? }, "destroyed clients should be frozen"
1069 1070 1071 1072 1073 1074 1075 1076
    assert companies(:first_firm).clients_of_firm.empty?, "37signals has no clients after destroy all"
    assert companies(:first_firm).clients_of_firm(true).empty?, "37signals has no clients after destroy all and refresh"
  end

  def test_dependence
    firm = companies(:first_firm)
    assert_equal 2, firm.clients.size
    firm.destroy
1077
    assert Client.all.merge!(:where => "firm_id=#{firm.id}").to_a.empty?
1078 1079
  end

1080 1081 1082 1083 1084
  def test_dependence_for_associations_with_hash_condition
    david = authors(:david)
    assert_difference('Post.count', -1) { assert david.destroy }
  end

1085
  def test_destroy_dependent_when_deleted_from_association
1086
    # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
1087
    firm = Firm.all.merge!(:order => "id").first
1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100
    assert_equal 2, firm.clients.size

    client = firm.clients.first
    firm.clients.delete(client)

    assert_raise(ActiveRecord::RecordNotFound) { Client.find(client.id) }
    assert_raise(ActiveRecord::RecordNotFound) { firm.clients.find(client.id) }
    assert_equal 1, firm.clients.size
  end

  def test_three_levels_of_dependence
    topic = Topic.create "title" => "neat and simple"
    reply = topic.replies.create "title" => "neat and simple", "content" => "still digging it"
1101
    reply.replies.create "title" => "neat and simple", "content" => "ain't complaining"
1102 1103 1104 1105 1106 1107 1108 1109 1110

    assert_nothing_raised { topic.destroy }
  end

  uses_transaction :test_dependence_with_transaction_support_on_failure
  def test_dependence_with_transaction_support_on_failure
    firm = companies(:first_firm)
    clients = firm.clients
    assert_equal 2, clients.length
1111
    clients.last.instance_eval { def overwrite_to_raise() raise "Trigger rollback" end }
1112 1113 1114

    firm.destroy rescue "do nothing"

1115
    assert_equal 2, Client.all.merge!(:where => "firm_id=#{firm.id}").to_a.size
1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137
  end

  def test_dependence_on_account
    num_accounts = Account.count
    companies(:first_firm).destroy
    assert_equal num_accounts - 1, Account.count
  end

  def test_depends_and_nullify
    num_accounts = Account.count

    core = companies(:rails_core)
    assert_equal accounts(:rails_core_account), core.account
    assert_equal companies(:leetsoft, :jadedpixel), core.companies
    core.destroy
    assert_nil accounts(:rails_core_account).reload.firm_id
    assert_nil companies(:leetsoft).reload.client_of
    assert_nil companies(:jadedpixel).reload.client_of

    assert_equal num_accounts, Account.count
  end

1138
  def test_restrict
1139
    firm = RestrictedFirm.create!(:name => 'restrict')
1140
    firm.companies.create(:name => 'child')
1141

1142 1143
    assert !firm.companies.empty?
    assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
1144 1145 1146 1147
    assert RestrictedFirm.exists?(:name => 'restrict')
    assert firm.companies.exists?(:name => 'child')
  end

1148 1149 1150 1151
  def test_restrict_is_deprecated
    klass = Class.new(ActiveRecord::Base)
    assert_deprecated { klass.has_many :posts, dependent: :restrict }
  end
1152

1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164
  def test_restrict_with_exception
    firm = RestrictedWithExceptionFirm.create!(:name => 'restrict')
    firm.companies.create(:name => 'child')

    assert !firm.companies.empty?
    assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
    assert RestrictedWithExceptionFirm.exists?(:name => 'restrict')
    assert firm.companies.exists?(:name => 'child')
  end

  def test_restrict_with_error
    firm = RestrictedWithErrorFirm.create!(:name => 'restrict')
1165 1166 1167 1168 1169 1170 1171 1172
    firm.companies.create(:name => 'child')

    assert !firm.companies.empty?

    firm.destroy

    assert !firm.errors.empty?

1173
    assert_equal "Cannot delete record because dependent companies exist", firm.errors[:base].first
1174
    assert RestrictedWithErrorFirm.exists?(:name => 'restrict')
1175
    assert firm.companies.exists?(:name => 'child')
1176 1177
  end

1178 1179 1180 1181
  def test_included_in_collection
    assert companies(:first_firm).clients.include?(Client.find(2))
  end

1182 1183 1184 1185 1186 1187 1188
  def test_included_in_collection_for_new_records
    client = Client.create(:name => 'Persisted')
    assert_nil client.client_of
    assert !Firm.new.clients_of_firm.include?(client),
           'includes a client that does not belong to any firm'
  end

1189
  def test_adding_array_and_collection
J
Jon Leighton 已提交
1190
    assert_nothing_raised { Firm.first.clients + Firm.all.last.clients }
1191 1192 1193
  end

  def test_replace_with_less
1194
    firm = Firm.all.merge!(:order => "id").first
1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207
    firm.clients = [companies(:first_client)]
    assert firm.save, "Could not save firm"
    firm.reload
    assert_equal 1, firm.clients.length
  end

  def test_replace_with_less_and_dependent_nullify
    num_companies = Company.count
    companies(:rails_core).companies = []
    assert_equal num_companies, Company.count
  end

  def test_replace_with_new
1208
    firm = Firm.all.merge!(:order => "id").first
1209 1210 1211 1212 1213 1214 1215
    firm.clients = [companies(:second_client), Client.new("name" => "New Client")]
    firm.save
    firm.reload
    assert_equal 2, firm.clients.length
    assert !firm.clients.include?(:first_client)
  end

1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
  def test_replace_failure
    firm = companies(:first_firm)
    account = Account.new
    orig_accounts = firm.accounts.to_a

    assert !account.valid?
    assert !orig_accounts.empty?
    assert_raise ActiveRecord::RecordNotSaved do
      firm.accounts = [account]
    end
    assert_equal orig_accounts, firm.accounts
  end

1229
  def test_transactions_when_replacing_on_persisted
J
Jon Leighton 已提交
1230 1231
    good = Client.new(:name => "Good")
    bad  = Client.new(:name => "Bad", :raise_on_save => true)
1232

J
Jon Leighton 已提交
1233 1234 1235 1236 1237 1238 1239 1240
    companies(:first_firm).clients_of_firm = [good]

    begin
      companies(:first_firm).clients_of_firm = [bad]
    rescue Client::RaisedOnSave
    end

    assert_equal [good], companies(:first_firm).clients_of_firm(true)
1241 1242 1243
  end

  def test_transactions_when_replacing_on_new_record
J
Jon Leighton 已提交
1244 1245 1246 1247
    assert_no_queries do
      firm = Firm.new
      firm.clients_of_firm = [Client.new("name" => "New Client")]
    end
1248 1249
  end

1250 1251 1252 1253
  def test_get_ids
    assert_equal [companies(:first_client).id, companies(:second_client).id], companies(:first_firm).client_ids
  end

1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269
  def test_get_ids_for_loaded_associations
    company = companies(:first_firm)
    company.clients(true)
    assert_queries(0) do
      company.client_ids
      company.client_ids
    end
  end

  def test_get_ids_for_unloaded_associations_does_not_load_them
    company = companies(:first_firm)
    assert !company.clients.loaded?
    assert_equal [companies(:first_client).id, companies(:second_client).id], company.client_ids
    assert !company.clients.loaded?
  end

1270 1271 1272 1273
  def test_get_ids_ignores_include_option
    assert_equal [readers(:michael_welcome).id], posts(:welcome).readers_with_person_ids
  end

1274 1275 1276 1277 1278 1279 1280
  def test_get_ids_for_unloaded_finder_sql_associations_loads_them
    company = companies(:first_firm)
    assert !company.clients_using_sql.loaded?
    assert_equal [companies(:second_client).id], company.clients_using_sql_ids
    assert company.clients_using_sql.loaded?
  end

1281
  def test_get_ids_for_ordered_association
1282
    assert_equal [companies(:second_client).id, companies(:first_client).id], companies(:first_firm).clients_ordered_by_name_ids
1283 1284
  end

1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303
  def test_assign_ids_ignoring_blanks
    firm = Firm.create!(:name => 'Apple')
    firm.client_ids = [companies(:first_client).id, nil, companies(:second_client).id, '']
    firm.save!

    assert_equal 2, firm.clients(true).size
    assert firm.clients.include?(companies(:second_client))
  end

  def test_get_ids_for_through
    assert_equal [comments(:eager_other_comment1).id], authors(:mary).comment_ids
  end

  def test_modifying_a_through_a_has_many_should_raise
    [
      lambda { authors(:mary).comment_ids = [comments(:greetings).id, comments(:more_greetings).id] },
      lambda { authors(:mary).comments = [comments(:greetings), comments(:more_greetings)] },
      lambda { authors(:mary).comments << Comment.create!(:body => "Yay", :post_id => 424242) },
      lambda { authors(:mary).comments.delete(authors(:mary).comments.first) },
1304
    ].each {|block| assert_raise(ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection, &block) }
1305 1306 1307
  end

  def test_dynamic_find_should_respect_association_order_for_through
1308
    assert_equal Comment.find(10), authors(:david).comments_desc.where("comments.type = 'SpecialComment'").first
1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
    assert_equal Comment.find(10), authors(:david).comments_desc.find_by_type('SpecialComment')
  end

  def test_has_many_through_respects_hash_conditions
    assert_equal authors(:david).hello_posts, authors(:david).hello_posts_with_hash_conditions
    assert_equal authors(:david).hello_post_comments, authors(:david).hello_post_comments_with_hash_conditions
  end

  def test_include_uses_array_include_after_loaded
    firm = companies(:first_firm)
J
Jon Leighton 已提交
1319
    firm.clients.load_target
1320

1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340
    client = firm.clients.first

    assert_no_queries do
      assert firm.clients.loaded?
      assert firm.clients.include?(client)
    end
  end

  def test_include_checks_if_record_exists_if_target_not_loaded
    firm = companies(:first_firm)
    client = firm.clients.first

    firm.reload
    assert ! firm.clients.loaded?
    assert_queries(1) do
      assert firm.clients.include?(client)
    end
    assert ! firm.clients.loaded?
  end

1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351
  def test_include_loads_collection_if_target_uses_finder_sql
    firm = companies(:first_firm)
    client = firm.clients_using_sql.first

    firm.reload
    assert ! firm.clients_using_sql.loaded?
    assert firm.clients_using_sql.include?(client)
    assert firm.clients_using_sql.loaded?
  end


1352 1353 1354 1355 1356 1357 1358 1359
  def test_include_returns_false_for_non_matching_record_to_verify_scoping
    firm = companies(:first_firm)
    client = Client.create!(:name => 'Not Associated')

    assert ! firm.clients.loaded?
    assert ! firm.clients.include?(client)
  end

1360 1361 1362 1363 1364 1365 1366 1367 1368
  def test_calling_first_or_last_on_association_should_not_load_association
    firm = companies(:first_firm)
    firm.clients.first
    firm.clients.last
    assert !firm.clients.loaded?
  end

  def test_calling_first_or_last_on_loaded_association_should_not_fetch_with_query
    firm = companies(:first_firm)
J
Jon Leighton 已提交
1369
    firm.clients.load_target
1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392
    assert firm.clients.loaded?

    assert_no_queries do
      firm.clients.first
      assert_equal 2, firm.clients.first(2).size
      firm.clients.last
      assert_equal 2, firm.clients.last(2).size
    end
  end

  def test_calling_first_or_last_on_existing_record_with_build_should_load_association
    firm = companies(:first_firm)
    firm.clients.build(:name => 'Foo')
    assert !firm.clients.loaded?

    assert_queries 1 do
      firm.clients.first
      firm.clients.last
    end

    assert firm.clients.loaded?
  end

1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405
  def test_calling_first_or_last_on_existing_record_with_create_should_not_load_association
    firm = companies(:first_firm)
    firm.clients.create(:name => 'Foo')
    assert !firm.clients.loaded?

    assert_queries 2 do
      firm.clients.first
      firm.clients.last
    end

    assert !firm.clients.loaded?
  end

1406 1407 1408 1409 1410 1411 1412 1413
  def test_calling_first_or_last_on_new_record_should_not_run_queries
    firm = Firm.new

    assert_no_queries do
      firm.clients.first
      firm.clients.last
    end
  end
1414

1415 1416 1417
  def test_custom_primary_key_on_new_record_should_fetch_with_query
    author = Author.new(:name => "David")
    assert !author.essays.loaded?
1418 1419

    assert_queries 1 do
1420 1421
      assert_equal 1, author.essays.size
    end
1422

J
Jon Leighton 已提交
1423
    assert_equal author.essays, Essay.where(writer_id: "David")
1424
  end
1425

1426 1427
  def test_has_many_custom_primary_key
    david = authors(:david)
J
Jon Leighton 已提交
1428
    assert_equal david.essays, Essay.where(writer_id: "David")
1429
  end
1430

1431 1432 1433
  def test_blank_custom_primary_key_on_new_record_should_not_run_queries
    author = Author.new
    assert !author.essays.loaded?
1434 1435

    assert_queries 0 do
1436 1437 1438
      assert_equal 0, author.essays.size
    end
  end
1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450

  def test_calling_first_or_last_with_integer_on_association_should_load_association
    firm = companies(:first_firm)

    assert_queries 1 do
      firm.clients.first(2)
      firm.clients.last(2)
    end

    assert firm.clients.loaded?
  end

1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489
  def test_calling_many_should_count_instead_of_loading_association
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.many?  # use count query
    end
    assert !firm.clients.loaded?
  end

  def test_calling_many_on_loaded_association_should_not_use_query
    firm = companies(:first_firm)
    firm.clients.collect  # force load
    assert_no_queries { assert firm.clients.many? }
  end

  def test_calling_many_should_defer_to_collection_if_using_a_block
    firm = companies(:first_firm)
    assert_queries(1) do
      firm.clients.expects(:size).never
      firm.clients.many? { true }
    end
    assert firm.clients.loaded?
  end

  def test_calling_many_should_return_false_if_none_or_one
    firm = companies(:another_firm)
    assert !firm.clients_like_ms.many?
    assert_equal 0, firm.clients_like_ms.size

    firm = companies(:first_firm)
    assert !firm.limited_clients.many?
    assert_equal 1, firm.limited_clients.size
  end

  def test_calling_many_should_return_true_if_more_than_one
    firm = companies(:first_firm)
    assert firm.clients.many?
    assert_equal 2, firm.clients.size
  end

1490 1491 1492 1493 1494 1495 1496
  def test_joins_with_namespaced_model_should_use_correct_type
    old = ActiveRecord::Base.store_full_sti_class
    ActiveRecord::Base.store_full_sti_class = true

    firm = Namespaced::Firm.create({ :name => 'Some Company' })
    firm.clients.create({ :name => 'Some Client' })

1497
    stats = Namespaced::Firm.all.merge!(
1498
      :select => "#{Namespaced::Firm.table_name}.id, COUNT(#{Namespaced::Client.table_name}.id) AS num_clients",
1499 1500
      :joins  => :clients,
      :group  => "#{Namespaced::Firm.table_name}.id"
J
Jon Leighton 已提交
1501
    ).find firm.id
1502 1503 1504 1505 1506
    assert_equal 1, stats.num_clients.to_i
  ensure
    ActiveRecord::Base.store_full_sti_class = old
  end

1507 1508
  def test_association_proxy_transaction_method_starts_transaction_in_association_class
    Comment.expects(:transaction)
1509
    Post.first.comments.transaction do
1510
      # nothing
1511 1512 1513
    end
  end

1514
  def test_sending_new_to_association_proxy_should_have_same_effect_as_calling_new
1515 1516 1517 1518 1519 1520 1521 1522
    client_association = companies(:first_firm).clients
    assert_equal client_association.new.attributes, client_association.send(:new).attributes
  end

  def test_respond_to_private_class_methods
    client_association = companies(:first_firm).clients
    assert !client_association.respond_to?(:private_method)
    assert client_association.respond_to?(:private_method, true)
1523
  end
1524 1525

  def test_creating_using_primary_key
1526
    firm = Firm.all.merge!(:order => "id").first
1527 1528 1529
    client = firm.clients_using_primary_key.create!(:name => 'test')
    assert_equal firm.name, client.firm_name
  end
1530 1531 1532

  def test_defining_has_many_association_with_delete_all_dependency_lazily_evaluates_target_class
    ActiveRecord::Reflection::AssociationReflection.any_instance.expects(:class_name).never
1533
    class_eval(<<-EOF, __FILE__, __LINE__ + 1)
1534 1535 1536 1537 1538 1539 1540 1541
      class DeleteAllModel < ActiveRecord::Base
        has_many :nonentities, :dependent => :delete_all
      end
    EOF
  end

  def test_defining_has_many_association_with_nullify_dependency_lazily_evaluates_target_class
    ActiveRecord::Reflection::AssociationReflection.any_instance.expects(:class_name).never
1542
    class_eval(<<-EOF, __FILE__, __LINE__ + 1)
1543 1544 1545 1546 1547
      class NullifyModel < ActiveRecord::Base
        has_many :nonentities, :dependent => :nullify
      end
    EOF
  end
1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559

  def test_attributes_are_being_set_when_initialized_from_has_many_association_with_where_clause
    new_comment = posts(:welcome).comments.where(:body => "Some content").build
    assert_equal new_comment.body, "Some content"
  end

  def test_attributes_are_being_set_when_initialized_from_has_many_association_with_multiple_where_clauses
    new_comment = posts(:welcome).comments.where(:body => "Some content").where(:type => 'SpecialComment').build
    assert_equal new_comment.body, "Some content"
    assert_equal new_comment.type, "SpecialComment"
    assert_equal new_comment.post_id, posts(:welcome).id
  end
1560 1561 1562 1563 1564 1565

  def test_include_method_in_has_many_association_should_return_true_for_instance_added_with_build
    post = Post.new
    comment = post.comments.build
    assert post.comments.include?(comment)
  end
1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586

  def test_load_target_respects_protected_attributes
    topic = Topic.create!
    reply = topic.replies.create(:title => "reply 1")
    reply.approved = false
    reply.save!

    # Save with a different object instance, so the instance that's still held
    # in topic.relies doesn't know about the changed attribute.
    reply2 = Reply.find(reply.id)
    reply2.approved = true
    reply2.save!

    # Force loading the collection from the db. This will merge the existing
    # object (reply) with what gets loaded from the db (which includes the
    # changed approved attribute). approved is a protected attribute, so if mass
    # assignment is used, it won't get updated and will still be false.
    first = topic.replies.to_a.first
    assert_equal reply.id, first.id
    assert_equal true, first.approved?
  end
1587 1588 1589 1590 1591 1592 1593

  def test_to_a_should_dup_target
    ary    = topics(:first).replies.to_a
    target = topics(:first).replies.target

    assert_not_equal target.object_id, ary.object_id
  end
1594 1595 1596 1597 1598 1599 1600 1601 1602 1603

  def test_merging_with_custom_attribute_writer
    bulb = Bulb.new(:color => "red")
    assert_equal "RED!", bulb.color

    car = Car.create!
    car.bulbs << bulb

    assert_equal "RED!", car.bulbs.to_a.first.color
  end
1604

1605 1606 1607 1608 1609
  def test_abstract_class_with_polymorphic_has_many
    post = SubStiPost.create! :title => "fooo", :body => "baa"
    tagging = Tagging.create! :taggable => post
    assert_equal [tagging], post.taggings
  end
F
Farley Knight 已提交
1610

A
Andy Lindeman 已提交
1611
  def test_build_with_polymorphic_has_many_does_not_allow_to_override_type_and_id
1612 1613 1614 1615 1616 1617 1618
    welcome = posts(:welcome)
    tagging = welcome.taggings.build(:taggable_id => 99, :taggable_type => 'ShouldNotChange')

    assert_equal welcome.id, tagging.taggable_id
    assert_equal 'Post', tagging.taggable_type
  end

F
Farley Knight 已提交
1619 1620 1621 1622 1623 1624 1625
  def test_dont_call_save_callbacks_twice_on_has_many
    firm = companies(:first_firm)
    contract = firm.contracts.create!

    assert_equal 1, contract.hi_count
    assert_equal 1, contract.bye_count
  end
1626 1627 1628 1629 1630 1631 1632

  def test_association_attributes_are_available_to_after_initialize
    car = Car.create(:name => 'honda')
    bulb = car.bulbs.build

    assert_equal car.id, bulb.attributes_after_initialize['car_id']
  end
1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643

  def test_replace
    car = Car.create(:name => 'honda')
    bulb1 = car.bulbs.create
    bulb2 = Bulb.create

    assert_equal [bulb1], car.bulbs
    car.bulbs.replace([bulb2])
    assert_equal [bulb2], car.bulbs
    assert_equal [bulb2], car.reload.bulbs
  end
1644

1645
  def test_replace_returns_target
1646 1647 1648 1649 1650 1651
    car = Car.create(:name => 'honda')
    bulb1 = car.bulbs.create
    bulb2 = car.bulbs.create
    bulb3 = Bulb.create

    assert_equal [bulb1, bulb2], car.bulbs
1652
    result = car.bulbs.replace([bulb3, bulb1])
1653 1654 1655 1656
    assert_equal [bulb1, bulb3], car.bulbs
    assert_equal [bulb1, bulb3], result
  end

1657 1658 1659 1660
  def test_collection_association_with_private_kernel_method
    firm = companies(:first_firm)
    assert_equal [accounts(:signals37)], firm.accounts.open
  end
J
Jon Leighton 已提交
1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674

  test "first_or_initialize adds the record to the association" do
    firm = Firm.create! name: 'omg'
    client = firm.clients_of_firm.first_or_initialize
    assert_equal [client], firm.clients_of_firm
  end

  test "first_or_create adds the record to the association" do
    firm = Firm.create! name: 'omg'
    firm.clients_of_firm.load_target
    client = firm.clients_of_firm.first_or_create name: 'lol'
    assert_equal [client], firm.clients_of_firm
    assert_equal [client], firm.reload.clients_of_firm
  end
1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686

  test "delete_all, when not loaded, doesn't load the records" do
    post = posts(:welcome)

    assert post.taggings_with_delete_all.count > 0
    assert !post.taggings_with_delete_all.loaded?

    # 2 queries: one DELETE and another to update the counter cache
    assert_queries(2) do
      post.taggings_with_delete_all.delete_all
    end
  end
1687 1688 1689 1690 1691 1692 1693 1694 1695 1696

  test ":finder_sql is deprecated" do
    klass = Class.new(ActiveRecord::Base)
    assert_deprecated { klass.has_many :foo, :finder_sql => 'lol' }
  end

  test ":counter_sql is deprecated" do
    klass = Class.new(ActiveRecord::Base)
    assert_deprecated { klass.has_many :foo, :counter_sql => 'lol' }
  end
1697

1698 1699 1700 1701 1702 1703
  test "sum calculation with block for array compatibility is deprecated" do
    assert_deprecated do
      posts(:welcome).comments.sum { |c| c.id }
    end
  end

1704 1705 1706 1707 1708 1709
  test "has many associations on new records use null relations" do
    post = Post.new

    assert_no_queries do
      assert_equal [], post.comments
      assert_equal [], post.comments.where(body: 'omg')
1710
      assert_equal [], post.comments.pluck(:body)
1711
      assert_equal 0,  post.comments.sum(:id)
V
Vipul A M 已提交
1712
      assert_equal 0,  post.comments.count
1713 1714
    end
  end
1715 1716 1717 1718 1719

  test "collection proxy respects default scope" do
    author = authors(:mary)
    assert !author.first_posts.exists?
  end
1720
end