Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
053bfa23
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
053bfa23
编写于
11月 21, 2012
作者:
Y
Yves Senn
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
prevent mass assignment of polymorphic type when using `build`
Closes #8265
上级
293c121f
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
15 addition
and
1 deletion
+15
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+5
-0
activerecord/lib/active_record/associations/association.rb
activerecord/lib/active_record/associations/association.rb
+2
-1
activerecord/test/cases/associations/has_many_associations_test.rb
...ord/test/cases/associations/has_many_associations_test.rb
+8
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
053bfa23
## Rails 4.0.0 (unreleased) ##
*
Prevent mass assignment to the type column of polymorphic associations when using
`build`
Fix #8265
*Yves Senn*
*
Fix postgresql adapter to handle BC timestamps correctly
HistoryEvent.create!(:name => "something", :occured_at => Date.new(0) - 5.years)
...
...
activerecord/lib/active_record/associations/association.rb
浏览文件 @
053bfa23
...
...
@@ -232,7 +232,8 @@ def stale_state
def
build_record
(
attributes
)
reflection
.
build_association
(
attributes
)
do
|
record
|
attributes
=
create_scope
.
except
(
*
(
record
.
changed
-
[
reflection
.
foreign_key
]))
skip_assign
=
[
reflection
.
foreign_key
,
reflection
.
type
].
compact
attributes
=
create_scope
.
except
(
*
(
record
.
changed
-
skip_assign
))
record
.
assign_attributes
(
attributes
)
end
end
...
...
activerecord/test/cases/associations/has_many_associations_test.rb
浏览文件 @
053bfa23
...
...
@@ -1579,6 +1579,14 @@ def test_abstract_class_with_polymorphic_has_many
assert_equal
[
tagging
],
post
.
taggings
end
def
test_build_with_polymotphic_has_many_does_not_allow_to_override_type_and_id
welcome
=
posts
(
:welcome
)
tagging
=
welcome
.
taggings
.
build
(
:taggable_id
=>
99
,
:taggable_type
=>
'ShouldNotChange'
)
assert_equal
welcome
.
id
,
tagging
.
taggable_id
assert_equal
'Post'
,
tagging
.
taggable_type
end
def
test_dont_call_save_callbacks_twice_on_has_many
firm
=
companies
(
:first_firm
)
contract
=
firm
.
contracts
.
create!
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录