* In new_from_dumpxml(), the used keyword argument 'options'
  doesn't exist in virsh.dumpxml(). This must be a typo
  s/options/extra.

* Fix a raise typo and some pylint/pep8 issues.

* The original xml of the vm need to be backed up before test
  and restored after it to keep the xml unchanged.

* When backing up, the xml need to be dumped using '--inactive'
  option. Otherwise the xml backup is slightly different from
  the original one like below. I'm not sure this will cause
  any problem, but it's annoying.

---
+++
@@ -4,6 +4,9 @@
   <memory unit='KiB'>1048576</memory>
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>2</vcpu>
+  <resource>
+    <partition>/machine</partition>
+  </resource>
   <os>
     <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type>
     <boot dev='hd'/>
@@ -43,7 +46,9 @@
     </console>
     <input type='tablet' bus='usb'/>
     <input type='mouse' bus='ps2'/>
-    <graphics type='vnc' port='-1' autoport='yes'/>
+    <graphics type='vnc' port='-1' autoport='yes'
listen='127.0.0.1'>
+      <listen type='address' address='127.0.0.1'/>
+    </graphics>
     <video>
       <model type='cirrus' vram='9216' heads='1'/>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
@@ -52,4 +57,5 @@
       <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
     </memballoon>
   </devices>
+  <seclabel type='dynamic' model='selinux' relabel='yes'/>
 </domain>
Signed-off-by: NHao Liu <hliu@redhat.com>

qemu.tests: new case to check guest clock offset

Add lvm support for qemu tests

virttest.qemu_vm: Log information about the parent PID and the monitor n...

When starting the qemu process, there is not much information about
the running parent PID (the autotest shell script that starts qemu) or
the monitor name that we are trying to connect (for example, hmp1).

So with this commit we're logging this information when qemu is started,
in order to provide information for debugging. Example:

When running  ./run -t qemu --tests=uptime --qemu_sandbox=on

From debug.log:

11:43:17 INFO | Created qemu process with parent PID 15592
11:43:17 INFO | Connecting to monitor 'hmp1'
11:44:17 WARNI| Could not find (qemu) prompt after connecting to monitor. Output so far: ''
11:44:18 ERROR| Could not connect to monitor 'hmp1'
11:44:18 DEBUG| Destroying VM virt-tests-vm1 (PID 15594)

Parent PID is 15592, now we are trying to find what is wrong...

ps -ef | grep 15592
rmoura   15592 15591  0 11:43 pts/3    00:00:00 /bin/bash -c source /tmp/autotestbMRLRL.sh
rmoura   15594 15592  0 11:43 pts/3    00:00:00 [qemu-system-x86] <defunct>

In this situation, it's clear that qemu-system-x86_64 goes bad.
Signed-off-by: NRuda Moura <rmoura@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

register lvm object to env file when use lvm storage, and restore it at
postprocess to clean up new volumes when "force_remove_image = yes";

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

check guest clock drift less that $acceptable_offset after online/offline
hotpluged vcpus;
Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

In fact, previous fixes that make nfs to use the
staging library needed some tweaking to match
expectations.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Make the nfs module use the service API previous to the
change made on 69ac938d.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Turns out that change was made with little thought
with regards to the users of the code that already
existed.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

virttest.qemu_devices: Make IDE bus strict_mode only

virsh_snapshot_create_as: Properly format output_dump

When using IDE bus, only ide.1 bus is used by default. We have to
force the ide.0 in order to use it (similar to AHCI). This patch
makes all QBusUnitBuses act this way.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Recent changes to dumpxml missed the snapshot_dumpxml reference
when changing the returned data as a CmdResult.  Format the output_dump
with the .stdout.strip()

virt-libguestfs: Fix bugs in virt_sysprep test

virt: propcan clean some old style construction V2

workaround for ovs

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

It is possible to call 'virsh setmem --domain test 524288' but the current
code create 'virsh setmem 524288 --domain test' for the right parameters.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>

The domain name and memory size have to be defined to PASS the test
on newer libvirt.

There are some tests that have different result on older libvirt and
newer libvirt. The right condition is that the new libvirt should not
fail, but the older one should fail. By this patch we follow this
behaviour.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>

We should restore memory into original size by using the original_outside_mem
instead of original_inside_mem because the inside mem is lower than the outside
mem and because of the virsh setmem command is setting the outside mem.
Signed-off-by: NPavel Hrdina <phrdina@redhat.com>

Signed-off-by: NDongsheng Yang <yangds.fnst@cn.fujitsu.com>

Nettype user default fixes

Signed-off-by: NChris Evich <cevich@redhat.com>

This change mirrors the default as used by the test runner.  I
added/rearranged the comments to make it clear it will be overridden.
Signed-off-by: NChris Evich <cevich@redhat.com>

Sample output:

15:37:08 INFO | Starting test ...
15:37:08 DEBUG| Test parameters:
                     ...
15:39:52 WARNI|
15:39:52 WARNI| Testing with nettype='user' while running as root may
                produce unexpected results!!!
15:39:52 WARNI|
Signed-off-by: NChris Evich <cevich@redhat.com>

When test runner is executed as root, default to using bridge-mode
networking.  Otherwise, force it to user-mode, unless different
on the command line.
Signed-off-by: NChris Evich <cevich@redhat.com>