Client can suggest IP address which he wants to have.
Autotest check if IP address is accessible, thanks to
it there is no problem with changing of guest network.
Additionally it helps with windows DHCP compatibility.
Signed-off-by: NJiří Župka <jzupka@redhat.com>

* max_disk must not have any usbs, otherwise there are not enough
  slots in PCI
* default image_boot = yes which generates in multi_disk test
  multiple disks with index = 1 and test failure. By forcing default
  value stg_image_boot = 'no' we can keep the default value (and index
  of image1) and let the other disk to have their own indexes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When we set disable_kvm to 'yes', we obviously don't want
-enable-kvm set regardless of the value of enable_kvm.

So let's fix that. Now you can just set

disable_kvm = yes

And everything else will be taken care of.

CC: Eduardo Habkost <ehabkost@redhat.com>
CC: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The implementation of the devices needed for KVM unit
testing changed a bit on qemu:

1) There's no need for a testlog anymore (as kvm-unit-tests
   now writes to the standard serial port)
2) Now there's a shared new device, called isa-debug-exit,
   that when written to, causes qemu to exit
3) Due to the new behavior of the isa-debug-exit device,
   the new known good behavior for qemu at the end of the
   unit test is to return 1.

Take that all into account, while still keeping backwards
compatibility. Also, document how one can run the unittests
with the new virt-tests runner both in the config file
and the wiki.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

For qemu upstream, in order to run the kvm-unit-tests suite,
there are new test devices, that differ in syntax from the
ones present in qemu-kvm:

* pc-testdev
* isa-debug-exit

Add them both to the qemu VM class, and make things
backwards compatible (ie, if an older qemu-kvm is being
tested, it'll handle the correct syntaxes as well).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When we introduced qemu CPU model configuration, we opted
for robustness, so we wouldn't add a cpu_model to the
command line in case it was not showing on qemu -cpu help
text. This is bad because:

1) It was all done very silently
2) This makes negative cpu model testing unfeasible

So let's honor the setting, and print a error message,
so people have a better idea of what's going on. In
such cases, the bad param will be passed to qemu, it
will fail and a VMCreateError will be thrown.

CC: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

This is a solution for issue #184.

Create the utility function _restore_stdout, so we
don't need to resort to standalone_utils.print_stdout
on error paths, changing all error paths to use it.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Based on experience and advice we are increasing the default
timeouts. We have seen non intended failures with the timeouts
as they are. Increasing them makes legit tests (migration ones
in our experience) not fail anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Do a better job at logging which VM is being killed,
and which method to kill it was used. Other parts of
the VM classes need cleanup, but let's start with this
method.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The option is not necessary anymore, as we have code specific for
-no-shutdown in the graceful-shutdown code path.

Other code that needs to wait until VM is paused outside
graceful_shutdown() may simply call wait_for_shutdown() or
wait_until_paused() directly.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This should help us in the main use case of the kill_vm_only_when_paused
code: to make the shutdown code wait until the VM is paused instead of
waiting until the VM is killed, when -no-shutdown is used.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

The code is trivial by now, but it will be extended once we start using
-no-shutdown.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This will help isolate the destroy() code that uses the shutdown command
from the rest of the VM-killing code.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Makes the code that waits until VM is dead simpler.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Just a helper for code that needs to wait until the VM is paused.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

A helper to wait until VM status changed to specific value.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

There's no need to wait 1 second before the first check for
status=paused, just used the default values for th wait_for() 'first'
and 'step' parameters.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Signed-off-by: NChris Evich <cevich@redhat.com>

Assign the host load cmd to a variable, so we can get
its PID without resorting to using a index list -1 to
retrieve it later. This avoids a IndexError on Windows
guests.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

Create a method that inspects the cartesian file for all
extra filters that the test runner add, and display the
same information for both the output of --list-tests and
the debug log. For example:

"""
Tests produced by config file /path/to/tests.cfg

The full test list was modified by the following:

Filters applied:
    only JeOS.17.64
    only smp2
    only qcow2
    only virtio_net
    only virtio_blk

Different guest OS have different test lists

Assignments applied:
    mem = 512
    qemu_binary = /bin/qemu-kvm
    qemu_img_binary = /bin/qemu-img
    qemu_io_binary = /bin/qemu-io
    nettype = user

Assignments override values previously set in the config file

1 balloon_check.base
...
"""

Hopefully that provides enough context information so
people get less confused on what the test runner is doing.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

So we can improve the information displayed to users
with regards to how the test list is generated.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

We have cartesian config files, and the test runner
modifies them according to the options passed in the
command line. It's hard to figure out what is config
file and what was programatically added by the parser,
so introduce new utility methods that can be used to
display exactly which is which.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This new feature of F18 completely kills a lot of the
tests that copy tmp files to there. Let's disable it in
our kickstart.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: Nyangdongsheng <yangds.fnst@fujitsu.cn>

Signed-off-by: Nyangdongsheng <yangds.fnst@fujitsu.cn>

Signed-off-by: Nyangdongsheng <yangds.fnst@fujitsu.cn>

Here mostly for convenience (you want to install F18 to
run some tests in it). Eventually we will enable the
ability to perform network installs of the mentioned
Fedora, but this still will take some time.

With this, you can execute:

tools/download_manager.py

And select the Fedora 18 ISO to be downloaded.

CC: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

/tmp used to be a safe bet, but now with some systems using a tmpfs based /tmp,
it looks like /var/tmp is a better choice.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is a solution for issue #178.

Display options values when displaying the list of
tests. That will explain the filters applied in the
config set generated by the config file.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This is a solution for issue #176.

If you did type a test name that is not available for
the guest type you want the test to run, explain
carefully to the user that he/she needs to double
check the input, explaining some common mistakes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This is a solution for issue #175.

With the recent switch kvm-> qemu, it's natural that
people mistake those for a while. We haven't been handling
that case well. So let's establish valid test types and,
if the user chooses an invalid one, give him/her an
understandable error message.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>