this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: NEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: NAdrian Bunk <bunk@stusta.de>

kconfig sanitized around drivers/net
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: NJeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

Instead of the DEV_OK macro, drivers should use pcmcia_dev_present().
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Instead of the two status values struct pcmcia_device->p_state and state,
use descriptive bitfields. Most value-checking in drivers was invalid, as
the core now only calls the ->remove() (a.k.a. detach) function in case the
attachement _and_ configuration was successful.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Remove the unused DEV_RELEASE_PENDING flag, and move the DEV_SUSPEND flag
into the p_dev structure, and make use of it at the core level.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Most of the driver initialization isn't done in the .probe function, but in
the internal _config() functions. Make them return a value, so that .probe
can properly report whether the probing of the device succeeded or not.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

dev_link_t * and client_handle_t both mean struct pcmcai_device * by now.
Therefore, remove all such indirections.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Embed dev_link_t into struct pcmcia_device(), as they basically address the
same entity. The actual contents of dev_link_t will be cleaned up step by step.
This patch includes a bugfix from and signed-off-by Andrew Morton.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

As we do not allow setting Vcc in the pcmcia core, and Vpp1 and
Vpp2 can only be set to the same value, a lot of code can be
streamlined.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

In all but one case, the suspend and resume functions of PCMCIA drivers
contain mostly of calls to pcmcia_release_configuration() and
pcmcia_request_configuration(). Therefore, move this code out of the
drivers and into the core.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Convert the remaining drivers which use pcmcia_release_io or
pcmcia_release_irq, and remove the EXPORT of these symbols.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

pcmcia_disable_device(struct pcmcia_device *p_dev) performs the necessary
cleanups upon device or driver removal: it calls the appropriate
pcmcia_release_* functions, and can replace (most) of the current drivers'
_release() functions.
Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>

Fix a lot of typos.  Eyeballed by jmc@ in OpenBSD.
Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

Replace all occurences of 0xff..  in calls to function pci_set_dma_mask()
and pci_set_consistant_dma_mask() with the corresponding DMA_xBIT_MASK from
linux/dma-mapping.h.
Signed-off-by: NMatthias Gehre <M.Gehre@gmx.de>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

Fixed encrypted of EAPOL frames from wlan#ap interface (hostapd). This
was broken when moving to use new frame control field defines in
net/ieee80211.h. hostapd uses Protected flag, not protocol version
(which was cleared in this function anyway). This fixes WPA group key
handshake and re-authentication.
http://hostap.epitest.fi/bugz/show_bug.cgi?id=126Signed-off-by: NJouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

hostap_tx_encrypt() is used only inside hostap_80211_tx.c and there
are no plans to use it elsewhere in the future either, so let's make
it static. As a bonus, this should silence Coverity scanner from
complaining about bogus FORWARD_NULL case (CID: 274).
Signed-off-by: NJouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

PCMCIA_SPECTRUM must select FW_LOADER.

Reported by "Alexander E. Patrakov" <patrakov@ums.usu.ru>.
Signed-off-by: NAdrian Bunk <bunk@stusta.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Initial patch by David Woodhouse and Michael Marineau.
Locking fix by me.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

patch by doctorzoidberg.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

This also includes a rewritten valuesave-stack.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

This should not make a difference, but be careful to not trash the register.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

as it causes more trouble than it solves
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

This bug was caused by the packing of the bcm43xx_dma and bcm43xx_pio
structures into a union.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

This may workaround the XMIT ERRORs some people are getting.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>