intel_dvo.c 15.8 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */
#include <linux/i2c.h>
28
#include <linux/slab.h>
29
#include <drm/drmP.h>
30
#include <drm/drm_atomic_helper.h>
31
#include <drm/drm_crtc.h>
J
Jesse Barnes 已提交
32
#include "intel_drv.h"
33
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
34 35 36 37 38 39
#include "i915_drv.h"
#include "dvo.h"

#define SIL164_ADDR	0x38
#define CH7xxx_ADDR	0x76
#define TFP410_ADDR	0x38
40
#define NS2501_ADDR     0x38
J
Jesse Barnes 已提交
41

C
Chris Wilson 已提交
42
static const struct intel_dvo_device intel_dvo_devices[] = {
J
Jesse Barnes 已提交
43 44 45 46 47 48 49 50 51 52 53 54 55 56
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "sil164",
		.dvo_reg = DVOC,
		.slave_addr = SIL164_ADDR,
		.dev_ops = &sil164_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = CH7xxx_ADDR,
		.dev_ops = &ch7xxx_ops,
	},
57 58 59 60 61 62 63
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = 0x75, /* For some ch7010 */
		.dev_ops = &ch7xxx_ops,
	},
J
Jesse Barnes 已提交
64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ivch",
		.dvo_reg = DVOA,
		.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
		.dev_ops = &ivch_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "tfp410",
		.dvo_reg = DVOC,
		.slave_addr = TFP410_ADDR,
		.dev_ops = &tfp410_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ch7017",
		.dvo_reg = DVOC,
		.slave_addr = 0x75,
83
		.gpio = GMBUS_PIN_DPB,
J
Jesse Barnes 已提交
84
		.dev_ops = &ch7017_ops,
85 86 87 88
	},
	{
	        .type = INTEL_DVO_CHIP_TMDS,
		.name = "ns2501",
V
Ville Syrjälä 已提交
89
		.dvo_reg = DVOB,
90 91 92
		.slave_addr = NS2501_ADDR,
		.dev_ops = &ns2501_ops,
       }
J
Jesse Barnes 已提交
93 94
};

C
Chris Wilson 已提交
95 96 97 98 99
struct intel_dvo {
	struct intel_encoder base;

	struct intel_dvo_device dev;

100 101
	struct intel_connector *attached_connector;

C
Chris Wilson 已提交
102 103 104
	bool panel_wants_dither;
};

105
static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
C
Chris Wilson 已提交
106
{
107
	return container_of(encoder, struct intel_dvo, base);
C
Chris Wilson 已提交
108 109
}

110 111
static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
{
112
	return enc_to_dvo(intel_attached_encoder(connector));
113 114
}

115
static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
J
Jesse Barnes 已提交
116
{
117 118
	struct drm_device *dev = connector->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
119
	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
120 121 122 123 124 125
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;
126 127 128 129 130 131 132 133 134

	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
}

static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
135
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
136 137 138 139 140 141 142 143 144 145 146 147
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	*pipe = PORT_TO_PIPE(tmp);

	return true;
}

148
static void intel_dvo_get_config(struct intel_encoder *encoder,
149
				 struct intel_crtc_state *pipe_config)
150 151
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
152
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
153 154 155 156 157 158 159 160 161 162 163 164
	u32 tmp, flags = 0;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

165
	pipe_config->base.adjusted_mode.flags |= flags;
166

167
	pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
168 169
}

170 171 172
static void intel_disable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
173
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
174 175 176 177 178 179 180 181 182 183 184
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	I915_READ(dvo_reg);
}

static void intel_enable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
185
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
186
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
C
Chris Wilson 已提交
187
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
J
Jesse Barnes 已提交
188 189
	u32 temp = I915_READ(dvo_reg);

190
	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
191 192
					 &crtc->config->base.mode,
					 &crtc->config->base.adjusted_mode);
193

194 195 196
	I915_WRITE(dvo_reg, temp | DVO_ENABLE);
	I915_READ(dvo_reg);

197 198 199
	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
}

200 201 202
static enum drm_mode_status
intel_dvo_mode_valid(struct drm_connector *connector,
		     struct drm_display_mode *mode)
J
Jesse Barnes 已提交
203
{
204
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
205 206
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;
M
Mika Kahola 已提交
207 208
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
	int target_clock = mode->clock;
J
Jesse Barnes 已提交
209 210 211 212 213 214

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	/* XXX: Validate clock range */

215 216
	if (fixed_mode) {
		if (mode->hdisplay > fixed_mode->hdisplay)
J
Jesse Barnes 已提交
217
			return MODE_PANEL;
218
		if (mode->vdisplay > fixed_mode->vdisplay)
J
Jesse Barnes 已提交
219
			return MODE_PANEL;
M
Mika Kahola 已提交
220

221
		target_clock = fixed_mode->clock;
J
Jesse Barnes 已提交
222 223
	}

M
Mika Kahola 已提交
224 225 226
	if (target_clock > max_dotclk)
		return MODE_CLOCK_HIGH;

C
Chris Wilson 已提交
227
	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
J
Jesse Barnes 已提交
228 229
}

230
static bool intel_dvo_compute_config(struct intel_encoder *encoder,
231
				     struct intel_crtc_state *pipe_config)
J
Jesse Barnes 已提交
232
{
233
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
234 235
	const struct drm_display_mode *fixed_mode =
		intel_dvo->attached_connector->panel.fixed_mode;
236
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
J
Jesse Barnes 已提交
237 238 239 240 241 242

	/* If we have timings from the BIOS for the panel, put them in
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
243 244
	if (fixed_mode)
		intel_fixed_panel_mode(fixed_mode, adjusted_mode);
J
Jesse Barnes 已提交
245 246 247 248

	return true;
}

249
static void intel_dvo_pre_enable(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
250
{
251
	struct drm_device *dev = encoder->base.dev;
J
Jesse Barnes 已提交
252
	struct drm_i915_private *dev_priv = dev->dev_private;
253
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
254
	struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
255 256
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	int pipe = crtc->pipe;
J
Jesse Barnes 已提交
257
	u32 dvo_val;
C
Chris Wilson 已提交
258
	u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
J
Jesse Barnes 已提交
259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287

	switch (dvo_reg) {
	case DVOA:
	default:
		dvo_srcdim_reg = DVOA_SRCDIM;
		break;
	case DVOB:
		dvo_srcdim_reg = DVOB_SRCDIM;
		break;
	case DVOC:
		dvo_srcdim_reg = DVOC_SRCDIM;
		break;
	}

	/* Save the data order, since I don't know what it should be set to. */
	dvo_val = I915_READ(dvo_reg) &
		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
	dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
		   DVO_BLANK_ACTIVE_HIGH;

	if (pipe == 1)
		dvo_val |= DVO_PIPE_B_SELECT;
	dvo_val |= DVO_PIPE_STALL;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		dvo_val |= DVO_VSYNC_ACTIVE_HIGH;

	/*I915_WRITE(DVOB_SRCDIM,
288 289
	  (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
	  (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
J
Jesse Barnes 已提交
290
	I915_WRITE(dvo_srcdim_reg,
291 292
		   (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
		   (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
J
Jesse Barnes 已提交
293 294 295 296 297 298 299 300 301
	/*I915_WRITE(DVOB, dvo_val);*/
	I915_WRITE(dvo_reg, dvo_val);
}

/**
 * Detect the output connection on our DVO device.
 *
 * Unimplemented.
 */
302
static enum drm_connector_status
303
intel_dvo_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
304
{
305
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
306
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
307
		      connector->base.id, connector->name);
C
Chris Wilson 已提交
308
	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
J
Jesse Barnes 已提交
309 310 311 312
}

static int intel_dvo_get_modes(struct drm_connector *connector)
{
313
	struct drm_i915_private *dev_priv = connector->dev->dev_private;
314 315
	const struct drm_display_mode *fixed_mode =
		to_intel_connector(connector)->panel.fixed_mode;
J
Jesse Barnes 已提交
316 317 318 319 320 321

	/* We should probably have an i2c driver get_modes function for those
	 * devices which will have a fixed set of modes determined by the chip
	 * (TV-out, for example), but for now with just TMDS and LVDS,
	 * that's not the case.
	 */
322
	intel_ddc_get_modes(connector,
323
			    intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
J
Jesse Barnes 已提交
324 325 326
	if (!list_empty(&connector->probed_modes))
		return 1;

327
	if (fixed_mode) {
J
Jesse Barnes 已提交
328
		struct drm_display_mode *mode;
329
		mode = drm_mode_duplicate(connector->dev, fixed_mode);
J
Jesse Barnes 已提交
330 331 332 333 334
		if (mode) {
			drm_mode_probed_add(connector, mode);
			return 1;
		}
	}
C
Chris Wilson 已提交
335

J
Jesse Barnes 已提交
336 337 338
	return 0;
}

C
Chris Wilson 已提交
339
static void intel_dvo_destroy(struct drm_connector *connector)
J
Jesse Barnes 已提交
340 341
{
	drm_connector_cleanup(connector);
342
	intel_panel_fini(&to_intel_connector(connector)->panel);
343
	kfree(connector);
J
Jesse Barnes 已提交
344 345 346
}

static const struct drm_connector_funcs intel_dvo_connector_funcs = {
347
	.dpms = drm_atomic_helper_connector_dpms,
J
Jesse Barnes 已提交
348 349 350
	.detect = intel_dvo_detect,
	.destroy = intel_dvo_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
351
	.atomic_get_property = intel_connector_atomic_get_property,
352
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
353
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
J
Jesse Barnes 已提交
354 355 356 357 358
};

static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	.mode_valid = intel_dvo_mode_valid,
	.get_modes = intel_dvo_get_modes,
359
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
360 361
};

362
static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
J
Jesse Barnes 已提交
363
{
364
	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
C
Chris Wilson 已提交
365 366 367 368 369

	if (intel_dvo->dev.dev_ops->destroy)
		intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);

	intel_encoder_destroy(encoder);
J
Jesse Barnes 已提交
370 371 372 373 374 375 376 377 378 379 380 381 382
}

static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	.destroy = intel_dvo_enc_destroy,
};

/**
 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 *
 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 * chip being on DVOB/C and having multiple pipes.
 */
static struct drm_display_mode *
C
Chris Wilson 已提交
383
intel_dvo_get_current_mode(struct drm_connector *connector)
J
Jesse Barnes 已提交
384 385 386
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
387
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
C
Chris Wilson 已提交
388
	uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
J
Jesse Barnes 已提交
389 390 391 392 393 394 395 396 397
	struct drm_display_mode *mode = NULL;

	/* If the DVO port is active, that'll be the LVDS, so we can pull out
	 * its timings to get how the BIOS set up the panel.
	 */
	if (dvo_val & DVO_ENABLE) {
		struct drm_crtc *crtc;
		int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;

398
		crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
399 400 401 402 403 404 405 406 407 408 409
		if (crtc) {
			mode = intel_crtc_mode_get(dev, crtc);
			if (mode) {
				mode->type |= DRM_MODE_TYPE_PREFERRED;
				if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PHSYNC;
				if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PVSYNC;
			}
		}
	}
C
Chris Wilson 已提交
410

J
Jesse Barnes 已提交
411 412 413 414 415
	return mode;
}

void intel_dvo_init(struct drm_device *dev)
{
416
	struct drm_i915_private *dev_priv = dev->dev_private;
417
	struct intel_encoder *intel_encoder;
C
Chris Wilson 已提交
418
	struct intel_dvo *intel_dvo;
419
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
420 421
	int i;
	int encoder_type = DRM_MODE_ENCODER_NONE;
C
Chris Wilson 已提交
422

423
	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
C
Chris Wilson 已提交
424
	if (!intel_dvo)
J
Jesse Barnes 已提交
425 426
		return;

427
	intel_connector = intel_connector_alloc();
428
	if (!intel_connector) {
C
Chris Wilson 已提交
429
		kfree(intel_dvo);
430 431 432
		return;
	}

433 434
	intel_dvo->attached_connector = intel_connector;

C
Chris Wilson 已提交
435
	intel_encoder = &intel_dvo->base;
436 437
	drm_encoder_init(dev, &intel_encoder->base,
			 &intel_dvo_enc_funcs, encoder_type);
C
Chris Wilson 已提交
438

439 440
	intel_encoder->disable = intel_disable_dvo;
	intel_encoder->enable = intel_enable_dvo;
441
	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
442
	intel_encoder->get_config = intel_dvo_get_config;
443
	intel_encoder->compute_config = intel_dvo_compute_config;
444
	intel_encoder->pre_enable = intel_dvo_pre_enable;
445
	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
446
	intel_connector->unregister = intel_connector_unregister;
447

J
Jesse Barnes 已提交
448 449
	/* Now, try to find a controller */
	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
450
		struct drm_connector *connector = &intel_connector->base;
C
Chris Wilson 已提交
451
		const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
452
		struct i2c_adapter *i2c;
J
Jesse Barnes 已提交
453
		int gpio;
454
		bool dvoinit;
455
		enum pipe pipe;
456
		uint32_t dpll[I915_MAX_PIPES];
J
Jesse Barnes 已提交
457 458 459 460 461

		/* Allow the I2C driver info to specify the GPIO to be used in
		 * special cases, but otherwise default to what's defined
		 * in the spec.
		 */
462
		if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
J
Jesse Barnes 已提交
463 464
			gpio = dvo->gpio;
		else if (dvo->type == INTEL_DVO_CHIP_LVDS)
465
			gpio = GMBUS_PIN_SSC;
J
Jesse Barnes 已提交
466
		else
467
			gpio = GMBUS_PIN_DPB;
J
Jesse Barnes 已提交
468 469 470 471 472

		/* Set up the I2C bus necessary for the chip we're probing.
		 * It appears that everything is on GPIOE except for panels
		 * on i830 laptops, which are on GPIOB (DVOA).
		 */
473
		i2c = intel_gmbus_get_adapter(dev_priv, gpio);
J
Jesse Barnes 已提交
474

C
Chris Wilson 已提交
475
		intel_dvo->dev = *dvo;
476 477 478 479 480 481

		/* GMBUS NAK handling seems to be unstable, hence let the
		 * transmitter detection run in bit banging mode for now.
		 */
		intel_gmbus_force_bit(i2c, true);

482 483 484 485 486 487 488 489 490 491
		/* ns2501 requires the DVO 2x clock before it will
		 * respond to i2c accesses, so make sure we have
		 * have the clock enabled before we attempt to
		 * initialize the device.
		 */
		for_each_pipe(dev_priv, pipe) {
			dpll[pipe] = I915_READ(DPLL(pipe));
			I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
		}

492 493
		dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);

494 495 496 497 498
		/* restore the DVO 2x clock state to original */
		for_each_pipe(dev_priv, pipe) {
			I915_WRITE(DPLL(pipe), dpll[pipe]);
		}

499 500 501
		intel_gmbus_force_bit(i2c, false);

		if (!dvoinit)
J
Jesse Barnes 已提交
502 503
			continue;

504 505
		intel_encoder->type = INTEL_OUTPUT_DVO;
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
506 507
		switch (dvo->type) {
		case INTEL_DVO_CHIP_TMDS:
508 509
			intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
				(1 << INTEL_OUTPUT_DVO);
J
Jesse Barnes 已提交
510 511 512 513 514 515
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_DVII);
			encoder_type = DRM_MODE_ENCODER_TMDS;
			break;
		case INTEL_DVO_CHIP_LVDS:
516
			intel_encoder->cloneable = 0;
J
Jesse Barnes 已提交
517 518 519 520 521 522 523 524 525 526 527 528 529
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_LVDS);
			encoder_type = DRM_MODE_ENCODER_LVDS;
			break;
		}

		drm_connector_helper_add(connector,
					 &intel_dvo_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;
		connector->interlace_allowed = false;
		connector->doublescan_allowed = false;

530
		intel_connector_attach_encoder(intel_connector, intel_encoder);
J
Jesse Barnes 已提交
531 532 533 534 535 536 537 538
		if (dvo->type == INTEL_DVO_CHIP_LVDS) {
			/* For our LVDS chipsets, we should hopefully be able
			 * to dig the fixed panel mode out of the BIOS data.
			 * However, it's in a different format from the BIOS
			 * data on chipsets with integrated LVDS (stored in AIM
			 * headers, likely), so for now, just get the current
			 * mode being output through DVO.
			 */
539 540 541
			intel_panel_init(&intel_connector->panel,
					 intel_dvo_get_current_mode(connector),
					 NULL);
C
Chris Wilson 已提交
542
			intel_dvo->panel_wants_dither = true;
J
Jesse Barnes 已提交
543 544
		}

545
		drm_connector_register(connector);
J
Jesse Barnes 已提交
546 547 548
		return;
	}

549
	drm_encoder_cleanup(&intel_encoder->base);
C
Chris Wilson 已提交
550
	kfree(intel_dvo);
551
	kfree(intel_connector);
J
Jesse Barnes 已提交
552
}