intel_dvo.c 15.7 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */
#include <linux/i2c.h>
28
#include <linux/slab.h>
29 30
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
J
Jesse Barnes 已提交
31
#include "intel_drv.h"
32
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
33 34 35 36 37 38
#include "i915_drv.h"
#include "dvo.h"

#define SIL164_ADDR	0x38
#define CH7xxx_ADDR	0x76
#define TFP410_ADDR	0x38
39
#define NS2501_ADDR     0x38
J
Jesse Barnes 已提交
40

C
Chris Wilson 已提交
41
static const struct intel_dvo_device intel_dvo_devices[] = {
J
Jesse Barnes 已提交
42 43 44 45 46 47 48 49 50 51 52 53 54 55
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "sil164",
		.dvo_reg = DVOC,
		.slave_addr = SIL164_ADDR,
		.dev_ops = &sil164_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = CH7xxx_ADDR,
		.dev_ops = &ch7xxx_ops,
	},
56 57 58 59 60 61 62
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = 0x75, /* For some ch7010 */
		.dev_ops = &ch7xxx_ops,
	},
J
Jesse Barnes 已提交
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ivch",
		.dvo_reg = DVOA,
		.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
		.dev_ops = &ivch_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "tfp410",
		.dvo_reg = DVOC,
		.slave_addr = TFP410_ADDR,
		.dev_ops = &tfp410_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ch7017",
		.dvo_reg = DVOC,
		.slave_addr = 0x75,
82
		.gpio = GMBUS_PORT_DPB,
J
Jesse Barnes 已提交
83
		.dev_ops = &ch7017_ops,
84 85 86 87 88 89 90 91
	},
	{
	        .type = INTEL_DVO_CHIP_TMDS,
		.name = "ns2501",
		.dvo_reg = DVOC,
		.slave_addr = NS2501_ADDR,
		.dev_ops = &ns2501_ops,
       }
J
Jesse Barnes 已提交
92 93
};

C
Chris Wilson 已提交
94 95 96 97 98 99 100 101 102
struct intel_dvo {
	struct intel_encoder base;

	struct intel_dvo_device dev;

	struct drm_display_mode *panel_fixed_mode;
	bool panel_wants_dither;
};

103
static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
C
Chris Wilson 已提交
104
{
105
	return container_of(encoder, struct intel_dvo, base);
C
Chris Wilson 已提交
106 107
}

108 109
static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
{
110
	return enc_to_dvo(intel_attached_encoder(connector));
111 112
}

113
static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
J
Jesse Barnes 已提交
114
{
115 116 117 118 119 120 121 122 123 124
	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);

	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
}

static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
125
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
126 127 128 129 130 131 132 133 134 135 136 137
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	*pipe = PORT_TO_PIPE(tmp);

	return true;
}

138 139 140 141
static void intel_dvo_get_config(struct intel_encoder *encoder,
				 struct intel_crtc_config *pipe_config)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
142
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
143 144 145 146 147 148 149 150 151 152 153 154 155
	u32 tmp, flags = 0;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

	pipe_config->adjusted_mode.flags |= flags;
156

157
	pipe_config->adjusted_mode.crtc_clock = pipe_config->port_clock;
158 159
}

160 161 162
static void intel_disable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
163
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
164 165 166 167 168 169 170 171 172 173 174
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	I915_READ(dvo_reg);
}

static void intel_enable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
175
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
176
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
C
Chris Wilson 已提交
177
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
J
Jesse Barnes 已提交
178 179
	u32 temp = I915_READ(dvo_reg);

180 181
	I915_WRITE(dvo_reg, temp | DVO_ENABLE);
	I915_READ(dvo_reg);
182 183 184 185
	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
					 &crtc->config.requested_mode,
					 &crtc->config.adjusted_mode);

186 187 188
	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
}

189
/* Special dpms function to support cloning between dvo/sdvo/crt. */
190
static void intel_dvo_dpms(struct drm_connector *connector, int mode)
J
Jesse Barnes 已提交
191
{
192 193
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
	struct drm_crtc *crtc;
194
	struct intel_crtc_config *config;
195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210

	/* dvo supports only 2 dpms states. */
	if (mode != DRM_MODE_DPMS_ON)
		mode = DRM_MODE_DPMS_OFF;

	if (mode == connector->dpms)
		return;

	connector->dpms = mode;

	/* Only need to change hw state when actually enabled */
	crtc = intel_dvo->base.base.crtc;
	if (!crtc) {
		intel_dvo->base.connectors_active = false;
		return;
	}
J
Jesse Barnes 已提交
211

212 213
	/* We call connector dpms manually below in case pipe dpms doesn't
	 * change due to cloning. */
J
Jesse Barnes 已提交
214
	if (mode == DRM_MODE_DPMS_ON) {
215 216
		config = &to_intel_crtc(crtc)->config;

217 218 219 220
		intel_dvo->base.connectors_active = true;

		intel_crtc_update_dpms(crtc);

221 222 223 224
		intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
						 &config->requested_mode,
						 &config->adjusted_mode);

225
		intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
J
Jesse Barnes 已提交
226
	} else {
227
		intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
228 229 230 231

		intel_dvo->base.connectors_active = false;

		intel_crtc_update_dpms(crtc);
J
Jesse Barnes 已提交
232
	}
233

234
	intel_modeset_check_state(connector->dev);
J
Jesse Barnes 已提交
235 236 237 238 239
}

static int intel_dvo_mode_valid(struct drm_connector *connector,
				struct drm_display_mode *mode)
{
240
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
J
Jesse Barnes 已提交
241 242 243 244 245 246

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	/* XXX: Validate clock range */

C
Chris Wilson 已提交
247 248
	if (intel_dvo->panel_fixed_mode) {
		if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay)
J
Jesse Barnes 已提交
249
			return MODE_PANEL;
C
Chris Wilson 已提交
250
		if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay)
J
Jesse Barnes 已提交
251 252 253
			return MODE_PANEL;
	}

C
Chris Wilson 已提交
254
	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
J
Jesse Barnes 已提交
255 256
}

257 258
static bool intel_dvo_compute_config(struct intel_encoder *encoder,
				     struct intel_crtc_config *pipe_config)
J
Jesse Barnes 已提交
259
{
260 261
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
J
Jesse Barnes 已提交
262 263 264 265 266 267

	/* If we have timings from the BIOS for the panel, put them in
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
C
Chris Wilson 已提交
268 269
	if (intel_dvo->panel_fixed_mode != NULL) {
#define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x
J
Jesse Barnes 已提交
270 271 272 273 274 275 276 277 278 279
		C(hdisplay);
		C(hsync_start);
		C(hsync_end);
		C(htotal);
		C(vdisplay);
		C(vsync_start);
		C(vsync_end);
		C(vtotal);
		C(clock);
#undef C
280 281

		drm_mode_set_crtcinfo(adjusted_mode, 0);
J
Jesse Barnes 已提交
282 283 284 285 286
	}

	return true;
}

287
static void intel_dvo_mode_set(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
288
{
289
	struct drm_device *dev = encoder->base.dev;
J
Jesse Barnes 已提交
290
	struct drm_i915_private *dev_priv = dev->dev_private;
291 292 293 294
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
	struct drm_display_mode *adjusted_mode = &crtc->config.adjusted_mode;
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	int pipe = crtc->pipe;
J
Jesse Barnes 已提交
295
	u32 dvo_val;
C
Chris Wilson 已提交
296
	u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
J
Jesse Barnes 已提交
297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339

	switch (dvo_reg) {
	case DVOA:
	default:
		dvo_srcdim_reg = DVOA_SRCDIM;
		break;
	case DVOB:
		dvo_srcdim_reg = DVOB_SRCDIM;
		break;
	case DVOC:
		dvo_srcdim_reg = DVOC_SRCDIM;
		break;
	}

	/* Save the data order, since I don't know what it should be set to. */
	dvo_val = I915_READ(dvo_reg) &
		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
	dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
		   DVO_BLANK_ACTIVE_HIGH;

	if (pipe == 1)
		dvo_val |= DVO_PIPE_B_SELECT;
	dvo_val |= DVO_PIPE_STALL;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		dvo_val |= DVO_VSYNC_ACTIVE_HIGH;

	/*I915_WRITE(DVOB_SRCDIM,
	  (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
	  (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
	I915_WRITE(dvo_srcdim_reg,
		   (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
		   (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
	/*I915_WRITE(DVOB, dvo_val);*/
	I915_WRITE(dvo_reg, dvo_val);
}

/**
 * Detect the output connection on our DVO device.
 *
 * Unimplemented.
 */
340
static enum drm_connector_status
341
intel_dvo_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
342
{
343
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
344 345
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
		      connector->base.id, drm_get_connector_name(connector));
C
Chris Wilson 已提交
346
	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
J
Jesse Barnes 已提交
347 348 349 350
}

static int intel_dvo_get_modes(struct drm_connector *connector)
{
351
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
352
	struct drm_i915_private *dev_priv = connector->dev->dev_private;
J
Jesse Barnes 已提交
353 354 355 356 357 358

	/* We should probably have an i2c driver get_modes function for those
	 * devices which will have a fixed set of modes determined by the chip
	 * (TV-out, for example), but for now with just TMDS and LVDS,
	 * that's not the case.
	 */
359
	intel_ddc_get_modes(connector,
360
			    intel_gmbus_get_adapter(dev_priv, GMBUS_PORT_DPC));
J
Jesse Barnes 已提交
361 362 363
	if (!list_empty(&connector->probed_modes))
		return 1;

C
Chris Wilson 已提交
364
	if (intel_dvo->panel_fixed_mode != NULL) {
J
Jesse Barnes 已提交
365
		struct drm_display_mode *mode;
C
Chris Wilson 已提交
366
		mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode);
J
Jesse Barnes 已提交
367 368 369 370 371
		if (mode) {
			drm_mode_probed_add(connector, mode);
			return 1;
		}
	}
C
Chris Wilson 已提交
372

J
Jesse Barnes 已提交
373 374 375
	return 0;
}

C
Chris Wilson 已提交
376
static void intel_dvo_destroy(struct drm_connector *connector)
J
Jesse Barnes 已提交
377 378
{
	drm_connector_cleanup(connector);
379
	kfree(connector);
J
Jesse Barnes 已提交
380 381 382
}

static const struct drm_connector_funcs intel_dvo_connector_funcs = {
383
	.dpms = intel_dvo_dpms,
J
Jesse Barnes 已提交
384 385 386 387 388 389 390 391
	.detect = intel_dvo_detect,
	.destroy = intel_dvo_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
};

static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	.mode_valid = intel_dvo_mode_valid,
	.get_modes = intel_dvo_get_modes,
392
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
393 394
};

395
static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
J
Jesse Barnes 已提交
396
{
397
	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
C
Chris Wilson 已提交
398 399 400 401 402 403 404

	if (intel_dvo->dev.dev_ops->destroy)
		intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);

	kfree(intel_dvo->panel_fixed_mode);

	intel_encoder_destroy(encoder);
J
Jesse Barnes 已提交
405 406 407 408 409 410 411 412 413 414 415 416 417
}

static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	.destroy = intel_dvo_enc_destroy,
};

/**
 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 *
 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 * chip being on DVOB/C and having multiple pipes.
 */
static struct drm_display_mode *
C
Chris Wilson 已提交
418
intel_dvo_get_current_mode(struct drm_connector *connector)
J
Jesse Barnes 已提交
419 420 421
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
422
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
C
Chris Wilson 已提交
423
	uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
J
Jesse Barnes 已提交
424 425 426 427 428 429 430 431 432
	struct drm_display_mode *mode = NULL;

	/* If the DVO port is active, that'll be the LVDS, so we can pull out
	 * its timings to get how the BIOS set up the panel.
	 */
	if (dvo_val & DVO_ENABLE) {
		struct drm_crtc *crtc;
		int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;

433
		crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
434 435 436 437 438 439 440 441 442 443 444
		if (crtc) {
			mode = intel_crtc_mode_get(dev, crtc);
			if (mode) {
				mode->type |= DRM_MODE_TYPE_PREFERRED;
				if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PHSYNC;
				if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PVSYNC;
			}
		}
	}
C
Chris Wilson 已提交
445

J
Jesse Barnes 已提交
446 447 448 449 450
	return mode;
}

void intel_dvo_init(struct drm_device *dev)
{
451
	struct drm_i915_private *dev_priv = dev->dev_private;
452
	struct intel_encoder *intel_encoder;
C
Chris Wilson 已提交
453
	struct intel_dvo *intel_dvo;
454
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
455 456
	int i;
	int encoder_type = DRM_MODE_ENCODER_NONE;
C
Chris Wilson 已提交
457

458
	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
C
Chris Wilson 已提交
459
	if (!intel_dvo)
J
Jesse Barnes 已提交
460 461
		return;

462
	intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL);
463
	if (!intel_connector) {
C
Chris Wilson 已提交
464
		kfree(intel_dvo);
465 466 467
		return;
	}

C
Chris Wilson 已提交
468
	intel_encoder = &intel_dvo->base;
469 470
	drm_encoder_init(dev, &intel_encoder->base,
			 &intel_dvo_enc_funcs, encoder_type);
C
Chris Wilson 已提交
471

472 473
	intel_encoder->disable = intel_disable_dvo;
	intel_encoder->enable = intel_enable_dvo;
474
	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
475
	intel_encoder->get_config = intel_dvo_get_config;
476
	intel_encoder->compute_config = intel_dvo_compute_config;
477
	intel_encoder->mode_set = intel_dvo_mode_set;
478
	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
479

J
Jesse Barnes 已提交
480 481
	/* Now, try to find a controller */
	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
482
		struct drm_connector *connector = &intel_connector->base;
C
Chris Wilson 已提交
483
		const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
484
		struct i2c_adapter *i2c;
J
Jesse Barnes 已提交
485
		int gpio;
486
		bool dvoinit;
J
Jesse Barnes 已提交
487 488 489 490 491

		/* Allow the I2C driver info to specify the GPIO to be used in
		 * special cases, but otherwise default to what's defined
		 * in the spec.
		 */
492
		if (intel_gmbus_is_port_valid(dvo->gpio))
J
Jesse Barnes 已提交
493 494
			gpio = dvo->gpio;
		else if (dvo->type == INTEL_DVO_CHIP_LVDS)
495
			gpio = GMBUS_PORT_SSC;
J
Jesse Barnes 已提交
496
		else
497
			gpio = GMBUS_PORT_DPB;
J
Jesse Barnes 已提交
498 499 500 501 502

		/* Set up the I2C bus necessary for the chip we're probing.
		 * It appears that everything is on GPIOE except for panels
		 * on i830 laptops, which are on GPIOB (DVOA).
		 */
503
		i2c = intel_gmbus_get_adapter(dev_priv, gpio);
J
Jesse Barnes 已提交
504

C
Chris Wilson 已提交
505
		intel_dvo->dev = *dvo;
506 507 508 509 510 511 512 513 514 515 516

		/* GMBUS NAK handling seems to be unstable, hence let the
		 * transmitter detection run in bit banging mode for now.
		 */
		intel_gmbus_force_bit(i2c, true);

		dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);

		intel_gmbus_force_bit(i2c, false);

		if (!dvoinit)
J
Jesse Barnes 已提交
517 518
			continue;

519 520
		intel_encoder->type = INTEL_OUTPUT_DVO;
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
521 522
		switch (dvo->type) {
		case INTEL_DVO_CHIP_TMDS:
523
			intel_encoder->cloneable = true;
J
Jesse Barnes 已提交
524 525 526 527 528 529
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_DVII);
			encoder_type = DRM_MODE_ENCODER_TMDS;
			break;
		case INTEL_DVO_CHIP_LVDS:
530
			intel_encoder->cloneable = false;
J
Jesse Barnes 已提交
531 532 533 534 535 536 537 538 539 540 541 542 543
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_LVDS);
			encoder_type = DRM_MODE_ENCODER_LVDS;
			break;
		}

		drm_connector_helper_add(connector,
					 &intel_dvo_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;
		connector->interlace_allowed = false;
		connector->doublescan_allowed = false;

544
		intel_connector_attach_encoder(intel_connector, intel_encoder);
J
Jesse Barnes 已提交
545 546 547 548 549 550 551 552
		if (dvo->type == INTEL_DVO_CHIP_LVDS) {
			/* For our LVDS chipsets, we should hopefully be able
			 * to dig the fixed panel mode out of the BIOS data.
			 * However, it's in a different format from the BIOS
			 * data on chipsets with integrated LVDS (stored in AIM
			 * headers, likely), so for now, just get the current
			 * mode being output through DVO.
			 */
C
Chris Wilson 已提交
553
			intel_dvo->panel_fixed_mode =
J
Jesse Barnes 已提交
554
				intel_dvo_get_current_mode(connector);
C
Chris Wilson 已提交
555
			intel_dvo->panel_wants_dither = true;
J
Jesse Barnes 已提交
556 557 558 559 560 561
		}

		drm_sysfs_connector_add(connector);
		return;
	}

562
	drm_encoder_cleanup(&intel_encoder->base);
C
Chris Wilson 已提交
563
	kfree(intel_dvo);
564
	kfree(intel_connector);
J
Jesse Barnes 已提交
565
}