intel_dvo.c 15.8 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */
#include <linux/i2c.h>
28
#include <linux/slab.h>
29
#include <drm/drmP.h>
30
#include <drm/drm_atomic_helper.h>
31
#include <drm/drm_crtc.h>
J
Jesse Barnes 已提交
32
#include "intel_drv.h"
33
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
34 35 36 37 38 39
#include "i915_drv.h"
#include "dvo.h"

#define SIL164_ADDR	0x38
#define CH7xxx_ADDR	0x76
#define TFP410_ADDR	0x38
40
#define NS2501_ADDR     0x38
J
Jesse Barnes 已提交
41

C
Chris Wilson 已提交
42
static const struct intel_dvo_device intel_dvo_devices[] = {
J
Jesse Barnes 已提交
43 44 45 46 47 48 49 50 51 52 53 54 55 56
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "sil164",
		.dvo_reg = DVOC,
		.slave_addr = SIL164_ADDR,
		.dev_ops = &sil164_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = CH7xxx_ADDR,
		.dev_ops = &ch7xxx_ops,
	},
57 58 59 60 61 62 63
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "ch7xxx",
		.dvo_reg = DVOC,
		.slave_addr = 0x75, /* For some ch7010 */
		.dev_ops = &ch7xxx_ops,
	},
J
Jesse Barnes 已提交
64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ivch",
		.dvo_reg = DVOA,
		.slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
		.dev_ops = &ivch_ops,
	},
	{
		.type = INTEL_DVO_CHIP_TMDS,
		.name = "tfp410",
		.dvo_reg = DVOC,
		.slave_addr = TFP410_ADDR,
		.dev_ops = &tfp410_ops,
	},
	{
		.type = INTEL_DVO_CHIP_LVDS,
		.name = "ch7017",
		.dvo_reg = DVOC,
		.slave_addr = 0x75,
83
		.gpio = GMBUS_PIN_DPB,
J
Jesse Barnes 已提交
84
		.dev_ops = &ch7017_ops,
85 86 87 88
	},
	{
	        .type = INTEL_DVO_CHIP_TMDS,
		.name = "ns2501",
V
Ville Syrjälä 已提交
89
		.dvo_reg = DVOB,
90 91 92
		.slave_addr = NS2501_ADDR,
		.dev_ops = &ns2501_ops,
       }
J
Jesse Barnes 已提交
93 94
};

C
Chris Wilson 已提交
95 96 97 98 99 100 101 102 103
struct intel_dvo {
	struct intel_encoder base;

	struct intel_dvo_device dev;

	struct drm_display_mode *panel_fixed_mode;
	bool panel_wants_dither;
};

104
static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
C
Chris Wilson 已提交
105
{
106
	return container_of(encoder, struct intel_dvo, base);
C
Chris Wilson 已提交
107 108
}

109 110
static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
{
111
	return enc_to_dvo(intel_attached_encoder(connector));
112 113
}

114
static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
J
Jesse Barnes 已提交
115
{
116 117
	struct drm_device *dev = connector->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
118
	struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
119 120 121 122 123 124
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;
125 126 127 128 129 130 131 132 133

	return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
}

static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
134
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
135 136 137 138 139 140 141 142 143 144 145 146
	u32 tmp;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);

	if (!(tmp & DVO_ENABLE))
		return false;

	*pipe = PORT_TO_PIPE(tmp);

	return true;
}

147
static void intel_dvo_get_config(struct intel_encoder *encoder,
148
				 struct intel_crtc_state *pipe_config)
149 150
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
151
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
152 153 154 155 156 157 158 159 160 161 162 163
	u32 tmp, flags = 0;

	tmp = I915_READ(intel_dvo->dev.dvo_reg);
	if (tmp & DVO_HSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (tmp & DVO_VSYNC_ACTIVE_HIGH)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

164
	pipe_config->base.adjusted_mode.flags |= flags;
165

166
	pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
167 168
}

169 170 171
static void intel_disable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
172
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
173 174 175 176 177 178 179 180 181 182 183
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
	u32 temp = I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
	I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
	I915_READ(dvo_reg);
}

static void intel_enable_dvo(struct intel_encoder *encoder)
{
	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
184
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
185
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
C
Chris Wilson 已提交
186
	u32 dvo_reg = intel_dvo->dev.dvo_reg;
J
Jesse Barnes 已提交
187 188
	u32 temp = I915_READ(dvo_reg);

189
	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
190 191
					 &crtc->config->base.mode,
					 &crtc->config->base.adjusted_mode);
192

193 194 195
	I915_WRITE(dvo_reg, temp | DVO_ENABLE);
	I915_READ(dvo_reg);

196 197 198
	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
}

199 200 201
static enum drm_mode_status
intel_dvo_mode_valid(struct drm_connector *connector,
		     struct drm_display_mode *mode)
J
Jesse Barnes 已提交
202
{
203
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
M
Mika Kahola 已提交
204 205
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
	int target_clock = mode->clock;
J
Jesse Barnes 已提交
206 207 208 209 210 211

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	/* XXX: Validate clock range */

C
Chris Wilson 已提交
212 213
	if (intel_dvo->panel_fixed_mode) {
		if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay)
J
Jesse Barnes 已提交
214
			return MODE_PANEL;
C
Chris Wilson 已提交
215
		if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay)
J
Jesse Barnes 已提交
216
			return MODE_PANEL;
M
Mika Kahola 已提交
217 218

		target_clock = intel_dvo->panel_fixed_mode->clock;
J
Jesse Barnes 已提交
219 220
	}

M
Mika Kahola 已提交
221 222 223
	if (target_clock > max_dotclk)
		return MODE_CLOCK_HIGH;

C
Chris Wilson 已提交
224
	return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
J
Jesse Barnes 已提交
225 226
}

227
static bool intel_dvo_compute_config(struct intel_encoder *encoder,
228
				     struct intel_crtc_state *pipe_config)
J
Jesse Barnes 已提交
229
{
230
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
231
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
J
Jesse Barnes 已提交
232 233 234 235 236 237

	/* If we have timings from the BIOS for the panel, put them in
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
C
Chris Wilson 已提交
238 239
	if (intel_dvo->panel_fixed_mode != NULL) {
#define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x
J
Jesse Barnes 已提交
240 241 242 243 244 245 246 247 248 249
		C(hdisplay);
		C(hsync_start);
		C(hsync_end);
		C(htotal);
		C(vdisplay);
		C(vsync_start);
		C(vsync_end);
		C(vtotal);
		C(clock);
#undef C
250 251

		drm_mode_set_crtcinfo(adjusted_mode, 0);
J
Jesse Barnes 已提交
252 253 254 255 256
	}

	return true;
}

257
static void intel_dvo_pre_enable(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
258
{
259
	struct drm_device *dev = encoder->base.dev;
J
Jesse Barnes 已提交
260
	struct drm_i915_private *dev_priv = dev->dev_private;
261
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
262
	struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
263 264
	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
	int pipe = crtc->pipe;
J
Jesse Barnes 已提交
265
	u32 dvo_val;
C
Chris Wilson 已提交
266
	u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
J
Jesse Barnes 已提交
267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309

	switch (dvo_reg) {
	case DVOA:
	default:
		dvo_srcdim_reg = DVOA_SRCDIM;
		break;
	case DVOB:
		dvo_srcdim_reg = DVOB_SRCDIM;
		break;
	case DVOC:
		dvo_srcdim_reg = DVOC_SRCDIM;
		break;
	}

	/* Save the data order, since I don't know what it should be set to. */
	dvo_val = I915_READ(dvo_reg) &
		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
	dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
		   DVO_BLANK_ACTIVE_HIGH;

	if (pipe == 1)
		dvo_val |= DVO_PIPE_B_SELECT;
	dvo_val |= DVO_PIPE_STALL;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		dvo_val |= DVO_VSYNC_ACTIVE_HIGH;

	/*I915_WRITE(DVOB_SRCDIM,
	  (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
	  (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
	I915_WRITE(dvo_srcdim_reg,
		   (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
		   (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
	/*I915_WRITE(DVOB, dvo_val);*/
	I915_WRITE(dvo_reg, dvo_val);
}

/**
 * Detect the output connection on our DVO device.
 *
 * Unimplemented.
 */
310
static enum drm_connector_status
311
intel_dvo_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
312
{
313
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
314
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
315
		      connector->base.id, connector->name);
C
Chris Wilson 已提交
316
	return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
J
Jesse Barnes 已提交
317 318 319 320
}

static int intel_dvo_get_modes(struct drm_connector *connector)
{
321
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
322
	struct drm_i915_private *dev_priv = connector->dev->dev_private;
J
Jesse Barnes 已提交
323 324 325 326 327 328

	/* We should probably have an i2c driver get_modes function for those
	 * devices which will have a fixed set of modes determined by the chip
	 * (TV-out, for example), but for now with just TMDS and LVDS,
	 * that's not the case.
	 */
329
	intel_ddc_get_modes(connector,
330
			    intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
J
Jesse Barnes 已提交
331 332 333
	if (!list_empty(&connector->probed_modes))
		return 1;

C
Chris Wilson 已提交
334
	if (intel_dvo->panel_fixed_mode != NULL) {
J
Jesse Barnes 已提交
335
		struct drm_display_mode *mode;
C
Chris Wilson 已提交
336
		mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode);
J
Jesse Barnes 已提交
337 338 339 340 341
		if (mode) {
			drm_mode_probed_add(connector, mode);
			return 1;
		}
	}
C
Chris Wilson 已提交
342

J
Jesse Barnes 已提交
343 344 345
	return 0;
}

C
Chris Wilson 已提交
346
static void intel_dvo_destroy(struct drm_connector *connector)
J
Jesse Barnes 已提交
347 348
{
	drm_connector_cleanup(connector);
349
	kfree(connector);
J
Jesse Barnes 已提交
350 351 352
}

static const struct drm_connector_funcs intel_dvo_connector_funcs = {
353
	.dpms = drm_atomic_helper_connector_dpms,
J
Jesse Barnes 已提交
354 355 356
	.detect = intel_dvo_detect,
	.destroy = intel_dvo_destroy,
	.fill_modes = drm_helper_probe_single_connector_modes,
357
	.atomic_get_property = intel_connector_atomic_get_property,
358
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
359
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
J
Jesse Barnes 已提交
360 361 362 363 364
};

static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
	.mode_valid = intel_dvo_mode_valid,
	.get_modes = intel_dvo_get_modes,
365
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
366 367
};

368
static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
J
Jesse Barnes 已提交
369
{
370
	struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
C
Chris Wilson 已提交
371 372 373 374 375 376 377

	if (intel_dvo->dev.dev_ops->destroy)
		intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);

	kfree(intel_dvo->panel_fixed_mode);

	intel_encoder_destroy(encoder);
J
Jesse Barnes 已提交
378 379 380 381 382 383 384 385 386 387 388 389 390
}

static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
	.destroy = intel_dvo_enc_destroy,
};

/**
 * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 *
 * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 * chip being on DVOB/C and having multiple pipes.
 */
static struct drm_display_mode *
C
Chris Wilson 已提交
391
intel_dvo_get_current_mode(struct drm_connector *connector)
J
Jesse Barnes 已提交
392 393 394
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
395
	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
C
Chris Wilson 已提交
396
	uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
J
Jesse Barnes 已提交
397 398 399 400 401 402 403 404 405
	struct drm_display_mode *mode = NULL;

	/* If the DVO port is active, that'll be the LVDS, so we can pull out
	 * its timings to get how the BIOS set up the panel.
	 */
	if (dvo_val & DVO_ENABLE) {
		struct drm_crtc *crtc;
		int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;

406
		crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
407 408 409 410 411 412 413 414 415 416 417
		if (crtc) {
			mode = intel_crtc_mode_get(dev, crtc);
			if (mode) {
				mode->type |= DRM_MODE_TYPE_PREFERRED;
				if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PHSYNC;
				if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
					mode->flags |= DRM_MODE_FLAG_PVSYNC;
			}
		}
	}
C
Chris Wilson 已提交
418

J
Jesse Barnes 已提交
419 420 421 422 423
	return mode;
}

void intel_dvo_init(struct drm_device *dev)
{
424
	struct drm_i915_private *dev_priv = dev->dev_private;
425
	struct intel_encoder *intel_encoder;
C
Chris Wilson 已提交
426
	struct intel_dvo *intel_dvo;
427
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
428 429
	int i;
	int encoder_type = DRM_MODE_ENCODER_NONE;
C
Chris Wilson 已提交
430

431
	intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
C
Chris Wilson 已提交
432
	if (!intel_dvo)
J
Jesse Barnes 已提交
433 434
		return;

435
	intel_connector = intel_connector_alloc();
436
	if (!intel_connector) {
C
Chris Wilson 已提交
437
		kfree(intel_dvo);
438 439 440
		return;
	}

C
Chris Wilson 已提交
441
	intel_encoder = &intel_dvo->base;
442 443
	drm_encoder_init(dev, &intel_encoder->base,
			 &intel_dvo_enc_funcs, encoder_type);
C
Chris Wilson 已提交
444

445 446
	intel_encoder->disable = intel_disable_dvo;
	intel_encoder->enable = intel_enable_dvo;
447
	intel_encoder->get_hw_state = intel_dvo_get_hw_state;
448
	intel_encoder->get_config = intel_dvo_get_config;
449
	intel_encoder->compute_config = intel_dvo_compute_config;
450
	intel_encoder->pre_enable = intel_dvo_pre_enable;
451
	intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
452
	intel_connector->unregister = intel_connector_unregister;
453

J
Jesse Barnes 已提交
454 455
	/* Now, try to find a controller */
	for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
456
		struct drm_connector *connector = &intel_connector->base;
C
Chris Wilson 已提交
457
		const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
458
		struct i2c_adapter *i2c;
J
Jesse Barnes 已提交
459
		int gpio;
460
		bool dvoinit;
461
		enum pipe pipe;
462
		uint32_t dpll[I915_MAX_PIPES];
J
Jesse Barnes 已提交
463 464 465 466 467

		/* Allow the I2C driver info to specify the GPIO to be used in
		 * special cases, but otherwise default to what's defined
		 * in the spec.
		 */
468
		if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
J
Jesse Barnes 已提交
469 470
			gpio = dvo->gpio;
		else if (dvo->type == INTEL_DVO_CHIP_LVDS)
471
			gpio = GMBUS_PIN_SSC;
J
Jesse Barnes 已提交
472
		else
473
			gpio = GMBUS_PIN_DPB;
J
Jesse Barnes 已提交
474 475 476 477 478

		/* Set up the I2C bus necessary for the chip we're probing.
		 * It appears that everything is on GPIOE except for panels
		 * on i830 laptops, which are on GPIOB (DVOA).
		 */
479
		i2c = intel_gmbus_get_adapter(dev_priv, gpio);
J
Jesse Barnes 已提交
480

C
Chris Wilson 已提交
481
		intel_dvo->dev = *dvo;
482 483 484 485 486 487

		/* GMBUS NAK handling seems to be unstable, hence let the
		 * transmitter detection run in bit banging mode for now.
		 */
		intel_gmbus_force_bit(i2c, true);

488 489 490 491 492 493 494 495 496 497
		/* ns2501 requires the DVO 2x clock before it will
		 * respond to i2c accesses, so make sure we have
		 * have the clock enabled before we attempt to
		 * initialize the device.
		 */
		for_each_pipe(dev_priv, pipe) {
			dpll[pipe] = I915_READ(DPLL(pipe));
			I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
		}

498 499
		dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);

500 501 502 503 504
		/* restore the DVO 2x clock state to original */
		for_each_pipe(dev_priv, pipe) {
			I915_WRITE(DPLL(pipe), dpll[pipe]);
		}

505 506 507
		intel_gmbus_force_bit(i2c, false);

		if (!dvoinit)
J
Jesse Barnes 已提交
508 509
			continue;

510 511
		intel_encoder->type = INTEL_OUTPUT_DVO;
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
512 513
		switch (dvo->type) {
		case INTEL_DVO_CHIP_TMDS:
514 515
			intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
				(1 << INTEL_OUTPUT_DVO);
J
Jesse Barnes 已提交
516 517 518 519 520 521
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_DVII);
			encoder_type = DRM_MODE_ENCODER_TMDS;
			break;
		case INTEL_DVO_CHIP_LVDS:
522
			intel_encoder->cloneable = 0;
J
Jesse Barnes 已提交
523 524 525 526 527 528 529 530 531 532 533 534 535
			drm_connector_init(dev, connector,
					   &intel_dvo_connector_funcs,
					   DRM_MODE_CONNECTOR_LVDS);
			encoder_type = DRM_MODE_ENCODER_LVDS;
			break;
		}

		drm_connector_helper_add(connector,
					 &intel_dvo_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;
		connector->interlace_allowed = false;
		connector->doublescan_allowed = false;

536
		intel_connector_attach_encoder(intel_connector, intel_encoder);
J
Jesse Barnes 已提交
537 538 539 540 541 542 543 544
		if (dvo->type == INTEL_DVO_CHIP_LVDS) {
			/* For our LVDS chipsets, we should hopefully be able
			 * to dig the fixed panel mode out of the BIOS data.
			 * However, it's in a different format from the BIOS
			 * data on chipsets with integrated LVDS (stored in AIM
			 * headers, likely), so for now, just get the current
			 * mode being output through DVO.
			 */
C
Chris Wilson 已提交
545
			intel_dvo->panel_fixed_mode =
J
Jesse Barnes 已提交
546
				intel_dvo_get_current_mode(connector);
C
Chris Wilson 已提交
547
			intel_dvo->panel_wants_dither = true;
J
Jesse Barnes 已提交
548 549
		}

550
		drm_connector_register(connector);
J
Jesse Barnes 已提交
551 552 553
		return;
	}

554
	drm_encoder_cleanup(&intel_encoder->base);
C
Chris Wilson 已提交
555
	kfree(intel_dvo);
556
	kfree(intel_connector);
J
Jesse Barnes 已提交
557
}