Skip to content

L
libvirt

openeuler / libvirt

通知 3
Star 0
Fork 0
L
libvirt

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 10 3月, 2016 1 次提交
  3. 01 3月, 2016 5 次提交
  5. 23 2月, 2016 1 次提交
    • M
      qemuBuildCommandLine: Change the condition for -nographics · 01c31852
      由 Michal Privoznik 提交于 
      There's this check when building command line that whenever
domain has no graphics card configured we put -nographics onto
qemu command line. The check is 'if (!def->graphics)'. This
makes coverity think that def->graphics can be NULL, which is
true. But later in the code every access to def->graphics is
guarded by check for def->ngraphics, so no crash occurs. But this
is something that coverity fails to deduct.
In order to shut coverity up lets change the condition to
'if (!def->ngraphics)'.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
      01c31852
  7. 22 2月, 2016 1 次提交
  9. 20 2月, 2016 1 次提交
    • A
      gic: Introduce VIR_GIC_VERSION_DEFAULT alias · d8fc7e05
      由 Andrea Bolognani 提交于 
      GIC v2 is the default, but checking against that specific version when
we want to know whether the default has been selected is potentially
error prone; using an alias instead makes it safer.
      d8fc7e05
  11. 18 2月, 2016 11 次提交
  13. 17 2月, 2016 12 次提交
  15. 16 2月, 2016 1 次提交
  17. 11 2月, 2016 3 次提交
    • J
      qemu: Split the command parsing routines into own module · d860b2f5
      由 John Ferlan 提交于 
      Extract out the qemuParseCommandLine{String|Pid} into their own
separate module - taking with it all the various static functions.

Causes a ripple effect with a few other modules to include the
new qemu_parse_command.h.

Narrowed down the list of #include's in the split out module to
those that are necessary for build.
      d860b2f5
    • J
      qemu: Check return status for virDomainGraphicsListenSetAddress · 336d4dac
      由 John Ferlan 提交于 
      Recent refactors in the vbox code to check the return status for the
function tipped Coverity's scales of justice for any functions that
do not check status - such as this one.

While I'm at it, since the call is essentially the same other than
whether starting from val or val+1 when val[0] = '[', just adjust
the val pointer by one and have one call instead of two.

Additionally, the call to virDomainGraphicsListenGetAddress is redundant
since it checking that the address field got filled.  It's a leftover
from the strndup -> ListenSetAddress conversion (commit id 'ef79fb5b')
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      336d4dac
    • J
      qemu: Introduce qemuParseCommandLineVnc · 7b3adac4
      由 John Ferlan 提交于 
      Refactor qemuParseCommandLine to pull out the "-vnc" argument parsing
into its own helper function.  Modify the code to use "cleanup" instead
of "error" and use the standard return processing to indicate success
or failure by using ret
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
      7b3adac4
  19. 08 2月, 2016 1 次提交
    • P
      conf: Move and optimize disk target duplicity checking · e84ab793
      由 Peter Krempa 提交于 
      Move the logic from virDomainDiskDefDstDuplicates into
virDomainDiskDefCheckDuplicateInfo so that we don't have to loop
multiple times through the array of disks. Since the original function
was called in qemuBuildDriveDevStr, it was actually called for every
single disk which was quite wasteful.

Additionally the target uniqueness check needed to be duplicated in
the disk hotplug case, since the disk was inserted into the domain
definition after the device string was formatted and thus
virDomainDiskDefDstDuplicates didn't do anything in that case.
      e84ab793
  21. 01 2月, 2016 1 次提交
  23. 12 1月, 2016 2 次提交