remote.c 195.7 KB
Newer Older
1
/*
2
 * remote.c: handlers for RPC method calls
3
 *
4
 * Copyright (C) 2007-2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
17
 * License along with this library.  If not, see
O
Osier Yang 已提交
18
 * <http://www.gnu.org/licenses/>.
19 20 21 22 23 24
 *
 * Author: Richard W.M. Jones <rjones@redhat.com>
 */

#include <config.h>

25
#include "virerror.h"
26

27
#if WITH_POLKIT0
28 29
# include <polkit/polkit.h>
# include <polkit-dbus/polkit-dbus.h>
30 31
#endif

32
#include "remote.h"
33
#include "libvirtd.h"
34 35
#include "libvirt_internal.h"
#include "datatypes.h"
36
#include "viralloc.h"
37
#include "virlog.h"
C
Chris Lalancette 已提交
38
#include "stream.h"
39
#include "viruuid.h"
40
#include "vircommand.h"
41
#include "intprops.h"
42
#include "virnetserverservice.h"
J
Jim Fehlig 已提交
43
#include "virnetserver.h"
44
#include "virfile.h"
45
#include "virtypedparam.h"
46
#include "virdbus.h"
47
#include "virprocess.h"
48 49
#include "remote_protocol.h"
#include "qemu_protocol.h"
50
#include "lxc_protocol.h"
51
#include "virstring.h"
52
#include "object_event.h"
53 54
#include "domain_conf.h"
#include "network_conf.h"
55
#include "virprobe.h"
56
#include "viraccessapicheck.h"
57 58

#define VIR_FROM_THIS VIR_FROM_RPC
59

60 61
VIR_LOG_INIT("daemon.remote");

62
#if SIZEOF_LONG < 8
E
Eric Blake 已提交
63 64 65
# define HYPER_TO_TYPE(_type, _to, _from)                               \
    do {                                                                \
        if ((_from) != (_type)(_from)) {                                \
66 67 68
            virReportError(VIR_ERR_OVERFLOW,                            \
                           _("conversion from hyper to %s overflowed"), \
                           #_type);                                     \
E
Eric Blake 已提交
69 70 71
            goto cleanup;                                               \
        }                                                               \
        (_to) = (_from);                                                \
72 73 74 75 76 77 78 79 80
    } while (0)

# define HYPER_TO_LONG(_to, _from) HYPER_TO_TYPE(long, _to, _from)
# define HYPER_TO_ULONG(_to, _from) HYPER_TO_TYPE(unsigned long, _to, _from)
#else
# define HYPER_TO_LONG(_to, _from) (_to) = (_from)
# define HYPER_TO_ULONG(_to, _from) (_to) = (_from)
#endif

81 82 83 84
struct daemonClientEventCallback {
    virNetServerClientPtr client;
    int eventID;
    int callbackID;
85
    bool legacy;
86 87
};

88 89 90 91 92 93 94
static virDomainPtr get_nonnull_domain(virConnectPtr conn, remote_nonnull_domain domain);
static virNetworkPtr get_nonnull_network(virConnectPtr conn, remote_nonnull_network network);
static virInterfacePtr get_nonnull_interface(virConnectPtr conn, remote_nonnull_interface iface);
static virStoragePoolPtr get_nonnull_storage_pool(virConnectPtr conn, remote_nonnull_storage_pool pool);
static virStorageVolPtr get_nonnull_storage_vol(virConnectPtr conn, remote_nonnull_storage_vol vol);
static virSecretPtr get_nonnull_secret(virConnectPtr conn, remote_nonnull_secret secret);
static virNWFilterPtr get_nonnull_nwfilter(virConnectPtr conn, remote_nonnull_nwfilter nwfilter);
95
static virDomainSnapshotPtr get_nonnull_domain_snapshot(virDomainPtr dom, remote_nonnull_domain_snapshot snapshot);
96 97 98 99 100 101 102 103 104
static void make_nonnull_domain(remote_nonnull_domain *dom_dst, virDomainPtr dom_src);
static void make_nonnull_network(remote_nonnull_network *net_dst, virNetworkPtr net_src);
static void make_nonnull_interface(remote_nonnull_interface *interface_dst, virInterfacePtr interface_src);
static void make_nonnull_storage_pool(remote_nonnull_storage_pool *pool_dst, virStoragePoolPtr pool_src);
static void make_nonnull_storage_vol(remote_nonnull_storage_vol *vol_dst, virStorageVolPtr vol_src);
static void make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNodeDevicePtr dev_src);
static void make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src);
static void make_nonnull_nwfilter(remote_nonnull_nwfilter *net_dst, virNWFilterPtr nwfilter_src);
static void make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src);
105

106 107 108 109 110
static virTypedParameterPtr
remoteDeserializeTypedParameters(remote_typed_param *args_params_val,
                                 u_int args_params_len,
                                 int limit,
                                 int *nparams);
111

112 113 114 115 116 117
static int
remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors,
                                int nerrors,
                                remote_domain_disk_error **ret_errors_val,
                                u_int *ret_errors_len);

118 119
#include "remote_dispatch.h"
#include "qemu_dispatch.h"
120
#include "lxc_dispatch.h"
C
Chris Lalancette 已提交
121 122


123 124
/* Prototypes */
static void
125
remoteDispatchObjectEventSend(virNetServerClientPtr client,
126
                              virNetServerProgramPtr program,
127 128 129
                              int procnr,
                              xdrproc_t proc,
                              void *data);
130

131 132 133 134 135 136
static void
remoteEventCallbackFree(void *opaque)
{
    VIR_FREE(opaque);
}

137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197

static bool
remoteRelayDomainEventCheckACL(virNetServerClientPtr client,
                               virConnectPtr conn, virDomainPtr dom)
{
    virDomainDef def;
    virIdentityPtr identity = NULL;
    bool ret = false;

    /* For now, we just create a virDomainDef with enough contents to
     * satisfy what viraccessdriverpolkit.c references.  This is a bit
     * fragile, but I don't know of anything better.  */
    def.name = dom->name;
    memcpy(def.uuid, dom->uuid, VIR_UUID_BUFLEN);

    if (!(identity = virNetServerClientGetIdentity(client)))
        goto cleanup;
    if (virIdentitySetCurrent(identity) < 0)
        goto cleanup;
    ret = virConnectDomainEventRegisterAnyCheckACL(conn, &def);

cleanup:
    ignore_value(virIdentitySetCurrent(NULL));
    virObjectUnref(identity);
    return ret;
}


static bool
remoteRelayNetworkEventCheckACL(virNetServerClientPtr client,
                                virConnectPtr conn, virNetworkPtr net)
{
    virNetworkDef def;
    virIdentityPtr identity = NULL;
    bool ret = false;

    /* For now, we just create a virNetworkDef with enough contents to
     * satisfy what viraccessdriverpolkit.c references.  This is a bit
     * fragile, but I don't know of anything better.  */
    def.name = net->name;
    memcpy(def.uuid, net->uuid, VIR_UUID_BUFLEN);

    if (!(identity = virNetServerClientGetIdentity(client)))
        goto cleanup;
    if (virIdentitySetCurrent(identity) < 0)
        goto cleanup;
    ret = virConnectNetworkEventRegisterAnyCheckACL(conn, &def);

cleanup:
    ignore_value(virIdentitySetCurrent(NULL));
    virObjectUnref(identity);
    return ret;
}


static int
remoteRelayDomainEventLifecycle(virConnectPtr conn,
                                virDomainPtr dom,
                                int event,
                                int detail,
                                void *opaque)
198
{
199
    daemonClientEventCallbackPtr callback = opaque;
200
    remote_domain_event_lifecycle_msg data;
201

202 203
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
204 205
        return -1;

206 207
    VIR_DEBUG("Relaying domain lifecycle event %d %d, callback %d legacy %d",
              event, detail, callback->callbackID, callback->legacy);
208

209
    /* build return data */
210
    memset(&data, 0, sizeof(data));
211
    make_nonnull_domain(&data.dom, dom);
212 213
    data.event = event;
    data.detail = detail;
214

215 216 217 218 219 220 221 222 223 224 225 226 227 228
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_LIFECYCLE,
                                      (xdrproc_t)xdr_remote_domain_event_lifecycle_msg,
                                      &data);
    } else {
        remote_domain_event_callback_lifecycle_msg msg = { callback->callbackID,
                                                           data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_LIFECYCLE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_lifecycle_msg,
                                      &msg);
    }
229

230 231
    return 0;
}
232

233 234 235 236
static int
remoteRelayDomainEventReboot(virConnectPtr conn,
                             virDomainPtr dom,
                             void *opaque)
237
{
238
    daemonClientEventCallbackPtr callback = opaque;
239 240
    remote_domain_event_reboot_msg data;

241 242
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
243 244
        return -1;

245 246
    VIR_DEBUG("Relaying domain reboot event %s %d, callback %d legacy %d",
              dom->name, dom->id, callback->callbackID, callback->legacy);
247 248

    /* build return data */
249
    memset(&data, 0, sizeof(data));
250
    make_nonnull_domain(&data.dom, dom);
251

252 253 254 255 256 257 258 259 260 261 262 263
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_REBOOT,
                                      (xdrproc_t)xdr_remote_domain_event_reboot_msg, &data);
    } else {
        remote_domain_event_callback_reboot_msg msg = { callback->callbackID,
                                                        data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_REBOOT,
                                      (xdrproc_t)xdr_remote_domain_event_callback_reboot_msg, &msg);
    }
264 265 266 267

    return 0;
}

268

269 270 271 272 273
static int
remoteRelayDomainEventRTCChange(virConnectPtr conn,
                                virDomainPtr dom,
                                long long offset,
                                void *opaque)
274
{
275
    daemonClientEventCallbackPtr callback = opaque;
276 277
    remote_domain_event_rtc_change_msg data;

278 279
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
280 281
        return -1;

282 283 284
    VIR_DEBUG("Relaying domain rtc change event %s %d %lld, callback %d legacy %d",
              dom->name, dom->id, offset,
              callback->callbackID, callback->legacy);
285 286

    /* build return data */
287
    memset(&data, 0, sizeof(data));
288
    make_nonnull_domain(&data.dom, dom);
289 290
    data.offset = offset;

291 292 293 294 295 296 297 298 299 300 301 302
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_RTC_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_rtc_change_msg, &data);
    } else {
        remote_domain_event_callback_rtc_change_msg msg = { callback->callbackID,
                                                            data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_RTC_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_rtc_change_msg, &msg);
    }
303 304 305 306 307

    return 0;
}


308 309 310 311 312
static int
remoteRelayDomainEventWatchdog(virConnectPtr conn,
                               virDomainPtr dom,
                               int action,
                               void *opaque)
313
{
314
    daemonClientEventCallbackPtr callback = opaque;
315 316
    remote_domain_event_watchdog_msg data;

317 318
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
319 320
        return -1;

321 322
    VIR_DEBUG("Relaying domain watchdog event %s %d %d, callback %d",
              dom->name, dom->id, action, callback->callbackID);
323 324

    /* build return data */
325
    memset(&data, 0, sizeof(data));
326
    make_nonnull_domain(&data.dom, dom);
327 328
    data.action = action;

329 330 331 332 333 334 335 336 337 338 339 340
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_WATCHDOG,
                                      (xdrproc_t)xdr_remote_domain_event_watchdog_msg, &data);
    } else {
        remote_domain_event_callback_watchdog_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_WATCHDOG,
                                      (xdrproc_t)xdr_remote_domain_event_callback_watchdog_msg, &msg);
    }
341 342 343 344 345

    return 0;
}


346 347 348 349 350 351 352
static int
remoteRelayDomainEventIOError(virConnectPtr conn,
                              virDomainPtr dom,
                              const char *srcPath,
                              const char *devAlias,
                              int action,
                              void *opaque)
353
{
354
    daemonClientEventCallbackPtr callback = opaque;
355 356
    remote_domain_event_io_error_msg data;

357 358
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
359 360
        return -1;

361 362 363
    VIR_DEBUG("Relaying domain io error %s %d %s %s %d, callback %d",
              dom->name, dom->id, srcPath, devAlias, action,
              callback->callbackID);
364 365

    /* build return data */
366
    memset(&data, 0, sizeof(data));
367 368 369
    if (VIR_STRDUP(data.srcPath, srcPath) < 0 ||
        VIR_STRDUP(data.devAlias, devAlias) < 0)
        goto error;
370
    make_nonnull_domain(&data.dom, dom);
371 372
    data.action = action;

373 374 375 376 377 378 379 380 381 382 383 384
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_IO_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_io_error_msg, &data);
    } else {
        remote_domain_event_callback_io_error_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_IO_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_callback_io_error_msg, &msg);
    }
385 386

    return 0;
387
error:
E
Eric Blake 已提交
388 389
    VIR_FREE(data.srcPath);
    VIR_FREE(data.devAlias);
390
    return -1;
391 392 393
}


394 395 396 397 398 399 400 401
static int
remoteRelayDomainEventIOErrorReason(virConnectPtr conn,
                                    virDomainPtr dom,
                                    const char *srcPath,
                                    const char *devAlias,
                                    int action,
                                    const char *reason,
                                    void *opaque)
402
{
403
    daemonClientEventCallbackPtr callback = opaque;
404 405
    remote_domain_event_io_error_reason_msg data;

406 407
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
408 409
        return -1;

410 411 412
    VIR_DEBUG("Relaying domain io error %s %d %s %s %d %s, callback %d",
              dom->name, dom->id, srcPath, devAlias, action, reason,
              callback->callbackID);
413 414

    /* build return data */
415
    memset(&data, 0, sizeof(data));
416 417 418 419
    if (VIR_STRDUP(data.srcPath, srcPath) < 0 ||
        VIR_STRDUP(data.devAlias, devAlias) < 0 ||
        VIR_STRDUP(data.reason, reason) < 0)
        goto error;
420
    data.action = action;
421 422

    make_nonnull_domain(&data.dom, dom);
423

424 425 426 427 428 429 430 431 432 433 434 435
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_IO_ERROR_REASON,
                                      (xdrproc_t)xdr_remote_domain_event_io_error_reason_msg, &data);
    } else {
        remote_domain_event_callback_io_error_reason_msg msg = { callback->callbackID,
                                                                 data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_IO_ERROR_REASON,
                                      (xdrproc_t)xdr_remote_domain_event_callback_io_error_reason_msg, &msg);
    }
436 437

    return 0;
438

439
error:
E
Eric Blake 已提交
440 441 442
    VIR_FREE(data.srcPath);
    VIR_FREE(data.devAlias);
    VIR_FREE(data.reason);
443
    return -1;
444 445 446
}


447 448 449 450 451 452 453 454 455
static int
remoteRelayDomainEventGraphics(virConnectPtr conn,
                               virDomainPtr dom,
                               int phase,
                               virDomainEventGraphicsAddressPtr local,
                               virDomainEventGraphicsAddressPtr remote,
                               const char *authScheme,
                               virDomainEventGraphicsSubjectPtr subject,
                               void *opaque)
456
{
457
    daemonClientEventCallbackPtr callback = opaque;
458
    remote_domain_event_graphics_msg data;
459
    size_t i;
460

461 462
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
463 464
        return -1;

465 466
    VIR_DEBUG("Relaying domain graphics event %s %d %d - %d %s %s  - %d %s %s - %s, callback %d",
              dom->name, dom->id, phase,
467 468
              local->family, local->service, local->node,
              remote->family, remote->service, remote->node,
469
              authScheme, callback->callbackID);
470

471
    VIR_DEBUG("Subject %d", subject->nidentity);
472
    for (i = 0; i < subject->nidentity; i++) {
473
        VIR_DEBUG("  %s=%s", subject->identities[i].type, subject->identities[i].name);
474 475 476
    }

    /* build return data */
477
    memset(&data, 0, sizeof(data));
478 479 480
    data.phase = phase;
    data.local.family = local->family;
    data.remote.family = remote->family;
481 482 483 484 485 486
    if (VIR_STRDUP(data.authScheme, authScheme) < 0 ||
        VIR_STRDUP(data.local.node, local->node) < 0 ||
        VIR_STRDUP(data.local.service, local->service) < 0 ||
        VIR_STRDUP(data.remote.node, remote->node) < 0 ||
        VIR_STRDUP(data.remote.service, remote->service) < 0)
        goto error;
487 488

    data.subject.subject_len = subject->nidentity;
489
    if (VIR_ALLOC_N(data.subject.subject_val, data.subject.subject_len) < 0)
490
        goto error;
491

492
    for (i = 0; i < data.subject.subject_len; i++) {
493 494 495
        if (VIR_STRDUP(data.subject.subject_val[i].type, subject->identities[i].type) < 0 ||
            VIR_STRDUP(data.subject.subject_val[i].name, subject->identities[i].name) < 0)
            goto error;
496
    }
497
    make_nonnull_domain(&data.dom, dom);
498

499 500 501 502 503 504 505 506 507 508 509 510
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_GRAPHICS,
                                      (xdrproc_t)xdr_remote_domain_event_graphics_msg, &data);
    } else {
        remote_domain_event_callback_graphics_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_GRAPHICS,
                                      (xdrproc_t)xdr_remote_domain_event_callback_graphics_msg, &msg);
    }
511 512

    return 0;
513

514
error:
E
Eric Blake 已提交
515 516 517 518 519
    VIR_FREE(data.authScheme);
    VIR_FREE(data.local.node);
    VIR_FREE(data.local.service);
    VIR_FREE(data.remote.node);
    VIR_FREE(data.remote.service);
520
    if (data.subject.subject_val != NULL) {
521
        for (i = 0; i < data.subject.subject_len; i++) {
E
Eric Blake 已提交
522 523
            VIR_FREE(data.subject.subject_val[i].type);
            VIR_FREE(data.subject.subject_val[i].name);
524
        }
E
Eric Blake 已提交
525
        VIR_FREE(data.subject.subject_val);
526 527
    }
    return -1;
528 529
}

530 531 532 533 534 535 536
static int
remoteRelayDomainEventBlockJob(virConnectPtr conn,
                               virDomainPtr dom,
                               const char *path,
                               int type,
                               int status,
                               void *opaque)
537
{
538
    daemonClientEventCallbackPtr callback = opaque;
539 540
    remote_domain_event_block_job_msg data;

541 542
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
543 544
        return -1;

545 546
    VIR_DEBUG("Relaying domain block job event %s %d %s %i, %i, callback %d",
              dom->name, dom->id, path, type, status, callback->callbackID);
547 548

    /* build return data */
549
    memset(&data, 0, sizeof(data));
550 551
    if (VIR_STRDUP(data.path, path) < 0)
        goto error;
552 553
    data.type = type;
    data.status = status;
554
    make_nonnull_domain(&data.dom, dom);
555

556 557 558 559 560 561 562 563 564 565 566 567
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_BLOCK_JOB,
                                      (xdrproc_t)xdr_remote_domain_event_block_job_msg, &data);
    } else {
        remote_domain_event_callback_block_job_msg msg = { callback->callbackID,
                                                           data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BLOCK_JOB,
                                      (xdrproc_t)xdr_remote_domain_event_callback_block_job_msg, &msg);
    }
568 569

    return 0;
570
error:
E
Eric Blake 已提交
571
    VIR_FREE(data.path);
572
    return -1;
573 574
}

575

576 577 578 579
static int
remoteRelayDomainEventControlError(virConnectPtr conn,
                                   virDomainPtr dom,
                                   void *opaque)
580
{
581
    daemonClientEventCallbackPtr callback = opaque;
582 583
    remote_domain_event_control_error_msg data;

584 585
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
586 587
        return -1;

588 589
    VIR_DEBUG("Relaying domain control error %s %d, callback %d",
              dom->name, dom->id, callback->callbackID);
590 591

    /* build return data */
592
    memset(&data, 0, sizeof(data));
593 594
    make_nonnull_domain(&data.dom, dom);

595 596 597 598 599 600 601 602 603 604 605 606
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CONTROL_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_control_error_msg, &data);
    } else {
        remote_domain_event_callback_control_error_msg msg = { callback->callbackID,
                                                               data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_CONTROL_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_callback_control_error_msg, &msg);
    }
607 608 609 610 611

    return 0;
}


612 613 614 615 616 617 618 619
static int
remoteRelayDomainEventDiskChange(virConnectPtr conn,
                                 virDomainPtr dom,
                                 const char *oldSrcPath,
                                 const char *newSrcPath,
                                 const char *devAlias,
                                 int reason,
                                 void *opaque)
620
{
621
    daemonClientEventCallbackPtr callback = opaque;
622 623 624
    remote_domain_event_disk_change_msg data;
    char **oldSrcPath_p = NULL, **newSrcPath_p = NULL;

625 626
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
627 628
        return -1;

629 630 631
    VIR_DEBUG("Relaying domain %s %d disk change %s %s %s %d, callback %d",
              dom->name, dom->id, oldSrcPath, newSrcPath, devAlias, reason,
              callback->callbackID);
632 633

    /* build return data */
634
    memset(&data, 0, sizeof(data));
635 636
    if (oldSrcPath &&
        ((VIR_ALLOC(oldSrcPath_p) < 0) ||
637
         VIR_STRDUP(*oldSrcPath_p, oldSrcPath) < 0))
638
        goto error;
639 640 641

    if (newSrcPath &&
        ((VIR_ALLOC(newSrcPath_p) < 0) ||
642
         VIR_STRDUP(*newSrcPath_p, newSrcPath) < 0))
643
        goto error;
644 645 646

    data.oldSrcPath = oldSrcPath_p;
    data.newSrcPath = newSrcPath_p;
647 648
    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
        goto error;
649 650 651 652
    data.reason = reason;

    make_nonnull_domain(&data.dom, dom);

653 654 655 656 657 658 659 660 661 662 663 664
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_DISK_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_disk_change_msg, &data);
    } else {
        remote_domain_event_callback_disk_change_msg msg = { callback->callbackID,
                                                             data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DISK_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_disk_change_msg, &msg);
    }
665 666 667

    return 0;

668
error:
M
Michal Privoznik 已提交
669 670
    VIR_FREE(oldSrcPath_p);
    VIR_FREE(newSrcPath_p);
671 672 673 674
    return -1;
}


675 676 677 678 679 680 681
static int
remoteRelayDomainEventTrayChange(virConnectPtr conn,
                                 virDomainPtr dom,
                                 const char *devAlias,
                                 int reason,
                                 void *opaque)
{
682
    daemonClientEventCallbackPtr callback = opaque;
683 684
    remote_domain_event_tray_change_msg data;

685 686
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
687 688
        return -1;

689 690
    VIR_DEBUG("Relaying domain %s %d tray change devAlias: %s reason: %d, callback %d",
              dom->name, dom->id, devAlias, reason, callback->callbackID);
691 692

    /* build return data */
693
    memset(&data, 0, sizeof(data));
694

695
    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
696 697 698 699 700
        return -1;
    data.reason = reason;

    make_nonnull_domain(&data.dom, dom);

701 702 703 704 705 706 707 708 709 710 711 712
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_TRAY_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_tray_change_msg, &data);
    } else {
        remote_domain_event_callback_tray_change_msg msg = { callback->callbackID,
                                                             data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TRAY_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_tray_change_msg, &msg);
    }
713 714 715 716

    return 0;
}

717 718 719
static int
remoteRelayDomainEventPMWakeup(virConnectPtr conn,
                               virDomainPtr dom,
E
Eric Blake 已提交
720
                               int reason,
721 722
                               void *opaque)
{
723
    daemonClientEventCallbackPtr callback = opaque;
O
Osier Yang 已提交
724 725
    remote_domain_event_pmwakeup_msg data;

726 727
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
O
Osier Yang 已提交
728 729
        return -1;

730 731
    VIR_DEBUG("Relaying domain %s %d system pmwakeup, callback %d",
              dom->name, dom->id, callback->callbackID);
O
Osier Yang 已提交
732 733

    /* build return data */
734
    memset(&data, 0, sizeof(data));
O
Osier Yang 已提交
735 736
    make_nonnull_domain(&data.dom, dom);

737 738 739 740 741 742
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMWAKEUP,
                                      (xdrproc_t)xdr_remote_domain_event_pmwakeup_msg, &data);
    } else {
        remote_domain_event_callback_pmwakeup_msg msg = { callback->callbackID,
E
Eric Blake 已提交
743
                                                          reason, data };
744 745 746 747 748

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMWAKEUP,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmwakeup_msg, &msg);
    }
O
Osier Yang 已提交
749 750 751 752

    return 0;
}

753 754 755
static int
remoteRelayDomainEventPMSuspend(virConnectPtr conn,
                                virDomainPtr dom,
E
Eric Blake 已提交
756
                                int reason,
757 758
                                void *opaque)
{
759
    daemonClientEventCallbackPtr callback = opaque;
O
Osier Yang 已提交
760 761
    remote_domain_event_pmsuspend_msg data;

762 763
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
O
Osier Yang 已提交
764 765
        return -1;

766 767
    VIR_DEBUG("Relaying domain %s %d system pmsuspend, callback %d",
              dom->name, dom->id, callback->callbackID);
O
Osier Yang 已提交
768 769

    /* build return data */
770
    memset(&data, 0, sizeof(data));
O
Osier Yang 已提交
771 772
    make_nonnull_domain(&data.dom, dom);

773 774 775 776 777 778
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND,
                                      (xdrproc_t)xdr_remote_domain_event_pmsuspend_msg, &data);
    } else {
        remote_domain_event_callback_pmsuspend_msg msg = { callback->callbackID,
E
Eric Blake 已提交
779
                                                           reason, data };
780 781 782 783 784

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmsuspend_msg, &msg);
    }
O
Osier Yang 已提交
785 786 787 788

    return 0;
}

789
static int
790
remoteRelayDomainEventBalloonChange(virConnectPtr conn,
791 792 793 794
                                    virDomainPtr dom,
                                    unsigned long long actual,
                                    void *opaque)
{
795
    daemonClientEventCallbackPtr callback = opaque;
796 797
    remote_domain_event_balloon_change_msg data;

798 799
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
800 801
        return -1;

802 803
    VIR_DEBUG("Relaying domain balloon change event %s %d %lld, callback %d",
              dom->name, dom->id, actual, callback->callbackID);
804 805 806 807 808 809

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_domain(&data.dom, dom);
    data.actual = actual;

810 811 812 813 814 815 816 817 818 819 820 821
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_BALLOON_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_balloon_change_msg, &data);
    } else {
        remote_domain_event_callback_balloon_change_msg msg = { callback->callbackID,
                                                                data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BALLOON_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_balloon_change_msg, &msg);
    }
822 823 824 825 826

    return 0;
}


827 828 829
static int
remoteRelayDomainEventPMSuspendDisk(virConnectPtr conn,
                                    virDomainPtr dom,
E
Eric Blake 已提交
830
                                    int reason,
831 832
                                    void *opaque)
{
833
    daemonClientEventCallbackPtr callback = opaque;
834 835
    remote_domain_event_pmsuspend_disk_msg data;

836 837
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
838 839
        return -1;

840 841
    VIR_DEBUG("Relaying domain %s %d system pmsuspend-disk, callback %d",
              dom->name, dom->id, callback->callbackID);
842 843 844 845 846

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_domain(&data.dom, dom);

847 848 849 850 851 852
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND_DISK,
                                      (xdrproc_t)xdr_remote_domain_event_pmsuspend_disk_msg, &data);
    } else {
        remote_domain_event_callback_pmsuspend_disk_msg msg = { callback->callbackID,
E
Eric Blake 已提交
853
                                                                reason, data };
854 855 856 857 858

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND_DISK,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmsuspend_disk_msg, &msg);
    }
859 860 861 862

    return 0;
}

863
static int
864
remoteRelayDomainEventDeviceRemoved(virConnectPtr conn,
865 866 867 868
                                    virDomainPtr dom,
                                    const char *devAlias,
                                    void *opaque)
{
869
    daemonClientEventCallbackPtr callback = opaque;
870 871
    remote_domain_event_device_removed_msg data;

872 873
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
874 875
        return -1;

876 877
    VIR_DEBUG("Relaying domain device removed event %s %d %s, callback %d",
              dom->name, dom->id, devAlias, callback->callbackID);
878 879 880 881 882 883 884 885 886

    /* build return data */
    memset(&data, 0, sizeof(data));

    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
        return -1;

    make_nonnull_domain(&data.dom, dom);

887 888 889 890 891 892 893 894 895 896 897 898 899 900
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_DEVICE_REMOVED,
                                      (xdrproc_t)xdr_remote_domain_event_device_removed_msg,
                                      &data);
    } else {
        remote_domain_event_callback_device_removed_msg msg = { callback->callbackID,
                                                                data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED,
                                      (xdrproc_t)xdr_remote_domain_event_callback_device_removed_msg,
                                      &msg);
    }
901 902 903 904

    return 0;
}

905

906
static virConnectDomainEventGenericCallback domainEventCallbacks[] = {
907
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventLifecycle),
908
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventReboot),
909
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventRTCChange),
910
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventWatchdog),
911
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventIOError),
912
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventGraphics),
913
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventIOErrorReason),
914
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventControlError),
915
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventBlockJob),
916
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventDiskChange),
917
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventTrayChange),
O
Osier Yang 已提交
918
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMWakeup),
O
Osier Yang 已提交
919
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMSuspend),
920
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventBalloonChange),
921
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMSuspendDisk),
922
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventDeviceRemoved),
923 924 925 926
};

verify(ARRAY_CARDINALITY(domainEventCallbacks) == VIR_DOMAIN_EVENT_ID_LAST);

927
static int
928
remoteRelayNetworkEventLifecycle(virConnectPtr conn,
929 930 931 932
                                 virNetworkPtr net,
                                 int event,
                                 int detail,
                                 void *opaque)
933
{
934
    daemonClientEventCallbackPtr callback = opaque;
935 936
    remote_network_event_lifecycle_msg data;

937 938
    if (callback->callbackID < 0 ||
        !remoteRelayNetworkEventCheckACL(callback->client, conn, net))
939 940
        return -1;

941 942
    VIR_DEBUG("Relaying network lifecycle event %d, detail %d, callback %d",
              event, detail, callback->callbackID);
943 944 945 946

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_network(&data.net, net);
947
    data.callbackID = callback->callbackID;
948 949 950
    data.event = event;
    data.detail = detail;

951
    remoteDispatchObjectEventSend(callback->client, remoteProgram,
952 953 954 955 956 957 958 959 960 961 962 963
                                  REMOTE_PROC_NETWORK_EVENT_LIFECYCLE,
                                  (xdrproc_t)xdr_remote_network_event_lifecycle_msg, &data);

    return 0;
}

static virConnectNetworkEventGenericCallback networkEventCallbacks[] = {
    VIR_NETWORK_EVENT_CALLBACK(remoteRelayNetworkEventLifecycle),
};

verify(ARRAY_CARDINALITY(networkEventCallbacks) == VIR_NETWORK_EVENT_ID_LAST);

964 965 966 967 968 969 970
/*
 * You must hold lock for at least the client
 * We don't free stuff here, merely disconnect the client's
 * network socket & resources.
 * We keep the libvirt connection open until any async
 * jobs have finished, then clean it up elsewhere
 */
971
void remoteClientFreeFunc(void *data)
972 973 974 975 976
{
    struct daemonClientPrivate *priv = data;

    /* Deregister event delivery callback */
    if (priv->conn) {
977
        virIdentityPtr sysident = virIdentityGetSystem();
978
        size_t i;
979

980 981
        virIdentitySetCurrent(sysident);

982 983 984 985 986
        for (i = 0; i < priv->ndomainEventCallbacks; i++) {
            int callbackID = priv->domainEventCallbacks[i]->callbackID;
            if (callbackID < 0) {
                VIR_WARN("unexpected incomplete domain callback %zu", i);
                continue;
987
            }
988 989 990 991 992
            VIR_DEBUG("Deregistering remote domain event relay %d",
                      callbackID);
            priv->domainEventCallbacks[i]->callbackID = -1;
            if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
                VIR_WARN("unexpected domain event deregister failure");
993
        }
994
        VIR_FREE(priv->domainEventCallbacks);
995

996 997 998 999 1000
        for (i = 0; i < priv->nnetworkEventCallbacks; i++) {
            int callbackID = priv->networkEventCallbacks[i]->callbackID;
            if (callbackID < 0) {
                VIR_WARN("unexpected incomplete network callback %zu", i);
                continue;
1001
            }
1002 1003 1004 1005 1006 1007
            VIR_DEBUG("Deregistering remote network event relay %d",
                      callbackID);
            priv->networkEventCallbacks[i]->callbackID = -1;
            if (virConnectNetworkEventDeregisterAny(priv->conn,
                                                    callbackID) < 0)
                VIR_WARN("unexpected network event deregister failure");
1008
        }
1009
        VIR_FREE(priv->networkEventCallbacks);
1010

1011
        virConnectClose(priv->conn);
1012 1013 1014

        virIdentitySetCurrent(NULL);
        virObjectUnref(sysident);
1015 1016 1017 1018 1019 1020
    }

    VIR_FREE(priv);
}


1021 1022 1023 1024 1025 1026 1027
static void remoteClientCloseFunc(virNetServerClientPtr client)
{
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    daemonRemoveAllClientStreams(priv->streams);
}

1028

1029 1030
void *remoteClientInitHook(virNetServerClientPtr client,
                           void *opaque ATTRIBUTE_UNUSED)
1031 1032 1033
{
    struct daemonClientPrivate *priv;

1034
    if (VIR_ALLOC(priv) < 0)
1035
        return NULL;
1036 1037 1038

    if (virMutexInit(&priv->lock) < 0) {
        VIR_FREE(priv);
1039
        virReportSystemError(errno, "%s", _("unable to init mutex"));
1040
        return NULL;
1041 1042
    }

1043
    virNetServerClientSetCloseHook(client, remoteClientCloseFunc);
1044
    return priv;
1045 1046
}

1047 1048 1049
/*----- Functions. -----*/

static int
1050 1051 1052 1053 1054
remoteDispatchConnectOpen(virNetServerPtr server,
                          virNetServerClientPtr client,
                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                          virNetMessageErrorPtr rerr,
                          struct remote_connect_open_args *args)
1055 1056
{
    const char *name;
1057
    unsigned int flags;
1058
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
1059
    int rv = -1;
1060

1061 1062 1063 1064
    VIR_DEBUG("priv=%p conn=%p", priv, priv->conn);
    virMutexLock(&priv->lock);
    /* Already opened? */
    if (priv->conn) {
1065
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection already open"));
1066 1067 1068
        goto cleanup;
    }

1069
    if (virNetServerKeepAliveRequired(server) && !priv->keepalive_supported) {
1070 1071
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                       _("keepalive support is required to connect"));
1072 1073 1074
        goto cleanup;
    }

1075 1076 1077 1078 1079 1080
    name = args->name ? *args->name : NULL;

    /* If this connection arrived on a readonly socket, force
     * the connection to be readonly.
     */
    flags = args->flags;
1081 1082
    if (virNetServerClientGetReadonly(client))
        flags |= VIR_CONNECT_RO;
1083

1084
    priv->conn =
1085
        flags & VIR_CONNECT_RO
1086 1087
        ? virConnectOpenReadOnly(name)
        : virConnectOpen(name);
1088

1089
    if (priv->conn == NULL)
1090 1091 1092
        goto cleanup;

    rv = 0;
1093

1094 1095
cleanup:
    if (rv < 0)
1096 1097
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
1098
    return rv;
1099 1100 1101 1102
}


static int
1103 1104 1105 1106
remoteDispatchConnectClose(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                           virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED)
1107
{
1108
    virNetServerClientDelayedClose(client);
1109
    return 0;
1110 1111
}

1112

1113
static int
1114 1115
remoteDispatchDomainGetSchedulerType(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client ATTRIBUTE_UNUSED,
1116
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
1117
                                     virNetMessageErrorPtr rerr,
1118 1119
                                     remote_domain_get_scheduler_type_args *args,
                                     remote_domain_get_scheduler_type_ret *ret)
1120
{
1121
    virDomainPtr dom = NULL;
1122 1123
    char *type;
    int nparams;
1124
    int rv = -1;
1125 1126
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1127

1128
    if (!priv->conn) {
1129
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1130
        goto cleanup;
1131 1132
    }

1133
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1134
        goto cleanup;
1135

1136
    if (!(type = virDomainGetSchedulerType(dom, &nparams)))
1137
        goto cleanup;
1138 1139 1140

    ret->type = type;
    ret->nparams = nparams;
1141 1142 1143 1144
    rv = 0;

cleanup:
    if (rv < 0)
1145
        virNetMessageSaveError(rerr);
1146 1147 1148
    if (dom)
        virDomainFree(dom);
    return rv;
1149 1150
}

1151 1152
/* Helper to serialize typed parameters. This also filters out any string
 * parameters that must not be returned to older clients.  */
1153 1154 1155
static int
remoteSerializeTypedParameters(virTypedParameterPtr params,
                               int nparams,
1156
                               remote_typed_param **ret_params_val,
1157 1158
                               u_int *ret_params_len,
                               unsigned int flags)
1159
{
1160 1161
    size_t i;
    size_t j;
1162 1163 1164 1165
    int rv = -1;
    remote_typed_param *val;

    *ret_params_len = nparams;
1166
    if (VIR_ALLOC_N(val, nparams) < 0)
1167 1168
        goto cleanup;

1169
    for (i = 0, j = 0; i < nparams; ++i) {
1170 1171 1172 1173 1174
        /* virDomainGetCPUStats can return a sparse array; also, we
         * can't pass back strings to older clients.  */
        if (!params[i].type ||
            (!(flags & VIR_TYPED_PARAM_STRING_OKAY) &&
             params[i].type == VIR_TYPED_PARAM_STRING)) {
1175 1176 1177 1178
            --*ret_params_len;
            continue;
        }

1179
        /* remoteDispatchClientRequest will free this: */
1180
        if (VIR_STRDUP(val[j].field, params[i].field) < 0)
1181
            goto cleanup;
1182
        val[j].value.type = params[i].type;
1183
        switch (params[i].type) {
1184
        case VIR_TYPED_PARAM_INT:
1185
            val[j].value.remote_typed_param_value_u.i = params[i].value.i;
1186 1187
            break;
        case VIR_TYPED_PARAM_UINT:
1188
            val[j].value.remote_typed_param_value_u.ui = params[i].value.ui;
1189 1190
            break;
        case VIR_TYPED_PARAM_LLONG:
1191
            val[j].value.remote_typed_param_value_u.l = params[i].value.l;
1192 1193
            break;
        case VIR_TYPED_PARAM_ULLONG:
1194
            val[j].value.remote_typed_param_value_u.ul = params[i].value.ul;
1195 1196
            break;
        case VIR_TYPED_PARAM_DOUBLE:
1197
            val[j].value.remote_typed_param_value_u.d = params[i].value.d;
1198 1199
            break;
        case VIR_TYPED_PARAM_BOOLEAN:
1200 1201 1202
            val[j].value.remote_typed_param_value_u.b = params[i].value.b;
            break;
        case VIR_TYPED_PARAM_STRING:
1203
            if (VIR_STRDUP(val[j].value.remote_typed_param_value_u.s, params[i].value.s) < 0)
1204
                goto cleanup;
1205 1206
            break;
        default:
1207 1208
            virReportError(VIR_ERR_RPC, _("unknown parameter type: %d"),
                           params[i].type);
1209 1210
            goto cleanup;
        }
1211
        j++;
1212 1213 1214 1215 1216 1217 1218 1219
    }

    *ret_params_val = val;
    val = NULL;
    rv = 0;

cleanup:
    if (val) {
1220
        for (i = 0; i < nparams; i++) {
1221
            VIR_FREE(val[i].field);
1222
            if (val[i].value.type == VIR_TYPED_PARAM_STRING)
1223 1224
                VIR_FREE(val[i].value.remote_typed_param_value_u.s);
        }
1225 1226 1227 1228 1229 1230 1231
        VIR_FREE(val);
    }
    return rv;
}

/* Helper to deserialize typed parameters. */
static virTypedParameterPtr
1232 1233
remoteDeserializeTypedParameters(remote_typed_param *args_params_val,
                                 u_int args_params_len,
1234 1235 1236
                                 int limit,
                                 int *nparams)
{
1237
    size_t i = 0;
1238 1239 1240 1241
    int rv = -1;
    virTypedParameterPtr params = NULL;

    /* Check the length of the returned list carefully. */
1242
    if (limit && args_params_len > limit) {
1243
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1244 1245
        goto cleanup;
    }
1246
    if (VIR_ALLOC_N(params, args_params_len) < 0)
1247 1248 1249 1250 1251 1252 1253 1254
        goto cleanup;

    *nparams = args_params_len;

    /* Deserialise the result. */
    for (i = 0; i < args_params_len; ++i) {
        if (virStrcpyStatic(params[i].field,
                            args_params_val[i].field) == NULL) {
1255 1256 1257
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Parameter %s too big for destination"),
                           args_params_val[i].field);
1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285
            goto cleanup;
        }
        params[i].type = args_params_val[i].value.type;
        switch (params[i].type) {
        case VIR_TYPED_PARAM_INT:
            params[i].value.i =
                args_params_val[i].value.remote_typed_param_value_u.i;
            break;
        case VIR_TYPED_PARAM_UINT:
            params[i].value.ui =
                args_params_val[i].value.remote_typed_param_value_u.ui;
            break;
        case VIR_TYPED_PARAM_LLONG:
            params[i].value.l =
                args_params_val[i].value.remote_typed_param_value_u.l;
            break;
        case VIR_TYPED_PARAM_ULLONG:
            params[i].value.ul =
                args_params_val[i].value.remote_typed_param_value_u.ul;
            break;
        case VIR_TYPED_PARAM_DOUBLE:
            params[i].value.d =
                args_params_val[i].value.remote_typed_param_value_u.d;
            break;
        case VIR_TYPED_PARAM_BOOLEAN:
            params[i].value.b =
                args_params_val[i].value.remote_typed_param_value_u.b;
            break;
1286
        case VIR_TYPED_PARAM_STRING:
1287 1288
            if (VIR_STRDUP(params[i].value.s,
                           args_params_val[i].value.remote_typed_param_value_u.s) < 0)
1289 1290
                goto cleanup;
            break;
1291
        default:
1292 1293
            virReportError(VIR_ERR_INTERNAL_ERROR, _("unknown parameter type: %d"),
                           params[i].type);
1294 1295 1296 1297 1298 1299 1300
            goto cleanup;
        }
    }

    rv = 0;

cleanup:
1301
    if (rv < 0) {
1302 1303
        virTypedParamsFree(params, i);
        params = NULL;
1304
    }
1305 1306 1307
    return params;
}

1308
static int
1309 1310
remoteDispatchDomainGetSchedulerParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
1311
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
1312
                                           virNetMessageErrorPtr rerr,
1313 1314
                                           remote_domain_get_scheduler_parameters_args *args,
                                           remote_domain_get_scheduler_parameters_ret *ret)
1315
{
1316
    virDomainPtr dom = NULL;
1317
    virTypedParameterPtr params = NULL;
1318
    int nparams = 0;
1319
    int rv = -1;
1320 1321
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1322

1323
    if (!priv->conn) {
1324
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1325
        goto cleanup;
1326 1327
    }

1328
    if (args->nparams > REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX) {
1329
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1330
        goto cleanup;
1331
    }
1332
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1333
        goto cleanup;
1334
    nparams = args->nparams;
1335

1336
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1337
        goto cleanup;
1338

1339
    if (virDomainGetSchedulerParameters(dom, params, &nparams) < 0)
1340
        goto cleanup;
1341

1342
    if (remoteSerializeTypedParameters(params, nparams,
1343
                                       &ret->params.params_val,
1344 1345
                                       &ret->params.params_len,
                                       0) < 0)
1346 1347 1348 1349 1350 1351
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
1352
        virNetMessageSaveError(rerr);
1353
    virTypedParamsFree(params, nparams);
1354 1355 1356 1357 1358
    if (dom)
        virDomainFree(dom);
    return rv;
}

1359 1360 1361 1362 1363 1364 1365 1366 1367 1368
static int
remoteDispatchConnectListAllDomains(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client,
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                    virNetMessageErrorPtr rerr,
                                    remote_connect_list_all_domains_args *args,
                                    remote_connect_list_all_domains_ret *ret)
{
    virDomainPtr *doms = NULL;
    int ndomains = 0;
1369
    size_t i;
1370 1371 1372 1373
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
1374
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1375 1376 1377 1378 1379 1380 1381 1382
        goto cleanup;
    }

    if ((ndomains = virConnectListAllDomains(priv->conn,
                                             args->need_results ? &doms : NULL,
                                             args->flags)) < 0)
        goto cleanup;

1383 1384 1385 1386 1387 1388 1389
    if (ndomains > REMOTE_DOMAIN_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domains '%d' for limit '%d'"),
                       ndomains, REMOTE_DOMAIN_LIST_MAX);
        goto cleanup;
    }

1390
    if (doms && ndomains) {
1391
        if (VIR_ALLOC_N(ret->domains.domains_val, ndomains) < 0)
1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417
            goto cleanup;

        ret->domains.domains_len = ndomains;

        for (i = 0; i < ndomains; i++)
            make_nonnull_domain(ret->domains.domains_val + i, doms[i]);
    } else {
        ret->domains.domains_len = 0;
        ret->domains.domains_val = NULL;
    }

    ret->ret = ndomains;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (doms) {
        for (i = 0; i < ndomains; i++)
            virDomainFree(doms[i]);
        VIR_FREE(doms);
    }
    return rv;
}

1418
static int
1419 1420
remoteDispatchDomainGetSchedulerParametersFlags(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
1421
                                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
1422
                                                virNetMessageErrorPtr rerr,
1423 1424 1425 1426 1427
                                                remote_domain_get_scheduler_parameters_flags_args *args,
                                                remote_domain_get_scheduler_parameters_flags_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
1428
    int nparams = 0;
1429
    int rv = -1;
1430 1431
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1432

1433
    if (!priv->conn) {
1434
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1435 1436 1437
        goto cleanup;
    }

1438
    if (args->nparams > REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX) {
1439
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1440 1441
        goto cleanup;
    }
1442
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1443
        goto cleanup;
1444
    nparams = args->nparams;
1445

1446
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1447 1448 1449 1450 1451 1452 1453
        goto cleanup;

    if (virDomainGetSchedulerParametersFlags(dom, params, &nparams,
                                             args->flags) < 0)
        goto cleanup;

    if (remoteSerializeTypedParameters(params, nparams,
1454
                                       &ret->params.params_val,
1455 1456
                                       &ret->params.params_len,
                                       args->flags) < 0)
1457
        goto cleanup;
1458

1459
    rv = 0;
1460 1461

cleanup:
1462
    if (rv < 0)
1463
        virNetMessageSaveError(rerr);
1464
    virTypedParamsFree(params, nparams);
1465 1466 1467
    if (dom)
        virDomainFree(dom);
    return rv;
1468 1469
}

1470
static int
1471 1472
remoteDispatchDomainMemoryStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
1473
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
1474
                                virNetMessageErrorPtr rerr,
1475 1476
                                remote_domain_memory_stats_args *args,
                                remote_domain_memory_stats_ret *ret)
1477
{
1478
    virDomainPtr dom = NULL;
1479
    struct _virDomainMemoryStat *stats = NULL;
1480 1481
    int nr_stats;
    size_t i;
1482
    int rv = -1;
1483 1484
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1485

1486
    if (!priv->conn) {
1487
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1488
        goto cleanup;
1489 1490
    }

1491
    if (args->maxStats > REMOTE_DOMAIN_MEMORY_STATS_MAX) {
1492 1493
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("maxStats > REMOTE_DOMAIN_MEMORY_STATS_MAX"));
1494
        goto cleanup;
1495 1496
    }

1497
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1498
        goto cleanup;
1499 1500

    /* Allocate stats array for making dispatch call */
1501
    if (VIR_ALLOC_N(stats, args->maxStats) < 0)
1502
        goto cleanup;
1503

1504
    nr_stats = virDomainMemoryStats(dom, stats, args->maxStats, args->flags);
1505
    if (nr_stats < 0)
1506
        goto cleanup;
1507 1508

    /* Allocate return buffer */
1509
    if (VIR_ALLOC_N(ret->stats.stats_val, args->maxStats) < 0)
1510
        goto cleanup;
1511 1512 1513 1514 1515 1516 1517

    /* Copy the stats into the xdr return structure */
    for (i = 0; i < nr_stats; i++) {
        ret->stats.stats_val[i].tag = stats[i].tag;
        ret->stats.stats_val[i].val = stats[i].val;
    }
    ret->stats.stats_len = nr_stats;
1518 1519 1520 1521
    rv = 0;

cleanup:
    if (rv < 0)
1522
        virNetMessageSaveError(rerr);
1523 1524
    if (dom)
        virDomainFree(dom);
1525
    VIR_FREE(stats);
1526
    return rv;
1527 1528
}

1529
static int
1530 1531
remoteDispatchDomainBlockPeek(virNetServerPtr server ATTRIBUTE_UNUSED,
                              virNetServerClientPtr client ATTRIBUTE_UNUSED,
1532
                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
1533
                              virNetMessageErrorPtr rerr,
1534 1535
                              remote_domain_block_peek_args *args,
                              remote_domain_block_peek_ret *ret)
1536
{
1537
    virDomainPtr dom = NULL;
1538 1539 1540 1541
    char *path;
    unsigned long long offset;
    size_t size;
    unsigned int flags;
1542
    int rv = -1;
1543 1544
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1545

1546
    if (!priv->conn) {
1547
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1548
        goto cleanup;
1549 1550
    }

1551
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1552
        goto cleanup;
1553 1554 1555 1556 1557 1558
    path = args->path;
    offset = args->offset;
    size = args->size;
    flags = args->flags;

    if (size > REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX) {
1559 1560
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("size > maximum buffer size"));
1561
        goto cleanup;
1562 1563 1564
    }

    ret->buffer.buffer_len = size;
1565
    if (VIR_ALLOC_N(ret->buffer.buffer_val, size) < 0)
1566
        goto cleanup;
1567

1568
    if (virDomainBlockPeek(dom, path, offset, size,
1569
                           ret->buffer.buffer_val, flags) < 0)
1570
        goto cleanup;
1571

1572 1573 1574 1575
    rv = 0;

cleanup:
    if (rv < 0) {
1576
        virNetMessageSaveError(rerr);
1577 1578 1579 1580 1581
        VIR_FREE(ret->buffer.buffer_val);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
1582 1583
}

1584 1585 1586
static int
remoteDispatchDomainBlockStatsFlags(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
1587
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
1588 1589 1590 1591 1592 1593 1594
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_block_stats_flags_args *args,
                                    remote_domain_block_stats_flags_ret *ret)
{
    virTypedParameterPtr params = NULL;
    virDomainPtr dom = NULL;
    const char *path = args->path;
1595
    int nparams = 0;
1596 1597 1598 1599 1600 1601
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
1602
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1603 1604 1605 1606 1607 1608 1609
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;
    flags = args->flags;

1610
    if (args->nparams > REMOTE_DOMAIN_BLOCK_STATS_PARAMETERS_MAX) {
1611
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1612 1613
        goto cleanup;
    }
1614
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1615
        goto cleanup;
1616
    nparams = args->nparams;
1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631

    if (virDomainBlockStatsFlags(dom, path, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the block stats. */
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
1632 1633
                                       &ret->params.params_len,
                                       args->flags) < 0)
1634 1635 1636 1637 1638 1639
        goto cleanup;

success:
    rv = 0;

cleanup:
1640
    if (rv < 0)
1641
        virNetMessageSaveError(rerr);
1642
    virTypedParamsFree(params, nparams);
A
ajia@redhat.com 已提交
1643 1644
    if (dom)
        virDomainFree(dom);
1645 1646 1647
    return rv;
}

R
Richard W.M. Jones 已提交
1648
static int
1649 1650
remoteDispatchDomainMemoryPeek(virNetServerPtr server ATTRIBUTE_UNUSED,
                               virNetServerClientPtr client ATTRIBUTE_UNUSED,
1651
                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
1652
                               virNetMessageErrorPtr rerr,
1653 1654
                               remote_domain_memory_peek_args *args,
                               remote_domain_memory_peek_ret *ret)
R
Richard W.M. Jones 已提交
1655
{
1656
    virDomainPtr dom = NULL;
R
Richard W.M. Jones 已提交
1657 1658 1659
    unsigned long long offset;
    size_t size;
    unsigned int flags;
1660
    int rv = -1;
1661 1662
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
R
Richard W.M. Jones 已提交
1663

1664
    if (!priv->conn) {
1665
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1666
        goto cleanup;
1667 1668
    }

1669
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1670
        goto cleanup;
R
Richard W.M. Jones 已提交
1671 1672 1673 1674 1675
    offset = args->offset;
    size = args->size;
    flags = args->flags;

    if (size > REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX) {
1676 1677
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("size > maximum buffer size"));
1678
        goto cleanup;
R
Richard W.M. Jones 已提交
1679 1680 1681
    }

    ret->buffer.buffer_len = size;
1682
    if (VIR_ALLOC_N(ret->buffer.buffer_val, size) < 0)
1683
        goto cleanup;
R
Richard W.M. Jones 已提交
1684

1685
    if (virDomainMemoryPeek(dom, offset, size,
1686
                            ret->buffer.buffer_val, flags) < 0)
1687
        goto cleanup;
R
Richard W.M. Jones 已提交
1688

1689 1690 1691 1692
    rv = 0;

cleanup:
    if (rv < 0) {
1693
        virNetMessageSaveError(rerr);
1694 1695 1696 1697 1698
        VIR_FREE(ret->buffer.buffer_val);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
R
Richard W.M. Jones 已提交
1699 1700
}

1701
static int
1702 1703
remoteDispatchDomainGetSecurityLabel(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client ATTRIBUTE_UNUSED,
1704
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
1705
                                     virNetMessageErrorPtr rerr,
1706 1707
                                     remote_domain_get_security_label_args *args,
                                     remote_domain_get_security_label_ret *ret)
1708
{
1709 1710
    virDomainPtr dom = NULL;
    virSecurityLabelPtr seclabel = NULL;
1711
    int rv = -1;
1712 1713
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1714

1715
    if (!priv->conn) {
1716
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1717
        goto cleanup;
1718 1719
    }

1720
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1721 1722
        goto cleanup;

1723
    if (VIR_ALLOC(seclabel) < 0)
1724 1725 1726 1727 1728 1729
        goto cleanup;

    if (virDomainGetSecurityLabel(dom, seclabel) < 0)
        goto cleanup;

    ret->label.label_len = strlen(seclabel->label) + 1;
1730
    if (VIR_ALLOC_N(ret->label.label_val, ret->label.label_len) < 0)
1731
        goto cleanup;
1732 1733
    strcpy(ret->label.label_val, seclabel->label);
    ret->enforcing = seclabel->enforcing;
1734

1735 1736 1737 1738
    rv = 0;

cleanup:
    if (rv < 0)
1739
        virNetMessageSaveError(rerr);
1740 1741 1742
    if (dom)
        virDomainFree(dom);
    VIR_FREE(seclabel);
1743
    return rv;
1744 1745
}

M
Marcelo Cerri 已提交
1746 1747 1748 1749 1750 1751 1752 1753 1754 1755
static int
remoteDispatchDomainGetSecurityLabelList(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_domain_get_security_label_list_args *args,
                                         remote_domain_get_security_label_list_ret *ret)
{
    virDomainPtr dom = NULL;
    virSecurityLabelPtr seclabels = NULL;
1756 1757
    int len, rv = -1;
    size_t i;
M
Marcelo Cerri 已提交
1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((len = virDomainGetSecurityLabelList(dom, &seclabels)) < 0) {
        ret->ret = len;
        ret->labels.labels_len = 0;
        ret->labels.labels_val = NULL;
        goto done;
    }

1776
    if (VIR_ALLOC_N(ret->labels.labels_val, len) < 0)
M
Marcelo Cerri 已提交
1777 1778 1779 1780 1781
        goto cleanup;

    for (i = 0; i < len; i++) {
        size_t label_len = strlen(seclabels[i].label) + 1;
        remote_domain_get_security_label_ret *cur = &ret->labels.labels_val[i];
1782
        if (VIR_ALLOC_N(cur->label.label_val, label_len) < 0)
M
Marcelo Cerri 已提交
1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805
            goto cleanup;
        if (virStrcpy(cur->label.label_val, seclabels[i].label, label_len) == NULL) {
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("failed to copy security label"));
            goto cleanup;
        }
        cur->label.label_len = label_len;
        cur->enforcing = seclabels[i].enforcing;
    }
    ret->labels.labels_len = ret->ret = len;

done:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    VIR_FREE(seclabels);
    return rv;
}

1806
static int
1807 1808
remoteDispatchNodeGetSecurityModel(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
1809
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
1810
                                   virNetMessageErrorPtr rerr,
1811
                                   remote_node_get_security_model_ret *ret)
1812
{
1813
    virSecurityModel secmodel;
1814
    int rv = -1;
1815 1816
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1817

1818
    if (!priv->conn) {
1819
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1820
        goto cleanup;
1821 1822
    }

1823
    memset(&secmodel, 0, sizeof(secmodel));
1824
    if (virNodeGetSecurityModel(priv->conn, &secmodel) < 0)
1825 1826 1827
        goto cleanup;

    ret->model.model_len = strlen(secmodel.model) + 1;
1828
    if (VIR_ALLOC_N(ret->model.model_val, ret->model.model_len) < 0)
1829 1830 1831 1832
        goto cleanup;
    strcpy(ret->model.model_val, secmodel.model);

    ret->doi.doi_len = strlen(secmodel.doi) + 1;
1833
    if (VIR_ALLOC_N(ret->doi.doi_val, ret->doi.doi_len) < 0)
1834
        goto cleanup;
1835
    strcpy(ret->doi.doi_val, secmodel.doi);
1836

1837 1838 1839 1840
    rv = 0;

cleanup:
    if (rv < 0)
1841
        virNetMessageSaveError(rerr);
1842
    return rv;
1843 1844
}

1845
static int
1846 1847
remoteDispatchDomainGetVcpuPinInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
1848
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
1849
                                   virNetMessageErrorPtr rerr,
E
Eric Blake 已提交
1850 1851
                                   remote_domain_get_vcpu_pin_info_args *args,
                                   remote_domain_get_vcpu_pin_info_ret *ret)
1852 1853 1854 1855 1856
{
    virDomainPtr dom = NULL;
    unsigned char *cpumaps = NULL;
    int num;
    int rv = -1;
1857 1858
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1859

1860
    if (!priv->conn) {
1861
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1862 1863 1864
        goto cleanup;
    }

1865
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1866 1867 1868
        goto cleanup;

    if (args->ncpumaps > REMOTE_VCPUINFO_MAX) {
1869
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("ncpumaps > REMOTE_VCPUINFO_MAX"));
1870 1871 1872 1873 1874
        goto cleanup;
    }

    if (INT_MULTIPLY_OVERFLOW(args->ncpumaps, args->maplen) ||
        args->ncpumaps * args->maplen > REMOTE_CPUMAPS_MAX) {
1875
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo * maplen > REMOTE_CPUMAPS_MAX"));
1876 1877 1878 1879 1880 1881
        goto cleanup;
    }

    /* Allocate buffers to take the results. */
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->ncpumaps * args->maplen) < 0)
1882
        goto cleanup;
1883

E
Eric Blake 已提交
1884
    if ((num = virDomainGetVcpuPinInfo(dom,
1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897
                                       args->ncpumaps,
                                       cpumaps,
                                       args->maplen,
                                       args->flags)) < 0)
        goto cleanup;

    ret->num = num;
    /* Don't need to allocate/copy the cpumaps if we make the reasonable
     * assumption that unsigned char and char are the same size.
     * Note that remoteDispatchClientRequest will free.
     */
    ret->cpumaps.cpumaps_len = args->ncpumaps * args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973
    cpumaps = NULL;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    VIR_FREE(cpumaps);
    if (dom)
        virDomainFree(dom);
    return rv;
}

static int
remoteDispatchDomainPinEmulator(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client,
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_pin_emulator_args *args)
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainPinEmulator(dom,
                             (unsigned char *) args->cpumap.cpumap_val,
                             args->cpumap.cpumap_len,
                             args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
remoteDispatchDomainGetEmulatorPinInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_get_emulator_pin_info_args *args,
                                       remote_domain_get_emulator_pin_info_ret *ret)
{
    virDomainPtr dom = NULL;
    unsigned char *cpumaps = NULL;
    int r;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    /* Allocate buffers to take the results */
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->maplen) < 0)
1974
        goto cleanup;
1975 1976 1977 1978 1979 1980 1981 1982 1983 1984

    if ((r = virDomainGetEmulatorPinInfo(dom,
                                         cpumaps,
                                         args->maplen,
                                         args->flags)) < 0)
        goto cleanup;

    ret->ret = r;
    ret->cpumaps.cpumaps_len = args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
1985 1986 1987 1988 1989 1990
    cpumaps = NULL;

    rv = 0;

cleanup:
    if (rv < 0)
1991
        virNetMessageSaveError(rerr);
1992 1993 1994 1995 1996 1997
    VIR_FREE(cpumaps);
    if (dom)
        virDomainFree(dom);
    return rv;
}

1998
static int
1999 2000
remoteDispatchDomainGetVcpus(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
2001
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
2002
                             virNetMessageErrorPtr rerr,
2003 2004
                             remote_domain_get_vcpus_args *args,
                             remote_domain_get_vcpus_ret *ret)
2005
{
2006
    virDomainPtr dom = NULL;
2007 2008
    virVcpuInfoPtr info = NULL;
    unsigned char *cpumaps = NULL;
2009 2010
    int info_len;
    size_t i;
2011
    int rv = -1;
2012 2013
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2014

2015
    if (!priv->conn) {
2016
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2017
        goto cleanup;
2018 2019
    }

2020
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2021
        goto cleanup;
2022

2023
    if (args->maxinfo > REMOTE_VCPUINFO_MAX) {
2024
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo > REMOTE_VCPUINFO_MAX"));
2025
        goto cleanup;
2026
    }
2027

2028 2029
    if (INT_MULTIPLY_OVERFLOW(args->maxinfo, args->maplen) ||
        args->maxinfo * args->maplen > REMOTE_CPUMAPS_MAX) {
2030
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo * maplen > REMOTE_CPUMAPS_MAX"));
2031 2032 2033 2034 2035
        goto cleanup;
    }

    /* Allocate buffers to take the results. */
    if (VIR_ALLOC_N(info, args->maxinfo) < 0)
2036
        goto cleanup;
2037 2038
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->maxinfo * args->maplen) < 0)
2039
        goto cleanup;
2040 2041 2042 2043 2044 2045 2046 2047 2048

    if ((info_len = virDomainGetVcpus(dom,
                                      info, args->maxinfo,
                                      cpumaps, args->maplen)) < 0)
        goto cleanup;

    /* Allocate the return buffer for info. */
    ret->info.info_len = info_len;
    if (VIR_ALLOC_N(ret->info.info_val, info_len) < 0)
2049
        goto cleanup;
2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066

    for (i = 0; i < info_len; ++i) {
        ret->info.info_val[i].number = info[i].number;
        ret->info.info_val[i].state = info[i].state;
        ret->info.info_val[i].cpu_time = info[i].cpuTime;
        ret->info.info_val[i].cpu = info[i].cpu;
    }

    /* Don't need to allocate/copy the cpumaps if we make the reasonable
     * assumption that unsigned char and char are the same size.
     * Note that remoteDispatchClientRequest will free.
     */
    ret->cpumaps.cpumaps_len = args->maxinfo * args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
    cpumaps = NULL;

    rv = 0;
2067 2068

cleanup:
2069
    if (rv < 0) {
2070
        virNetMessageSaveError(rerr);
2071 2072 2073 2074
        VIR_FREE(ret->info.info_val);
    }
    VIR_FREE(cpumaps);
    VIR_FREE(info);
2075 2076 2077
    if (dom)
        virDomainFree(dom);
    return rv;
2078 2079 2080
}

static int
2081 2082
remoteDispatchDomainMigratePrepare(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
2083
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
2084
                                   virNetMessageErrorPtr rerr,
2085 2086
                                   remote_domain_migrate_prepare_args *args,
                                   remote_domain_migrate_prepare_ret *ret)
2087
{
2088 2089 2090 2091 2092
    char *cookie = NULL;
    int cookielen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
2093
    int rv = -1;
2094 2095
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2096

2097
    if (!priv->conn) {
2098
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2099
        goto cleanup;
2100 2101
    }

2102 2103 2104 2105
    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;

    /* Wacky world of XDR ... */
2106
    if (VIR_ALLOC(uri_out) < 0)
2107
        goto cleanup;
2108

2109
    if (virDomainMigratePrepare(priv->conn, &cookie, &cookielen,
2110 2111
                                uri_in, uri_out,
                                args->flags, dname, args->resource) < 0)
2112
        goto cleanup;
2113

2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124
    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie.cookie_len = cookielen;
    ret->cookie.cookie_val = cookie;
    if (*uri_out == NULL) {
        ret->uri_out = NULL;
    } else {
        ret->uri_out = uri_out;
        uri_out = NULL;
    }
2125

2126
    rv = 0;
2127

2128 2129
cleanup:
    if (rv < 0)
2130
        virNetMessageSaveError(rerr);
2131
    VIR_FREE(uri_out);
2132
    return rv;
2133 2134
}

2135
static int
2136 2137
remoteDispatchDomainMigratePrepare2(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
2138
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
2139
                                    virNetMessageErrorPtr rerr,
2140 2141
                                    remote_domain_migrate_prepare2_args *args,
                                    remote_domain_migrate_prepare2_ret *ret)
2142
{
2143 2144 2145 2146 2147
    char *cookie = NULL;
    int cookielen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
2148
    int rv = -1;
2149 2150
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2151

2152
    if (!priv->conn) {
2153
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2154
        goto cleanup;
2155 2156
    }

2157 2158
    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;
2159

2160
    /* Wacky world of XDR ... */
2161
    if (VIR_ALLOC(uri_out) < 0)
2162
        goto cleanup;
2163

2164
    if (virDomainMigratePrepare2(priv->conn, &cookie, &cookielen,
2165 2166 2167
                                 uri_in, uri_out,
                                 args->flags, dname, args->resource,
                                 args->dom_xml) < 0)
2168
        goto cleanup;
2169

2170 2171 2172 2173 2174 2175
    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie.cookie_len = cookielen;
    ret->cookie.cookie_val = cookie;
    ret->uri_out = *uri_out == NULL ? NULL : uri_out;
2176

2177 2178 2179 2180
    rv = 0;

cleanup:
    if (rv < 0)
2181
        virNetMessageSaveError(rerr);
2182
    return rv;
2183 2184
}

C
Chris Lalancette 已提交
2185
static int
2186 2187
remoteDispatchDomainGetMemoryParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client ATTRIBUTE_UNUSED,
2188
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
2189 2190 2191
                                        virNetMessageErrorPtr rerr,
                                        remote_domain_get_memory_parameters_args *args,
                                        remote_domain_get_memory_parameters_ret *ret)
C
Chris Lalancette 已提交
2192
{
2193
    virDomainPtr dom = NULL;
2194
    virTypedParameterPtr params = NULL;
2195
    int nparams = 0;
2196
    unsigned int flags;
2197
    int rv = -1;
2198 2199
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2200

2201
    if (!priv->conn) {
2202
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2203
        goto cleanup;
2204
    }
C
Chris Lalancette 已提交
2205

2206
    flags = args->flags;
C
Chris Lalancette 已提交
2207

2208
    if (args->nparams > REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX) {
2209
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2210 2211
        goto cleanup;
    }
2212
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2213
        goto cleanup;
2214
    nparams = args->nparams;
C
Chris Lalancette 已提交
2215

2216
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2217
        goto cleanup;
C
Chris Lalancette 已提交
2218

2219
    if (virDomainGetMemoryParameters(dom, params, &nparams, flags) < 0)
2220
        goto cleanup;
C
Chris Lalancette 已提交
2221

2222 2223 2224 2225 2226 2227
    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
2228 2229
    }

2230
    if (remoteSerializeTypedParameters(params, nparams,
2231
                                       &ret->params.params_val,
2232 2233
                                       &ret->params.params_len,
                                       args->flags) < 0)
2234
        goto cleanup;
2235

2236
success:
2237 2238 2239
    rv = 0;

cleanup:
2240
    if (rv < 0)
2241
        virNetMessageSaveError(rerr);
2242
    virTypedParamsFree(params, nparams);
2243 2244 2245
    if (dom)
        virDomainFree(dom);
    return rv;
2246 2247
}

2248 2249 2250 2251 2252 2253 2254 2255 2256 2257
static int
remoteDispatchDomainGetNumaParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_domain_get_numa_parameters_args *args,
                                      remote_domain_get_numa_parameters_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
2258
    int nparams = 0;
2259 2260 2261 2262 2263 2264
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2265
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2266 2267 2268 2269 2270
        goto cleanup;
    }

    flags = args->flags;

2271
    if (args->nparams > REMOTE_DOMAIN_NUMA_PARAMETERS_MAX) {
2272
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2273 2274
        goto cleanup;
    }
2275
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2276
        goto cleanup;
2277
    nparams = args->nparams;
2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetNumaParameters(dom, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
2305
    virTypedParamsFree(params, nparams);
2306 2307 2308 2309 2310
    if (dom)
        virDomainFree(dom);
    return rv;
}

2311
static int
2312 2313
remoteDispatchDomainGetBlkioParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client ATTRIBUTE_UNUSED,
2314
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
2315 2316 2317
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_get_blkio_parameters_args *args,
                                       remote_domain_get_blkio_parameters_ret *ret)
2318
{
2319
    virDomainPtr dom = NULL;
2320
    virTypedParameterPtr params = NULL;
2321
    int nparams = 0;
2322
    unsigned int flags;
2323
    int rv = -1;
2324 2325
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2326

2327
    if (!priv->conn) {
2328
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2329
        goto cleanup;
2330 2331
    }

2332 2333
    flags = args->flags;

2334
    if (args->nparams > REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX) {
2335
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2336
        goto cleanup;
2337
    }
2338
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2339
        goto cleanup;
2340
    nparams = args->nparams;
2341

2342
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2343
        goto cleanup;
2344

2345
    if (virDomainGetBlkioParameters(dom, params, &nparams, flags) < 0)
2346
        goto cleanup;
2347

2348 2349 2350 2351 2352 2353 2354 2355
    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

2356
    if (remoteSerializeTypedParameters(params, nparams,
2357
                                       &ret->params.params_val,
2358 2359
                                       &ret->params.params_len,
                                       args->flags) < 0)
2360
        goto cleanup;
2361

2362 2363
success:
    rv = 0;
2364

2365
cleanup:
2366
    if (rv < 0)
2367
        virNetMessageSaveError(rerr);
2368
    virTypedParamsFree(params, nparams);
2369 2370 2371
    if (dom)
        virDomainFree(dom);
    return rv;
2372 2373
}

2374
static int
2375 2376
remoteDispatchNodeGetCPUStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                              virNetServerClientPtr client ATTRIBUTE_UNUSED,
2377
                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
2378 2379 2380
                              virNetMessageErrorPtr rerr,
                              remote_node_get_cpu_stats_args *args,
                              remote_node_get_cpu_stats_ret *ret)
2381
{
2382
    virNodeCPUStatsPtr params = NULL;
2383
    size_t i;
2384
    int cpuNum = args->cpuNum;
2385
    int nparams = 0;
2386 2387
    unsigned int flags;
    int rv = -1;
2388 2389
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2390

2391
    if (!priv->conn) {
2392
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2393 2394 2395 2396 2397
        goto cleanup;
    }

    flags = args->flags;

2398
    if (args->nparams > REMOTE_NODE_CPU_STATS_MAX) {
2399
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2400 2401
        goto cleanup;
    }
2402
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2403
        goto cleanup;
2404
    nparams = args->nparams;
2405

2406
    if (virNodeGetCPUStats(priv->conn, cpuNum, params, &nparams, flags) < 0)
2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419
        goto cleanup;

    /* In this case, we need to send back the number of stats
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the memory parameters. */
    ret->params.params_len = nparams;
    if (VIR_ALLOC_N(ret->params.params_val, nparams) < 0)
2420
        goto cleanup;
2421 2422 2423

    for (i = 0; i < nparams; ++i) {
        /* remoteDispatchClientRequest will free this: */
2424 2425
        if (VIR_STRDUP(ret->params.params_val[i].field, params[i].field) < 0)
            goto cleanup;
2426 2427 2428 2429 2430 2431 2432

        ret->params.params_val[i].value = params[i].value;
    }

success:
    rv = 0;

2433 2434
cleanup:
    if (rv < 0) {
2435
        virNetMessageSaveError(rerr);
2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446
        if (ret->params.params_val) {
            for (i = 0; i < nparams; i++)
                VIR_FREE(ret->params.params_val[i].field);
            VIR_FREE(ret->params.params_val);
        }
    }
    VIR_FREE(params);
    return rv;
}

static int
2447 2448
remoteDispatchNodeGetMemoryStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
2449
                                 virNetMessagePtr msg ATTRIBUTE_UNUSED,
2450 2451 2452
                                 virNetMessageErrorPtr rerr,
                                 remote_node_get_memory_stats_args *args,
                                 remote_node_get_memory_stats_ret *ret)
2453
{
2454
    virNodeMemoryStatsPtr params = NULL;
2455
    size_t i;
2456
    int cellNum = args->cellNum;
2457
    int nparams = 0;
2458 2459
    unsigned int flags;
    int rv = -1;
2460 2461
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2462

2463
    if (!priv->conn) {
2464
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2465 2466 2467 2468 2469
        goto cleanup;
    }

    flags = args->flags;

2470
    if (args->nparams > REMOTE_NODE_MEMORY_STATS_MAX) {
2471
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2472 2473
        goto cleanup;
    }
2474
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2475
        goto cleanup;
2476
    nparams = args->nparams;
2477

2478
    if (virNodeGetMemoryStats(priv->conn, cellNum, params, &nparams, flags) < 0)
2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the memory parameters. */
    ret->params.params_len = nparams;
    if (VIR_ALLOC_N(ret->params.params_val, nparams) < 0)
2492
        goto cleanup;
2493 2494 2495

    for (i = 0; i < nparams; ++i) {
        /* remoteDispatchClientRequest will free this: */
2496 2497
        if (VIR_STRDUP(ret->params.params_val[i].field, params[i].field) < 0)
            goto cleanup;
2498 2499 2500 2501 2502 2503 2504

        ret->params.params_val[i].value = params[i].value;
    }

success:
    rv = 0;

2505 2506
cleanup:
    if (rv < 0) {
2507
        virNetMessageSaveError(rerr);
2508 2509 2510 2511 2512 2513 2514 2515 2516 2517
        if (ret->params.params_val) {
            for (i = 0; i < nparams; i++)
                VIR_FREE(ret->params.params_val[i].field);
            VIR_FREE(ret->params.params_val);
        }
    }
    VIR_FREE(params);
    return rv;
}

2518 2519 2520
static int
remoteDispatchDomainGetBlockJobInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
2521
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_get_block_job_info_args *args,
                                    remote_domain_get_block_job_info_ret *ret)
{
    virDomainPtr dom = NULL;
    virDomainBlockJobInfo tmp;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2533
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    rv = virDomainGetBlockJobInfo(dom, args->path, &tmp, args->flags);
    if (rv <= 0)
        goto cleanup;

    ret->type = tmp.type;
    ret->bandwidth = tmp.bandwidth;
    ret->cur = tmp.cur;
    ret->end = tmp.end;
    ret->found = 1;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569
static int
remoteDispatchDomainGetBlockIoTune(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                   virNetMessagePtr hdr ATTRIBUTE_UNUSED,
                                   virNetMessageErrorPtr rerr,
                                   remote_domain_get_block_io_tune_args *args,
                                   remote_domain_get_block_io_tune_ret *ret)
{
    virDomainPtr dom = NULL;
    int rv = -1;
    virTypedParameterPtr params = NULL;
2570
    int nparams = 0;
2571 2572 2573 2574
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2575
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2576 2577 2578
        goto cleanup;
    }

2579
    if (args->nparams > REMOTE_DOMAIN_BLOCK_IO_TUNE_PARAMETERS_MAX) {
2580
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2581 2582 2583
        goto cleanup;
    }

2584
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2585
        goto cleanup;
2586
    nparams = args->nparams;
2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetBlockIoTune(dom, args->disk ? *args->disk : NULL,
                                params, &nparams, args->flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the block I/O tuning parameters. */
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
2616
    virTypedParamsFree(params, nparams);
2617 2618 2619 2620
    if (dom)
        virDomainFree(dom);
    return rv;
}
2621

D
Daniel Veillard 已提交
2622 2623
/*-------------------------------------------------------------*/

2624
static int
2625
remoteDispatchAuthList(virNetServerPtr server,
2626
                       virNetServerClientPtr client,
2627
                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
2628
                       virNetMessageErrorPtr rerr,
2629
                       remote_auth_list_ret *ret)
2630
{
2631
    int rv = -1;
2632 2633
    int auth = virNetServerClientGetAuth(client);
    uid_t callerUid;
2634
    gid_t callerGid;
2635
    pid_t callerPid;
2636
    unsigned long long timestamp;
2637 2638 2639 2640 2641 2642

    /* If the client is root then we want to bypass the
     * policykit auth to avoid root being denied if
     * some piece of polkit isn't present/running
     */
    if (auth == VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
2643
        if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
2644
                                              &callerPid, &timestamp) < 0) {
2645 2646 2647 2648
            /* Don't do anything on error - it'll be validated at next
             * phase of auth anyway */
            virResetLastError();
        } else if (callerUid == 0) {
2649 2650
            char *ident;
            if (virAsprintf(&ident, "pid:%lld,uid:%d",
2651
                            (long long) callerPid, (int) callerUid) < 0)
J
Jim Fehlig 已提交
2652 2653
                goto cleanup;
            VIR_INFO("Bypass polkit auth for privileged client %s", ident);
2654
            virNetServerClientSetAuth(client, 0);
2655
            virNetServerTrackCompletedAuth(server);
2656
            auth = VIR_NET_SERVER_SERVICE_AUTH_NONE;
J
Jim Fehlig 已提交
2657
            VIR_FREE(ident);
2658 2659
        }
    }
2660

2661
    ret->types.types_len = 1;
2662
    if (VIR_ALLOC_N(ret->types.types_val, ret->types.types_len) < 0)
2663
        goto cleanup;
2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677

    switch (auth) {
    case VIR_NET_SERVER_SERVICE_AUTH_NONE:
        ret->types.types_val[0] = REMOTE_AUTH_NONE;
        break;
    case VIR_NET_SERVER_SERVICE_AUTH_POLKIT:
        ret->types.types_val[0] = REMOTE_AUTH_POLKIT;
        break;
    case VIR_NET_SERVER_SERVICE_AUTH_SASL:
        ret->types.types_val[0] = REMOTE_AUTH_SASL;
        break;
    default:
        ret->types.types_val[0] = REMOTE_AUTH_NONE;
    }
2678

2679 2680 2681 2682
    rv = 0;

cleanup:
    if (rv < 0)
2683
        virNetMessageSaveError(rerr);
2684
    return rv;
2685 2686 2687
}


2688
#ifdef WITH_SASL
2689 2690
/*
 * Initializes the SASL session in prepare for authentication
2691
 * and gives the client a list of allowed mechanisms to choose
2692 2693
 */
static int
2694 2695
remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client,
2696
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
2697
                           virNetMessageErrorPtr rerr,
2698
                           remote_auth_sasl_init_ret *ret)
2699
{
2700 2701 2702
    virNetSASLSessionPtr sasl = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2703

2704
    virMutexLock(&priv->lock);
2705

2706 2707 2708
    VIR_DEBUG("Initialize SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl != NULL) {
2709
        VIR_ERROR(_("client tried invalid SASL init request"));
2710
        goto authfail;
2711 2712
    }

2713 2714 2715 2716 2717
    sasl = virNetSASLSessionNewServer(saslCtxt,
                                      "libvirt",
                                      virNetServerClientLocalAddrString(client),
                                      virNetServerClientRemoteAddrString(client));
    if (!sasl)
2718
        goto authfail;
2719

2720
# if WITH_GNUTLS
2721
    /* Inform SASL that we've got an external SSF layer from TLS */
2722 2723 2724 2725
    if (virNetServerClientHasTLSSession(client)) {
        int ssf;

        if ((ssf = virNetServerClientGetTLSKeySize(client)) < 0)
2726
            goto authfail;
2727 2728 2729 2730 2731

        ssf *= 8; /* key size is bytes, sasl wants bits */

        VIR_DEBUG("Setting external SSF %d", ssf);
        if (virNetSASLSessionExtKeySize(sasl, ssf) < 0)
2732
            goto authfail;
2733
    }
2734
# endif
2735

2736
    if (virNetServerClientIsSecure(client))
2737
        /* If we've got TLS or UNIX domain sock, we don't care about SSF */
2738 2739
        virNetSASLSessionSecProps(sasl, 0, 0, true);
    else
2740
        /* Plain TCP, better get an SSF layer */
2741 2742 2743 2744
        virNetSASLSessionSecProps(sasl,
                                  56,  /* Good enough to require kerberos */
                                  100000,  /* Arbitrary big number */
                                  false); /* No anonymous */
2745

2746
    if (!(ret->mechlist = virNetSASLSessionListMechanisms(sasl)))
2747
        goto authfail;
2748
    VIR_DEBUG("Available mechanisms for client: '%s'", ret->mechlist);
2749

2750 2751
    priv->sasl = sasl;
    virMutexUnlock(&priv->lock);
2752
    return 0;
2753 2754

authfail:
2755
    virResetLastError();
2756 2757
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
2758
    virNetMessageSaveError(rerr);
2759 2760 2761
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2762
    virObjectUnref(sasl);
2763
    virMutexUnlock(&priv->lock);
2764
    return -1;
2765 2766
}

2767
/*
2768 2769
 * Returns 0 if ok, -1 on error, -2 if rejected
 */
2770
static int
2771 2772
remoteSASLFinish(virNetServerPtr server,
                 virNetServerClientPtr client)
2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787
{
    const char *identity;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    int ssf;

    /* TLS or UNIX domain sockets trivially OK */
    if (!virNetServerClientIsSecure(client)) {
        if ((ssf = virNetSASLSessionGetKeySize(priv->sasl)) < 0)
            goto error;

        VIR_DEBUG("negotiated an SSF of %d", ssf);
        if (ssf < 56) { /* 56 is good for Kerberos */
            VIR_ERROR(_("negotiated SSF %d was not strong enough"), ssf);
            return -2;
        }
2788
    }
2789 2790

    if (!(identity = virNetSASLSessionGetIdentity(priv->sasl)))
2791
        return -2;
2792

2793 2794
    if (!virNetSASLContextCheckIdentity(saslCtxt, identity))
        return -2;
2795

2796
    virNetServerClientSetAuth(client, 0);
2797
    virNetServerTrackCompletedAuth(server);
2798
    virNetServerClientSetSASLSession(client, priv->sasl);
2799

2800
    VIR_DEBUG("Authentication successful %d", virNetServerClientGetFD(client));
2801

2802 2803 2804
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2805

2806
    virObjectUnref(priv->sasl);
2807
    priv->sasl = NULL;
2808

2809
    return 0;
2810

2811 2812 2813
error:
    return -1;
}
2814

2815 2816 2817 2818
/*
 * This starts the SASL authentication negotiation.
 */
static int
2819
remoteDispatchAuthSaslStart(virNetServerPtr server,
2820
                            virNetServerClientPtr client,
2821
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
2822
                            virNetMessageErrorPtr rerr,
2823 2824
                            remote_auth_sasl_start_args *args,
                            remote_auth_sasl_start_ret *ret)
2825 2826
{
    const char *serverout;
2827
    size_t serveroutlen;
2828
    int err;
2829 2830 2831
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2832
    const char *identity;
2833

2834
    virMutexLock(&priv->lock);
2835

2836 2837 2838
    VIR_DEBUG("Start SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl == NULL) {
2839
        VIR_ERROR(_("client tried invalid SASL start request"));
2840
        goto authfail;
2841 2842
    }

2843 2844
    VIR_DEBUG("Using SASL mechanism %s. Data %d bytes, nil: %d",
              args->mech, args->data.data_len, args->nil);
2845 2846 2847 2848 2849 2850 2851 2852 2853
    err = virNetSASLSessionServerStart(priv->sasl,
                                       args->mech,
                                       /* NB, distinction of NULL vs "" is *critical* in SASL */
                                       args->nil ? NULL : args->data.data_val,
                                       args->data.data_len,
                                       &serverout,
                                       &serveroutlen);
    if (err != VIR_NET_SASL_COMPLETE &&
        err != VIR_NET_SASL_CONTINUE)
2854
        goto authfail;
2855

2856
    if (serveroutlen > REMOTE_AUTH_SASL_DATA_MAX) {
2857
        VIR_ERROR(_("sasl start reply data too long %d"), (int)serveroutlen);
2858
        goto authfail;
2859 2860 2861 2862
    }

    /* NB, distinction of NULL vs "" is *critical* in SASL */
    if (serverout) {
2863 2864
        if (VIR_ALLOC_N(ret->data.data_val, serveroutlen) < 0)
            goto authfail;
2865 2866 2867 2868 2869 2870 2871
        memcpy(ret->data.data_val, serverout, serveroutlen);
    } else {
        ret->data.data_val = NULL;
    }
    ret->nil = serverout ? 0 : 1;
    ret->data.data_len = serveroutlen;

2872
    VIR_DEBUG("SASL return data %d bytes, nil; %d", ret->data.data_len, ret->nil);
2873
    if (err == VIR_NET_SASL_CONTINUE) {
2874 2875
        ret->complete = 0;
    } else {
2876
        /* Check username whitelist ACL */
2877
        if ((err = remoteSASLFinish(server, client)) < 0) {
2878 2879 2880 2881 2882
            if (err == -2)
                goto authdeny;
            else
                goto authfail;
        }
2883

2884 2885 2886
        ret->complete = 1;
    }

2887
    virMutexUnlock(&priv->lock);
2888
    return 0;
2889 2890

authfail:
2891 2892 2893
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2894 2895 2896
    goto error;

authdeny:
2897
    identity = virNetSASLSessionGetIdentity(priv->sasl);
2898 2899 2900
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2901 2902
    goto error;

2903
error:
2904
    virObjectUnref(priv->sasl);
2905 2906
    priv->sasl = NULL;
    virResetLastError();
2907 2908
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
2909 2910 2911
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
2912
    return -1;
2913 2914 2915 2916
}


static int
2917
remoteDispatchAuthSaslStep(virNetServerPtr server,
2918
                           virNetServerClientPtr client,
2919
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
2920
                           virNetMessageErrorPtr rerr,
2921 2922
                           remote_auth_sasl_step_args *args,
                           remote_auth_sasl_step_ret *ret)
2923 2924
{
    const char *serverout;
2925
    size_t serveroutlen;
2926
    int err;
2927 2928 2929
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2930
    const char *identity;
2931

2932 2933 2934 2935 2936
    virMutexLock(&priv->lock);

    VIR_DEBUG("Step SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl == NULL) {
2937
        VIR_ERROR(_("client tried invalid SASL start request"));
2938
        goto authfail;
2939 2940
    }

2941
    VIR_DEBUG("Step using SASL Data %d bytes, nil: %d",
2942
              args->data.data_len, args->nil);
2943 2944 2945 2946 2947 2948 2949 2950
    err = virNetSASLSessionServerStep(priv->sasl,
                                      /* NB, distinction of NULL vs "" is *critical* in SASL */
                                      args->nil ? NULL : args->data.data_val,
                                      args->data.data_len,
                                      &serverout,
                                      &serveroutlen);
    if (err != VIR_NET_SASL_COMPLETE &&
        err != VIR_NET_SASL_CONTINUE)
2951
        goto authfail;
2952 2953

    if (serveroutlen > REMOTE_AUTH_SASL_DATA_MAX) {
2954
        VIR_ERROR(_("sasl step reply data too long %d"),
2955
                  (int)serveroutlen);
2956
        goto authfail;
2957 2958 2959 2960
    }

    /* NB, distinction of NULL vs "" is *critical* in SASL */
    if (serverout) {
2961 2962
        if (VIR_ALLOC_N(ret->data.data_val, serveroutlen) < 0)
            goto authfail;
2963 2964 2965 2966 2967 2968 2969
        memcpy(ret->data.data_val, serverout, serveroutlen);
    } else {
        ret->data.data_val = NULL;
    }
    ret->nil = serverout ? 0 : 1;
    ret->data.data_len = serveroutlen;

2970
    VIR_DEBUG("SASL return data %d bytes, nil; %d", ret->data.data_len, ret->nil);
2971
    if (err == VIR_NET_SASL_CONTINUE) {
2972 2973
        ret->complete = 0;
    } else {
2974
        /* Check username whitelist ACL */
2975
        if ((err = remoteSASLFinish(server, client)) < 0) {
2976 2977 2978 2979 2980
            if (err == -2)
                goto authdeny;
            else
                goto authfail;
        }
2981

2982 2983 2984
        ret->complete = 1;
    }

2985
    virMutexUnlock(&priv->lock);
2986
    return 0;
2987 2988

authfail:
2989 2990 2991
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2992 2993 2994
    goto error;

authdeny:
2995
    identity = virNetSASLSessionGetIdentity(priv->sasl);
2996 2997 2998
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2999 3000
    goto error;

3001
error:
3002
    virObjectUnref(priv->sasl);
3003 3004
    priv->sasl = NULL;
    virResetLastError();
3005 3006
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3007 3008 3009
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3010 3011
    return -1;
}
3012 3013 3014 3015
#else
static int
remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
3016
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
3017 3018 3019 3020
                           virNetMessageErrorPtr rerr,
                           remote_auth_sasl_init_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3021 3022
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3023 3024 3025 3026 3027 3028
    virNetMessageSaveError(rerr);
    return -1;
}
static int
remoteDispatchAuthSaslStart(virNetServerPtr server ATTRIBUTE_UNUSED,
                            virNetServerClientPtr client ATTRIBUTE_UNUSED,
3029
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
3030 3031 3032 3033 3034
                            virNetMessageErrorPtr rerr,
                            remote_auth_sasl_start_args *args ATTRIBUTE_UNUSED,
                            remote_auth_sasl_start_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3035 3036
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3037 3038 3039 3040 3041 3042
    virNetMessageSaveError(rerr);
    return -1;
}
static int
remoteDispatchAuthSaslStep(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
3043
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
3044 3045 3046 3047 3048
                           virNetMessageErrorPtr rerr,
                           remote_auth_sasl_step_args *args ATTRIBUTE_UNUSED,
                           remote_auth_sasl_step_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3049 3050
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3051 3052 3053 3054
    virNetMessageSaveError(rerr);
    return -1;
}
#endif
3055 3056 3057



3058
#if WITH_POLKIT1
3059
static int
3060
remoteDispatchAuthPolkit(virNetServerPtr server,
3061
                         virNetServerClientPtr client,
3062
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3063
                         virNetMessageErrorPtr rerr,
3064
                         remote_auth_polkit_ret *ret)
3065
{
3066
    pid_t callerPid = -1;
3067
    gid_t callerGid = -1;
3068
    uid_t callerUid = -1;
3069
    unsigned long long timestamp;
3070 3071
    const char *action;
    int status = -1;
3072
    char *ident = NULL;
3073
    bool authdismissed = 0;
3074
    char *pkout = NULL;
3075 3076
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3077
    virCommandPtr cmd = NULL;
3078
# ifndef PKCHECK_SUPPORTS_UID
3079
    static bool polkitInsecureWarned;
3080
# endif
3081

3082 3083
    virMutexLock(&priv->lock);
    action = virNetServerClientGetReadonly(client) ?
3084 3085 3086
        "org.libvirt.unix.monitor" :
        "org.libvirt.unix.manage";

3087
    cmd = virCommandNewArgList(PKCHECK_PATH, "--action-id", action, NULL);
3088
    virCommandSetOutputBuffer(cmd, &pkout);
3089
    virCommandSetErrorBuffer(cmd, &pkout);
3090

3091 3092
    VIR_DEBUG("Start PolicyKit auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
3093
        VIR_ERROR(_("client tried invalid PolicyKit init request"));
3094 3095 3096
        goto authfail;
    }

3097
    if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
3098
                                          &callerPid, &timestamp) < 0) {
3099 3100 3101
        goto authfail;
    }

3102 3103 3104 3105 3106 3107
    if (timestamp == 0) {
        VIR_WARN("Failing polkit auth due to missing client (pid=%lld) start time",
                 (long long)callerPid);
        goto authfail;
    }

3108 3109
    VIR_INFO("Checking PID %lld running as %d",
             (long long) callerPid, callerUid);
3110

3111
    virCommandAddArg(cmd, "--process");
3112

3113
# ifdef PKCHECK_SUPPORTS_UID
3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124
    virCommandAddArgFormat(cmd, "%lld,%llu,%lu",
                           (long long) callerPid,
                           timestamp,
                           (unsigned long) callerUid);
# else
    if (!polkitInsecureWarned) {
        VIR_WARN("No support for caller UID with pkcheck. "
                 "This deployment is known to be insecure.");
        polkitInsecureWarned = true;
    }
    virCommandAddArgFormat(cmd, "%lld,%llu", (long long) callerPid, timestamp);
3125
# endif
3126

3127
    virCommandAddArg(cmd, "--allow-user-interaction");
3128

3129
    if (virAsprintf(&ident, "pid:%lld,uid:%d",
3130
                    (long long) callerPid, callerUid) < 0)
3131 3132
        goto authfail;

3133
    if (virCommandRun(cmd, &status) < 0)
3134
        goto authfail;
3135

3136
    authdismissed = (pkout && strstr(pkout, "dismissed=true"));
3137
    if (status != 0) {
3138 3139 3140
        VIR_ERROR(_("Policy kit denied action %s from pid %lld, uid %d "
                    "with status %d"),
                  action, (long long) callerPid, callerUid, status);
3141
        goto authdeny;
3142
    }
3143 3144 3145
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3146 3147
    VIR_INFO("Policy allowed action %s from pid %lld, uid %d",
             action, (long long) callerPid, callerUid);
3148 3149
    ret->complete = 1;

3150
    virNetServerClientSetAuth(client, 0);
3151
    virNetServerTrackCompletedAuth(server);
3152
    virMutexUnlock(&priv->lock);
3153
    virCommandFree(cmd);
E
Eric Blake 已提交
3154
    VIR_FREE(pkout);
3155
    VIR_FREE(ident);
3156

3157 3158
    return 0;

3159
error:
3160 3161
    virCommandFree(cmd);
    VIR_FREE(ident);
3162
    virResetLastError();
3163

3164
    if (authdismissed) {
3165 3166
        virReportError(VIR_ERR_AUTH_CANCELLED, "%s",
                       _("authentication cancelled by user"));
3167 3168
    } else if (pkout && *pkout) {
        virReportError(VIR_ERR_AUTH_FAILED, _("polkit: %s"), pkout);
3169
    } else {
3170
        virReportError(VIR_ERR_AUTH_FAILED, "%s", _("authentication failed"));
3171
    }
3172 3173

    VIR_FREE(pkout);
3174 3175 3176 3177
    virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return -1;

3178
authfail:
3179 3180 3181
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_POLKIT);
3182 3183 3184
    goto error;

authdeny:
3185 3186
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
3187
          client, REMOTE_AUTH_POLKIT, ident);
3188
    goto error;
3189
}
3190
#elif WITH_POLKIT0
3191
static int
3192
remoteDispatchAuthPolkit(virNetServerPtr server,
3193
                         virNetServerClientPtr client,
3194
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3195
                         virNetMessageErrorPtr rerr,
3196
                         remote_auth_polkit_ret *ret)
3197 3198
{
    pid_t callerPid;
3199
    gid_t callerGid;
3200
    uid_t callerUid;
3201 3202 3203 3204 3205 3206
    PolKitCaller *pkcaller = NULL;
    PolKitAction *pkaction = NULL;
    PolKitContext *pkcontext = NULL;
    PolKitError *pkerr = NULL;
    PolKitResult pkresult;
    DBusError err;
3207
    const char *action;
3208
    char *ident = NULL;
3209 3210
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3211
    DBusConnection *sysbus;
J
Jim Fehlig 已提交
3212
    unsigned long long timestamp;
3213

J
Jim Fehlig 已提交
3214
    virMutexLock(&priv->lock);
3215

J
Jim Fehlig 已提交
3216
    action = virNetServerClientGetReadonly(client) ?
3217 3218
        "org.libvirt.unix.monitor" :
        "org.libvirt.unix.manage";
3219

3220
    VIR_DEBUG("Start PolicyKit auth %d", virNetServerClientGetFD(client));
J
Jim Fehlig 已提交
3221
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
3222
        VIR_ERROR(_("client tried invalid PolicyKit init request"));
3223
        goto authfail;
3224 3225
    }

3226
    if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
J
Jim Fehlig 已提交
3227
                                          &callerPid, &timestamp) < 0) {
3228
        VIR_ERROR(_("cannot get peer socket identity"));
3229
        goto authfail;
3230 3231
    }

3232
    if (virAsprintf(&ident, "pid:%lld,uid:%d",
3233
                    (long long) callerPid, callerUid) < 0)
3234 3235
        goto authfail;

3236 3237 3238
    if (!(sysbus = virDBusGetSystemBus()))
        goto authfail;

3239 3240
    VIR_INFO("Checking PID %lld running as %d",
             (long long) callerPid, callerUid);
3241
    dbus_error_init(&err);
3242
    if (!(pkcaller = polkit_caller_new_from_pid(sysbus,
3243
                                                callerPid, &err))) {
3244
        VIR_ERROR(_("Failed to lookup policy kit caller: %s"), err.message);
3245
        dbus_error_free(&err);
3246
        goto authfail;
3247
    }
3248

3249
    if (!(pkaction = polkit_action_new())) {
3250
        char ebuf[1024];
3251
        VIR_ERROR(_("Failed to create polkit action %s"),
3252
                  virStrerror(errno, ebuf, sizeof(ebuf)));
3253
        polkit_caller_unref(pkcaller);
3254
        goto authfail;
3255 3256 3257 3258 3259
    }
    polkit_action_set_action_id(pkaction, action);

    if (!(pkcontext = polkit_context_new()) ||
        !polkit_context_init(pkcontext, &pkerr)) {
3260
        char ebuf[1024];
3261
        VIR_ERROR(_("Failed to create polkit context %s"),
3262
                  (pkerr ? polkit_error_get_error_message(pkerr)
3263
                   : virStrerror(errno, ebuf, sizeof(ebuf))));
3264 3265 3266 3267 3268
        if (pkerr)
            polkit_error_free(pkerr);
        polkit_caller_unref(pkcaller);
        polkit_action_unref(pkaction);
        dbus_error_free(&err);
3269
        goto authfail;
3270
    }
3271

3272
# if HAVE_POLKIT_CONTEXT_IS_CALLER_AUTHORIZED
3273 3274 3275 3276 3277 3278
    pkresult = polkit_context_is_caller_authorized(pkcontext,
                                                   pkaction,
                                                   pkcaller,
                                                   0,
                                                   &pkerr);
    if (pkerr && polkit_error_is_set(pkerr)) {
3279 3280 3281
        VIR_ERROR(_("Policy kit failed to check authorization %d %s"),
                  polkit_error_get_error_code(pkerr),
                  polkit_error_get_error_message(pkerr));
3282
        goto authfail;
3283
    }
3284
# else
3285 3286 3287
    pkresult = polkit_context_can_caller_do_action(pkcontext,
                                                   pkaction,
                                                   pkcaller);
3288
# endif
3289 3290 3291 3292
    polkit_context_unref(pkcontext);
    polkit_caller_unref(pkcaller);
    polkit_action_unref(pkaction);
    if (pkresult != POLKIT_RESULT_YES) {
3293 3294
        VIR_ERROR(_("Policy kit denied action %s from pid %lld, uid %d, result: %s"),
                  action, (long long) callerPid, callerUid,
3295
                  polkit_result_to_string_representation(pkresult));
3296
        goto authdeny;
3297
    }
3298 3299 3300
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3301 3302
    VIR_INFO("Policy allowed action %s from pid %lld, uid %d, result %s",
             action, (long long) callerPid, callerUid,
3303 3304
             polkit_result_to_string_representation(pkresult));
    ret->complete = 1;
3305

3306
    virNetServerClientSetAuth(client, 0);
3307
    virNetServerTrackCompletedAuth(server);
J
Jim Fehlig 已提交
3308
    virMutexUnlock(&priv->lock);
3309
    VIR_FREE(ident);
3310
    return 0;
3311

3312
error:
3313
    VIR_FREE(ident);
3314
    virResetLastError();
3315 3316
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3317
    virNetMessageSaveError(rerr);
J
Jim Fehlig 已提交
3318
    virMutexUnlock(&priv->lock);
3319 3320
    return -1;

3321
authfail:
3322 3323 3324
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_POLKIT);
3325
    goto error;
3326

3327
authdeny:
3328 3329 3330
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3331
    goto error;
3332 3333
}

3334
#else /* !WITH_POLKIT0 & !HAVE_POLKIT1*/
3335 3336

static int
3337
remoteDispatchAuthPolkit(virNetServerPtr server ATTRIBUTE_UNUSED,
J
Jiri Denemark 已提交
3338
                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
3339
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3340
                         virNetMessageErrorPtr rerr,
3341
                         remote_auth_polkit_ret *ret ATTRIBUTE_UNUSED)
3342
{
3343
    VIR_ERROR(_("client tried unsupported PolicyKit init request"));
3344 3345
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3346
    virNetMessageSaveError(rerr);
3347 3348
    return -1;
}
3349
#endif /* WITH_POLKIT1 */
3350 3351


3352 3353 3354
/***************************************************************
 *     NODE INFO APIS
 **************************************************************/
3355

3356
static int
3357 3358
remoteDispatchNodeDeviceGetParent(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client ATTRIBUTE_UNUSED,
3359
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
3360
                                  virNetMessageErrorPtr rerr,
3361 3362
                                  remote_node_device_get_parent_args *args,
                                  remote_node_device_get_parent_ret *ret)
3363
{
3364 3365
    virNodeDevicePtr dev = NULL;
    const char *parent = NULL;
3366
    int rv = -1;
3367 3368
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3369

3370
    if (!priv->conn) {
3371
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3372
        goto cleanup;
3373 3374
    }

3375
    if (!(dev = virNodeDeviceLookupByName(priv->conn, args->name)))
3376 3377
        goto cleanup;

3378 3379 3380 3381 3382 3383 3384
    parent = virNodeDeviceGetParent(dev);

    if (parent == NULL) {
        ret->parent = NULL;
    } else {
        /* remoteDispatchClientRequest will free this. */
        char **parent_p;
3385
        if (VIR_ALLOC(parent_p) < 0)
3386
            goto cleanup;
3387
        if (VIR_STRDUP(*parent_p, parent) < 0) {
3388 3389 3390 3391 3392 3393
            VIR_FREE(parent_p);
            goto cleanup;
        }
        ret->parent = parent_p;
    }

3394 3395 3396 3397
    rv = 0;

cleanup:
    if (rv < 0)
3398
        virNetMessageSaveError(rerr);
3399 3400
    if (dev)
        virNodeDeviceFree(dev);
3401
    return rv;
3402 3403
}

3404 3405 3406 3407 3408

/***************************
 * Register / deregister events
 ***************************/
static int
3409
remoteDispatchConnectDomainEventRegister(virNetServerPtr server ATTRIBUTE_UNUSED,
3410
                                         virNetServerClientPtr client,
3411 3412 3413
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                         remote_connect_domain_event_register_ret *ret ATTRIBUTE_UNUSED)
O
Osier Yang 已提交
3414
{
3415
    int callbackID;
3416
    int rv = -1;
3417 3418
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
3419 3420
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
O
Osier Yang 已提交
3421

3422
    if (!priv->conn) {
3423
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3424
        goto cleanup;
3425 3426
    }

3427 3428
    virMutexLock(&priv->lock);

3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = VIR_DOMAIN_EVENT_ID_LIFECYCLE;
    callback->callbackID = -1;
3440
    callback->legacy = true;
3441 3442 3443 3444
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
3445
        goto cleanup;
O
Osier Yang 已提交
3446

3447
    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
3448 3449 3450
                                                       NULL,
                                                       VIR_DOMAIN_EVENT_ID_LIFECYCLE,
                                                       VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventLifecycle),
3451 3452 3453 3454 3455
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
3456
        goto cleanup;
3457
    }
O
Osier Yang 已提交
3458

3459
    ref->callbackID = callbackID;
3460

3461 3462 3463
    rv = 0;

cleanup:
3464
    VIR_FREE(callback);
3465
    if (rv < 0)
3466 3467
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3468
    return rv;
O
Osier Yang 已提交
3469 3470
}

3471
static int
3472
remoteDispatchConnectDomainEventDeregister(virNetServerPtr server ATTRIBUTE_UNUSED,
3473
                                           virNetServerClientPtr client,
3474 3475 3476
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                           virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                           remote_connect_domain_event_deregister_ret *ret ATTRIBUTE_UNUSED)
3477
{
3478
    int callbackID = -1;
3479
    int rv = -1;
3480
    size_t i;
3481 3482
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3483

3484
    if (!priv->conn) {
3485
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3486
        goto cleanup;
3487 3488
    }

3489 3490
    virMutexLock(&priv->lock);

3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501
    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->eventID == VIR_DOMAIN_EVENT_ID_LIFECYCLE) {
            callbackID = priv->domainEventCallbacks[i]->callbackID;
            break;
        }
    }

    if (callbackID < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event %d not registered"),
                       VIR_DOMAIN_EVENT_ID_LIFECYCLE);
3502
        goto cleanup;
3503
    }
3504

3505
    if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
3506
        goto cleanup;
3507

3508 3509
    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);
3510

3511 3512 3513
    rv = 0;

cleanup:
3514
    if (rv < 0)
3515 3516
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3517 3518 3519 3520
    return rv;
}

static void
3521
remoteDispatchObjectEventSend(virNetServerClientPtr client,
3522
                              virNetServerProgramPtr program,
3523 3524 3525 3526
                              int procnr,
                              xdrproc_t proc,
                              void *data)
{
3527
    virNetMessagePtr msg;
3528

3529
    if (!(msg = virNetMessageNew(false)))
3530
        goto cleanup;
3531

3532 3533 3534 3535 3536 3537
    msg->header.prog = virNetServerProgramGetID(program);
    msg->header.vers = virNetServerProgramGetVersion(program);
    msg->header.proc = procnr;
    msg->header.type = VIR_NET_MESSAGE;
    msg->header.serial = 1;
    msg->header.status = VIR_NET_OK;
3538

3539
    if (virNetMessageEncodeHeader(msg) < 0)
3540 3541
        goto cleanup;

3542 3543
    if (virNetMessageEncodePayload(msg, proc, data) < 0)
        goto cleanup;
3544

3545 3546
    VIR_DEBUG("Queue event %d %zu", procnr, msg->bufferLength);
    virNetServerClientSendMessage(client, msg);
3547

3548
    xdr_free(proc, data);
3549 3550 3551
    return;

cleanup:
3552
    virNetMessageFree(msg);
3553
    xdr_free(proc, data);
3554 3555
}

3556
static int
3557 3558
remoteDispatchSecretGetValue(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
3559
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
3560
                             virNetMessageErrorPtr rerr,
3561 3562
                             remote_secret_get_value_args *args,
                             remote_secret_get_value_ret *ret)
3563
{
3564 3565 3566
    virSecretPtr secret = NULL;
    size_t value_size;
    unsigned char *value;
3567
    int rv = -1;
3568 3569
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3570

3571
    if (!priv->conn) {
3572
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3573
        goto cleanup;
3574 3575
    }

3576
    if (!(secret = get_nonnull_secret(priv->conn, args->secret)))
3577
        goto cleanup;
3578

3579
    if (!(value = virSecretGetValue(secret, &value_size, args->flags)))
3580
        goto cleanup;
3581

3582 3583 3584
    ret->value.value_len = value_size;
    ret->value.value_val = (char *)value;

3585 3586 3587 3588
    rv = 0;

cleanup:
    if (rv < 0)
3589
        virNetMessageSaveError(rerr);
3590 3591
    if (secret)
        virSecretFree(secret);
3592
    return rv;
3593 3594
}

3595
static int
3596 3597
remoteDispatchDomainGetState(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
3598
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
3599
                             virNetMessageErrorPtr rerr,
3600 3601 3602 3603 3604
                             remote_domain_get_state_args *args,
                             remote_domain_get_state_ret *ret)
{
    virDomainPtr dom = NULL;
    int rv = -1;
3605 3606
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3607

3608
    if (!priv->conn) {
3609
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3610 3611 3612
        goto cleanup;
    }

3613
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3614 3615 3616 3617 3618 3619 3620 3621 3622
        goto cleanup;

    if (virDomainGetState(dom, &ret->state, &ret->reason, args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
3623
        virNetMessageSaveError(rerr);
3624 3625 3626 3627 3628
    if (dom)
        virDomainFree(dom);
    return rv;
}

3629 3630 3631 3632 3633 3634

/* Due to back-compat reasons, two RPC calls map to the same libvirt
 * API of virConnectDomainEventRegisterAny.  A client should only use
 * the new call if they have probed
 * VIR_DRV_SUPPORTS_FEATURE(VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK),
 * and must not mix the two styles.  */
3635
static int
3636
remoteDispatchConnectDomainEventRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
3637
                                            virNetServerClientPtr client,
3638 3639 3640
                                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                            virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                            remote_connect_domain_event_register_any_args *args)
3641 3642
{
    int callbackID;
3643
    int rv = -1;
3644 3645
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
3646 3647
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3648

3649
    if (!priv->conn) {
3650
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3651
        goto cleanup;
3652 3653
    }

3654 3655
    virMutexLock(&priv->lock);

3656 3657 3658 3659
    /* We intentionally do not use VIR_DOMAIN_EVENT_ID_LAST here; any
     * new domain events added after this point should only use the
     * modern callback style of RPC.  */
    if (args->eventID > VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED ||
3660
        args->eventID < 0) {
3661 3662
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
3663
        goto cleanup;
3664 3665
    }

3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
3677
    callback->legacy = true;
3678 3679 3680 3681
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
3682
        goto cleanup;
3683

3684
    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
3685 3686 3687
                                                       NULL,
                                                       args->eventID,
                                                       domainEventCallbacks[args->eventID],
3688 3689 3690 3691 3692
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
3693
        goto cleanup;
3694
    }
3695

3696
    ref->callbackID = callbackID;
3697

3698 3699 3700
    rv = 0;

cleanup:
3701
    VIR_FREE(callback);
3702
    if (rv < 0)
3703 3704
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3705
    return rv;
3706 3707 3708
}


3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735
static int
remoteDispatchConnectDomainEventCallbackRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                    virNetServerClientPtr client,
                                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                    virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                                    remote_connect_domain_event_callback_register_any_args *args,
                                                    remote_connect_domain_event_callback_register_any_ret *ret)
{
    int callbackID;
    int rv = -1;
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

    if (args->dom &&
        !(dom = get_nonnull_domain(priv->conn, *args->dom)))
        goto cleanup;

3736
    if (args->eventID >= VIR_DOMAIN_EVENT_ID_LAST || args->eventID < 0) {
3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
        goto cleanup;
    }

    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
        goto cleanup;

    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
                                                       dom,
                                                       args->eventID,
                                                       domainEventCallbacks[args->eventID],
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
        goto cleanup;
    }

    ref->callbackID = callbackID;
    ret->callbackID = callbackID;

    rv = 0;

cleanup:
    VIR_FREE(callback);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    virMutexUnlock(&priv->lock);
    return rv;
}


3787
static int
3788
remoteDispatchConnectDomainEventDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
3789
                                              virNetServerClientPtr client,
3790 3791 3792
                                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                              virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                              remote_connect_domain_event_deregister_any_args *args)
3793 3794
{
    int callbackID = -1;
3795
    int rv = -1;
3796
    size_t i;
3797 3798
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3799

3800
    if (!priv->conn) {
3801
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3802
        goto cleanup;
3803 3804
    }

3805 3806
    virMutexLock(&priv->lock);

3807 3808 3809 3810
    /* We intentionally do not use VIR_DOMAIN_EVENT_ID_LAST here; any
     * new domain events added after this point should only use the
     * modern callback style of RPC.  */
    if (args->eventID > VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED ||
3811
        args->eventID < 0) {
3812 3813
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
3814
        goto cleanup;
3815 3816
    }

3817 3818 3819 3820 3821 3822
    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->eventID == args->eventID) {
            callbackID = priv->domainEventCallbacks[i]->callbackID;
            break;
        }
    }
3823
    if (callbackID < 0) {
3824 3825
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event %d not registered"), args->eventID);
3826
        goto cleanup;
3827 3828
    }

3829
    if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
3830
        goto cleanup;
3831

3832 3833
    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);
3834

3835 3836 3837 3838
    rv = 0;

cleanup:
    if (rv < 0)
3839 3840
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3841
    return rv;
3842 3843
}

3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890

static int
remoteDispatchConnectDomainEventCallbackDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                      virNetServerClientPtr client,
                                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                      virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                                      remote_connect_domain_event_callback_deregister_any_args *args)
{
    int rv = -1;
    size_t i;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->callbackID == args->callbackID)
            break;
    }
    if (i == priv->ndomainEventCallbacks) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event callback %d not registered"),
                       args->callbackID);
        goto cleanup;
    }

    if (virConnectDomainEventDeregisterAny(priv->conn, args->callbackID) < 0)
        goto cleanup;

    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return rv;
}


C
Chris Lalancette 已提交
3891
static int
3892 3893 3894 3895 3896 3897
qemuDispatchDomainMonitorCommand(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                 virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                 virNetMessageErrorPtr rerr,
                                 qemu_domain_monitor_command_args *args,
                                 qemu_domain_monitor_command_ret *ret)
C
Chris Lalancette 已提交
3898
{
3899
    virDomainPtr dom = NULL;
3900
    int rv = -1;
3901 3902
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
C
Chris Lalancette 已提交
3903

3904
    if (!priv->conn) {
3905
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3906
        goto cleanup;
3907 3908
    }

3909
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3910
        goto cleanup;
C
Chris Lalancette 已提交
3911

3912
    if (virDomainQemuMonitorCommand(dom, args->cmd, &ret->result,
3913
                                    args->flags) < 0)
3914
        goto cleanup;
C
Chris Lalancette 已提交
3915

3916
    rv = 0;
C
Chris Lalancette 已提交
3917

3918 3919
cleanup:
    if (rv < 0)
3920
        virNetMessageSaveError(rerr);
3921 3922
    if (dom)
        virDomainFree(dom);
3923
    return rv;
C
Chris Lalancette 已提交
3924 3925
}

3926

3927
static int
3928 3929
remoteDispatchDomainMigrateBegin3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client ATTRIBUTE_UNUSED,
3930
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
3931
                                  virNetMessageErrorPtr rerr,
3932 3933 3934 3935 3936 3937
                                  remote_domain_migrate_begin3_args *args,
                                  remote_domain_migrate_begin3_ret *ret)
{
    char *xml = NULL;
    virDomainPtr dom = NULL;
    char *dname;
3938
    char *xmlin;
3939 3940 3941
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
3942 3943
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3944

3945
    if (!priv->conn) {
3946
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3947 3948 3949
        goto cleanup;
    }

3950
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3951 3952
        goto cleanup;

3953
    xmlin = args->xmlin == NULL ? NULL : *args->xmlin;
3954 3955
    dname = args->dname == NULL ? NULL : *args->dname;

3956
    if (!(xml = virDomainMigrateBegin3(dom, xmlin,
3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971
                                       &cookieout, &cookieoutlen,
                                       args->flags, dname, args->resource)))
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie and
     * the xml string if there is one.
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->xml = xml;

    rv = 0;

cleanup:
    if (rv < 0)
3972
        virNetMessageSaveError(rerr);
3973 3974 3975 3976 3977 3978 3979
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
3980 3981
remoteDispatchDomainMigratePrepare3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
3982
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
3983
                                    virNetMessageErrorPtr rerr,
3984 3985 3986 3987 3988 3989 3990 3991 3992
                                    remote_domain_migrate_prepare3_args *args,
                                    remote_domain_migrate_prepare3_ret *ret)
{
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
    int rv = -1;
3993 3994
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3995

3996
    if (!priv->conn) {
3997
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3998 3999 4000 4001 4002 4003 4004
        goto cleanup;
    }

    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;

    /* Wacky world of XDR ... */
4005
    if (VIR_ALLOC(uri_out) < 0)
4006 4007
        goto cleanup;

4008
    if (virDomainMigratePrepare3(priv->conn,
4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 &cookieout, &cookieoutlen,
                                 uri_in, uri_out,
                                 args->flags, dname, args->resource,
                                 args->dom_xml) < 0)
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->uri_out = *uri_out == NULL ? NULL : uri_out;

    rv = 0;

cleanup:
    if (rv < 0) {
4028
        virNetMessageSaveError(rerr);
4029 4030 4031 4032 4033
        VIR_FREE(uri_out);
    }
    return rv;
}

4034

4035
static int
4036 4037
remoteDispatchDomainMigratePerform3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
4038
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
4039
                                    virNetMessageErrorPtr rerr,
4040 4041 4042 4043
                                    remote_domain_migrate_perform3_args *args,
                                    remote_domain_migrate_perform3_ret *ret)
{
    virDomainPtr dom = NULL;
4044
    char *xmlin;
4045
    char *dname;
4046 4047
    char *uri;
    char *dconnuri;
4048 4049 4050
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
4051 4052
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4053

4054
    if (!priv->conn) {
4055
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4056 4057 4058
        goto cleanup;
    }

4059
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
4060 4061
        goto cleanup;

4062
    xmlin = args->xmlin == NULL ? NULL : *args->xmlin;
4063
    dname = args->dname == NULL ? NULL : *args->dname;
4064 4065
    uri = args->uri == NULL ? NULL : *args->uri;
    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;
4066

4067
    if (virDomainMigratePerform3(dom, xmlin,
4068 4069 4070
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 &cookieout, &cookieoutlen,
4071
                                 dconnuri, uri,
4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083
                                 args->flags, dname, args->resource) < 0)
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    if (rv < 0)
4084
        virNetMessageSaveError(rerr);
4085 4086 4087 4088 4089 4090 4091
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
4092 4093
remoteDispatchDomainMigrateFinish3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
4094
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
4095
                                   virNetMessageErrorPtr rerr,
4096 4097 4098 4099 4100 4101
                                   remote_domain_migrate_finish3_args *args,
                                   remote_domain_migrate_finish3_ret *ret)
{
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
4102 4103
    char *uri;
    char *dconnuri;
4104
    int rv = -1;
4105 4106
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4107

4108
    if (!priv->conn) {
4109
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4110 4111 4112
        goto cleanup;
    }

4113 4114 4115
    uri = args->uri == NULL ? NULL : *args->uri;
    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;

4116
    if (!(dom = virDomainMigrateFinish3(priv->conn, args->dname,
4117 4118 4119 4120 4121 4122
                                        args->cookie_in.cookie_in_val,
                                        args->cookie_in.cookie_in_len,
                                        &cookieout, &cookieoutlen,
                                        dconnuri, uri,
                                        args->flags,
                                        args->cancelled)))
4123 4124
        goto cleanup;

4125
    make_nonnull_domain(&ret->dom, dom);
4126 4127 4128 4129 4130 4131 4132 4133 4134 4135

    /* remoteDispatchClientRequest will free cookie
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    if (rv < 0) {
4136
        virNetMessageSaveError(rerr);
4137 4138 4139 4140 4141 4142 4143 4144 4145
        VIR_FREE(cookieout);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
4146 4147
remoteDispatchDomainMigrateConfirm3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
4148
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
4149 4150
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_migrate_confirm3_args *args)
4151 4152 4153
{
    virDomainPtr dom = NULL;
    int rv = -1;
4154 4155
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4156

4157
    if (!priv->conn) {
4158
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4159 4160 4161
        goto cleanup;
    }

4162
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174
        goto cleanup;

    if (virDomainMigrateConfirm3(dom,
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 args->flags, args->cancelled) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
4175
        virNetMessageSaveError(rerr);
4176 4177 4178 4179 4180 4181
    if (dom)
        virDomainFree(dom);
    return rv;
}


4182 4183 4184 4185 4186 4187
static int remoteDispatchConnectSupportsFeature(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client,
                                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                virNetMessageErrorPtr rerr,
                                                remote_connect_supports_feature_args *args,
                                                remote_connect_supports_feature_ret *ret)
4188 4189 4190 4191 4192 4193
{
    int rv = -1;
    int supported;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

4194 4195 4196 4197 4198 4199 4200 4201 4202 4203
    /* This feature is checked before opening the connection, thus we must
     * check it first.
     */
    if (args->feature == VIR_DRV_FEATURE_PROGRAM_KEEPALIVE) {
        if (virNetServerClientStartKeepAlive(client) < 0)
            goto cleanup;
        supported = 1;
        goto done;
    }

4204
    if (!priv->conn) {
4205
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4206 4207 4208 4209 4210
        goto cleanup;
    }

    switch (args->feature) {
    case VIR_DRV_FEATURE_FD_PASSING:
4211
    case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK:
4212 4213 4214 4215
        supported = 1;
        break;

    default:
4216
        if ((supported = virConnectSupportsFeature(priv->conn, args->feature)) < 0)
4217 4218 4219 4220
            goto cleanup;
        break;
    }

4221
done:
4222 4223 4224 4225 4226 4227 4228 4229 4230 4231
    ret->supported = supported;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    return rv;
}


4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245
static int
remoteDispatchDomainOpenGraphics(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                 virNetMessagePtr msg,
                                 virNetMessageErrorPtr rerr,
                                 remote_domain_open_graphics_args *args)
{
    virDomainPtr dom = NULL;
    int rv = -1;
    int fd = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4246
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((fd = virNetMessageDupFD(msg, 0)) < 0)
        goto cleanup;

    if (virDomainOpenGraphics(dom,
                              args->idx,
                              fd,
                              args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    VIR_FORCE_CLOSE(fd);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283
static int
remoteDispatchDomainGetInterfaceParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                           virNetMessageErrorPtr rerr,
                                           remote_domain_get_interface_parameters_args *args,
                                           remote_domain_get_interface_parameters_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    const char *device = args->device;
4284
    int nparams = 0;
4285 4286 4287 4288 4289 4290
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4291
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4292 4293 4294 4295 4296
        goto cleanup;
    }

    flags = args->flags;

4297
    if (args->nparams > REMOTE_DOMAIN_INTERFACE_PARAMETERS_MAX) {
4298
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
4299 4300
        goto cleanup;
    }
4301
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
4302
        goto cleanup;
4303
    nparams = args->nparams;
4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetInterfaceParameters(dom, device, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
4331
    virTypedParamsFree(params, nparams);
4332 4333 4334 4335
    if (dom)
        virDomainFree(dom);
    return rv;
}
4336

4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352
static int
remoteDispatchDomainGetCPUStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                virNetMessagePtr hdr ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_get_cpu_stats_args *args,
                                remote_domain_get_cpu_stats_ret *ret)
{
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv;
    virTypedParameterPtr params = NULL;
    int rv = -1;
    int percpu_len = 0;

    priv = virNetServerClientGetPrivateData(client);
    if (!priv->conn) {
4353
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4354 4355 4356 4357
        goto cleanup;
    }

    if (args->nparams > REMOTE_NODE_CPU_STATS_MAX) {
4358
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
4359 4360 4361
        goto cleanup;
    }
    if (args->ncpus > REMOTE_DOMAIN_GET_CPU_STATS_NCPUS_MAX) {
4362
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("ncpus too large"));
4363 4364 4365 4366
        goto cleanup;
    }

    if (args->nparams > 0 &&
4367
        VIR_ALLOC_N(params, args->ncpus * args->nparams) < 0)
4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390
        goto cleanup;

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    percpu_len = virDomainGetCPUStats(dom, params, args->nparams,
                                      args->start_cpu, args->ncpus,
                                      args->flags);
    if (percpu_len < 0)
        goto cleanup;
    /* If nparams == 0, the function returns a single value */
    if (args->nparams == 0)
        goto success;

    if (remoteSerializeTypedParameters(params, args->nparams * args->ncpus,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;
    ret->nparams = percpu_len;
4391
    if (args->nparams && !(args->flags & VIR_TYPED_PARAM_STRING_OKAY)) {
4392
        size_t i;
4393 4394 4395 4396 4397 4398

        for (i = 0; i < percpu_len; i++) {
            if (params[i].type == VIR_TYPED_PARAM_STRING)
                ret->nparams--;
        }
    }
4399 4400 4401 4402

cleanup:
    if (rv < 0)
         virNetMessageSaveError(rerr);
4403
    virTypedParamsFree(params, args->ncpus * args->nparams);
4404 4405 4406 4407 4408
    if (dom)
        virDomainFree(dom);
    return rv;
}

4409 4410 4411 4412 4413 4414 4415
static int
remoteDispatchDomainGetDiskErrors(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client,
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                  virNetMessageErrorPtr rerr,
                                  remote_domain_get_disk_errors_args *args,
                                  remote_domain_get_disk_errors_ret *ret)
4416 4417 4418 4419
{
    int rv = -1;
    virDomainPtr dom = NULL;
    virDomainDiskErrorPtr errors = NULL;
4420
    int len = 0;
4421 4422 4423 4424
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4425
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4426 4427 4428 4429 4430 4431 4432
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (args->maxerrors > REMOTE_DOMAIN_DISK_ERRORS_MAX) {
4433 4434
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("maxerrors too large"));
4435 4436 4437 4438
        goto cleanup;
    }

    if (args->maxerrors &&
4439
        VIR_ALLOC_N(errors, args->maxerrors) < 0)
4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461
        goto cleanup;

    if ((len = virDomainGetDiskErrors(dom, errors,
                                      args->maxerrors,
                                      args->flags)) < 0)
        goto cleanup;

    ret->nerrors = len;
    if (errors &&
        remoteSerializeDomainDiskErrors(errors, len,
                                        &ret->errors.errors_val,
                                        &ret->errors.errors_len) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    if (errors) {
4462
        size_t i;
4463 4464 4465 4466 4467 4468 4469
        for (i = 0; i < len; i++)
            VIR_FREE(errors[i].disk);
    }
    VIR_FREE(errors);
    return rv;
}

4470 4471 4472 4473 4474 4475 4476 4477 4478 4479
static int
remoteDispatchDomainListAllSnapshots(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client,
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                     virNetMessageErrorPtr rerr,
                                     remote_domain_list_all_snapshots_args *args,
                                     remote_domain_list_all_snapshots_ret *ret)
{
    virDomainSnapshotPtr *snaps = NULL;
    int nsnaps = 0;
4480
    size_t i;
4481 4482 4483 4484 4485
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;

    if (!priv->conn) {
4486
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((nsnaps = virDomainListAllSnapshots(dom,
                                            args->need_results ? &snaps : NULL,
                                            args->flags)) < 0)
        goto cleanup;

4498 4499 4500 4501 4502 4503 4504
    if (nsnaps > REMOTE_DOMAIN_SNAPSHOT_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domain snapshots '%d' for limit '%d'"),
                       nsnaps, REMOTE_DOMAIN_SNAPSHOT_LIST_MAX);
        goto cleanup;
    }

4505
    if (snaps && nsnaps) {
4506
        if (VIR_ALLOC_N(ret->snapshots.snapshots_val, nsnaps) < 0)
4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544
            goto cleanup;

        ret->snapshots.snapshots_len = nsnaps;

        for (i = 0; i < nsnaps; i++)
            make_nonnull_domain_snapshot(ret->snapshots.snapshots_val + i,
                                         snaps[i]);
    } else {
        ret->snapshots.snapshots_len = 0;
        ret->snapshots.snapshots_val = NULL;
    }

    ret->ret = nsnaps;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    if (snaps) {
        for (i = 0; i < nsnaps; i++)
            virDomainSnapshotFree(snaps[i]);
        VIR_FREE(snaps);
    }
    return rv;
}

static int
remoteDispatchDomainSnapshotListAllChildren(virNetServerPtr server ATTRIBUTE_UNUSED,
                                            virNetServerClientPtr client,
                                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                            virNetMessageErrorPtr rerr,
                                            remote_domain_snapshot_list_all_children_args *args,
                                            remote_domain_snapshot_list_all_children_ret *ret)
{
    virDomainSnapshotPtr *snaps = NULL;
    int nsnaps = 0;
4545
    size_t i;
4546 4547 4548 4549 4550 4551
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;
    virDomainSnapshotPtr snapshot = NULL;

    if (!priv->conn) {
4552
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->snapshot.dom)))
        goto cleanup;

    if (!(snapshot = get_nonnull_domain_snapshot(dom, args->snapshot)))
        goto cleanup;

    if ((nsnaps = virDomainSnapshotListAllChildren(snapshot,
                                                   args->need_results ? &snaps : NULL,
                                                   args->flags)) < 0)
        goto cleanup;

4567 4568 4569 4570 4571 4572 4573
    if (nsnaps > REMOTE_DOMAIN_SNAPSHOT_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domain snapshots '%d' for limit '%d'"),
                       nsnaps, REMOTE_DOMAIN_SNAPSHOT_LIST_MAX);
        goto cleanup;
    }

4574
    if (snaps && nsnaps) {
4575
        if (VIR_ALLOC_N(ret->snapshots.snapshots_val, nsnaps) < 0)
4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605
            goto cleanup;

        ret->snapshots.snapshots_len = nsnaps;

        for (i = 0; i < nsnaps; i++)
            make_nonnull_domain_snapshot(ret->snapshots.snapshots_val + i,
                                         snaps[i]);
    } else {
        ret->snapshots.snapshots_len = 0;
        ret->snapshots.snapshots_val = NULL;
    }

    ret->ret = nsnaps;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (snapshot)
        virDomainSnapshotFree(snapshot);
    if (dom)
        virDomainFree(dom);
    if (snaps) {
        for (i = 0; i < nsnaps; i++)
            virDomainSnapshotFree(snaps[i]);
        VIR_FREE(snaps);
    }
    return rv;
}

4606 4607 4608 4609 4610 4611 4612 4613 4614 4615
static int
remoteDispatchConnectListAllStoragePools(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_connect_list_all_storage_pools_args *args,
                                         remote_connect_list_all_storage_pools_ret *ret)
{
    virStoragePoolPtr *pools = NULL;
    int npools = 0;
4616
    size_t i;
4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((npools = virConnectListAllStoragePools(priv->conn,
                                                args->need_results ? &pools : NULL,
                                                args->flags)) < 0)
        goto cleanup;

4630 4631 4632 4633 4634 4635 4636
    if (npools > REMOTE_STORAGE_POOL_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many storage pools '%d' for limit '%d'"),
                       npools, REMOTE_STORAGE_POOL_LIST_MAX);
        goto cleanup;
    }

4637
    if (pools && npools) {
4638
        if (VIR_ALLOC_N(ret->pools.pools_val, npools) < 0)
4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664
            goto cleanup;

        ret->pools.pools_len = npools;

        for (i = 0; i < npools; i++)
            make_nonnull_storage_pool(ret->pools.pools_val + i, pools[i]);
    } else {
        ret->pools.pools_len = 0;
        ret->pools.pools_val = NULL;
    }

    ret->ret = npools;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (pools) {
        for (i = 0; i < npools; i++)
            virStoragePoolFree(pools[i]);
        VIR_FREE(pools);
    }
    return rv;
}

4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675
static int
remoteDispatchStoragePoolListAllVolumes(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_storage_pool_list_all_volumes_args *args,
                                        remote_storage_pool_list_all_volumes_ret *ret)
{
    virStorageVolPtr *vols = NULL;
    virStoragePoolPtr pool = NULL;
    int nvols = 0;
4676
    size_t i;
4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(pool = get_nonnull_storage_pool(priv->conn, args->pool)))
        goto cleanup;

    if ((nvols = virStoragePoolListAllVolumes(pool,
                                              args->need_results ? &vols : NULL,
                                              args->flags)) < 0)
        goto cleanup;

4693 4694 4695 4696 4697 4698 4699
    if (nvols > REMOTE_STORAGE_VOL_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many storage volumes '%d' for limit '%d'"),
                       nvols, REMOTE_STORAGE_VOL_LIST_MAX);
        goto cleanup;
    }

4700
    if (vols && nvols) {
4701
        if (VIR_ALLOC_N(ret->vols.vols_val, nvols) < 0)
4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724
            goto cleanup;

        ret->vols.vols_len = nvols;

        for (i = 0; i < nvols; i++)
            make_nonnull_storage_vol(ret->vols.vols_val + i, vols[i]);
    } else {
        ret->vols.vols_len = 0;
        ret->vols.vols_val = NULL;
    }

    ret->ret = nvols;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (vols) {
        for (i = 0; i < nvols; i++)
            virStorageVolFree(vols[i]);
        VIR_FREE(vols);
    }
4725 4726
    if (pool)
        virStoragePoolFree(pool);
4727 4728 4729
    return rv;
}

4730 4731 4732 4733 4734 4735 4736 4737 4738 4739
static int
remoteDispatchConnectListAllNetworks(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client,
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                     virNetMessageErrorPtr rerr,
                                     remote_connect_list_all_networks_args *args,
                                     remote_connect_list_all_networks_ret *ret)
{
    virNetworkPtr *nets = NULL;
    int nnets = 0;
4740
    size_t i;
4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nnets = virConnectListAllNetworks(priv->conn,
                                           args->need_results ? &nets : NULL,
                                           args->flags)) < 0)
        goto cleanup;

4754 4755 4756 4757 4758 4759 4760
    if (nnets > REMOTE_NETWORK_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many networks '%d' for limit '%d'"),
                       nnets, REMOTE_NETWORK_LIST_MAX);
        goto cleanup;
    }

4761
    if (nets && nnets) {
4762
        if (VIR_ALLOC_N(ret->nets.nets_val, nnets) < 0)
4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788
            goto cleanup;

        ret->nets.nets_len = nnets;

        for (i = 0; i < nnets; i++)
            make_nonnull_network(ret->nets.nets_val + i, nets[i]);
    } else {
        ret->nets.nets_len = 0;
        ret->nets.nets_val = NULL;
    }

    ret->ret = nnets;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (nets) {
        for (i = 0; i < nnets; i++)
            virNetworkFree(nets[i]);
        VIR_FREE(nets);
    }
    return rv;
}

4789 4790 4791 4792 4793 4794 4795 4796 4797 4798
static int
remoteDispatchConnectListAllInterfaces(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_connect_list_all_interfaces_args *args,
                                       remote_connect_list_all_interfaces_ret *ret)
{
    virInterfacePtr *ifaces = NULL;
    int nifaces = 0;
4799
    size_t i;
4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nifaces = virConnectListAllInterfaces(priv->conn,
                                               args->need_results ? &ifaces : NULL,
                                               args->flags)) < 0)
        goto cleanup;

4813 4814 4815 4816 4817 4818 4819
    if (nifaces > REMOTE_INTERFACE_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many interfaces '%d' for limit '%d'"),
                       nifaces, REMOTE_INTERFACE_LIST_MAX);
        goto cleanup;
    }

4820
    if (ifaces && nifaces) {
4821
        if (VIR_ALLOC_N(ret->ifaces.ifaces_val, nifaces) < 0)
4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847
            goto cleanup;

        ret->ifaces.ifaces_len = nifaces;

        for (i = 0; i < nifaces; i++)
            make_nonnull_interface(ret->ifaces.ifaces_val + i, ifaces[i]);
    } else {
        ret->ifaces.ifaces_len = 0;
        ret->ifaces.ifaces_val = NULL;
    }

    ret->ret = nifaces;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (ifaces) {
        for (i = 0; i < nifaces; i++)
            virInterfaceFree(ifaces[i]);
        VIR_FREE(ifaces);
    }
    return rv;
}

4848 4849 4850 4851 4852 4853 4854 4855 4856 4857
static int
remoteDispatchConnectListAllNodeDevices(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_connect_list_all_node_devices_args *args,
                                        remote_connect_list_all_node_devices_ret *ret)
{
    virNodeDevicePtr *devices = NULL;
    int ndevices = 0;
4858
    size_t i;
4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((ndevices = virConnectListAllNodeDevices(priv->conn,
                                                 args->need_results ? &devices : NULL,
                                                 args->flags)) < 0)
        goto cleanup;

4872 4873 4874 4875 4876 4877 4878
    if (ndevices > REMOTE_NODE_DEVICE_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many node devices '%d' for limit '%d'"),
                       ndevices, REMOTE_NODE_DEVICE_LIST_MAX);
        goto cleanup;
    }

4879
    if (devices && ndevices) {
4880
        if (VIR_ALLOC_N(ret->devices.devices_val, ndevices) < 0)
4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905
            goto cleanup;

        ret->devices.devices_len = ndevices;

        for (i = 0; i < ndevices; i++)
            make_nonnull_node_device(ret->devices.devices_val + i, devices[i]);
    } else {
        ret->devices.devices_len = 0;
        ret->devices.devices_val = NULL;
    }

    ret->ret = ndevices;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (devices) {
        for (i = 0; i < ndevices; i++)
            virNodeDeviceFree(devices[i]);
        VIR_FREE(devices);
    }
    return rv;
}
4906

4907 4908 4909 4910 4911 4912 4913 4914 4915 4916
static int
remoteDispatchConnectListAllNWFilters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_connect_list_all_nwfilters_args *args,
                                      remote_connect_list_all_nwfilters_ret *ret)
{
    virNWFilterPtr *filters = NULL;
    int nfilters = 0;
4917
    size_t i;
4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nfilters = virConnectListAllNWFilters(priv->conn,
                                               args->need_results ? &filters : NULL,
                                               args->flags)) < 0)
        goto cleanup;

4931 4932 4933 4934 4935 4936 4937
    if (nfilters > REMOTE_NWFILTER_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many network filters '%d' for limit '%d'"),
                       nfilters, REMOTE_NWFILTER_LIST_MAX);
        goto cleanup;
    }

4938
    if (filters && nfilters) {
4939
        if (VIR_ALLOC_N(ret->filters.filters_val, nfilters) < 0)
4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965
            goto cleanup;

        ret->filters.filters_len = nfilters;

        for (i = 0; i < nfilters; i++)
            make_nonnull_nwfilter(ret->filters.filters_val + i, filters[i]);
    } else {
        ret->filters.filters_len = 0;
        ret->filters.filters_val = NULL;
    }

    ret->ret = nfilters;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (filters) {
        for (i = 0; i < nfilters; i++)
            virNWFilterFree(filters[i]);
        VIR_FREE(filters);
    }
    return rv;
}

4966 4967 4968 4969 4970 4971 4972 4973 4974 4975
static int
remoteDispatchConnectListAllSecrets(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client,
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                    virNetMessageErrorPtr rerr,
                                    remote_connect_list_all_secrets_args *args,
                                    remote_connect_list_all_secrets_ret *ret)
{
    virSecretPtr *secrets = NULL;
    int nsecrets = 0;
4976
    size_t i;
4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nsecrets = virConnectListAllSecrets(priv->conn,
                                             args->need_results ? &secrets : NULL,
                                             args->flags)) < 0)
        goto cleanup;

4990 4991 4992 4993 4994 4995 4996
    if (nsecrets > REMOTE_SECRET_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many secrets '%d' for limit '%d'"),
                       nsecrets, REMOTE_SECRET_LIST_MAX);
        goto cleanup;
    }

4997
    if (secrets && nsecrets) {
4998
        if (VIR_ALLOC_N(ret->secrets.secrets_val, nsecrets) < 0)
4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024
            goto cleanup;

        ret->secrets.secrets_len = nsecrets;

        for (i = 0; i < nsecrets; i++)
            make_nonnull_secret(ret->secrets.secrets_val + i, secrets[i]);
    } else {
        ret->secrets.secrets_len = 0;
        ret->secrets.secrets_val = NULL;
    }

    ret->ret = nsecrets;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (secrets) {
        for (i = 0; i < nsecrets; i++)
            virSecretFree(secrets[i]);
        VIR_FREE(secrets);
    }
    return rv;
}

5025 5026 5027 5028 5029 5030 5031 5032 5033
static int
remoteDispatchNodeGetMemoryParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_node_get_memory_parameters_args *args,
                                      remote_node_get_memory_parameters_ret *ret)
{
    virTypedParameterPtr params = NULL;
5034
    int nparams = 0;
5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    flags = args->flags;

5047
    if (args->nparams > REMOTE_NODE_MEMORY_PARAMETERS_MAX) {
5048 5049 5050
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
        goto cleanup;
    }
5051
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
5052
        goto cleanup;
5053
    nparams = args->nparams;
5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077

    if (virNodeGetMemoryParameters(priv->conn, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
5078
    virTypedParamsFree(params, nparams);
5079 5080 5081
    return rv;
}

5082 5083 5084 5085 5086 5087 5088 5089 5090
static int
remoteDispatchNodeGetCPUMap(virNetServerPtr server ATTRIBUTE_UNUSED,
                            virNetServerClientPtr client ATTRIBUTE_UNUSED,
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                            virNetMessageErrorPtr rerr,
                            remote_node_get_cpu_map_args *args,
                            remote_node_get_cpu_map_ret *ret)
{
    unsigned char *cpumap = NULL;
5091
    unsigned int online = 0;
5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104
    unsigned int flags;
    int cpunum;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    flags = args->flags;

5105 5106
    cpunum = virNodeGetCPUMap(priv->conn, args->need_map ? &cpumap : NULL,
                              args->need_online ? &online : NULL, flags);
5107 5108 5109 5110
    if (cpunum < 0)
        goto cleanup;

    /* 'serialize' return cpumap */
5111
    if (args->need_map) {
5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128
        ret->cpumap.cpumap_len = VIR_CPU_MAPLEN(cpunum);
        ret->cpumap.cpumap_val = (char *) cpumap;
        cpumap = NULL;
    }

    ret->online = online;
    ret->ret = cpunum;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    VIR_FREE(cpumap);
    return rv;
}

5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161
static int
lxcDispatchDomainOpenNamespace(virNetServerPtr server ATTRIBUTE_UNUSED,
                               virNetServerClientPtr client ATTRIBUTE_UNUSED,
                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                               virNetMessageErrorPtr rerr,
                               lxc_domain_open_namespace_args *args)
{
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *fdlist = NULL;
    int ret;
    virDomainPtr dom = NULL;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    ret = virDomainLxcOpenNamespace(dom,
                                    &fdlist,
                                    args->flags);
    if (ret < 0)
        goto cleanup;

    /* We shouldn't have received any from the client,
     * but in case they're playing games with us, prevent
     * a resource leak
     */
5162
    for (i = 0; i < msg->nfds; i++)
5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174
        VIR_FORCE_CLOSE(msg->fds[i]);
    VIR_FREE(msg->fds);
    msg->nfds = 0;

    msg->fds = fdlist;
    msg->nfds = ret;

    rv = 1;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
5175 5176
    if (dom)
        virDomainFree(dom);
5177 5178 5179
    return rv;
}

5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206
static int
remoteDispatchDomainGetJobStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client,
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_get_job_stats_args *args,
                                remote_domain_get_job_stats_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetJobStats(dom, &ret->type, &params,
                             &nparams, args->flags) < 0)
        goto cleanup;

5207 5208 5209 5210 5211 5212 5213
    if (nparams > REMOTE_DOMAIN_JOB_STATS_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many job stats '%d' for limit '%d'"),
                       nparams, REMOTE_DOMAIN_JOB_STATS_MAX);
        goto cleanup;
    }

5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       0) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virTypedParamsFree(params, nparams);
    if (dom)
        virDomainFree(dom);
    return rv;
}

5231
static int
5232 5233 5234 5235 5236 5237
remoteDispatchDomainMigrateBegin3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_domain_migrate_begin3_params_args *args,
                                        remote_domain_migrate_begin3_params_ret *ret)
5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253
{
    char *xml = NULL;
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5254 5255 5256 5257 5258 5259 5260
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (!(xml = virDomainMigrateBegin3Params(dom, params, nparams,
                                             &cookieout, &cookieoutlen,
                                             args->flags)))
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->xml = xml;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

static int
5290 5291 5292 5293 5294 5295
remoteDispatchDomainMigratePrepare3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_prepare3_params_args *args,
                                          remote_domain_migrate_prepare3_params_ret *ret)
5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char **uri_out;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5311 5312 5313 5314 5315 5316 5317
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5318 5319 5320 5321 5322 5323
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    /* Wacky world of XDR ... */
5324
    if (VIR_ALLOC(uri_out) < 0)
5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349
        goto cleanup;

    if (virDomainMigratePrepare3Params(priv->conn, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       &cookieout, &cookieoutlen,
                                       uri_out, args->flags) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->uri_out = !*uri_out ? NULL : uri_out;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(uri_out);
    }
    return rv;
}

static int
5350 5351 5352 5353 5354 5355
remoteDispatchDomainMigratePrepareTunnel3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client,
                                                virNetMessagePtr msg,
                                                virNetMessageErrorPtr rerr,
                                                remote_domain_migrate_prepare_tunnel3_params_args *args,
                                                remote_domain_migrate_prepare_tunnel3_params_ret *ret)
5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    virStreamPtr st = NULL;
    daemonClientStreamPtr stream = NULL;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5372 5373 5374 5375 5376 5377 5378
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (!(st = virStreamNew(priv->conn, VIR_STREAM_NONBLOCK)) ||
        !(stream = daemonCreateClientStream(client, st, remoteProgram,
                                            &msg->header)))
        goto cleanup;

    if (virDomainMigratePrepareTunnel3Params(priv->conn, st, params, nparams,
                                             args->cookie_in.cookie_in_val,
                                             args->cookie_in.cookie_in_len,
                                             &cookieout, &cookieoutlen,
                                             args->flags) < 0)
        goto cleanup;

    if (daemonAddClientStream(client, stream, false) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_val = cookieout;
    ret->cookie_out.cookie_out_len = cookieoutlen;
    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(cookieout);
        if (stream) {
            virStreamAbort(st);
            daemonFreeClientStream(client, stream);
        } else {
            virStreamFree(st);
        }
    }
    return rv;
}


static int
5420 5421 5422 5423 5424 5425
remoteDispatchDomainMigratePerform3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_perform3_params_args *args,
                                          remote_domain_migrate_perform3_params_ret *ret)
5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char *dconnuri;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5442 5443 5444 5445 5446 5447 5448
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;

    if (virDomainMigratePerform3Params(dom, dconnuri, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       &cookieout, &cookieoutlen,
                                       args->flags) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
5482 5483 5484 5485 5486 5487
remoteDispatchDomainMigrateFinish3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_domain_migrate_finish3_params_args *args,
                                         remote_domain_migrate_finish3_params_ret *ret)
5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5503 5504 5505 5506 5507 5508 5509
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    dom = virDomainMigrateFinish3Params(priv->conn, params, nparams,
                                        args->cookie_in.cookie_in_val,
                                        args->cookie_in.cookie_in_len,
                                        &cookieout, &cookieoutlen,
                                        args->flags, args->cancelled);
    if (!dom)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(cookieout);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
5543 5544 5545 5546 5547
remoteDispatchDomainMigrateConfirm3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_confirm3_params_args *args)
5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5561 5562 5563 5564 5565 5566 5567
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (virDomainMigrateConfirm3Params(dom, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       args->flags, args->cancelled) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645
static int
remoteDispatchConnectGetCPUModelNames(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_connect_get_cpu_model_names_args *args,
                                      remote_connect_get_cpu_model_names_ret *ret)
{
    int len, rv = -1;
    char **models = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    len = virConnectGetCPUModelNames(priv->conn, args->arch,
                                     args->need_results ? &models : NULL,
                                     args->flags);
    if (len < 0)
        goto cleanup;

    if (len > REMOTE_CONNECT_CPU_MODELS_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many CPU models '%d' for limit '%d'"),
                       len, REMOTE_CONNECT_CPU_MODELS_MAX);
        goto cleanup;
    }

    if (len && models) {
        ret->models.models_val = models;
        ret->models.models_len = len;
        models = NULL;
    } else {
        ret->models.models_val = NULL;
        ret->models.models_len = 0;
    }

    ret->ret = len;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virStringFreeList(models);
    return rv;
}


5646 5647 5648 5649 5650 5651 5652
static int
remoteDispatchDomainCreateXMLWithFiles(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_create_xml_with_files_args *args,
                                       remote_domain_create_xml_with_files_ret *ret)
5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *files = NULL;
    unsigned int nfiles = 0;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (VIR_ALLOC_N(files, msg->nfds) < 0)
        goto cleanup;
    for (i = 0; i < msg->nfds; i++) {
        if ((files[i] = virNetMessageDupFD(msg, i)) < 0)
            goto cleanup;
        nfiles++;
    }

    if ((dom = virDomainCreateXMLWithFiles(priv->conn, args->xml_desc,
                                           nfiles, files,
                                           args->flags)) == NULL)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);
    rv = 0;

cleanup:
    for (i = 0; i < nfiles; i++) {
        VIR_FORCE_CLOSE(files[i]);
    }
    VIR_FREE(files);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5696 5697 5698 5699 5700 5701
static int remoteDispatchDomainCreateWithFiles(virNetServerPtr server ATTRIBUTE_UNUSED,
                                               virNetServerClientPtr client,
                                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                               virNetMessageErrorPtr rerr,
                                               remote_domain_create_with_files_args *args,
                                               remote_domain_create_with_files_ret *ret)
5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *files = NULL;
    unsigned int nfiles = 0;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (VIR_ALLOC_N(files, msg->nfds) < 0)
        goto cleanup;
    for (i = 0; i < msg->nfds; i++) {
        if ((files[i] = virNetMessageDupFD(msg, i)) < 0)
            goto cleanup;
        nfiles++;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainCreateWithFiles(dom,
                                 nfiles, files,
                                 args->flags) < 0)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);
    rv = 0;

cleanup:
    for (i = 0; i < nfiles; i++) {
        VIR_FORCE_CLOSE(files[i]);
    }
    VIR_FREE(files);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5748 5749
static int
remoteDispatchConnectNetworkEventRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
5750
                                             virNetServerClientPtr client,
5751 5752 5753
                                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                             virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                             remote_connect_network_event_register_any_args *args,
5754
                                             remote_connect_network_event_register_any_ret *ret)
5755 5756 5757
{
    int callbackID;
    int rv = -1;
5758 5759
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
5760 5761
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
5762
    virNetworkPtr net = NULL;
5763 5764 5765 5766 5767 5768 5769 5770

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

5771 5772 5773 5774
    if (args->net &&
        !(net = get_nonnull_network(priv->conn, *args->net)))
        goto cleanup;

5775 5776 5777
    if (args->eventID >= VIR_NETWORK_EVENT_ID_LAST || args->eventID < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unsupported network event ID %d"), args->eventID);
5778 5779 5780
        goto cleanup;
    }

5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->networkEventCallbacks,
                           priv->nnetworkEventCallbacks,
                           callback) < 0)
5796 5797 5798
        goto cleanup;

    if ((callbackID = virConnectNetworkEventRegisterAny(priv->conn,
5799
                                                        net,
5800 5801
                                                        args->eventID,
                                                        networkEventCallbacks[args->eventID],
5802 5803 5804 5805 5806
                                                        ref,
                                                        remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->networkEventCallbacks,
                     priv->nnetworkEventCallbacks, 1);
        callback = ref;
5807
        goto cleanup;
5808
    }
5809

5810
    ref->callbackID = callbackID;
5811
    ret->callbackID = callbackID;
5812 5813 5814 5815

    rv = 0;

cleanup:
5816
    VIR_FREE(callback);
5817 5818
    if (rv < 0)
        virNetMessageSaveError(rerr);
5819 5820
    if (net)
        virNetworkFree(net);
5821 5822 5823 5824 5825 5826 5827
    virMutexUnlock(&priv->lock);
    return rv;
}


static int
remoteDispatchConnectNetworkEventDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
5828
                                               virNetServerClientPtr client,
5829 5830
                                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                               virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
5831
                                               remote_connect_network_event_deregister_any_args *args)
5832 5833
{
    int rv = -1;
5834
    size_t i;
5835 5836 5837 5838 5839 5840 5841 5842 5843 5844
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

5845
    for (i = 0; i < priv->nnetworkEventCallbacks; i++) {
5846
        if (priv->networkEventCallbacks[i]->callbackID == args->callbackID)
5847 5848
            break;
    }
5849
    if (i == priv->nnetworkEventCallbacks) {
5850
        virReportError(VIR_ERR_INTERNAL_ERROR,
5851 5852
                       _("network event callback %d not registered"),
                       args->callbackID);
5853 5854 5855
        goto cleanup;
    }

5856
    if (virConnectNetworkEventDeregisterAny(priv->conn, args->callbackID) < 0)
5857 5858
        goto cleanup;

5859 5860
    VIR_DELETE_ELEMENT(priv->networkEventCallbacks, i,
                       priv->nnetworkEventCallbacks);
5861 5862 5863 5864 5865 5866 5867 5868 5869 5870

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return rv;
}

5871

5872 5873 5874 5875 5876 5877 5878 5879 5880
/*----- Helpers. -----*/

/* get_nonnull_domain and get_nonnull_network turn an on-wire
 * (name, uuid) pair into virDomainPtr or virNetworkPtr object.
 * virDomainPtr or virNetworkPtr cannot be NULL.
 *
 * NB. If these return NULL then the caller must return an error.
 */
static virDomainPtr
5881
get_nonnull_domain(virConnectPtr conn, remote_nonnull_domain domain)
5882 5883
{
    virDomainPtr dom;
5884
    dom = virGetDomain(conn, domain.name, BAD_CAST domain.uuid);
5885 5886 5887 5888 5889 5890 5891 5892
    /* Should we believe the domain.id sent by the client?  Maybe
     * this should be a check rather than an assignment? XXX
     */
    if (dom) dom->id = domain.id;
    return dom;
}

static virNetworkPtr
5893
get_nonnull_network(virConnectPtr conn, remote_nonnull_network network)
5894
{
5895
    return virGetNetwork(conn, network.name, BAD_CAST network.uuid);
5896 5897
}

D
Daniel Veillard 已提交
5898
static virInterfacePtr
5899
get_nonnull_interface(virConnectPtr conn, remote_nonnull_interface iface)
D
Daniel Veillard 已提交
5900
{
5901
    return virGetInterface(conn, iface.name, iface.mac);
D
Daniel Veillard 已提交
5902 5903
}

5904
static virStoragePoolPtr
5905
get_nonnull_storage_pool(virConnectPtr conn, remote_nonnull_storage_pool pool)
5906
{
5907 5908
    return virGetStoragePool(conn, pool.name, BAD_CAST pool.uuid,
                             NULL, NULL);
5909 5910 5911
}

static virStorageVolPtr
5912
get_nonnull_storage_vol(virConnectPtr conn, remote_nonnull_storage_vol vol)
5913 5914
{
    virStorageVolPtr ret;
5915 5916
    ret = virGetStorageVol(conn, vol.pool, vol.name, vol.key,
                           NULL, NULL);
5917 5918 5919
    return ret;
}

5920
static virSecretPtr
5921
get_nonnull_secret(virConnectPtr conn, remote_nonnull_secret secret)
5922
{
5923
    return virGetSecret(conn, BAD_CAST secret.uuid, secret.usageType, secret.usageID);
5924 5925
}

5926
static virNWFilterPtr
5927
get_nonnull_nwfilter(virConnectPtr conn, remote_nonnull_nwfilter nwfilter)
5928
{
5929
    return virGetNWFilter(conn, nwfilter.name, BAD_CAST nwfilter.uuid);
5930 5931
}

C
Chris Lalancette 已提交
5932
static virDomainSnapshotPtr
5933
get_nonnull_domain_snapshot(virDomainPtr dom, remote_nonnull_domain_snapshot snapshot)
C
Chris Lalancette 已提交
5934
{
5935
    return virGetDomainSnapshot(dom, snapshot.name);
C
Chris Lalancette 已提交
5936 5937
}

5938 5939
/* Make remote_nonnull_domain and remote_nonnull_network. */
static void
5940
make_nonnull_domain(remote_nonnull_domain *dom_dst, virDomainPtr dom_src)
5941 5942
{
    dom_dst->id = dom_src->id;
5943
    ignore_value(VIR_STRDUP_QUIET(dom_dst->name, dom_src->name));
5944
    memcpy(dom_dst->uuid, dom_src->uuid, VIR_UUID_BUFLEN);
5945 5946 5947
}

static void
5948
make_nonnull_network(remote_nonnull_network *net_dst, virNetworkPtr net_src)
5949
{
5950
    ignore_value(VIR_STRDUP_QUIET(net_dst->name, net_src->name));
5951
    memcpy(net_dst->uuid, net_src->uuid, VIR_UUID_BUFLEN);
5952 5953
}

D
Daniel Veillard 已提交
5954
static void
5955 5956
make_nonnull_interface(remote_nonnull_interface *interface_dst,
                       virInterfacePtr interface_src)
D
Daniel Veillard 已提交
5957
{
5958 5959
    ignore_value(VIR_STRDUP_QUIET(interface_dst->name, interface_src->name));
    ignore_value(VIR_STRDUP_QUIET(interface_dst->mac, interface_src->mac));
D
Daniel Veillard 已提交
5960 5961
}

5962
static void
5963
make_nonnull_storage_pool(remote_nonnull_storage_pool *pool_dst, virStoragePoolPtr pool_src)
5964
{
5965
    ignore_value(VIR_STRDUP_QUIET(pool_dst->name, pool_src->name));
5966
    memcpy(pool_dst->uuid, pool_src->uuid, VIR_UUID_BUFLEN);
5967 5968 5969
}

static void
5970
make_nonnull_storage_vol(remote_nonnull_storage_vol *vol_dst, virStorageVolPtr vol_src)
5971
{
5972 5973 5974
    ignore_value(VIR_STRDUP_QUIET(vol_dst->pool, vol_src->pool));
    ignore_value(VIR_STRDUP_QUIET(vol_dst->name, vol_src->name));
    ignore_value(VIR_STRDUP_QUIET(vol_dst->key, vol_src->key));
5975
}
5976 5977

static void
5978
make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNodeDevicePtr dev_src)
5979
{
5980
    ignore_value(VIR_STRDUP_QUIET(dev_dst->name, dev_src->name));
5981
}
5982 5983

static void
5984
make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src)
5985
{
5986
    memcpy(secret_dst->uuid, secret_src->uuid, VIR_UUID_BUFLEN);
5987
    secret_dst->usageType = secret_src->usageType;
5988
    ignore_value(VIR_STRDUP_QUIET(secret_dst->usageID, secret_src->usageID));
5989
}
5990 5991

static void
5992
make_nonnull_nwfilter(remote_nonnull_nwfilter *nwfilter_dst, virNWFilterPtr nwfilter_src)
5993
{
5994
    ignore_value(VIR_STRDUP_QUIET(nwfilter_dst->name, nwfilter_src->name));
5995
    memcpy(nwfilter_dst->uuid, nwfilter_src->uuid, VIR_UUID_BUFLEN);
5996
}
C
Chris Lalancette 已提交
5997 5998

static void
5999
make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src)
C
Chris Lalancette 已提交
6000
{
6001
    ignore_value(VIR_STRDUP_QUIET(snapshot_dst->name, snapshot_src->name));
6002
    make_nonnull_domain(&snapshot_dst->dom, snapshot_src->domain);
C
Chris Lalancette 已提交
6003
}
6004 6005 6006 6007 6008 6009 6010 6011

static int
remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors,
                                int nerrors,
                                remote_domain_disk_error **ret_errors_val,
                                u_int *ret_errors_len)
{
    remote_domain_disk_error *val = NULL;
6012
    size_t i = 0;
6013

6014
    if (VIR_ALLOC_N(val, nerrors) < 0)
6015
        goto error;
6016 6017

    for (i = 0; i < nerrors; i++) {
6018 6019
        if (VIR_STRDUP(val[i].disk, errors[i].disk) < 0)
            goto error;
6020 6021 6022 6023 6024 6025 6026 6027
        val[i].error = errors[i].error;
    }

    *ret_errors_len = nerrors;
    *ret_errors_val = val;

    return 0;

6028
error:
6029
    if (val) {
6030
        size_t j;
6031 6032 6033 6034 6035 6036
        for (j = 0; j < i; j++)
            VIR_FREE(val[j].disk);
        VIR_FREE(val);
    }
    return -1;
}