remote.c 195.5 KB
Newer Older
1
/*
2
 * remote.c: handlers for RPC method calls
3
 *
4
 * Copyright (C) 2007-2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
17
 * License along with this library.  If not, see
O
Osier Yang 已提交
18
 * <http://www.gnu.org/licenses/>.
19 20 21 22 23 24
 *
 * Author: Richard W.M. Jones <rjones@redhat.com>
 */

#include <config.h>

25
#include "virerror.h"
26

27
#if WITH_POLKIT0
28 29
# include <polkit/polkit.h>
# include <polkit-dbus/polkit-dbus.h>
30 31
#endif

32
#include "remote.h"
33
#include "libvirtd.h"
34 35
#include "libvirt_internal.h"
#include "datatypes.h"
36
#include "viralloc.h"
37
#include "virlog.h"
C
Chris Lalancette 已提交
38
#include "stream.h"
39
#include "viruuid.h"
40
#include "vircommand.h"
41
#include "intprops.h"
42
#include "virnetserverservice.h"
J
Jim Fehlig 已提交
43
#include "virnetserver.h"
44
#include "virfile.h"
45
#include "virtypedparam.h"
46
#include "virdbus.h"
47
#include "virprocess.h"
48 49
#include "remote_protocol.h"
#include "qemu_protocol.h"
50
#include "lxc_protocol.h"
51
#include "virstring.h"
52
#include "object_event.h"
53 54 55
#include "domain_conf.h"
#include "network_conf.h"
#include "viraccessapicheck.h"
56 57

#define VIR_FROM_THIS VIR_FROM_RPC
58

59
#if SIZEOF_LONG < 8
E
Eric Blake 已提交
60 61 62
# define HYPER_TO_TYPE(_type, _to, _from)                               \
    do {                                                                \
        if ((_from) != (_type)(_from)) {                                \
63 64 65
            virReportError(VIR_ERR_OVERFLOW,                            \
                           _("conversion from hyper to %s overflowed"), \
                           #_type);                                     \
E
Eric Blake 已提交
66 67 68
            goto cleanup;                                               \
        }                                                               \
        (_to) = (_from);                                                \
69 70 71 72 73 74 75 76 77
    } while (0)

# define HYPER_TO_LONG(_to, _from) HYPER_TO_TYPE(long, _to, _from)
# define HYPER_TO_ULONG(_to, _from) HYPER_TO_TYPE(unsigned long, _to, _from)
#else
# define HYPER_TO_LONG(_to, _from) (_to) = (_from)
# define HYPER_TO_ULONG(_to, _from) (_to) = (_from)
#endif

78 79 80 81
struct daemonClientEventCallback {
    virNetServerClientPtr client;
    int eventID;
    int callbackID;
82
    bool legacy;
83 84
};

85 86 87 88 89 90 91
static virDomainPtr get_nonnull_domain(virConnectPtr conn, remote_nonnull_domain domain);
static virNetworkPtr get_nonnull_network(virConnectPtr conn, remote_nonnull_network network);
static virInterfacePtr get_nonnull_interface(virConnectPtr conn, remote_nonnull_interface iface);
static virStoragePoolPtr get_nonnull_storage_pool(virConnectPtr conn, remote_nonnull_storage_pool pool);
static virStorageVolPtr get_nonnull_storage_vol(virConnectPtr conn, remote_nonnull_storage_vol vol);
static virSecretPtr get_nonnull_secret(virConnectPtr conn, remote_nonnull_secret secret);
static virNWFilterPtr get_nonnull_nwfilter(virConnectPtr conn, remote_nonnull_nwfilter nwfilter);
92
static virDomainSnapshotPtr get_nonnull_domain_snapshot(virDomainPtr dom, remote_nonnull_domain_snapshot snapshot);
93 94 95 96 97 98 99 100 101
static void make_nonnull_domain(remote_nonnull_domain *dom_dst, virDomainPtr dom_src);
static void make_nonnull_network(remote_nonnull_network *net_dst, virNetworkPtr net_src);
static void make_nonnull_interface(remote_nonnull_interface *interface_dst, virInterfacePtr interface_src);
static void make_nonnull_storage_pool(remote_nonnull_storage_pool *pool_dst, virStoragePoolPtr pool_src);
static void make_nonnull_storage_vol(remote_nonnull_storage_vol *vol_dst, virStorageVolPtr vol_src);
static void make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNodeDevicePtr dev_src);
static void make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src);
static void make_nonnull_nwfilter(remote_nonnull_nwfilter *net_dst, virNWFilterPtr nwfilter_src);
static void make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src);
102

103 104 105 106 107
static virTypedParameterPtr
remoteDeserializeTypedParameters(remote_typed_param *args_params_val,
                                 u_int args_params_len,
                                 int limit,
                                 int *nparams);
108

109 110 111 112 113 114
static int
remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors,
                                int nerrors,
                                remote_domain_disk_error **ret_errors_val,
                                u_int *ret_errors_len);

115 116
#include "remote_dispatch.h"
#include "qemu_dispatch.h"
117
#include "lxc_dispatch.h"
C
Chris Lalancette 已提交
118 119


120 121
/* Prototypes */
static void
122
remoteDispatchObjectEventSend(virNetServerClientPtr client,
123
                              virNetServerProgramPtr program,
124 125 126
                              int procnr,
                              xdrproc_t proc,
                              void *data);
127

128 129 130 131 132 133
static void
remoteEventCallbackFree(void *opaque)
{
    VIR_FREE(opaque);
}

134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194

static bool
remoteRelayDomainEventCheckACL(virNetServerClientPtr client,
                               virConnectPtr conn, virDomainPtr dom)
{
    virDomainDef def;
    virIdentityPtr identity = NULL;
    bool ret = false;

    /* For now, we just create a virDomainDef with enough contents to
     * satisfy what viraccessdriverpolkit.c references.  This is a bit
     * fragile, but I don't know of anything better.  */
    def.name = dom->name;
    memcpy(def.uuid, dom->uuid, VIR_UUID_BUFLEN);

    if (!(identity = virNetServerClientGetIdentity(client)))
        goto cleanup;
    if (virIdentitySetCurrent(identity) < 0)
        goto cleanup;
    ret = virConnectDomainEventRegisterAnyCheckACL(conn, &def);

cleanup:
    ignore_value(virIdentitySetCurrent(NULL));
    virObjectUnref(identity);
    return ret;
}


static bool
remoteRelayNetworkEventCheckACL(virNetServerClientPtr client,
                                virConnectPtr conn, virNetworkPtr net)
{
    virNetworkDef def;
    virIdentityPtr identity = NULL;
    bool ret = false;

    /* For now, we just create a virNetworkDef with enough contents to
     * satisfy what viraccessdriverpolkit.c references.  This is a bit
     * fragile, but I don't know of anything better.  */
    def.name = net->name;
    memcpy(def.uuid, net->uuid, VIR_UUID_BUFLEN);

    if (!(identity = virNetServerClientGetIdentity(client)))
        goto cleanup;
    if (virIdentitySetCurrent(identity) < 0)
        goto cleanup;
    ret = virConnectNetworkEventRegisterAnyCheckACL(conn, &def);

cleanup:
    ignore_value(virIdentitySetCurrent(NULL));
    virObjectUnref(identity);
    return ret;
}


static int
remoteRelayDomainEventLifecycle(virConnectPtr conn,
                                virDomainPtr dom,
                                int event,
                                int detail,
                                void *opaque)
195
{
196
    daemonClientEventCallbackPtr callback = opaque;
197
    remote_domain_event_lifecycle_msg data;
198

199 200
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
201 202
        return -1;

203 204
    VIR_DEBUG("Relaying domain lifecycle event %d %d, callback %d legacy %d",
              event, detail, callback->callbackID, callback->legacy);
205

206
    /* build return data */
207
    memset(&data, 0, sizeof(data));
208
    make_nonnull_domain(&data.dom, dom);
209 210
    data.event = event;
    data.detail = detail;
211

212 213 214 215 216 217 218 219 220 221 222 223 224 225
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_LIFECYCLE,
                                      (xdrproc_t)xdr_remote_domain_event_lifecycle_msg,
                                      &data);
    } else {
        remote_domain_event_callback_lifecycle_msg msg = { callback->callbackID,
                                                           data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_LIFECYCLE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_lifecycle_msg,
                                      &msg);
    }
226

227 228
    return 0;
}
229

230 231 232 233
static int
remoteRelayDomainEventReboot(virConnectPtr conn,
                             virDomainPtr dom,
                             void *opaque)
234
{
235
    daemonClientEventCallbackPtr callback = opaque;
236 237
    remote_domain_event_reboot_msg data;

238 239
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
240 241
        return -1;

242 243
    VIR_DEBUG("Relaying domain reboot event %s %d, callback %d legacy %d",
              dom->name, dom->id, callback->callbackID, callback->legacy);
244 245

    /* build return data */
246
    memset(&data, 0, sizeof(data));
247
    make_nonnull_domain(&data.dom, dom);
248

249 250 251 252 253 254 255 256 257 258 259 260
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_REBOOT,
                                      (xdrproc_t)xdr_remote_domain_event_reboot_msg, &data);
    } else {
        remote_domain_event_callback_reboot_msg msg = { callback->callbackID,
                                                        data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_REBOOT,
                                      (xdrproc_t)xdr_remote_domain_event_callback_reboot_msg, &msg);
    }
261 262 263 264

    return 0;
}

265

266 267 268 269 270
static int
remoteRelayDomainEventRTCChange(virConnectPtr conn,
                                virDomainPtr dom,
                                long long offset,
                                void *opaque)
271
{
272
    daemonClientEventCallbackPtr callback = opaque;
273 274
    remote_domain_event_rtc_change_msg data;

275 276
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
277 278
        return -1;

279 280 281
    VIR_DEBUG("Relaying domain rtc change event %s %d %lld, callback %d legacy %d",
              dom->name, dom->id, offset,
              callback->callbackID, callback->legacy);
282 283

    /* build return data */
284
    memset(&data, 0, sizeof(data));
285
    make_nonnull_domain(&data.dom, dom);
286 287
    data.offset = offset;

288 289 290 291 292 293 294 295 296 297 298 299
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_RTC_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_rtc_change_msg, &data);
    } else {
        remote_domain_event_callback_rtc_change_msg msg = { callback->callbackID,
                                                            data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_RTC_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_rtc_change_msg, &msg);
    }
300 301 302 303 304

    return 0;
}


305 306 307 308 309
static int
remoteRelayDomainEventWatchdog(virConnectPtr conn,
                               virDomainPtr dom,
                               int action,
                               void *opaque)
310
{
311
    daemonClientEventCallbackPtr callback = opaque;
312 313
    remote_domain_event_watchdog_msg data;

314 315
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
316 317
        return -1;

318 319
    VIR_DEBUG("Relaying domain watchdog event %s %d %d, callback %d",
              dom->name, dom->id, action, callback->callbackID);
320 321

    /* build return data */
322
    memset(&data, 0, sizeof(data));
323
    make_nonnull_domain(&data.dom, dom);
324 325
    data.action = action;

326 327 328 329 330 331 332 333 334 335 336 337
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_WATCHDOG,
                                      (xdrproc_t)xdr_remote_domain_event_watchdog_msg, &data);
    } else {
        remote_domain_event_callback_watchdog_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_WATCHDOG,
                                      (xdrproc_t)xdr_remote_domain_event_callback_watchdog_msg, &msg);
    }
338 339 340 341 342

    return 0;
}


343 344 345 346 347 348 349
static int
remoteRelayDomainEventIOError(virConnectPtr conn,
                              virDomainPtr dom,
                              const char *srcPath,
                              const char *devAlias,
                              int action,
                              void *opaque)
350
{
351
    daemonClientEventCallbackPtr callback = opaque;
352 353
    remote_domain_event_io_error_msg data;

354 355
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
356 357
        return -1;

358 359 360
    VIR_DEBUG("Relaying domain io error %s %d %s %s %d, callback %d",
              dom->name, dom->id, srcPath, devAlias, action,
              callback->callbackID);
361 362

    /* build return data */
363
    memset(&data, 0, sizeof(data));
364 365 366
    if (VIR_STRDUP(data.srcPath, srcPath) < 0 ||
        VIR_STRDUP(data.devAlias, devAlias) < 0)
        goto error;
367
    make_nonnull_domain(&data.dom, dom);
368 369
    data.action = action;

370 371 372 373 374 375 376 377 378 379 380 381
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_IO_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_io_error_msg, &data);
    } else {
        remote_domain_event_callback_io_error_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_IO_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_callback_io_error_msg, &msg);
    }
382 383

    return 0;
384
error:
E
Eric Blake 已提交
385 386
    VIR_FREE(data.srcPath);
    VIR_FREE(data.devAlias);
387
    return -1;
388 389 390
}


391 392 393 394 395 396 397 398
static int
remoteRelayDomainEventIOErrorReason(virConnectPtr conn,
                                    virDomainPtr dom,
                                    const char *srcPath,
                                    const char *devAlias,
                                    int action,
                                    const char *reason,
                                    void *opaque)
399
{
400
    daemonClientEventCallbackPtr callback = opaque;
401 402
    remote_domain_event_io_error_reason_msg data;

403 404
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
405 406
        return -1;

407 408 409
    VIR_DEBUG("Relaying domain io error %s %d %s %s %d %s, callback %d",
              dom->name, dom->id, srcPath, devAlias, action, reason,
              callback->callbackID);
410 411

    /* build return data */
412
    memset(&data, 0, sizeof(data));
413 414 415 416
    if (VIR_STRDUP(data.srcPath, srcPath) < 0 ||
        VIR_STRDUP(data.devAlias, devAlias) < 0 ||
        VIR_STRDUP(data.reason, reason) < 0)
        goto error;
417
    data.action = action;
418 419

    make_nonnull_domain(&data.dom, dom);
420

421 422 423 424 425 426 427 428 429 430 431 432
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_IO_ERROR_REASON,
                                      (xdrproc_t)xdr_remote_domain_event_io_error_reason_msg, &data);
    } else {
        remote_domain_event_callback_io_error_reason_msg msg = { callback->callbackID,
                                                                 data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_IO_ERROR_REASON,
                                      (xdrproc_t)xdr_remote_domain_event_callback_io_error_reason_msg, &msg);
    }
433 434

    return 0;
435

436
error:
E
Eric Blake 已提交
437 438 439
    VIR_FREE(data.srcPath);
    VIR_FREE(data.devAlias);
    VIR_FREE(data.reason);
440
    return -1;
441 442 443
}


444 445 446 447 448 449 450 451 452
static int
remoteRelayDomainEventGraphics(virConnectPtr conn,
                               virDomainPtr dom,
                               int phase,
                               virDomainEventGraphicsAddressPtr local,
                               virDomainEventGraphicsAddressPtr remote,
                               const char *authScheme,
                               virDomainEventGraphicsSubjectPtr subject,
                               void *opaque)
453
{
454
    daemonClientEventCallbackPtr callback = opaque;
455
    remote_domain_event_graphics_msg data;
456
    size_t i;
457

458 459
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
460 461
        return -1;

462 463
    VIR_DEBUG("Relaying domain graphics event %s %d %d - %d %s %s  - %d %s %s - %s, callback %d",
              dom->name, dom->id, phase,
464 465
              local->family, local->service, local->node,
              remote->family, remote->service, remote->node,
466
              authScheme, callback->callbackID);
467

468
    VIR_DEBUG("Subject %d", subject->nidentity);
469
    for (i = 0; i < subject->nidentity; i++) {
470
        VIR_DEBUG("  %s=%s", subject->identities[i].type, subject->identities[i].name);
471 472 473
    }

    /* build return data */
474
    memset(&data, 0, sizeof(data));
475 476 477
    data.phase = phase;
    data.local.family = local->family;
    data.remote.family = remote->family;
478 479 480 481 482 483
    if (VIR_STRDUP(data.authScheme, authScheme) < 0 ||
        VIR_STRDUP(data.local.node, local->node) < 0 ||
        VIR_STRDUP(data.local.service, local->service) < 0 ||
        VIR_STRDUP(data.remote.node, remote->node) < 0 ||
        VIR_STRDUP(data.remote.service, remote->service) < 0)
        goto error;
484 485

    data.subject.subject_len = subject->nidentity;
486
    if (VIR_ALLOC_N(data.subject.subject_val, data.subject.subject_len) < 0)
487
        goto error;
488

489
    for (i = 0; i < data.subject.subject_len; i++) {
490 491 492
        if (VIR_STRDUP(data.subject.subject_val[i].type, subject->identities[i].type) < 0 ||
            VIR_STRDUP(data.subject.subject_val[i].name, subject->identities[i].name) < 0)
            goto error;
493
    }
494
    make_nonnull_domain(&data.dom, dom);
495

496 497 498 499 500 501 502 503 504 505 506 507
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_GRAPHICS,
                                      (xdrproc_t)xdr_remote_domain_event_graphics_msg, &data);
    } else {
        remote_domain_event_callback_graphics_msg msg = { callback->callbackID,
                                                          data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_GRAPHICS,
                                      (xdrproc_t)xdr_remote_domain_event_callback_graphics_msg, &msg);
    }
508 509

    return 0;
510

511
error:
E
Eric Blake 已提交
512 513 514 515 516
    VIR_FREE(data.authScheme);
    VIR_FREE(data.local.node);
    VIR_FREE(data.local.service);
    VIR_FREE(data.remote.node);
    VIR_FREE(data.remote.service);
517
    if (data.subject.subject_val != NULL) {
518
        for (i = 0; i < data.subject.subject_len; i++) {
E
Eric Blake 已提交
519 520
            VIR_FREE(data.subject.subject_val[i].type);
            VIR_FREE(data.subject.subject_val[i].name);
521
        }
E
Eric Blake 已提交
522
        VIR_FREE(data.subject.subject_val);
523 524
    }
    return -1;
525 526
}

527 528 529 530 531 532 533
static int
remoteRelayDomainEventBlockJob(virConnectPtr conn,
                               virDomainPtr dom,
                               const char *path,
                               int type,
                               int status,
                               void *opaque)
534
{
535
    daemonClientEventCallbackPtr callback = opaque;
536 537
    remote_domain_event_block_job_msg data;

538 539
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
540 541
        return -1;

542 543
    VIR_DEBUG("Relaying domain block job event %s %d %s %i, %i, callback %d",
              dom->name, dom->id, path, type, status, callback->callbackID);
544 545

    /* build return data */
546
    memset(&data, 0, sizeof(data));
547 548
    if (VIR_STRDUP(data.path, path) < 0)
        goto error;
549 550
    data.type = type;
    data.status = status;
551
    make_nonnull_domain(&data.dom, dom);
552

553 554 555 556 557 558 559 560 561 562 563 564
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_BLOCK_JOB,
                                      (xdrproc_t)xdr_remote_domain_event_block_job_msg, &data);
    } else {
        remote_domain_event_callback_block_job_msg msg = { callback->callbackID,
                                                           data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BLOCK_JOB,
                                      (xdrproc_t)xdr_remote_domain_event_callback_block_job_msg, &msg);
    }
565 566

    return 0;
567
error:
E
Eric Blake 已提交
568
    VIR_FREE(data.path);
569
    return -1;
570 571
}

572

573 574 575 576
static int
remoteRelayDomainEventControlError(virConnectPtr conn,
                                   virDomainPtr dom,
                                   void *opaque)
577
{
578
    daemonClientEventCallbackPtr callback = opaque;
579 580
    remote_domain_event_control_error_msg data;

581 582
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
583 584
        return -1;

585 586
    VIR_DEBUG("Relaying domain control error %s %d, callback %d",
              dom->name, dom->id, callback->callbackID);
587 588

    /* build return data */
589
    memset(&data, 0, sizeof(data));
590 591
    make_nonnull_domain(&data.dom, dom);

592 593 594 595 596 597 598 599 600 601 602 603
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CONTROL_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_control_error_msg, &data);
    } else {
        remote_domain_event_callback_control_error_msg msg = { callback->callbackID,
                                                               data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_CONTROL_ERROR,
                                      (xdrproc_t)xdr_remote_domain_event_callback_control_error_msg, &msg);
    }
604 605 606 607 608

    return 0;
}


609 610 611 612 613 614 615 616
static int
remoteRelayDomainEventDiskChange(virConnectPtr conn,
                                 virDomainPtr dom,
                                 const char *oldSrcPath,
                                 const char *newSrcPath,
                                 const char *devAlias,
                                 int reason,
                                 void *opaque)
617
{
618
    daemonClientEventCallbackPtr callback = opaque;
619 620 621
    remote_domain_event_disk_change_msg data;
    char **oldSrcPath_p = NULL, **newSrcPath_p = NULL;

622 623
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
624 625
        return -1;

626 627 628
    VIR_DEBUG("Relaying domain %s %d disk change %s %s %s %d, callback %d",
              dom->name, dom->id, oldSrcPath, newSrcPath, devAlias, reason,
              callback->callbackID);
629 630

    /* build return data */
631
    memset(&data, 0, sizeof(data));
632 633
    if (oldSrcPath &&
        ((VIR_ALLOC(oldSrcPath_p) < 0) ||
634
         VIR_STRDUP(*oldSrcPath_p, oldSrcPath) < 0))
635
        goto error;
636 637 638

    if (newSrcPath &&
        ((VIR_ALLOC(newSrcPath_p) < 0) ||
639
         VIR_STRDUP(*newSrcPath_p, newSrcPath) < 0))
640
        goto error;
641 642 643

    data.oldSrcPath = oldSrcPath_p;
    data.newSrcPath = newSrcPath_p;
644 645
    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
        goto error;
646 647 648 649
    data.reason = reason;

    make_nonnull_domain(&data.dom, dom);

650 651 652 653 654 655 656 657 658 659 660 661
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_DISK_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_disk_change_msg, &data);
    } else {
        remote_domain_event_callback_disk_change_msg msg = { callback->callbackID,
                                                             data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DISK_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_disk_change_msg, &msg);
    }
662 663 664

    return 0;

665
error:
M
Michal Privoznik 已提交
666 667
    VIR_FREE(oldSrcPath_p);
    VIR_FREE(newSrcPath_p);
668 669 670 671
    return -1;
}


672 673 674 675 676 677 678
static int
remoteRelayDomainEventTrayChange(virConnectPtr conn,
                                 virDomainPtr dom,
                                 const char *devAlias,
                                 int reason,
                                 void *opaque)
{
679
    daemonClientEventCallbackPtr callback = opaque;
680 681
    remote_domain_event_tray_change_msg data;

682 683
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
684 685
        return -1;

686 687
    VIR_DEBUG("Relaying domain %s %d tray change devAlias: %s reason: %d, callback %d",
              dom->name, dom->id, devAlias, reason, callback->callbackID);
688 689

    /* build return data */
690
    memset(&data, 0, sizeof(data));
691

692
    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
693 694 695 696 697
        return -1;
    data.reason = reason;

    make_nonnull_domain(&data.dom, dom);

698 699 700 701 702 703 704 705 706 707 708 709
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_TRAY_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_tray_change_msg, &data);
    } else {
        remote_domain_event_callback_tray_change_msg msg = { callback->callbackID,
                                                             data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TRAY_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_tray_change_msg, &msg);
    }
710 711 712 713

    return 0;
}

714 715 716
static int
remoteRelayDomainEventPMWakeup(virConnectPtr conn,
                               virDomainPtr dom,
E
Eric Blake 已提交
717
                               int reason,
718 719
                               void *opaque)
{
720
    daemonClientEventCallbackPtr callback = opaque;
O
Osier Yang 已提交
721 722
    remote_domain_event_pmwakeup_msg data;

723 724
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
O
Osier Yang 已提交
725 726
        return -1;

727 728
    VIR_DEBUG("Relaying domain %s %d system pmwakeup, callback %d",
              dom->name, dom->id, callback->callbackID);
O
Osier Yang 已提交
729 730

    /* build return data */
731
    memset(&data, 0, sizeof(data));
O
Osier Yang 已提交
732 733
    make_nonnull_domain(&data.dom, dom);

734 735 736 737 738 739
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMWAKEUP,
                                      (xdrproc_t)xdr_remote_domain_event_pmwakeup_msg, &data);
    } else {
        remote_domain_event_callback_pmwakeup_msg msg = { callback->callbackID,
E
Eric Blake 已提交
740
                                                          reason, data };
741 742 743 744 745

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMWAKEUP,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmwakeup_msg, &msg);
    }
O
Osier Yang 已提交
746 747 748 749

    return 0;
}

750 751 752
static int
remoteRelayDomainEventPMSuspend(virConnectPtr conn,
                                virDomainPtr dom,
E
Eric Blake 已提交
753
                                int reason,
754 755
                                void *opaque)
{
756
    daemonClientEventCallbackPtr callback = opaque;
O
Osier Yang 已提交
757 758
    remote_domain_event_pmsuspend_msg data;

759 760
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
O
Osier Yang 已提交
761 762
        return -1;

763 764
    VIR_DEBUG("Relaying domain %s %d system pmsuspend, callback %d",
              dom->name, dom->id, callback->callbackID);
O
Osier Yang 已提交
765 766

    /* build return data */
767
    memset(&data, 0, sizeof(data));
O
Osier Yang 已提交
768 769
    make_nonnull_domain(&data.dom, dom);

770 771 772 773 774 775
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND,
                                      (xdrproc_t)xdr_remote_domain_event_pmsuspend_msg, &data);
    } else {
        remote_domain_event_callback_pmsuspend_msg msg = { callback->callbackID,
E
Eric Blake 已提交
776
                                                           reason, data };
777 778 779 780 781

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmsuspend_msg, &msg);
    }
O
Osier Yang 已提交
782 783 784 785

    return 0;
}

786
static int
787
remoteRelayDomainEventBalloonChange(virConnectPtr conn,
788 789 790 791
                                    virDomainPtr dom,
                                    unsigned long long actual,
                                    void *opaque)
{
792
    daemonClientEventCallbackPtr callback = opaque;
793 794
    remote_domain_event_balloon_change_msg data;

795 796
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
797 798
        return -1;

799 800
    VIR_DEBUG("Relaying domain balloon change event %s %d %lld, callback %d",
              dom->name, dom->id, actual, callback->callbackID);
801 802 803 804 805 806

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_domain(&data.dom, dom);
    data.actual = actual;

807 808 809 810 811 812 813 814 815 816 817 818
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_BALLOON_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_balloon_change_msg, &data);
    } else {
        remote_domain_event_callback_balloon_change_msg msg = { callback->callbackID,
                                                                data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BALLOON_CHANGE,
                                      (xdrproc_t)xdr_remote_domain_event_callback_balloon_change_msg, &msg);
    }
819 820 821 822 823

    return 0;
}


824 825 826
static int
remoteRelayDomainEventPMSuspendDisk(virConnectPtr conn,
                                    virDomainPtr dom,
E
Eric Blake 已提交
827
                                    int reason,
828 829
                                    void *opaque)
{
830
    daemonClientEventCallbackPtr callback = opaque;
831 832
    remote_domain_event_pmsuspend_disk_msg data;

833 834
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
835 836
        return -1;

837 838
    VIR_DEBUG("Relaying domain %s %d system pmsuspend-disk, callback %d",
              dom->name, dom->id, callback->callbackID);
839 840 841 842 843

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_domain(&data.dom, dom);

844 845 846 847 848 849
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND_DISK,
                                      (xdrproc_t)xdr_remote_domain_event_pmsuspend_disk_msg, &data);
    } else {
        remote_domain_event_callback_pmsuspend_disk_msg msg = { callback->callbackID,
E
Eric Blake 已提交
850
                                                                reason, data };
851 852 853 854 855

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND_DISK,
                                      (xdrproc_t)xdr_remote_domain_event_callback_pmsuspend_disk_msg, &msg);
    }
856 857 858 859

    return 0;
}

860
static int
861
remoteRelayDomainEventDeviceRemoved(virConnectPtr conn,
862 863 864 865
                                    virDomainPtr dom,
                                    const char *devAlias,
                                    void *opaque)
{
866
    daemonClientEventCallbackPtr callback = opaque;
867 868
    remote_domain_event_device_removed_msg data;

869 870
    if (callback->callbackID < 0 ||
        !remoteRelayDomainEventCheckACL(callback->client, conn, dom))
871 872
        return -1;

873 874
    VIR_DEBUG("Relaying domain device removed event %s %d %s, callback %d",
              dom->name, dom->id, devAlias, callback->callbackID);
875 876 877 878 879 880 881 882 883

    /* build return data */
    memset(&data, 0, sizeof(data));

    if (VIR_STRDUP(data.devAlias, devAlias) < 0)
        return -1;

    make_nonnull_domain(&data.dom, dom);

884 885 886 887 888 889 890 891 892 893 894 895 896 897
    if (callback->legacy) {
        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_DEVICE_REMOVED,
                                      (xdrproc_t)xdr_remote_domain_event_device_removed_msg,
                                      &data);
    } else {
        remote_domain_event_callback_device_removed_msg msg = { callback->callbackID,
                                                                data };

        remoteDispatchObjectEventSend(callback->client, remoteProgram,
                                      REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED,
                                      (xdrproc_t)xdr_remote_domain_event_callback_device_removed_msg,
                                      &msg);
    }
898 899 900 901

    return 0;
}

902

903
static virConnectDomainEventGenericCallback domainEventCallbacks[] = {
904
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventLifecycle),
905
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventReboot),
906
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventRTCChange),
907
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventWatchdog),
908
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventIOError),
909
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventGraphics),
910
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventIOErrorReason),
911
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventControlError),
912
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventBlockJob),
913
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventDiskChange),
914
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventTrayChange),
O
Osier Yang 已提交
915
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMWakeup),
O
Osier Yang 已提交
916
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMSuspend),
917
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventBalloonChange),
918
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventPMSuspendDisk),
919
    VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventDeviceRemoved),
920 921 922 923
};

verify(ARRAY_CARDINALITY(domainEventCallbacks) == VIR_DOMAIN_EVENT_ID_LAST);

924
static int
925
remoteRelayNetworkEventLifecycle(virConnectPtr conn,
926 927 928 929
                                 virNetworkPtr net,
                                 int event,
                                 int detail,
                                 void *opaque)
930
{
931
    daemonClientEventCallbackPtr callback = opaque;
932 933
    remote_network_event_lifecycle_msg data;

934 935
    if (callback->callbackID < 0 ||
        !remoteRelayNetworkEventCheckACL(callback->client, conn, net))
936 937
        return -1;

938 939
    VIR_DEBUG("Relaying network lifecycle event %d, detail %d, callback %d",
              event, detail, callback->callbackID);
940 941 942 943

    /* build return data */
    memset(&data, 0, sizeof(data));
    make_nonnull_network(&data.net, net);
944
    data.callbackID = callback->callbackID;
945 946 947
    data.event = event;
    data.detail = detail;

948
    remoteDispatchObjectEventSend(callback->client, remoteProgram,
949 950 951 952 953 954 955 956 957 958 959 960
                                  REMOTE_PROC_NETWORK_EVENT_LIFECYCLE,
                                  (xdrproc_t)xdr_remote_network_event_lifecycle_msg, &data);

    return 0;
}

static virConnectNetworkEventGenericCallback networkEventCallbacks[] = {
    VIR_NETWORK_EVENT_CALLBACK(remoteRelayNetworkEventLifecycle),
};

verify(ARRAY_CARDINALITY(networkEventCallbacks) == VIR_NETWORK_EVENT_ID_LAST);

961 962 963 964 965 966 967
/*
 * You must hold lock for at least the client
 * We don't free stuff here, merely disconnect the client's
 * network socket & resources.
 * We keep the libvirt connection open until any async
 * jobs have finished, then clean it up elsewhere
 */
968
void remoteClientFreeFunc(void *data)
969 970 971 972 973
{
    struct daemonClientPrivate *priv = data;

    /* Deregister event delivery callback */
    if (priv->conn) {
974
        virIdentityPtr sysident = virIdentityGetSystem();
975
        size_t i;
976

977 978
        virIdentitySetCurrent(sysident);

979 980 981 982 983
        for (i = 0; i < priv->ndomainEventCallbacks; i++) {
            int callbackID = priv->domainEventCallbacks[i]->callbackID;
            if (callbackID < 0) {
                VIR_WARN("unexpected incomplete domain callback %zu", i);
                continue;
984
            }
985 986 987 988 989
            VIR_DEBUG("Deregistering remote domain event relay %d",
                      callbackID);
            priv->domainEventCallbacks[i]->callbackID = -1;
            if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
                VIR_WARN("unexpected domain event deregister failure");
990
        }
991
        VIR_FREE(priv->domainEventCallbacks);
992

993 994 995 996 997
        for (i = 0; i < priv->nnetworkEventCallbacks; i++) {
            int callbackID = priv->networkEventCallbacks[i]->callbackID;
            if (callbackID < 0) {
                VIR_WARN("unexpected incomplete network callback %zu", i);
                continue;
998
            }
999 1000 1001 1002 1003 1004
            VIR_DEBUG("Deregistering remote network event relay %d",
                      callbackID);
            priv->networkEventCallbacks[i]->callbackID = -1;
            if (virConnectNetworkEventDeregisterAny(priv->conn,
                                                    callbackID) < 0)
                VIR_WARN("unexpected network event deregister failure");
1005
        }
1006
        VIR_FREE(priv->networkEventCallbacks);
1007

1008
        virConnectClose(priv->conn);
1009 1010 1011

        virIdentitySetCurrent(NULL);
        virObjectUnref(sysident);
1012 1013 1014 1015 1016 1017
    }

    VIR_FREE(priv);
}


1018 1019 1020 1021 1022 1023 1024
static void remoteClientCloseFunc(virNetServerClientPtr client)
{
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    daemonRemoveAllClientStreams(priv->streams);
}

1025

1026 1027
void *remoteClientInitHook(virNetServerClientPtr client,
                           void *opaque ATTRIBUTE_UNUSED)
1028 1029 1030
{
    struct daemonClientPrivate *priv;

1031
    if (VIR_ALLOC(priv) < 0)
1032
        return NULL;
1033 1034 1035

    if (virMutexInit(&priv->lock) < 0) {
        VIR_FREE(priv);
1036
        virReportSystemError(errno, "%s", _("unable to init mutex"));
1037
        return NULL;
1038 1039
    }

1040
    virNetServerClientSetCloseHook(client, remoteClientCloseFunc);
1041
    return priv;
1042 1043
}

1044 1045 1046
/*----- Functions. -----*/

static int
1047 1048 1049 1050 1051
remoteDispatchConnectOpen(virNetServerPtr server,
                          virNetServerClientPtr client,
                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                          virNetMessageErrorPtr rerr,
                          struct remote_connect_open_args *args)
1052 1053
{
    const char *name;
1054
    unsigned int flags;
1055
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
1056
    int rv = -1;
1057

1058 1059 1060 1061
    VIR_DEBUG("priv=%p conn=%p", priv, priv->conn);
    virMutexLock(&priv->lock);
    /* Already opened? */
    if (priv->conn) {
1062
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection already open"));
1063 1064 1065
        goto cleanup;
    }

1066
    if (virNetServerKeepAliveRequired(server) && !priv->keepalive_supported) {
1067 1068
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                       _("keepalive support is required to connect"));
1069 1070 1071
        goto cleanup;
    }

1072 1073 1074 1075 1076 1077
    name = args->name ? *args->name : NULL;

    /* If this connection arrived on a readonly socket, force
     * the connection to be readonly.
     */
    flags = args->flags;
1078 1079
    if (virNetServerClientGetReadonly(client))
        flags |= VIR_CONNECT_RO;
1080

1081
    priv->conn =
1082
        flags & VIR_CONNECT_RO
1083 1084
        ? virConnectOpenReadOnly(name)
        : virConnectOpen(name);
1085

1086
    if (priv->conn == NULL)
1087 1088 1089
        goto cleanup;

    rv = 0;
1090

1091 1092
cleanup:
    if (rv < 0)
1093 1094
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
1095
    return rv;
1096 1097 1098 1099
}


static int
1100 1101 1102 1103
remoteDispatchConnectClose(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                           virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED)
1104
{
1105
    virNetServerClientDelayedClose(client);
1106
    return 0;
1107 1108
}

1109

1110
static int
1111 1112
remoteDispatchDomainGetSchedulerType(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client ATTRIBUTE_UNUSED,
1113
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
1114
                                     virNetMessageErrorPtr rerr,
1115 1116
                                     remote_domain_get_scheduler_type_args *args,
                                     remote_domain_get_scheduler_type_ret *ret)
1117
{
1118
    virDomainPtr dom = NULL;
1119 1120
    char *type;
    int nparams;
1121
    int rv = -1;
1122 1123
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1124

1125
    if (!priv->conn) {
1126
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1127
        goto cleanup;
1128 1129
    }

1130
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1131
        goto cleanup;
1132

1133
    if (!(type = virDomainGetSchedulerType(dom, &nparams)))
1134
        goto cleanup;
1135 1136 1137

    ret->type = type;
    ret->nparams = nparams;
1138 1139 1140 1141
    rv = 0;

cleanup:
    if (rv < 0)
1142
        virNetMessageSaveError(rerr);
1143 1144 1145
    if (dom)
        virDomainFree(dom);
    return rv;
1146 1147
}

1148 1149
/* Helper to serialize typed parameters. This also filters out any string
 * parameters that must not be returned to older clients.  */
1150 1151 1152
static int
remoteSerializeTypedParameters(virTypedParameterPtr params,
                               int nparams,
1153
                               remote_typed_param **ret_params_val,
1154 1155
                               u_int *ret_params_len,
                               unsigned int flags)
1156
{
1157 1158
    size_t i;
    size_t j;
1159 1160 1161 1162
    int rv = -1;
    remote_typed_param *val;

    *ret_params_len = nparams;
1163
    if (VIR_ALLOC_N(val, nparams) < 0)
1164 1165
        goto cleanup;

1166
    for (i = 0, j = 0; i < nparams; ++i) {
1167 1168 1169 1170 1171
        /* virDomainGetCPUStats can return a sparse array; also, we
         * can't pass back strings to older clients.  */
        if (!params[i].type ||
            (!(flags & VIR_TYPED_PARAM_STRING_OKAY) &&
             params[i].type == VIR_TYPED_PARAM_STRING)) {
1172 1173 1174 1175
            --*ret_params_len;
            continue;
        }

1176
        /* remoteDispatchClientRequest will free this: */
1177
        if (VIR_STRDUP(val[j].field, params[i].field) < 0)
1178
            goto cleanup;
1179
        val[j].value.type = params[i].type;
1180
        switch (params[i].type) {
1181
        case VIR_TYPED_PARAM_INT:
1182
            val[j].value.remote_typed_param_value_u.i = params[i].value.i;
1183 1184
            break;
        case VIR_TYPED_PARAM_UINT:
1185
            val[j].value.remote_typed_param_value_u.ui = params[i].value.ui;
1186 1187
            break;
        case VIR_TYPED_PARAM_LLONG:
1188
            val[j].value.remote_typed_param_value_u.l = params[i].value.l;
1189 1190
            break;
        case VIR_TYPED_PARAM_ULLONG:
1191
            val[j].value.remote_typed_param_value_u.ul = params[i].value.ul;
1192 1193
            break;
        case VIR_TYPED_PARAM_DOUBLE:
1194
            val[j].value.remote_typed_param_value_u.d = params[i].value.d;
1195 1196
            break;
        case VIR_TYPED_PARAM_BOOLEAN:
1197 1198 1199
            val[j].value.remote_typed_param_value_u.b = params[i].value.b;
            break;
        case VIR_TYPED_PARAM_STRING:
1200
            if (VIR_STRDUP(val[j].value.remote_typed_param_value_u.s, params[i].value.s) < 0)
1201
                goto cleanup;
1202 1203
            break;
        default:
1204 1205
            virReportError(VIR_ERR_RPC, _("unknown parameter type: %d"),
                           params[i].type);
1206 1207
            goto cleanup;
        }
1208
        j++;
1209 1210 1211 1212 1213 1214 1215 1216
    }

    *ret_params_val = val;
    val = NULL;
    rv = 0;

cleanup:
    if (val) {
1217
        for (i = 0; i < nparams; i++) {
1218
            VIR_FREE(val[i].field);
1219
            if (val[i].value.type == VIR_TYPED_PARAM_STRING)
1220 1221
                VIR_FREE(val[i].value.remote_typed_param_value_u.s);
        }
1222 1223 1224 1225 1226 1227 1228
        VIR_FREE(val);
    }
    return rv;
}

/* Helper to deserialize typed parameters. */
static virTypedParameterPtr
1229 1230
remoteDeserializeTypedParameters(remote_typed_param *args_params_val,
                                 u_int args_params_len,
1231 1232 1233
                                 int limit,
                                 int *nparams)
{
1234
    size_t i = 0;
1235 1236 1237 1238
    int rv = -1;
    virTypedParameterPtr params = NULL;

    /* Check the length of the returned list carefully. */
1239
    if (limit && args_params_len > limit) {
1240
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1241 1242
        goto cleanup;
    }
1243
    if (VIR_ALLOC_N(params, args_params_len) < 0)
1244 1245 1246 1247 1248 1249 1250 1251
        goto cleanup;

    *nparams = args_params_len;

    /* Deserialise the result. */
    for (i = 0; i < args_params_len; ++i) {
        if (virStrcpyStatic(params[i].field,
                            args_params_val[i].field) == NULL) {
1252 1253 1254
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Parameter %s too big for destination"),
                           args_params_val[i].field);
1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282
            goto cleanup;
        }
        params[i].type = args_params_val[i].value.type;
        switch (params[i].type) {
        case VIR_TYPED_PARAM_INT:
            params[i].value.i =
                args_params_val[i].value.remote_typed_param_value_u.i;
            break;
        case VIR_TYPED_PARAM_UINT:
            params[i].value.ui =
                args_params_val[i].value.remote_typed_param_value_u.ui;
            break;
        case VIR_TYPED_PARAM_LLONG:
            params[i].value.l =
                args_params_val[i].value.remote_typed_param_value_u.l;
            break;
        case VIR_TYPED_PARAM_ULLONG:
            params[i].value.ul =
                args_params_val[i].value.remote_typed_param_value_u.ul;
            break;
        case VIR_TYPED_PARAM_DOUBLE:
            params[i].value.d =
                args_params_val[i].value.remote_typed_param_value_u.d;
            break;
        case VIR_TYPED_PARAM_BOOLEAN:
            params[i].value.b =
                args_params_val[i].value.remote_typed_param_value_u.b;
            break;
1283
        case VIR_TYPED_PARAM_STRING:
1284 1285
            if (VIR_STRDUP(params[i].value.s,
                           args_params_val[i].value.remote_typed_param_value_u.s) < 0)
1286 1287
                goto cleanup;
            break;
1288
        default:
1289 1290
            virReportError(VIR_ERR_INTERNAL_ERROR, _("unknown parameter type: %d"),
                           params[i].type);
1291 1292 1293 1294 1295 1296 1297
            goto cleanup;
        }
    }

    rv = 0;

cleanup:
1298
    if (rv < 0) {
1299 1300
        virTypedParamsFree(params, i);
        params = NULL;
1301
    }
1302 1303 1304
    return params;
}

1305
static int
1306 1307
remoteDispatchDomainGetSchedulerParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
1308
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
1309
                                           virNetMessageErrorPtr rerr,
1310 1311
                                           remote_domain_get_scheduler_parameters_args *args,
                                           remote_domain_get_scheduler_parameters_ret *ret)
1312
{
1313
    virDomainPtr dom = NULL;
1314
    virTypedParameterPtr params = NULL;
1315
    int nparams = 0;
1316
    int rv = -1;
1317 1318
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1319

1320
    if (!priv->conn) {
1321
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1322
        goto cleanup;
1323 1324
    }

1325
    if (args->nparams > REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX) {
1326
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1327
        goto cleanup;
1328
    }
1329
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1330
        goto cleanup;
1331
    nparams = args->nparams;
1332

1333
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1334
        goto cleanup;
1335

1336
    if (virDomainGetSchedulerParameters(dom, params, &nparams) < 0)
1337
        goto cleanup;
1338

1339
    if (remoteSerializeTypedParameters(params, nparams,
1340
                                       &ret->params.params_val,
1341 1342
                                       &ret->params.params_len,
                                       0) < 0)
1343 1344 1345 1346 1347 1348
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
1349
        virNetMessageSaveError(rerr);
1350
    virTypedParamsFree(params, nparams);
1351 1352 1353 1354 1355
    if (dom)
        virDomainFree(dom);
    return rv;
}

1356 1357 1358 1359 1360 1361 1362 1363 1364 1365
static int
remoteDispatchConnectListAllDomains(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client,
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                    virNetMessageErrorPtr rerr,
                                    remote_connect_list_all_domains_args *args,
                                    remote_connect_list_all_domains_ret *ret)
{
    virDomainPtr *doms = NULL;
    int ndomains = 0;
1366
    size_t i;
1367 1368 1369 1370
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
1371
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1372 1373 1374 1375 1376 1377 1378 1379
        goto cleanup;
    }

    if ((ndomains = virConnectListAllDomains(priv->conn,
                                             args->need_results ? &doms : NULL,
                                             args->flags)) < 0)
        goto cleanup;

1380 1381 1382 1383 1384 1385 1386
    if (ndomains > REMOTE_DOMAIN_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domains '%d' for limit '%d'"),
                       ndomains, REMOTE_DOMAIN_LIST_MAX);
        goto cleanup;
    }

1387
    if (doms && ndomains) {
1388
        if (VIR_ALLOC_N(ret->domains.domains_val, ndomains) < 0)
1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414
            goto cleanup;

        ret->domains.domains_len = ndomains;

        for (i = 0; i < ndomains; i++)
            make_nonnull_domain(ret->domains.domains_val + i, doms[i]);
    } else {
        ret->domains.domains_len = 0;
        ret->domains.domains_val = NULL;
    }

    ret->ret = ndomains;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (doms) {
        for (i = 0; i < ndomains; i++)
            virDomainFree(doms[i]);
        VIR_FREE(doms);
    }
    return rv;
}

1415
static int
1416 1417
remoteDispatchDomainGetSchedulerParametersFlags(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
1418
                                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
1419
                                                virNetMessageErrorPtr rerr,
1420 1421 1422 1423 1424
                                                remote_domain_get_scheduler_parameters_flags_args *args,
                                                remote_domain_get_scheduler_parameters_flags_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
1425
    int nparams = 0;
1426
    int rv = -1;
1427 1428
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1429

1430
    if (!priv->conn) {
1431
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1432 1433 1434
        goto cleanup;
    }

1435
    if (args->nparams > REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX) {
1436
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1437 1438
        goto cleanup;
    }
1439
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1440
        goto cleanup;
1441
    nparams = args->nparams;
1442

1443
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1444 1445 1446 1447 1448 1449 1450
        goto cleanup;

    if (virDomainGetSchedulerParametersFlags(dom, params, &nparams,
                                             args->flags) < 0)
        goto cleanup;

    if (remoteSerializeTypedParameters(params, nparams,
1451
                                       &ret->params.params_val,
1452 1453
                                       &ret->params.params_len,
                                       args->flags) < 0)
1454
        goto cleanup;
1455

1456
    rv = 0;
1457 1458

cleanup:
1459
    if (rv < 0)
1460
        virNetMessageSaveError(rerr);
1461
    virTypedParamsFree(params, nparams);
1462 1463 1464
    if (dom)
        virDomainFree(dom);
    return rv;
1465 1466
}

1467
static int
1468 1469
remoteDispatchDomainMemoryStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
1470
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
1471
                                virNetMessageErrorPtr rerr,
1472 1473
                                remote_domain_memory_stats_args *args,
                                remote_domain_memory_stats_ret *ret)
1474
{
1475
    virDomainPtr dom = NULL;
1476
    struct _virDomainMemoryStat *stats = NULL;
1477 1478
    int nr_stats;
    size_t i;
1479
    int rv = -1;
1480 1481
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1482

1483
    if (!priv->conn) {
1484
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1485
        goto cleanup;
1486 1487
    }

1488
    if (args->maxStats > REMOTE_DOMAIN_MEMORY_STATS_MAX) {
1489 1490
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("maxStats > REMOTE_DOMAIN_MEMORY_STATS_MAX"));
1491
        goto cleanup;
1492 1493
    }

1494
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1495
        goto cleanup;
1496 1497

    /* Allocate stats array for making dispatch call */
1498
    if (VIR_ALLOC_N(stats, args->maxStats) < 0)
1499
        goto cleanup;
1500

1501
    nr_stats = virDomainMemoryStats(dom, stats, args->maxStats, args->flags);
1502
    if (nr_stats < 0)
1503
        goto cleanup;
1504 1505

    /* Allocate return buffer */
1506
    if (VIR_ALLOC_N(ret->stats.stats_val, args->maxStats) < 0)
1507
        goto cleanup;
1508 1509 1510 1511 1512 1513 1514

    /* Copy the stats into the xdr return structure */
    for (i = 0; i < nr_stats; i++) {
        ret->stats.stats_val[i].tag = stats[i].tag;
        ret->stats.stats_val[i].val = stats[i].val;
    }
    ret->stats.stats_len = nr_stats;
1515 1516 1517 1518
    rv = 0;

cleanup:
    if (rv < 0)
1519
        virNetMessageSaveError(rerr);
1520 1521
    if (dom)
        virDomainFree(dom);
1522
    VIR_FREE(stats);
1523
    return rv;
1524 1525
}

1526
static int
1527 1528
remoteDispatchDomainBlockPeek(virNetServerPtr server ATTRIBUTE_UNUSED,
                              virNetServerClientPtr client ATTRIBUTE_UNUSED,
1529
                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
1530
                              virNetMessageErrorPtr rerr,
1531 1532
                              remote_domain_block_peek_args *args,
                              remote_domain_block_peek_ret *ret)
1533
{
1534
    virDomainPtr dom = NULL;
1535 1536 1537 1538
    char *path;
    unsigned long long offset;
    size_t size;
    unsigned int flags;
1539
    int rv = -1;
1540 1541
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1542

1543
    if (!priv->conn) {
1544
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1545
        goto cleanup;
1546 1547
    }

1548
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1549
        goto cleanup;
1550 1551 1552 1553 1554 1555
    path = args->path;
    offset = args->offset;
    size = args->size;
    flags = args->flags;

    if (size > REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX) {
1556 1557
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("size > maximum buffer size"));
1558
        goto cleanup;
1559 1560 1561
    }

    ret->buffer.buffer_len = size;
1562
    if (VIR_ALLOC_N(ret->buffer.buffer_val, size) < 0)
1563
        goto cleanup;
1564

1565
    if (virDomainBlockPeek(dom, path, offset, size,
1566
                           ret->buffer.buffer_val, flags) < 0)
1567
        goto cleanup;
1568

1569 1570 1571 1572
    rv = 0;

cleanup:
    if (rv < 0) {
1573
        virNetMessageSaveError(rerr);
1574 1575 1576 1577 1578
        VIR_FREE(ret->buffer.buffer_val);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
1579 1580
}

1581 1582 1583
static int
remoteDispatchDomainBlockStatsFlags(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
1584
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
1585 1586 1587 1588 1589 1590 1591
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_block_stats_flags_args *args,
                                    remote_domain_block_stats_flags_ret *ret)
{
    virTypedParameterPtr params = NULL;
    virDomainPtr dom = NULL;
    const char *path = args->path;
1592
    int nparams = 0;
1593 1594 1595 1596 1597 1598
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
1599
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1600 1601 1602 1603 1604 1605 1606
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;
    flags = args->flags;

1607
    if (args->nparams > REMOTE_DOMAIN_BLOCK_STATS_PARAMETERS_MAX) {
1608
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
1609 1610
        goto cleanup;
    }
1611
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
1612
        goto cleanup;
1613
    nparams = args->nparams;
1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628

    if (virDomainBlockStatsFlags(dom, path, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the block stats. */
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
1629 1630
                                       &ret->params.params_len,
                                       args->flags) < 0)
1631 1632 1633 1634 1635 1636
        goto cleanup;

success:
    rv = 0;

cleanup:
1637
    if (rv < 0)
1638
        virNetMessageSaveError(rerr);
1639
    virTypedParamsFree(params, nparams);
A
ajia@redhat.com 已提交
1640 1641
    if (dom)
        virDomainFree(dom);
1642 1643 1644
    return rv;
}

R
Richard W.M. Jones 已提交
1645
static int
1646 1647
remoteDispatchDomainMemoryPeek(virNetServerPtr server ATTRIBUTE_UNUSED,
                               virNetServerClientPtr client ATTRIBUTE_UNUSED,
1648
                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
1649
                               virNetMessageErrorPtr rerr,
1650 1651
                               remote_domain_memory_peek_args *args,
                               remote_domain_memory_peek_ret *ret)
R
Richard W.M. Jones 已提交
1652
{
1653
    virDomainPtr dom = NULL;
R
Richard W.M. Jones 已提交
1654 1655 1656
    unsigned long long offset;
    size_t size;
    unsigned int flags;
1657
    int rv = -1;
1658 1659
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
R
Richard W.M. Jones 已提交
1660

1661
    if (!priv->conn) {
1662
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1663
        goto cleanup;
1664 1665
    }

1666
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1667
        goto cleanup;
R
Richard W.M. Jones 已提交
1668 1669 1670 1671 1672
    offset = args->offset;
    size = args->size;
    flags = args->flags;

    if (size > REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX) {
1673 1674
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("size > maximum buffer size"));
1675
        goto cleanup;
R
Richard W.M. Jones 已提交
1676 1677 1678
    }

    ret->buffer.buffer_len = size;
1679
    if (VIR_ALLOC_N(ret->buffer.buffer_val, size) < 0)
1680
        goto cleanup;
R
Richard W.M. Jones 已提交
1681

1682
    if (virDomainMemoryPeek(dom, offset, size,
1683
                            ret->buffer.buffer_val, flags) < 0)
1684
        goto cleanup;
R
Richard W.M. Jones 已提交
1685

1686 1687 1688 1689
    rv = 0;

cleanup:
    if (rv < 0) {
1690
        virNetMessageSaveError(rerr);
1691 1692 1693 1694 1695
        VIR_FREE(ret->buffer.buffer_val);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
R
Richard W.M. Jones 已提交
1696 1697
}

1698
static int
1699 1700
remoteDispatchDomainGetSecurityLabel(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client ATTRIBUTE_UNUSED,
1701
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
1702
                                     virNetMessageErrorPtr rerr,
1703 1704
                                     remote_domain_get_security_label_args *args,
                                     remote_domain_get_security_label_ret *ret)
1705
{
1706 1707
    virDomainPtr dom = NULL;
    virSecurityLabelPtr seclabel = NULL;
1708
    int rv = -1;
1709 1710
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1711

1712
    if (!priv->conn) {
1713
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1714
        goto cleanup;
1715 1716
    }

1717
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1718 1719
        goto cleanup;

1720
    if (VIR_ALLOC(seclabel) < 0)
1721 1722 1723 1724 1725 1726
        goto cleanup;

    if (virDomainGetSecurityLabel(dom, seclabel) < 0)
        goto cleanup;

    ret->label.label_len = strlen(seclabel->label) + 1;
1727
    if (VIR_ALLOC_N(ret->label.label_val, ret->label.label_len) < 0)
1728
        goto cleanup;
1729 1730
    strcpy(ret->label.label_val, seclabel->label);
    ret->enforcing = seclabel->enforcing;
1731

1732 1733 1734 1735
    rv = 0;

cleanup:
    if (rv < 0)
1736
        virNetMessageSaveError(rerr);
1737 1738 1739
    if (dom)
        virDomainFree(dom);
    VIR_FREE(seclabel);
1740
    return rv;
1741 1742
}

M
Marcelo Cerri 已提交
1743 1744 1745 1746 1747 1748 1749 1750 1751 1752
static int
remoteDispatchDomainGetSecurityLabelList(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_domain_get_security_label_list_args *args,
                                         remote_domain_get_security_label_list_ret *ret)
{
    virDomainPtr dom = NULL;
    virSecurityLabelPtr seclabels = NULL;
1753 1754
    int len, rv = -1;
    size_t i;
M
Marcelo Cerri 已提交
1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((len = virDomainGetSecurityLabelList(dom, &seclabels)) < 0) {
        ret->ret = len;
        ret->labels.labels_len = 0;
        ret->labels.labels_val = NULL;
        goto done;
    }

1773
    if (VIR_ALLOC_N(ret->labels.labels_val, len) < 0)
M
Marcelo Cerri 已提交
1774 1775 1776 1777 1778
        goto cleanup;

    for (i = 0; i < len; i++) {
        size_t label_len = strlen(seclabels[i].label) + 1;
        remote_domain_get_security_label_ret *cur = &ret->labels.labels_val[i];
1779
        if (VIR_ALLOC_N(cur->label.label_val, label_len) < 0)
M
Marcelo Cerri 已提交
1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802
            goto cleanup;
        if (virStrcpy(cur->label.label_val, seclabels[i].label, label_len) == NULL) {
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("failed to copy security label"));
            goto cleanup;
        }
        cur->label.label_len = label_len;
        cur->enforcing = seclabels[i].enforcing;
    }
    ret->labels.labels_len = ret->ret = len;

done:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    VIR_FREE(seclabels);
    return rv;
}

1803
static int
1804 1805
remoteDispatchNodeGetSecurityModel(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
1806
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
1807
                                   virNetMessageErrorPtr rerr,
1808
                                   remote_node_get_security_model_ret *ret)
1809
{
1810
    virSecurityModel secmodel;
1811
    int rv = -1;
1812 1813
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1814

1815
    if (!priv->conn) {
1816
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1817
        goto cleanup;
1818 1819
    }

1820
    memset(&secmodel, 0, sizeof(secmodel));
1821
    if (virNodeGetSecurityModel(priv->conn, &secmodel) < 0)
1822 1823 1824
        goto cleanup;

    ret->model.model_len = strlen(secmodel.model) + 1;
1825
    if (VIR_ALLOC_N(ret->model.model_val, ret->model.model_len) < 0)
1826 1827 1828 1829
        goto cleanup;
    strcpy(ret->model.model_val, secmodel.model);

    ret->doi.doi_len = strlen(secmodel.doi) + 1;
1830
    if (VIR_ALLOC_N(ret->doi.doi_val, ret->doi.doi_len) < 0)
1831
        goto cleanup;
1832
    strcpy(ret->doi.doi_val, secmodel.doi);
1833

1834 1835 1836 1837
    rv = 0;

cleanup:
    if (rv < 0)
1838
        virNetMessageSaveError(rerr);
1839
    return rv;
1840 1841
}

1842
static int
1843 1844
remoteDispatchDomainGetVcpuPinInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
1845
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
1846
                                   virNetMessageErrorPtr rerr,
E
Eric Blake 已提交
1847 1848
                                   remote_domain_get_vcpu_pin_info_args *args,
                                   remote_domain_get_vcpu_pin_info_ret *ret)
1849 1850 1851 1852 1853
{
    virDomainPtr dom = NULL;
    unsigned char *cpumaps = NULL;
    int num;
    int rv = -1;
1854 1855
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
1856

1857
    if (!priv->conn) {
1858
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
1859 1860 1861
        goto cleanup;
    }

1862
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
1863 1864 1865
        goto cleanup;

    if (args->ncpumaps > REMOTE_VCPUINFO_MAX) {
1866
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("ncpumaps > REMOTE_VCPUINFO_MAX"));
1867 1868 1869 1870 1871
        goto cleanup;
    }

    if (INT_MULTIPLY_OVERFLOW(args->ncpumaps, args->maplen) ||
        args->ncpumaps * args->maplen > REMOTE_CPUMAPS_MAX) {
1872
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo * maplen > REMOTE_CPUMAPS_MAX"));
1873 1874 1875 1876 1877 1878
        goto cleanup;
    }

    /* Allocate buffers to take the results. */
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->ncpumaps * args->maplen) < 0)
1879
        goto cleanup;
1880

E
Eric Blake 已提交
1881
    if ((num = virDomainGetVcpuPinInfo(dom,
1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894
                                       args->ncpumaps,
                                       cpumaps,
                                       args->maplen,
                                       args->flags)) < 0)
        goto cleanup;

    ret->num = num;
    /* Don't need to allocate/copy the cpumaps if we make the reasonable
     * assumption that unsigned char and char are the same size.
     * Note that remoteDispatchClientRequest will free.
     */
    ret->cpumaps.cpumaps_len = args->ncpumaps * args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970
    cpumaps = NULL;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    VIR_FREE(cpumaps);
    if (dom)
        virDomainFree(dom);
    return rv;
}

static int
remoteDispatchDomainPinEmulator(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client,
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_pin_emulator_args *args)
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainPinEmulator(dom,
                             (unsigned char *) args->cpumap.cpumap_val,
                             args->cpumap.cpumap_len,
                             args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
remoteDispatchDomainGetEmulatorPinInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_get_emulator_pin_info_args *args,
                                       remote_domain_get_emulator_pin_info_ret *ret)
{
    virDomainPtr dom = NULL;
    unsigned char *cpumaps = NULL;
    int r;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    /* Allocate buffers to take the results */
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->maplen) < 0)
1971
        goto cleanup;
1972 1973 1974 1975 1976 1977 1978 1979 1980 1981

    if ((r = virDomainGetEmulatorPinInfo(dom,
                                         cpumaps,
                                         args->maplen,
                                         args->flags)) < 0)
        goto cleanup;

    ret->ret = r;
    ret->cpumaps.cpumaps_len = args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
1982 1983 1984 1985 1986 1987
    cpumaps = NULL;

    rv = 0;

cleanup:
    if (rv < 0)
1988
        virNetMessageSaveError(rerr);
1989 1990 1991 1992 1993 1994
    VIR_FREE(cpumaps);
    if (dom)
        virDomainFree(dom);
    return rv;
}

1995
static int
1996 1997
remoteDispatchDomainGetVcpus(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
1998
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
1999
                             virNetMessageErrorPtr rerr,
2000 2001
                             remote_domain_get_vcpus_args *args,
                             remote_domain_get_vcpus_ret *ret)
2002
{
2003
    virDomainPtr dom = NULL;
2004 2005
    virVcpuInfoPtr info = NULL;
    unsigned char *cpumaps = NULL;
2006 2007
    int info_len;
    size_t i;
2008
    int rv = -1;
2009 2010
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2011

2012
    if (!priv->conn) {
2013
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2014
        goto cleanup;
2015 2016
    }

2017
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2018
        goto cleanup;
2019

2020
    if (args->maxinfo > REMOTE_VCPUINFO_MAX) {
2021
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo > REMOTE_VCPUINFO_MAX"));
2022
        goto cleanup;
2023
    }
2024

2025 2026
    if (INT_MULTIPLY_OVERFLOW(args->maxinfo, args->maplen) ||
        args->maxinfo * args->maplen > REMOTE_CPUMAPS_MAX) {
2027
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("maxinfo * maplen > REMOTE_CPUMAPS_MAX"));
2028 2029 2030 2031 2032
        goto cleanup;
    }

    /* Allocate buffers to take the results. */
    if (VIR_ALLOC_N(info, args->maxinfo) < 0)
2033
        goto cleanup;
2034 2035
    if (args->maplen > 0 &&
        VIR_ALLOC_N(cpumaps, args->maxinfo * args->maplen) < 0)
2036
        goto cleanup;
2037 2038 2039 2040 2041 2042 2043 2044 2045

    if ((info_len = virDomainGetVcpus(dom,
                                      info, args->maxinfo,
                                      cpumaps, args->maplen)) < 0)
        goto cleanup;

    /* Allocate the return buffer for info. */
    ret->info.info_len = info_len;
    if (VIR_ALLOC_N(ret->info.info_val, info_len) < 0)
2046
        goto cleanup;
2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063

    for (i = 0; i < info_len; ++i) {
        ret->info.info_val[i].number = info[i].number;
        ret->info.info_val[i].state = info[i].state;
        ret->info.info_val[i].cpu_time = info[i].cpuTime;
        ret->info.info_val[i].cpu = info[i].cpu;
    }

    /* Don't need to allocate/copy the cpumaps if we make the reasonable
     * assumption that unsigned char and char are the same size.
     * Note that remoteDispatchClientRequest will free.
     */
    ret->cpumaps.cpumaps_len = args->maxinfo * args->maplen;
    ret->cpumaps.cpumaps_val = (char *) cpumaps;
    cpumaps = NULL;

    rv = 0;
2064 2065

cleanup:
2066
    if (rv < 0) {
2067
        virNetMessageSaveError(rerr);
2068 2069 2070 2071
        VIR_FREE(ret->info.info_val);
    }
    VIR_FREE(cpumaps);
    VIR_FREE(info);
2072 2073 2074
    if (dom)
        virDomainFree(dom);
    return rv;
2075 2076 2077
}

static int
2078 2079
remoteDispatchDomainMigratePrepare(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
2080
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
2081
                                   virNetMessageErrorPtr rerr,
2082 2083
                                   remote_domain_migrate_prepare_args *args,
                                   remote_domain_migrate_prepare_ret *ret)
2084
{
2085 2086 2087 2088 2089
    char *cookie = NULL;
    int cookielen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
2090
    int rv = -1;
2091 2092
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2093

2094
    if (!priv->conn) {
2095
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2096
        goto cleanup;
2097 2098
    }

2099 2100 2101 2102
    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;

    /* Wacky world of XDR ... */
2103
    if (VIR_ALLOC(uri_out) < 0)
2104
        goto cleanup;
2105

2106
    if (virDomainMigratePrepare(priv->conn, &cookie, &cookielen,
2107 2108
                                uri_in, uri_out,
                                args->flags, dname, args->resource) < 0)
2109
        goto cleanup;
2110

2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121
    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie.cookie_len = cookielen;
    ret->cookie.cookie_val = cookie;
    if (*uri_out == NULL) {
        ret->uri_out = NULL;
    } else {
        ret->uri_out = uri_out;
        uri_out = NULL;
    }
2122

2123
    rv = 0;
2124

2125 2126
cleanup:
    if (rv < 0)
2127
        virNetMessageSaveError(rerr);
2128
    VIR_FREE(uri_out);
2129
    return rv;
2130 2131
}

2132
static int
2133 2134
remoteDispatchDomainMigratePrepare2(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
2135
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
2136
                                    virNetMessageErrorPtr rerr,
2137 2138
                                    remote_domain_migrate_prepare2_args *args,
                                    remote_domain_migrate_prepare2_ret *ret)
2139
{
2140 2141 2142 2143 2144
    char *cookie = NULL;
    int cookielen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
2145
    int rv = -1;
2146 2147
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2148

2149
    if (!priv->conn) {
2150
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2151
        goto cleanup;
2152 2153
    }

2154 2155
    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;
2156

2157
    /* Wacky world of XDR ... */
2158
    if (VIR_ALLOC(uri_out) < 0)
2159
        goto cleanup;
2160

2161
    if (virDomainMigratePrepare2(priv->conn, &cookie, &cookielen,
2162 2163 2164
                                 uri_in, uri_out,
                                 args->flags, dname, args->resource,
                                 args->dom_xml) < 0)
2165
        goto cleanup;
2166

2167 2168 2169 2170 2171 2172
    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie.cookie_len = cookielen;
    ret->cookie.cookie_val = cookie;
    ret->uri_out = *uri_out == NULL ? NULL : uri_out;
2173

2174 2175 2176 2177
    rv = 0;

cleanup:
    if (rv < 0)
2178
        virNetMessageSaveError(rerr);
2179
    return rv;
2180 2181
}

C
Chris Lalancette 已提交
2182
static int
2183 2184
remoteDispatchDomainGetMemoryParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client ATTRIBUTE_UNUSED,
2185
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
2186 2187 2188
                                        virNetMessageErrorPtr rerr,
                                        remote_domain_get_memory_parameters_args *args,
                                        remote_domain_get_memory_parameters_ret *ret)
C
Chris Lalancette 已提交
2189
{
2190
    virDomainPtr dom = NULL;
2191
    virTypedParameterPtr params = NULL;
2192
    int nparams = 0;
2193
    unsigned int flags;
2194
    int rv = -1;
2195 2196
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2197

2198
    if (!priv->conn) {
2199
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2200
        goto cleanup;
2201
    }
C
Chris Lalancette 已提交
2202

2203
    flags = args->flags;
C
Chris Lalancette 已提交
2204

2205
    if (args->nparams > REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX) {
2206
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2207 2208
        goto cleanup;
    }
2209
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2210
        goto cleanup;
2211
    nparams = args->nparams;
C
Chris Lalancette 已提交
2212

2213
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2214
        goto cleanup;
C
Chris Lalancette 已提交
2215

2216
    if (virDomainGetMemoryParameters(dom, params, &nparams, flags) < 0)
2217
        goto cleanup;
C
Chris Lalancette 已提交
2218

2219 2220 2221 2222 2223 2224
    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
2225 2226
    }

2227
    if (remoteSerializeTypedParameters(params, nparams,
2228
                                       &ret->params.params_val,
2229 2230
                                       &ret->params.params_len,
                                       args->flags) < 0)
2231
        goto cleanup;
2232

2233
success:
2234 2235 2236
    rv = 0;

cleanup:
2237
    if (rv < 0)
2238
        virNetMessageSaveError(rerr);
2239
    virTypedParamsFree(params, nparams);
2240 2241 2242
    if (dom)
        virDomainFree(dom);
    return rv;
2243 2244
}

2245 2246 2247 2248 2249 2250 2251 2252 2253 2254
static int
remoteDispatchDomainGetNumaParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_domain_get_numa_parameters_args *args,
                                      remote_domain_get_numa_parameters_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
2255
    int nparams = 0;
2256 2257 2258 2259 2260 2261
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2262
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2263 2264 2265 2266 2267
        goto cleanup;
    }

    flags = args->flags;

2268
    if (args->nparams > REMOTE_DOMAIN_NUMA_PARAMETERS_MAX) {
2269
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2270 2271
        goto cleanup;
    }
2272
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2273
        goto cleanup;
2274
    nparams = args->nparams;
2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetNumaParameters(dom, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
2302
    virTypedParamsFree(params, nparams);
2303 2304 2305 2306 2307
    if (dom)
        virDomainFree(dom);
    return rv;
}

2308
static int
2309 2310
remoteDispatchDomainGetBlkioParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client ATTRIBUTE_UNUSED,
2311
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
2312 2313 2314
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_get_blkio_parameters_args *args,
                                       remote_domain_get_blkio_parameters_ret *ret)
2315
{
2316
    virDomainPtr dom = NULL;
2317
    virTypedParameterPtr params = NULL;
2318
    int nparams = 0;
2319
    unsigned int flags;
2320
    int rv = -1;
2321 2322
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2323

2324
    if (!priv->conn) {
2325
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2326
        goto cleanup;
2327 2328
    }

2329 2330
    flags = args->flags;

2331
    if (args->nparams > REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX) {
2332
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2333
        goto cleanup;
2334
    }
2335
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2336
        goto cleanup;
2337
    nparams = args->nparams;
2338

2339
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
2340
        goto cleanup;
2341

2342
    if (virDomainGetBlkioParameters(dom, params, &nparams, flags) < 0)
2343
        goto cleanup;
2344

2345 2346 2347 2348 2349 2350 2351 2352
    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

2353
    if (remoteSerializeTypedParameters(params, nparams,
2354
                                       &ret->params.params_val,
2355 2356
                                       &ret->params.params_len,
                                       args->flags) < 0)
2357
        goto cleanup;
2358

2359 2360
success:
    rv = 0;
2361

2362
cleanup:
2363
    if (rv < 0)
2364
        virNetMessageSaveError(rerr);
2365
    virTypedParamsFree(params, nparams);
2366 2367 2368
    if (dom)
        virDomainFree(dom);
    return rv;
2369 2370
}

2371
static int
2372 2373
remoteDispatchNodeGetCPUStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                              virNetServerClientPtr client ATTRIBUTE_UNUSED,
2374
                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
2375 2376 2377
                              virNetMessageErrorPtr rerr,
                              remote_node_get_cpu_stats_args *args,
                              remote_node_get_cpu_stats_ret *ret)
2378
{
2379
    virNodeCPUStatsPtr params = NULL;
2380
    size_t i;
2381
    int cpuNum = args->cpuNum;
2382
    int nparams = 0;
2383 2384
    unsigned int flags;
    int rv = -1;
2385 2386
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2387

2388
    if (!priv->conn) {
2389
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2390 2391 2392 2393 2394
        goto cleanup;
    }

    flags = args->flags;

2395
    if (args->nparams > REMOTE_NODE_CPU_STATS_MAX) {
2396
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2397 2398
        goto cleanup;
    }
2399
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2400
        goto cleanup;
2401
    nparams = args->nparams;
2402

2403
    if (virNodeGetCPUStats(priv->conn, cpuNum, params, &nparams, flags) < 0)
2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416
        goto cleanup;

    /* In this case, we need to send back the number of stats
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the memory parameters. */
    ret->params.params_len = nparams;
    if (VIR_ALLOC_N(ret->params.params_val, nparams) < 0)
2417
        goto cleanup;
2418 2419 2420

    for (i = 0; i < nparams; ++i) {
        /* remoteDispatchClientRequest will free this: */
2421 2422
        if (VIR_STRDUP(ret->params.params_val[i].field, params[i].field) < 0)
            goto cleanup;
2423 2424 2425 2426 2427 2428 2429

        ret->params.params_val[i].value = params[i].value;
    }

success:
    rv = 0;

2430 2431
cleanup:
    if (rv < 0) {
2432
        virNetMessageSaveError(rerr);
2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443
        if (ret->params.params_val) {
            for (i = 0; i < nparams; i++)
                VIR_FREE(ret->params.params_val[i].field);
            VIR_FREE(ret->params.params_val);
        }
    }
    VIR_FREE(params);
    return rv;
}

static int
2444 2445
remoteDispatchNodeGetMemoryStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
2446
                                 virNetMessagePtr msg ATTRIBUTE_UNUSED,
2447 2448 2449
                                 virNetMessageErrorPtr rerr,
                                 remote_node_get_memory_stats_args *args,
                                 remote_node_get_memory_stats_ret *ret)
2450
{
2451
    virNodeMemoryStatsPtr params = NULL;
2452
    size_t i;
2453
    int cellNum = args->cellNum;
2454
    int nparams = 0;
2455 2456
    unsigned int flags;
    int rv = -1;
2457 2458
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2459

2460
    if (!priv->conn) {
2461
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2462 2463 2464 2465 2466
        goto cleanup;
    }

    flags = args->flags;

2467
    if (args->nparams > REMOTE_NODE_MEMORY_STATS_MAX) {
2468
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2469 2470
        goto cleanup;
    }
2471
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2472
        goto cleanup;
2473
    nparams = args->nparams;
2474

2475
    if (virNodeGetMemoryStats(priv->conn, cellNum, params, &nparams, flags) < 0)
2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the memory parameters. */
    ret->params.params_len = nparams;
    if (VIR_ALLOC_N(ret->params.params_val, nparams) < 0)
2489
        goto cleanup;
2490 2491 2492

    for (i = 0; i < nparams; ++i) {
        /* remoteDispatchClientRequest will free this: */
2493 2494
        if (VIR_STRDUP(ret->params.params_val[i].field, params[i].field) < 0)
            goto cleanup;
2495 2496 2497 2498 2499 2500 2501

        ret->params.params_val[i].value = params[i].value;
    }

success:
    rv = 0;

2502 2503
cleanup:
    if (rv < 0) {
2504
        virNetMessageSaveError(rerr);
2505 2506 2507 2508 2509 2510 2511 2512 2513 2514
        if (ret->params.params_val) {
            for (i = 0; i < nparams; i++)
                VIR_FREE(ret->params.params_val[i].field);
            VIR_FREE(ret->params.params_val);
        }
    }
    VIR_FREE(params);
    return rv;
}

2515 2516 2517
static int
remoteDispatchDomainGetBlockJobInfo(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
2518
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_get_block_job_info_args *args,
                                    remote_domain_get_block_job_info_ret *ret)
{
    virDomainPtr dom = NULL;
    virDomainBlockJobInfo tmp;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2530
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    rv = virDomainGetBlockJobInfo(dom, args->path, &tmp, args->flags);
    if (rv <= 0)
        goto cleanup;

    ret->type = tmp.type;
    ret->bandwidth = tmp.bandwidth;
    ret->cur = tmp.cur;
    ret->end = tmp.end;
    ret->found = 1;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566
static int
remoteDispatchDomainGetBlockIoTune(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                   virNetMessagePtr hdr ATTRIBUTE_UNUSED,
                                   virNetMessageErrorPtr rerr,
                                   remote_domain_get_block_io_tune_args *args,
                                   remote_domain_get_block_io_tune_ret *ret)
{
    virDomainPtr dom = NULL;
    int rv = -1;
    virTypedParameterPtr params = NULL;
2567
    int nparams = 0;
2568 2569 2570 2571
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
2572
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
2573 2574 2575
        goto cleanup;
    }

2576
    if (args->nparams > REMOTE_DOMAIN_BLOCK_IO_TUNE_PARAMETERS_MAX) {
2577
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
2578 2579 2580
        goto cleanup;
    }

2581
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
2582
        goto cleanup;
2583
    nparams = args->nparams;
2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetBlockIoTune(dom, args->disk ? *args->disk : NULL,
                                params, &nparams, args->flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    /* Serialise the block I/O tuning parameters. */
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
2613
    virTypedParamsFree(params, nparams);
2614 2615 2616 2617
    if (dom)
        virDomainFree(dom);
    return rv;
}
2618

D
Daniel Veillard 已提交
2619 2620
/*-------------------------------------------------------------*/

2621
static int
2622 2623
remoteDispatchAuthList(virNetServerPtr server ATTRIBUTE_UNUSED,
                       virNetServerClientPtr client,
2624
                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
2625
                       virNetMessageErrorPtr rerr,
2626
                       remote_auth_list_ret *ret)
2627
{
2628
    int rv = -1;
2629 2630
    int auth = virNetServerClientGetAuth(client);
    uid_t callerUid;
2631
    gid_t callerGid;
2632
    pid_t callerPid;
2633
    unsigned long long timestamp;
2634 2635 2636 2637 2638 2639

    /* If the client is root then we want to bypass the
     * policykit auth to avoid root being denied if
     * some piece of polkit isn't present/running
     */
    if (auth == VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
2640
        if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
2641
                                              &callerPid, &timestamp) < 0) {
2642 2643 2644 2645
            /* Don't do anything on error - it'll be validated at next
             * phase of auth anyway */
            virResetLastError();
        } else if (callerUid == 0) {
2646 2647
            char *ident;
            if (virAsprintf(&ident, "pid:%lld,uid:%d",
2648
                            (long long) callerPid, (int) callerUid) < 0)
J
Jim Fehlig 已提交
2649 2650
                goto cleanup;
            VIR_INFO("Bypass polkit auth for privileged client %s", ident);
2651 2652
            virNetServerClientSetAuth(client, 0);
            auth = VIR_NET_SERVER_SERVICE_AUTH_NONE;
J
Jim Fehlig 已提交
2653
            VIR_FREE(ident);
2654 2655
        }
    }
2656

2657
    ret->types.types_len = 1;
2658
    if (VIR_ALLOC_N(ret->types.types_val, ret->types.types_len) < 0)
2659
        goto cleanup;
2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673

    switch (auth) {
    case VIR_NET_SERVER_SERVICE_AUTH_NONE:
        ret->types.types_val[0] = REMOTE_AUTH_NONE;
        break;
    case VIR_NET_SERVER_SERVICE_AUTH_POLKIT:
        ret->types.types_val[0] = REMOTE_AUTH_POLKIT;
        break;
    case VIR_NET_SERVER_SERVICE_AUTH_SASL:
        ret->types.types_val[0] = REMOTE_AUTH_SASL;
        break;
    default:
        ret->types.types_val[0] = REMOTE_AUTH_NONE;
    }
2674

2675 2676 2677 2678
    rv = 0;

cleanup:
    if (rv < 0)
2679
        virNetMessageSaveError(rerr);
2680
    return rv;
2681 2682 2683
}


2684
#ifdef WITH_SASL
2685 2686
/*
 * Initializes the SASL session in prepare for authentication
2687
 * and gives the client a list of allowed mechanisms to choose
2688 2689
 */
static int
2690 2691
remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client,
2692
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
2693
                           virNetMessageErrorPtr rerr,
2694
                           remote_auth_sasl_init_ret *ret)
2695
{
2696 2697 2698
    virNetSASLSessionPtr sasl = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2699

2700
    virMutexLock(&priv->lock);
2701

2702 2703 2704
    VIR_DEBUG("Initialize SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl != NULL) {
2705
        VIR_ERROR(_("client tried invalid SASL init request"));
2706
        goto authfail;
2707 2708
    }

2709 2710 2711 2712 2713
    sasl = virNetSASLSessionNewServer(saslCtxt,
                                      "libvirt",
                                      virNetServerClientLocalAddrString(client),
                                      virNetServerClientRemoteAddrString(client));
    if (!sasl)
2714
        goto authfail;
2715

2716
# if WITH_GNUTLS
2717
    /* Inform SASL that we've got an external SSF layer from TLS */
2718 2719 2720 2721
    if (virNetServerClientHasTLSSession(client)) {
        int ssf;

        if ((ssf = virNetServerClientGetTLSKeySize(client)) < 0)
2722
            goto authfail;
2723 2724 2725 2726 2727

        ssf *= 8; /* key size is bytes, sasl wants bits */

        VIR_DEBUG("Setting external SSF %d", ssf);
        if (virNetSASLSessionExtKeySize(sasl, ssf) < 0)
2728
            goto authfail;
2729
    }
2730
# endif
2731

2732
    if (virNetServerClientIsSecure(client))
2733
        /* If we've got TLS or UNIX domain sock, we don't care about SSF */
2734 2735
        virNetSASLSessionSecProps(sasl, 0, 0, true);
    else
2736
        /* Plain TCP, better get an SSF layer */
2737 2738 2739 2740
        virNetSASLSessionSecProps(sasl,
                                  56,  /* Good enough to require kerberos */
                                  100000,  /* Arbitrary big number */
                                  false); /* No anonymous */
2741

2742
    if (!(ret->mechlist = virNetSASLSessionListMechanisms(sasl)))
2743
        goto authfail;
2744
    VIR_DEBUG("Available mechanisms for client: '%s'", ret->mechlist);
2745

2746 2747
    priv->sasl = sasl;
    virMutexUnlock(&priv->lock);
2748
    return 0;
2749 2750

authfail:
2751
    virResetLastError();
2752 2753
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
2754
    virNetMessageSaveError(rerr);
2755 2756 2757
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2758
    virObjectUnref(sasl);
2759
    virMutexUnlock(&priv->lock);
2760
    return -1;
2761 2762
}

2763
/*
2764 2765
 * Returns 0 if ok, -1 on error, -2 if rejected
 */
2766
static int
2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782
remoteSASLFinish(virNetServerClientPtr client)
{
    const char *identity;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    int ssf;

    /* TLS or UNIX domain sockets trivially OK */
    if (!virNetServerClientIsSecure(client)) {
        if ((ssf = virNetSASLSessionGetKeySize(priv->sasl)) < 0)
            goto error;

        VIR_DEBUG("negotiated an SSF of %d", ssf);
        if (ssf < 56) { /* 56 is good for Kerberos */
            VIR_ERROR(_("negotiated SSF %d was not strong enough"), ssf);
            return -2;
        }
2783
    }
2784 2785

    if (!(identity = virNetSASLSessionGetIdentity(priv->sasl)))
2786
        return -2;
2787

2788 2789
    if (!virNetSASLContextCheckIdentity(saslCtxt, identity))
        return -2;
2790

2791
    virNetServerClientSetAuth(client, 0);
2792
    virNetServerClientSetSASLSession(client, priv->sasl);
2793

2794
    VIR_DEBUG("Authentication successful %d", virNetServerClientGetFD(client));
2795

2796 2797 2798
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2799

2800
    virObjectUnref(priv->sasl);
2801
    priv->sasl = NULL;
2802

2803
    return 0;
2804

2805 2806 2807
error:
    return -1;
}
2808

2809 2810 2811 2812
/*
 * This starts the SASL authentication negotiation.
 */
static int
2813 2814
remoteDispatchAuthSaslStart(virNetServerPtr server ATTRIBUTE_UNUSED,
                            virNetServerClientPtr client,
2815
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
2816
                            virNetMessageErrorPtr rerr,
2817 2818
                            remote_auth_sasl_start_args *args,
                            remote_auth_sasl_start_ret *ret)
2819 2820
{
    const char *serverout;
2821
    size_t serveroutlen;
2822
    int err;
2823 2824 2825
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2826
    const char *identity;
2827

2828
    virMutexLock(&priv->lock);
2829

2830 2831 2832
    VIR_DEBUG("Start SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl == NULL) {
2833
        VIR_ERROR(_("client tried invalid SASL start request"));
2834
        goto authfail;
2835 2836
    }

2837 2838
    VIR_DEBUG("Using SASL mechanism %s. Data %d bytes, nil: %d",
              args->mech, args->data.data_len, args->nil);
2839 2840 2841 2842 2843 2844 2845 2846 2847
    err = virNetSASLSessionServerStart(priv->sasl,
                                       args->mech,
                                       /* NB, distinction of NULL vs "" is *critical* in SASL */
                                       args->nil ? NULL : args->data.data_val,
                                       args->data.data_len,
                                       &serverout,
                                       &serveroutlen);
    if (err != VIR_NET_SASL_COMPLETE &&
        err != VIR_NET_SASL_CONTINUE)
2848
        goto authfail;
2849

2850
    if (serveroutlen > REMOTE_AUTH_SASL_DATA_MAX) {
2851
        VIR_ERROR(_("sasl start reply data too long %d"), (int)serveroutlen);
2852
        goto authfail;
2853 2854 2855 2856
    }

    /* NB, distinction of NULL vs "" is *critical* in SASL */
    if (serverout) {
2857 2858
        if (VIR_ALLOC_N(ret->data.data_val, serveroutlen) < 0)
            goto authfail;
2859 2860 2861 2862 2863 2864 2865
        memcpy(ret->data.data_val, serverout, serveroutlen);
    } else {
        ret->data.data_val = NULL;
    }
    ret->nil = serverout ? 0 : 1;
    ret->data.data_len = serveroutlen;

2866
    VIR_DEBUG("SASL return data %d bytes, nil; %d", ret->data.data_len, ret->nil);
2867
    if (err == VIR_NET_SASL_CONTINUE) {
2868 2869
        ret->complete = 0;
    } else {
2870
        /* Check username whitelist ACL */
2871
        if ((err = remoteSASLFinish(client)) < 0) {
2872 2873 2874 2875 2876
            if (err == -2)
                goto authdeny;
            else
                goto authfail;
        }
2877

2878 2879 2880
        ret->complete = 1;
    }

2881
    virMutexUnlock(&priv->lock);
2882
    return 0;
2883 2884

authfail:
2885 2886 2887
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2888 2889 2890
    goto error;

authdeny:
2891
    identity = virNetSASLSessionGetIdentity(priv->sasl);
2892 2893 2894
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2895 2896
    goto error;

2897
error:
2898
    virObjectUnref(priv->sasl);
2899 2900
    priv->sasl = NULL;
    virResetLastError();
2901 2902
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
2903 2904 2905
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
2906
    return -1;
2907 2908 2909 2910
}


static int
2911 2912
remoteDispatchAuthSaslStep(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client,
2913
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
2914
                           virNetMessageErrorPtr rerr,
2915 2916
                           remote_auth_sasl_step_args *args,
                           remote_auth_sasl_step_ret *ret)
2917 2918
{
    const char *serverout;
2919
    size_t serveroutlen;
2920
    int err;
2921 2922 2923
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
2924
    const char *identity;
2925

2926 2927 2928 2929 2930
    virMutexLock(&priv->lock);

    VIR_DEBUG("Step SASL auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_SASL ||
        priv->sasl == NULL) {
2931
        VIR_ERROR(_("client tried invalid SASL start request"));
2932
        goto authfail;
2933 2934
    }

2935
    VIR_DEBUG("Step using SASL Data %d bytes, nil: %d",
2936
              args->data.data_len, args->nil);
2937 2938 2939 2940 2941 2942 2943 2944
    err = virNetSASLSessionServerStep(priv->sasl,
                                      /* NB, distinction of NULL vs "" is *critical* in SASL */
                                      args->nil ? NULL : args->data.data_val,
                                      args->data.data_len,
                                      &serverout,
                                      &serveroutlen);
    if (err != VIR_NET_SASL_COMPLETE &&
        err != VIR_NET_SASL_CONTINUE)
2945
        goto authfail;
2946 2947

    if (serveroutlen > REMOTE_AUTH_SASL_DATA_MAX) {
2948
        VIR_ERROR(_("sasl step reply data too long %d"),
2949
                  (int)serveroutlen);
2950
        goto authfail;
2951 2952 2953 2954
    }

    /* NB, distinction of NULL vs "" is *critical* in SASL */
    if (serverout) {
2955 2956
        if (VIR_ALLOC_N(ret->data.data_val, serveroutlen) < 0)
            goto authfail;
2957 2958 2959 2960 2961 2962 2963
        memcpy(ret->data.data_val, serverout, serveroutlen);
    } else {
        ret->data.data_val = NULL;
    }
    ret->nil = serverout ? 0 : 1;
    ret->data.data_len = serveroutlen;

2964
    VIR_DEBUG("SASL return data %d bytes, nil; %d", ret->data.data_len, ret->nil);
2965
    if (err == VIR_NET_SASL_CONTINUE) {
2966 2967
        ret->complete = 0;
    } else {
2968
        /* Check username whitelist ACL */
2969
        if ((err = remoteSASLFinish(client)) < 0) {
2970 2971 2972 2973 2974
            if (err == -2)
                goto authdeny;
            else
                goto authfail;
        }
2975

2976 2977 2978
        ret->complete = 1;
    }

2979
    virMutexUnlock(&priv->lock);
2980
    return 0;
2981 2982

authfail:
2983 2984 2985
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_SASL);
2986 2987 2988
    goto error;

authdeny:
2989
    identity = virNetSASLSessionGetIdentity(priv->sasl);
2990 2991 2992
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_SASL, identity);
2993 2994
    goto error;

2995
error:
2996
    virObjectUnref(priv->sasl);
2997 2998
    priv->sasl = NULL;
    virResetLastError();
2999 3000
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3001 3002 3003
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3004 3005
    return -1;
}
3006 3007 3008 3009
#else
static int
remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
3010
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
3011 3012 3013 3014
                           virNetMessageErrorPtr rerr,
                           remote_auth_sasl_init_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3015 3016
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3017 3018 3019 3020 3021 3022
    virNetMessageSaveError(rerr);
    return -1;
}
static int
remoteDispatchAuthSaslStart(virNetServerPtr server ATTRIBUTE_UNUSED,
                            virNetServerClientPtr client ATTRIBUTE_UNUSED,
3023
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
3024 3025 3026 3027 3028
                            virNetMessageErrorPtr rerr,
                            remote_auth_sasl_start_args *args ATTRIBUTE_UNUSED,
                            remote_auth_sasl_start_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3029 3030
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3031 3032 3033 3034 3035 3036
    virNetMessageSaveError(rerr);
    return -1;
}
static int
remoteDispatchAuthSaslStep(virNetServerPtr server ATTRIBUTE_UNUSED,
                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
3037
                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
3038 3039 3040 3041 3042
                           virNetMessageErrorPtr rerr,
                           remote_auth_sasl_step_args *args ATTRIBUTE_UNUSED,
                           remote_auth_sasl_step_ret *ret ATTRIBUTE_UNUSED)
{
    VIR_WARN("Client tried unsupported SASL auth");
3043 3044
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3045 3046 3047 3048
    virNetMessageSaveError(rerr);
    return -1;
}
#endif
3049 3050 3051



3052
#if WITH_POLKIT1
3053
static int
3054 3055
remoteDispatchAuthPolkit(virNetServerPtr server ATTRIBUTE_UNUSED,
                         virNetServerClientPtr client,
3056
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3057
                         virNetMessageErrorPtr rerr,
3058
                         remote_auth_polkit_ret *ret)
3059
{
3060
    pid_t callerPid = -1;
3061
    gid_t callerGid = -1;
3062
    uid_t callerUid = -1;
3063
    unsigned long long timestamp;
3064 3065
    const char *action;
    int status = -1;
3066
    char *ident = NULL;
3067
    bool authdismissed = 0;
3068
    char *pkout = NULL;
3069 3070
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3071
    virCommandPtr cmd = NULL;
3072
# ifndef PKCHECK_SUPPORTS_UID
3073
    static bool polkitInsecureWarned;
3074
# endif
3075

3076 3077
    virMutexLock(&priv->lock);
    action = virNetServerClientGetReadonly(client) ?
3078 3079 3080
        "org.libvirt.unix.monitor" :
        "org.libvirt.unix.manage";

3081
    cmd = virCommandNewArgList(PKCHECK_PATH, "--action-id", action, NULL);
3082
    virCommandSetOutputBuffer(cmd, &pkout);
3083
    virCommandSetErrorBuffer(cmd, &pkout);
3084

3085 3086
    VIR_DEBUG("Start PolicyKit auth %d", virNetServerClientGetFD(client));
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
3087
        VIR_ERROR(_("client tried invalid PolicyKit init request"));
3088 3089 3090
        goto authfail;
    }

3091
    if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
3092
                                          &callerPid, &timestamp) < 0) {
3093 3094 3095
        goto authfail;
    }

3096 3097 3098 3099 3100 3101
    if (timestamp == 0) {
        VIR_WARN("Failing polkit auth due to missing client (pid=%lld) start time",
                 (long long)callerPid);
        goto authfail;
    }

3102 3103
    VIR_INFO("Checking PID %lld running as %d",
             (long long) callerPid, callerUid);
3104

3105
    virCommandAddArg(cmd, "--process");
3106

3107
# ifdef PKCHECK_SUPPORTS_UID
3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118
    virCommandAddArgFormat(cmd, "%lld,%llu,%lu",
                           (long long) callerPid,
                           timestamp,
                           (unsigned long) callerUid);
# else
    if (!polkitInsecureWarned) {
        VIR_WARN("No support for caller UID with pkcheck. "
                 "This deployment is known to be insecure.");
        polkitInsecureWarned = true;
    }
    virCommandAddArgFormat(cmd, "%lld,%llu", (long long) callerPid, timestamp);
3119
# endif
3120

3121
    virCommandAddArg(cmd, "--allow-user-interaction");
3122

3123
    if (virAsprintf(&ident, "pid:%lld,uid:%d",
3124
                    (long long) callerPid, callerUid) < 0)
3125 3126
        goto authfail;

3127
    if (virCommandRun(cmd, &status) < 0)
3128
        goto authfail;
3129

3130
    authdismissed = (pkout && strstr(pkout, "dismissed=true"));
3131
    if (status != 0) {
3132 3133 3134
        VIR_ERROR(_("Policy kit denied action %s from pid %lld, uid %d "
                    "with status %d"),
                  action, (long long) callerPid, callerUid, status);
3135
        goto authdeny;
3136
    }
3137 3138 3139
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3140 3141
    VIR_INFO("Policy allowed action %s from pid %lld, uid %d",
             action, (long long) callerPid, callerUid);
3142 3143
    ret->complete = 1;

3144
    virNetServerClientSetAuth(client, 0);
3145
    virMutexUnlock(&priv->lock);
3146
    virCommandFree(cmd);
E
Eric Blake 已提交
3147
    VIR_FREE(pkout);
3148
    VIR_FREE(ident);
3149

3150 3151
    return 0;

3152
error:
3153 3154
    virCommandFree(cmd);
    VIR_FREE(ident);
3155
    virResetLastError();
3156

3157
    if (authdismissed) {
3158 3159
        virReportError(VIR_ERR_AUTH_CANCELLED, "%s",
                       _("authentication cancelled by user"));
3160 3161
    } else if (pkout && *pkout) {
        virReportError(VIR_ERR_AUTH_FAILED, _("polkit: %s"), pkout);
3162
    } else {
3163
        virReportError(VIR_ERR_AUTH_FAILED, "%s", _("authentication failed"));
3164
    }
3165 3166

    VIR_FREE(pkout);
3167 3168 3169 3170
    virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return -1;

3171
authfail:
3172 3173 3174
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_POLKIT);
3175 3176 3177
    goto error;

authdeny:
3178 3179
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
3180
          client, REMOTE_AUTH_POLKIT, ident);
3181
    goto error;
3182
}
3183
#elif WITH_POLKIT0
3184
static int
3185
remoteDispatchAuthPolkit(virNetServerPtr server ATTRIBUTE_UNUSED,
3186
                         virNetServerClientPtr client,
3187
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3188
                         virNetMessageErrorPtr rerr,
3189
                         remote_auth_polkit_ret *ret)
3190 3191
{
    pid_t callerPid;
3192
    gid_t callerGid;
3193
    uid_t callerUid;
3194 3195 3196 3197 3198 3199
    PolKitCaller *pkcaller = NULL;
    PolKitAction *pkaction = NULL;
    PolKitContext *pkcontext = NULL;
    PolKitError *pkerr = NULL;
    PolKitResult pkresult;
    DBusError err;
3200
    const char *action;
3201
    char *ident = NULL;
3202 3203
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3204
    DBusConnection *sysbus;
J
Jim Fehlig 已提交
3205
    unsigned long long timestamp;
3206

J
Jim Fehlig 已提交
3207
    virMutexLock(&priv->lock);
3208

J
Jim Fehlig 已提交
3209
    action = virNetServerClientGetReadonly(client) ?
3210 3211
        "org.libvirt.unix.monitor" :
        "org.libvirt.unix.manage";
3212

3213
    VIR_DEBUG("Start PolicyKit auth %d", virNetServerClientGetFD(client));
J
Jim Fehlig 已提交
3214
    if (virNetServerClientGetAuth(client) != VIR_NET_SERVER_SERVICE_AUTH_POLKIT) {
3215
        VIR_ERROR(_("client tried invalid PolicyKit init request"));
3216
        goto authfail;
3217 3218
    }

3219
    if (virNetServerClientGetUNIXIdentity(client, &callerUid, &callerGid,
J
Jim Fehlig 已提交
3220
                                          &callerPid, &timestamp) < 0) {
3221
        VIR_ERROR(_("cannot get peer socket identity"));
3222
        goto authfail;
3223 3224
    }

3225
    if (virAsprintf(&ident, "pid:%lld,uid:%d",
3226
                    (long long) callerPid, callerUid) < 0)
3227 3228
        goto authfail;

3229 3230 3231
    if (!(sysbus = virDBusGetSystemBus()))
        goto authfail;

3232 3233
    VIR_INFO("Checking PID %lld running as %d",
             (long long) callerPid, callerUid);
3234
    dbus_error_init(&err);
3235
    if (!(pkcaller = polkit_caller_new_from_pid(sysbus,
3236
                                                callerPid, &err))) {
3237
        VIR_ERROR(_("Failed to lookup policy kit caller: %s"), err.message);
3238
        dbus_error_free(&err);
3239
        goto authfail;
3240
    }
3241

3242
    if (!(pkaction = polkit_action_new())) {
3243
        char ebuf[1024];
3244
        VIR_ERROR(_("Failed to create polkit action %s"),
3245
                  virStrerror(errno, ebuf, sizeof(ebuf)));
3246
        polkit_caller_unref(pkcaller);
3247
        goto authfail;
3248 3249 3250 3251 3252
    }
    polkit_action_set_action_id(pkaction, action);

    if (!(pkcontext = polkit_context_new()) ||
        !polkit_context_init(pkcontext, &pkerr)) {
3253
        char ebuf[1024];
3254
        VIR_ERROR(_("Failed to create polkit context %s"),
3255
                  (pkerr ? polkit_error_get_error_message(pkerr)
3256
                   : virStrerror(errno, ebuf, sizeof(ebuf))));
3257 3258 3259 3260 3261
        if (pkerr)
            polkit_error_free(pkerr);
        polkit_caller_unref(pkcaller);
        polkit_action_unref(pkaction);
        dbus_error_free(&err);
3262
        goto authfail;
3263
    }
3264

3265
# if HAVE_POLKIT_CONTEXT_IS_CALLER_AUTHORIZED
3266 3267 3268 3269 3270 3271
    pkresult = polkit_context_is_caller_authorized(pkcontext,
                                                   pkaction,
                                                   pkcaller,
                                                   0,
                                                   &pkerr);
    if (pkerr && polkit_error_is_set(pkerr)) {
3272 3273 3274
        VIR_ERROR(_("Policy kit failed to check authorization %d %s"),
                  polkit_error_get_error_code(pkerr),
                  polkit_error_get_error_message(pkerr));
3275
        goto authfail;
3276
    }
3277
# else
3278 3279 3280
    pkresult = polkit_context_can_caller_do_action(pkcontext,
                                                   pkaction,
                                                   pkcaller);
3281
# endif
3282 3283 3284 3285
    polkit_context_unref(pkcontext);
    polkit_caller_unref(pkcaller);
    polkit_action_unref(pkaction);
    if (pkresult != POLKIT_RESULT_YES) {
3286 3287
        VIR_ERROR(_("Policy kit denied action %s from pid %lld, uid %d, result: %s"),
                  action, (long long) callerPid, callerUid,
3288
                  polkit_result_to_string_representation(pkresult));
3289
        goto authdeny;
3290
    }
3291 3292 3293
    PROBE(RPC_SERVER_CLIENT_AUTH_ALLOW,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3294 3295
    VIR_INFO("Policy allowed action %s from pid %lld, uid %d, result %s",
             action, (long long) callerPid, callerUid,
3296 3297
             polkit_result_to_string_representation(pkresult));
    ret->complete = 1;
3298

3299
    virNetServerClientSetAuth(client, 0);
J
Jim Fehlig 已提交
3300
    virMutexUnlock(&priv->lock);
3301
    VIR_FREE(ident);
3302
    return 0;
3303

3304
error:
3305
    VIR_FREE(ident);
3306
    virResetLastError();
3307 3308
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3309
    virNetMessageSaveError(rerr);
J
Jim Fehlig 已提交
3310
    virMutexUnlock(&priv->lock);
3311 3312
    return -1;

3313
authfail:
3314 3315 3316
    PROBE(RPC_SERVER_CLIENT_AUTH_FAIL,
          "client=%p auth=%d",
          client, REMOTE_AUTH_POLKIT);
3317
    goto error;
3318

3319
authdeny:
3320 3321 3322
    PROBE(RPC_SERVER_CLIENT_AUTH_DENY,
          "client=%p auth=%d identity=%s",
          client, REMOTE_AUTH_POLKIT, ident);
3323
    goto error;
3324 3325
}

3326
#else /* !WITH_POLKIT0 & !HAVE_POLKIT1*/
3327 3328

static int
3329
remoteDispatchAuthPolkit(virNetServerPtr server ATTRIBUTE_UNUSED,
J
Jiri Denemark 已提交
3330
                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
3331
                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
3332
                         virNetMessageErrorPtr rerr,
3333
                         remote_auth_polkit_ret *ret ATTRIBUTE_UNUSED)
3334
{
3335
    VIR_ERROR(_("client tried unsupported PolicyKit init request"));
3336 3337
    virReportError(VIR_ERR_AUTH_FAILED, "%s",
                   _("authentication failed"));
3338
    virNetMessageSaveError(rerr);
3339 3340
    return -1;
}
3341
#endif /* WITH_POLKIT1 */
3342 3343


3344 3345 3346
/***************************************************************
 *     NODE INFO APIS
 **************************************************************/
3347

3348
static int
3349 3350
remoteDispatchNodeDeviceGetParent(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client ATTRIBUTE_UNUSED,
3351
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
3352
                                  virNetMessageErrorPtr rerr,
3353 3354
                                  remote_node_device_get_parent_args *args,
                                  remote_node_device_get_parent_ret *ret)
3355
{
3356 3357
    virNodeDevicePtr dev = NULL;
    const char *parent = NULL;
3358
    int rv = -1;
3359 3360
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3361

3362
    if (!priv->conn) {
3363
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3364
        goto cleanup;
3365 3366
    }

3367
    if (!(dev = virNodeDeviceLookupByName(priv->conn, args->name)))
3368 3369
        goto cleanup;

3370 3371 3372 3373 3374 3375 3376
    parent = virNodeDeviceGetParent(dev);

    if (parent == NULL) {
        ret->parent = NULL;
    } else {
        /* remoteDispatchClientRequest will free this. */
        char **parent_p;
3377
        if (VIR_ALLOC(parent_p) < 0)
3378
            goto cleanup;
3379
        if (VIR_STRDUP(*parent_p, parent) < 0) {
3380 3381 3382 3383 3384 3385
            VIR_FREE(parent_p);
            goto cleanup;
        }
        ret->parent = parent_p;
    }

3386 3387 3388 3389
    rv = 0;

cleanup:
    if (rv < 0)
3390
        virNetMessageSaveError(rerr);
3391 3392
    if (dev)
        virNodeDeviceFree(dev);
3393
    return rv;
3394 3395
}

3396 3397 3398 3399 3400

/***************************
 * Register / deregister events
 ***************************/
static int
3401
remoteDispatchConnectDomainEventRegister(virNetServerPtr server ATTRIBUTE_UNUSED,
3402
                                         virNetServerClientPtr client,
3403 3404 3405
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                         remote_connect_domain_event_register_ret *ret ATTRIBUTE_UNUSED)
O
Osier Yang 已提交
3406
{
3407
    int callbackID;
3408
    int rv = -1;
3409 3410
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
3411 3412
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
O
Osier Yang 已提交
3413

3414
    if (!priv->conn) {
3415
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3416
        goto cleanup;
3417 3418
    }

3419 3420
    virMutexLock(&priv->lock);

3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = VIR_DOMAIN_EVENT_ID_LIFECYCLE;
    callback->callbackID = -1;
3432
    callback->legacy = true;
3433 3434 3435 3436
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
3437
        goto cleanup;
O
Osier Yang 已提交
3438

3439
    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
3440 3441 3442
                                                       NULL,
                                                       VIR_DOMAIN_EVENT_ID_LIFECYCLE,
                                                       VIR_DOMAIN_EVENT_CALLBACK(remoteRelayDomainEventLifecycle),
3443 3444 3445 3446 3447
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
3448
        goto cleanup;
3449
    }
O
Osier Yang 已提交
3450

3451
    ref->callbackID = callbackID;
3452

3453 3454 3455
    rv = 0;

cleanup:
3456
    VIR_FREE(callback);
3457
    if (rv < 0)
3458 3459
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3460
    return rv;
O
Osier Yang 已提交
3461 3462
}

3463
static int
3464
remoteDispatchConnectDomainEventDeregister(virNetServerPtr server ATTRIBUTE_UNUSED,
3465
                                           virNetServerClientPtr client,
3466 3467 3468
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                           virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                           remote_connect_domain_event_deregister_ret *ret ATTRIBUTE_UNUSED)
3469
{
3470
    int callbackID = -1;
3471
    int rv = -1;
3472
    size_t i;
3473 3474
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3475

3476
    if (!priv->conn) {
3477
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3478
        goto cleanup;
3479 3480
    }

3481 3482
    virMutexLock(&priv->lock);

3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493
    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->eventID == VIR_DOMAIN_EVENT_ID_LIFECYCLE) {
            callbackID = priv->domainEventCallbacks[i]->callbackID;
            break;
        }
    }

    if (callbackID < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event %d not registered"),
                       VIR_DOMAIN_EVENT_ID_LIFECYCLE);
3494
        goto cleanup;
3495
    }
3496

3497
    if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
3498
        goto cleanup;
3499

3500 3501
    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);
3502

3503 3504 3505
    rv = 0;

cleanup:
3506
    if (rv < 0)
3507 3508
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3509 3510 3511 3512
    return rv;
}

static void
3513
remoteDispatchObjectEventSend(virNetServerClientPtr client,
3514
                              virNetServerProgramPtr program,
3515 3516 3517 3518
                              int procnr,
                              xdrproc_t proc,
                              void *data)
{
3519
    virNetMessagePtr msg;
3520

3521
    if (!(msg = virNetMessageNew(false)))
3522
        goto cleanup;
3523

3524 3525 3526 3527 3528 3529
    msg->header.prog = virNetServerProgramGetID(program);
    msg->header.vers = virNetServerProgramGetVersion(program);
    msg->header.proc = procnr;
    msg->header.type = VIR_NET_MESSAGE;
    msg->header.serial = 1;
    msg->header.status = VIR_NET_OK;
3530

3531
    if (virNetMessageEncodeHeader(msg) < 0)
3532 3533
        goto cleanup;

3534 3535
    if (virNetMessageEncodePayload(msg, proc, data) < 0)
        goto cleanup;
3536

3537 3538
    VIR_DEBUG("Queue event %d %zu", procnr, msg->bufferLength);
    virNetServerClientSendMessage(client, msg);
3539

3540
    xdr_free(proc, data);
3541 3542 3543
    return;

cleanup:
3544
    virNetMessageFree(msg);
3545
    xdr_free(proc, data);
3546 3547
}

3548
static int
3549 3550
remoteDispatchSecretGetValue(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
3551
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
3552
                             virNetMessageErrorPtr rerr,
3553 3554
                             remote_secret_get_value_args *args,
                             remote_secret_get_value_ret *ret)
3555
{
3556 3557 3558
    virSecretPtr secret = NULL;
    size_t value_size;
    unsigned char *value;
3559
    int rv = -1;
3560 3561
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3562

3563
    if (!priv->conn) {
3564
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3565
        goto cleanup;
3566 3567
    }

3568
    if (!(secret = get_nonnull_secret(priv->conn, args->secret)))
3569
        goto cleanup;
3570

3571
    if (!(value = virSecretGetValue(secret, &value_size, args->flags)))
3572
        goto cleanup;
3573

3574 3575 3576
    ret->value.value_len = value_size;
    ret->value.value_val = (char *)value;

3577 3578 3579 3580
    rv = 0;

cleanup:
    if (rv < 0)
3581
        virNetMessageSaveError(rerr);
3582 3583
    if (secret)
        virSecretFree(secret);
3584
    return rv;
3585 3586
}

3587
static int
3588 3589
remoteDispatchDomainGetState(virNetServerPtr server ATTRIBUTE_UNUSED,
                             virNetServerClientPtr client ATTRIBUTE_UNUSED,
3590
                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
3591
                             virNetMessageErrorPtr rerr,
3592 3593 3594 3595 3596
                             remote_domain_get_state_args *args,
                             remote_domain_get_state_ret *ret)
{
    virDomainPtr dom = NULL;
    int rv = -1;
3597 3598
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3599

3600
    if (!priv->conn) {
3601
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3602 3603 3604
        goto cleanup;
    }

3605
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3606 3607 3608 3609 3610 3611 3612 3613 3614
        goto cleanup;

    if (virDomainGetState(dom, &ret->state, &ret->reason, args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
3615
        virNetMessageSaveError(rerr);
3616 3617 3618 3619 3620
    if (dom)
        virDomainFree(dom);
    return rv;
}

3621 3622 3623 3624 3625 3626

/* Due to back-compat reasons, two RPC calls map to the same libvirt
 * API of virConnectDomainEventRegisterAny.  A client should only use
 * the new call if they have probed
 * VIR_DRV_SUPPORTS_FEATURE(VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK),
 * and must not mix the two styles.  */
3627
static int
3628
remoteDispatchConnectDomainEventRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
3629
                                            virNetServerClientPtr client,
3630 3631 3632
                                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                            virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                            remote_connect_domain_event_register_any_args *args)
3633 3634
{
    int callbackID;
3635
    int rv = -1;
3636 3637
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
3638 3639
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3640

3641
    if (!priv->conn) {
3642
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3643
        goto cleanup;
3644 3645
    }

3646 3647
    virMutexLock(&priv->lock);

3648 3649 3650 3651
    /* We intentionally do not use VIR_DOMAIN_EVENT_ID_LAST here; any
     * new domain events added after this point should only use the
     * modern callback style of RPC.  */
    if (args->eventID > VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED ||
3652
        args->eventID < 0) {
3653 3654
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
3655
        goto cleanup;
3656 3657
    }

3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
3669
    callback->legacy = true;
3670 3671 3672 3673
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
3674
        goto cleanup;
3675

3676
    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
3677 3678 3679
                                                       NULL,
                                                       args->eventID,
                                                       domainEventCallbacks[args->eventID],
3680 3681 3682 3683 3684
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
3685
        goto cleanup;
3686
    }
3687

3688
    ref->callbackID = callbackID;
3689

3690 3691 3692
    rv = 0;

cleanup:
3693
    VIR_FREE(callback);
3694
    if (rv < 0)
3695 3696
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3697
    return rv;
3698 3699 3700
}


3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727
static int
remoteDispatchConnectDomainEventCallbackRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                    virNetServerClientPtr client,
                                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                    virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                                    remote_connect_domain_event_callback_register_any_args *args,
                                                    remote_connect_domain_event_callback_register_any_ret *ret)
{
    int callbackID;
    int rv = -1;
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

    if (args->dom &&
        !(dom = get_nonnull_domain(priv->conn, *args->dom)))
        goto cleanup;

3728
    if (args->eventID >= VIR_DOMAIN_EVENT_ID_LAST || args->eventID < 0) {
3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
        goto cleanup;
    }

    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->domainEventCallbacks,
                           priv->ndomainEventCallbacks,
                           callback) < 0)
        goto cleanup;

    if ((callbackID = virConnectDomainEventRegisterAny(priv->conn,
                                                       dom,
                                                       args->eventID,
                                                       domainEventCallbacks[args->eventID],
                                                       ref,
                                                       remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->domainEventCallbacks,
                     priv->ndomainEventCallbacks, 1);
        callback = ref;
        goto cleanup;
    }

    ref->callbackID = callbackID;
    ret->callbackID = callbackID;

    rv = 0;

cleanup:
    VIR_FREE(callback);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    virMutexUnlock(&priv->lock);
    return rv;
}


3779
static int
3780
remoteDispatchConnectDomainEventDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
3781
                                              virNetServerClientPtr client,
3782 3783 3784
                                              virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                              virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                              remote_connect_domain_event_deregister_any_args *args)
3785 3786
{
    int callbackID = -1;
3787
    int rv = -1;
3788
    size_t i;
3789 3790
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3791

3792
    if (!priv->conn) {
3793
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3794
        goto cleanup;
3795 3796
    }

3797 3798
    virMutexLock(&priv->lock);

3799 3800 3801 3802
    /* We intentionally do not use VIR_DOMAIN_EVENT_ID_LAST here; any
     * new domain events added after this point should only use the
     * modern callback style of RPC.  */
    if (args->eventID > VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED ||
3803
        args->eventID < 0) {
3804 3805
        virReportError(VIR_ERR_INTERNAL_ERROR, _("unsupported event ID %d"),
                       args->eventID);
3806
        goto cleanup;
3807 3808
    }

3809 3810 3811 3812 3813 3814
    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->eventID == args->eventID) {
            callbackID = priv->domainEventCallbacks[i]->callbackID;
            break;
        }
    }
3815
    if (callbackID < 0) {
3816 3817
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event %d not registered"), args->eventID);
3818
        goto cleanup;
3819 3820
    }

3821
    if (virConnectDomainEventDeregisterAny(priv->conn, callbackID) < 0)
3822
        goto cleanup;
3823

3824 3825
    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);
3826

3827 3828 3829 3830
    rv = 0;

cleanup:
    if (rv < 0)
3831 3832
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
3833
    return rv;
3834 3835
}

3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882

static int
remoteDispatchConnectDomainEventCallbackDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                      virNetServerClientPtr client,
                                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                      virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                                      remote_connect_domain_event_callback_deregister_any_args *args)
{
    int rv = -1;
    size_t i;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

    for (i = 0; i < priv->ndomainEventCallbacks; i++) {
        if (priv->domainEventCallbacks[i]->callbackID == args->callbackID)
            break;
    }
    if (i == priv->ndomainEventCallbacks) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("domain event callback %d not registered"),
                       args->callbackID);
        goto cleanup;
    }

    if (virConnectDomainEventDeregisterAny(priv->conn, args->callbackID) < 0)
        goto cleanup;

    VIR_DELETE_ELEMENT(priv->domainEventCallbacks, i,
                       priv->ndomainEventCallbacks);

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return rv;
}


C
Chris Lalancette 已提交
3883
static int
3884 3885 3886 3887 3888 3889
qemuDispatchDomainMonitorCommand(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                 virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                 virNetMessageErrorPtr rerr,
                                 qemu_domain_monitor_command_args *args,
                                 qemu_domain_monitor_command_ret *ret)
C
Chris Lalancette 已提交
3890
{
3891
    virDomainPtr dom = NULL;
3892
    int rv = -1;
3893 3894
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
C
Chris Lalancette 已提交
3895

3896
    if (!priv->conn) {
3897
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3898
        goto cleanup;
3899 3900
    }

3901
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3902
        goto cleanup;
C
Chris Lalancette 已提交
3903

3904
    if (virDomainQemuMonitorCommand(dom, args->cmd, &ret->result,
3905
                                    args->flags) < 0)
3906
        goto cleanup;
C
Chris Lalancette 已提交
3907

3908
    rv = 0;
C
Chris Lalancette 已提交
3909

3910 3911
cleanup:
    if (rv < 0)
3912
        virNetMessageSaveError(rerr);
3913 3914
    if (dom)
        virDomainFree(dom);
3915
    return rv;
C
Chris Lalancette 已提交
3916 3917
}

3918

3919
static int
3920 3921
remoteDispatchDomainMigrateBegin3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client ATTRIBUTE_UNUSED,
3922
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
3923
                                  virNetMessageErrorPtr rerr,
3924 3925 3926 3927 3928 3929
                                  remote_domain_migrate_begin3_args *args,
                                  remote_domain_migrate_begin3_ret *ret)
{
    char *xml = NULL;
    virDomainPtr dom = NULL;
    char *dname;
3930
    char *xmlin;
3931 3932 3933
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
3934 3935
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3936

3937
    if (!priv->conn) {
3938
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3939 3940 3941
        goto cleanup;
    }

3942
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
3943 3944
        goto cleanup;

3945
    xmlin = args->xmlin == NULL ? NULL : *args->xmlin;
3946 3947
    dname = args->dname == NULL ? NULL : *args->dname;

3948
    if (!(xml = virDomainMigrateBegin3(dom, xmlin,
3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963
                                       &cookieout, &cookieoutlen,
                                       args->flags, dname, args->resource)))
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie and
     * the xml string if there is one.
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->xml = xml;

    rv = 0;

cleanup:
    if (rv < 0)
3964
        virNetMessageSaveError(rerr);
3965 3966 3967 3968 3969 3970 3971
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
3972 3973
remoteDispatchDomainMigratePrepare3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
3974
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
3975
                                    virNetMessageErrorPtr rerr,
3976 3977 3978 3979 3980 3981 3982 3983 3984
                                    remote_domain_migrate_prepare3_args *args,
                                    remote_domain_migrate_prepare3_ret *ret)
{
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char *uri_in;
    char **uri_out;
    char *dname;
    int rv = -1;
3985 3986
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
3987

3988
    if (!priv->conn) {
3989
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
3990 3991 3992 3993 3994 3995 3996
        goto cleanup;
    }

    uri_in = args->uri_in == NULL ? NULL : *args->uri_in;
    dname = args->dname == NULL ? NULL : *args->dname;

    /* Wacky world of XDR ... */
3997
    if (VIR_ALLOC(uri_out) < 0)
3998 3999
        goto cleanup;

4000
    if (virDomainMigratePrepare3(priv->conn,
4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 &cookieout, &cookieoutlen,
                                 uri_in, uri_out,
                                 args->flags, dname, args->resource,
                                 args->dom_xml) < 0)
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie, uri_out and
     * the string if there is one.
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->uri_out = *uri_out == NULL ? NULL : uri_out;

    rv = 0;

cleanup:
    if (rv < 0) {
4020
        virNetMessageSaveError(rerr);
4021 4022 4023 4024 4025
        VIR_FREE(uri_out);
    }
    return rv;
}

4026

4027
static int
4028 4029
remoteDispatchDomainMigratePerform3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
4030
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
4031
                                    virNetMessageErrorPtr rerr,
4032 4033 4034 4035
                                    remote_domain_migrate_perform3_args *args,
                                    remote_domain_migrate_perform3_ret *ret)
{
    virDomainPtr dom = NULL;
4036
    char *xmlin;
4037
    char *dname;
4038 4039
    char *uri;
    char *dconnuri;
4040 4041 4042
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
4043 4044
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4045

4046
    if (!priv->conn) {
4047
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4048 4049 4050
        goto cleanup;
    }

4051
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
4052 4053
        goto cleanup;

4054
    xmlin = args->xmlin == NULL ? NULL : *args->xmlin;
4055
    dname = args->dname == NULL ? NULL : *args->dname;
4056 4057
    uri = args->uri == NULL ? NULL : *args->uri;
    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;
4058

4059
    if (virDomainMigratePerform3(dom, xmlin,
4060 4061 4062
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 &cookieout, &cookieoutlen,
4063
                                 dconnuri, uri,
4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075
                                 args->flags, dname, args->resource) < 0)
        goto cleanup;

    /* remoteDispatchClientRequest will free cookie
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    if (rv < 0)
4076
        virNetMessageSaveError(rerr);
4077 4078 4079 4080 4081 4082 4083
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
4084 4085
remoteDispatchDomainMigrateFinish3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                   virNetServerClientPtr client ATTRIBUTE_UNUSED,
4086
                                   virNetMessagePtr msg ATTRIBUTE_UNUSED,
4087
                                   virNetMessageErrorPtr rerr,
4088 4089 4090 4091 4092 4093
                                   remote_domain_migrate_finish3_args *args,
                                   remote_domain_migrate_finish3_ret *ret)
{
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
4094 4095
    char *uri;
    char *dconnuri;
4096
    int rv = -1;
4097 4098
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4099

4100
    if (!priv->conn) {
4101
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4102 4103 4104
        goto cleanup;
    }

4105 4106 4107
    uri = args->uri == NULL ? NULL : *args->uri;
    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;

4108
    if (!(dom = virDomainMigrateFinish3(priv->conn, args->dname,
4109 4110 4111 4112 4113 4114
                                        args->cookie_in.cookie_in_val,
                                        args->cookie_in.cookie_in_len,
                                        &cookieout, &cookieoutlen,
                                        dconnuri, uri,
                                        args->flags,
                                        args->cancelled)))
4115 4116
        goto cleanup;

4117
    make_nonnull_domain(&ret->dom, dom);
4118 4119 4120 4121 4122 4123 4124 4125 4126 4127

    /* remoteDispatchClientRequest will free cookie
     */
    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    if (rv < 0) {
4128
        virNetMessageSaveError(rerr);
4129 4130 4131 4132 4133 4134 4135 4136 4137
        VIR_FREE(cookieout);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
4138 4139
remoteDispatchDomainMigrateConfirm3(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client ATTRIBUTE_UNUSED,
4140
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
4141 4142
                                    virNetMessageErrorPtr rerr,
                                    remote_domain_migrate_confirm3_args *args)
4143 4144 4145
{
    virDomainPtr dom = NULL;
    int rv = -1;
4146 4147
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
4148

4149
    if (!priv->conn) {
4150
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4151 4152 4153
        goto cleanup;
    }

4154
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166
        goto cleanup;

    if (virDomainMigrateConfirm3(dom,
                                 args->cookie_in.cookie_in_val,
                                 args->cookie_in.cookie_in_len,
                                 args->flags, args->cancelled) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
4167
        virNetMessageSaveError(rerr);
4168 4169 4170 4171 4172 4173
    if (dom)
        virDomainFree(dom);
    return rv;
}


4174 4175 4176 4177 4178 4179
static int remoteDispatchConnectSupportsFeature(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client,
                                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                                virNetMessageErrorPtr rerr,
                                                remote_connect_supports_feature_args *args,
                                                remote_connect_supports_feature_ret *ret)
4180 4181 4182 4183 4184 4185
{
    int rv = -1;
    int supported;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

4186 4187 4188 4189 4190 4191 4192 4193 4194 4195
    /* This feature is checked before opening the connection, thus we must
     * check it first.
     */
    if (args->feature == VIR_DRV_FEATURE_PROGRAM_KEEPALIVE) {
        if (virNetServerClientStartKeepAlive(client) < 0)
            goto cleanup;
        supported = 1;
        goto done;
    }

4196
    if (!priv->conn) {
4197
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4198 4199 4200 4201 4202
        goto cleanup;
    }

    switch (args->feature) {
    case VIR_DRV_FEATURE_FD_PASSING:
4203
    case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK:
4204 4205 4206 4207
        supported = 1;
        break;

    default:
4208
        if ((supported = virConnectSupportsFeature(priv->conn, args->feature)) < 0)
4209 4210 4211 4212
            goto cleanup;
        break;
    }

4213
done:
4214 4215 4216 4217 4218 4219 4220 4221 4222 4223
    ret->supported = supported;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    return rv;
}


4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237
static int
remoteDispatchDomainOpenGraphics(virNetServerPtr server ATTRIBUTE_UNUSED,
                                 virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                 virNetMessagePtr msg,
                                 virNetMessageErrorPtr rerr,
                                 remote_domain_open_graphics_args *args)
{
    virDomainPtr dom = NULL;
    int rv = -1;
    int fd = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4238
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((fd = virNetMessageDupFD(msg, 0)) < 0)
        goto cleanup;

    if (virDomainOpenGraphics(dom,
                              args->idx,
                              fd,
                              args->flags) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    VIR_FORCE_CLOSE(fd);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275
static int
remoteDispatchDomainGetInterfaceParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                           virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                           virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                           virNetMessageErrorPtr rerr,
                                           remote_domain_get_interface_parameters_args *args,
                                           remote_domain_get_interface_parameters_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    const char *device = args->device;
4276
    int nparams = 0;
4277 4278 4279 4280 4281 4282
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4283
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4284 4285 4286 4287 4288
        goto cleanup;
    }

    flags = args->flags;

4289
    if (args->nparams > REMOTE_DOMAIN_INTERFACE_PARAMETERS_MAX) {
4290
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
4291 4292
        goto cleanup;
    }
4293
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
4294
        goto cleanup;
4295
    nparams = args->nparams;
4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetInterfaceParameters(dom, device, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
4323
    virTypedParamsFree(params, nparams);
4324 4325 4326 4327
    if (dom)
        virDomainFree(dom);
    return rv;
}
4328

4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344
static int
remoteDispatchDomainGetCPUStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                virNetMessagePtr hdr ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_get_cpu_stats_args *args,
                                remote_domain_get_cpu_stats_ret *ret)
{
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv;
    virTypedParameterPtr params = NULL;
    int rv = -1;
    int percpu_len = 0;

    priv = virNetServerClientGetPrivateData(client);
    if (!priv->conn) {
4345
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4346 4347 4348 4349
        goto cleanup;
    }

    if (args->nparams > REMOTE_NODE_CPU_STATS_MAX) {
4350
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
4351 4352 4353
        goto cleanup;
    }
    if (args->ncpus > REMOTE_DOMAIN_GET_CPU_STATS_NCPUS_MAX) {
4354
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("ncpus too large"));
4355 4356 4357 4358
        goto cleanup;
    }

    if (args->nparams > 0 &&
4359
        VIR_ALLOC_N(params, args->ncpus * args->nparams) < 0)
4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382
        goto cleanup;

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    percpu_len = virDomainGetCPUStats(dom, params, args->nparams,
                                      args->start_cpu, args->ncpus,
                                      args->flags);
    if (percpu_len < 0)
        goto cleanup;
    /* If nparams == 0, the function returns a single value */
    if (args->nparams == 0)
        goto success;

    if (remoteSerializeTypedParameters(params, args->nparams * args->ncpus,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;
    ret->nparams = percpu_len;
4383
    if (args->nparams && !(args->flags & VIR_TYPED_PARAM_STRING_OKAY)) {
4384
        size_t i;
4385 4386 4387 4388 4389 4390

        for (i = 0; i < percpu_len; i++) {
            if (params[i].type == VIR_TYPED_PARAM_STRING)
                ret->nparams--;
        }
    }
4391 4392 4393 4394

cleanup:
    if (rv < 0)
         virNetMessageSaveError(rerr);
4395
    virTypedParamsFree(params, args->ncpus * args->nparams);
4396 4397 4398 4399 4400
    if (dom)
        virDomainFree(dom);
    return rv;
}

4401 4402 4403 4404 4405 4406 4407
static int
remoteDispatchDomainGetDiskErrors(virNetServerPtr server ATTRIBUTE_UNUSED,
                                  virNetServerClientPtr client,
                                  virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                  virNetMessageErrorPtr rerr,
                                  remote_domain_get_disk_errors_args *args,
                                  remote_domain_get_disk_errors_ret *ret)
4408 4409 4410 4411
{
    int rv = -1;
    virDomainPtr dom = NULL;
    virDomainDiskErrorPtr errors = NULL;
4412
    int len = 0;
4413 4414 4415 4416
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
4417
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4418 4419 4420 4421 4422 4423 4424
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (args->maxerrors > REMOTE_DOMAIN_DISK_ERRORS_MAX) {
4425 4426
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("maxerrors too large"));
4427 4428 4429 4430
        goto cleanup;
    }

    if (args->maxerrors &&
4431
        VIR_ALLOC_N(errors, args->maxerrors) < 0)
4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453
        goto cleanup;

    if ((len = virDomainGetDiskErrors(dom, errors,
                                      args->maxerrors,
                                      args->flags)) < 0)
        goto cleanup;

    ret->nerrors = len;
    if (errors &&
        remoteSerializeDomainDiskErrors(errors, len,
                                        &ret->errors.errors_val,
                                        &ret->errors.errors_len) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    if (errors) {
4454
        size_t i;
4455 4456 4457 4458 4459 4460 4461
        for (i = 0; i < len; i++)
            VIR_FREE(errors[i].disk);
    }
    VIR_FREE(errors);
    return rv;
}

4462 4463 4464 4465 4466 4467 4468 4469 4470 4471
static int
remoteDispatchDomainListAllSnapshots(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client,
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                     virNetMessageErrorPtr rerr,
                                     remote_domain_list_all_snapshots_args *args,
                                     remote_domain_list_all_snapshots_ret *ret)
{
    virDomainSnapshotPtr *snaps = NULL;
    int nsnaps = 0;
4472
    size_t i;
4473 4474 4475 4476 4477
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;

    if (!priv->conn) {
4478
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if ((nsnaps = virDomainListAllSnapshots(dom,
                                            args->need_results ? &snaps : NULL,
                                            args->flags)) < 0)
        goto cleanup;

4490 4491 4492 4493 4494 4495 4496
    if (nsnaps > REMOTE_DOMAIN_SNAPSHOT_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domain snapshots '%d' for limit '%d'"),
                       nsnaps, REMOTE_DOMAIN_SNAPSHOT_LIST_MAX);
        goto cleanup;
    }

4497
    if (snaps && nsnaps) {
4498
        if (VIR_ALLOC_N(ret->snapshots.snapshots_val, nsnaps) < 0)
4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536
            goto cleanup;

        ret->snapshots.snapshots_len = nsnaps;

        for (i = 0; i < nsnaps; i++)
            make_nonnull_domain_snapshot(ret->snapshots.snapshots_val + i,
                                         snaps[i]);
    } else {
        ret->snapshots.snapshots_len = 0;
        ret->snapshots.snapshots_val = NULL;
    }

    ret->ret = nsnaps;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    if (snaps) {
        for (i = 0; i < nsnaps; i++)
            virDomainSnapshotFree(snaps[i]);
        VIR_FREE(snaps);
    }
    return rv;
}

static int
remoteDispatchDomainSnapshotListAllChildren(virNetServerPtr server ATTRIBUTE_UNUSED,
                                            virNetServerClientPtr client,
                                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                            virNetMessageErrorPtr rerr,
                                            remote_domain_snapshot_list_all_children_args *args,
                                            remote_domain_snapshot_list_all_children_ret *ret)
{
    virDomainSnapshotPtr *snaps = NULL;
    int nsnaps = 0;
4537
    size_t i;
4538 4539 4540 4541 4542 4543
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
    virDomainPtr dom = NULL;
    virDomainSnapshotPtr snapshot = NULL;

    if (!priv->conn) {
4544
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->snapshot.dom)))
        goto cleanup;

    if (!(snapshot = get_nonnull_domain_snapshot(dom, args->snapshot)))
        goto cleanup;

    if ((nsnaps = virDomainSnapshotListAllChildren(snapshot,
                                                   args->need_results ? &snaps : NULL,
                                                   args->flags)) < 0)
        goto cleanup;

4559 4560 4561 4562 4563 4564 4565
    if (nsnaps > REMOTE_DOMAIN_SNAPSHOT_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many domain snapshots '%d' for limit '%d'"),
                       nsnaps, REMOTE_DOMAIN_SNAPSHOT_LIST_MAX);
        goto cleanup;
    }

4566
    if (snaps && nsnaps) {
4567
        if (VIR_ALLOC_N(ret->snapshots.snapshots_val, nsnaps) < 0)
4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597
            goto cleanup;

        ret->snapshots.snapshots_len = nsnaps;

        for (i = 0; i < nsnaps; i++)
            make_nonnull_domain_snapshot(ret->snapshots.snapshots_val + i,
                                         snaps[i]);
    } else {
        ret->snapshots.snapshots_len = 0;
        ret->snapshots.snapshots_val = NULL;
    }

    ret->ret = nsnaps;
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (snapshot)
        virDomainSnapshotFree(snapshot);
    if (dom)
        virDomainFree(dom);
    if (snaps) {
        for (i = 0; i < nsnaps; i++)
            virDomainSnapshotFree(snaps[i]);
        VIR_FREE(snaps);
    }
    return rv;
}

4598 4599 4600 4601 4602 4603 4604 4605 4606 4607
static int
remoteDispatchConnectListAllStoragePools(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_connect_list_all_storage_pools_args *args,
                                         remote_connect_list_all_storage_pools_ret *ret)
{
    virStoragePoolPtr *pools = NULL;
    int npools = 0;
4608
    size_t i;
4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((npools = virConnectListAllStoragePools(priv->conn,
                                                args->need_results ? &pools : NULL,
                                                args->flags)) < 0)
        goto cleanup;

4622 4623 4624 4625 4626 4627 4628
    if (npools > REMOTE_STORAGE_POOL_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many storage pools '%d' for limit '%d'"),
                       npools, REMOTE_STORAGE_POOL_LIST_MAX);
        goto cleanup;
    }

4629
    if (pools && npools) {
4630
        if (VIR_ALLOC_N(ret->pools.pools_val, npools) < 0)
4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656
            goto cleanup;

        ret->pools.pools_len = npools;

        for (i = 0; i < npools; i++)
            make_nonnull_storage_pool(ret->pools.pools_val + i, pools[i]);
    } else {
        ret->pools.pools_len = 0;
        ret->pools.pools_val = NULL;
    }

    ret->ret = npools;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (pools) {
        for (i = 0; i < npools; i++)
            virStoragePoolFree(pools[i]);
        VIR_FREE(pools);
    }
    return rv;
}

4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667
static int
remoteDispatchStoragePoolListAllVolumes(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_storage_pool_list_all_volumes_args *args,
                                        remote_storage_pool_list_all_volumes_ret *ret)
{
    virStorageVolPtr *vols = NULL;
    virStoragePoolPtr pool = NULL;
    int nvols = 0;
4668
    size_t i;
4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(pool = get_nonnull_storage_pool(priv->conn, args->pool)))
        goto cleanup;

    if ((nvols = virStoragePoolListAllVolumes(pool,
                                              args->need_results ? &vols : NULL,
                                              args->flags)) < 0)
        goto cleanup;

4685 4686 4687 4688 4689 4690 4691
    if (nvols > REMOTE_STORAGE_VOL_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many storage volumes '%d' for limit '%d'"),
                       nvols, REMOTE_STORAGE_VOL_LIST_MAX);
        goto cleanup;
    }

4692
    if (vols && nvols) {
4693
        if (VIR_ALLOC_N(ret->vols.vols_val, nvols) < 0)
4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716
            goto cleanup;

        ret->vols.vols_len = nvols;

        for (i = 0; i < nvols; i++)
            make_nonnull_storage_vol(ret->vols.vols_val + i, vols[i]);
    } else {
        ret->vols.vols_len = 0;
        ret->vols.vols_val = NULL;
    }

    ret->ret = nvols;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (vols) {
        for (i = 0; i < nvols; i++)
            virStorageVolFree(vols[i]);
        VIR_FREE(vols);
    }
4717 4718
    if (pool)
        virStoragePoolFree(pool);
4719 4720 4721
    return rv;
}

4722 4723 4724 4725 4726 4727 4728 4729 4730 4731
static int
remoteDispatchConnectListAllNetworks(virNetServerPtr server ATTRIBUTE_UNUSED,
                                     virNetServerClientPtr client,
                                     virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                     virNetMessageErrorPtr rerr,
                                     remote_connect_list_all_networks_args *args,
                                     remote_connect_list_all_networks_ret *ret)
{
    virNetworkPtr *nets = NULL;
    int nnets = 0;
4732
    size_t i;
4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nnets = virConnectListAllNetworks(priv->conn,
                                           args->need_results ? &nets : NULL,
                                           args->flags)) < 0)
        goto cleanup;

4746 4747 4748 4749 4750 4751 4752
    if (nnets > REMOTE_NETWORK_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many networks '%d' for limit '%d'"),
                       nnets, REMOTE_NETWORK_LIST_MAX);
        goto cleanup;
    }

4753
    if (nets && nnets) {
4754
        if (VIR_ALLOC_N(ret->nets.nets_val, nnets) < 0)
4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780
            goto cleanup;

        ret->nets.nets_len = nnets;

        for (i = 0; i < nnets; i++)
            make_nonnull_network(ret->nets.nets_val + i, nets[i]);
    } else {
        ret->nets.nets_len = 0;
        ret->nets.nets_val = NULL;
    }

    ret->ret = nnets;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (nets) {
        for (i = 0; i < nnets; i++)
            virNetworkFree(nets[i]);
        VIR_FREE(nets);
    }
    return rv;
}

4781 4782 4783 4784 4785 4786 4787 4788 4789 4790
static int
remoteDispatchConnectListAllInterfaces(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_connect_list_all_interfaces_args *args,
                                       remote_connect_list_all_interfaces_ret *ret)
{
    virInterfacePtr *ifaces = NULL;
    int nifaces = 0;
4791
    size_t i;
4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nifaces = virConnectListAllInterfaces(priv->conn,
                                               args->need_results ? &ifaces : NULL,
                                               args->flags)) < 0)
        goto cleanup;

4805 4806 4807 4808 4809 4810 4811
    if (nifaces > REMOTE_INTERFACE_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many interfaces '%d' for limit '%d'"),
                       nifaces, REMOTE_INTERFACE_LIST_MAX);
        goto cleanup;
    }

4812
    if (ifaces && nifaces) {
4813
        if (VIR_ALLOC_N(ret->ifaces.ifaces_val, nifaces) < 0)
4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839
            goto cleanup;

        ret->ifaces.ifaces_len = nifaces;

        for (i = 0; i < nifaces; i++)
            make_nonnull_interface(ret->ifaces.ifaces_val + i, ifaces[i]);
    } else {
        ret->ifaces.ifaces_len = 0;
        ret->ifaces.ifaces_val = NULL;
    }

    ret->ret = nifaces;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (ifaces) {
        for (i = 0; i < nifaces; i++)
            virInterfaceFree(ifaces[i]);
        VIR_FREE(ifaces);
    }
    return rv;
}

4840 4841 4842 4843 4844 4845 4846 4847 4848 4849
static int
remoteDispatchConnectListAllNodeDevices(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_connect_list_all_node_devices_args *args,
                                        remote_connect_list_all_node_devices_ret *ret)
{
    virNodeDevicePtr *devices = NULL;
    int ndevices = 0;
4850
    size_t i;
4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((ndevices = virConnectListAllNodeDevices(priv->conn,
                                                 args->need_results ? &devices : NULL,
                                                 args->flags)) < 0)
        goto cleanup;

4864 4865 4866 4867 4868 4869 4870
    if (ndevices > REMOTE_NODE_DEVICE_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many node devices '%d' for limit '%d'"),
                       ndevices, REMOTE_NODE_DEVICE_LIST_MAX);
        goto cleanup;
    }

4871
    if (devices && ndevices) {
4872
        if (VIR_ALLOC_N(ret->devices.devices_val, ndevices) < 0)
4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897
            goto cleanup;

        ret->devices.devices_len = ndevices;

        for (i = 0; i < ndevices; i++)
            make_nonnull_node_device(ret->devices.devices_val + i, devices[i]);
    } else {
        ret->devices.devices_len = 0;
        ret->devices.devices_val = NULL;
    }

    ret->ret = ndevices;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (devices) {
        for (i = 0; i < ndevices; i++)
            virNodeDeviceFree(devices[i]);
        VIR_FREE(devices);
    }
    return rv;
}
4898

4899 4900 4901 4902 4903 4904 4905 4906 4907 4908
static int
remoteDispatchConnectListAllNWFilters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_connect_list_all_nwfilters_args *args,
                                      remote_connect_list_all_nwfilters_ret *ret)
{
    virNWFilterPtr *filters = NULL;
    int nfilters = 0;
4909
    size_t i;
4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nfilters = virConnectListAllNWFilters(priv->conn,
                                               args->need_results ? &filters : NULL,
                                               args->flags)) < 0)
        goto cleanup;

4923 4924 4925 4926 4927 4928 4929
    if (nfilters > REMOTE_NWFILTER_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many network filters '%d' for limit '%d'"),
                       nfilters, REMOTE_NWFILTER_LIST_MAX);
        goto cleanup;
    }

4930
    if (filters && nfilters) {
4931
        if (VIR_ALLOC_N(ret->filters.filters_val, nfilters) < 0)
4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957
            goto cleanup;

        ret->filters.filters_len = nfilters;

        for (i = 0; i < nfilters; i++)
            make_nonnull_nwfilter(ret->filters.filters_val + i, filters[i]);
    } else {
        ret->filters.filters_len = 0;
        ret->filters.filters_val = NULL;
    }

    ret->ret = nfilters;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (filters) {
        for (i = 0; i < nfilters; i++)
            virNWFilterFree(filters[i]);
        VIR_FREE(filters);
    }
    return rv;
}

4958 4959 4960 4961 4962 4963 4964 4965 4966 4967
static int
remoteDispatchConnectListAllSecrets(virNetServerPtr server ATTRIBUTE_UNUSED,
                                    virNetServerClientPtr client,
                                    virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                    virNetMessageErrorPtr rerr,
                                    remote_connect_list_all_secrets_args *args,
                                    remote_connect_list_all_secrets_ret *ret)
{
    virSecretPtr *secrets = NULL;
    int nsecrets = 0;
4968
    size_t i;
4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981
    int rv = -1;
    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if ((nsecrets = virConnectListAllSecrets(priv->conn,
                                             args->need_results ? &secrets : NULL,
                                             args->flags)) < 0)
        goto cleanup;

4982 4983 4984 4985 4986 4987 4988
    if (nsecrets > REMOTE_SECRET_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many secrets '%d' for limit '%d'"),
                       nsecrets, REMOTE_SECRET_LIST_MAX);
        goto cleanup;
    }

4989
    if (secrets && nsecrets) {
4990
        if (VIR_ALLOC_N(ret->secrets.secrets_val, nsecrets) < 0)
4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016
            goto cleanup;

        ret->secrets.secrets_len = nsecrets;

        for (i = 0; i < nsecrets; i++)
            make_nonnull_secret(ret->secrets.secrets_val + i, secrets[i]);
    } else {
        ret->secrets.secrets_len = 0;
        ret->secrets.secrets_val = NULL;
    }

    ret->ret = nsecrets;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (secrets) {
        for (i = 0; i < nsecrets; i++)
            virSecretFree(secrets[i]);
        VIR_FREE(secrets);
    }
    return rv;
}

5017 5018 5019 5020 5021 5022 5023 5024 5025
static int
remoteDispatchNodeGetMemoryParameters(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_node_get_memory_parameters_args *args,
                                      remote_node_get_memory_parameters_ret *ret)
{
    virTypedParameterPtr params = NULL;
5026
    int nparams = 0;
5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038
    unsigned int flags;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    flags = args->flags;

5039
    if (args->nparams > REMOTE_NODE_MEMORY_PARAMETERS_MAX) {
5040 5041 5042
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large"));
        goto cleanup;
    }
5043
    if (args->nparams && VIR_ALLOC_N(params, args->nparams) < 0)
5044
        goto cleanup;
5045
    nparams = args->nparams;
5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069

    if (virNodeGetMemoryParameters(priv->conn, params, &nparams, flags) < 0)
        goto cleanup;

    /* In this case, we need to send back the number of parameters
     * supported
     */
    if (args->nparams == 0) {
        ret->nparams = nparams;
        goto success;
    }

    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       args->flags) < 0)
        goto cleanup;

success:
    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
5070
    virTypedParamsFree(params, nparams);
5071 5072 5073
    return rv;
}

5074 5075 5076 5077 5078 5079 5080 5081 5082
static int
remoteDispatchNodeGetCPUMap(virNetServerPtr server ATTRIBUTE_UNUSED,
                            virNetServerClientPtr client ATTRIBUTE_UNUSED,
                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
                            virNetMessageErrorPtr rerr,
                            remote_node_get_cpu_map_args *args,
                            remote_node_get_cpu_map_ret *ret)
{
    unsigned char *cpumap = NULL;
5083
    unsigned int online = 0;
5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096
    unsigned int flags;
    int cpunum;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    flags = args->flags;

5097 5098
    cpunum = virNodeGetCPUMap(priv->conn, args->need_map ? &cpumap : NULL,
                              args->need_online ? &online : NULL, flags);
5099 5100 5101 5102
    if (cpunum < 0)
        goto cleanup;

    /* 'serialize' return cpumap */
5103
    if (args->need_map) {
5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120
        ret->cpumap.cpumap_len = VIR_CPU_MAPLEN(cpunum);
        ret->cpumap.cpumap_val = (char *) cpumap;
        cpumap = NULL;
    }

    ret->online = online;
    ret->ret = cpunum;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    VIR_FREE(cpumap);
    return rv;
}

5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153
static int
lxcDispatchDomainOpenNamespace(virNetServerPtr server ATTRIBUTE_UNUSED,
                               virNetServerClientPtr client ATTRIBUTE_UNUSED,
                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                               virNetMessageErrorPtr rerr,
                               lxc_domain_open_namespace_args *args)
{
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *fdlist = NULL;
    int ret;
    virDomainPtr dom = NULL;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    ret = virDomainLxcOpenNamespace(dom,
                                    &fdlist,
                                    args->flags);
    if (ret < 0)
        goto cleanup;

    /* We shouldn't have received any from the client,
     * but in case they're playing games with us, prevent
     * a resource leak
     */
5154
    for (i = 0; i < msg->nfds; i++)
5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166
        VIR_FORCE_CLOSE(msg->fds[i]);
    VIR_FREE(msg->fds);
    msg->nfds = 0;

    msg->fds = fdlist;
    msg->nfds = ret;

    rv = 1;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
5167 5168
    if (dom)
        virDomainFree(dom);
5169 5170 5171
    return rv;
}

5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198
static int
remoteDispatchDomainGetJobStats(virNetServerPtr server ATTRIBUTE_UNUSED,
                                virNetServerClientPtr client,
                                virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                virNetMessageErrorPtr rerr,
                                remote_domain_get_job_stats_args *args,
                                remote_domain_get_job_stats_ret *ret)
{
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainGetJobStats(dom, &ret->type, &params,
                             &nparams, args->flags) < 0)
        goto cleanup;

5199 5200 5201 5202 5203 5204 5205
    if (nparams > REMOTE_DOMAIN_JOB_STATS_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many job stats '%d' for limit '%d'"),
                       nparams, REMOTE_DOMAIN_JOB_STATS_MAX);
        goto cleanup;
    }

5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222
    if (remoteSerializeTypedParameters(params, nparams,
                                       &ret->params.params_val,
                                       &ret->params.params_len,
                                       0) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virTypedParamsFree(params, nparams);
    if (dom)
        virDomainFree(dom);
    return rv;
}

5223
static int
5224 5225 5226 5227 5228 5229
remoteDispatchDomainMigrateBegin3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                        virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                        virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                        virNetMessageErrorPtr rerr,
                                        remote_domain_migrate_begin3_params_args *args,
                                        remote_domain_migrate_begin3_params_ret *ret)
5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245
{
    char *xml = NULL;
    virDomainPtr dom = NULL;
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5246 5247 5248 5249 5250 5251 5252
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (!(xml = virDomainMigrateBegin3Params(dom, params, nparams,
                                             &cookieout, &cookieoutlen,
                                             args->flags)))
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->xml = xml;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}

static int
5282 5283 5284 5285 5286 5287
remoteDispatchDomainMigratePrepare3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_prepare3_params_args *args,
                                          remote_domain_migrate_prepare3_params_ret *ret)
5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char **uri_out;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5303 5304 5305 5306 5307 5308 5309
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5310 5311 5312 5313 5314 5315
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    /* Wacky world of XDR ... */
5316
    if (VIR_ALLOC(uri_out) < 0)
5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341
        goto cleanup;

    if (virDomainMigratePrepare3Params(priv->conn, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       &cookieout, &cookieoutlen,
                                       uri_out, args->flags) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;
    ret->uri_out = !*uri_out ? NULL : uri_out;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(uri_out);
    }
    return rv;
}

static int
5342 5343 5344 5345 5346 5347
remoteDispatchDomainMigratePrepareTunnel3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                                virNetServerClientPtr client,
                                                virNetMessagePtr msg,
                                                virNetMessageErrorPtr rerr,
                                                remote_domain_migrate_prepare_tunnel3_params_args *args,
                                                remote_domain_migrate_prepare_tunnel3_params_ret *ret)
5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    virStreamPtr st = NULL;
    daemonClientStreamPtr stream = NULL;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5364 5365 5366 5367 5368 5369 5370
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (!(st = virStreamNew(priv->conn, VIR_STREAM_NONBLOCK)) ||
        !(stream = daemonCreateClientStream(client, st, remoteProgram,
                                            &msg->header)))
        goto cleanup;

    if (virDomainMigratePrepareTunnel3Params(priv->conn, st, params, nparams,
                                             args->cookie_in.cookie_in_val,
                                             args->cookie_in.cookie_in_len,
                                             &cookieout, &cookieoutlen,
                                             args->flags) < 0)
        goto cleanup;

    if (daemonAddClientStream(client, stream, false) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_val = cookieout;
    ret->cookie_out.cookie_out_len = cookieoutlen;
    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(cookieout);
        if (stream) {
            virStreamAbort(st);
            daemonFreeClientStream(client, stream);
        } else {
            virStreamFree(st);
        }
    }
    return rv;
}


static int
5412 5413 5414 5415 5416 5417
remoteDispatchDomainMigratePerform3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_perform3_params_args *args,
                                          remote_domain_migrate_perform3_params_ret *ret)
5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    char *dconnuri;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5434 5435 5436 5437 5438 5439 5440
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    dconnuri = args->dconnuri == NULL ? NULL : *args->dconnuri;

    if (virDomainMigratePerform3Params(dom, dconnuri, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       &cookieout, &cookieoutlen,
                                       args->flags) < 0)
        goto cleanup;

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
5474 5475 5476 5477 5478 5479
remoteDispatchDomainMigrateFinish3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                         virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                         virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                         virNetMessageErrorPtr rerr,
                                         remote_domain_migrate_finish3_params_args *args,
                                         remote_domain_migrate_finish3_params_ret *ret)
5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    char *cookieout = NULL;
    int cookieoutlen = 0;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5495 5496 5497 5498 5499 5500 5501
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534
    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    dom = virDomainMigrateFinish3Params(priv->conn, params, nparams,
                                        args->cookie_in.cookie_in_val,
                                        args->cookie_in.cookie_in_len,
                                        &cookieout, &cookieoutlen,
                                        args->flags, args->cancelled);
    if (!dom)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);

    ret->cookie_out.cookie_out_len = cookieoutlen;
    ret->cookie_out.cookie_out_val = cookieout;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0) {
        virNetMessageSaveError(rerr);
        VIR_FREE(cookieout);
    }
    if (dom)
        virDomainFree(dom);
    return rv;
}


static int
5535 5536 5537 5538 5539
remoteDispatchDomainMigrateConfirm3Params(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                          virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                          virNetMessageErrorPtr rerr,
                                          remote_domain_migrate_confirm3_params_args *args)
5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552
{
    virTypedParameterPtr params = NULL;
    int nparams = 0;
    virDomainPtr dom = NULL;
    int rv = -1;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

5553 5554 5555 5556 5557 5558 5559
    if (args->params.params_len > REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many migration parameters '%d' for limit '%d'"),
                       args->params.params_len, REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX);
        goto cleanup;
    }

5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585
    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (!(params = remoteDeserializeTypedParameters(args->params.params_val,
                                                    args->params.params_len,
                                                    0, &nparams)))
        goto cleanup;

    if (virDomainMigrateConfirm3Params(dom, params, nparams,
                                       args->cookie_in.cookie_in_val,
                                       args->cookie_in.cookie_in_len,
                                       args->flags, args->cancelled) < 0)
        goto cleanup;

    rv = 0;

cleanup:
    virTypedParamsFree(params, nparams);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637
static int
remoteDispatchConnectGetCPUModelNames(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client ATTRIBUTE_UNUSED,
                                      virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                      virNetMessageErrorPtr rerr,
                                      remote_connect_get_cpu_model_names_args *args,
                                      remote_connect_get_cpu_model_names_ret *ret)
{
    int len, rv = -1;
    char **models = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    len = virConnectGetCPUModelNames(priv->conn, args->arch,
                                     args->need_results ? &models : NULL,
                                     args->flags);
    if (len < 0)
        goto cleanup;

    if (len > REMOTE_CONNECT_CPU_MODELS_MAX) {
        virReportError(VIR_ERR_RPC,
                       _("Too many CPU models '%d' for limit '%d'"),
                       len, REMOTE_CONNECT_CPU_MODELS_MAX);
        goto cleanup;
    }

    if (len && models) {
        ret->models.models_val = models;
        ret->models.models_len = len;
        models = NULL;
    } else {
        ret->models.models_val = NULL;
        ret->models.models_len = 0;
    }

    ret->ret = len;

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virStringFreeList(models);
    return rv;
}


5638 5639 5640 5641 5642 5643 5644
static int
remoteDispatchDomainCreateXMLWithFiles(virNetServerPtr server ATTRIBUTE_UNUSED,
                                       virNetServerClientPtr client,
                                       virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                       virNetMessageErrorPtr rerr,
                                       remote_domain_create_xml_with_files_args *args,
                                       remote_domain_create_xml_with_files_ret *ret)
5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *files = NULL;
    unsigned int nfiles = 0;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (VIR_ALLOC_N(files, msg->nfds) < 0)
        goto cleanup;
    for (i = 0; i < msg->nfds; i++) {
        if ((files[i] = virNetMessageDupFD(msg, i)) < 0)
            goto cleanup;
        nfiles++;
    }

    if ((dom = virDomainCreateXMLWithFiles(priv->conn, args->xml_desc,
                                           nfiles, files,
                                           args->flags)) == NULL)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);
    rv = 0;

cleanup:
    for (i = 0; i < nfiles; i++) {
        VIR_FORCE_CLOSE(files[i]);
    }
    VIR_FREE(files);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5688 5689 5690 5691 5692 5693
static int remoteDispatchDomainCreateWithFiles(virNetServerPtr server ATTRIBUTE_UNUSED,
                                               virNetServerClientPtr client,
                                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                               virNetMessageErrorPtr rerr,
                                               remote_domain_create_with_files_args *args,
                                               remote_domain_create_with_files_ret *ret)
5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739
{
    int rv = -1;
    virDomainPtr dom = NULL;
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
    int *files = NULL;
    unsigned int nfiles = 0;
    size_t i;

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    if (VIR_ALLOC_N(files, msg->nfds) < 0)
        goto cleanup;
    for (i = 0; i < msg->nfds; i++) {
        if ((files[i] = virNetMessageDupFD(msg, i)) < 0)
            goto cleanup;
        nfiles++;
    }

    if (!(dom = get_nonnull_domain(priv->conn, args->dom)))
        goto cleanup;

    if (virDomainCreateWithFiles(dom,
                                 nfiles, files,
                                 args->flags) < 0)
        goto cleanup;

    make_nonnull_domain(&ret->dom, dom);
    rv = 0;

cleanup:
    for (i = 0; i < nfiles; i++) {
        VIR_FORCE_CLOSE(files[i]);
    }
    VIR_FREE(files);
    if (rv < 0)
        virNetMessageSaveError(rerr);
    if (dom)
        virDomainFree(dom);
    return rv;
}


5740 5741
static int
remoteDispatchConnectNetworkEventRegisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
5742
                                             virNetServerClientPtr client,
5743 5744 5745
                                             virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                             virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
                                             remote_connect_network_event_register_any_args *args,
5746
                                             remote_connect_network_event_register_any_ret *ret)
5747 5748 5749
{
    int callbackID;
    int rv = -1;
5750 5751
    daemonClientEventCallbackPtr callback = NULL;
    daemonClientEventCallbackPtr ref;
5752 5753
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);
5754
    virNetworkPtr net = NULL;
5755 5756 5757 5758 5759 5760 5761 5762

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

5763 5764 5765 5766
    if (args->net &&
        !(net = get_nonnull_network(priv->conn, *args->net)))
        goto cleanup;

5767 5768 5769
    if (args->eventID >= VIR_NETWORK_EVENT_ID_LAST || args->eventID < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unsupported network event ID %d"), args->eventID);
5770 5771 5772
        goto cleanup;
    }

5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787
    /* If we call register first, we could append a complete callback
     * to our array, but on OOM append failure, we'd have to then hope
     * deregister works to undo our register.  So instead we append an
     * incomplete callback to our array, then register, then fix up
     * our callback; but since VIR_APPEND_ELEMENT clears 'callback' on
     * success, we use 'ref' to save a copy of the pointer.  */
    if (VIR_ALLOC(callback) < 0)
        goto cleanup;
    callback->client = client;
    callback->eventID = args->eventID;
    callback->callbackID = -1;
    ref = callback;
    if (VIR_APPEND_ELEMENT(priv->networkEventCallbacks,
                           priv->nnetworkEventCallbacks,
                           callback) < 0)
5788 5789 5790
        goto cleanup;

    if ((callbackID = virConnectNetworkEventRegisterAny(priv->conn,
5791
                                                        net,
5792 5793
                                                        args->eventID,
                                                        networkEventCallbacks[args->eventID],
5794 5795 5796 5797 5798
                                                        ref,
                                                        remoteEventCallbackFree)) < 0) {
        VIR_SHRINK_N(priv->networkEventCallbacks,
                     priv->nnetworkEventCallbacks, 1);
        callback = ref;
5799
        goto cleanup;
5800
    }
5801

5802
    ref->callbackID = callbackID;
5803
    ret->callbackID = callbackID;
5804 5805 5806 5807

    rv = 0;

cleanup:
5808
    VIR_FREE(callback);
5809 5810
    if (rv < 0)
        virNetMessageSaveError(rerr);
5811 5812
    if (net)
        virNetworkFree(net);
5813 5814 5815 5816 5817 5818 5819
    virMutexUnlock(&priv->lock);
    return rv;
}


static int
remoteDispatchConnectNetworkEventDeregisterAny(virNetServerPtr server ATTRIBUTE_UNUSED,
5820
                                               virNetServerClientPtr client,
5821 5822
                                               virNetMessagePtr msg ATTRIBUTE_UNUSED,
                                               virNetMessageErrorPtr rerr ATTRIBUTE_UNUSED,
5823
                                               remote_connect_network_event_deregister_any_args *args)
5824 5825
{
    int rv = -1;
5826
    size_t i;
5827 5828 5829 5830 5831 5832 5833 5834 5835 5836
    struct daemonClientPrivate *priv =
        virNetServerClientGetPrivateData(client);

    if (!priv->conn) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
        goto cleanup;
    }

    virMutexLock(&priv->lock);

5837
    for (i = 0; i < priv->nnetworkEventCallbacks; i++) {
5838
        if (priv->networkEventCallbacks[i]->callbackID == args->callbackID)
5839 5840
            break;
    }
5841
    if (i == priv->nnetworkEventCallbacks) {
5842
        virReportError(VIR_ERR_INTERNAL_ERROR,
5843 5844
                       _("network event callback %d not registered"),
                       args->callbackID);
5845 5846 5847
        goto cleanup;
    }

5848
    if (virConnectNetworkEventDeregisterAny(priv->conn, args->callbackID) < 0)
5849 5850
        goto cleanup;

5851 5852
    VIR_DELETE_ELEMENT(priv->networkEventCallbacks, i,
                       priv->nnetworkEventCallbacks);
5853 5854 5855 5856 5857 5858 5859 5860 5861 5862

    rv = 0;

cleanup:
    if (rv < 0)
        virNetMessageSaveError(rerr);
    virMutexUnlock(&priv->lock);
    return rv;
}

5863

5864 5865 5866 5867 5868 5869 5870 5871 5872
/*----- Helpers. -----*/

/* get_nonnull_domain and get_nonnull_network turn an on-wire
 * (name, uuid) pair into virDomainPtr or virNetworkPtr object.
 * virDomainPtr or virNetworkPtr cannot be NULL.
 *
 * NB. If these return NULL then the caller must return an error.
 */
static virDomainPtr
5873
get_nonnull_domain(virConnectPtr conn, remote_nonnull_domain domain)
5874 5875
{
    virDomainPtr dom;
5876
    dom = virGetDomain(conn, domain.name, BAD_CAST domain.uuid);
5877 5878 5879 5880 5881 5882 5883 5884
    /* Should we believe the domain.id sent by the client?  Maybe
     * this should be a check rather than an assignment? XXX
     */
    if (dom) dom->id = domain.id;
    return dom;
}

static virNetworkPtr
5885
get_nonnull_network(virConnectPtr conn, remote_nonnull_network network)
5886
{
5887
    return virGetNetwork(conn, network.name, BAD_CAST network.uuid);
5888 5889
}

D
Daniel Veillard 已提交
5890
static virInterfacePtr
5891
get_nonnull_interface(virConnectPtr conn, remote_nonnull_interface iface)
D
Daniel Veillard 已提交
5892
{
5893
    return virGetInterface(conn, iface.name, iface.mac);
D
Daniel Veillard 已提交
5894 5895
}

5896
static virStoragePoolPtr
5897
get_nonnull_storage_pool(virConnectPtr conn, remote_nonnull_storage_pool pool)
5898
{
5899 5900
    return virGetStoragePool(conn, pool.name, BAD_CAST pool.uuid,
                             NULL, NULL);
5901 5902 5903
}

static virStorageVolPtr
5904
get_nonnull_storage_vol(virConnectPtr conn, remote_nonnull_storage_vol vol)
5905 5906
{
    virStorageVolPtr ret;
5907 5908
    ret = virGetStorageVol(conn, vol.pool, vol.name, vol.key,
                           NULL, NULL);
5909 5910 5911
    return ret;
}

5912
static virSecretPtr
5913
get_nonnull_secret(virConnectPtr conn, remote_nonnull_secret secret)
5914
{
5915
    return virGetSecret(conn, BAD_CAST secret.uuid, secret.usageType, secret.usageID);
5916 5917
}

5918
static virNWFilterPtr
5919
get_nonnull_nwfilter(virConnectPtr conn, remote_nonnull_nwfilter nwfilter)
5920
{
5921
    return virGetNWFilter(conn, nwfilter.name, BAD_CAST nwfilter.uuid);
5922 5923
}

C
Chris Lalancette 已提交
5924
static virDomainSnapshotPtr
5925
get_nonnull_domain_snapshot(virDomainPtr dom, remote_nonnull_domain_snapshot snapshot)
C
Chris Lalancette 已提交
5926
{
5927
    return virGetDomainSnapshot(dom, snapshot.name);
C
Chris Lalancette 已提交
5928 5929
}

5930 5931
/* Make remote_nonnull_domain and remote_nonnull_network. */
static void
5932
make_nonnull_domain(remote_nonnull_domain *dom_dst, virDomainPtr dom_src)
5933 5934
{
    dom_dst->id = dom_src->id;
5935
    ignore_value(VIR_STRDUP_QUIET(dom_dst->name, dom_src->name));
5936
    memcpy(dom_dst->uuid, dom_src->uuid, VIR_UUID_BUFLEN);
5937 5938 5939
}

static void
5940
make_nonnull_network(remote_nonnull_network *net_dst, virNetworkPtr net_src)
5941
{
5942
    ignore_value(VIR_STRDUP_QUIET(net_dst->name, net_src->name));
5943
    memcpy(net_dst->uuid, net_src->uuid, VIR_UUID_BUFLEN);
5944 5945
}

D
Daniel Veillard 已提交
5946
static void
5947 5948
make_nonnull_interface(remote_nonnull_interface *interface_dst,
                       virInterfacePtr interface_src)
D
Daniel Veillard 已提交
5949
{
5950 5951
    ignore_value(VIR_STRDUP_QUIET(interface_dst->name, interface_src->name));
    ignore_value(VIR_STRDUP_QUIET(interface_dst->mac, interface_src->mac));
D
Daniel Veillard 已提交
5952 5953
}

5954
static void
5955
make_nonnull_storage_pool(remote_nonnull_storage_pool *pool_dst, virStoragePoolPtr pool_src)
5956
{
5957
    ignore_value(VIR_STRDUP_QUIET(pool_dst->name, pool_src->name));
5958
    memcpy(pool_dst->uuid, pool_src->uuid, VIR_UUID_BUFLEN);
5959 5960 5961
}

static void
5962
make_nonnull_storage_vol(remote_nonnull_storage_vol *vol_dst, virStorageVolPtr vol_src)
5963
{
5964 5965 5966
    ignore_value(VIR_STRDUP_QUIET(vol_dst->pool, vol_src->pool));
    ignore_value(VIR_STRDUP_QUIET(vol_dst->name, vol_src->name));
    ignore_value(VIR_STRDUP_QUIET(vol_dst->key, vol_src->key));
5967
}
5968 5969

static void
5970
make_nonnull_node_device(remote_nonnull_node_device *dev_dst, virNodeDevicePtr dev_src)
5971
{
5972
    ignore_value(VIR_STRDUP_QUIET(dev_dst->name, dev_src->name));
5973
}
5974 5975

static void
5976
make_nonnull_secret(remote_nonnull_secret *secret_dst, virSecretPtr secret_src)
5977
{
5978
    memcpy(secret_dst->uuid, secret_src->uuid, VIR_UUID_BUFLEN);
5979
    secret_dst->usageType = secret_src->usageType;
5980
    ignore_value(VIR_STRDUP_QUIET(secret_dst->usageID, secret_src->usageID));
5981
}
5982 5983

static void
5984
make_nonnull_nwfilter(remote_nonnull_nwfilter *nwfilter_dst, virNWFilterPtr nwfilter_src)
5985
{
5986
    ignore_value(VIR_STRDUP_QUIET(nwfilter_dst->name, nwfilter_src->name));
5987
    memcpy(nwfilter_dst->uuid, nwfilter_src->uuid, VIR_UUID_BUFLEN);
5988
}
C
Chris Lalancette 已提交
5989 5990

static void
5991
make_nonnull_domain_snapshot(remote_nonnull_domain_snapshot *snapshot_dst, virDomainSnapshotPtr snapshot_src)
C
Chris Lalancette 已提交
5992
{
5993
    ignore_value(VIR_STRDUP_QUIET(snapshot_dst->name, snapshot_src->name));
5994
    make_nonnull_domain(&snapshot_dst->dom, snapshot_src->domain);
C
Chris Lalancette 已提交
5995
}
5996 5997 5998 5999 6000 6001 6002 6003

static int
remoteSerializeDomainDiskErrors(virDomainDiskErrorPtr errors,
                                int nerrors,
                                remote_domain_disk_error **ret_errors_val,
                                u_int *ret_errors_len)
{
    remote_domain_disk_error *val = NULL;
6004
    size_t i = 0;
6005

6006
    if (VIR_ALLOC_N(val, nerrors) < 0)
6007
        goto error;
6008 6009

    for (i = 0; i < nerrors; i++) {
6010 6011
        if (VIR_STRDUP(val[i].disk, errors[i].disk) < 0)
            goto error;
6012 6013 6014 6015 6016 6017 6018 6019
        val[i].error = errors[i].error;
    }

    *ret_errors_len = nerrors;
    *ret_errors_val = val;

    return 0;

6020
error:
6021
    if (val) {
6022
        size_t j;
6023 6024 6025 6026 6027 6028
        for (j = 0; j < i; j++)
            VIR_FREE(val[j].disk);
        VIR_FREE(val);
    }
    return -1;
}