qemu_cgroup.c 39.0 KB
Newer Older
1 2 3
/*
 * qemu_cgroup.c: QEMU cgroup management
 *
4
 * Copyright (C) 2006-2015 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24
 */

#include <config.h>

#include "qemu_cgroup.h"
25
#include "qemu_domain.h"
26
#include "qemu_process.h"
27
#include "qemu_extdevice.h"
28
#include "qemu_hostdev.h"
29
#include "virlog.h"
30
#include "viralloc.h"
31
#include "virerror.h"
32
#include "domain_audit.h"
33
#include "virscsi.h"
34
#include "virstring.h"
35
#include "virfile.h"
36
#include "virtypedparam.h"
37
#include "virnuma.h"
38
#include "virsystemd.h"
39
#include "virdevmapper.h"
40 41 42

#define VIR_FROM_THIS VIR_FROM_QEMU

43 44
VIR_LOG_INIT("qemu.qemu_cgroup");

45
const char *const defaultDeviceACL[] = {
46 47
    "/dev/null", "/dev/full", "/dev/zero",
    "/dev/random", "/dev/urandom",
48
    "/dev/ptmx", "/dev/kvm",
49
    "/dev/rtc", "/dev/hpet",
50 51 52 53 54
    NULL,
};
#define DEVICE_PTY_MAJOR 136
#define DEVICE_SND_MAJOR 116

55

56
static int
57 58 59
qemuSetupImagePathCgroup(virDomainObjPtr vm,
                         const char *path,
                         bool readonly)
60
{
61
    qemuDomainObjPrivatePtr priv = vm->privateData;
62
    int perms = VIR_CGROUP_DEVICE_READ;
63 64 65 66
    char **targetPaths = NULL;
    size_t i;
    int rv;
    int ret = -1;
67

68
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
69 70
        return 0;

71
    if (!readonly)
72
        perms |= VIR_CGROUP_DEVICE_WRITE;
73

74
    VIR_DEBUG("Allow path %s, perms: %s",
75
              path, virCgroupGetDevicePermsString(perms));
76

77
    rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, true);
78

79
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
80
                             virCgroupGetDevicePermsString(perms),
81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
                             rv);
    if (rv < 0)
        goto cleanup;

    if (rv > 0) {
        /* @path is neither character device nor block device. */
        ret = 0;
        goto cleanup;
    }

    if (virDevMapperGetTargets(path, &targetPaths) < 0 &&
        errno != ENOSYS && errno != EBADF) {
        virReportSystemError(errno,
                             _("Unable to get devmapper targets for %s"),
                             path);
        goto cleanup;
    }
98

99 100 101 102 103 104 105 106 107 108 109 110 111
    for (i = 0; targetPaths && targetPaths[i]; i++) {
        rv = virCgroupAllowDevicePath(priv->cgroup, targetPaths[i], perms, false);

        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", targetPaths[i],
                                 virCgroupGetDevicePermsString(perms),
                                 rv);
        if (rv < 0)
            goto cleanup;
    }

    ret = 0;
 cleanup:
    virStringListFree(targetPaths);
112
    return ret;
113 114 115
}


116 117 118 119 120 121 122 123 124 125 126
static int
qemuSetupImageCgroupInternal(virDomainObjPtr vm,
                             virStorageSourcePtr src,
                             bool forceReadonly)
{
    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

127
    if (virStoragePRDefIsManaged(src->pr) &&
128 129
        virFileExists(QEMU_DEVICE_MAPPER_CONTROL_PATH) &&
        qemuSetupImagePathCgroup(vm, QEMU_DEVICE_MAPPER_CONTROL_PATH, false) < 0)
130 131
        return -1;

132 133 134 135
    return qemuSetupImagePathCgroup(vm, src->path, src->readonly || forceReadonly);
}


136
int
137 138
qemuSetupImageCgroup(virDomainObjPtr vm,
                     virStorageSourcePtr src)
139
{
140
    return qemuSetupImageCgroupInternal(vm, src, false);
141 142 143 144 145 146 147
}


int
qemuTeardownImageCgroup(virDomainObjPtr vm,
                        virStorageSourcePtr src)
{
148
    qemuDomainObjPrivatePtr priv = vm->privateData;
149 150
    int perms = VIR_CGROUP_DEVICE_RWM;
    size_t i;
151 152 153 154 155 156 157 158 159 160 161 162
    int ret;

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

163
    if (virFileExists(QEMU_DEVICE_MAPPER_CONTROL_PATH)) {
164 165 166 167 168 169 170 171 172 173 174 175 176
        for (i = 0; i < vm->def->ndisks; i++) {
            virStorageSourcePtr diskSrc = vm->def->disks[i]->src;

            if (src == diskSrc)
                continue;

            if (virStoragePRDefIsManaged(diskSrc->pr))
                break;
        }

        if (i == vm->def->ndisks) {
            VIR_DEBUG("Disabling device mapper control");
            ret = virCgroupDenyDevicePath(priv->cgroup,
177 178
                                          QEMU_DEVICE_MAPPER_CONTROL_PATH,
                                          perms, true);
179
            virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
180
                                     QEMU_DEVICE_MAPPER_CONTROL_PATH,
181 182 183 184
                                     virCgroupGetDevicePermsString(perms), ret);
            if (ret < 0)
                return ret;
        }
185 186
    }

187 188 189 190 191
    VIR_DEBUG("Deny path %s", src->path);

    ret = virCgroupDenyDevicePath(priv->cgroup, src->path, perms, true);

    virDomainAuditCgroupPath(vm, priv->cgroup, "deny", src->path,
192
                             virCgroupGetDevicePermsString(perms), ret);
193

194 195 196 197 198 199 200
    /* If you're looking for a counter part to
     * qemuSetupImagePathCgroup you're at the right place.
     * However, we can't just blindly deny all the device mapper
     * targets of src->path because they might still be used by
     * another disk in domain. Just like we are not removing
     * disks from namespace. */

201
    return ret;
202 203 204
}


205
int
206 207
qemuSetupImageChainCgroup(virDomainObjPtr vm,
                          virStorageSourcePtr src)
208
{
209
    virStorageSourcePtr next;
210
    bool forceReadonly = false;
211

212
    for (next = src; virStorageSourceIsBacking(next); next = next->backingStore) {
213
        if (qemuSetupImageCgroupInternal(vm, next, forceReadonly) < 0)
214
            return -1;
215 216 217

        /* setup only the top level image for read-write */
        forceReadonly = true;
218
    }
219 220

    return 0;
221 222 223
}


224
int
225 226
qemuTeardownImageChainCgroup(virDomainObjPtr vm,
                             virStorageSourcePtr src)
227
{
228
    virStorageSourcePtr next;
229

230
    for (next = src; virStorageSourceIsBacking(next); next = next->backingStore) {
231
        if (qemuTeardownImageCgroup(vm, next) < 0)
232 233
            return -1;
    }
234

235
    return 0;
236 237
}

238

239
static int
240
qemuSetupChrSourceCgroup(virDomainObjPtr vm,
241
                         virDomainChrSourceDefPtr source)
242
{
243
    qemuDomainObjPrivatePtr priv = vm->privateData;
244
    int ret;
245

246 247 248
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

249
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
250 251
        return 0;

252
    VIR_DEBUG("Process path '%s' for device", source->data.file.path);
253

254
    ret = virCgroupAllowDevicePath(priv->cgroup, source->data.file.path,
255
                                   VIR_CGROUP_DEVICE_RW, false);
256
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
257
                             source->data.file.path, "rw", ret);
258

259
    return ret;
260 261
}

262 263 264 265 266 267 268 269

static int
qemuTeardownChrSourceCgroup(virDomainObjPtr vm,
                            virDomainChrSourceDefPtr source)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret;

270 271 272
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

273 274 275 276 277 278 279 280
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
        return 0;

    VIR_DEBUG("Process path '%s' for device", source->data.file.path);

    ret = virCgroupDenyDevicePath(priv->cgroup, source->data.file.path,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
281
                             source->data.file.path, "rw", ret);
282 283 284 285 286

    return ret;
}


287
static int
J
Ján Tomko 已提交
288
qemuSetupChardevCgroupCB(virDomainDefPtr def G_GNUC_UNUSED,
289 290
                         virDomainChrDefPtr dev,
                         void *opaque)
291
{
292 293
    virDomainObjPtr vm = opaque;

294
    return qemuSetupChrSourceCgroup(vm, dev->source);
295 296 297 298
}


static int
299
qemuSetupTPMCgroup(virDomainObjPtr vm)
300
{
301
    int ret = 0;
302
    virDomainTPMDefPtr dev = vm->def->tpm;
303 304 305

    switch (dev->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
306
        ret = qemuSetupChrSourceCgroup(vm, &dev->data.passthrough.source);
307
        break;
308
    case VIR_DOMAIN_TPM_TYPE_EMULATOR:
309 310 311 312
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

313
    return ret;
314 315
}

316

317
int
318 319 320 321 322 323
qemuSetupInputCgroup(virDomainObjPtr vm,
                     virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

324 325 326
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

327 328 329 330
    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupAllowDevicePath(priv->cgroup, dev->source.evdev,
331
                                       VIR_CGROUP_DEVICE_RW, false);
332
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", dev->source.evdev, "rw", ret);
333 334 335 336 337 338 339
        break;
    }

    return ret;
}


340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
int
qemuTeardownInputCgroup(virDomainObjPtr vm,
                        virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupDenyDevicePath(priv->cgroup, dev->source.evdev,
                                      VIR_CGROUP_DEVICE_RWM, false);
355
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny", dev->source.evdev, "rwm", ret);
356 357 358 359 360 361 362
        break;
    }

    return ret;
}


363 364 365 366 367 368 369 370 371 372
/**
 * qemuSetupHostdevCgroup:
 * vm: domain object
 * @dev: device to allow
 *
 * For given host device @dev allow access to in Cgroups.
 *
 * Returns: 0 on success,
 *         -1 otherwise.
 */
373
int
374
qemuSetupHostdevCgroup(virDomainObjPtr vm,
375 376 377
                       virDomainHostdevDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
378 379
    g_autofree char *path = NULL;
    int perms;
380
    int rv, ret = -1;
381

382 383 384
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

385
    if (qemuDomainGetHostdevPath(dev, &path, &perms) < 0)
386
        goto cleanup;
387

388 389 390 391 392 393 394
    VIR_DEBUG("Cgroup allow %s perms=%d", path, perms);
    rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
                             virCgroupGetDevicePermsString(perms),
                             rv);
    if (rv < 0)
        goto cleanup;
395

396 397 398 399 400 401 402 403 404 405
    if (qemuHostdevNeedsVFIO(dev)) {
        VIR_DEBUG("Cgroup allow %s perms=%d", QEMU_DEV_VFIO, VIR_CGROUP_DEVICE_RW);
        rv = virCgroupAllowDevicePath(priv->cgroup, QEMU_DEV_VFIO,
                                      VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
                                 QEMU_DEV_VFIO, "rw", rv);
        if (rv < 0)
            goto cleanup;
    }

406
    ret = 0;
407

408
 cleanup:
409 410 411
    return ret;
}

412 413 414 415 416 417 418 419 420 421 422 423

/**
 * qemuTeardownHostdevCgroup:
 * @vm: doamin object
 * @dev: device to tear down
 *
 * For given host device @dev deny access to it in CGroups.
 * Note, @dev must not be in @vm's definition.
 *
 * Returns: 0 on success,
 *         -1 otherwise.
 */
424 425
int
qemuTeardownHostdevCgroup(virDomainObjPtr vm,
426
                          virDomainHostdevDefPtr dev)
427 428
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
429
    g_autofree char *path = NULL;
430
    int rv, ret = -1;
431 432 433 434

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

435
    if (qemuDomainGetHostdevPath(dev, &path, NULL) < 0)
436 437
        goto cleanup;

438 439 440 441 442 443 444
    VIR_DEBUG("Cgroup deny %s", path);
    rv = virCgroupDenyDevicePath(priv->cgroup, path,
                                 VIR_CGROUP_DEVICE_RWM, false);
    virDomainAuditCgroupPath(vm, priv->cgroup,
                             "deny", path, "rwm", rv);
    if (rv < 0)
        goto cleanup;
445

446 447 448 449 450 451 452 453 454 455 456
    if (qemuHostdevNeedsVFIO(dev) &&
        !qemuDomainNeedsVFIO(vm->def)) {
        VIR_DEBUG("Cgroup deny " QEMU_DEV_VFIO);
        rv = virCgroupDenyDevicePath(priv->cgroup, QEMU_DEV_VFIO,
                                     VIR_CGROUP_DEVICE_RWM, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 QEMU_DEV_VFIO, "rwm", rv);
        if (rv < 0)
            goto cleanup;
    }

457
    ret = 0;
458
 cleanup:
459 460 461
    return ret;
}

462

463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
int
qemuSetupMemoryDevicesCgroup(virDomainObjPtr vm,
                             virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    VIR_DEBUG("Setting devices Cgroup for NVDIMM device: %s", mem->nvdimmPath);
    rv = virCgroupAllowDevicePath(priv->cgroup, mem->nvdimmPath,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
480
                             mem->nvdimmPath, "rw", rv);
481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501

    return rv;
}


int
qemuTeardownMemoryDevicesCgroup(virDomainObjPtr vm,
                                virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    rv = virCgroupDenyDevicePath(priv->cgroup, mem->nvdimmPath,
                                 VIR_CGROUP_DEVICE_RWM, false);
    virDomainAuditCgroupPath(vm, priv->cgroup,
502
                             "deny", mem->nvdimmPath, "rwm", rv);
503 504 505 506
    return rv;
}


507 508 509 510 511
static int
qemuSetupGraphicsCgroup(virDomainObjPtr vm,
                        virDomainGraphicsDefPtr gfx)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
512
    const char *rendernode = virDomainGraphicsGetRenderNode(gfx);
513 514
    int ret;

515 516
    if (!rendernode ||
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
517 518 519 520 521
        return 0;

    ret = virCgroupAllowDevicePath(priv->cgroup, rendernode,
                                   VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", rendernode,
522
                             "rw", ret);
523 524 525 526
    return ret;
}


527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549
static int
qemuSetupVideoCgroup(virDomainObjPtr vm,
                     virDomainVideoDefPtr def)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainVideoAccelDefPtr accel = def->accel;
    int ret;

    if (!accel)
        return 0;

    if (!accel->rendernode ||
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    ret = virCgroupAllowDevicePath(priv->cgroup, accel->rendernode,
                                   VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", accel->rendernode,
                             "rw", ret);
    return ret;
}


550 551 552 553
static int
qemuSetupBlkioCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
554
    size_t i;
555 556 557 558 559 560 561 562 563 564 565 566

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_BLKIO)) {
        if (vm->def->blkio.weight || vm->def->blkio.ndevices) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Block I/O tuning is not available on this host"));
            return -1;
        } else {
            return 0;
        }
    }

567 568 569
    if (vm->def->blkio.weight != 0 &&
        virCgroupSetBlkioWeight(priv->cgroup, vm->def->blkio.weight) < 0)
        return -1;
570 571 572

    if (vm->def->blkio.ndevices) {
        for (i = 0; i < vm->def->blkio.ndevices; i++) {
573
            virBlkioDevicePtr dev = &vm->def->blkio.devices[i];
574 575
            if (dev->weight &&
                (virCgroupSetBlkioDeviceWeight(priv->cgroup, dev->path,
576 577 578
                                               dev->weight) < 0 ||
                 virCgroupGetBlkioDeviceWeight(priv->cgroup, dev->path,
                                               &dev->weight) < 0))
579 580 581 582
                return -1;

            if (dev->riops &&
                (virCgroupSetBlkioDeviceReadIops(priv->cgroup, dev->path,
583 584 585
                                                 dev->riops) < 0 ||
                 virCgroupGetBlkioDeviceReadIops(priv->cgroup, dev->path,
                                                 &dev->riops) < 0))
586 587 588 589
                return -1;

            if (dev->wiops &&
                (virCgroupSetBlkioDeviceWriteIops(priv->cgroup, dev->path,
590 591 592
                                                  dev->wiops) < 0 ||
                 virCgroupGetBlkioDeviceWriteIops(priv->cgroup, dev->path,
                                                  &dev->wiops) < 0))
593 594 595 596
                return -1;

            if (dev->rbps &&
                (virCgroupSetBlkioDeviceReadBps(priv->cgroup, dev->path,
597 598 599
                                                dev->rbps) < 0 ||
                 virCgroupGetBlkioDeviceReadBps(priv->cgroup, dev->path,
                                                &dev->rbps) < 0))
600 601 602 603
                return -1;

            if (dev->wbps &&
                (virCgroupSetBlkioDeviceWriteBps(priv->cgroup, dev->path,
604 605 606
                                                 dev->wbps) < 0 ||
                 virCgroupGetBlkioDeviceWriteBps(priv->cgroup, dev->path,
                                                 &dev->wbps) < 0))
607 608 609 610 611 612 613
                return -1;
        }
    }

    return 0;
}

614

615 616 617 618 619
static int
qemuSetupMemoryCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

E
Eric Blake 已提交
620
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_MEMORY)) {
621 622 623
        if (virMemoryLimitIsSet(vm->def->mem.hard_limit) ||
            virMemoryLimitIsSet(vm->def->mem.soft_limit) ||
            virMemoryLimitIsSet(vm->def->mem.swap_hard_limit)) {
624 625 626
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Memory cgroup is not available on this host"));
            return -1;
O
Osier Yang 已提交
627 628
        } else {
            return 0;
629 630 631
        }
    }

632 633 634
    if (virMemoryLimitIsSet(vm->def->mem.hard_limit))
        if (virCgroupSetMemoryHardLimit(priv->cgroup, vm->def->mem.hard_limit) < 0)
            return -1;
635

636 637 638
    if (virMemoryLimitIsSet(vm->def->mem.soft_limit))
        if (virCgroupSetMemorySoftLimit(priv->cgroup, vm->def->mem.soft_limit) < 0)
            return -1;
639

640 641 642
    if (virMemoryLimitIsSet(vm->def->mem.swap_hard_limit))
        if (virCgroupSetMemSwapHardLimit(priv->cgroup, vm->def->mem.swap_hard_limit) < 0)
            return -1;
643 644 645 646 647

    return 0;
}


648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
static int
qemuSetupFirmwareCgroup(virDomainObjPtr vm)
{
    if (!vm->def->os.loader)
        return 0;

    if (vm->def->os.loader->path &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->path,
                                 vm->def->os.loader->readonly == VIR_TRISTATE_BOOL_YES) < 0)
        return -1;

    if (vm->def->os.loader->nvram &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->nvram, false) < 0)
        return -1;

    return 0;
}


667 668 669 670 671 672 673
int
qemuSetupRNGCgroup(virDomainObjPtr vm,
                   virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

674 675 676
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

677 678 679 680 681 682 683
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Setting Cgroup ACL for RNG device");
        rv = virCgroupAllowDevicePath(priv->cgroup,
                                      rng->source.file,
                                      VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
                                 rng->source.file,
684
                                 "rw", rv);
685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


int
qemuTeardownRNGCgroup(virDomainObjPtr vm,
                      virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

701 702 703
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

704 705 706 707 708 709 710
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Tearing down Cgroup ACL for RNG device");
        rv = virCgroupDenyDevicePath(priv->cgroup,
                                     rng->source.file,
                                     VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 rng->source.file,
711
                                 "rw", rv);
712 713 714 715 716 717 718 719 720
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736
int
qemuSetupChardevCgroup(virDomainObjPtr vm,
                       virDomainChrDefPtr dev)
{
    return qemuSetupChrSourceCgroup(vm, dev->source);
}


int
qemuTeardownChardevCgroup(virDomainObjPtr vm,
                          virDomainChrDefPtr dev)
{
    return qemuTeardownChrSourceCgroup(vm, dev->source);
}


737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752
static int
qemuSetupSEVCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    ret = virCgroupAllowDevicePath(priv->cgroup, "/dev/sev",
                                   VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", "/dev/sev",
                             "rw", ret);
    return ret;
}

753
static int
754
qemuSetupDevicesCgroup(virDomainObjPtr vm)
755 756 757 758
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = NULL;
    const char *const *deviceACL = NULL;
759
    int rv = -1;
760
    int ret = -1;
761
    size_t i;
762 763 764 765

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

766 767 768 769 770
    rv = virCgroupDenyAllDevices(priv->cgroup);
    virDomainAuditCgroup(vm, priv->cgroup, "deny", "all", rv == 0);
    if (rv < 0) {
        if (virLastErrorIsSystemErrno(EPERM)) {
            virResetLastError();
771 772 773 774 775 776 777
            VIR_WARN("Group devices ACL is not accessible, disabling whitelisting");
            return 0;
        }

        goto cleanup;
    }

778 779 780
    if (qemuSetupFirmwareCgroup(vm) < 0)
        goto cleanup;

781
    for (i = 0; i < vm->def->ndisks; i++) {
782
        if (qemuSetupImageChainCgroup(vm, vm->def->disks[i]->src) < 0)
783 784 785
            goto cleanup;
    }

786 787
    rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_PTY_MAJOR, -1,
                              VIR_CGROUP_DEVICE_RW);
788
    virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_PTY_MAJOR,
789 790
                              "pty", "rw", rv == 0);
    if (rv < 0)
791 792
        goto cleanup;

793
    cfg = virQEMUDriverGetConfig(priv->driver);
794 795 796 797 798
    deviceACL = cfg->cgroupDeviceACL ?
                (const char *const *)cfg->cgroupDeviceACL :
                defaultDeviceACL;

    if (vm->def->nsounds &&
799
        ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) ||
800 801
         (vm->def->graphics &&
          ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
802
           cfg->vncAllowHostAudio) ||
803
           (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) {
804 805
        rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_SND_MAJOR, -1,
                                  VIR_CGROUP_DEVICE_RW);
806
        virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR,
807 808
                                  "sound", "rw", rv == 0);
        if (rv < 0)
809 810 811
            goto cleanup;
    }

812
    for (i = 0; deviceACL[i] != NULL; i++) {
813
        if (!virFileExists(deviceACL[i])) {
N
Nehal J Wani 已提交
814
            VIR_DEBUG("Ignoring non-existent device %s", deviceACL[i]);
815 816 817
            continue;
        }

818
        rv = virCgroupAllowDevicePath(priv->cgroup, deviceACL[i],
819
                                      VIR_CGROUP_DEVICE_RW, false);
820
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", deviceACL[i], "rw", rv);
821 822
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
823 824 825 826 827
            goto cleanup;
    }

    if (virDomainChrDefForeach(vm->def,
                               true,
828
                               qemuSetupChardevCgroupCB,
829 830 831
                               vm) < 0)
        goto cleanup;

832
    if (vm->def->tpm && qemuSetupTPMCgroup(vm) < 0)
833 834 835
        goto cleanup;

    for (i = 0; i < vm->def->nhostdevs; i++) {
836 837
        /* This may allow /dev/vfio/vfio multiple times, but that
         * is not a problem. Kernel will have only one record. */
838
        if (qemuSetupHostdevCgroup(vm, vm->def->hostdevs[i]) < 0)
839 840 841
            goto cleanup;
    }

842 843 844 845 846
    for (i = 0; i < vm->def->nmems; i++) {
        if (qemuSetupMemoryDevicesCgroup(vm, vm->def->mems[i]) < 0)
            goto cleanup;
    }

847 848 849
    for (i = 0; i < vm->def->ngraphics; i++) {
        if (qemuSetupGraphicsCgroup(vm, vm->def->graphics[i]) < 0)
            goto cleanup;
850 851 852 853 854
    }

    for (i = 0; i < vm->def->nvideos; i++) {
        if (qemuSetupVideoCgroup(vm, vm->def->videos[i]) < 0)
            goto cleanup;
855 856
    }

857 858 859 860 861
    for (i = 0; i < vm->def->ninputs; i++) {
        if (qemuSetupInputCgroup(vm, vm->def->inputs[i]) < 0)
            goto cleanup;
    }

862
    for (i = 0; i < vm->def->nrngs; i++) {
863 864
        if (qemuSetupRNGCgroup(vm, vm->def->rngs[i]) < 0)
            goto cleanup;
865 866
    }

867 868 869
    if (vm->def->sev && qemuSetupSEVCgroup(vm) < 0)
        goto cleanup;

870
    ret = 0;
871
 cleanup:
872 873 874 875 876
    virObjectUnref(cfg);
    return ret;
}


877
static int
878
qemuSetupCpusetCgroup(virDomainObjPtr vm)
879 880 881 882 883 884
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

885 886 887
    if (virCgroupSetCpusetMemoryMigrate(priv->cgroup, true) < 0)
        return -1;

888
    return 0;
889 890 891
}


892
static int
893
qemuSetupCpuCgroup(virDomainObjPtr vm)
894 895
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
896 897 898 899
    virObjectEventPtr event = NULL;
    virTypedParameterPtr eventParams = NULL;
    int eventNparams = 0;
    int eventMaxparams = 0;
900 901

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
902
       if (vm->def->cputune.sharesSpecified) {
903 904 905 906 907 908 909 910
           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                          _("CPU tuning is not available on this host"));
           return -1;
       } else {
           return 0;
       }
    }

911 912 913 914 915 916 917
    if (vm->def->cputune.sharesSpecified) {
        unsigned long long val;
        if (virCgroupSetCpuShares(priv->cgroup, vm->def->cputune.shares) < 0)
            return -1;

        if (virCgroupGetCpuShares(priv->cgroup, &val) < 0)
            return -1;
918 919 920 921
        if (vm->def->cputune.shares != val) {
            vm->def->cputune.shares = val;
            if (virTypedParamsAddULLong(&eventParams, &eventNparams,
                                        &eventMaxparams,
922
                                        VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES,
923 924 925 926 927 928
                                        val) < 0)
                return -1;

            event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);
        }

929
        virObjectEventStateQueue(priv->driver->domainEventState, event);
930
    }
931 932 933 934 935

    return 0;
}


936
static int
937
qemuInitCgroup(virDomainObjPtr vm,
938 939
               size_t nnicindexes,
               int *nicindexes)
940
{
941
    int ret = -1;
942
    qemuDomainObjPrivatePtr priv = vm->privateData;
943
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
944

945
    if (!virQEMUDriverIsPrivileged(priv->driver))
946 947
        goto done;

948 949 950
    if (!virCgroupAvailable())
        goto done;

951
    virCgroupFree(&priv->cgroup);
952

953
    if (!vm->def->resource) {
954 955
        virDomainResourceDefPtr res;

956
        if (VIR_ALLOC(res) < 0)
957
            goto cleanup;
958

959
        res->partition = g_strdup("/machine");
960 961

        vm->def->resource = res;
962 963
    }

964 965 966 967 968 969
    if (vm->def->resource->partition[0] != '/') {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Resource partition '%s' must start with '/'"),
                       vm->def->resource->partition);
        goto cleanup;
    }
970

971
    if (virCgroupNewMachine(priv->machineName,
972 973 974 975 976
                            "qemu",
                            vm->def->uuid,
                            NULL,
                            vm->pid,
                            false,
977
                            nnicindexes, nicindexes,
978 979
                            vm->def->resource->partition,
                            cfg->cgroupControllers,
980
                            cfg->maxThreadsPerProc,
981
                            &priv->cgroup) < 0) {
982 983
        if (virCgroupNewIgnoreError())
            goto done;
984

985 986
        goto cleanup;
    }
987

988
 done:
989
    ret = 0;
990
 cleanup:
991 992 993
    virObjectUnref(cfg);
    return ret;
}
994

995 996 997
static void
qemuRestoreCgroupState(virDomainObjPtr vm)
{
998
    char *mem_mask = NULL;
999
    char *nodeset = NULL;
1000 1001
    int empty = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
1002
    size_t i = 0;
1003
    virBitmapPtr all_nodes;
1004
    virCgroupPtr cgroup_temp = NULL;
1005

1006 1007 1008 1009
    if (!virNumaIsAvailable() ||
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return;

1010
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
1011 1012 1013 1014 1015 1016
        goto error;

    if (!(mem_mask = virBitmapFormat(all_nodes)))
        goto error;

    if ((empty = virCgroupHasEmptyTasks(priv->cgroup,
1017
                                        VIR_CGROUP_CONTROLLER_CPUSET)) <= 0)
1018 1019 1020 1021 1022
        goto error;

    if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0)
        goto error;

1023
    for (i = 0; i < virDomainDefGetVcpusMax(vm->def); i++) {
1024
        virDomainVcpuDefPtr vcpu = virDomainDefGetVcpu(vm->def, i);
1025 1026 1027 1028

        if (!vcpu->online)
            continue;

J
John Ferlan 已提交
1029 1030
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               false, &cgroup_temp) < 0 ||
1031 1032 1033 1034 1035
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1036
        VIR_FREE(nodeset);
1037
        virCgroupFree(&cgroup_temp);
1038 1039
    }

1040 1041 1042
    for (i = 0; i < vm->def->niothreadids; i++) {
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               vm->def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
1043
                               false, &cgroup_temp) < 0 ||
1044 1045 1046 1047 1048
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1049
        VIR_FREE(nodeset);
1050
        virCgroupFree(&cgroup_temp);
1051 1052
    }

J
John Ferlan 已提交
1053 1054
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0 ||
1055 1056 1057 1058 1059
        virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
        virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
        virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
        goto cleanup;

1060 1061
 cleanup:
    VIR_FREE(mem_mask);
1062
    VIR_FREE(nodeset);
1063
    virBitmapFree(all_nodes);
1064
    virCgroupFree(&cgroup_temp);
1065 1066 1067 1068 1069 1070 1071
    return;

 error:
    virResetLastError();
    VIR_DEBUG("Couldn't restore cgroups to meaningful state");
    goto cleanup;
}
1072 1073

int
1074
qemuConnectCgroup(virDomainObjPtr vm)
1075 1076
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
1077
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
1078 1079
    int ret = -1;

1080
    if (!virQEMUDriverIsPrivileged(priv->driver))
1081 1082 1083 1084 1085
        goto done;

    if (!virCgroupAvailable())
        goto done;

1086
    virCgroupFree(&priv->cgroup);
1087

1088 1089 1090
    if (virCgroupNewDetectMachine(vm->def->name,
                                  "qemu",
                                  vm->pid,
1091
                                  cfg->cgroupControllers,
1092
                                  priv->machineName,
1093
                                  &priv->cgroup) < 0)
1094
        goto cleanup;
1095

1096 1097
    qemuRestoreCgroupState(vm);

1098
 done:
1099
    ret = 0;
1100
 cleanup:
1101
    virObjectUnref(cfg);
1102
    return ret;
1103 1104
}

1105
int
1106
qemuSetupCgroup(virDomainObjPtr vm,
1107 1108
                size_t nnicindexes,
                int *nicindexes)
1109
{
1110
    qemuDomainObjPrivatePtr priv = vm->privateData;
1111

1112 1113 1114 1115 1116 1117
    if (!vm->pid) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Cannot setup cgroups until process is started"));
        return -1;
    }

1118
    if (qemuInitCgroup(vm, nnicindexes, nicindexes) < 0)
1119
        return -1;
1120

1121
    if (!priv->cgroup)
1122
        return 0;
1123

1124
    if (qemuSetupDevicesCgroup(vm) < 0)
1125
        return -1;
1126

1127
    if (qemuSetupBlkioCgroup(vm) < 0)
1128
        return -1;
1129

1130
    if (qemuSetupMemoryCgroup(vm) < 0)
1131
        return -1;
1132

1133
    if (qemuSetupCpuCgroup(vm) < 0)
1134
        return -1;
1135

1136
    if (qemuSetupCpusetCgroup(vm) < 0)
1137
        return -1;
1138

1139
    return 0;
1140 1141
}

1142 1143 1144 1145
int
qemuSetupCgroupVcpuBW(virCgroupPtr cgroup,
                      unsigned long long period,
                      long long quota)
1146 1147 1148 1149 1150 1151 1152 1153
{
    unsigned long long old_period;

    if (period == 0 && quota == 0)
        return 0;

    if (period) {
        /* get old period, and we can rollback if set quota failed */
1154
        if (virCgroupGetCpuCfsPeriod(cgroup, &old_period) < 0)
1155 1156
            return -1;

1157
        if (virCgroupSetCpuCfsPeriod(cgroup, period) < 0)
1158 1159 1160
            return -1;
    }

1161 1162 1163
    if (quota &&
        virCgroupSetCpuCfsQuota(cgroup, quota) < 0)
        goto error;
1164 1165 1166

    return 0;

1167
 error:
1168
    if (period) {
1169 1170 1171
        virErrorPtr saved;

        virErrorPreserveLast(&saved);
1172
        ignore_value(virCgroupSetCpuCfsPeriod(cgroup, old_period));
1173
        virErrorRestore(&saved);
1174 1175 1176 1177 1178
    }

    return -1;
}

1179

1180
int
1181 1182
qemuSetupCgroupCpusetCpus(virCgroupPtr cgroup,
                          virBitmapPtr cpumask)
1183
{
1184
    int ret = -1;
1185 1186
    char *new_cpus = NULL;

1187
    if (!(new_cpus = virBitmapFormat(cpumask)))
1188 1189
        goto cleanup;

1190
    if (virCgroupSetCpusetCpus(cgroup, new_cpus) < 0)
1191 1192
        goto cleanup;

1193
    ret = 0;
1194
 cleanup:
1195
    VIR_FREE(new_cpus);
1196
    return ret;
1197 1198
}

1199

1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227
int
qemuSetupCgroupForExtDevices(virDomainObjPtr vm,
                             virQEMUDriverPtr driver)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virCgroupPtr cgroup_temp = NULL;
    int ret = -1;

    if (!qemuExtDevicesHasDevice(vm->def) ||
        priv->cgroup == NULL)
        return 0; /* Not supported, so claim success */

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0)
        goto cleanup;

    ret = qemuExtDevicesSetupCgroup(driver, vm->def, cgroup_temp);

 cleanup:
1228
    virCgroupFree(&cgroup_temp);
1229 1230 1231 1232 1233

    return ret;
}


1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282
int
qemuSetupGlobalCpuCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    unsigned long long period = vm->def->cputune.global_period;
    long long quota = vm->def->cputune.global_quota;
    char *mem_mask = NULL;
    virDomainNumatuneMemMode mem_mode;

    if ((period || quota) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;


    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

    if (period || quota) {
        if (qemuSetupCgroupVcpuBW(priv->cgroup, period, quota) < 0)
            goto cleanup;
    }

    VIR_FREE(mem_mask);

    return 0;

 cleanup:
    VIR_FREE(mem_mask);

    return -1;
}


1283
int
1284
qemuRemoveCgroup(virDomainObjPtr vm)
1285
{
1286
    qemuDomainObjPrivatePtr priv = vm->privateData;
1287

1288
    if (priv->cgroup == NULL)
1289 1290
        return 0; /* Not supported, so claim success */

1291
    if (virCgroupTerminateMachine(priv->machineName) < 0) {
1292 1293 1294 1295
        if (!virCgroupNewIgnoreError())
            VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name);
    }

1296
    return virCgroupRemove(priv->cgroup);
1297
}
1298 1299 1300 1301 1302 1303 1304 1305


static void
qemuCgroupEmulatorAllNodesDataFree(qemuCgroupEmulatorAllNodesDataPtr data)
{
    if (!data)
        return;

1306
    virCgroupFree(&data->emulatorCgroup);
1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319
    VIR_FREE(data->emulatorMemMask);
    VIR_FREE(data);
}


/**
 * qemuCgroupEmulatorAllNodesAllow:
 * @cgroup: domain cgroup pointer
 * @retData: filled with structure used to roll back the operation
 *
 * Allows all NUMA nodes for the qemu emulator thread temporarily. This is
 * necessary when hotplugging cpus since it requires memory allocated in the
 * DMA region. Afterwards the operation can be reverted by
1320
 * qemuCgroupEmulatorAllNodesRestore.
1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336
 *
 * Returns 0 on success -1 on error
 */
int
qemuCgroupEmulatorAllNodesAllow(virCgroupPtr cgroup,
                                qemuCgroupEmulatorAllNodesDataPtr *retData)
{
    qemuCgroupEmulatorAllNodesDataPtr data = NULL;
    char *all_nodes_str = NULL;
    virBitmapPtr all_nodes = NULL;
    int ret = -1;

    if (!virNumaIsAvailable() ||
        !virCgroupHasController(cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1337
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353
        goto cleanup;

    if (!(all_nodes_str = virBitmapFormat(all_nodes)))
        goto cleanup;

    if (VIR_ALLOC(data) < 0)
        goto cleanup;

    if (virCgroupNewThread(cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &data->emulatorCgroup) < 0)
        goto cleanup;

    if (virCgroupGetCpusetMems(data->emulatorCgroup, &data->emulatorMemMask) < 0 ||
        virCgroupSetCpusetMems(data->emulatorCgroup, all_nodes_str) < 0)
        goto cleanup;

1354
    *retData = g_steal_pointer(&data);
1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
    ret = 0;

 cleanup:
    VIR_FREE(all_nodes_str);
    virBitmapFree(all_nodes);
    qemuCgroupEmulatorAllNodesDataFree(data);

    return ret;
}


/**
1367
 * qemuCgroupEmulatorAllNodesRestore:
1368 1369 1370 1371 1372 1373
 * @data: data structure created by qemuCgroupEmulatorAllNodesAllow
 *
 * Rolls back the setting done by qemuCgroupEmulatorAllNodesAllow and frees the
 * associated data.
 */
void
1374
qemuCgroupEmulatorAllNodesRestore(qemuCgroupEmulatorAllNodesDataPtr data)
1375 1376 1377 1378 1379 1380
{
    virErrorPtr err;

    if (!data)
        return;

1381
    virErrorPreserveLast(&err);
1382
    virCgroupSetCpusetMems(data->emulatorCgroup, data->emulatorMemMask);
1383
    virErrorRestore(&err);
1384 1385 1386

    qemuCgroupEmulatorAllNodesDataFree(data);
}