qemu_cgroup.c 37.1 KB
Newer Older
1 2 3
/*
 * qemu_cgroup.c: QEMU cgroup management
 *
4
 * Copyright (C) 2006-2015 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include "qemu_cgroup.h"
27
#include "qemu_domain.h"
28
#include "qemu_process.h"
29
#include "vircgroup.h"
30
#include "virlog.h"
31
#include "viralloc.h"
32
#include "virerror.h"
33
#include "domain_audit.h"
34
#include "virscsi.h"
35
#include "virstring.h"
36
#include "virfile.h"
37
#include "virtypedparam.h"
38
#include "virnuma.h"
39
#include "virsystemd.h"
40
#include "virdevmapper.h"
41 42 43

#define VIR_FROM_THIS VIR_FROM_QEMU

44 45
VIR_LOG_INIT("qemu.qemu_cgroup");

46
const char *const defaultDeviceACL[] = {
47 48 49
    "/dev/null", "/dev/full", "/dev/zero",
    "/dev/random", "/dev/urandom",
    "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
50
    "/dev/rtc", "/dev/hpet",
51 52 53 54 55
    NULL,
};
#define DEVICE_PTY_MAJOR 136
#define DEVICE_SND_MAJOR 116

56

57
static int
58 59 60
qemuSetupImagePathCgroup(virDomainObjPtr vm,
                         const char *path,
                         bool readonly)
61
{
62
    qemuDomainObjPrivatePtr priv = vm->privateData;
63
    int perms = VIR_CGROUP_DEVICE_READ;
64 65 66 67
    char **targetPaths = NULL;
    size_t i;
    int rv;
    int ret = -1;
68

69
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
70 71
        return 0;

72
    if (!readonly)
73
        perms |= VIR_CGROUP_DEVICE_WRITE;
74

75
    VIR_DEBUG("Allow path %s, perms: %s",
76
              path, virCgroupGetDevicePermsString(perms));
77

78
    rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, true);
79

80
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
81
                             virCgroupGetDevicePermsString(perms),
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
                             rv);
    if (rv < 0)
        goto cleanup;

    if (rv > 0) {
        /* @path is neither character device nor block device. */
        ret = 0;
        goto cleanup;
    }

    if (virDevMapperGetTargets(path, &targetPaths) < 0 &&
        errno != ENOSYS && errno != EBADF) {
        virReportSystemError(errno,
                             _("Unable to get devmapper targets for %s"),
                             path);
        goto cleanup;
    }
99

100 101 102 103 104 105 106 107 108 109 110 111 112
    for (i = 0; targetPaths && targetPaths[i]; i++) {
        rv = virCgroupAllowDevicePath(priv->cgroup, targetPaths[i], perms, false);

        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", targetPaths[i],
                                 virCgroupGetDevicePermsString(perms),
                                 rv);
        if (rv < 0)
            goto cleanup;
    }

    ret = 0;
 cleanup:
    virStringListFree(targetPaths);
113
    return ret;
114 115 116
}


117 118
#define DEVICE_MAPPER_CONTROL_PATH "/dev/mapper/control"

119 120 121 122 123 124 125 126 127 128 129
static int
qemuSetupImageCgroupInternal(virDomainObjPtr vm,
                             virStorageSourcePtr src,
                             bool forceReadonly)
{
    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

130 131 132 133
    if (virStoragePRDefIsManaged(src->pr) &&
        qemuSetupImagePathCgroup(vm, DEVICE_MAPPER_CONTROL_PATH, false) < 0)
        return -1;

134 135 136 137
    return qemuSetupImagePathCgroup(vm, src->path, src->readonly || forceReadonly);
}


138
int
139 140
qemuSetupImageCgroup(virDomainObjPtr vm,
                     virStorageSourcePtr src)
141
{
142
    return qemuSetupImageCgroupInternal(vm, src, false);
143 144 145 146 147 148 149
}


int
qemuTeardownImageCgroup(virDomainObjPtr vm,
                        virStorageSourcePtr src)
{
150
    qemuDomainObjPrivatePtr priv = vm->privateData;
151 152
    int perms = VIR_CGROUP_DEVICE_RWM;
    size_t i;
153 154 155 156 157 158 159 160 161 162 163 164
    int ret;

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
    for (i = 0; i < vm->def->ndisks; i++) {
        virStorageSourcePtr diskSrc = vm->def->disks[i]->src;

        if (src == diskSrc)
            continue;

        if (virStoragePRDefIsManaged(diskSrc->pr))
            break;
    }

    if (i == vm->def->ndisks) {
        VIR_DEBUG("Disabling device mapper control");
        ret = virCgroupDenyDevicePath(priv->cgroup,
                                      DEVICE_MAPPER_CONTROL_PATH, perms, true);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 DEVICE_MAPPER_CONTROL_PATH,
                                 virCgroupGetDevicePermsString(perms), ret);
        if (ret < 0)
            return ret;
    }


187 188 189 190 191
    VIR_DEBUG("Deny path %s", src->path);

    ret = virCgroupDenyDevicePath(priv->cgroup, src->path, perms, true);

    virDomainAuditCgroupPath(vm, priv->cgroup, "deny", src->path,
192
                             virCgroupGetDevicePermsString(perms), ret);
193

194 195 196 197 198 199 200
    /* If you're looking for a counter part to
     * qemuSetupImagePathCgroup you're at the right place.
     * However, we can't just blindly deny all the device mapper
     * targets of src->path because they might still be used by
     * another disk in domain. Just like we are not removing
     * disks from namespace. */

201
    return ret;
202 203 204
}


205 206 207
int
qemuSetupDiskCgroup(virDomainObjPtr vm,
                    virDomainDiskDefPtr disk)
208
{
209
    virStorageSourcePtr next;
210
    bool forceReadonly = false;
211

212
    for (next = disk->src; virStorageSourceIsBacking(next); next = next->backingStore) {
213
        if (qemuSetupImageCgroupInternal(vm, next, forceReadonly) < 0)
214
            return -1;
215 216 217

        /* setup only the top level image for read-write */
        forceReadonly = true;
218
    }
219 220

    return 0;
221 222 223
}


224 225 226
int
qemuTeardownDiskCgroup(virDomainObjPtr vm,
                       virDomainDiskDefPtr disk)
227
{
228
    virStorageSourcePtr next;
229

230
    for (next = disk->src; virStorageSourceIsBacking(next); next = next->backingStore) {
231
        if (qemuTeardownImageCgroup(vm, next) < 0)
232 233
            return -1;
    }
234

235
    return 0;
236 237
}

238

239
static int
240
qemuSetupChrSourceCgroup(virDomainObjPtr vm,
241
                         virDomainChrSourceDefPtr source)
242
{
243
    qemuDomainObjPrivatePtr priv = vm->privateData;
244
    int ret;
245

246 247 248
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

249
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
250 251
        return 0;

252
    VIR_DEBUG("Process path '%s' for device", source->data.file.path);
253

254
    ret = virCgroupAllowDevicePath(priv->cgroup, source->data.file.path,
255
                                   VIR_CGROUP_DEVICE_RW, false);
256
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
257
                             source->data.file.path, "rw", ret);
258

259
    return ret;
260 261
}

262 263 264 265 266 267 268 269

static int
qemuTeardownChrSourceCgroup(virDomainObjPtr vm,
                            virDomainChrSourceDefPtr source)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret;

270 271 272
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

273 274 275 276 277 278 279 280
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
        return 0;

    VIR_DEBUG("Process path '%s' for device", source->data.file.path);

    ret = virCgroupDenyDevicePath(priv->cgroup, source->data.file.path,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
281
                             source->data.file.path, "rw", ret);
282 283 284 285 286

    return ret;
}


287
static int
288 289 290
qemuSetupChardevCgroupCB(virDomainDefPtr def ATTRIBUTE_UNUSED,
                         virDomainChrDefPtr dev,
                         void *opaque)
291
{
292 293
    virDomainObjPtr vm = opaque;

294
    return qemuSetupChrSourceCgroup(vm, dev->source);
295 296 297 298
}


static int
299
qemuSetupTPMCgroup(virDomainObjPtr vm)
300
{
301
    int ret = 0;
302
    virDomainTPMDefPtr dev = vm->def->tpm;
303 304 305

    switch (dev->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
306
        ret = qemuSetupChrSourceCgroup(vm, &dev->data.passthrough.source);
307 308 309 310 311
        break;
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

312
    return ret;
313 314
}

315

316
int
317 318 319 320 321 322
qemuSetupInputCgroup(virDomainObjPtr vm,
                     virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

323 324 325
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

326 327 328 329
    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupAllowDevicePath(priv->cgroup, dev->source.evdev,
330
                                       VIR_CGROUP_DEVICE_RW, false);
331
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", dev->source.evdev, "rw", ret);
332 333 334 335 336 337 338
        break;
    }

    return ret;
}


339 340 341 342 343 344 345 346 347 348 349 350 351 352 353
int
qemuTeardownInputCgroup(virDomainObjPtr vm,
                        virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupDenyDevicePath(priv->cgroup, dev->source.evdev,
                                      VIR_CGROUP_DEVICE_RWM, false);
354
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny", dev->source.evdev, "rwm", ret);
355 356 357 358 359 360 361
        break;
    }

    return ret;
}


362
int
363
qemuSetupHostdevCgroup(virDomainObjPtr vm,
364 365 366
                       virDomainHostdevDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
367 368 369 370
    char **path = NULL;
    int *perms = NULL;
    size_t i, npaths = 0;
    int rv, ret = -1;
371

372 373 374
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

375
    if (qemuDomainGetHostdevPath(NULL, dev, false, &npaths, &path, &perms) < 0)
376
        goto cleanup;
377

378 379 380 381 382
    for (i = 0; i < npaths; i++) {
        VIR_DEBUG("Cgroup allow %s perms=%d", path[i], perms[i]);
        rv = virCgroupAllowDevicePath(priv->cgroup, path[i], perms[i], false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path[i],
                                 virCgroupGetDevicePermsString(perms[i]),
383
                                 rv);
384 385
        if (rv < 0)
            goto cleanup;
386 387
    }

388
    ret = 0;
389

390
 cleanup:
391 392
    for (i = 0; i < npaths; i++)
        VIR_FREE(path[i]);
393
    VIR_FREE(path);
394
    VIR_FREE(perms);
395 396 397 398 399 400 401 402
    return ret;
}

int
qemuTeardownHostdevCgroup(virDomainObjPtr vm,
                       virDomainHostdevDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
403 404 405
    char **path = NULL;
    size_t i, npaths = 0;
    int rv, ret = -1;
406 407 408 409 410 411 412 413 414

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

415 416 417 418 419 420 421 422 423 424 425 426
    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
        dev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI &&
        dev->source.subsys.u.pci.backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO &&
        qemuDomainGetHostdevPath(vm->def, dev, true,
                                 &npaths, &path, NULL) < 0)
        goto cleanup;

    for (i = 0; i < npaths; i++) {
        VIR_DEBUG("Cgroup deny %s", path[i]);
        rv = virCgroupDenyDevicePath(priv->cgroup, path[i],
                                     VIR_CGROUP_DEVICE_RWM, false);
        virDomainAuditCgroupPath(vm, priv->cgroup,
427
                                 "deny", path[i], "rwm", rv);
428 429
        if (rv < 0)
            goto cleanup;
430 431 432
    }

    ret = 0;
433
 cleanup:
434 435
    for (i = 0; i < npaths; i++)
        VIR_FREE(path[i]);
436 437 438 439
    VIR_FREE(path);
    return ret;
}

440

441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457
int
qemuSetupMemoryDevicesCgroup(virDomainObjPtr vm,
                             virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    VIR_DEBUG("Setting devices Cgroup for NVDIMM device: %s", mem->nvdimmPath);
    rv = virCgroupAllowDevicePath(priv->cgroup, mem->nvdimmPath,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
458
                             mem->nvdimmPath, "rw", rv);
459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479

    return rv;
}


int
qemuTeardownMemoryDevicesCgroup(virDomainObjPtr vm,
                                virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    rv = virCgroupDenyDevicePath(priv->cgroup, mem->nvdimmPath,
                                 VIR_CGROUP_DEVICE_RWM, false);
    virDomainAuditCgroupPath(vm, priv->cgroup,
480
                             "deny", mem->nvdimmPath, "rwm", rv);
481 482 483 484
    return rv;
}


485 486 487 488 489 490 491 492
static int
qemuSetupGraphicsCgroup(virDomainObjPtr vm,
                        virDomainGraphicsDefPtr gfx)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    const char *rendernode = gfx->data.spice.rendernode;
    int ret;

493 494 495
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

496 497 498 499 500 501 502 503
    if (gfx->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE ||
        gfx->data.spice.gl != VIR_TRISTATE_BOOL_YES ||
        !rendernode)
        return 0;

    ret = virCgroupAllowDevicePath(priv->cgroup, rendernode,
                                   VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", rendernode,
504
                             "rw", ret);
505 506 507 508
    return ret;
}


509 510 511 512
static int
qemuSetupBlkioCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
513
    size_t i;
514 515 516 517 518 519 520 521 522 523 524 525

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_BLKIO)) {
        if (vm->def->blkio.weight || vm->def->blkio.ndevices) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Block I/O tuning is not available on this host"));
            return -1;
        } else {
            return 0;
        }
    }

526 527 528
    if (vm->def->blkio.weight != 0 &&
        virCgroupSetBlkioWeight(priv->cgroup, vm->def->blkio.weight) < 0)
        return -1;
529 530 531

    if (vm->def->blkio.ndevices) {
        for (i = 0; i < vm->def->blkio.ndevices; i++) {
532
            virBlkioDevicePtr dev = &vm->def->blkio.devices[i];
533 534
            if (dev->weight &&
                (virCgroupSetBlkioDeviceWeight(priv->cgroup, dev->path,
535 536 537
                                               dev->weight) < 0 ||
                 virCgroupGetBlkioDeviceWeight(priv->cgroup, dev->path,
                                               &dev->weight) < 0))
538 539 540 541
                return -1;

            if (dev->riops &&
                (virCgroupSetBlkioDeviceReadIops(priv->cgroup, dev->path,
542 543 544
                                                 dev->riops) < 0 ||
                 virCgroupGetBlkioDeviceReadIops(priv->cgroup, dev->path,
                                                 &dev->riops) < 0))
545 546 547 548
                return -1;

            if (dev->wiops &&
                (virCgroupSetBlkioDeviceWriteIops(priv->cgroup, dev->path,
549 550 551
                                                  dev->wiops) < 0 ||
                 virCgroupGetBlkioDeviceWriteIops(priv->cgroup, dev->path,
                                                  &dev->wiops) < 0))
552 553 554 555
                return -1;

            if (dev->rbps &&
                (virCgroupSetBlkioDeviceReadBps(priv->cgroup, dev->path,
556 557 558
                                                dev->rbps) < 0 ||
                 virCgroupGetBlkioDeviceReadBps(priv->cgroup, dev->path,
                                                &dev->rbps) < 0))
559 560 561 562
                return -1;

            if (dev->wbps &&
                (virCgroupSetBlkioDeviceWriteBps(priv->cgroup, dev->path,
563 564 565
                                                 dev->wbps) < 0 ||
                 virCgroupGetBlkioDeviceWriteBps(priv->cgroup, dev->path,
                                                 &dev->wbps) < 0))
566 567 568 569 570 571 572
                return -1;
        }
    }

    return 0;
}

573

574 575 576 577 578
static int
qemuSetupMemoryCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

E
Eric Blake 已提交
579
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_MEMORY)) {
580 581 582
        if (virMemoryLimitIsSet(vm->def->mem.hard_limit) ||
            virMemoryLimitIsSet(vm->def->mem.soft_limit) ||
            virMemoryLimitIsSet(vm->def->mem.swap_hard_limit)) {
583 584 585
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Memory cgroup is not available on this host"));
            return -1;
O
Osier Yang 已提交
586 587
        } else {
            return 0;
588 589 590
        }
    }

591 592 593
    if (virMemoryLimitIsSet(vm->def->mem.hard_limit))
        if (virCgroupSetMemoryHardLimit(priv->cgroup, vm->def->mem.hard_limit) < 0)
            return -1;
594

595 596 597
    if (virMemoryLimitIsSet(vm->def->mem.soft_limit))
        if (virCgroupSetMemorySoftLimit(priv->cgroup, vm->def->mem.soft_limit) < 0)
            return -1;
598

599 600 601
    if (virMemoryLimitIsSet(vm->def->mem.swap_hard_limit))
        if (virCgroupSetMemSwapHardLimit(priv->cgroup, vm->def->mem.swap_hard_limit) < 0)
            return -1;
602 603 604 605 606

    return 0;
}


607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625
static int
qemuSetupFirmwareCgroup(virDomainObjPtr vm)
{
    if (!vm->def->os.loader)
        return 0;

    if (vm->def->os.loader->path &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->path,
                                 vm->def->os.loader->readonly == VIR_TRISTATE_BOOL_YES) < 0)
        return -1;

    if (vm->def->os.loader->nvram &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->nvram, false) < 0)
        return -1;

    return 0;
}


626 627 628 629 630 631 632
int
qemuSetupRNGCgroup(virDomainObjPtr vm,
                   virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

633 634 635
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

636 637 638 639 640 641 642
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Setting Cgroup ACL for RNG device");
        rv = virCgroupAllowDevicePath(priv->cgroup,
                                      rng->source.file,
                                      VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
                                 rng->source.file,
643
                                 "rw", rv);
644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


int
qemuTeardownRNGCgroup(virDomainObjPtr vm,
                      virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

660 661 662
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

663 664 665 666 667 668 669
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Tearing down Cgroup ACL for RNG device");
        rv = virCgroupDenyDevicePath(priv->cgroup,
                                     rng->source.file,
                                     VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 rng->source.file,
670
                                 "rw", rv);
671 672 673 674 675 676 677 678 679
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695
int
qemuSetupChardevCgroup(virDomainObjPtr vm,
                       virDomainChrDefPtr dev)
{
    return qemuSetupChrSourceCgroup(vm, dev->source);
}


int
qemuTeardownChardevCgroup(virDomainObjPtr vm,
                          virDomainChrDefPtr dev)
{
    return qemuTeardownChrSourceCgroup(vm, dev->source);
}


696
static int
697
qemuSetupDevicesCgroup(virDomainObjPtr vm)
698 699 700 701
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = NULL;
    const char *const *deviceACL = NULL;
702
    int rv = -1;
703
    int ret = -1;
704
    size_t i;
705 706 707 708

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

709 710 711 712 713
    rv = virCgroupDenyAllDevices(priv->cgroup);
    virDomainAuditCgroup(vm, priv->cgroup, "deny", "all", rv == 0);
    if (rv < 0) {
        if (virLastErrorIsSystemErrno(EPERM)) {
            virResetLastError();
714 715 716 717 718 719 720
            VIR_WARN("Group devices ACL is not accessible, disabling whitelisting");
            return 0;
        }

        goto cleanup;
    }

721 722 723
    if (qemuSetupFirmwareCgroup(vm) < 0)
        goto cleanup;

724
    for (i = 0; i < vm->def->ndisks; i++) {
725 726 727 728
        if (qemuSetupDiskCgroup(vm, vm->def->disks[i]) < 0)
            goto cleanup;
    }

729 730
    rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_PTY_MAJOR, -1,
                              VIR_CGROUP_DEVICE_RW);
731
    virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_PTY_MAJOR,
732 733
                              "pty", "rw", rv == 0);
    if (rv < 0)
734 735
        goto cleanup;

736
    cfg = virQEMUDriverGetConfig(priv->driver);
737 738 739 740 741
    deviceACL = cfg->cgroupDeviceACL ?
                (const char *const *)cfg->cgroupDeviceACL :
                defaultDeviceACL;

    if (vm->def->nsounds &&
742
        ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) ||
743 744
         (vm->def->graphics &&
          ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
745
           cfg->vncAllowHostAudio) ||
746
           (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) {
747 748
        rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_SND_MAJOR, -1,
                                  VIR_CGROUP_DEVICE_RW);
749
        virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR,
750 751
                                  "sound", "rw", rv == 0);
        if (rv < 0)
752 753 754
            goto cleanup;
    }

755
    for (i = 0; deviceACL[i] != NULL; i++) {
756
        if (!virFileExists(deviceACL[i])) {
N
Nehal J Wani 已提交
757
            VIR_DEBUG("Ignoring non-existent device %s", deviceACL[i]);
758 759 760
            continue;
        }

761
        rv = virCgroupAllowDevicePath(priv->cgroup, deviceACL[i],
762
                                      VIR_CGROUP_DEVICE_RW, false);
763
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", deviceACL[i], "rw", rv);
764 765
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
766 767 768 769 770
            goto cleanup;
    }

    if (virDomainChrDefForeach(vm->def,
                               true,
771
                               qemuSetupChardevCgroupCB,
772 773 774
                               vm) < 0)
        goto cleanup;

775
    if (vm->def->tpm && qemuSetupTPMCgroup(vm) < 0)
776 777 778
        goto cleanup;

    for (i = 0; i < vm->def->nhostdevs; i++) {
779
        if (qemuSetupHostdevCgroup(vm, vm->def->hostdevs[i]) < 0)
780 781 782
            goto cleanup;
    }

783 784 785 786 787
    for (i = 0; i < vm->def->nmems; i++) {
        if (qemuSetupMemoryDevicesCgroup(vm, vm->def->mems[i]) < 0)
            goto cleanup;
    }

788 789 790 791 792
    for (i = 0; i < vm->def->ngraphics; i++) {
        if (qemuSetupGraphicsCgroup(vm, vm->def->graphics[i]) < 0)
            goto cleanup;
    }

793 794 795 796 797
    for (i = 0; i < vm->def->ninputs; i++) {
        if (qemuSetupInputCgroup(vm, vm->def->inputs[i]) < 0)
            goto cleanup;
    }

798
    for (i = 0; i < vm->def->nrngs; i++) {
799 800
        if (qemuSetupRNGCgroup(vm, vm->def->rngs[i]) < 0)
            goto cleanup;
801 802
    }

803
    ret = 0;
804
 cleanup:
805 806 807 808 809
    virObjectUnref(cfg);
    return ret;
}


810
int
811
qemuSetupCpusetMems(virDomainObjPtr vm)
812
{
813
    virCgroupPtr cgroup_temp = NULL;
814
    qemuDomainObjPrivatePtr priv = vm->privateData;
815
    virDomainNumatuneMemMode mode;
816
    char *mem_mask = NULL;
817 818 819 820 821
    int ret = -1;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

822 823
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 ||
        mode != VIR_DOMAIN_NUMATUNE_MEM_STRICT)
824 825
        return 0;

826
    if (virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
827
                                            priv->autoNodeset,
828
                                            &mem_mask, -1) < 0)
829
        goto cleanup;
830

831
    if (mem_mask)
J
John Ferlan 已提交
832 833
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                               false, &cgroup_temp) < 0 ||
834
            virCgroupSetCpusetMems(cgroup_temp, mem_mask) < 0)
835
            goto cleanup;
836

837 838 839
    ret = 0;
 cleanup:
    VIR_FREE(mem_mask);
840
    virCgroupFree(&cgroup_temp);
841 842 843 844 845
    return ret;
}


static int
846
qemuSetupCpusetCgroup(virDomainObjPtr vm)
847 848 849 850 851 852
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

853 854 855
    if (virCgroupSetCpusetMemoryMigrate(priv->cgroup, true) < 0)
        return -1;

856
    return 0;
857 858 859
}


860
static int
861
qemuSetupCpuCgroup(virDomainObjPtr vm)
862 863
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
864 865 866 867
    virObjectEventPtr event = NULL;
    virTypedParameterPtr eventParams = NULL;
    int eventNparams = 0;
    int eventMaxparams = 0;
868 869

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
870
       if (vm->def->cputune.sharesSpecified) {
871 872 873 874 875 876 877 878
           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                          _("CPU tuning is not available on this host"));
           return -1;
       } else {
           return 0;
       }
    }

879 880 881 882 883 884 885
    if (vm->def->cputune.sharesSpecified) {
        unsigned long long val;
        if (virCgroupSetCpuShares(priv->cgroup, vm->def->cputune.shares) < 0)
            return -1;

        if (virCgroupGetCpuShares(priv->cgroup, &val) < 0)
            return -1;
886 887 888 889
        if (vm->def->cputune.shares != val) {
            vm->def->cputune.shares = val;
            if (virTypedParamsAddULLong(&eventParams, &eventNparams,
                                        &eventMaxparams,
890
                                        VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES,
891 892 893 894 895 896
                                        val) < 0)
                return -1;

            event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);
        }

897
        qemuDomainEventQueue(priv->driver, event);
898
    }
899 900 901 902 903

    return 0;
}


904
static int
905
qemuInitCgroup(virDomainObjPtr vm,
906 907
               size_t nnicindexes,
               int *nicindexes)
908
{
909
    int ret = -1;
910
    qemuDomainObjPrivatePtr priv = vm->privateData;
911
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
912

913
    if (!virQEMUDriverIsPrivileged(priv->driver))
914 915
        goto done;

916 917 918
    if (!virCgroupAvailable())
        goto done;

919 920
    virCgroupFree(&priv->cgroup);

921
    if (!vm->def->resource) {
922 923
        virDomainResourceDefPtr res;

924
        if (VIR_ALLOC(res) < 0)
925
            goto cleanup;
926

927
        if (VIR_STRDUP(res->partition, "/machine") < 0) {
928 929 930 931 932
            VIR_FREE(res);
            goto cleanup;
        }

        vm->def->resource = res;
933 934
    }

935 936 937 938 939 940
    if (vm->def->resource->partition[0] != '/') {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Resource partition '%s' must start with '/'"),
                       vm->def->resource->partition);
        goto cleanup;
    }
941

942
    if (virCgroupNewMachine(priv->machineName,
943 944 945 946 947
                            "qemu",
                            vm->def->uuid,
                            NULL,
                            vm->pid,
                            false,
948
                            nnicindexes, nicindexes,
949 950 951
                            vm->def->resource->partition,
                            cfg->cgroupControllers,
                            &priv->cgroup) < 0) {
952 953
        if (virCgroupNewIgnoreError())
            goto done;
954

955 956
        goto cleanup;
    }
957

958
 done:
959
    ret = 0;
960
 cleanup:
961 962 963
    virObjectUnref(cfg);
    return ret;
}
964

965 966 967
static void
qemuRestoreCgroupState(virDomainObjPtr vm)
{
968
    char *mem_mask = NULL;
969
    char *nodeset = NULL;
970 971
    int empty = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
972
    size_t i = 0;
973
    virBitmapPtr all_nodes;
974
    virCgroupPtr cgroup_temp = NULL;
975

976 977 978 979
    if (!virNumaIsAvailable() ||
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return;

980
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
981 982 983 984 985 986
        goto error;

    if (!(mem_mask = virBitmapFormat(all_nodes)))
        goto error;

    if ((empty = virCgroupHasEmptyTasks(priv->cgroup,
987
                                        VIR_CGROUP_CONTROLLER_CPUSET)) <= 0)
988 989 990 991 992
        goto error;

    if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0)
        goto error;

993
    for (i = 0; i < virDomainDefGetVcpusMax(vm->def); i++) {
994
        virDomainVcpuDefPtr vcpu = virDomainDefGetVcpu(vm->def, i);
995 996 997 998

        if (!vcpu->online)
            continue;

J
John Ferlan 已提交
999 1000
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               false, &cgroup_temp) < 0 ||
1001 1002 1003 1004 1005
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1006
        VIR_FREE(nodeset);
1007 1008 1009
        virCgroupFree(&cgroup_temp);
    }

1010 1011 1012
    for (i = 0; i < vm->def->niothreadids; i++) {
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               vm->def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
1013
                               false, &cgroup_temp) < 0 ||
1014 1015 1016 1017 1018
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1019
        VIR_FREE(nodeset);
1020 1021 1022
        virCgroupFree(&cgroup_temp);
    }

J
John Ferlan 已提交
1023 1024
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0 ||
1025 1026 1027 1028 1029
        virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
        virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
        virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
        goto cleanup;

1030 1031
 cleanup:
    VIR_FREE(mem_mask);
1032
    VIR_FREE(nodeset);
1033
    virBitmapFree(all_nodes);
1034
    virCgroupFree(&cgroup_temp);
1035 1036 1037 1038 1039 1040 1041
    return;

 error:
    virResetLastError();
    VIR_DEBUG("Couldn't restore cgroups to meaningful state");
    goto cleanup;
}
1042 1043

int
1044
qemuConnectCgroup(virDomainObjPtr vm)
1045 1046
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
1047
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
1048 1049
    int ret = -1;

1050
    if (!virQEMUDriverIsPrivileged(priv->driver))
1051 1052 1053 1054 1055 1056 1057
        goto done;

    if (!virCgroupAvailable())
        goto done;

    virCgroupFree(&priv->cgroup);

1058 1059 1060
    if (virCgroupNewDetectMachine(vm->def->name,
                                  "qemu",
                                  vm->pid,
1061
                                  cfg->cgroupControllers,
1062
                                  priv->machineName,
1063
                                  &priv->cgroup) < 0)
1064
        goto cleanup;
1065

1066 1067
    qemuRestoreCgroupState(vm);

1068
 done:
1069
    ret = 0;
1070
 cleanup:
1071
    virObjectUnref(cfg);
1072
    return ret;
1073 1074
}

1075
int
1076
qemuSetupCgroup(virDomainObjPtr vm,
1077 1078
                size_t nnicindexes,
                int *nicindexes)
1079
{
1080
    qemuDomainObjPrivatePtr priv = vm->privateData;
1081
    int ret = -1;
1082

1083 1084 1085 1086 1087 1088
    if (!vm->pid) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Cannot setup cgroups until process is started"));
        return -1;
    }

1089
    if (qemuInitCgroup(vm, nnicindexes, nicindexes) < 0)
1090
        return -1;
1091

1092
    if (!priv->cgroup)
1093
        return 0;
1094

1095
    if (qemuSetupDevicesCgroup(vm) < 0)
1096
        goto cleanup;
1097

1098 1099
    if (qemuSetupBlkioCgroup(vm) < 0)
        goto cleanup;
1100

1101 1102
    if (qemuSetupMemoryCgroup(vm) < 0)
        goto cleanup;
1103

1104
    if (qemuSetupCpuCgroup(vm) < 0)
1105
        goto cleanup;
1106

1107
    if (qemuSetupCpusetCgroup(vm) < 0)
1108
        goto cleanup;
1109

1110
    ret = 0;
1111
 cleanup:
1112
    return ret;
1113 1114
}

1115 1116 1117 1118
int
qemuSetupCgroupVcpuBW(virCgroupPtr cgroup,
                      unsigned long long period,
                      long long quota)
1119 1120 1121 1122 1123 1124 1125 1126
{
    unsigned long long old_period;

    if (period == 0 && quota == 0)
        return 0;

    if (period) {
        /* get old period, and we can rollback if set quota failed */
1127
        if (virCgroupGetCpuCfsPeriod(cgroup, &old_period) < 0)
1128 1129
            return -1;

1130
        if (virCgroupSetCpuCfsPeriod(cgroup, period) < 0)
1131 1132 1133
            return -1;
    }

1134 1135 1136
    if (quota &&
        virCgroupSetCpuCfsQuota(cgroup, quota) < 0)
        goto error;
1137 1138 1139

    return 0;

1140
 error:
1141
    if (period) {
1142 1143 1144 1145 1146 1147
        virErrorPtr saved = virSaveLastError();
        ignore_value(virCgroupSetCpuCfsPeriod(cgroup, old_period));
        if (saved) {
            virSetError(saved);
            virFreeError(saved);
        }
1148 1149 1150 1151 1152
    }

    return -1;
}

1153

1154
int
1155 1156
qemuSetupCgroupCpusetCpus(virCgroupPtr cgroup,
                          virBitmapPtr cpumask)
1157
{
1158
    int ret = -1;
1159 1160
    char *new_cpus = NULL;

1161
    if (!(new_cpus = virBitmapFormat(cpumask)))
1162 1163
        goto cleanup;

1164
    if (virCgroupSetCpusetCpus(cgroup, new_cpus) < 0)
1165 1166
        goto cleanup;

1167
    ret = 0;
1168
 cleanup:
1169
    VIR_FREE(new_cpus);
1170
    return ret;
1171 1172
}

1173

1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222
int
qemuSetupGlobalCpuCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    unsigned long long period = vm->def->cputune.global_period;
    long long quota = vm->def->cputune.global_quota;
    char *mem_mask = NULL;
    virDomainNumatuneMemMode mem_mode;

    if ((period || quota) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;


    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

    if (period || quota) {
        if (qemuSetupCgroupVcpuBW(priv->cgroup, period, quota) < 0)
            goto cleanup;
    }

    VIR_FREE(mem_mask);

    return 0;

 cleanup:
    VIR_FREE(mem_mask);

    return -1;
}


1223
int
1224
qemuRemoveCgroup(virDomainObjPtr vm)
1225
{
1226
    qemuDomainObjPrivatePtr priv = vm->privateData;
1227

1228
    if (priv->cgroup == NULL)
1229 1230
        return 0; /* Not supported, so claim success */

1231
    if (virCgroupTerminateMachine(priv->machineName) < 0) {
1232 1233 1234 1235
        if (!virCgroupNewIgnoreError())
            VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name);
    }

1236
    return virCgroupRemove(priv->cgroup);
1237
}
1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259


static void
qemuCgroupEmulatorAllNodesDataFree(qemuCgroupEmulatorAllNodesDataPtr data)
{
    if (!data)
        return;

    virCgroupFree(&data->emulatorCgroup);
    VIR_FREE(data->emulatorMemMask);
    VIR_FREE(data);
}


/**
 * qemuCgroupEmulatorAllNodesAllow:
 * @cgroup: domain cgroup pointer
 * @retData: filled with structure used to roll back the operation
 *
 * Allows all NUMA nodes for the qemu emulator thread temporarily. This is
 * necessary when hotplugging cpus since it requires memory allocated in the
 * DMA region. Afterwards the operation can be reverted by
1260
 * qemuCgroupEmulatorAllNodesRestore.
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276
 *
 * Returns 0 on success -1 on error
 */
int
qemuCgroupEmulatorAllNodesAllow(virCgroupPtr cgroup,
                                qemuCgroupEmulatorAllNodesDataPtr *retData)
{
    qemuCgroupEmulatorAllNodesDataPtr data = NULL;
    char *all_nodes_str = NULL;
    virBitmapPtr all_nodes = NULL;
    int ret = -1;

    if (!virNumaIsAvailable() ||
        !virCgroupHasController(cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1277
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306
        goto cleanup;

    if (!(all_nodes_str = virBitmapFormat(all_nodes)))
        goto cleanup;

    if (VIR_ALLOC(data) < 0)
        goto cleanup;

    if (virCgroupNewThread(cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &data->emulatorCgroup) < 0)
        goto cleanup;

    if (virCgroupGetCpusetMems(data->emulatorCgroup, &data->emulatorMemMask) < 0 ||
        virCgroupSetCpusetMems(data->emulatorCgroup, all_nodes_str) < 0)
        goto cleanup;

    VIR_STEAL_PTR(*retData, data);
    ret = 0;

 cleanup:
    VIR_FREE(all_nodes_str);
    virBitmapFree(all_nodes);
    qemuCgroupEmulatorAllNodesDataFree(data);

    return ret;
}


/**
1307
 * qemuCgroupEmulatorAllNodesRestore:
1308 1309 1310 1311 1312 1313
 * @data: data structure created by qemuCgroupEmulatorAllNodesAllow
 *
 * Rolls back the setting done by qemuCgroupEmulatorAllNodesAllow and frees the
 * associated data.
 */
void
1314
qemuCgroupEmulatorAllNodesRestore(qemuCgroupEmulatorAllNodesDataPtr data)
1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327
{
    virErrorPtr err;

    if (!data)
        return;

    err = virSaveLastError();
    virCgroupSetCpusetMems(data->emulatorCgroup, data->emulatorMemMask);
    virSetError(err);
    virFreeError(err);

    qemuCgroupEmulatorAllNodesDataFree(data);
}