qemu_cgroup.c 38.4 KB
Newer Older
1 2 3
/*
 * qemu_cgroup.c: QEMU cgroup management
 *
4
 * Copyright (C) 2006-2015 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include "qemu_cgroup.h"
27
#include "qemu_domain.h"
28
#include "qemu_process.h"
29
#include "vircgroup.h"
30
#include "virlog.h"
31
#include "viralloc.h"
32
#include "virerror.h"
33
#include "domain_audit.h"
34
#include "virscsi.h"
35
#include "virstring.h"
36
#include "virfile.h"
37
#include "virtypedparam.h"
38
#include "virnuma.h"
39 40 41

#define VIR_FROM_THIS VIR_FROM_QEMU

42 43
VIR_LOG_INIT("qemu.qemu_cgroup");

44 45 46 47
static const char *const defaultDeviceACL[] = {
    "/dev/null", "/dev/full", "/dev/zero",
    "/dev/random", "/dev/urandom",
    "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
48
    "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio",
49 50 51 52 53
    NULL,
};
#define DEVICE_PTY_MAJOR 136
#define DEVICE_SND_MAJOR 116

54 55 56 57 58
static int
qemuSetImageCgroupInternal(virDomainObjPtr vm,
                           virStorageSourcePtr src,
                           bool deny,
                           bool forceReadonly)
59
{
60
    qemuDomainObjPrivatePtr priv = vm->privateData;
61
    int perms = VIR_CGROUP_DEVICE_READ;
62
    int ret;
63

64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

    if (deny) {
        perms |= VIR_CGROUP_DEVICE_WRITE | VIR_CGROUP_DEVICE_MKNOD;

        VIR_DEBUG("Deny path %s", src->path);

        ret = virCgroupDenyDevicePath(priv->cgroup, src->path, perms);
    } else {
81
        if (!src->readonly && !forceReadonly)
82 83 84 85 86 87 88 89 90 91 92 93 94
            perms |= VIR_CGROUP_DEVICE_WRITE;

        VIR_DEBUG("Allow path %s, perms: %s",
                  src->path, virCgroupGetDevicePermsString(perms));

        ret = virCgroupAllowDevicePath(priv->cgroup, src->path, perms);
    }

    virDomainAuditCgroupPath(vm, priv->cgroup,
                             deny ? "deny" : "allow",
                             src->path,
                             virCgroupGetDevicePermsString(perms),
                             ret == 0);
95 96 97 98

    /* Get this for root squash NFS */
    if (ret < 0 &&
        virLastErrorIsSystemErrno(EACCES)) {
99
        VIR_DEBUG("Ignoring EACCES for %s", src->path);
100 101
        virResetLastError();
        ret = 0;
102
    }
103

104
    return ret;
105 106 107
}


108 109 110 111 112 113 114 115 116
int
qemuSetImageCgroup(virDomainObjPtr vm,
                   virStorageSourcePtr src,
                   bool deny)
{
    return qemuSetImageCgroupInternal(vm, src, deny, false);
}


117 118 119
int
qemuSetupDiskCgroup(virDomainObjPtr vm,
                    virDomainDiskDefPtr disk)
120
{
121
    virStorageSourcePtr next;
122
    bool forceReadonly = false;
123

124
    for (next = disk->src; next; next = next->backingStore) {
125
        if (qemuSetImageCgroupInternal(vm, next, false, forceReadonly) < 0)
126
            return -1;
127 128 129

        /* setup only the top level image for read-write */
        forceReadonly = true;
130
    }
131 132

    return 0;
133 134 135
}


136 137 138
int
qemuTeardownDiskCgroup(virDomainObjPtr vm,
                       virDomainDiskDefPtr disk)
139
{
140
    virStorageSourcePtr next;
141

142 143 144 145
    for (next = disk->src; next; next = next->backingStore) {
        if (qemuSetImageCgroup(vm, next, true) < 0)
            return -1;
    }
146

147
    return 0;
148 149
}

150

151
static int
152 153
qemuSetupChrSourceCgroup(virDomainObjPtr vm,
                         virDomainChrSourceDefPtr dev)
154
{
155
    qemuDomainObjPrivatePtr priv = vm->privateData;
156
    int ret;
157

158
    if (dev->type != VIR_DOMAIN_CHR_TYPE_DEV)
159 160
        return 0;

161
    VIR_DEBUG("Process path '%s' for device", dev->data.file.path);
162

163 164
    ret = virCgroupAllowDevicePath(priv->cgroup, dev->data.file.path,
                                   VIR_CGROUP_DEVICE_RW);
165
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
166
                             dev->data.file.path, "rw", ret == 0);
167

168
    return ret;
169 170
}

171
static int
172
qemuSetupChardevCgroup(virDomainDefPtr def ATTRIBUTE_UNUSED,
173 174 175
                       virDomainChrDefPtr dev,
                       void *opaque)
{
176 177 178
    virDomainObjPtr vm = opaque;

    return qemuSetupChrSourceCgroup(vm, &dev->source);
179 180 181 182
}


static int
183
qemuSetupTPMCgroup(virDomainObjPtr vm)
184
{
185
    int ret = 0;
186
    virDomainTPMDefPtr dev = vm->def->tpm;
187 188 189

    switch (dev->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
190
        ret = qemuSetupChrSourceCgroup(vm, &dev->data.passthrough.source);
191 192 193 194 195
        break;
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

196
    return ret;
197 198
}

199

200
static int
201
qemuSetupHostUSBDeviceCgroup(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
202 203
                             const char *path,
                             void *opaque)
204
{
205 206
    virDomainObjPtr vm = opaque;
    qemuDomainObjPrivatePtr priv = vm->privateData;
207
    int ret;
208 209

    VIR_DEBUG("Process path '%s' for USB device", path);
210 211 212
    ret = virCgroupAllowDevicePath(priv->cgroup, path,
                                   VIR_CGROUP_DEVICE_RW);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path, "rw", ret == 0);
213

214
    return ret;
215 216
}

217
static int
218
qemuSetupHostSCSIDeviceCgroup(virSCSIDevicePtr dev ATTRIBUTE_UNUSED,
219 220 221 222 223
                              const char *path,
                              void *opaque)
{
    virDomainObjPtr vm = opaque;
    qemuDomainObjPrivatePtr priv = vm->privateData;
224
    int ret;
225 226 227

    VIR_DEBUG("Process path '%s' for SCSI device", path);

228 229 230 231
    ret = virCgroupAllowDevicePath(priv->cgroup, path,
                                   virSCSIDeviceGetReadonly(dev) ?
                                   VIR_CGROUP_DEVICE_READ :
                                   VIR_CGROUP_DEVICE_RW);
232 233

    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
234
                             virSCSIDeviceGetReadonly(dev) ? "r" : "rw", ret == 0);
235

236
    return ret;
237
}
238

239
int
240
qemuSetupHostdevCgroup(virDomainObjPtr vm,
241 242 243 244
                       virDomainHostdevDefPtr dev)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
245
    virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
246
    virDomainHostdevSubsysPCIPtr pcisrc = &dev->source.subsys.u.pci;
247
    virDomainHostdevSubsysSCSIPtr scsisrc = &dev->source.subsys.u.scsi;
248
    virPCIDevicePtr pci = NULL;
249
    virUSBDevicePtr usb = NULL;
250
    virSCSIDevicePtr scsi = NULL;
251 252 253 254 255 256 257 258 259 260 261 262 263 264
    char *path = NULL;

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {

        switch (dev->source.subsys.type) {
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
265
            if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
266
                int rv;
267

268 269 270 271
                pci = virPCIDeviceNew(pcisrc->addr.domain,
                                      pcisrc->addr.bus,
                                      pcisrc->addr.slot,
                                      pcisrc->addr.function);
272 273 274
                if (!pci)
                    goto cleanup;

275
                if (!(path = virPCIDeviceGetIOMMUGroupDev(pci)))
276 277 278
                    goto cleanup;

                VIR_DEBUG("Cgroup allow %s for PCI device assignment", path);
279
                rv = virCgroupAllowDevicePath(priv->cgroup, path,
280 281
                                              VIR_CGROUP_DEVICE_RW);
                virDomainAuditCgroupPath(vm, priv->cgroup,
282 283
                                         "allow", path, "rw", rv == 0);
                if (rv < 0)
284 285 286
                    goto cleanup;
            }
            break;
287 288 289 290 291 292 293 294

        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
            /* NB: hostdev->missing wasn't previously checked in the
             * case of hotplug, only when starting a domain. Now it is
             * always checked, and the cgroup setup skipped if true.
             */
            if (dev->missing)
                break;
295
            if ((usb = virUSBDeviceNew(usbsrc->bus, usbsrc->device,
296 297 298 299
                                       NULL)) == NULL) {
                goto cleanup;
            }

300
            /* oddly, qemuSetupHostUSBDeviceCgroup doesn't ever
301 302
             * reference the usb object we just created
             */
303
            if (virUSBDeviceFileIterate(usb, qemuSetupHostUSBDeviceCgroup,
304 305 306 307
                                        vm) < 0) {
                goto cleanup;
            }
            break;
308

309
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: {
310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328
            if (scsisrc->protocol ==
                VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
                virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
                /* Follow qemuSetupDiskCgroup() and qemuSetImageCgroupInternal()
                 * which does nothing for non local storage
                 */
                VIR_DEBUG("Not updating cgroups for hostdev iSCSI path '%s'",
                          iscsisrc->path);
            } else {
                virDomainHostdevSubsysSCSIHostPtr scsihostsrc =
                    &scsisrc->u.host;
                if ((scsi = virSCSIDeviceNew(NULL,
                                             scsihostsrc->adapter,
                                             scsihostsrc->bus,
                                             scsihostsrc->target,
                                             scsihostsrc->unit,
                                             dev->readonly,
                                             dev->shareable)) == NULL)
                    goto cleanup;
329

330 331 332 333 334
                if (virSCSIDeviceFileIterate(scsi,
                                             qemuSetupHostSCSIDeviceCgroup,
                                             vm) < 0)
                    goto cleanup;
            }
335 336
            break;
        }
337

338 339 340 341 342 343
        default:
            break;
        }
    }

    ret = 0;
344
 cleanup:
345
    virPCIDeviceFree(pci);
346
    virUSBDeviceFree(usb);
347
    virSCSIDeviceFree(scsi);
348 349 350 351 352 353 354 355 356 357
    VIR_FREE(path);
    return ret;
}

int
qemuTeardownHostdevCgroup(virDomainObjPtr vm,
                       virDomainHostdevDefPtr dev)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
358
    virDomainHostdevSubsysPCIPtr pcisrc = &dev->source.subsys.u.pci;
359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
    virPCIDevicePtr pci = NULL;
    char *path = NULL;

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {

        switch (dev->source.subsys.type) {
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
374
            if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
375
                int rv;
376

377 378 379 380
                pci = virPCIDeviceNew(pcisrc->addr.domain,
                                      pcisrc->addr.bus,
                                      pcisrc->addr.slot,
                                      pcisrc->addr.function);
381 382 383
                if (!pci)
                    goto cleanup;

384
                if (!(path = virPCIDeviceGetIOMMUGroupDev(pci)))
385 386 387
                    goto cleanup;

                VIR_DEBUG("Cgroup deny %s for PCI device assignment", path);
388
                rv = virCgroupDenyDevicePath(priv->cgroup, path,
389 390
                                             VIR_CGROUP_DEVICE_RWM);
                virDomainAuditCgroupPath(vm, priv->cgroup,
391 392
                                         "deny", path, "rwm", rv == 0);
                if (rv < 0)
393 394 395
                    goto cleanup;
            }
            break;
396 397 398
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
            /* nothing to tear down for USB */
            break;
399 400 401 402 403 404
        default:
            break;
        }
    }

    ret = 0;
405
 cleanup:
406 407 408 409 410
    virPCIDeviceFree(pci);
    VIR_FREE(path);
    return ret;
}

411 412 413 414
static int
qemuSetupBlkioCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
415
    size_t i;
416 417 418 419 420 421 422 423 424 425 426 427

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_BLKIO)) {
        if (vm->def->blkio.weight || vm->def->blkio.ndevices) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Block I/O tuning is not available on this host"));
            return -1;
        } else {
            return 0;
        }
    }

428 429 430
    if (vm->def->blkio.weight != 0 &&
        virCgroupSetBlkioWeight(priv->cgroup, vm->def->blkio.weight) < 0)
        return -1;
431 432 433

    if (vm->def->blkio.ndevices) {
        for (i = 0; i < vm->def->blkio.ndevices; i++) {
434
            virBlkioDevicePtr dev = &vm->def->blkio.devices[i];
435 436
            if (dev->weight &&
                (virCgroupSetBlkioDeviceWeight(priv->cgroup, dev->path,
437 438 439
                                               dev->weight) < 0 ||
                 virCgroupGetBlkioDeviceWeight(priv->cgroup, dev->path,
                                               &dev->weight) < 0))
440 441 442 443
                return -1;

            if (dev->riops &&
                (virCgroupSetBlkioDeviceReadIops(priv->cgroup, dev->path,
444 445 446
                                                 dev->riops) < 0 ||
                 virCgroupGetBlkioDeviceReadIops(priv->cgroup, dev->path,
                                                 &dev->riops) < 0))
447 448 449 450
                return -1;

            if (dev->wiops &&
                (virCgroupSetBlkioDeviceWriteIops(priv->cgroup, dev->path,
451 452 453
                                                  dev->wiops) < 0 ||
                 virCgroupGetBlkioDeviceWriteIops(priv->cgroup, dev->path,
                                                  &dev->wiops) < 0))
454 455 456 457
                return -1;

            if (dev->rbps &&
                (virCgroupSetBlkioDeviceReadBps(priv->cgroup, dev->path,
458 459 460
                                                dev->rbps) < 0 ||
                 virCgroupGetBlkioDeviceReadBps(priv->cgroup, dev->path,
                                                &dev->rbps) < 0))
461 462 463 464
                return -1;

            if (dev->wbps &&
                (virCgroupSetBlkioDeviceWriteBps(priv->cgroup, dev->path,
465 466 467
                                                 dev->wbps) < 0 ||
                 virCgroupGetBlkioDeviceWriteBps(priv->cgroup, dev->path,
                                                 &dev->wbps) < 0))
468 469 470 471 472 473 474
                return -1;
        }
    }

    return 0;
}

475

476 477 478 479 480
static int
qemuSetupMemoryCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

E
Eric Blake 已提交
481
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_MEMORY)) {
482 483 484
        if (virMemoryLimitIsSet(vm->def->mem.hard_limit) ||
            virMemoryLimitIsSet(vm->def->mem.soft_limit) ||
            virMemoryLimitIsSet(vm->def->mem.swap_hard_limit)) {
485 486 487
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Memory cgroup is not available on this host"));
            return -1;
O
Osier Yang 已提交
488 489
        } else {
            return 0;
490 491 492
        }
    }

493 494 495
    if (virMemoryLimitIsSet(vm->def->mem.hard_limit))
        if (virCgroupSetMemoryHardLimit(priv->cgroup, vm->def->mem.hard_limit) < 0)
            return -1;
496

497 498 499
    if (virMemoryLimitIsSet(vm->def->mem.soft_limit))
        if (virCgroupSetMemorySoftLimit(priv->cgroup, vm->def->mem.soft_limit) < 0)
            return -1;
500

501 502 503
    if (virMemoryLimitIsSet(vm->def->mem.swap_hard_limit))
        if (virCgroupSetMemSwapHardLimit(priv->cgroup, vm->def->mem.swap_hard_limit) < 0)
            return -1;
504 505 506 507 508

    return 0;
}


509 510 511 512 513 514 515
static int
qemuSetupDevicesCgroup(virQEMUDriverPtr driver,
                       virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = NULL;
    const char *const *deviceACL = NULL;
516
    int rv = -1;
517
    int ret = -1;
518
    size_t i;
519 520 521 522

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

523 524 525 526 527
    rv = virCgroupDenyAllDevices(priv->cgroup);
    virDomainAuditCgroup(vm, priv->cgroup, "deny", "all", rv == 0);
    if (rv < 0) {
        if (virLastErrorIsSystemErrno(EPERM)) {
            virResetLastError();
528 529 530 531 532 533 534
            VIR_WARN("Group devices ACL is not accessible, disabling whitelisting");
            return 0;
        }

        goto cleanup;
    }

535
    for (i = 0; i < vm->def->ndisks; i++) {
536 537 538 539
        if (qemuSetupDiskCgroup(vm, vm->def->disks[i]) < 0)
            goto cleanup;
    }

540
    rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_PTY_MAJOR,
541 542
                                   VIR_CGROUP_DEVICE_RW);
    virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_PTY_MAJOR,
543 544
                              "pty", "rw", rv == 0);
    if (rv < 0)
545 546 547 548 549 550 551 552
        goto cleanup;

    cfg = virQEMUDriverGetConfig(driver);
    deviceACL = cfg->cgroupDeviceACL ?
                (const char *const *)cfg->cgroupDeviceACL :
                defaultDeviceACL;

    if (vm->def->nsounds &&
553
        ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) ||
554 555
         (vm->def->graphics &&
          ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
556
           cfg->vncAllowHostAudio) ||
557
           (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) {
558
        rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_SND_MAJOR,
559 560
                                       VIR_CGROUP_DEVICE_RW);
        virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR,
561 562
                                  "sound", "rw", rv == 0);
        if (rv < 0)
563 564 565
            goto cleanup;
    }

566
    for (i = 0; deviceACL[i] != NULL; i++) {
567
        if (!virFileExists(deviceACL[i])) {
N
Nehal J Wani 已提交
568
            VIR_DEBUG("Ignoring non-existent device %s", deviceACL[i]);
569 570 571
            continue;
        }

572
        rv = virCgroupAllowDevicePath(priv->cgroup, deviceACL[i],
573
                                      VIR_CGROUP_DEVICE_RW);
574 575 576
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", deviceACL[i], "rw", rv == 0);
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
577 578 579 580 581 582 583 584 585
            goto cleanup;
    }

    if (virDomainChrDefForeach(vm->def,
                               true,
                               qemuSetupChardevCgroup,
                               vm) < 0)
        goto cleanup;

586
    if (vm->def->tpm && qemuSetupTPMCgroup(vm) < 0)
587 588 589
        goto cleanup;

    for (i = 0; i < vm->def->nhostdevs; i++) {
590
        if (qemuSetupHostdevCgroup(vm, vm->def->hostdevs[i]) < 0)
591 592 593
            goto cleanup;
    }

594 595 596
    for (i = 0; i < vm->def->nrngs; i++) {
        if (vm->def->rngs[i]->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
            VIR_DEBUG("Setting Cgroup ACL for RNG device");
597 598
            rv = virCgroupAllowDevicePath(priv->cgroup,
                                          vm->def->rngs[i]->source.file,
599 600
                                          VIR_CGROUP_DEVICE_RW);
            virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
601 602
                                     vm->def->rngs[i]->source.file,
                                     "rw", rv == 0);
603 604 605 606
            if (rv < 0 &&
                !virLastErrorIsSystemErrno(ENOENT))
                goto cleanup;
        }
607 608
    }

609
    ret = 0;
610
 cleanup:
611 612 613 614 615
    virObjectUnref(cfg);
    return ret;
}


616
int
617
qemuSetupCpusetMems(virDomainObjPtr vm)
618
{
619
    virCgroupPtr cgroup_temp = NULL;
620
    qemuDomainObjPrivatePtr priv = vm->privateData;
621
    virDomainNumatuneMemMode mode;
622
    char *mem_mask = NULL;
623 624 625 626 627
    int ret = -1;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

628 629
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 ||
        mode != VIR_DOMAIN_NUMATUNE_MEM_STRICT)
630 631
        return 0;

632
    if (virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
633
                                            priv->autoNodeset,
634
                                            &mem_mask, -1) < 0)
635
        goto cleanup;
636

637
    if (mem_mask)
J
John Ferlan 已提交
638 639
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                               false, &cgroup_temp) < 0 ||
640
            virCgroupSetCpusetMems(cgroup_temp, mem_mask) < 0)
641
            goto cleanup;
642

643 644 645
    ret = 0;
 cleanup:
    VIR_FREE(mem_mask);
646
    virCgroupFree(&cgroup_temp);
647 648 649 650 651
    return ret;
}


static int
652
qemuSetupCpusetCgroup(virDomainObjPtr vm)
653 654 655 656 657 658
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

659 660 661
    if (virCgroupSetCpusetMemoryMigrate(priv->cgroup, true) < 0)
        return -1;

662
    return 0;
663 664 665
}


666
static int
667 668
qemuSetupCpuCgroup(virQEMUDriverPtr driver,
                   virDomainObjPtr vm)
669 670
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
671 672 673 674
    virObjectEventPtr event = NULL;
    virTypedParameterPtr eventParams = NULL;
    int eventNparams = 0;
    int eventMaxparams = 0;
675 676

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
677
       if (vm->def->cputune.sharesSpecified) {
678 679 680 681 682 683 684 685
           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                          _("CPU tuning is not available on this host"));
           return -1;
       } else {
           return 0;
       }
    }

686 687 688 689 690 691 692
    if (vm->def->cputune.sharesSpecified) {
        unsigned long long val;
        if (virCgroupSetCpuShares(priv->cgroup, vm->def->cputune.shares) < 0)
            return -1;

        if (virCgroupGetCpuShares(priv->cgroup, &val) < 0)
            return -1;
693 694 695 696
        if (vm->def->cputune.shares != val) {
            vm->def->cputune.shares = val;
            if (virTypedParamsAddULLong(&eventParams, &eventNparams,
                                        &eventMaxparams,
697
                                        VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES,
698 699 700 701 702 703
                                        val) < 0)
                return -1;

            event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);
        }

704
        qemuDomainEventQueue(driver, event);
705
    }
706 707 708 709 710

    return 0;
}


711
static int
712
qemuInitCgroup(virQEMUDriverPtr driver,
713 714 715
               virDomainObjPtr vm,
               size_t nnicindexes,
               int *nicindexes)
716
{
717
    int ret = -1;
718 719 720
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

721
    if (!virQEMUDriverIsPrivileged(driver))
722 723
        goto done;

724 725 726
    if (!virCgroupAvailable())
        goto done;

727 728
    virCgroupFree(&priv->cgroup);

729
    if (!vm->def->resource) {
730 731
        virDomainResourceDefPtr res;

732
        if (VIR_ALLOC(res) < 0)
733
            goto cleanup;
734

735
        if (VIR_STRDUP(res->partition, "/machine") < 0) {
736 737 738 739 740
            VIR_FREE(res);
            goto cleanup;
        }

        vm->def->resource = res;
741 742
    }

743 744 745 746 747 748
    if (vm->def->resource->partition[0] != '/') {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Resource partition '%s' must start with '/'"),
                       vm->def->resource->partition);
        goto cleanup;
    }
749 750 751

    if (virCgroupNewMachine(vm->def->name,
                            "qemu",
752
                            true,
753 754 755 756
                            vm->def->uuid,
                            NULL,
                            vm->pid,
                            false,
757
                            nnicindexes, nicindexes,
758 759 760
                            vm->def->resource->partition,
                            cfg->cgroupControllers,
                            &priv->cgroup) < 0) {
761 762
        if (virCgroupNewIgnoreError())
            goto done;
763

764 765
        goto cleanup;
    }
766

767
 done:
768
    ret = 0;
769
 cleanup:
770 771 772
    virObjectUnref(cfg);
    return ret;
}
773

774 775 776
static void
qemuRestoreCgroupState(virDomainObjPtr vm)
{
777
    char *mem_mask = NULL;
778
    char *nodeset = NULL;
779 780
    int empty = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
781
    size_t i = 0;
782
    virBitmapPtr all_nodes;
783
    virCgroupPtr cgroup_temp = NULL;
784 785 786 787 788 789 790 791

    if (!(all_nodes = virNumaGetHostNodeset()))
        goto error;

    if (!(mem_mask = virBitmapFormat(all_nodes)))
        goto error;

    if ((empty = virCgroupHasEmptyTasks(priv->cgroup,
792
                                        VIR_CGROUP_CONTROLLER_CPUSET)) <= 0)
793 794 795 796 797
        goto error;

    if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0)
        goto error;

798
    for (i = 0; i < priv->nvcpupids; i++) {
J
John Ferlan 已提交
799 800
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               false, &cgroup_temp) < 0 ||
801 802 803 804 805
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

806
        VIR_FREE(nodeset);
807 808 809
        virCgroupFree(&cgroup_temp);
    }

810 811 812
    for (i = 0; i < vm->def->niothreadids; i++) {
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               vm->def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
813
                               false, &cgroup_temp) < 0 ||
814 815 816 817 818
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

819
        VIR_FREE(nodeset);
820 821 822
        virCgroupFree(&cgroup_temp);
    }

J
John Ferlan 已提交
823 824
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0 ||
825 826 827 828 829
        virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
        virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
        virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
        goto cleanup;

830 831
 cleanup:
    VIR_FREE(mem_mask);
832
    VIR_FREE(nodeset);
833
    virBitmapFree(all_nodes);
834
    virCgroupFree(&cgroup_temp);
835 836 837 838 839 840 841
    return;

 error:
    virResetLastError();
    VIR_DEBUG("Couldn't restore cgroups to meaningful state");
    goto cleanup;
}
842 843 844 845 846 847 848 849 850

int
qemuConnectCgroup(virQEMUDriverPtr driver,
                  virDomainObjPtr vm)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = -1;

851
    if (!virQEMUDriverIsPrivileged(driver))
852 853 854 855 856 857 858
        goto done;

    if (!virCgroupAvailable())
        goto done;

    virCgroupFree(&priv->cgroup);

859 860 861
    if (virCgroupNewDetectMachine(vm->def->name,
                                  "qemu",
                                  vm->pid,
862
                                  cfg->cgroupControllers,
863
                                  &priv->cgroup) < 0)
864
        goto cleanup;
865

866 867
    qemuRestoreCgroupState(vm);

868
 done:
869
    ret = 0;
870
 cleanup:
871
    virObjectUnref(cfg);
872
    return ret;
873 874
}

875 876
int
qemuSetupCgroup(virQEMUDriverPtr driver,
877 878 879
                virDomainObjPtr vm,
                size_t nnicindexes,
                int *nicindexes)
880
{
881
    qemuDomainObjPrivatePtr priv = vm->privateData;
882
    int ret = -1;
883

884 885 886 887 888 889
    if (!vm->pid) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Cannot setup cgroups until process is started"));
        return -1;
    }

890
    if (qemuInitCgroup(driver, vm, nnicindexes, nicindexes) < 0)
891
        return -1;
892

893
    if (!priv->cgroup)
894
        return 0;
895

896 897
    if (qemuSetupDevicesCgroup(driver, vm) < 0)
        goto cleanup;
898

899 900
    if (qemuSetupBlkioCgroup(vm) < 0)
        goto cleanup;
901

902 903
    if (qemuSetupMemoryCgroup(vm) < 0)
        goto cleanup;
904

905
    if (qemuSetupCpuCgroup(driver, vm) < 0)
906
        goto cleanup;
907

908
    if (qemuSetupCpusetCgroup(vm) < 0)
909
        goto cleanup;
910

911
    ret = 0;
912
 cleanup:
913
    return ret;
914 915
}

916 917 918 919
int
qemuSetupCgroupVcpuBW(virCgroupPtr cgroup,
                      unsigned long long period,
                      long long quota)
920 921 922 923 924 925 926 927
{
    unsigned long long old_period;

    if (period == 0 && quota == 0)
        return 0;

    if (period) {
        /* get old period, and we can rollback if set quota failed */
928
        if (virCgroupGetCpuCfsPeriod(cgroup, &old_period) < 0)
929 930
            return -1;

931
        if (virCgroupSetCpuCfsPeriod(cgroup, period) < 0)
932 933 934
            return -1;
    }

935 936 937
    if (quota &&
        virCgroupSetCpuCfsQuota(cgroup, quota) < 0)
        goto error;
938 939 940

    return 0;

941
 error:
942
    if (period) {
943 944 945 946 947 948
        virErrorPtr saved = virSaveLastError();
        ignore_value(virCgroupSetCpuCfsPeriod(cgroup, old_period));
        if (saved) {
            virSetError(saved);
            virFreeError(saved);
        }
949 950 951 952 953
    }

    return -1;
}

954

955
int
956 957
qemuSetupCgroupCpusetCpus(virCgroupPtr cgroup,
                          virBitmapPtr cpumask)
958
{
959
    int ret = -1;
960 961
    char *new_cpus = NULL;

962
    if (!(new_cpus = virBitmapFormat(cpumask)))
963 964
        goto cleanup;

965
    if (virCgroupSetCpusetCpus(cgroup, new_cpus) < 0)
966 967
        goto cleanup;

968
    ret = 0;
969
 cleanup:
970
    VIR_FREE(new_cpus);
971
    return ret;
972 973
}

974 975
int
qemuSetupCgroupForVcpu(virDomainObjPtr vm)
976 977 978
{
    virCgroupPtr cgroup_vcpu = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
979
    virDomainDefPtr def = vm->def;
980
    size_t i, j;
981 982
    unsigned long long period = vm->def->cputune.period;
    long long quota = vm->def->cputune.quota;
983
    char *mem_mask = NULL;
984
    virDomainNumatuneMemMode mem_mode;
985

986
    if ((period || quota) &&
987
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
988 989
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
H
Hu Tao 已提交
990 991 992
        return -1;
    }

993 994 995 996 997 998 999 1000 1001
    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1002
    /* We are trying to setup cgroups for CPU pinning, which can also be done
1003
     * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
1004
     */
1005
    if (priv->cgroup == NULL)
1006 1007
        return 0;

1008
    if (priv->nvcpupids == 0 || priv->vcpupids[0] == vm->pid) {
1009
        /* If we don't know VCPU<->PID mapping or all vcpu runs in the same
W
Wen Congyang 已提交
1010
         * thread, we cannot control each vcpu.
1011
         */
1012
        return 0;
1013 1014
    }

1015 1016
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
1017
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
1018 1019 1020 1021
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

1022
    for (i = 0; i < priv->nvcpupids; i++) {
1023
        virCgroupFree(&cgroup_vcpu);
J
John Ferlan 已提交
1024 1025
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               true, &cgroup_vcpu) < 0)
1026 1027 1028
            goto cleanup;

        /* move the thread for vcpu to sub dir */
1029
        if (virCgroupAddTask(cgroup_vcpu, priv->vcpupids[i]) < 0)
1030 1031 1032
            goto cleanup;

        if (period || quota) {
H
Hu Tao 已提交
1033 1034
            if (qemuSetupCgroupVcpuBW(cgroup_vcpu, period, quota) < 0)
                goto cleanup;
1035 1036
        }

1037
        /* Set vcpupin in cgroup if vcpupin xml is provided */
1038
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET)) {
1039
            virBitmapPtr cpumap = NULL;
M
Martin Kletzander 已提交
1040

1041 1042 1043 1044
            if (mem_mask &&
                virCgroupSetCpusetMems(cgroup_vcpu, mem_mask) < 0)
                goto cleanup;

1045 1046 1047 1048 1049
            /* try to use the default cpu maps */
            if (vm->def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
                cpumap = priv->autoCpuset;
            else
                cpumap = vm->def->cpumask;
M
Martin Kletzander 已提交
1050

1051 1052 1053 1054 1055 1056
            /* lookup a more specific pinning info */
            for (j = 0; j < def->cputune.nvcpupin; j++) {
                if (def->cputune.vcpupin[j]->id == i) {
                    cpumap = def->cputune.vcpupin[j]->cpumask;
                    break;
                }
M
Martin Kletzander 已提交
1057
            }
1058 1059 1060 1061

            if (!cpumap)
                continue;

1062
            if (qemuSetupCgroupCpusetCpus(cgroup_vcpu, cpumap) < 0)
1063
                goto cleanup;
M
Martin Kletzander 已提交
1064
        }
1065
    }
1066
    virCgroupFree(&cgroup_vcpu);
1067
    VIR_FREE(mem_mask);
1068 1069 1070

    return 0;

1071
 cleanup:
1072 1073 1074 1075
    if (cgroup_vcpu) {
        virCgroupRemove(cgroup_vcpu);
        virCgroupFree(&cgroup_vcpu);
    }
1076
    VIR_FREE(mem_mask);
1077

1078 1079 1080
    return -1;
}

1081
int
1082
qemuSetupCgroupForEmulator(virDomainObjPtr vm)
1083
{
1084
    virBitmapPtr cpumask = NULL;
1085
    virCgroupPtr cgroup_emulator = NULL;
1086
    virDomainDefPtr def = vm->def;
1087
    qemuDomainObjPrivatePtr priv = vm->privateData;
1088 1089
    unsigned long long period = vm->def->cputune.emulator_period;
    long long quota = vm->def->cputune.emulator_quota;
1090

1091
    if ((period || quota) &&
1092
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
1093 1094 1095 1096 1097
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

1098 1099 1100 1101 1102 1103 1104 1105 1106
    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1107
    if (priv->cgroup == NULL)
1108 1109
        return 0; /* Not supported, so claim success */

J
John Ferlan 已提交
1110 1111
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           true, &cgroup_emulator) < 0)
1112 1113
        goto cleanup;

1114
    if (virCgroupMoveTask(priv->cgroup, cgroup_emulator) < 0)
1115
        goto cleanup;
1116

1117
    if (def->cputune.emulatorpin)
1118
        cpumask = def->cputune.emulatorpin;
1119 1120
    else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
        cpumask = priv->autoCpuset;
1121
    else if (def->cpumask)
1122 1123 1124
        cpumask = def->cpumask;

    if (cpumask) {
1125
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET) &&
1126
            qemuSetupCgroupCpusetCpus(cgroup_emulator, cpumask) < 0)
1127
            goto cleanup;
H
Hu Tao 已提交
1128
    }
1129

1130
    if (period || quota) {
1131 1132 1133 1134
        if (virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
            qemuSetupCgroupVcpuBW(cgroup_emulator, period,
                                  quota) < 0)
            goto cleanup;
1135 1136
    }

1137 1138 1139
    virCgroupFree(&cgroup_emulator);
    return 0;

1140
 cleanup:
1141 1142 1143 1144 1145
    if (cgroup_emulator) {
        virCgroupRemove(cgroup_emulator);
        virCgroupFree(&cgroup_emulator);
    }

1146
    return -1;
1147
}
1148

1149 1150 1151 1152 1153 1154
int
qemuSetupCgroupForIOThreads(virDomainObjPtr vm)
{
    virCgroupPtr cgroup_iothread = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainDefPtr def = vm->def;
1155
    size_t i;
1156 1157
    unsigned long long period = vm->def->cputune.period;
    long long quota = vm->def->cputune.quota;
1158
    char *mem_mask = NULL;
1159
    virDomainNumatuneMemMode mem_mode;
1160

1161 1162 1163
    if (def->niothreadids == 0)
        return 0;

1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185
    if ((period || quota) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

    /* We are trying to setup cgroups for CPU pinning, which can also be done
     * with virProcessSetAffinity, thus the lack of cgroups is not fatal here.
     */
    if (priv->cgroup == NULL)
        return 0;

1186 1187
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
1188
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
1189 1190 1191 1192
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

1193
    for (i = 0; i < def->niothreadids; i++) {
1194 1195 1196
        /* IOThreads are numbered 1..n, although the array is 0..n-1,
         * so we will account for that here
         */
1197 1198
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
1199
                               true, &cgroup_iothread) < 0)
1200 1201 1202
            goto cleanup;

        /* move the thread for iothread to sub dir */
1203 1204
        if (virCgroupAddTask(cgroup_iothread,
                             def->iothreadids[i]->thread_id) < 0)
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214
            goto cleanup;

        if (period || quota) {
            if (qemuSetupCgroupVcpuBW(cgroup_iothread, period, quota) < 0)
                goto cleanup;
        }

        /* Set iothreadpin in cgroup if iothreadpin xml is provided */
        if (virCgroupHasController(priv->cgroup,
                                   VIR_CGROUP_CONTROLLER_CPUSET)) {
1215
            virBitmapPtr cpumask = NULL;
1216

1217 1218 1219 1220
            if (mem_mask &&
                virCgroupSetCpusetMems(cgroup_iothread, mem_mask) < 0)
                goto cleanup;

1221 1222 1223
            if (def->iothreadids[i]->cpumask)
                cpumask = def->iothreadids[i]->cpumask;
            else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO)
1224 1225 1226
                cpumask = priv->autoCpuset;
            else
                cpumask = def->cpumask;
1227

1228
            if (cpumask &&
1229
                qemuSetupCgroupCpusetCpus(cgroup_iothread, cpumask) < 0)
1230
                goto cleanup;
1231 1232 1233 1234
        }

        virCgroupFree(&cgroup_iothread);
    }
1235
    VIR_FREE(mem_mask);
1236 1237 1238 1239 1240 1241 1242 1243

    return 0;

 cleanup:
    if (cgroup_iothread) {
        virCgroupRemove(cgroup_iothread);
        virCgroupFree(&cgroup_iothread);
    }
1244
    VIR_FREE(mem_mask);
1245 1246 1247 1248

    return -1;
}

1249
int
1250 1251
qemuRemoveCgroup(virQEMUDriverPtr driver,
                 virDomainObjPtr vm)
1252
{
1253
    qemuDomainObjPrivatePtr priv = vm->privateData;
1254

1255
    if (priv->cgroup == NULL)
1256 1257
        return 0; /* Not supported, so claim success */

1258 1259
    if (virCgroupTerminateMachine(vm->def->name,
                                  "qemu",
1260
                                  virQEMUDriverIsPrivileged(driver)) < 0) {
1261 1262 1263 1264
        if (!virCgroupNewIgnoreError())
            VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name);
    }

1265
    return virCgroupRemove(priv->cgroup);
1266 1267
}

1268 1269
int
qemuAddToCgroup(virDomainObjPtr vm)
1270
{
1271
    qemuDomainObjPrivatePtr priv = vm->privateData;
1272

1273
    if (priv->cgroup == NULL)
1274 1275
        return 0; /* Not supported, so claim success */

1276
    return 0;
1277
}