qemu_cgroup.c 37.1 KB
Newer Older
1 2 3
/*
 * qemu_cgroup.c: QEMU cgroup management
 *
4
 * Copyright (C) 2006-2015 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include "qemu_cgroup.h"
27
#include "qemu_domain.h"
28
#include "qemu_process.h"
29
#include "vircgroup.h"
30
#include "virlog.h"
31
#include "viralloc.h"
32
#include "virerror.h"
33
#include "domain_audit.h"
34
#include "virscsi.h"
35
#include "virstring.h"
36
#include "virfile.h"
37
#include "virtypedparam.h"
38
#include "virnuma.h"
39
#include "virsystemd.h"
40
#include "virdevmapper.h"
41 42 43

#define VIR_FROM_THIS VIR_FROM_QEMU

44 45
VIR_LOG_INIT("qemu.qemu_cgroup");

46
const char *const defaultDeviceACL[] = {
47 48 49
    "/dev/null", "/dev/full", "/dev/zero",
    "/dev/random", "/dev/urandom",
    "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
50
    "/dev/rtc", "/dev/hpet",
51 52 53 54 55
    NULL,
};
#define DEVICE_PTY_MAJOR 136
#define DEVICE_SND_MAJOR 116

56

57
static int
58 59 60
qemuSetupImagePathCgroup(virDomainObjPtr vm,
                         const char *path,
                         bool readonly)
61
{
62
    qemuDomainObjPrivatePtr priv = vm->privateData;
63
    int perms = VIR_CGROUP_DEVICE_READ;
64 65 66 67
    char **targetPaths = NULL;
    size_t i;
    int rv;
    int ret = -1;
68

69
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
70 71
        return 0;

72
    if (!readonly)
73
        perms |= VIR_CGROUP_DEVICE_WRITE;
74

75
    VIR_DEBUG("Allow path %s, perms: %s",
76
              path, virCgroupGetDevicePermsString(perms));
77

78
    rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, true);
79

80
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path,
81
                             virCgroupGetDevicePermsString(perms),
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
                             rv);
    if (rv < 0)
        goto cleanup;

    if (rv > 0) {
        /* @path is neither character device nor block device. */
        ret = 0;
        goto cleanup;
    }

    if (virDevMapperGetTargets(path, &targetPaths) < 0 &&
        errno != ENOSYS && errno != EBADF) {
        virReportSystemError(errno,
                             _("Unable to get devmapper targets for %s"),
                             path);
        goto cleanup;
    }
99

100 101 102 103 104 105 106 107 108 109 110 111 112
    for (i = 0; targetPaths && targetPaths[i]; i++) {
        rv = virCgroupAllowDevicePath(priv->cgroup, targetPaths[i], perms, false);

        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", targetPaths[i],
                                 virCgroupGetDevicePermsString(perms),
                                 rv);
        if (rv < 0)
            goto cleanup;
    }

    ret = 0;
 cleanup:
    virStringListFree(targetPaths);
113
    return ret;
114 115 116
}


117 118
#define DEVICE_MAPPER_CONTROL_PATH "/dev/mapper/control"

119 120 121 122 123 124 125 126 127 128 129
static int
qemuSetupImageCgroupInternal(virDomainObjPtr vm,
                             virStorageSourcePtr src,
                             bool forceReadonly)
{
    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

130 131 132 133
    if (virStoragePRDefIsManaged(src->pr) &&
        qemuSetupImagePathCgroup(vm, DEVICE_MAPPER_CONTROL_PATH, false) < 0)
        return -1;

134 135 136 137
    return qemuSetupImagePathCgroup(vm, src->path, src->readonly || forceReadonly);
}


138
int
139 140
qemuSetupImageCgroup(virDomainObjPtr vm,
                     virStorageSourcePtr src)
141
{
142
    return qemuSetupImageCgroupInternal(vm, src, false);
143 144 145 146 147 148 149
}


int
qemuTeardownImageCgroup(virDomainObjPtr vm,
                        virStorageSourcePtr src)
{
150
    qemuDomainObjPrivatePtr priv = vm->privateData;
151 152
    int perms = VIR_CGROUP_DEVICE_RWM;
    size_t i;
153 154 155 156 157 158 159 160 161 162 163 164
    int ret;

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    if (!src->path || !virStorageSourceIsLocalStorage(src)) {
        VIR_DEBUG("Not updating cgroups for disk path '%s', type: %s",
                  NULLSTR(src->path), virStorageTypeToString(src->type));
        return 0;
    }

165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
    for (i = 0; i < vm->def->ndisks; i++) {
        virStorageSourcePtr diskSrc = vm->def->disks[i]->src;

        if (src == diskSrc)
            continue;

        if (virStoragePRDefIsManaged(diskSrc->pr))
            break;
    }

    if (i == vm->def->ndisks) {
        VIR_DEBUG("Disabling device mapper control");
        ret = virCgroupDenyDevicePath(priv->cgroup,
                                      DEVICE_MAPPER_CONTROL_PATH, perms, true);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 DEVICE_MAPPER_CONTROL_PATH,
                                 virCgroupGetDevicePermsString(perms), ret);
        if (ret < 0)
            return ret;
    }


187 188 189 190 191
    VIR_DEBUG("Deny path %s", src->path);

    ret = virCgroupDenyDevicePath(priv->cgroup, src->path, perms, true);

    virDomainAuditCgroupPath(vm, priv->cgroup, "deny", src->path,
192
                             virCgroupGetDevicePermsString(perms), ret);
193

194 195 196 197 198 199 200
    /* If you're looking for a counter part to
     * qemuSetupImagePathCgroup you're at the right place.
     * However, we can't just blindly deny all the device mapper
     * targets of src->path because they might still be used by
     * another disk in domain. Just like we are not removing
     * disks from namespace. */

201
    return ret;
202 203 204
}


205 206 207
int
qemuSetupDiskCgroup(virDomainObjPtr vm,
                    virDomainDiskDefPtr disk)
208
{
209
    virStorageSourcePtr next;
210
    bool forceReadonly = false;
211

212
    for (next = disk->src; virStorageSourceIsBacking(next); next = next->backingStore) {
213
        if (qemuSetupImageCgroupInternal(vm, next, forceReadonly) < 0)
214
            return -1;
215 216 217

        /* setup only the top level image for read-write */
        forceReadonly = true;
218
    }
219 220

    return 0;
221 222 223
}


224 225 226
int
qemuTeardownDiskCgroup(virDomainObjPtr vm,
                       virDomainDiskDefPtr disk)
227
{
228
    virStorageSourcePtr next;
229

230
    for (next = disk->src; virStorageSourceIsBacking(next); next = next->backingStore) {
231
        if (qemuTeardownImageCgroup(vm, next) < 0)
232 233
            return -1;
    }
234

235
    return 0;
236 237
}

238

239
static int
240
qemuSetupChrSourceCgroup(virDomainObjPtr vm,
241
                         virDomainChrSourceDefPtr source)
242
{
243
    qemuDomainObjPrivatePtr priv = vm->privateData;
244
    int ret;
245

246 247 248
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

249
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
250 251
        return 0;

252
    VIR_DEBUG("Process path '%s' for device", source->data.file.path);
253

254
    ret = virCgroupAllowDevicePath(priv->cgroup, source->data.file.path,
255
                                   VIR_CGROUP_DEVICE_RW, false);
256
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
257
                             source->data.file.path, "rw", ret);
258

259
    return ret;
260 261
}

262 263 264 265 266 267 268 269

static int
qemuTeardownChrSourceCgroup(virDomainObjPtr vm,
                            virDomainChrSourceDefPtr source)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret;

270 271 272
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

273 274 275 276 277 278 279 280
    if (source->type != VIR_DOMAIN_CHR_TYPE_DEV)
        return 0;

    VIR_DEBUG("Process path '%s' for device", source->data.file.path);

    ret = virCgroupDenyDevicePath(priv->cgroup, source->data.file.path,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
281
                             source->data.file.path, "rw", ret);
282 283 284 285 286

    return ret;
}


287
static int
288 289 290
qemuSetupChardevCgroupCB(virDomainDefPtr def ATTRIBUTE_UNUSED,
                         virDomainChrDefPtr dev,
                         void *opaque)
291
{
292 293
    virDomainObjPtr vm = opaque;

294
    return qemuSetupChrSourceCgroup(vm, dev->source);
295 296 297 298
}


static int
299
qemuSetupTPMCgroup(virDomainObjPtr vm)
300
{
301
    int ret = 0;
302
    virDomainTPMDefPtr dev = vm->def->tpm;
303 304 305

    switch (dev->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
306
        ret = qemuSetupChrSourceCgroup(vm, &dev->data.passthrough.source);
307
        break;
308
    case VIR_DOMAIN_TPM_TYPE_EMULATOR:
309 310 311 312
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

313
    return ret;
314 315
}

316

317
int
318 319 320 321 322 323
qemuSetupInputCgroup(virDomainObjPtr vm,
                     virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

324 325 326
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

327 328 329 330
    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupAllowDevicePath(priv->cgroup, dev->source.evdev,
331
                                       VIR_CGROUP_DEVICE_RW, false);
332
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", dev->source.evdev, "rw", ret);
333 334 335 336 337 338 339
        break;
    }

    return ret;
}


340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
int
qemuTeardownInputCgroup(virDomainObjPtr vm,
                        virDomainInputDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    switch (dev->type) {
    case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
        VIR_DEBUG("Process path '%s' for input device", dev->source.evdev);
        ret = virCgroupDenyDevicePath(priv->cgroup, dev->source.evdev,
                                      VIR_CGROUP_DEVICE_RWM, false);
355
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny", dev->source.evdev, "rwm", ret);
356 357 358 359 360 361 362
        break;
    }

    return ret;
}


363
int
364
qemuSetupHostdevCgroup(virDomainObjPtr vm,
365 366 367
                       virDomainHostdevDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
368 369 370 371
    char **path = NULL;
    int *perms = NULL;
    size_t i, npaths = 0;
    int rv, ret = -1;
372

373 374 375
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

376
    if (qemuDomainGetHostdevPath(NULL, dev, false, &npaths, &path, &perms) < 0)
377
        goto cleanup;
378

379 380 381 382 383
    for (i = 0; i < npaths; i++) {
        VIR_DEBUG("Cgroup allow %s perms=%d", path[i], perms[i]);
        rv = virCgroupAllowDevicePath(priv->cgroup, path[i], perms[i], false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path[i],
                                 virCgroupGetDevicePermsString(perms[i]),
384
                                 rv);
385 386
        if (rv < 0)
            goto cleanup;
387 388
    }

389
    ret = 0;
390

391
 cleanup:
392 393
    for (i = 0; i < npaths; i++)
        VIR_FREE(path[i]);
394
    VIR_FREE(path);
395
    VIR_FREE(perms);
396 397 398 399 400 401 402 403
    return ret;
}

int
qemuTeardownHostdevCgroup(virDomainObjPtr vm,
                       virDomainHostdevDefPtr dev)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
404 405 406
    char **path = NULL;
    size_t i, npaths = 0;
    int rv, ret = -1;
407 408 409 410 411 412 413 414 415

    /* currently this only does something for PCI devices using vfio
     * for device assignment, but it is called for *all* hostdev
     * devices.
     */

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

416 417 418 419 420 421 422 423 424 425 426 427
    if (dev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
        dev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI &&
        dev->source.subsys.u.pci.backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO &&
        qemuDomainGetHostdevPath(vm->def, dev, true,
                                 &npaths, &path, NULL) < 0)
        goto cleanup;

    for (i = 0; i < npaths; i++) {
        VIR_DEBUG("Cgroup deny %s", path[i]);
        rv = virCgroupDenyDevicePath(priv->cgroup, path[i],
                                     VIR_CGROUP_DEVICE_RWM, false);
        virDomainAuditCgroupPath(vm, priv->cgroup,
428
                                 "deny", path[i], "rwm", rv);
429 430
        if (rv < 0)
            goto cleanup;
431 432 433
    }

    ret = 0;
434
 cleanup:
435 436
    for (i = 0; i < npaths; i++)
        VIR_FREE(path[i]);
437 438 439 440
    VIR_FREE(path);
    return ret;
}

441

442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458
int
qemuSetupMemoryDevicesCgroup(virDomainObjPtr vm,
                             virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    VIR_DEBUG("Setting devices Cgroup for NVDIMM device: %s", mem->nvdimmPath);
    rv = virCgroupAllowDevicePath(priv->cgroup, mem->nvdimmPath,
                                  VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
459
                             mem->nvdimmPath, "rw", rv);
460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480

    return rv;
}


int
qemuTeardownMemoryDevicesCgroup(virDomainObjPtr vm,
                                virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

    if (mem->model != VIR_DOMAIN_MEMORY_MODEL_NVDIMM)
        return 0;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

    rv = virCgroupDenyDevicePath(priv->cgroup, mem->nvdimmPath,
                                 VIR_CGROUP_DEVICE_RWM, false);
    virDomainAuditCgroupPath(vm, priv->cgroup,
481
                             "deny", mem->nvdimmPath, "rwm", rv);
482 483 484 485
    return rv;
}


486 487 488 489 490 491 492 493
static int
qemuSetupGraphicsCgroup(virDomainObjPtr vm,
                        virDomainGraphicsDefPtr gfx)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    const char *rendernode = gfx->data.spice.rendernode;
    int ret;

494 495 496
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

497 498 499 500 501 502 503 504
    if (gfx->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE ||
        gfx->data.spice.gl != VIR_TRISTATE_BOOL_YES ||
        !rendernode)
        return 0;

    ret = virCgroupAllowDevicePath(priv->cgroup, rendernode,
                                   VIR_CGROUP_DEVICE_RW, false);
    virDomainAuditCgroupPath(vm, priv->cgroup, "allow", rendernode,
505
                             "rw", ret);
506 507 508 509
    return ret;
}


510 511 512 513
static int
qemuSetupBlkioCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
514
    size_t i;
515 516 517 518 519 520 521 522 523 524 525 526

    if (!virCgroupHasController(priv->cgroup,
                                VIR_CGROUP_CONTROLLER_BLKIO)) {
        if (vm->def->blkio.weight || vm->def->blkio.ndevices) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Block I/O tuning is not available on this host"));
            return -1;
        } else {
            return 0;
        }
    }

527 528 529
    if (vm->def->blkio.weight != 0 &&
        virCgroupSetBlkioWeight(priv->cgroup, vm->def->blkio.weight) < 0)
        return -1;
530 531 532

    if (vm->def->blkio.ndevices) {
        for (i = 0; i < vm->def->blkio.ndevices; i++) {
533
            virBlkioDevicePtr dev = &vm->def->blkio.devices[i];
534 535
            if (dev->weight &&
                (virCgroupSetBlkioDeviceWeight(priv->cgroup, dev->path,
536 537 538
                                               dev->weight) < 0 ||
                 virCgroupGetBlkioDeviceWeight(priv->cgroup, dev->path,
                                               &dev->weight) < 0))
539 540 541 542
                return -1;

            if (dev->riops &&
                (virCgroupSetBlkioDeviceReadIops(priv->cgroup, dev->path,
543 544 545
                                                 dev->riops) < 0 ||
                 virCgroupGetBlkioDeviceReadIops(priv->cgroup, dev->path,
                                                 &dev->riops) < 0))
546 547 548 549
                return -1;

            if (dev->wiops &&
                (virCgroupSetBlkioDeviceWriteIops(priv->cgroup, dev->path,
550 551 552
                                                  dev->wiops) < 0 ||
                 virCgroupGetBlkioDeviceWriteIops(priv->cgroup, dev->path,
                                                  &dev->wiops) < 0))
553 554 555 556
                return -1;

            if (dev->rbps &&
                (virCgroupSetBlkioDeviceReadBps(priv->cgroup, dev->path,
557 558 559
                                                dev->rbps) < 0 ||
                 virCgroupGetBlkioDeviceReadBps(priv->cgroup, dev->path,
                                                &dev->rbps) < 0))
560 561 562 563
                return -1;

            if (dev->wbps &&
                (virCgroupSetBlkioDeviceWriteBps(priv->cgroup, dev->path,
564 565 566
                                                 dev->wbps) < 0 ||
                 virCgroupGetBlkioDeviceWriteBps(priv->cgroup, dev->path,
                                                 &dev->wbps) < 0))
567 568 569 570 571 572 573
                return -1;
        }
    }

    return 0;
}

574

575 576 577 578 579
static int
qemuSetupMemoryCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

E
Eric Blake 已提交
580
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_MEMORY)) {
581 582 583
        if (virMemoryLimitIsSet(vm->def->mem.hard_limit) ||
            virMemoryLimitIsSet(vm->def->mem.soft_limit) ||
            virMemoryLimitIsSet(vm->def->mem.swap_hard_limit)) {
584 585 586
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Memory cgroup is not available on this host"));
            return -1;
O
Osier Yang 已提交
587 588
        } else {
            return 0;
589 590 591
        }
    }

592 593 594
    if (virMemoryLimitIsSet(vm->def->mem.hard_limit))
        if (virCgroupSetMemoryHardLimit(priv->cgroup, vm->def->mem.hard_limit) < 0)
            return -1;
595

596 597 598
    if (virMemoryLimitIsSet(vm->def->mem.soft_limit))
        if (virCgroupSetMemorySoftLimit(priv->cgroup, vm->def->mem.soft_limit) < 0)
            return -1;
599

600 601 602
    if (virMemoryLimitIsSet(vm->def->mem.swap_hard_limit))
        if (virCgroupSetMemSwapHardLimit(priv->cgroup, vm->def->mem.swap_hard_limit) < 0)
            return -1;
603 604 605 606 607

    return 0;
}


608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626
static int
qemuSetupFirmwareCgroup(virDomainObjPtr vm)
{
    if (!vm->def->os.loader)
        return 0;

    if (vm->def->os.loader->path &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->path,
                                 vm->def->os.loader->readonly == VIR_TRISTATE_BOOL_YES) < 0)
        return -1;

    if (vm->def->os.loader->nvram &&
        qemuSetupImagePathCgroup(vm, vm->def->os.loader->nvram, false) < 0)
        return -1;

    return 0;
}


627 628 629 630 631 632 633
int
qemuSetupRNGCgroup(virDomainObjPtr vm,
                   virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

634 635 636
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

637 638 639 640 641 642 643
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Setting Cgroup ACL for RNG device");
        rv = virCgroupAllowDevicePath(priv->cgroup,
                                      rng->source.file,
                                      VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow",
                                 rng->source.file,
644
                                 "rw", rv);
645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


int
qemuTeardownRNGCgroup(virDomainObjPtr vm,
                      virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rv;

661 662 663
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

664 665 666 667 668 669 670
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_RANDOM) {
        VIR_DEBUG("Tearing down Cgroup ACL for RNG device");
        rv = virCgroupDenyDevicePath(priv->cgroup,
                                     rng->source.file,
                                     VIR_CGROUP_DEVICE_RW, false);
        virDomainAuditCgroupPath(vm, priv->cgroup, "deny",
                                 rng->source.file,
671
                                 "rw", rv);
672 673 674 675 676 677 678 679 680
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
            return -1;
    }

    return 0;
}


681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696
int
qemuSetupChardevCgroup(virDomainObjPtr vm,
                       virDomainChrDefPtr dev)
{
    return qemuSetupChrSourceCgroup(vm, dev->source);
}


int
qemuTeardownChardevCgroup(virDomainObjPtr vm,
                          virDomainChrDefPtr dev)
{
    return qemuTeardownChrSourceCgroup(vm, dev->source);
}


697
static int
698
qemuSetupDevicesCgroup(virDomainObjPtr vm)
699 700 701 702
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virQEMUDriverConfigPtr cfg = NULL;
    const char *const *deviceACL = NULL;
703
    int rv = -1;
704
    int ret = -1;
705
    size_t i;
706 707 708 709

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
        return 0;

710 711 712 713 714
    rv = virCgroupDenyAllDevices(priv->cgroup);
    virDomainAuditCgroup(vm, priv->cgroup, "deny", "all", rv == 0);
    if (rv < 0) {
        if (virLastErrorIsSystemErrno(EPERM)) {
            virResetLastError();
715 716 717 718 719 720 721
            VIR_WARN("Group devices ACL is not accessible, disabling whitelisting");
            return 0;
        }

        goto cleanup;
    }

722 723 724
    if (qemuSetupFirmwareCgroup(vm) < 0)
        goto cleanup;

725
    for (i = 0; i < vm->def->ndisks; i++) {
726 727 728 729
        if (qemuSetupDiskCgroup(vm, vm->def->disks[i]) < 0)
            goto cleanup;
    }

730 731
    rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_PTY_MAJOR, -1,
                              VIR_CGROUP_DEVICE_RW);
732
    virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_PTY_MAJOR,
733 734
                              "pty", "rw", rv == 0);
    if (rv < 0)
735 736
        goto cleanup;

737
    cfg = virQEMUDriverGetConfig(priv->driver);
738 739 740 741 742
    deviceACL = cfg->cgroupDeviceACL ?
                (const char *const *)cfg->cgroupDeviceACL :
                defaultDeviceACL;

    if (vm->def->nsounds &&
743
        ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) ||
744 745
         (vm->def->graphics &&
          ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
746
           cfg->vncAllowHostAudio) ||
747
           (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) {
748 749
        rv = virCgroupAllowDevice(priv->cgroup, 'c', DEVICE_SND_MAJOR, -1,
                                  VIR_CGROUP_DEVICE_RW);
750
        virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR,
751 752
                                  "sound", "rw", rv == 0);
        if (rv < 0)
753 754 755
            goto cleanup;
    }

756
    for (i = 0; deviceACL[i] != NULL; i++) {
757
        if (!virFileExists(deviceACL[i])) {
N
Nehal J Wani 已提交
758
            VIR_DEBUG("Ignoring non-existent device %s", deviceACL[i]);
759 760 761
            continue;
        }

762
        rv = virCgroupAllowDevicePath(priv->cgroup, deviceACL[i],
763
                                      VIR_CGROUP_DEVICE_RW, false);
764
        virDomainAuditCgroupPath(vm, priv->cgroup, "allow", deviceACL[i], "rw", rv);
765 766
        if (rv < 0 &&
            !virLastErrorIsSystemErrno(ENOENT))
767 768 769 770 771
            goto cleanup;
    }

    if (virDomainChrDefForeach(vm->def,
                               true,
772
                               qemuSetupChardevCgroupCB,
773 774 775
                               vm) < 0)
        goto cleanup;

776
    if (vm->def->tpm && qemuSetupTPMCgroup(vm) < 0)
777 778 779
        goto cleanup;

    for (i = 0; i < vm->def->nhostdevs; i++) {
780
        if (qemuSetupHostdevCgroup(vm, vm->def->hostdevs[i]) < 0)
781 782 783
            goto cleanup;
    }

784 785 786 787 788
    for (i = 0; i < vm->def->nmems; i++) {
        if (qemuSetupMemoryDevicesCgroup(vm, vm->def->mems[i]) < 0)
            goto cleanup;
    }

789 790 791 792 793
    for (i = 0; i < vm->def->ngraphics; i++) {
        if (qemuSetupGraphicsCgroup(vm, vm->def->graphics[i]) < 0)
            goto cleanup;
    }

794 795 796 797 798
    for (i = 0; i < vm->def->ninputs; i++) {
        if (qemuSetupInputCgroup(vm, vm->def->inputs[i]) < 0)
            goto cleanup;
    }

799
    for (i = 0; i < vm->def->nrngs; i++) {
800 801
        if (qemuSetupRNGCgroup(vm, vm->def->rngs[i]) < 0)
            goto cleanup;
802 803
    }

804
    ret = 0;
805
 cleanup:
806 807 808 809 810
    virObjectUnref(cfg);
    return ret;
}


811
int
812
qemuSetupCpusetMems(virDomainObjPtr vm)
813
{
814
    virCgroupPtr cgroup_temp = NULL;
815
    qemuDomainObjPrivatePtr priv = vm->privateData;
816
    virDomainNumatuneMemMode mode;
817
    char *mem_mask = NULL;
818 819 820 821 822
    int ret = -1;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

823 824
    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 ||
        mode != VIR_DOMAIN_NUMATUNE_MEM_STRICT)
825 826
        return 0;

827
    if (virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
828
                                            priv->autoNodeset,
829
                                            &mem_mask, -1) < 0)
830
        goto cleanup;
831

832
    if (mem_mask)
J
John Ferlan 已提交
833 834
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                               false, &cgroup_temp) < 0 ||
835
            virCgroupSetCpusetMems(cgroup_temp, mem_mask) < 0)
836
            goto cleanup;
837

838 839 840
    ret = 0;
 cleanup:
    VIR_FREE(mem_mask);
841
    virCgroupFree(&cgroup_temp);
842 843 844 845 846
    return ret;
}


static int
847
qemuSetupCpusetCgroup(virDomainObjPtr vm)
848 849 850 851 852 853
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

854 855 856
    if (virCgroupSetCpusetMemoryMigrate(priv->cgroup, true) < 0)
        return -1;

857
    return 0;
858 859 860
}


861
static int
862
qemuSetupCpuCgroup(virDomainObjPtr vm)
863 864
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
865 866 867 868
    virObjectEventPtr event = NULL;
    virTypedParameterPtr eventParams = NULL;
    int eventNparams = 0;
    int eventMaxparams = 0;
869 870

    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
871
       if (vm->def->cputune.sharesSpecified) {
872 873 874 875 876 877 878 879
           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                          _("CPU tuning is not available on this host"));
           return -1;
       } else {
           return 0;
       }
    }

880 881 882 883 884 885 886
    if (vm->def->cputune.sharesSpecified) {
        unsigned long long val;
        if (virCgroupSetCpuShares(priv->cgroup, vm->def->cputune.shares) < 0)
            return -1;

        if (virCgroupGetCpuShares(priv->cgroup, &val) < 0)
            return -1;
887 888 889 890
        if (vm->def->cputune.shares != val) {
            vm->def->cputune.shares = val;
            if (virTypedParamsAddULLong(&eventParams, &eventNparams,
                                        &eventMaxparams,
891
                                        VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES,
892 893 894 895 896 897
                                        val) < 0)
                return -1;

            event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);
        }

898
        qemuDomainEventQueue(priv->driver, event);
899
    }
900 901 902 903 904

    return 0;
}


905
static int
906
qemuInitCgroup(virDomainObjPtr vm,
907 908
               size_t nnicindexes,
               int *nicindexes)
909
{
910
    int ret = -1;
911
    qemuDomainObjPrivatePtr priv = vm->privateData;
912
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
913

914
    if (!virQEMUDriverIsPrivileged(priv->driver))
915 916
        goto done;

917 918 919
    if (!virCgroupAvailable())
        goto done;

920 921
    virCgroupFree(&priv->cgroup);

922
    if (!vm->def->resource) {
923 924
        virDomainResourceDefPtr res;

925
        if (VIR_ALLOC(res) < 0)
926
            goto cleanup;
927

928
        if (VIR_STRDUP(res->partition, "/machine") < 0) {
929 930 931 932 933
            VIR_FREE(res);
            goto cleanup;
        }

        vm->def->resource = res;
934 935
    }

936 937 938 939 940 941
    if (vm->def->resource->partition[0] != '/') {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Resource partition '%s' must start with '/'"),
                       vm->def->resource->partition);
        goto cleanup;
    }
942

943
    if (virCgroupNewMachine(priv->machineName,
944 945 946 947 948
                            "qemu",
                            vm->def->uuid,
                            NULL,
                            vm->pid,
                            false,
949
                            nnicindexes, nicindexes,
950 951 952
                            vm->def->resource->partition,
                            cfg->cgroupControllers,
                            &priv->cgroup) < 0) {
953 954
        if (virCgroupNewIgnoreError())
            goto done;
955

956 957
        goto cleanup;
    }
958

959
 done:
960
    ret = 0;
961
 cleanup:
962 963 964
    virObjectUnref(cfg);
    return ret;
}
965

966 967 968
static void
qemuRestoreCgroupState(virDomainObjPtr vm)
{
969
    char *mem_mask = NULL;
970
    char *nodeset = NULL;
971 972
    int empty = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
973
    size_t i = 0;
974
    virBitmapPtr all_nodes;
975
    virCgroupPtr cgroup_temp = NULL;
976

977 978 979 980
    if (!virNumaIsAvailable() ||
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return;

981
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
982 983 984 985 986 987
        goto error;

    if (!(mem_mask = virBitmapFormat(all_nodes)))
        goto error;

    if ((empty = virCgroupHasEmptyTasks(priv->cgroup,
988
                                        VIR_CGROUP_CONTROLLER_CPUSET)) <= 0)
989 990 991 992 993
        goto error;

    if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0)
        goto error;

994
    for (i = 0; i < virDomainDefGetVcpusMax(vm->def); i++) {
995
        virDomainVcpuDefPtr vcpu = virDomainDefGetVcpu(vm->def, i);
996 997 998 999

        if (!vcpu->online)
            continue;

J
John Ferlan 已提交
1000 1001
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i,
                               false, &cgroup_temp) < 0 ||
1002 1003 1004 1005 1006
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1007
        VIR_FREE(nodeset);
1008 1009 1010
        virCgroupFree(&cgroup_temp);
    }

1011 1012 1013
    for (i = 0; i < vm->def->niothreadids; i++) {
        if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_IOTHREAD,
                               vm->def->iothreadids[i]->iothread_id,
J
John Ferlan 已提交
1014
                               false, &cgroup_temp) < 0 ||
1015 1016 1017 1018 1019
            virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
            virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
            virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
            goto cleanup;

1020
        VIR_FREE(nodeset);
1021 1022 1023
        virCgroupFree(&cgroup_temp);
    }

J
John Ferlan 已提交
1024 1025
    if (virCgroupNewThread(priv->cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &cgroup_temp) < 0 ||
1026 1027 1028 1029 1030
        virCgroupSetCpusetMemoryMigrate(cgroup_temp, true) < 0 ||
        virCgroupGetCpusetMems(cgroup_temp, &nodeset) < 0 ||
        virCgroupSetCpusetMems(cgroup_temp, nodeset) < 0)
        goto cleanup;

1031 1032
 cleanup:
    VIR_FREE(mem_mask);
1033
    VIR_FREE(nodeset);
1034
    virBitmapFree(all_nodes);
1035
    virCgroupFree(&cgroup_temp);
1036 1037 1038 1039 1040 1041 1042
    return;

 error:
    virResetLastError();
    VIR_DEBUG("Couldn't restore cgroups to meaningful state");
    goto cleanup;
}
1043 1044

int
1045
qemuConnectCgroup(virDomainObjPtr vm)
1046 1047
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
1048
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver);
1049 1050
    int ret = -1;

1051
    if (!virQEMUDriverIsPrivileged(priv->driver))
1052 1053 1054 1055 1056 1057 1058
        goto done;

    if (!virCgroupAvailable())
        goto done;

    virCgroupFree(&priv->cgroup);

1059 1060 1061
    if (virCgroupNewDetectMachine(vm->def->name,
                                  "qemu",
                                  vm->pid,
1062
                                  cfg->cgroupControllers,
1063
                                  priv->machineName,
1064
                                  &priv->cgroup) < 0)
1065
        goto cleanup;
1066

1067 1068
    qemuRestoreCgroupState(vm);

1069
 done:
1070
    ret = 0;
1071
 cleanup:
1072
    virObjectUnref(cfg);
1073
    return ret;
1074 1075
}

1076
int
1077
qemuSetupCgroup(virDomainObjPtr vm,
1078 1079
                size_t nnicindexes,
                int *nicindexes)
1080
{
1081
    qemuDomainObjPrivatePtr priv = vm->privateData;
1082
    int ret = -1;
1083

1084 1085 1086 1087 1088 1089
    if (!vm->pid) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Cannot setup cgroups until process is started"));
        return -1;
    }

1090
    if (qemuInitCgroup(vm, nnicindexes, nicindexes) < 0)
1091
        return -1;
1092

1093
    if (!priv->cgroup)
1094
        return 0;
1095

1096
    if (qemuSetupDevicesCgroup(vm) < 0)
1097
        goto cleanup;
1098

1099 1100
    if (qemuSetupBlkioCgroup(vm) < 0)
        goto cleanup;
1101

1102 1103
    if (qemuSetupMemoryCgroup(vm) < 0)
        goto cleanup;
1104

1105
    if (qemuSetupCpuCgroup(vm) < 0)
1106
        goto cleanup;
1107

1108
    if (qemuSetupCpusetCgroup(vm) < 0)
1109
        goto cleanup;
1110

1111
    ret = 0;
1112
 cleanup:
1113
    return ret;
1114 1115
}

1116 1117 1118 1119
int
qemuSetupCgroupVcpuBW(virCgroupPtr cgroup,
                      unsigned long long period,
                      long long quota)
1120 1121 1122 1123 1124 1125 1126 1127
{
    unsigned long long old_period;

    if (period == 0 && quota == 0)
        return 0;

    if (period) {
        /* get old period, and we can rollback if set quota failed */
1128
        if (virCgroupGetCpuCfsPeriod(cgroup, &old_period) < 0)
1129 1130
            return -1;

1131
        if (virCgroupSetCpuCfsPeriod(cgroup, period) < 0)
1132 1133 1134
            return -1;
    }

1135 1136 1137
    if (quota &&
        virCgroupSetCpuCfsQuota(cgroup, quota) < 0)
        goto error;
1138 1139 1140

    return 0;

1141
 error:
1142
    if (period) {
1143 1144 1145 1146 1147 1148
        virErrorPtr saved = virSaveLastError();
        ignore_value(virCgroupSetCpuCfsPeriod(cgroup, old_period));
        if (saved) {
            virSetError(saved);
            virFreeError(saved);
        }
1149 1150 1151 1152 1153
    }

    return -1;
}

1154

1155
int
1156 1157
qemuSetupCgroupCpusetCpus(virCgroupPtr cgroup,
                          virBitmapPtr cpumask)
1158
{
1159
    int ret = -1;
1160 1161
    char *new_cpus = NULL;

1162
    if (!(new_cpus = virBitmapFormat(cpumask)))
1163 1164
        goto cleanup;

1165
    if (virCgroupSetCpusetCpus(cgroup, new_cpus) < 0)
1166 1167
        goto cleanup;

1168
    ret = 0;
1169
 cleanup:
1170
    VIR_FREE(new_cpus);
1171
    return ret;
1172 1173
}

1174

1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223
int
qemuSetupGlobalCpuCgroup(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    unsigned long long period = vm->def->cputune.global_period;
    long long quota = vm->def->cputune.global_quota;
    char *mem_mask = NULL;
    virDomainNumatuneMemMode mem_mode;

    if ((period || quota) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("cgroup cpu is required for scheduler tuning"));
        return -1;
    }

    /*
     * If CPU cgroup controller is not initialized here, then we need
     * neither period nor quota settings.  And if CPUSET controller is
     * not initialized either, then there's nothing to do anyway.
     */
    if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU) &&
        !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;


    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 &&
        mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT &&
        virDomainNumatuneMaybeFormatNodeset(vm->def->numa,
                                            priv->autoNodeset,
                                            &mem_mask, -1) < 0)
        goto cleanup;

    if (period || quota) {
        if (qemuSetupCgroupVcpuBW(priv->cgroup, period, quota) < 0)
            goto cleanup;
    }

    VIR_FREE(mem_mask);

    return 0;

 cleanup:
    VIR_FREE(mem_mask);

    return -1;
}


1224
int
1225
qemuRemoveCgroup(virDomainObjPtr vm)
1226
{
1227
    qemuDomainObjPrivatePtr priv = vm->privateData;
1228

1229
    if (priv->cgroup == NULL)
1230 1231
        return 0; /* Not supported, so claim success */

1232
    if (virCgroupTerminateMachine(priv->machineName) < 0) {
1233 1234 1235 1236
        if (!virCgroupNewIgnoreError())
            VIR_DEBUG("Failed to terminate cgroup for %s", vm->def->name);
    }

1237
    return virCgroupRemove(priv->cgroup);
1238
}
1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260


static void
qemuCgroupEmulatorAllNodesDataFree(qemuCgroupEmulatorAllNodesDataPtr data)
{
    if (!data)
        return;

    virCgroupFree(&data->emulatorCgroup);
    VIR_FREE(data->emulatorMemMask);
    VIR_FREE(data);
}


/**
 * qemuCgroupEmulatorAllNodesAllow:
 * @cgroup: domain cgroup pointer
 * @retData: filled with structure used to roll back the operation
 *
 * Allows all NUMA nodes for the qemu emulator thread temporarily. This is
 * necessary when hotplugging cpus since it requires memory allocated in the
 * DMA region. Afterwards the operation can be reverted by
1261
 * qemuCgroupEmulatorAllNodesRestore.
1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
 *
 * Returns 0 on success -1 on error
 */
int
qemuCgroupEmulatorAllNodesAllow(virCgroupPtr cgroup,
                                qemuCgroupEmulatorAllNodesDataPtr *retData)
{
    qemuCgroupEmulatorAllNodesDataPtr data = NULL;
    char *all_nodes_str = NULL;
    virBitmapPtr all_nodes = NULL;
    int ret = -1;

    if (!virNumaIsAvailable() ||
        !virCgroupHasController(cgroup, VIR_CGROUP_CONTROLLER_CPUSET))
        return 0;

1278
    if (!(all_nodes = virNumaGetHostMemoryNodeset()))
1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307
        goto cleanup;

    if (!(all_nodes_str = virBitmapFormat(all_nodes)))
        goto cleanup;

    if (VIR_ALLOC(data) < 0)
        goto cleanup;

    if (virCgroupNewThread(cgroup, VIR_CGROUP_THREAD_EMULATOR, 0,
                           false, &data->emulatorCgroup) < 0)
        goto cleanup;

    if (virCgroupGetCpusetMems(data->emulatorCgroup, &data->emulatorMemMask) < 0 ||
        virCgroupSetCpusetMems(data->emulatorCgroup, all_nodes_str) < 0)
        goto cleanup;

    VIR_STEAL_PTR(*retData, data);
    ret = 0;

 cleanup:
    VIR_FREE(all_nodes_str);
    virBitmapFree(all_nodes);
    qemuCgroupEmulatorAllNodesDataFree(data);

    return ret;
}


/**
1308
 * qemuCgroupEmulatorAllNodesRestore:
1309 1310 1311 1312 1313 1314
 * @data: data structure created by qemuCgroupEmulatorAllNodesAllow
 *
 * Rolls back the setting done by qemuCgroupEmulatorAllNodesAllow and frees the
 * associated data.
 */
void
1315
qemuCgroupEmulatorAllNodesRestore(qemuCgroupEmulatorAllNodesDataPtr data)
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328
{
    virErrorPtr err;

    if (!data)
        return;

    err = virSaveLastError();
    virCgroupSetCpusetMems(data->emulatorCgroup, data->emulatorMemMask);
    virSetError(err);
    virFreeError(err);

    qemuCgroupEmulatorAllNodesDataFree(data);
}