1. 26 8月, 2020 1 次提交
    • M
      ibmvnic fix NULL tx_pools and rx_tools issue at do_reset · 9f134573
      Mingming Cao 提交于
      At the time of do_rest, ibmvnic tries to re-initalize the tx_pools
      and rx_pools to avoid re-allocating the long term buffer. However
      there is a window inside do_reset that the tx_pools and
      rx_pools were freed before re-initialized making it possible to deference
      null pointers.
      
      This patch fix this issue by always check the tx_pool
      and rx_pool are not NULL after ibmvnic_login. If so, re-allocating
      the pools. This will avoid getting into calling reset_tx/rx_pools with
      NULL adapter tx_pools/rx_pools pointer. Also add null pointer check in
      reset_tx_pools and reset_rx_pools to safe handle NULL pointer case.
      Signed-off-by: NMingming Cao <mmc@linux.vnet.ibm.com>
      Signed-off-by: NDany Madden <drt@linux.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9f134573
  2. 25 8月, 2020 12 次提交
  3. 24 8月, 2020 2 次提交
  4. 22 8月, 2020 1 次提交
    • T
      net: dsa: b53: check for timeout · 774d977a
      Tom Rix 提交于
      clang static analysis reports this problem
      
      b53_common.c:1583:13: warning: The left expression of the compound
        assignment is an uninitialized value. The computed value will
        also be garbage
              ent.port &= ~BIT(port);
              ~~~~~~~~ ^
      
      ent is set by a successful call to b53_arl_read().  Unsuccessful
      calls are caught by an switch statement handling specific returns.
      b32_arl_read() calls b53_arl_op_wait() which fails with the
      unhandled -ETIMEDOUT.
      
      So add -ETIMEDOUT to the switch statement.  Because
      b53_arl_op_wait() already prints out a message, do not add another
      one.
      
      Fixes: 1da6df85 ("net: dsa: b53: Implement ARL add/del/dump operations")
      Signed-off-by: NTom Rix <trix@redhat.com>
      Acked-by: NFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      774d977a
  5. 21 8月, 2020 6 次提交
  6. 20 8月, 2020 18 次提交