dir.c 29.3 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-only
M
Miklos Szeredi 已提交
2 3 4 5 6 7 8 9 10 11
/*
 *
 * Copyright (C) 2011 Novell Inc.
 */

#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/cred.h>
12
#include <linux/module.h>
13 14
#include <linux/posix_acl.h>
#include <linux/posix_acl_xattr.h>
15
#include <linux/atomic.h>
M
Miklos Szeredi 已提交
16
#include <linux/ratelimit.h>
M
Miklos Szeredi 已提交
17 18
#include "overlayfs.h"

19 20
static unsigned short ovl_redirect_max = 256;
module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
21
MODULE_PARM_DESC(redirect_max,
22 23
		 "Maximum length of absolute redirect xattr value");

24 25
static int ovl_set_redirect(struct dentry *dentry, bool samedir);

26
int ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
M
Miklos Szeredi 已提交
27 28 29 30
{
	int err;

	dget(wdentry);
31
	if (d_is_dir(wdentry))
M
Miklos Szeredi 已提交
32 33 34 35 36 37
		err = ovl_do_rmdir(wdir, wdentry);
	else
		err = ovl_do_unlink(wdir, wdentry);
	dput(wdentry);

	if (err) {
L
lijiazi 已提交
38
		pr_err("cleanup of '%pd2' failed (%i)\n",
M
Miklos Szeredi 已提交
39 40
		       wdentry, err);
	}
41 42

	return err;
M
Miklos Szeredi 已提交
43 44
}

45
struct dentry *ovl_lookup_temp(struct dentry *workdir)
M
Miklos Szeredi 已提交
46 47 48
{
	struct dentry *temp;
	char name[20];
49
	static atomic_t temp_id = ATOMIC_INIT(0);
M
Miklos Szeredi 已提交
50

51 52
	/* counter is allowed to wrap, since temp dentries are ephemeral */
	snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
M
Miklos Szeredi 已提交
53 54 55

	temp = lookup_one_len(name, workdir, strlen(name));
	if (!IS_ERR(temp) && temp->d_inode) {
L
lijiazi 已提交
56
		pr_err("workdir/%s already exists\n", name);
M
Miklos Szeredi 已提交
57 58 59 60 61 62 63 64
		dput(temp);
		temp = ERR_PTR(-EIO);
	}

	return temp;
}

/* caller holds i_mutex on workdir */
C
Chengguang Xu 已提交
65
static struct dentry *ovl_whiteout(struct ovl_fs *ofs)
M
Miklos Szeredi 已提交
66 67 68
{
	int err;
	struct dentry *whiteout;
C
Chengguang Xu 已提交
69
	struct dentry *workdir = ofs->workdir;
M
Miklos Szeredi 已提交
70 71
	struct inode *wdir = workdir->d_inode;

C
Chengguang Xu 已提交
72 73 74 75
	if (!ofs->whiteout) {
		whiteout = ovl_lookup_temp(workdir);
		if (IS_ERR(whiteout))
			goto out;
M
Miklos Szeredi 已提交
76

C
Chengguang Xu 已提交
77 78 79 80 81 82 83
		err = ovl_do_whiteout(wdir, whiteout);
		if (err) {
			dput(whiteout);
			whiteout = ERR_PTR(err);
			goto out;
		}
		ofs->whiteout = whiteout;
M
Miklos Szeredi 已提交
84 85
	}

C
Chengguang Xu 已提交
86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
	if (ofs->share_whiteout) {
		whiteout = ovl_lookup_temp(workdir);
		if (IS_ERR(whiteout))
			goto out;

		err = ovl_do_link(ofs->whiteout, wdir, whiteout);
		if (!err)
			goto out;

		if (err != -EMLINK) {
			pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%i)\n",
				ofs->whiteout->d_inode->i_nlink, err);
			ofs->share_whiteout = false;
		}
		dput(whiteout);
	}
	whiteout = ofs->whiteout;
	ofs->whiteout = NULL;
out:
M
Miklos Szeredi 已提交
105 106 107
	return whiteout;
}

108
/* Caller must hold i_mutex on both workdir and dir */
C
Chengguang Xu 已提交
109
int ovl_cleanup_and_whiteout(struct ovl_fs *ofs, struct inode *dir,
110 111
			     struct dentry *dentry)
{
C
Chengguang Xu 已提交
112
	struct inode *wdir = ofs->workdir->d_inode;
113 114 115 116
	struct dentry *whiteout;
	int err;
	int flags = 0;

C
Chengguang Xu 已提交
117
	whiteout = ovl_whiteout(ofs);
118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
	err = PTR_ERR(whiteout);
	if (IS_ERR(whiteout))
		return err;

	if (d_is_dir(dentry))
		flags = RENAME_EXCHANGE;

	err = ovl_do_rename(wdir, whiteout, dir, dentry, flags);
	if (err)
		goto kill_whiteout;
	if (flags)
		ovl_cleanup(wdir, dentry);

out:
	dput(whiteout);
	return err;

kill_whiteout:
	ovl_cleanup(wdir, whiteout);
	goto out;
}

140
int ovl_mkdir_real(struct inode *dir, struct dentry **newdentry, umode_t mode)
141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
{
	int err;
	struct dentry *d, *dentry = *newdentry;

	err = ovl_do_mkdir(dir, dentry, mode);
	if (err)
		return err;

	if (likely(!d_unhashed(dentry)))
		return 0;

	/*
	 * vfs_mkdir() may succeed and leave the dentry passed
	 * to it unhashed and negative. If that happens, try to
	 * lookup a new hashed and positive dentry.
	 */
	d = lookup_one_len(dentry->d_name.name, dentry->d_parent,
			   dentry->d_name.len);
	if (IS_ERR(d)) {
L
lijiazi 已提交
160
		pr_warn("failed lookup after mkdir (%pd2, err=%i).\n",
161 162 163 164 165 166 167 168 169
			dentry, err);
		return PTR_ERR(d);
	}
	dput(dentry);
	*newdentry = d;

	return 0;
}

170 171
struct dentry *ovl_create_real(struct inode *dir, struct dentry *newdentry,
			       struct ovl_cattr *attr)
M
Miklos Szeredi 已提交
172 173 174
{
	int err;

175 176 177 178
	if (IS_ERR(newdentry))
		return newdentry;

	err = -ESTALE;
M
Miklos Szeredi 已提交
179
	if (newdentry->d_inode)
180
		goto out;
M
Miklos Szeredi 已提交
181

A
Amir Goldstein 已提交
182 183
	if (attr->hardlink) {
		err = ovl_do_link(attr->hardlink, dir, newdentry);
M
Miklos Szeredi 已提交
184
	} else {
A
Al Viro 已提交
185
		switch (attr->mode & S_IFMT) {
M
Miklos Szeredi 已提交
186
		case S_IFREG:
187
			err = ovl_do_create(dir, newdentry, attr->mode);
M
Miklos Szeredi 已提交
188 189 190
			break;

		case S_IFDIR:
191 192
			/* mkdir is special... */
			err =  ovl_mkdir_real(dir, &newdentry, attr->mode);
M
Miklos Szeredi 已提交
193 194 195 196 197 198
			break;

		case S_IFCHR:
		case S_IFBLK:
		case S_IFIFO:
		case S_IFSOCK:
199 200
			err = ovl_do_mknod(dir, newdentry, attr->mode,
					   attr->rdev);
M
Miklos Szeredi 已提交
201 202 203
			break;

		case S_IFLNK:
204
			err = ovl_do_symlink(dir, newdentry, attr->link);
M
Miklos Szeredi 已提交
205 206 207 208 209 210 211 212 213 214 215
			break;

		default:
			err = -EPERM;
		}
	}
	if (!err && WARN_ON(!newdentry->d_inode)) {
		/*
		 * Not quite sure if non-instantiated dentry is legal or not.
		 * VFS doesn't seem to care so check and warn here.
		 */
216
		err = -EIO;
M
Miklos Szeredi 已提交
217
	}
218 219 220 221 222 223
out:
	if (err) {
		dput(newdentry);
		return ERR_PTR(err);
	}
	return newdentry;
M
Miklos Szeredi 已提交
224 225
}

226 227 228 229 230 231
struct dentry *ovl_create_temp(struct dentry *workdir, struct ovl_cattr *attr)
{
	return ovl_create_real(d_inode(workdir), ovl_lookup_temp(workdir),
			       attr);
}

232 233
static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
			       int xerr)
M
Miklos Szeredi 已提交
234
{
M
Miklos Szeredi 已提交
235 236
	int err;

237
	err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
M
Miklos Szeredi 已提交
238 239 240 241
	if (!err)
		ovl_dentry_set_opaque(dentry);

	return err;
M
Miklos Szeredi 已提交
242 243
}

244 245 246 247 248 249 250 251 252 253
static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
{
	/*
	 * Fail with -EIO when trying to create opaque dir and upper doesn't
	 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
	 * return a specific error for noxattr case.
	 */
	return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
}

254 255 256 257 258 259 260
/*
 * Common operations required to be done after creation of file on upper.
 * If @hardlink is false, then @inode is a pre-allocated inode, we may or
 * may not use to instantiate the new dentry.
 */
static int ovl_instantiate(struct dentry *dentry, struct inode *inode,
			   struct dentry *newdentry, bool hardlink)
261
{
262 263 264 265 266
	struct ovl_inode_params oip = {
		.upperdentry = newdentry,
		.newinode = inode,
	};

M
Miklos Szeredi 已提交
267
	ovl_dir_modified(dentry->d_parent, false);
268
	ovl_dentry_set_upper_alias(dentry);
269 270 271
	ovl_dentry_update_reval(dentry, newdentry,
			DCACHE_OP_REVALIDATE | DCACHE_OP_WEAK_REVALIDATE);

M
Miklos Szeredi 已提交
272
	if (!hardlink) {
273 274 275 276 277 278 279 280 281 282 283 284 285
		/*
		 * ovl_obtain_alias() can be called after ovl_create_real()
		 * and before we get here, so we may get an inode from cache
		 * with the same real upperdentry that is not the inode we
		 * pre-allocated.  In this case we will use the cached inode
		 * to instantiate the new dentry.
		 *
		 * XXX: if we ever use ovl_obtain_alias() to decode directory
		 * file handles, need to use ovl_get_inode_locked() and
		 * d_instantiate_new() here to prevent from creating two
		 * hashed directory inode aliases.
		 */
		inode = ovl_get_inode(dentry->d_sb, &oip);
286
		if (IS_ERR(inode))
287
			return PTR_ERR(inode);
288 289
		if (inode == oip.newinode)
			ovl_set_flag(OVL_UPPERDATA, inode);
M
Miklos Szeredi 已提交
290
	} else {
291 292
		WARN_ON(ovl_inode_real(inode) != d_inode(newdentry));
		dput(newdentry);
M
Miklos Szeredi 已提交
293 294
		inc_nlink(inode);
	}
295

296
	d_instantiate(dentry, inode);
297
	if (inode != oip.newinode) {
L
lijiazi 已提交
298
		pr_warn_ratelimited("newly created inode found in cache (%pd2)\n",
299 300 301
				    dentry);
	}

302 303 304
	/* Force lookup of new upper hardlink to find its lower */
	if (hardlink)
		d_drop(dentry);
305 306

	return 0;
307 308
}

309 310 311 312 313
static bool ovl_type_merge(struct dentry *dentry)
{
	return OVL_TYPE_MERGE(ovl_path_type(dentry));
}

314 315 316 317 318
static bool ovl_type_origin(struct dentry *dentry)
{
	return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
}

M
Miklos Szeredi 已提交
319
static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
320
			    struct ovl_cattr *attr)
M
Miklos Szeredi 已提交
321 322 323 324 325 326
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *newdentry;
	int err;

A
Amir Goldstein 已提交
327
	if (!attr->hardlink && !IS_POSIXACL(udir))
A
Al Viro 已提交
328
		attr->mode &= ~current_umask();
329

A
Al Viro 已提交
330
	inode_lock_nested(udir, I_MUTEX_PARENT);
331 332 333 334 335
	newdentry = ovl_create_real(udir,
				    lookup_one_len(dentry->d_name.name,
						   upperdir,
						   dentry->d_name.len),
				    attr);
M
Miklos Szeredi 已提交
336 337 338 339
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;

340
	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
341 342 343 344
		/* Setting opaque here is just an optimization, allow to fail */
		ovl_set_opaque(dentry, newdentry);
	}

345 346 347
	err = ovl_instantiate(dentry, inode, newdentry, !!attr->hardlink);
	if (err)
		goto out_cleanup;
M
Miklos Szeredi 已提交
348
out_unlock:
A
Al Viro 已提交
349
	inode_unlock(udir);
M
Miklos Szeredi 已提交
350
	return err;
351 352 353 354 355

out_cleanup:
	ovl_cleanup(udir, newdentry);
	dput(newdentry);
	goto out_unlock;
M
Miklos Szeredi 已提交
356 357 358 359 360 361 362 363 364 365 366 367 368 369 370
}

static struct dentry *ovl_clear_empty(struct dentry *dentry,
				      struct list_head *list)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct path upperpath;
	struct dentry *upper;
	struct dentry *opaquedir;
	struct kstat stat;
	int err;

371 372 373
	if (WARN_ON(!workdir))
		return ERR_PTR(-EROFS);

M
Miklos Szeredi 已提交
374 375 376 377 378
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	ovl_path_upper(dentry, &upperpath);
379 380
	err = vfs_getattr(&upperpath, &stat,
			  STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
M
Miklos Szeredi 已提交
381 382 383 384 385 386 387 388 389 390
	if (err)
		goto out_unlock;

	err = -ESTALE;
	if (!S_ISDIR(stat.mode))
		goto out_unlock;
	upper = upperpath.dentry;
	if (upper->d_parent->d_inode != udir)
		goto out_unlock;

391
	opaquedir = ovl_create_temp(workdir, OVL_CATTR(stat.mode));
M
Miklos Szeredi 已提交
392 393 394 395
	err = PTR_ERR(opaquedir);
	if (IS_ERR(opaquedir))
		goto out_unlock;

396
	err = ovl_copy_xattr(dentry->d_sb, upper, opaquedir);
M
Miklos Szeredi 已提交
397 398 399
	if (err)
		goto out_cleanup;

M
Miklos Szeredi 已提交
400
	err = ovl_set_opaque(dentry, opaquedir);
M
Miklos Szeredi 已提交
401 402 403
	if (err)
		goto out_cleanup;

A
Al Viro 已提交
404
	inode_lock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
405
	err = ovl_set_attr(opaquedir, &stat);
A
Al Viro 已提交
406
	inode_unlock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431
	if (err)
		goto out_cleanup;

	err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
	if (err)
		goto out_cleanup;

	ovl_cleanup_whiteouts(upper, list);
	ovl_cleanup(wdir, upper);
	unlock_rename(workdir, upperdir);

	/* dentry's upper doesn't match now, get rid of it */
	d_drop(dentry);

	return opaquedir;

out_cleanup:
	ovl_cleanup(wdir, opaquedir);
	dput(opaquedir);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
	return ERR_PTR(err);
}

432 433 434 435 436 437 438 439 440 441
static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
			     const struct posix_acl *acl)
{
	void *buffer;
	size_t size;
	int err;

	if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
		return 0;

442
	size = posix_acl_xattr_size(acl->a_count);
443 444 445 446
	buffer = kmalloc(size, GFP_KERNEL);
	if (!buffer)
		return -ENOMEM;

447
	err = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
448 449 450 451 452 453 454 455 456
	if (err < 0)
		goto out_free;

	err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
out_free:
	kfree(buffer);
	return err;
}

M
Miklos Szeredi 已提交
457
static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
458
				    struct ovl_cattr *cattr)
M
Miklos Szeredi 已提交
459 460 461 462 463 464 465 466
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *upper;
	struct dentry *newdentry;
	int err;
467
	struct posix_acl *acl, *default_acl;
A
Amir Goldstein 已提交
468
	bool hardlink = !!cattr->hardlink;
M
Miklos Szeredi 已提交
469

470 471 472
	if (WARN_ON(!workdir))
		return -EROFS;

473 474
	if (!hardlink) {
		err = posix_acl_create(dentry->d_parent->d_inode,
A
Al Viro 已提交
475
				       &cattr->mode, &default_acl, &acl);
476 477 478 479
		if (err)
			return err;
	}

M
Miklos Szeredi 已提交
480 481 482 483 484 485 486 487
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
488
		goto out_unlock;
M
Miklos Szeredi 已提交
489

490 491 492 493
	err = -ESTALE;
	if (d_is_negative(upper) || !IS_WHITEOUT(d_inode(upper)))
		goto out_dput;

494
	newdentry = ovl_create_temp(workdir, cattr);
495 496 497
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput;
M
Miklos Szeredi 已提交
498

M
Miklos Szeredi 已提交
499 500 501
	/*
	 * mode could have been mutilated due to umask (e.g. sgid directory)
	 */
M
Miklos Szeredi 已提交
502
	if (!hardlink &&
A
Al Viro 已提交
503 504
	    !S_ISLNK(cattr->mode) &&
	    newdentry->d_inode->i_mode != cattr->mode) {
M
Miklos Szeredi 已提交
505 506
		struct iattr attr = {
			.ia_valid = ATTR_MODE,
A
Al Viro 已提交
507
			.ia_mode = cattr->mode,
M
Miklos Szeredi 已提交
508 509 510 511 512 513 514
		};
		inode_lock(newdentry->d_inode);
		err = notify_change(newdentry, &attr, NULL);
		inode_unlock(newdentry->d_inode);
		if (err)
			goto out_cleanup;
	}
515 516 517 518 519 520 521 522 523 524 525
	if (!hardlink) {
		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
					acl);
		if (err)
			goto out_cleanup;

		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
					default_acl);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
526

A
Al Viro 已提交
527
	if (!hardlink && S_ISDIR(cattr->mode)) {
M
Miklos Szeredi 已提交
528
		err = ovl_set_opaque(dentry, newdentry);
M
Miklos Szeredi 已提交
529 530 531 532 533 534 535 536 537 538 539 540 541 542
		if (err)
			goto out_cleanup;

		err = ovl_do_rename(wdir, newdentry, udir, upper,
				    RENAME_EXCHANGE);
		if (err)
			goto out_cleanup;

		ovl_cleanup(wdir, upper);
	} else {
		err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
		if (err)
			goto out_cleanup;
	}
543
	err = ovl_instantiate(dentry, inode, newdentry, hardlink);
544 545 546 547
	if (err) {
		ovl_cleanup(udir, newdentry);
		dput(newdentry);
	}
M
Miklos Szeredi 已提交
548
out_dput:
549
	dput(upper);
M
Miklos Szeredi 已提交
550 551 552
out_unlock:
	unlock_rename(workdir, upperdir);
out:
553 554 555 556
	if (!hardlink) {
		posix_acl_release(acl);
		posix_acl_release(default_acl);
	}
M
Miklos Szeredi 已提交
557 558 559 560
	return err;

out_cleanup:
	ovl_cleanup(wdir, newdentry);
561 562
	dput(newdentry);
	goto out_dput;
M
Miklos Szeredi 已提交
563 564
}

M
Miklos Szeredi 已提交
565
static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
566
			      struct ovl_cattr *attr, bool origin)
M
Miklos Szeredi 已提交
567 568
{
	int err;
569 570
	const struct cred *old_cred;
	struct cred *override_cred;
571
	struct dentry *parent = dentry->d_parent;
M
Miklos Szeredi 已提交
572

573
	err = ovl_copy_up(parent);
M
Miklos Szeredi 已提交
574
	if (err)
M
Miklos Szeredi 已提交
575
		return err;
M
Miklos Szeredi 已提交
576

577
	old_cred = ovl_override_creds(dentry->d_sb);
578 579 580 581 582 583 584 585 586 587 588

	/*
	 * When linking a file with copy up origin into a new parent, mark the
	 * new parent dir "impure".
	 */
	if (origin) {
		err = ovl_set_impure(parent, ovl_dentry_upper(parent));
		if (err)
			goto out_revert_creds;
	}

589 590 591
	err = -ENOMEM;
	override_cred = prepare_creds();
	if (override_cred) {
M
Miklos Szeredi 已提交
592 593
		override_cred->fsuid = inode->i_uid;
		override_cred->fsgid = inode->i_gid;
A
Amir Goldstein 已提交
594
		if (!attr->hardlink) {
595
			err = security_dentry_create_files_as(dentry,
A
Al Viro 已提交
596
					attr->mode, &dentry->d_name, old_cred,
597 598 599 600 601 602
					override_cred);
			if (err) {
				put_cred(override_cred);
				goto out_revert_creds;
			}
		}
603 604 605
		put_cred(override_creds(override_cred));
		put_cred(override_cred);

M
Miklos Szeredi 已提交
606
		if (!ovl_dentry_is_whiteout(dentry))
A
Amir Goldstein 已提交
607
			err = ovl_create_upper(dentry, inode, attr);
608
		else
A
Amir Goldstein 已提交
609
			err = ovl_create_over_whiteout(dentry, inode, attr);
M
Miklos Szeredi 已提交
610
	}
611
out_revert_creds:
612
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
613 614 615 616 617 618 619
	return err;
}

static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
			     const char *link)
{
	int err;
M
Miklos Szeredi 已提交
620
	struct inode *inode;
A
Amir Goldstein 已提交
621
	struct ovl_cattr attr = {
M
Miklos Szeredi 已提交
622
		.rdev = rdev,
A
Al Viro 已提交
623
		.link = link,
M
Miklos Szeredi 已提交
624
	};
M
Miklos Szeredi 已提交
625 626

	err = ovl_want_write(dentry);
M
Miklos Szeredi 已提交
627 628 629
	if (err)
		goto out;

630
	/* Preallocate inode to be used by ovl_get_inode() */
M
Miklos Szeredi 已提交
631
	err = -ENOMEM;
632
	inode = ovl_new_inode(dentry->d_sb, mode, rdev);
M
Miklos Szeredi 已提交
633 634 635
	if (!inode)
		goto out_drop_write;

636 637 638 639
	spin_lock(&inode->i_lock);
	inode->i_state |= I_CREATING;
	spin_unlock(&inode->i_lock);

M
Miklos Szeredi 已提交
640
	inode_init_owner(inode, dentry->d_parent->d_inode, mode);
A
Al Viro 已提交
641
	attr.mode = inode->i_mode;
M
Miklos Szeredi 已提交
642

A
Amir Goldstein 已提交
643
	err = ovl_create_or_link(dentry, inode, &attr, false);
644 645
	/* Did we end up using the preallocated inode? */
	if (inode != d_inode(dentry))
M
Miklos Szeredi 已提交
646
		iput(inode);
M
Miklos Szeredi 已提交
647

M
Miklos Szeredi 已提交
648 649 650
out_drop_write:
	ovl_drop_write(dentry);
out:
M
Miklos Szeredi 已提交
651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680
	return err;
}

static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
		      bool excl)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
}

static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
}

static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
		     dev_t rdev)
{
	/* Don't allow creation of "whiteout" on overlay */
	if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
		return -EPERM;

	return ovl_create_object(dentry, mode, rdev, NULL);
}

static int ovl_symlink(struct inode *dir, struct dentry *dentry,
		       const char *link)
{
	return ovl_create_object(dentry, S_IFLNK, 0, link);
}

681 682 683 684 685 686 687 688 689 690 691 692
static int ovl_set_link_redirect(struct dentry *dentry)
{
	const struct cred *old_cred;
	int err;

	old_cred = ovl_override_creds(dentry->d_sb);
	err = ovl_set_redirect(dentry, false);
	revert_creds(old_cred);

	return err;
}

M
Miklos Szeredi 已提交
693 694 695 696
static int ovl_link(struct dentry *old, struct inode *newdir,
		    struct dentry *new)
{
	int err;
M
Miklos Szeredi 已提交
697
	struct inode *inode;
M
Miklos Szeredi 已提交
698 699 700 701 702 703 704 705 706

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

707 708 709 710
	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;

711
	if (ovl_is_metacopy_dentry(old)) {
712
		err = ovl_set_link_redirect(old);
713 714 715 716
		if (err)
			goto out_drop_write;
	}

717
	err = ovl_nlink_start(old);
718 719 720
	if (err)
		goto out_drop_write;

M
Miklos Szeredi 已提交
721 722 723
	inode = d_inode(old);
	ihold(inode);

A
Amir Goldstein 已提交
724 725 726
	err = ovl_create_or_link(new, inode,
			&(struct ovl_cattr) {.hardlink = ovl_dentry_upper(old)},
			ovl_type_origin(old));
M
Miklos Szeredi 已提交
727 728
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
729

730
	ovl_nlink_end(old);
M
Miklos Szeredi 已提交
731 732 733 734 735 736
out_drop_write:
	ovl_drop_write(old);
out:
	return err;
}

M
Miklos Szeredi 已提交
737 738 739 740 741
static bool ovl_matches_upper(struct dentry *dentry, struct dentry *upper)
{
	return d_inode(ovl_dentry_upper(dentry)) == d_inode(upper);
}

742 743
static int ovl_remove_and_whiteout(struct dentry *dentry,
				   struct list_head *list)
M
Miklos Szeredi 已提交
744
{
C
Chengguang Xu 已提交
745
	struct ovl_fs *ofs = OVL_FS(dentry->d_sb);
M
Miklos Szeredi 已提交
746 747 748 749 750 751
	struct dentry *workdir = ovl_workdir(dentry);
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct dentry *upper;
	struct dentry *opaquedir = NULL;
	int err;

752 753 754
	if (WARN_ON(!workdir))
		return -EROFS;

755 756
	if (!list_empty(list)) {
		opaquedir = ovl_clear_empty(dentry, list);
M
Miklos Szeredi 已提交
757 758 759
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
M
Miklos Szeredi 已提交
760 761 762 763 764 765
	}

	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out_dput;

766 767 768 769
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
M
Miklos Szeredi 已提交
770 771
		goto out_unlock;

772 773 774
	err = -ESTALE;
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && ovl_dentry_upper(dentry) &&
M
Miklos Szeredi 已提交
775
	     !ovl_matches_upper(dentry, upper))) {
776 777
		goto out_dput_upper;
	}
M
Miklos Szeredi 已提交
778

C
Chengguang Xu 已提交
779
	err = ovl_cleanup_and_whiteout(ofs, d_inode(upperdir), upper);
780
	if (err)
781
		goto out_d_drop;
M
Miklos Szeredi 已提交
782

M
Miklos Szeredi 已提交
783
	ovl_dir_modified(dentry->d_parent, true);
M
Miklos Szeredi 已提交
784 785
out_d_drop:
	d_drop(dentry);
786 787
out_dput_upper:
	dput(upper);
M
Miklos Szeredi 已提交
788 789 790 791 792 793 794 795
out_unlock:
	unlock_rename(workdir, upperdir);
out_dput:
	dput(opaquedir);
out:
	return err;
}

796 797
static int ovl_remove_upper(struct dentry *dentry, bool is_dir,
			    struct list_head *list)
M
Miklos Szeredi 已提交
798 799 800
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *dir = upperdir->d_inode;
801
	struct dentry *upper;
802
	struct dentry *opaquedir = NULL;
M
Miklos Szeredi 已提交
803 804
	int err;

805 806
	if (!list_empty(list)) {
		opaquedir = ovl_clear_empty(dentry, list);
807 808 809 810 811
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
	}

A
Al Viro 已提交
812
	inode_lock_nested(dir, I_MUTEX_PARENT);
813 814 815 816 817 818
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_unlock;

M
Miklos Szeredi 已提交
819
	err = -ESTALE;
820
	if ((opaquedir && upper != opaquedir) ||
M
Miklos Szeredi 已提交
821
	    (!opaquedir && !ovl_matches_upper(dentry, upper)))
822 823 824 825 826 827
		goto out_dput_upper;

	if (is_dir)
		err = vfs_rmdir(dir, upper);
	else
		err = vfs_unlink(dir, upper, NULL);
M
Miklos Szeredi 已提交
828
	ovl_dir_modified(dentry->d_parent, ovl_type_origin(dentry));
M
Miklos Szeredi 已提交
829 830 831 832 833 834 835

	/*
	 * Keeping this dentry hashed would mean having to release
	 * upperpath/lowerpath, which could only be done if we are the
	 * sole user of this dentry.  Too tricky...  Just unhash for
	 * now.
	 */
836 837
	if (!err)
		d_drop(dentry);
838 839
out_dput_upper:
	dput(upper);
840
out_unlock:
A
Al Viro 已提交
841
	inode_unlock(dir);
842 843
	dput(opaquedir);
out:
M
Miklos Szeredi 已提交
844 845 846
	return err;
}

847 848 849 850 851 852
static bool ovl_pure_upper(struct dentry *dentry)
{
	return !ovl_dentry_lower(dentry) &&
	       !ovl_test_flag(OVL_WHITEOUTS, d_inode(dentry));
}

853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874
static void ovl_drop_nlink(struct dentry *dentry)
{
	struct inode *inode = d_inode(dentry);
	struct dentry *alias;

	/* Try to find another, hashed alias */
	spin_lock(&inode->i_lock);
	hlist_for_each_entry(alias, &inode->i_dentry, d_u.d_alias) {
		if (alias != dentry && !d_unhashed(alias))
			break;
	}
	spin_unlock(&inode->i_lock);

	/*
	 * Changes to underlying layers may cause i_nlink to lose sync with
	 * reality.  In this case prevent the link count from going to zero
	 * prematurely.
	 */
	if (inode->i_nlink > !!alias)
		drop_nlink(inode);
}

M
Miklos Szeredi 已提交
875 876 877
static int ovl_do_remove(struct dentry *dentry, bool is_dir)
{
	int err;
878
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
879
	struct dentry *upperdentry;
880 881 882 883 884 885 886 887 888
	bool lower_positive = ovl_lower_positive(dentry);
	LIST_HEAD(list);

	/* No need to clean pure upper removed by vfs_rmdir() */
	if (is_dir && (lower_positive || !ovl_pure_upper(dentry))) {
		err = ovl_check_empty_dir(dentry, &list);
		if (err)
			goto out;
	}
889

M
Miklos Szeredi 已提交
890 891 892 893 894 895 896 897
	err = ovl_want_write(dentry);
	if (err)
		goto out;

	err = ovl_copy_up(dentry->d_parent);
	if (err)
		goto out_drop_write;

898
	err = ovl_nlink_start(dentry);
899 900
	if (err)
		goto out_drop_write;
M
Miklos Szeredi 已提交
901

902
	old_cred = ovl_override_creds(dentry->d_sb);
903 904
	if (!lower_positive)
		err = ovl_remove_upper(dentry, is_dir, &list);
905
	else
906
		err = ovl_remove_and_whiteout(dentry, &list);
907
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
908 909 910 911
	if (!err) {
		if (is_dir)
			clear_nlink(dentry->d_inode);
		else
912
			ovl_drop_nlink(dentry);
M
Miklos Szeredi 已提交
913
	}
914
	ovl_nlink_end(dentry);
M
Miklos Szeredi 已提交
915 916 917 918 919 920 921 922 923 924 925

	/*
	 * Copy ctime
	 *
	 * Note: we fail to update ctime if there was no copy-up, only a
	 * whiteout
	 */
	upperdentry = ovl_dentry_upper(dentry);
	if (upperdentry)
		ovl_copyattr(d_inode(upperdentry), d_inode(dentry));

M
Miklos Szeredi 已提交
926 927 928
out_drop_write:
	ovl_drop_write(dentry);
out:
929
	ovl_cache_free(&list);
M
Miklos Szeredi 已提交
930 931 932 933 934 935 936 937 938 939 940 941 942
	return err;
}

static int ovl_unlink(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, false);
}

static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, true);
}

943 944 945 946 947 948 949
static bool ovl_type_merge_or_lower(struct dentry *dentry)
{
	enum ovl_path_type type = ovl_path_type(dentry);

	return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
}

M
Miklos Szeredi 已提交
950 951 952 953 954 955
static bool ovl_can_move(struct dentry *dentry)
{
	return ovl_redirect_dir(dentry->d_sb) ||
		!d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
}

956
static char *ovl_get_redirect(struct dentry *dentry, bool abs_redirect)
M
Miklos Szeredi 已提交
957 958 959
{
	char *buf, *ret;
	struct dentry *d, *tmp;
960
	int buflen = ovl_redirect_max + 1;
M
Miklos Szeredi 已提交
961

962
	if (!abs_redirect) {
M
Miklos Szeredi 已提交
963 964 965 966 967
		ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
			       GFP_KERNEL);
		goto out;
	}

968
	buf = ret = kmalloc(buflen, GFP_KERNEL);
M
Miklos Szeredi 已提交
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996
	if (!buf)
		goto out;

	buflen--;
	buf[buflen] = '\0';
	for (d = dget(dentry); !IS_ROOT(d);) {
		const char *name;
		int thislen;

		spin_lock(&d->d_lock);
		name = ovl_dentry_get_redirect(d);
		if (name) {
			thislen = strlen(name);
		} else {
			name = d->d_name.name;
			thislen = d->d_name.len;
		}

		/* If path is too long, fall back to userspace move */
		if (thislen + (name[0] != '/') > buflen) {
			ret = ERR_PTR(-EXDEV);
			spin_unlock(&d->d_lock);
			goto out_put;
		}

		buflen -= thislen;
		memcpy(&buf[buflen], name, thislen);
		spin_unlock(&d->d_lock);
997
		tmp = dget_parent(d);
M
Miklos Szeredi 已提交
998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015

		dput(d);
		d = tmp;

		/* Absolute redirect: finished */
		if (buf[buflen] == '/')
			break;
		buflen--;
		buf[buflen] = '/';
	}
	ret = kstrdup(&buf[buflen], GFP_KERNEL);
out_put:
	dput(d);
	kfree(buf);
out:
	return ret ? ret : ERR_PTR(-ENOMEM);
}

1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
static bool ovl_need_absolute_redirect(struct dentry *dentry, bool samedir)
{
	struct dentry *lowerdentry;

	if (!samedir)
		return true;

	if (d_is_dir(dentry))
		return false;

	/*
	 * For non-dir hardlinked files, we need absolute redirects
	 * in general as two upper hardlinks could be in different
	 * dirs. We could put a relative redirect now and convert
	 * it to absolute redirect later. But when nlink > 1 and
	 * indexing is on, that means relative redirect needs to be
	 * converted to absolute during copy up of another lower
	 * hardllink as well.
	 *
	 * So without optimizing too much, just check if lower is
	 * a hard link or not. If lower is hard link, put absolute
	 * redirect.
	 */
	lowerdentry = ovl_dentry_lower(dentry);
	return (d_inode(lowerdentry)->i_nlink > 1);
}

M
Miklos Szeredi 已提交
1043 1044 1045 1046
static int ovl_set_redirect(struct dentry *dentry, bool samedir)
{
	int err;
	const char *redirect = ovl_dentry_get_redirect(dentry);
1047
	bool absolute_redirect = ovl_need_absolute_redirect(dentry, samedir);
M
Miklos Szeredi 已提交
1048

1049
	if (redirect && (!absolute_redirect || redirect[0] == '/'))
M
Miklos Szeredi 已提交
1050 1051
		return 0;

1052
	redirect = ovl_get_redirect(dentry, absolute_redirect);
M
Miklos Szeredi 已提交
1053 1054 1055
	if (IS_ERR(redirect))
		return PTR_ERR(redirect);

1056 1057 1058
	err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
				 OVL_XATTR_REDIRECT,
				 redirect, strlen(redirect), -EXDEV);
M
Miklos Szeredi 已提交
1059 1060 1061 1062 1063 1064
	if (!err) {
		spin_lock(&dentry->d_lock);
		ovl_dentry_set_redirect(dentry, redirect);
		spin_unlock(&dentry->d_lock);
	} else {
		kfree(redirect);
L
lijiazi 已提交
1065
		pr_warn_ratelimited("failed to set redirect (%i)\n",
A
Amir Goldstein 已提交
1066
				    err);
M
Miklos Szeredi 已提交
1067 1068 1069 1070 1071 1072
		/* Fall back to userspace copy-up */
		err = -EXDEV;
	}
	return err;
}

1073 1074 1075
static int ovl_rename(struct inode *olddir, struct dentry *old,
		      struct inode *newdir, struct dentry *new,
		      unsigned int flags)
M
Miklos Szeredi 已提交
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085
{
	int err;
	struct dentry *old_upperdir;
	struct dentry *new_upperdir;
	struct dentry *olddentry;
	struct dentry *newdentry;
	struct dentry *trap;
	bool old_opaque;
	bool new_opaque;
	bool cleanup_whiteout = false;
1086
	bool update_nlink = false;
M
Miklos Szeredi 已提交
1087
	bool overwrite = !(flags & RENAME_EXCHANGE);
1088
	bool is_dir = d_is_dir(old);
1089
	bool new_is_dir = d_is_dir(new);
M
Miklos Szeredi 已提交
1090
	bool samedir = olddir == newdir;
M
Miklos Szeredi 已提交
1091 1092
	struct dentry *opaquedir = NULL;
	const struct cred *old_cred = NULL;
1093
	LIST_HEAD(list);
M
Miklos Szeredi 已提交
1094 1095 1096 1097 1098 1099 1100 1101 1102

	err = -EINVAL;
	if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
		goto out;

	flags &= ~RENAME_NOREPLACE;

	/* Don't copy up directory trees */
	err = -EXDEV;
M
Miklos Szeredi 已提交
1103
	if (!ovl_can_move(old))
1104
		goto out;
M
Miklos Szeredi 已提交
1105
	if (!overwrite && !ovl_can_move(new))
M
Miklos Szeredi 已提交
1106 1107
		goto out;

1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
	if (overwrite && new_is_dir && !ovl_pure_upper(new)) {
		err = ovl_check_empty_dir(new, &list);
		if (err)
			goto out;
	}

	if (overwrite) {
		if (ovl_lower_positive(old)) {
			if (!ovl_dentry_is_whiteout(new)) {
				/* Whiteout source */
				flags |= RENAME_WHITEOUT;
			} else {
				/* Switch whiteouts */
				flags |= RENAME_EXCHANGE;
			}
		} else if (is_dir && ovl_dentry_is_whiteout(new)) {
			flags |= RENAME_EXCHANGE;
			cleanup_whiteout = true;
		}
	}

M
Miklos Szeredi 已提交
1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143
	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;
	if (!overwrite) {
		err = ovl_copy_up(new);
		if (err)
			goto out_drop_write;
1144 1145
	} else if (d_inode(new)) {
		err = ovl_nlink_start(new);
1146 1147
		if (err)
			goto out_drop_write;
1148 1149

		update_nlink = true;
M
Miklos Szeredi 已提交
1150 1151
	}

1152
	old_cred = ovl_override_creds(old->d_sb);
M
Miklos Szeredi 已提交
1153

1154 1155
	if (!list_empty(&list)) {
		opaquedir = ovl_clear_empty(new, &list);
M
Miklos Szeredi 已提交
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir)) {
			opaquedir = NULL;
			goto out_revert_creds;
		}
	}

	old_upperdir = ovl_dentry_upper(old->d_parent);
	new_upperdir = ovl_dentry_upper(new->d_parent);

1166 1167 1168
	if (!samedir) {
		/*
		 * When moving a merge dir or non-dir with copy up origin into
1169 1170 1171
		 * a new parent, we are marking the new parent dir "impure".
		 * When ovl_iterate() iterates an "impure" upper dir, it will
		 * lookup the origin inodes of the entries to fill d_ino.
1172
		 */
1173
		if (ovl_type_origin(old)) {
1174 1175 1176 1177
			err = ovl_set_impure(new->d_parent, new_upperdir);
			if (err)
				goto out_revert_creds;
		}
1178
		if (!overwrite && ovl_type_origin(new)) {
1179 1180 1181 1182 1183 1184
			err = ovl_set_impure(old->d_parent, old_upperdir);
			if (err)
				goto out_revert_creds;
		}
	}

M
Miklos Szeredi 已提交
1185 1186
	trap = lock_rename(new_upperdir, old_upperdir);

1187 1188 1189 1190 1191 1192 1193
	olddentry = lookup_one_len(old->d_name.name, old_upperdir,
				   old->d_name.len);
	err = PTR_ERR(olddentry);
	if (IS_ERR(olddentry))
		goto out_unlock;

	err = -ESTALE;
M
Miklos Szeredi 已提交
1194
	if (!ovl_matches_upper(old, olddentry))
1195 1196 1197 1198 1199 1200 1201 1202
		goto out_dput_old;

	newdentry = lookup_one_len(new->d_name.name, new_upperdir,
				   new->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput_old;

1203 1204 1205
	old_opaque = ovl_dentry_is_opaque(old);
	new_opaque = ovl_dentry_is_opaque(new);

1206
	err = -ESTALE;
1207
	if (d_inode(new) && ovl_dentry_upper(new)) {
M
Miklos Szeredi 已提交
1208
		if (opaquedir) {
1209 1210
			if (newdentry != opaquedir)
				goto out_dput;
M
Miklos Szeredi 已提交
1211
		} else {
M
Miklos Szeredi 已提交
1212
			if (!ovl_matches_upper(new, newdentry))
1213
				goto out_dput;
M
Miklos Szeredi 已提交
1214 1215
		}
	} else {
1216 1217 1218 1219 1220 1221 1222
		if (!d_is_negative(newdentry)) {
			if (!new_opaque || !ovl_is_whiteout(newdentry))
				goto out_dput;
		} else {
			if (flags & RENAME_EXCHANGE)
				goto out_dput;
		}
M
Miklos Szeredi 已提交
1223 1224 1225 1226 1227 1228 1229
	}

	if (olddentry == trap)
		goto out_dput;
	if (newdentry == trap)
		goto out_dput;

1230
	if (olddentry->d_inode == newdentry->d_inode)
M
Miklos Szeredi 已提交
1231 1232
		goto out_dput;

M
Miklos Szeredi 已提交
1233
	err = 0;
1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247
	if (ovl_type_merge_or_lower(old))
		err = ovl_set_redirect(old, samedir);
	else if (is_dir && !old_opaque && ovl_type_merge(new->d_parent))
		err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
	if (err)
		goto out_dput;

	if (!overwrite && ovl_type_merge_or_lower(new))
		err = ovl_set_redirect(new, samedir);
	else if (!overwrite && new_is_dir && !new_opaque &&
		 ovl_type_merge(old->d_parent))
		err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
	if (err)
		goto out_dput;
M
Miklos Szeredi 已提交
1248

1249 1250 1251
	err = ovl_do_rename(old_upperdir->d_inode, olddentry,
			    new_upperdir->d_inode, newdentry, flags);
	if (err)
M
Miklos Szeredi 已提交
1252 1253 1254 1255 1256
		goto out_dput;

	if (cleanup_whiteout)
		ovl_cleanup(old_upperdir->d_inode, newdentry);

1257 1258 1259 1260
	if (overwrite && d_inode(new)) {
		if (new_is_dir)
			clear_nlink(d_inode(new));
		else
1261
			ovl_drop_nlink(new);
1262 1263
	}

M
Miklos Szeredi 已提交
1264 1265 1266 1267 1268 1269 1270 1271 1272
	ovl_dir_modified(old->d_parent, ovl_type_origin(old) ||
			 (!overwrite && ovl_type_origin(new)));
	ovl_dir_modified(new->d_parent, ovl_type_origin(old) ||
			 (d_inode(new) && ovl_type_origin(new)));

	/* copy ctime: */
	ovl_copyattr(d_inode(olddentry), d_inode(old));
	if (d_inode(new) && ovl_dentry_upper(new))
		ovl_copyattr(d_inode(newdentry), d_inode(new));
M
Miklos Szeredi 已提交
1273 1274 1275

out_dput:
	dput(newdentry);
1276 1277
out_dput_old:
	dput(olddentry);
M
Miklos Szeredi 已提交
1278 1279 1280
out_unlock:
	unlock_rename(new_upperdir, old_upperdir);
out_revert_creds:
1281
	revert_creds(old_cred);
1282 1283
	if (update_nlink)
		ovl_nlink_end(new);
M
Miklos Szeredi 已提交
1284 1285 1286 1287
out_drop_write:
	ovl_drop_write(old);
out:
	dput(opaquedir);
1288
	ovl_cache_free(&list);
M
Miklos Szeredi 已提交
1289 1290 1291 1292 1293 1294 1295 1296 1297
	return err;
}

const struct inode_operations ovl_dir_inode_operations = {
	.lookup		= ovl_lookup,
	.mkdir		= ovl_mkdir,
	.symlink	= ovl_symlink,
	.unlink		= ovl_unlink,
	.rmdir		= ovl_rmdir,
1298
	.rename		= ovl_rename,
M
Miklos Szeredi 已提交
1299 1300 1301 1302 1303
	.link		= ovl_link,
	.setattr	= ovl_setattr,
	.create		= ovl_create,
	.mknod		= ovl_mknod,
	.permission	= ovl_permission,
1304
	.getattr	= ovl_getattr,
M
Miklos Szeredi 已提交
1305
	.listxattr	= ovl_listxattr,
1306
	.get_acl2	= ovl_get_acl,
M
Miklos Szeredi 已提交
1307
	.update_time	= ovl_update_time,
M
Miklos Szeredi 已提交
1308
};