dir.c 27.9 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14
/*
 *
 * Copyright (C) 2011 Novell Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/cred.h>
15
#include <linux/module.h>
16 17
#include <linux/posix_acl.h>
#include <linux/posix_acl_xattr.h>
18
#include <linux/atomic.h>
M
Miklos Szeredi 已提交
19
#include <linux/ratelimit.h>
M
Miklos Szeredi 已提交
20 21
#include "overlayfs.h"

22 23 24 25 26
static unsigned short ovl_redirect_max = 256;
module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
MODULE_PARM_DESC(ovl_redirect_max,
		 "Maximum length of absolute redirect xattr value");

27 28
static int ovl_set_redirect(struct dentry *dentry, bool samedir);

29
int ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
M
Miklos Szeredi 已提交
30 31 32 33
{
	int err;

	dget(wdentry);
34
	if (d_is_dir(wdentry))
M
Miklos Szeredi 已提交
35 36 37 38 39 40 41 42 43
		err = ovl_do_rmdir(wdir, wdentry);
	else
		err = ovl_do_unlink(wdir, wdentry);
	dput(wdentry);

	if (err) {
		pr_err("overlayfs: cleanup of '%pd2' failed (%i)\n",
		       wdentry, err);
	}
44 45

	return err;
M
Miklos Szeredi 已提交
46 47
}

48
static struct dentry *ovl_lookup_temp(struct dentry *workdir)
M
Miklos Szeredi 已提交
49 50 51
{
	struct dentry *temp;
	char name[20];
52
	static atomic_t temp_id = ATOMIC_INIT(0);
M
Miklos Szeredi 已提交
53

54 55
	/* counter is allowed to wrap, since temp dentries are ephemeral */
	snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
M
Miklos Szeredi 已提交
56 57 58 59 60 61 62 63 64 65 66 67

	temp = lookup_one_len(name, workdir, strlen(name));
	if (!IS_ERR(temp) && temp->d_inode) {
		pr_err("overlayfs: workdir/%s already exists\n", name);
		dput(temp);
		temp = ERR_PTR(-EIO);
	}

	return temp;
}

/* caller holds i_mutex on workdir */
68
static struct dentry *ovl_whiteout(struct dentry *workdir)
M
Miklos Szeredi 已提交
69 70 71 72 73
{
	int err;
	struct dentry *whiteout;
	struct inode *wdir = workdir->d_inode;

74
	whiteout = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
75 76 77 78 79 80 81 82 83 84 85 86
	if (IS_ERR(whiteout))
		return whiteout;

	err = ovl_do_whiteout(wdir, whiteout);
	if (err) {
		dput(whiteout);
		whiteout = ERR_PTR(err);
	}

	return whiteout;
}

87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
/* Caller must hold i_mutex on both workdir and dir */
int ovl_cleanup_and_whiteout(struct dentry *workdir, struct inode *dir,
			     struct dentry *dentry)
{
	struct inode *wdir = workdir->d_inode;
	struct dentry *whiteout;
	int err;
	int flags = 0;

	whiteout = ovl_whiteout(workdir);
	err = PTR_ERR(whiteout);
	if (IS_ERR(whiteout))
		return err;

	if (d_is_dir(dentry))
		flags = RENAME_EXCHANGE;

	err = ovl_do_rename(wdir, whiteout, dir, dentry, flags);
	if (err)
		goto kill_whiteout;
	if (flags)
		ovl_cleanup(wdir, dentry);

out:
	dput(whiteout);
	return err;

kill_whiteout:
	ovl_cleanup(wdir, whiteout);
	goto out;
}

119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149
static int ovl_mkdir_real(struct inode *dir, struct dentry **newdentry,
			  umode_t mode)
{
	int err;
	struct dentry *d, *dentry = *newdentry;

	err = ovl_do_mkdir(dir, dentry, mode);
	if (err)
		return err;

	if (likely(!d_unhashed(dentry)))
		return 0;

	/*
	 * vfs_mkdir() may succeed and leave the dentry passed
	 * to it unhashed and negative. If that happens, try to
	 * lookup a new hashed and positive dentry.
	 */
	d = lookup_one_len(dentry->d_name.name, dentry->d_parent,
			   dentry->d_name.len);
	if (IS_ERR(d)) {
		pr_warn("overlayfs: failed lookup after mkdir (%pd2, err=%i).\n",
			dentry, err);
		return PTR_ERR(d);
	}
	dput(dentry);
	*newdentry = d;

	return 0;
}

150 151
struct dentry *ovl_create_real(struct inode *dir, struct dentry *newdentry,
			       struct ovl_cattr *attr)
M
Miklos Szeredi 已提交
152 153 154
{
	int err;

155 156 157 158
	if (IS_ERR(newdentry))
		return newdentry;

	err = -ESTALE;
M
Miklos Szeredi 已提交
159
	if (newdentry->d_inode)
160
		goto out;
M
Miklos Szeredi 已提交
161

A
Amir Goldstein 已提交
162 163
	if (attr->hardlink) {
		err = ovl_do_link(attr->hardlink, dir, newdentry);
M
Miklos Szeredi 已提交
164
	} else {
A
Al Viro 已提交
165
		switch (attr->mode & S_IFMT) {
M
Miklos Szeredi 已提交
166
		case S_IFREG:
167
			err = ovl_do_create(dir, newdentry, attr->mode);
M
Miklos Szeredi 已提交
168 169 170
			break;

		case S_IFDIR:
171 172
			/* mkdir is special... */
			err =  ovl_mkdir_real(dir, &newdentry, attr->mode);
M
Miklos Szeredi 已提交
173 174 175 176 177 178
			break;

		case S_IFCHR:
		case S_IFBLK:
		case S_IFIFO:
		case S_IFSOCK:
179 180
			err = ovl_do_mknod(dir, newdentry, attr->mode,
					   attr->rdev);
M
Miklos Szeredi 已提交
181 182 183
			break;

		case S_IFLNK:
184
			err = ovl_do_symlink(dir, newdentry, attr->link);
M
Miklos Szeredi 已提交
185 186 187 188 189 190 191 192 193 194 195
			break;

		default:
			err = -EPERM;
		}
	}
	if (!err && WARN_ON(!newdentry->d_inode)) {
		/*
		 * Not quite sure if non-instantiated dentry is legal or not.
		 * VFS doesn't seem to care so check and warn here.
		 */
196
		err = -EIO;
M
Miklos Szeredi 已提交
197
	}
198 199 200 201 202 203
out:
	if (err) {
		dput(newdentry);
		return ERR_PTR(err);
	}
	return newdentry;
M
Miklos Szeredi 已提交
204 205
}

206 207 208 209 210 211
struct dentry *ovl_create_temp(struct dentry *workdir, struct ovl_cattr *attr)
{
	return ovl_create_real(d_inode(workdir), ovl_lookup_temp(workdir),
			       attr);
}

212 213
static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
			       int xerr)
M
Miklos Szeredi 已提交
214
{
M
Miklos Szeredi 已提交
215 216
	int err;

217
	err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
M
Miklos Szeredi 已提交
218 219 220 221
	if (!err)
		ovl_dentry_set_opaque(dentry);

	return err;
M
Miklos Szeredi 已提交
222 223
}

224 225 226 227 228 229 230 231 232 233
static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
{
	/*
	 * Fail with -EIO when trying to create opaque dir and upper doesn't
	 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
	 * return a specific error for noxattr case.
	 */
	return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
}

234 235 236 237 238 239 240
/*
 * Common operations required to be done after creation of file on upper.
 * If @hardlink is false, then @inode is a pre-allocated inode, we may or
 * may not use to instantiate the new dentry.
 */
static int ovl_instantiate(struct dentry *dentry, struct inode *inode,
			   struct dentry *newdentry, bool hardlink)
241
{
242 243 244 245 246
	struct ovl_inode_params oip = {
		.upperdentry = newdentry,
		.newinode = inode,
	};

M
Miklos Szeredi 已提交
247
	ovl_dir_modified(dentry->d_parent, false);
248
	ovl_dentry_set_upper_alias(dentry);
M
Miklos Szeredi 已提交
249
	if (!hardlink) {
250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
		/*
		 * ovl_obtain_alias() can be called after ovl_create_real()
		 * and before we get here, so we may get an inode from cache
		 * with the same real upperdentry that is not the inode we
		 * pre-allocated.  In this case we will use the cached inode
		 * to instantiate the new dentry.
		 *
		 * XXX: if we ever use ovl_obtain_alias() to decode directory
		 * file handles, need to use ovl_get_inode_locked() and
		 * d_instantiate_new() here to prevent from creating two
		 * hashed directory inode aliases.
		 */
		inode = ovl_get_inode(dentry->d_sb, &oip);
		if (WARN_ON(IS_ERR(inode)))
			return PTR_ERR(inode);
M
Miklos Szeredi 已提交
265
	} else {
266 267
		WARN_ON(ovl_inode_real(inode) != d_inode(newdentry));
		dput(newdentry);
M
Miklos Szeredi 已提交
268 269
		inc_nlink(inode);
	}
270

271
	d_instantiate(dentry, inode);
272 273 274 275 276
	if (inode != oip.newinode) {
		pr_warn_ratelimited("overlayfs: newly created inode found in cache (%pd2)\n",
				    dentry);
	}

277 278 279
	/* Force lookup of new upper hardlink to find its lower */
	if (hardlink)
		d_drop(dentry);
280 281

	return 0;
282 283
}

284 285 286 287 288
static bool ovl_type_merge(struct dentry *dentry)
{
	return OVL_TYPE_MERGE(ovl_path_type(dentry));
}

289 290 291 292 293
static bool ovl_type_origin(struct dentry *dentry)
{
	return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
}

M
Miklos Szeredi 已提交
294
static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
295
			    struct ovl_cattr *attr)
M
Miklos Szeredi 已提交
296 297 298 299 300 301
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *newdentry;
	int err;

A
Amir Goldstein 已提交
302
	if (!attr->hardlink && !IS_POSIXACL(udir))
A
Al Viro 已提交
303
		attr->mode &= ~current_umask();
304

A
Al Viro 已提交
305
	inode_lock_nested(udir, I_MUTEX_PARENT);
306 307 308 309 310
	newdentry = ovl_create_real(udir,
				    lookup_one_len(dentry->d_name.name,
						   upperdir,
						   dentry->d_name.len),
				    attr);
M
Miklos Szeredi 已提交
311 312 313 314
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;

315
	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
316 317 318 319
		/* Setting opaque here is just an optimization, allow to fail */
		ovl_set_opaque(dentry, newdentry);
	}

320 321 322
	err = ovl_instantiate(dentry, inode, newdentry, !!attr->hardlink);
	if (err)
		goto out_cleanup;
M
Miklos Szeredi 已提交
323
out_unlock:
A
Al Viro 已提交
324
	inode_unlock(udir);
M
Miklos Szeredi 已提交
325
	return err;
326 327 328 329 330

out_cleanup:
	ovl_cleanup(udir, newdentry);
	dput(newdentry);
	goto out_unlock;
M
Miklos Szeredi 已提交
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
}

static struct dentry *ovl_clear_empty(struct dentry *dentry,
				      struct list_head *list)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct path upperpath;
	struct dentry *upper;
	struct dentry *opaquedir;
	struct kstat stat;
	int err;

346 347 348
	if (WARN_ON(!workdir))
		return ERR_PTR(-EROFS);

M
Miklos Szeredi 已提交
349 350 351 352 353
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	ovl_path_upper(dentry, &upperpath);
354 355
	err = vfs_getattr(&upperpath, &stat,
			  STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
M
Miklos Szeredi 已提交
356 357 358 359 360 361 362 363 364 365
	if (err)
		goto out_unlock;

	err = -ESTALE;
	if (!S_ISDIR(stat.mode))
		goto out_unlock;
	upper = upperpath.dentry;
	if (upper->d_parent->d_inode != udir)
		goto out_unlock;

366
	opaquedir = ovl_create_temp(workdir, OVL_CATTR(stat.mode));
M
Miklos Szeredi 已提交
367 368 369 370 371 372 373 374
	err = PTR_ERR(opaquedir);
	if (IS_ERR(opaquedir))
		goto out_unlock;

	err = ovl_copy_xattr(upper, opaquedir);
	if (err)
		goto out_cleanup;

M
Miklos Szeredi 已提交
375
	err = ovl_set_opaque(dentry, opaquedir);
M
Miklos Szeredi 已提交
376 377 378
	if (err)
		goto out_cleanup;

A
Al Viro 已提交
379
	inode_lock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
380
	err = ovl_set_attr(opaquedir, &stat);
A
Al Viro 已提交
381
	inode_unlock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406
	if (err)
		goto out_cleanup;

	err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
	if (err)
		goto out_cleanup;

	ovl_cleanup_whiteouts(upper, list);
	ovl_cleanup(wdir, upper);
	unlock_rename(workdir, upperdir);

	/* dentry's upper doesn't match now, get rid of it */
	d_drop(dentry);

	return opaquedir;

out_cleanup:
	ovl_cleanup(wdir, opaquedir);
	dput(opaquedir);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
	return ERR_PTR(err);
}

407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432
static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
			     const struct posix_acl *acl)
{
	void *buffer;
	size_t size;
	int err;

	if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
		return 0;

	size = posix_acl_to_xattr(NULL, acl, NULL, 0);
	buffer = kmalloc(size, GFP_KERNEL);
	if (!buffer)
		return -ENOMEM;

	size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
	err = size;
	if (err < 0)
		goto out_free;

	err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
out_free:
	kfree(buffer);
	return err;
}

M
Miklos Szeredi 已提交
433
static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
434
				    struct ovl_cattr *cattr)
M
Miklos Szeredi 已提交
435 436 437 438 439 440 441 442
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *upper;
	struct dentry *newdentry;
	int err;
443
	struct posix_acl *acl, *default_acl;
A
Amir Goldstein 已提交
444
	bool hardlink = !!cattr->hardlink;
M
Miklos Szeredi 已提交
445

446 447 448
	if (WARN_ON(!workdir))
		return -EROFS;

449 450
	if (!hardlink) {
		err = posix_acl_create(dentry->d_parent->d_inode,
A
Al Viro 已提交
451
				       &cattr->mode, &default_acl, &acl);
452 453 454 455
		if (err)
			return err;
	}

M
Miklos Szeredi 已提交
456 457 458 459 460 461 462 463
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
464
		goto out_unlock;
M
Miklos Szeredi 已提交
465

466
	newdentry = ovl_create_temp(workdir, cattr);
467 468 469
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput;
M
Miklos Szeredi 已提交
470

M
Miklos Szeredi 已提交
471 472 473
	/*
	 * mode could have been mutilated due to umask (e.g. sgid directory)
	 */
M
Miklos Szeredi 已提交
474
	if (!hardlink &&
A
Al Viro 已提交
475 476
	    !S_ISLNK(cattr->mode) &&
	    newdentry->d_inode->i_mode != cattr->mode) {
M
Miklos Szeredi 已提交
477 478
		struct iattr attr = {
			.ia_valid = ATTR_MODE,
A
Al Viro 已提交
479
			.ia_mode = cattr->mode,
M
Miklos Szeredi 已提交
480 481 482 483 484 485 486
		};
		inode_lock(newdentry->d_inode);
		err = notify_change(newdentry, &attr, NULL);
		inode_unlock(newdentry->d_inode);
		if (err)
			goto out_cleanup;
	}
487 488 489 490 491 492 493 494 495 496 497
	if (!hardlink) {
		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
					acl);
		if (err)
			goto out_cleanup;

		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
					default_acl);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
498

A
Al Viro 已提交
499
	if (!hardlink && S_ISDIR(cattr->mode)) {
M
Miklos Szeredi 已提交
500
		err = ovl_set_opaque(dentry, newdentry);
M
Miklos Szeredi 已提交
501 502 503 504 505 506 507 508 509 510 511 512 513 514
		if (err)
			goto out_cleanup;

		err = ovl_do_rename(wdir, newdentry, udir, upper,
				    RENAME_EXCHANGE);
		if (err)
			goto out_cleanup;

		ovl_cleanup(wdir, upper);
	} else {
		err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
		if (err)
			goto out_cleanup;
	}
515 516 517
	err = ovl_instantiate(dentry, inode, newdentry, hardlink);
	if (err)
		goto out_cleanup;
M
Miklos Szeredi 已提交
518
out_dput:
519
	dput(upper);
M
Miklos Szeredi 已提交
520 521 522
out_unlock:
	unlock_rename(workdir, upperdir);
out:
523 524 525 526
	if (!hardlink) {
		posix_acl_release(acl);
		posix_acl_release(default_acl);
	}
M
Miklos Szeredi 已提交
527 528 529 530
	return err;

out_cleanup:
	ovl_cleanup(wdir, newdentry);
531 532
	dput(newdentry);
	goto out_dput;
M
Miklos Szeredi 已提交
533 534
}

M
Miklos Szeredi 已提交
535
static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
A
Amir Goldstein 已提交
536
			      struct ovl_cattr *attr, bool origin)
M
Miklos Szeredi 已提交
537 538
{
	int err;
539 540
	const struct cred *old_cred;
	struct cred *override_cred;
541
	struct dentry *parent = dentry->d_parent;
M
Miklos Szeredi 已提交
542

543
	err = ovl_copy_up(parent);
M
Miklos Szeredi 已提交
544
	if (err)
M
Miklos Szeredi 已提交
545
		return err;
M
Miklos Szeredi 已提交
546

547
	old_cred = ovl_override_creds(dentry->d_sb);
548 549 550 551 552 553 554 555 556 557 558

	/*
	 * When linking a file with copy up origin into a new parent, mark the
	 * new parent dir "impure".
	 */
	if (origin) {
		err = ovl_set_impure(parent, ovl_dentry_upper(parent));
		if (err)
			goto out_revert_creds;
	}

559 560 561
	err = -ENOMEM;
	override_cred = prepare_creds();
	if (override_cred) {
M
Miklos Szeredi 已提交
562 563
		override_cred->fsuid = inode->i_uid;
		override_cred->fsgid = inode->i_gid;
A
Amir Goldstein 已提交
564
		if (!attr->hardlink) {
565
			err = security_dentry_create_files_as(dentry,
A
Al Viro 已提交
566
					attr->mode, &dentry->d_name, old_cred,
567 568 569 570 571 572
					override_cred);
			if (err) {
				put_cred(override_cred);
				goto out_revert_creds;
			}
		}
573 574 575
		put_cred(override_creds(override_cred));
		put_cred(override_cred);

M
Miklos Szeredi 已提交
576
		if (!ovl_dentry_is_whiteout(dentry))
A
Amir Goldstein 已提交
577
			err = ovl_create_upper(dentry, inode, attr);
578
		else
A
Amir Goldstein 已提交
579
			err = ovl_create_over_whiteout(dentry, inode, attr);
M
Miklos Szeredi 已提交
580
	}
581
out_revert_creds:
582
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
583 584 585 586 587 588 589
	return err;
}

static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
			     const char *link)
{
	int err;
M
Miklos Szeredi 已提交
590
	struct inode *inode;
A
Amir Goldstein 已提交
591
	struct ovl_cattr attr = {
M
Miklos Szeredi 已提交
592
		.rdev = rdev,
A
Al Viro 已提交
593
		.link = link,
M
Miklos Szeredi 已提交
594
	};
M
Miklos Szeredi 已提交
595 596

	err = ovl_want_write(dentry);
M
Miklos Szeredi 已提交
597 598 599
	if (err)
		goto out;

600
	/* Preallocate inode to be used by ovl_get_inode() */
M
Miklos Szeredi 已提交
601
	err = -ENOMEM;
602
	inode = ovl_new_inode(dentry->d_sb, mode, rdev);
M
Miklos Szeredi 已提交
603 604 605
	if (!inode)
		goto out_drop_write;

606 607 608 609
	spin_lock(&inode->i_lock);
	inode->i_state |= I_CREATING;
	spin_unlock(&inode->i_lock);

M
Miklos Szeredi 已提交
610
	inode_init_owner(inode, dentry->d_parent->d_inode, mode);
A
Al Viro 已提交
611
	attr.mode = inode->i_mode;
M
Miklos Szeredi 已提交
612

A
Amir Goldstein 已提交
613
	err = ovl_create_or_link(dentry, inode, &attr, false);
614 615
	/* Did we end up using the preallocated inode? */
	if (inode != d_inode(dentry))
M
Miklos Szeredi 已提交
616
		iput(inode);
M
Miklos Szeredi 已提交
617

M
Miklos Szeredi 已提交
618 619 620
out_drop_write:
	ovl_drop_write(dentry);
out:
M
Miklos Szeredi 已提交
621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654
	return err;
}

static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
		      bool excl)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
}

static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
}

static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
		     dev_t rdev)
{
	/* Don't allow creation of "whiteout" on overlay */
	if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
		return -EPERM;

	return ovl_create_object(dentry, mode, rdev, NULL);
}

static int ovl_symlink(struct inode *dir, struct dentry *dentry,
		       const char *link)
{
	return ovl_create_object(dentry, S_IFLNK, 0, link);
}

static int ovl_link(struct dentry *old, struct inode *newdir,
		    struct dentry *new)
{
	int err;
M
Miklos Szeredi 已提交
655
	struct inode *inode;
M
Miklos Szeredi 已提交
656 657 658 659 660 661 662 663 664

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

665 666 667 668
	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;

669 670 671 672 673 674
	if (ovl_is_metacopy_dentry(old)) {
		err = ovl_set_redirect(old, false);
		if (err)
			goto out_drop_write;
	}

675
	err = ovl_nlink_start(old);
676 677 678
	if (err)
		goto out_drop_write;

M
Miklos Szeredi 已提交
679 680 681
	inode = d_inode(old);
	ihold(inode);

A
Amir Goldstein 已提交
682 683 684
	err = ovl_create_or_link(new, inode,
			&(struct ovl_cattr) {.hardlink = ovl_dentry_upper(old)},
			ovl_type_origin(old));
M
Miklos Szeredi 已提交
685 686
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
687

688
	ovl_nlink_end(old);
M
Miklos Szeredi 已提交
689 690 691 692 693 694
out_drop_write:
	ovl_drop_write(old);
out:
	return err;
}

M
Miklos Szeredi 已提交
695 696 697 698 699
static bool ovl_matches_upper(struct dentry *dentry, struct dentry *upper)
{
	return d_inode(ovl_dentry_upper(dentry)) == d_inode(upper);
}

700 701
static int ovl_remove_and_whiteout(struct dentry *dentry,
				   struct list_head *list)
M
Miklos Szeredi 已提交
702 703 704 705 706 707 708
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct dentry *upper;
	struct dentry *opaquedir = NULL;
	int err;

709 710 711
	if (WARN_ON(!workdir))
		return -EROFS;

712 713
	if (!list_empty(list)) {
		opaquedir = ovl_clear_empty(dentry, list);
M
Miklos Szeredi 已提交
714 715 716
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
M
Miklos Szeredi 已提交
717 718 719 720 721 722
	}

	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out_dput;

723 724 725 726
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
M
Miklos Szeredi 已提交
727 728
		goto out_unlock;

729 730 731
	err = -ESTALE;
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && ovl_dentry_upper(dentry) &&
M
Miklos Szeredi 已提交
732
	     !ovl_matches_upper(dentry, upper))) {
733 734
		goto out_dput_upper;
	}
M
Miklos Szeredi 已提交
735

736
	err = ovl_cleanup_and_whiteout(workdir, d_inode(upperdir), upper);
737
	if (err)
738
		goto out_d_drop;
M
Miklos Szeredi 已提交
739

M
Miklos Szeredi 已提交
740
	ovl_dir_modified(dentry->d_parent, true);
M
Miklos Szeredi 已提交
741 742
out_d_drop:
	d_drop(dentry);
743 744
out_dput_upper:
	dput(upper);
M
Miklos Szeredi 已提交
745 746 747 748 749 750 751 752
out_unlock:
	unlock_rename(workdir, upperdir);
out_dput:
	dput(opaquedir);
out:
	return err;
}

753 754
static int ovl_remove_upper(struct dentry *dentry, bool is_dir,
			    struct list_head *list)
M
Miklos Szeredi 已提交
755 756 757
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *dir = upperdir->d_inode;
758
	struct dentry *upper;
759
	struct dentry *opaquedir = NULL;
M
Miklos Szeredi 已提交
760 761
	int err;

762 763
	if (!list_empty(list)) {
		opaquedir = ovl_clear_empty(dentry, list);
764 765 766 767 768
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
	}

A
Al Viro 已提交
769
	inode_lock_nested(dir, I_MUTEX_PARENT);
770 771 772 773 774 775
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_unlock;

M
Miklos Szeredi 已提交
776
	err = -ESTALE;
777
	if ((opaquedir && upper != opaquedir) ||
M
Miklos Szeredi 已提交
778
	    (!opaquedir && !ovl_matches_upper(dentry, upper)))
779 780 781 782 783 784
		goto out_dput_upper;

	if (is_dir)
		err = vfs_rmdir(dir, upper);
	else
		err = vfs_unlink(dir, upper, NULL);
M
Miklos Szeredi 已提交
785
	ovl_dir_modified(dentry->d_parent, ovl_type_origin(dentry));
M
Miklos Szeredi 已提交
786 787 788 789 790 791 792

	/*
	 * Keeping this dentry hashed would mean having to release
	 * upperpath/lowerpath, which could only be done if we are the
	 * sole user of this dentry.  Too tricky...  Just unhash for
	 * now.
	 */
793 794
	if (!err)
		d_drop(dentry);
795 796
out_dput_upper:
	dput(upper);
797
out_unlock:
A
Al Viro 已提交
798
	inode_unlock(dir);
799 800
	dput(opaquedir);
out:
M
Miklos Szeredi 已提交
801 802 803
	return err;
}

804 805 806 807 808 809
static bool ovl_pure_upper(struct dentry *dentry)
{
	return !ovl_dentry_lower(dentry) &&
	       !ovl_test_flag(OVL_WHITEOUTS, d_inode(dentry));
}

M
Miklos Szeredi 已提交
810 811 812
static int ovl_do_remove(struct dentry *dentry, bool is_dir)
{
	int err;
813
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
814
	struct dentry *upperdentry;
815 816 817 818 819 820 821 822 823
	bool lower_positive = ovl_lower_positive(dentry);
	LIST_HEAD(list);

	/* No need to clean pure upper removed by vfs_rmdir() */
	if (is_dir && (lower_positive || !ovl_pure_upper(dentry))) {
		err = ovl_check_empty_dir(dentry, &list);
		if (err)
			goto out;
	}
824

M
Miklos Szeredi 已提交
825 826 827 828 829 830 831 832
	err = ovl_want_write(dentry);
	if (err)
		goto out;

	err = ovl_copy_up(dentry->d_parent);
	if (err)
		goto out_drop_write;

833
	err = ovl_nlink_start(dentry);
834 835
	if (err)
		goto out_drop_write;
M
Miklos Szeredi 已提交
836

837
	old_cred = ovl_override_creds(dentry->d_sb);
838 839
	if (!lower_positive)
		err = ovl_remove_upper(dentry, is_dir, &list);
840
	else
841
		err = ovl_remove_and_whiteout(dentry, &list);
842
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
843 844 845 846 847 848
	if (!err) {
		if (is_dir)
			clear_nlink(dentry->d_inode);
		else
			drop_nlink(dentry->d_inode);
	}
849
	ovl_nlink_end(dentry);
M
Miklos Szeredi 已提交
850 851 852 853 854 855 856 857 858 859 860

	/*
	 * Copy ctime
	 *
	 * Note: we fail to update ctime if there was no copy-up, only a
	 * whiteout
	 */
	upperdentry = ovl_dentry_upper(dentry);
	if (upperdentry)
		ovl_copyattr(d_inode(upperdentry), d_inode(dentry));

M
Miklos Szeredi 已提交
861 862 863
out_drop_write:
	ovl_drop_write(dentry);
out:
864
	ovl_cache_free(&list);
M
Miklos Szeredi 已提交
865 866 867 868 869 870 871 872 873 874 875 876 877
	return err;
}

static int ovl_unlink(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, false);
}

static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, true);
}

878 879 880 881 882 883 884
static bool ovl_type_merge_or_lower(struct dentry *dentry)
{
	enum ovl_path_type type = ovl_path_type(dentry);

	return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
}

M
Miklos Szeredi 已提交
885 886 887 888 889 890
static bool ovl_can_move(struct dentry *dentry)
{
	return ovl_redirect_dir(dentry->d_sb) ||
		!d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
}

891
static char *ovl_get_redirect(struct dentry *dentry, bool abs_redirect)
M
Miklos Szeredi 已提交
892 893 894
{
	char *buf, *ret;
	struct dentry *d, *tmp;
895
	int buflen = ovl_redirect_max + 1;
M
Miklos Szeredi 已提交
896

897
	if (!abs_redirect) {
M
Miklos Szeredi 已提交
898 899 900 901 902
		ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
			       GFP_KERNEL);
		goto out;
	}

903
	buf = ret = kmalloc(buflen, GFP_KERNEL);
M
Miklos Szeredi 已提交
904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950
	if (!buf)
		goto out;

	buflen--;
	buf[buflen] = '\0';
	for (d = dget(dentry); !IS_ROOT(d);) {
		const char *name;
		int thislen;

		spin_lock(&d->d_lock);
		name = ovl_dentry_get_redirect(d);
		if (name) {
			thislen = strlen(name);
		} else {
			name = d->d_name.name;
			thislen = d->d_name.len;
		}

		/* If path is too long, fall back to userspace move */
		if (thislen + (name[0] != '/') > buflen) {
			ret = ERR_PTR(-EXDEV);
			spin_unlock(&d->d_lock);
			goto out_put;
		}

		buflen -= thislen;
		memcpy(&buf[buflen], name, thislen);
		tmp = dget_dlock(d->d_parent);
		spin_unlock(&d->d_lock);

		dput(d);
		d = tmp;

		/* Absolute redirect: finished */
		if (buf[buflen] == '/')
			break;
		buflen--;
		buf[buflen] = '/';
	}
	ret = kstrdup(&buf[buflen], GFP_KERNEL);
out_put:
	dput(d);
	kfree(buf);
out:
	return ret ? ret : ERR_PTR(-ENOMEM);
}

951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977
static bool ovl_need_absolute_redirect(struct dentry *dentry, bool samedir)
{
	struct dentry *lowerdentry;

	if (!samedir)
		return true;

	if (d_is_dir(dentry))
		return false;

	/*
	 * For non-dir hardlinked files, we need absolute redirects
	 * in general as two upper hardlinks could be in different
	 * dirs. We could put a relative redirect now and convert
	 * it to absolute redirect later. But when nlink > 1 and
	 * indexing is on, that means relative redirect needs to be
	 * converted to absolute during copy up of another lower
	 * hardllink as well.
	 *
	 * So without optimizing too much, just check if lower is
	 * a hard link or not. If lower is hard link, put absolute
	 * redirect.
	 */
	lowerdentry = ovl_dentry_lower(dentry);
	return (d_inode(lowerdentry)->i_nlink > 1);
}

M
Miklos Szeredi 已提交
978 979 980 981
static int ovl_set_redirect(struct dentry *dentry, bool samedir)
{
	int err;
	const char *redirect = ovl_dentry_get_redirect(dentry);
982
	bool absolute_redirect = ovl_need_absolute_redirect(dentry, samedir);
M
Miklos Szeredi 已提交
983

984
	if (redirect && (!absolute_redirect || redirect[0] == '/'))
M
Miklos Szeredi 已提交
985 986
		return 0;

987
	redirect = ovl_get_redirect(dentry, absolute_redirect);
M
Miklos Szeredi 已提交
988 989 990
	if (IS_ERR(redirect))
		return PTR_ERR(redirect);

991 992 993
	err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
				 OVL_XATTR_REDIRECT,
				 redirect, strlen(redirect), -EXDEV);
M
Miklos Szeredi 已提交
994 995 996 997 998 999
	if (!err) {
		spin_lock(&dentry->d_lock);
		ovl_dentry_set_redirect(dentry, redirect);
		spin_unlock(&dentry->d_lock);
	} else {
		kfree(redirect);
A
Amir Goldstein 已提交
1000 1001
		pr_warn_ratelimited("overlayfs: failed to set redirect (%i)\n",
				    err);
M
Miklos Szeredi 已提交
1002 1003 1004 1005 1006 1007
		/* Fall back to userspace copy-up */
		err = -EXDEV;
	}
	return err;
}

1008 1009 1010
static int ovl_rename(struct inode *olddir, struct dentry *old,
		      struct inode *newdir, struct dentry *new,
		      unsigned int flags)
M
Miklos Szeredi 已提交
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
{
	int err;
	struct dentry *old_upperdir;
	struct dentry *new_upperdir;
	struct dentry *olddentry;
	struct dentry *newdentry;
	struct dentry *trap;
	bool old_opaque;
	bool new_opaque;
	bool cleanup_whiteout = false;
1021
	bool update_nlink = false;
M
Miklos Szeredi 已提交
1022
	bool overwrite = !(flags & RENAME_EXCHANGE);
1023
	bool is_dir = d_is_dir(old);
1024
	bool new_is_dir = d_is_dir(new);
M
Miklos Szeredi 已提交
1025
	bool samedir = olddir == newdir;
M
Miklos Szeredi 已提交
1026 1027
	struct dentry *opaquedir = NULL;
	const struct cred *old_cred = NULL;
1028
	LIST_HEAD(list);
M
Miklos Szeredi 已提交
1029 1030 1031 1032 1033 1034 1035 1036 1037

	err = -EINVAL;
	if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
		goto out;

	flags &= ~RENAME_NOREPLACE;

	/* Don't copy up directory trees */
	err = -EXDEV;
M
Miklos Szeredi 已提交
1038
	if (!ovl_can_move(old))
1039
		goto out;
M
Miklos Szeredi 已提交
1040
	if (!overwrite && !ovl_can_move(new))
M
Miklos Szeredi 已提交
1041 1042
		goto out;

1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
	if (overwrite && new_is_dir && !ovl_pure_upper(new)) {
		err = ovl_check_empty_dir(new, &list);
		if (err)
			goto out;
	}

	if (overwrite) {
		if (ovl_lower_positive(old)) {
			if (!ovl_dentry_is_whiteout(new)) {
				/* Whiteout source */
				flags |= RENAME_WHITEOUT;
			} else {
				/* Switch whiteouts */
				flags |= RENAME_EXCHANGE;
			}
		} else if (is_dir && ovl_dentry_is_whiteout(new)) {
			flags |= RENAME_EXCHANGE;
			cleanup_whiteout = true;
		}
	}

M
Miklos Szeredi 已提交
1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;
	if (!overwrite) {
		err = ovl_copy_up(new);
		if (err)
			goto out_drop_write;
1079 1080
	} else if (d_inode(new)) {
		err = ovl_nlink_start(new);
1081 1082
		if (err)
			goto out_drop_write;
1083 1084

		update_nlink = true;
M
Miklos Szeredi 已提交
1085 1086
	}

1087
	old_cred = ovl_override_creds(old->d_sb);
M
Miklos Szeredi 已提交
1088

1089 1090
	if (!list_empty(&list)) {
		opaquedir = ovl_clear_empty(new, &list);
M
Miklos Szeredi 已提交
1091 1092 1093 1094 1095 1096 1097 1098 1099 1100
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir)) {
			opaquedir = NULL;
			goto out_revert_creds;
		}
	}

	old_upperdir = ovl_dentry_upper(old->d_parent);
	new_upperdir = ovl_dentry_upper(new->d_parent);

1101 1102 1103
	if (!samedir) {
		/*
		 * When moving a merge dir or non-dir with copy up origin into
1104 1105 1106
		 * a new parent, we are marking the new parent dir "impure".
		 * When ovl_iterate() iterates an "impure" upper dir, it will
		 * lookup the origin inodes of the entries to fill d_ino.
1107
		 */
1108
		if (ovl_type_origin(old)) {
1109 1110 1111 1112
			err = ovl_set_impure(new->d_parent, new_upperdir);
			if (err)
				goto out_revert_creds;
		}
1113
		if (!overwrite && ovl_type_origin(new)) {
1114 1115 1116 1117 1118 1119
			err = ovl_set_impure(old->d_parent, old_upperdir);
			if (err)
				goto out_revert_creds;
		}
	}

M
Miklos Szeredi 已提交
1120 1121
	trap = lock_rename(new_upperdir, old_upperdir);

1122 1123 1124 1125 1126 1127 1128
	olddentry = lookup_one_len(old->d_name.name, old_upperdir,
				   old->d_name.len);
	err = PTR_ERR(olddentry);
	if (IS_ERR(olddentry))
		goto out_unlock;

	err = -ESTALE;
M
Miklos Szeredi 已提交
1129
	if (!ovl_matches_upper(old, olddentry))
1130 1131 1132 1133 1134 1135 1136 1137
		goto out_dput_old;

	newdentry = lookup_one_len(new->d_name.name, new_upperdir,
				   new->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput_old;

1138 1139 1140
	old_opaque = ovl_dentry_is_opaque(old);
	new_opaque = ovl_dentry_is_opaque(new);

1141
	err = -ESTALE;
1142
	if (d_inode(new) && ovl_dentry_upper(new)) {
M
Miklos Szeredi 已提交
1143
		if (opaquedir) {
1144 1145
			if (newdentry != opaquedir)
				goto out_dput;
M
Miklos Szeredi 已提交
1146
		} else {
M
Miklos Szeredi 已提交
1147
			if (!ovl_matches_upper(new, newdentry))
1148
				goto out_dput;
M
Miklos Szeredi 已提交
1149 1150
		}
	} else {
1151 1152 1153
		if (!d_is_negative(newdentry) &&
		    (!new_opaque || !ovl_is_whiteout(newdentry)))
			goto out_dput;
M
Miklos Szeredi 已提交
1154 1155 1156 1157 1158 1159 1160
	}

	if (olddentry == trap)
		goto out_dput;
	if (newdentry == trap)
		goto out_dput;

M
Miklos Szeredi 已提交
1161 1162 1163
	if (WARN_ON(olddentry->d_inode == newdentry->d_inode))
		goto out_dput;

M
Miklos Szeredi 已提交
1164
	err = 0;
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178
	if (ovl_type_merge_or_lower(old))
		err = ovl_set_redirect(old, samedir);
	else if (is_dir && !old_opaque && ovl_type_merge(new->d_parent))
		err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
	if (err)
		goto out_dput;

	if (!overwrite && ovl_type_merge_or_lower(new))
		err = ovl_set_redirect(new, samedir);
	else if (!overwrite && new_is_dir && !new_opaque &&
		 ovl_type_merge(old->d_parent))
		err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
	if (err)
		goto out_dput;
M
Miklos Szeredi 已提交
1179

1180 1181 1182
	err = ovl_do_rename(old_upperdir->d_inode, olddentry,
			    new_upperdir->d_inode, newdentry, flags);
	if (err)
M
Miklos Szeredi 已提交
1183 1184 1185 1186 1187
		goto out_dput;

	if (cleanup_whiteout)
		ovl_cleanup(old_upperdir->d_inode, newdentry);

1188 1189 1190 1191 1192 1193 1194
	if (overwrite && d_inode(new)) {
		if (new_is_dir)
			clear_nlink(d_inode(new));
		else
			drop_nlink(d_inode(new));
	}

M
Miklos Szeredi 已提交
1195 1196 1197 1198 1199 1200 1201 1202 1203
	ovl_dir_modified(old->d_parent, ovl_type_origin(old) ||
			 (!overwrite && ovl_type_origin(new)));
	ovl_dir_modified(new->d_parent, ovl_type_origin(old) ||
			 (d_inode(new) && ovl_type_origin(new)));

	/* copy ctime: */
	ovl_copyattr(d_inode(olddentry), d_inode(old));
	if (d_inode(new) && ovl_dentry_upper(new))
		ovl_copyattr(d_inode(newdentry), d_inode(new));
M
Miklos Szeredi 已提交
1204 1205 1206

out_dput:
	dput(newdentry);
1207 1208
out_dput_old:
	dput(olddentry);
M
Miklos Szeredi 已提交
1209 1210 1211
out_unlock:
	unlock_rename(new_upperdir, old_upperdir);
out_revert_creds:
1212
	revert_creds(old_cred);
1213 1214
	if (update_nlink)
		ovl_nlink_end(new);
M
Miklos Szeredi 已提交
1215 1216 1217 1218
out_drop_write:
	ovl_drop_write(old);
out:
	dput(opaquedir);
1219
	ovl_cache_free(&list);
M
Miklos Szeredi 已提交
1220 1221 1222 1223 1224 1225 1226 1227 1228
	return err;
}

const struct inode_operations ovl_dir_inode_operations = {
	.lookup		= ovl_lookup,
	.mkdir		= ovl_mkdir,
	.symlink	= ovl_symlink,
	.unlink		= ovl_unlink,
	.rmdir		= ovl_rmdir,
1229
	.rename		= ovl_rename,
M
Miklos Szeredi 已提交
1230 1231 1232 1233 1234
	.link		= ovl_link,
	.setattr	= ovl_setattr,
	.create		= ovl_create,
	.mknod		= ovl_mknod,
	.permission	= ovl_permission,
1235
	.getattr	= ovl_getattr,
M
Miklos Szeredi 已提交
1236
	.listxattr	= ovl_listxattr,
1237
	.get_acl	= ovl_get_acl,
M
Miklos Szeredi 已提交
1238
	.update_time	= ovl_update_time,
M
Miklos Szeredi 已提交
1239
};