dir.c 24.3 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14
/*
 *
 * Copyright (C) 2011 Novell Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/cred.h>
15
#include <linux/module.h>
16 17
#include <linux/posix_acl.h>
#include <linux/posix_acl_xattr.h>
18
#include <linux/atomic.h>
M
Miklos Szeredi 已提交
19
#include <linux/ratelimit.h>
M
Miklos Szeredi 已提交
20 21
#include "overlayfs.h"

22 23 24 25 26
static unsigned short ovl_redirect_max = 256;
module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
MODULE_PARM_DESC(ovl_redirect_max,
		 "Maximum length of absolute redirect xattr value");

M
Miklos Szeredi 已提交
27 28 29 30 31
void ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
{
	int err;

	dget(wdentry);
32
	if (d_is_dir(wdentry))
M
Miklos Szeredi 已提交
33 34 35 36 37 38 39 40 41 42 43
		err = ovl_do_rmdir(wdir, wdentry);
	else
		err = ovl_do_unlink(wdir, wdentry);
	dput(wdentry);

	if (err) {
		pr_err("overlayfs: cleanup of '%pd2' failed (%i)\n",
		       wdentry, err);
	}
}

44
struct dentry *ovl_lookup_temp(struct dentry *workdir)
M
Miklos Szeredi 已提交
45 46 47
{
	struct dentry *temp;
	char name[20];
48
	static atomic_t temp_id = ATOMIC_INIT(0);
M
Miklos Szeredi 已提交
49

50 51
	/* counter is allowed to wrap, since temp dentries are ephemeral */
	snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
M
Miklos Szeredi 已提交
52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70

	temp = lookup_one_len(name, workdir, strlen(name));
	if (!IS_ERR(temp) && temp->d_inode) {
		pr_err("overlayfs: workdir/%s already exists\n", name);
		dput(temp);
		temp = ERR_PTR(-EIO);
	}

	return temp;
}

/* caller holds i_mutex on workdir */
static struct dentry *ovl_whiteout(struct dentry *workdir,
				   struct dentry *dentry)
{
	int err;
	struct dentry *whiteout;
	struct inode *wdir = workdir->d_inode;

71
	whiteout = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
72 73 74 75 76 77 78 79 80 81 82 83 84
	if (IS_ERR(whiteout))
		return whiteout;

	err = ovl_do_whiteout(wdir, whiteout);
	if (err) {
		dput(whiteout);
		whiteout = ERR_PTR(err);
	}

	return whiteout;
}

int ovl_create_real(struct inode *dir, struct dentry *newdentry,
A
Al Viro 已提交
85
		    struct cattr *attr, struct dentry *hardlink, bool debug)
M
Miklos Szeredi 已提交
86 87 88 89 90 91 92 93 94
{
	int err;

	if (newdentry->d_inode)
		return -ESTALE;

	if (hardlink) {
		err = ovl_do_link(hardlink, dir, newdentry, debug);
	} else {
A
Al Viro 已提交
95
		switch (attr->mode & S_IFMT) {
M
Miklos Szeredi 已提交
96
		case S_IFREG:
A
Al Viro 已提交
97
			err = ovl_do_create(dir, newdentry, attr->mode, debug);
M
Miklos Szeredi 已提交
98 99 100
			break;

		case S_IFDIR:
A
Al Viro 已提交
101
			err = ovl_do_mkdir(dir, newdentry, attr->mode, debug);
M
Miklos Szeredi 已提交
102 103 104 105 106 107 108
			break;

		case S_IFCHR:
		case S_IFBLK:
		case S_IFIFO:
		case S_IFSOCK:
			err = ovl_do_mknod(dir, newdentry,
A
Al Viro 已提交
109
					   attr->mode, attr->rdev, debug);
M
Miklos Szeredi 已提交
110 111 112
			break;

		case S_IFLNK:
A
Al Viro 已提交
113
			err = ovl_do_symlink(dir, newdentry, attr->link, debug);
M
Miklos Szeredi 已提交
114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129
			break;

		default:
			err = -EPERM;
		}
	}
	if (!err && WARN_ON(!newdentry->d_inode)) {
		/*
		 * Not quite sure if non-instantiated dentry is legal or not.
		 * VFS doesn't seem to care so check and warn here.
		 */
		err = -ENOENT;
	}
	return err;
}

130 131
static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
			       int xerr)
M
Miklos Szeredi 已提交
132
{
M
Miklos Szeredi 已提交
133 134
	int err;

135
	err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
M
Miklos Szeredi 已提交
136 137 138 139
	if (!err)
		ovl_dentry_set_opaque(dentry);

	return err;
M
Miklos Szeredi 已提交
140 141
}

142 143 144 145 146 147 148 149 150 151
static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
{
	/*
	 * Fail with -EIO when trying to create opaque dir and upper doesn't
	 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
	 * return a specific error for noxattr case.
	 */
	return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
}

152 153
/* Common operations required to be done after creation of file on upper */
static void ovl_instantiate(struct dentry *dentry, struct inode *inode,
M
Miklos Szeredi 已提交
154
			    struct dentry *newdentry, bool hardlink)
155 156 157
{
	ovl_dentry_version_inc(dentry->d_parent);
	ovl_dentry_update(dentry, newdentry);
M
Miklos Szeredi 已提交
158 159 160 161 162 163 164
	if (!hardlink) {
		ovl_inode_update(inode, d_inode(newdentry));
		ovl_copyattr(newdentry->d_inode, inode);
	} else {
		WARN_ON(ovl_inode_real(inode, NULL) != d_inode(newdentry));
		inc_nlink(inode);
	}
165
	d_instantiate(dentry, inode);
166 167 168
	/* Force lookup of new upper hardlink to find its lower */
	if (hardlink)
		d_drop(dentry);
169 170
}

171 172 173 174 175
static bool ovl_type_merge(struct dentry *dentry)
{
	return OVL_TYPE_MERGE(ovl_path_type(dentry));
}

176 177 178 179 180
static bool ovl_type_origin(struct dentry *dentry)
{
	return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
}

M
Miklos Szeredi 已提交
181
static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
182
			    struct cattr *attr, struct dentry *hardlink)
M
Miklos Szeredi 已提交
183 184 185 186 187 188
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *newdentry;
	int err;

189
	if (!hardlink && !IS_POSIXACL(udir))
A
Al Viro 已提交
190
		attr->mode &= ~current_umask();
191

A
Al Viro 已提交
192
	inode_lock_nested(udir, I_MUTEX_PARENT);
M
Miklos Szeredi 已提交
193 194 195 196 197
	newdentry = lookup_one_len(dentry->d_name.name, upperdir,
				   dentry->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;
A
Al Viro 已提交
198
	err = ovl_create_real(udir, newdentry, attr, hardlink, false);
M
Miklos Szeredi 已提交
199 200 201
	if (err)
		goto out_dput;

202
	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
203 204 205 206
		/* Setting opaque here is just an optimization, allow to fail */
		ovl_set_opaque(dentry, newdentry);
	}

M
Miklos Szeredi 已提交
207
	ovl_instantiate(dentry, inode, newdentry, !!hardlink);
M
Miklos Szeredi 已提交
208 209 210 211
	newdentry = NULL;
out_dput:
	dput(newdentry);
out_unlock:
A
Al Viro 已提交
212
	inode_unlock(udir);
M
Miklos Szeredi 已提交
213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248
	return err;
}

static int ovl_lock_rename_workdir(struct dentry *workdir,
				   struct dentry *upperdir)
{
	/* Workdir should not be the same as upperdir */
	if (workdir == upperdir)
		goto err;

	/* Workdir should not be subdir of upperdir and vice versa */
	if (lock_rename(workdir, upperdir) != NULL)
		goto err_unlock;

	return 0;

err_unlock:
	unlock_rename(workdir, upperdir);
err:
	pr_err("overlayfs: failed to lock workdir+upperdir\n");
	return -EIO;
}

static struct dentry *ovl_clear_empty(struct dentry *dentry,
				      struct list_head *list)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct path upperpath;
	struct dentry *upper;
	struct dentry *opaquedir;
	struct kstat stat;
	int err;

249 250 251
	if (WARN_ON(!workdir))
		return ERR_PTR(-EROFS);

M
Miklos Szeredi 已提交
252 253 254 255 256
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	ovl_path_upper(dentry, &upperpath);
257 258
	err = vfs_getattr(&upperpath, &stat,
			  STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
M
Miklos Szeredi 已提交
259 260 261 262 263 264 265 266 267 268
	if (err)
		goto out_unlock;

	err = -ESTALE;
	if (!S_ISDIR(stat.mode))
		goto out_unlock;
	upper = upperpath.dentry;
	if (upper->d_parent->d_inode != udir)
		goto out_unlock;

269
	opaquedir = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
270 271 272 273
	err = PTR_ERR(opaquedir);
	if (IS_ERR(opaquedir))
		goto out_unlock;

A
Al Viro 已提交
274 275
	err = ovl_create_real(wdir, opaquedir,
			      &(struct cattr){.mode = stat.mode}, NULL, true);
M
Miklos Szeredi 已提交
276 277 278 279 280 281 282
	if (err)
		goto out_dput;

	err = ovl_copy_xattr(upper, opaquedir);
	if (err)
		goto out_cleanup;

M
Miklos Szeredi 已提交
283
	err = ovl_set_opaque(dentry, opaquedir);
M
Miklos Szeredi 已提交
284 285 286
	if (err)
		goto out_cleanup;

A
Al Viro 已提交
287
	inode_lock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
288
	err = ovl_set_attr(opaquedir, &stat);
A
Al Viro 已提交
289
	inode_unlock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315
	if (err)
		goto out_cleanup;

	err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
	if (err)
		goto out_cleanup;

	ovl_cleanup_whiteouts(upper, list);
	ovl_cleanup(wdir, upper);
	unlock_rename(workdir, upperdir);

	/* dentry's upper doesn't match now, get rid of it */
	d_drop(dentry);

	return opaquedir;

out_cleanup:
	ovl_cleanup(wdir, opaquedir);
out_dput:
	dput(opaquedir);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
	return ERR_PTR(err);
}

M
Miklos Szeredi 已提交
316
static struct dentry *ovl_check_empty_and_clear(struct dentry *dentry)
M
Miklos Szeredi 已提交
317 318 319
{
	int err;
	struct dentry *ret = NULL;
M
Miklos Szeredi 已提交
320
	enum ovl_path_type type = ovl_path_type(dentry);
M
Miklos Szeredi 已提交
321 322 323
	LIST_HEAD(list);

	err = ovl_check_empty_dir(dentry, &list);
M
Miklos Szeredi 已提交
324
	if (err) {
M
Miklos Szeredi 已提交
325
		ret = ERR_PTR(err);
M
Miklos Szeredi 已提交
326
		goto out_free;
M
Miklos Szeredi 已提交
327
	}
M
Miklos Szeredi 已提交
328

M
Miklos Szeredi 已提交
329 330 331 332 333 334 335 336 337 338 339 340 341 342
	/*
	 * When removing an empty opaque directory, then it makes no sense to
	 * replace it with an exact replica of itself.
	 *
	 * If no upperdentry then skip clearing whiteouts.
	 *
	 * Can race with copy-up, since we don't hold the upperdir mutex.
	 * Doesn't matter, since copy-up can't create a non-empty directory
	 * from an empty one.
	 */
	if (OVL_TYPE_UPPER(type) && OVL_TYPE_MERGE(type))
		ret = ovl_clear_empty(dentry, &list);

out_free:
M
Miklos Szeredi 已提交
343 344 345 346 347
	ovl_cache_free(&list);

	return ret;
}

348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
			     const struct posix_acl *acl)
{
	void *buffer;
	size_t size;
	int err;

	if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
		return 0;

	size = posix_acl_to_xattr(NULL, acl, NULL, 0);
	buffer = kmalloc(size, GFP_KERNEL);
	if (!buffer)
		return -ENOMEM;

	size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
	err = size;
	if (err < 0)
		goto out_free;

	err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
out_free:
	kfree(buffer);
	return err;
}

M
Miklos Szeredi 已提交
374
static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
375
				    struct cattr *cattr,
M
Miklos Szeredi 已提交
376 377 378 379 380 381 382 383 384
				    struct dentry *hardlink)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *upper;
	struct dentry *newdentry;
	int err;
385
	struct posix_acl *acl, *default_acl;
M
Miklos Szeredi 已提交
386

387 388 389
	if (WARN_ON(!workdir))
		return -EROFS;

390 391
	if (!hardlink) {
		err = posix_acl_create(dentry->d_parent->d_inode,
A
Al Viro 已提交
392
				       &cattr->mode, &default_acl, &acl);
393 394 395 396
		if (err)
			return err;
	}

M
Miklos Szeredi 已提交
397 398 399 400
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

401
	newdentry = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
402 403 404 405 406 407 408 409 410 411
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;

	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_dput;

A
Al Viro 已提交
412
	err = ovl_create_real(wdir, newdentry, cattr, hardlink, true);
M
Miklos Szeredi 已提交
413 414 415
	if (err)
		goto out_dput2;

M
Miklos Szeredi 已提交
416 417 418
	/*
	 * mode could have been mutilated due to umask (e.g. sgid directory)
	 */
M
Miklos Szeredi 已提交
419
	if (!hardlink &&
A
Al Viro 已提交
420 421
	    !S_ISLNK(cattr->mode) &&
	    newdentry->d_inode->i_mode != cattr->mode) {
M
Miklos Szeredi 已提交
422 423
		struct iattr attr = {
			.ia_valid = ATTR_MODE,
A
Al Viro 已提交
424
			.ia_mode = cattr->mode,
M
Miklos Szeredi 已提交
425 426 427 428 429 430 431
		};
		inode_lock(newdentry->d_inode);
		err = notify_change(newdentry, &attr, NULL);
		inode_unlock(newdentry->d_inode);
		if (err)
			goto out_cleanup;
	}
432 433 434 435 436 437 438 439 440 441 442
	if (!hardlink) {
		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
					acl);
		if (err)
			goto out_cleanup;

		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
					default_acl);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
443

A
Al Viro 已提交
444
	if (!hardlink && S_ISDIR(cattr->mode)) {
M
Miklos Szeredi 已提交
445
		err = ovl_set_opaque(dentry, newdentry);
M
Miklos Szeredi 已提交
446 447 448 449 450 451 452 453 454 455 456 457 458 459
		if (err)
			goto out_cleanup;

		err = ovl_do_rename(wdir, newdentry, udir, upper,
				    RENAME_EXCHANGE);
		if (err)
			goto out_cleanup;

		ovl_cleanup(wdir, upper);
	} else {
		err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
460
	ovl_instantiate(dentry, inode, newdentry, !!hardlink);
M
Miklos Szeredi 已提交
461 462 463 464 465 466 467 468
	newdentry = NULL;
out_dput2:
	dput(upper);
out_dput:
	dput(newdentry);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
469 470 471 472
	if (!hardlink) {
		posix_acl_release(acl);
		posix_acl_release(default_acl);
	}
M
Miklos Szeredi 已提交
473 474 475 476 477 478 479
	return err;

out_cleanup:
	ovl_cleanup(wdir, newdentry);
	goto out_dput2;
}

M
Miklos Szeredi 已提交
480
static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
481
			      struct cattr *attr, struct dentry *hardlink)
M
Miklos Szeredi 已提交
482 483
{
	int err;
484 485
	const struct cred *old_cred;
	struct cred *override_cred;
M
Miklos Szeredi 已提交
486 487 488

	err = ovl_copy_up(dentry->d_parent);
	if (err)
M
Miklos Szeredi 已提交
489
		return err;
M
Miklos Szeredi 已提交
490

491 492 493 494
	old_cred = ovl_override_creds(dentry->d_sb);
	err = -ENOMEM;
	override_cred = prepare_creds();
	if (override_cred) {
M
Miklos Szeredi 已提交
495 496
		override_cred->fsuid = inode->i_uid;
		override_cred->fsgid = inode->i_gid;
497 498
		if (!hardlink) {
			err = security_dentry_create_files_as(dentry,
A
Al Viro 已提交
499
					attr->mode, &dentry->d_name, old_cred,
500 501 502 503 504 505
					override_cred);
			if (err) {
				put_cred(override_cred);
				goto out_revert_creds;
			}
		}
506 507 508
		put_cred(override_creds(override_cred));
		put_cred(override_cred);

M
Miklos Szeredi 已提交
509
		if (!ovl_dentry_is_whiteout(dentry))
A
Al Viro 已提交
510
			err = ovl_create_upper(dentry, inode, attr,
511 512
						hardlink);
		else
A
Al Viro 已提交
513 514
			err = ovl_create_over_whiteout(dentry, inode, attr,
							hardlink);
M
Miklos Szeredi 已提交
515
	}
516
out_revert_creds:
517
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
518 519 520 521 522 523 524
	if (!err) {
		struct inode *realinode = d_inode(ovl_dentry_upper(dentry));

		WARN_ON(inode->i_mode != realinode->i_mode);
		WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid));
		WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid));
	}
M
Miklos Szeredi 已提交
525 526 527 528 529 530 531
	return err;
}

static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
			     const char *link)
{
	int err;
M
Miklos Szeredi 已提交
532
	struct inode *inode;
A
Al Viro 已提交
533
	struct cattr attr = {
M
Miklos Szeredi 已提交
534
		.rdev = rdev,
A
Al Viro 已提交
535
		.link = link,
M
Miklos Szeredi 已提交
536
	};
M
Miklos Szeredi 已提交
537 538

	err = ovl_want_write(dentry);
M
Miklos Szeredi 已提交
539 540 541 542
	if (err)
		goto out;

	err = -ENOMEM;
543
	inode = ovl_new_inode(dentry->d_sb, mode, rdev);
M
Miklos Szeredi 已提交
544 545 546 547
	if (!inode)
		goto out_drop_write;

	inode_init_owner(inode, dentry->d_parent->d_inode, mode);
A
Al Viro 已提交
548
	attr.mode = inode->i_mode;
M
Miklos Szeredi 已提交
549

A
Al Viro 已提交
550
	err = ovl_create_or_link(dentry, inode, &attr, NULL);
M
Miklos Szeredi 已提交
551 552
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
553

M
Miklos Szeredi 已提交
554 555 556
out_drop_write:
	ovl_drop_write(dentry);
out:
M
Miklos Szeredi 已提交
557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590
	return err;
}

static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
		      bool excl)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
}

static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
}

static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
		     dev_t rdev)
{
	/* Don't allow creation of "whiteout" on overlay */
	if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
		return -EPERM;

	return ovl_create_object(dentry, mode, rdev, NULL);
}

static int ovl_symlink(struct inode *dir, struct dentry *dentry,
		       const char *link)
{
	return ovl_create_object(dentry, S_IFLNK, 0, link);
}

static int ovl_link(struct dentry *old, struct inode *newdir,
		    struct dentry *new)
{
	int err;
M
Miklos Szeredi 已提交
591
	struct inode *inode;
M
Miklos Szeredi 已提交
592 593 594 595 596 597 598 599 600

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

M
Miklos Szeredi 已提交
601 602 603
	inode = d_inode(old);
	ihold(inode);

A
Al Viro 已提交
604
	err = ovl_create_or_link(new, inode, NULL, ovl_dentry_upper(old));
M
Miklos Szeredi 已提交
605 606
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
607 608 609 610 611 612 613

out_drop_write:
	ovl_drop_write(old);
out:
	return err;
}

M
Miklos Szeredi 已提交
614
static int ovl_remove_and_whiteout(struct dentry *dentry, bool is_dir)
M
Miklos Szeredi 已提交
615 616 617 618 619 620 621 622 623
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *whiteout;
	struct dentry *upper;
	struct dentry *opaquedir = NULL;
	int err;
624
	int flags = 0;
M
Miklos Szeredi 已提交
625

626 627 628
	if (WARN_ON(!workdir))
		return -EROFS;

629
	if (is_dir) {
M
Miklos Szeredi 已提交
630 631 632 633
		opaquedir = ovl_check_empty_and_clear(dentry);
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
M
Miklos Szeredi 已提交
634 635 636 637 638 639
	}

	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out_dput;

640 641 642 643
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
M
Miklos Szeredi 已提交
644 645
		goto out_unlock;

646 647 648 649 650 651
	err = -ESTALE;
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && ovl_dentry_upper(dentry) &&
	     upper != ovl_dentry_upper(dentry))) {
		goto out_dput_upper;
	}
M
Miklos Szeredi 已提交
652

653 654 655 656
	whiteout = ovl_whiteout(workdir, dentry);
	err = PTR_ERR(whiteout);
	if (IS_ERR(whiteout))
		goto out_dput_upper;
M
Miklos Szeredi 已提交
657

658 659
	if (d_is_dir(upper))
		flags = RENAME_EXCHANGE;
M
Miklos Szeredi 已提交
660

661 662 663 664 665
	err = ovl_do_rename(wdir, whiteout, udir, upper, flags);
	if (err)
		goto kill_whiteout;
	if (flags)
		ovl_cleanup(wdir, upper);
M
Miklos Szeredi 已提交
666 667 668 669 670

	ovl_dentry_version_inc(dentry->d_parent);
out_d_drop:
	d_drop(dentry);
	dput(whiteout);
671 672
out_dput_upper:
	dput(upper);
M
Miklos Szeredi 已提交
673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688
out_unlock:
	unlock_rename(workdir, upperdir);
out_dput:
	dput(opaquedir);
out:
	return err;

kill_whiteout:
	ovl_cleanup(wdir, whiteout);
	goto out_d_drop;
}

static int ovl_remove_upper(struct dentry *dentry, bool is_dir)
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *dir = upperdir->d_inode;
689
	struct dentry *upper;
690
	struct dentry *opaquedir = NULL;
M
Miklos Szeredi 已提交
691 692
	int err;

693 694 695 696 697 698 699 700
	/* Redirect dir can be !ovl_lower_positive && OVL_TYPE_MERGE */
	if (is_dir && ovl_dentry_get_redirect(dentry)) {
		opaquedir = ovl_check_empty_and_clear(dentry);
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
	}

A
Al Viro 已提交
701
	inode_lock_nested(dir, I_MUTEX_PARENT);
702 703 704 705 706 707
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_unlock;

M
Miklos Szeredi 已提交
708
	err = -ESTALE;
709 710 711 712 713 714 715 716 717
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && upper != ovl_dentry_upper(dentry)))
		goto out_dput_upper;

	if (is_dir)
		err = vfs_rmdir(dir, upper);
	else
		err = vfs_unlink(dir, upper, NULL);
	ovl_dentry_version_inc(dentry->d_parent);
M
Miklos Szeredi 已提交
718 719 720 721 722 723 724

	/*
	 * Keeping this dentry hashed would mean having to release
	 * upperpath/lowerpath, which could only be done if we are the
	 * sole user of this dentry.  Too tricky...  Just unhash for
	 * now.
	 */
725 726
	if (!err)
		d_drop(dentry);
727 728
out_dput_upper:
	dput(upper);
729
out_unlock:
A
Al Viro 已提交
730
	inode_unlock(dir);
731 732
	dput(opaquedir);
out:
M
Miklos Szeredi 已提交
733 734 735 736 737 738 739
	return err;
}

static int ovl_do_remove(struct dentry *dentry, bool is_dir)
{
	enum ovl_path_type type;
	int err;
740 741
	const struct cred *old_cred;

M
Miklos Szeredi 已提交
742 743 744 745 746 747 748 749 750 751
	err = ovl_want_write(dentry);
	if (err)
		goto out;

	err = ovl_copy_up(dentry->d_parent);
	if (err)
		goto out_drop_write;

	type = ovl_path_type(dentry);

752
	old_cred = ovl_override_creds(dentry->d_sb);
753
	if (!ovl_lower_positive(dentry))
754 755
		err = ovl_remove_upper(dentry, is_dir);
	else
M
Miklos Szeredi 已提交
756
		err = ovl_remove_and_whiteout(dentry, is_dir);
757
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
758 759 760 761 762 763
	if (!err) {
		if (is_dir)
			clear_nlink(dentry->d_inode);
		else
			drop_nlink(dentry->d_inode);
	}
M
Miklos Szeredi 已提交
764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779
out_drop_write:
	ovl_drop_write(dentry);
out:
	return err;
}

static int ovl_unlink(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, false);
}

static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, true);
}

780 781 782 783 784 785 786
static bool ovl_type_merge_or_lower(struct dentry *dentry)
{
	enum ovl_path_type type = ovl_path_type(dentry);

	return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
}

M
Miklos Szeredi 已提交
787 788 789 790 791 792 793 794 795 796
static bool ovl_can_move(struct dentry *dentry)
{
	return ovl_redirect_dir(dentry->d_sb) ||
		!d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
}

static char *ovl_get_redirect(struct dentry *dentry, bool samedir)
{
	char *buf, *ret;
	struct dentry *d, *tmp;
797
	int buflen = ovl_redirect_max + 1;
M
Miklos Szeredi 已提交
798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864

	if (samedir) {
		ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
			       GFP_KERNEL);
		goto out;
	}

	buf = ret = kmalloc(buflen, GFP_TEMPORARY);
	if (!buf)
		goto out;

	buflen--;
	buf[buflen] = '\0';
	for (d = dget(dentry); !IS_ROOT(d);) {
		const char *name;
		int thislen;

		spin_lock(&d->d_lock);
		name = ovl_dentry_get_redirect(d);
		if (name) {
			thislen = strlen(name);
		} else {
			name = d->d_name.name;
			thislen = d->d_name.len;
		}

		/* If path is too long, fall back to userspace move */
		if (thislen + (name[0] != '/') > buflen) {
			ret = ERR_PTR(-EXDEV);
			spin_unlock(&d->d_lock);
			goto out_put;
		}

		buflen -= thislen;
		memcpy(&buf[buflen], name, thislen);
		tmp = dget_dlock(d->d_parent);
		spin_unlock(&d->d_lock);

		dput(d);
		d = tmp;

		/* Absolute redirect: finished */
		if (buf[buflen] == '/')
			break;
		buflen--;
		buf[buflen] = '/';
	}
	ret = kstrdup(&buf[buflen], GFP_KERNEL);
out_put:
	dput(d);
	kfree(buf);
out:
	return ret ? ret : ERR_PTR(-ENOMEM);
}

static int ovl_set_redirect(struct dentry *dentry, bool samedir)
{
	int err;
	const char *redirect = ovl_dentry_get_redirect(dentry);

	if (redirect && (samedir || redirect[0] == '/'))
		return 0;

	redirect = ovl_get_redirect(dentry, samedir);
	if (IS_ERR(redirect))
		return PTR_ERR(redirect);

865 866 867
	err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
				 OVL_XATTR_REDIRECT,
				 redirect, strlen(redirect), -EXDEV);
M
Miklos Szeredi 已提交
868 869 870 871 872 873
	if (!err) {
		spin_lock(&dentry->d_lock);
		ovl_dentry_set_redirect(dentry, redirect);
		spin_unlock(&dentry->d_lock);
	} else {
		kfree(redirect);
874
		pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
M
Miklos Szeredi 已提交
875 876 877 878 879 880
		/* Fall back to userspace copy-up */
		err = -EXDEV;
	}
	return err;
}

881 882 883
static int ovl_rename(struct inode *olddir, struct dentry *old,
		      struct inode *newdir, struct dentry *new,
		      unsigned int flags)
M
Miklos Szeredi 已提交
884 885 886 887 888 889 890 891 892 893 894
{
	int err;
	struct dentry *old_upperdir;
	struct dentry *new_upperdir;
	struct dentry *olddentry;
	struct dentry *newdentry;
	struct dentry *trap;
	bool old_opaque;
	bool new_opaque;
	bool cleanup_whiteout = false;
	bool overwrite = !(flags & RENAME_EXCHANGE);
895
	bool is_dir = d_is_dir(old);
896
	bool new_is_dir = d_is_dir(new);
M
Miklos Szeredi 已提交
897
	bool samedir = olddir == newdir;
M
Miklos Szeredi 已提交
898 899 900 901 902 903 904 905 906 907 908
	struct dentry *opaquedir = NULL;
	const struct cred *old_cred = NULL;

	err = -EINVAL;
	if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
		goto out;

	flags &= ~RENAME_NOREPLACE;

	/* Don't copy up directory trees */
	err = -EXDEV;
M
Miklos Szeredi 已提交
909
	if (!ovl_can_move(old))
910
		goto out;
M
Miklos Szeredi 已提交
911
	if (!overwrite && !ovl_can_move(new))
M
Miklos Szeredi 已提交
912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930
		goto out;

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;
	if (!overwrite) {
		err = ovl_copy_up(new);
		if (err)
			goto out_drop_write;
	}

931
	old_cred = ovl_override_creds(old->d_sb);
M
Miklos Szeredi 已提交
932

933
	if (overwrite && new_is_dir && ovl_type_merge_or_lower(new)) {
M
Miklos Szeredi 已提交
934
		opaquedir = ovl_check_empty_and_clear(new);
M
Miklos Szeredi 已提交
935 936 937 938 939 940 941 942
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir)) {
			opaquedir = NULL;
			goto out_revert_creds;
		}
	}

	if (overwrite) {
943
		if (ovl_lower_positive(old)) {
M
Miklos Szeredi 已提交
944
			if (!ovl_dentry_is_whiteout(new)) {
M
Miklos Szeredi 已提交
945 946 947 948 949 950
				/* Whiteout source */
				flags |= RENAME_WHITEOUT;
			} else {
				/* Switch whiteouts */
				flags |= RENAME_EXCHANGE;
			}
M
Miklos Szeredi 已提交
951
		} else if (is_dir && ovl_dentry_is_whiteout(new)) {
M
Miklos Szeredi 已提交
952 953 954 955 956 957 958 959
			flags |= RENAME_EXCHANGE;
			cleanup_whiteout = true;
		}
	}

	old_upperdir = ovl_dentry_upper(old->d_parent);
	new_upperdir = ovl_dentry_upper(new->d_parent);

960 961 962
	if (!samedir) {
		/*
		 * When moving a merge dir or non-dir with copy up origin into
963 964 965
		 * a new parent, we are marking the new parent dir "impure".
		 * When ovl_iterate() iterates an "impure" upper dir, it will
		 * lookup the origin inodes of the entries to fill d_ino.
966
		 */
967
		if (ovl_type_origin(old)) {
968 969 970 971
			err = ovl_set_impure(new->d_parent, new_upperdir);
			if (err)
				goto out_revert_creds;
		}
972
		if (!overwrite && ovl_type_origin(new)) {
973 974 975 976 977 978
			err = ovl_set_impure(old->d_parent, old_upperdir);
			if (err)
				goto out_revert_creds;
		}
	}

M
Miklos Szeredi 已提交
979 980
	trap = lock_rename(new_upperdir, old_upperdir);

981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996
	olddentry = lookup_one_len(old->d_name.name, old_upperdir,
				   old->d_name.len);
	err = PTR_ERR(olddentry);
	if (IS_ERR(olddentry))
		goto out_unlock;

	err = -ESTALE;
	if (olddentry != ovl_dentry_upper(old))
		goto out_dput_old;

	newdentry = lookup_one_len(new->d_name.name, new_upperdir,
				   new->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput_old;

997 998 999
	old_opaque = ovl_dentry_is_opaque(old);
	new_opaque = ovl_dentry_is_opaque(new);

1000 1001
	err = -ESTALE;
	if (ovl_dentry_upper(new)) {
M
Miklos Szeredi 已提交
1002
		if (opaquedir) {
1003 1004
			if (newdentry != opaquedir)
				goto out_dput;
M
Miklos Szeredi 已提交
1005
		} else {
1006 1007
			if (newdentry != ovl_dentry_upper(new))
				goto out_dput;
M
Miklos Szeredi 已提交
1008 1009
		}
	} else {
1010 1011 1012
		if (!d_is_negative(newdentry) &&
		    (!new_opaque || !ovl_is_whiteout(newdentry)))
			goto out_dput;
M
Miklos Szeredi 已提交
1013 1014 1015 1016 1017 1018 1019
	}

	if (olddentry == trap)
		goto out_dput;
	if (newdentry == trap)
		goto out_dput;

M
Miklos Szeredi 已提交
1020 1021 1022
	if (WARN_ON(olddentry->d_inode == newdentry->d_inode))
		goto out_dput;

M
Miklos Szeredi 已提交
1023
	err = 0;
M
Miklos Szeredi 已提交
1024
	if (is_dir) {
M
Miklos Szeredi 已提交
1025
		if (ovl_type_merge_or_lower(old))
M
Miklos Szeredi 已提交
1026
			err = ovl_set_redirect(old, samedir);
1027
		else if (!old_opaque && ovl_type_merge(new->d_parent))
1028
			err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
M
Miklos Szeredi 已提交
1029 1030
		if (err)
			goto out_dput;
M
Miklos Szeredi 已提交
1031
	}
M
Miklos Szeredi 已提交
1032
	if (!overwrite && new_is_dir) {
M
Miklos Szeredi 已提交
1033
		if (ovl_type_merge_or_lower(new))
M
Miklos Szeredi 已提交
1034
			err = ovl_set_redirect(new, samedir);
1035
		else if (!new_opaque && ovl_type_merge(old->d_parent))
1036
			err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
M
Miklos Szeredi 已提交
1037 1038
		if (err)
			goto out_dput;
M
Miklos Szeredi 已提交
1039 1040
	}

1041 1042 1043
	err = ovl_do_rename(old_upperdir->d_inode, olddentry,
			    new_upperdir->d_inode, newdentry, flags);
	if (err)
M
Miklos Szeredi 已提交
1044 1045 1046 1047 1048
		goto out_dput;

	if (cleanup_whiteout)
		ovl_cleanup(old_upperdir->d_inode, newdentry);

1049 1050 1051 1052 1053 1054 1055
	if (overwrite && d_inode(new)) {
		if (new_is_dir)
			clear_nlink(d_inode(new));
		else
			drop_nlink(d_inode(new));
	}

M
Miklos Szeredi 已提交
1056 1057 1058 1059 1060
	ovl_dentry_version_inc(old->d_parent);
	ovl_dentry_version_inc(new->d_parent);

out_dput:
	dput(newdentry);
1061 1062
out_dput_old:
	dput(olddentry);
M
Miklos Szeredi 已提交
1063 1064 1065
out_unlock:
	unlock_rename(new_upperdir, old_upperdir);
out_revert_creds:
1066
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
out_drop_write:
	ovl_drop_write(old);
out:
	dput(opaquedir);
	return err;
}

const struct inode_operations ovl_dir_inode_operations = {
	.lookup		= ovl_lookup,
	.mkdir		= ovl_mkdir,
	.symlink	= ovl_symlink,
	.unlink		= ovl_unlink,
	.rmdir		= ovl_rmdir,
1080
	.rename		= ovl_rename,
M
Miklos Szeredi 已提交
1081 1082 1083 1084 1085
	.link		= ovl_link,
	.setattr	= ovl_setattr,
	.create		= ovl_create,
	.mknod		= ovl_mknod,
	.permission	= ovl_permission,
1086
	.getattr	= ovl_getattr,
M
Miklos Szeredi 已提交
1087
	.listxattr	= ovl_listxattr,
1088
	.get_acl	= ovl_get_acl,
M
Miklos Szeredi 已提交
1089
	.update_time	= ovl_update_time,
M
Miklos Szeredi 已提交
1090
};