Signed-off-by: NCleber Rosa <crosa@redhat.com>

We prove that `post_tests` will always be executed when `pre_tests` was.
Let's remove the unnecessary `__del__` handling of teststmpdir.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This adds the documentation of pre/post tests plugin interface including
the conditions under which they are or are not executed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit enables the left-behind-temporary-dirs check between each
test. As all selftests are executed as a single process the BORG class
keeps the TMP dir of the unit-tests. To avoid results spoiled by this
fact this commit adds a force-cleanup of the tmp dir tracker overriding
the BORG internal state, which is not really nice, but for selftests
acceptable.

The method to clean it was especially named
"unittest_refresh_dir_tracker" to emphasize it should not be used
outside of unittest.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In some tests we override the job workflow, let's make sure the
post_tests is executed whenever pre_test was.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Remove the temporary script files which are not located in tmpdirs.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  SPEC file: sync how we build snapshot and release packages

Downstream (Fedora and EPEL) RPM packages have had a different way
of building release (by default) and snapshot packages by editing
the SPEC file.

Let's sync with them, while also allowing snapshot packages to be
built from our usual `make rpm` command.  Release builds are still
supported with `make rpm-release`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Altered the way linux_modules checks loaded module
  linux_modules returns parameter type

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  utils: Add "get_interfaces_in_pci_address" method to pci.py

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Using more than one docstrig directive makes Avocado to use only the
first one. This patch makes the safeloader to handle multiple docstring
directives (i.e. `🥑 enable` and `🥑 tags=foo`).

Reference: https://trello.com/c/6FpySXuCSigned-off-by: NAmador Pahim <apahim@redhat.com>

Add a new function, which takes pci_address and pci_class as
i/P and returns corresponding pci_interface
Signed-off-by: NVenkat R B <vrbagal1@linux.vnet.ibm.com>

avocado/utils/linux_modules: module_is_loaded() was using
loaded_module_info() to check if a module is loaded or not,
which is a roundabout approach, and prints some unnecessary
information as well.
Made it to read /proc/modules to check this.
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

avocado/utils/linux_modules: In addition to parameters, their
types are also returned by loaded_module_info()
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Currently the `selftests/run_coverage` only reports unit coverage. This
patch allows specifying custom `avocado` command in selftests and uses
it to run coverage to also include the functional tests to results.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

`system-out` should be in the same level as `failure`, but we are
creating it as a `failure` child.

This patch puts system-out in the same level as `failure` and adds the
functional test to validate all the xunit outputs against the
junit-4.xsd schema.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Let's move the junit schema file to .data so we can reuse it for
functional tests.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The package names have changed, let's sync that with what's used
in the release example testplan.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Simply because this file won't be available when being installed
from any method outside the source tree.

The downside is obvious: it requires extra steps when doing a new
release.  But that is still better than not being able to ship
these plugins to users using the standard Python mechanisms.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Now that the optional plugins have been excluded from the main
git archive, let's create them (currently with setuptools sdist
command).

Also, let's adjust the upload instruction a bit to signal that
other packages may be in PYPI_UPLOAD too.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

PyPI understands (rightfully so) one Python module per archive.  So,
it doesn't make sense to bundle all the plugins there for users of
`pip install avocado-framework`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So users will now be able to find Avocado plugins on PyPI, and install
them via `pip`.  Let's try to be consistent with the naming on those
packages, so that users don't fall into naming traps such as
installing Django related extensions.

Also, those packages map more closely to their (RPM) packaged versions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Downstream file contains a conditional for the execution of
selftests.  Let's port that to the upstream SPEC file too.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

I have to say that having one requirement per line is really verbose,
but I have to admit that it makes diffs a lot easier to grasp.

Again, this syncs with the downstream SPEC file.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The first line says it all.  While this change wouldn't be really
required, it brings the SPEC file close to the Fedora/EPEL downstream
version.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Added -y to pvcreate in lv_utils

Added '-y' to pvcreate since pvcreate asks for confirmation
if previous filesystem signature exists.
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

The write to /proc/sys/vm/drop_caches requires root, let's use the
`sudo` to allow the execution for non-root executions as well.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>