1. 20 7月, 2013 9 次提交
  2. 16 7月, 2013 3 次提交
    • M
      drm/i915: introduce i915_queue_hangcheck · 10cd45b6
      Mika Kuoppala 提交于
      To run hangcheck in near future.
      Signed-off-by: NMika Kuoppala <mika.kuoppala@intel.com>
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      10cd45b6
    • D
      drm/i915: unify GT/PM irq postinstall code · 0a9a8c91
      Daniel Vetter 提交于
      Again extract a common helper. For the postinstall hook things are a
      bit more complicated since we have more cases on ilk-hsw/vlv here.
      
      But since vlv was clearly broken by failing to initialize
      dev_priv->gt_irq_mask correctly the shared code is clearly justified.
      
      Also kill the PMIER setting in the async rps enable work. I should
      have been save, but also clearly looked rather fragile. PMIER setup is
      now all down in the irq pre/postinstall hooks.
      
      With this we now have the usual interrupt register sequence for GT/PM
      irq registers:
      
      - IER is setup once with all the interrupts we ever need in the
        postinstall hook and never touched again. Exceptions are SDEIER,
        which is touched in the preinstall hook (when the irq handler isn't
        enabled) and then only from the irq handler. And DEIER/VLV_IER with
        is used in the irq handler but also written to once in the
        postinstall hook. But since that write is essentially what enables
        the interrupt and we should always have MSI interrupts we should be
        save. In case we ever have non-MSI interrupts we'd be screwed.
      
      - IIR is cleared in the postinstall hook before we enable/unmask the
        respective interrupt sources. Hence we can't steal an interrupt
        event an accidentally trigger the spurious interrupt logic in the
        core kernel. Note that after some discussion with Ben Widawsky we
        think that we actually should clear the IIR registers in the
        preinstall hook. But doing that is a much larger patch series.
      
      - IMR regs are (usually) all masked off. Those are the only regs
        changed at runtime, which is all protected by dev_priv->irq_lock.
      
      This unification also kills the cargo-culted read-modify-write PM
      register setup for VECS. Interrupt setup is done without userspace
      being able to interfere, so we better know what values we want to put
      into those registers. RMW cycles otoh are really good at papering over
      races, until stuff magically blows up and no one has a clue why.
      
      v2: Touch the gen6+ PM interrupt registers only on gen6+.
      
      v3: Improve the commit message to more clearly spell out why we want
      to unify the code and what exactly changes.
      
      Cc: Ben Widawsky <ben@bwidawsk.net>
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      [danvet: Add a comment to explain why the l3 parity interrupt is
      special.]
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      0a9a8c91
    • D
      drm/i915: unify PM interrupt preinstall sequence · d18ea1b5
      Daniel Vetter 提交于
      Since the addition of VECS we have a slightly different enable
      sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that
      will end up in hard to track down surprises.
      
      Hence unifiy things and since we have copies of this code in 3 places
      now, extract it into its own little helper.
      
      Note that this changes the irq preinstall sequence a bit for snb and
      vlv: We now also clear the PM registers in the preinstall hook, in
      addition to the PM register clearing/setup already done when actually
      enabling rps. So this doesn't fix a bug but simply unifies the code
      across all platforms. After the postinstall hook is similarly unified
      we can rip out the then redundant PM interrupt setup from the rps
      code.
      
      v3: Rebase on top of the retained double-GTIIR clearing. Also
      resurrect the masking/disabling of the gen6+ PM interrupts as spotted
      by Ben Widaswky.
      
      v4: Move the DE interrupt reset code out of gen5_gt_irq_preinstall
      back to ironlake_irq_preinstall where it really belongs. Spotted by
      Paulo.
      
      v3: Improve the commit message to more clearly spell out why we want
      to unify the code and what exactly changes.
      
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      [danvet: s/GT/PM/ to fix up a comment which Ben spotted while
      reviewing.]
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      d18ea1b5
  3. 13 7月, 2013 1 次提交
  4. 11 7月, 2013 9 次提交
    • D
      drm/i915: don't enable PM_VEBOX_CS_ERROR_INTERRUPT · c0d6a3dd
      Daniel Vetter 提交于
      The code to handle it is broken - there's simply no code to clear CS
      parser errors on gen5+. And behold, for all the other rings we also
      don't enable it!
      
      Leave the handling code itself in place just to be consistent with the
      existing mess though. And in case someone feels like fixing it all up.
      
      This has been errornously enabled in
      
      commit 12638c57
      Author: Ben Widawsky <ben@bwidawsk.net>
      Date:   Tue May 28 19:22:31 2013 -0700
      
          drm/i915: Enable vebox interrupts
      
      Cc: Damien Lespiau <damien.lespiau@intel.com>
      Cc: Ben Widawsky <ben@bwidawsk.net>
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      c0d6a3dd
    • D
      drm/i915: kill dev_priv->rps.lock · 59cdb63d
      Daniel Vetter 提交于
      Now that the rps interrupt locking isn't clearly separated (at elast
      conceptually) from all the other interrupt locking having a different
      lock stopped making sense: It protects much more than just the rps
      workqueue it started out with. But with the addition of VECS the
      separation started to blurr and resulted in some more complex locking
      for the ring interrupt refcount.
      
      With this we can (again) unifiy the ringbuffer irq refcounts without
      causing a massive confusion, but that's for the next patch.
      
      v2: Explain better why the rps.lock once made sense and why no longer,
      requested by Ben.
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      59cdb63d
    • D
      drm/i915: queue work outside spinlock in hsw_pm_irq_handler · 2adbee62
      Daniel Vetter 提交于
      And kill the comment about it. Queueing work is a barrier type event,
      no amount of locking will help in ordering things (as long as we queue
      the work after having updated all relevant data structures). Also, the
      queue_work works itself as a sufficient memory barrier.
      
      Again on the surface this is just a tiny micro-optimization to reduce
      the hold-time of dev_priv->irq_lock. But the better reason is that it
      reduces superficial locking and so makes it clearer what we actually
      need for correctness.
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      2adbee62
    • D
      drm/i915: streamline hsw_pm_irq_handler · 41a05a3a
      Daniel Vetter 提交于
      The if (pm_iir & ~GEN6_PM_RPS_EVENTS) check was redunandant. Otoh
      adding a check for rps events allows us to avoid the spinlock grabbing
      for VECS interrupts.
      
      v2: Drop misplaced hunk which now moved to the right patch.
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      41a05a3a
    • D
      drm/i915: irq handlers don't need interrupt-safe spinlocks · d0ecd7e2
      Daniel Vetter 提交于
      Since we only have one interrupt handler and interrupt handlers are
      non-reentrant.
      
      To drive the point really home give them all an _irq_handler suffix.
      
      This is a tiny micro-optimization but even more important it makes it
      clearer what locking we actually need. And in case someone screws this
      up: lockdep will catch hardirq vs. other context deadlocks.
      
      v2: Fix up compile fail.
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Reviewed-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      d0ecd7e2
    • D
      drm/i915: kill lpt pch transcoder->crtc mapping code for fifo underruns · de28075d
      Daniel Vetter 提交于
      It's racy: There's no guarantee that we won't walk this code (due to a
      pch fifo underrun interrupt) while someone is changing the pointers
      around.
      
      The only reason we do this is to use the righ crtc for the pch fifo
      underrun accounting. But we never expose this to userspace, so
      essentially no one really cares if we use the "wrong" crtc.
      
      So let's just rip it out.
      
      With this patch fifo underrun code will always use crtc A for tracking
      underruns on the (only) pch transcoder on LPT.
      
      v2: Add a big comment explaining what's going on. Requested by Paulo.
      
      v3: Fixup spelling in comment as spotted by Paulo.
      
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      de28075d
    • D
      drm/i915: improve GEN7_ERR_INT clearing for fifo underrun reporting · 7336df65
      Daniel Vetter 提交于
      Same treatment as for SERR_INT: If we clear only the bit for the pipe
      we're enabling (but unconditionally) then we can always check for
      possible underruns after having disabled the interrupt. That way pipe
      underruns won't be lost, but at worst only get reported in a delayed
      fashion.
      
      v2: The same logic bug as in the SERR handling change also existed
      here. The same bugfix of only reporting missed underruns when the
      error interrupt was masked applies, too.
      
      v3: Do the same fixes as for the SERR handling that Paulo suggested in
      his review:
      - s/%i/%c/ fix in the debug output
      - move the DE_ERR_INT_IVB read into the respective if block
      
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      [danvet: Fix up the checkpatch bikeshed Paulo noticed.]
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      7336df65
    • D
      drm/i915: improve SERR_INT clearing for fifo underrun reporting · 1dd246fb
      Daniel Vetter 提交于
      The current code won't report any fifo underruns on cpt if just one
      pipe has fifo underrun reporting disabled. We can't enable the
      interrupts, but we can still check the per-transcoder bits and so
      report the underrun delayed if:
      - We always clear the transcoder's bit (and none of the other bits)
        when enabling.
      - We check the transcoder's bit after disabling (to avoid racing with
        the interrupt handler).
      
      v2: I've forgotten to actually remove the old SERR_INT clearing.
      
      v3: Use transcoder_name as suggested by Paulo Zanoni. Paulo also
      noticed a logic bug: When an underrun interrupt fires we report it
      both in the interrupt handler and when checking for underruns when
      disabling it in cpt_set_fifo_underrun_reporting. But that second check
      is only required if the interrupt is disabled and we're switching of
      underrun reporting (e.g. because we're disabling the crtc). Hence
      check for that condition.
      
      At first I wanted to rework the code to pass that bit of information
      from the uppper functions down to cpt_set_fifo_underrun_reporting. But
      that turned out too messy. Hence the quick&dirty check whether the
      south error interrupt source is masked off or not.
      
      v4: Streamline the control flow a bit.
      
      v5: s/pipe/pch transcoder/ in the dmesg output, suggested by Paulo.
      
      v6: Review from Paulo:
      - Reorder the was_enabled assignment to only read the register when we
        need it. Also add a comment that we need to do that before updating
        the register.
      - s/%i/%c/ fix for the debug output.
      - Fix the checkpath complaint in the SERR_INT_TRANS_FIFO_UNDERRUN
        #define.
      
      v7: Hopefully put that elusive SERR hunk back into this patch, spotted
      by Paulo.
      
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      1dd246fb
    • D
      drm/i915: extract ibx_display_interrupt_update · fee884ed
      Daniel Vetter 提交于
      This way all changes to SDEIMR all go through the same function, with
      the exception of the (single-threaded) setup/teardown code.
      
      For paranoia again add an assert_spin_locked.
      
      v2: For even more paranoia also sprinkle a spinlock assert over
      cpt_can_enable_serr_int since we need to have that one there, too.
      
      v3: Fix the logic of interrupt enabling, add enable/disable macros for
      the simple cases in the fifo code and add a comment. All requested by
      Paulo.
      Reviewed-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      fee884ed
  5. 09 7月, 2013 1 次提交
    • B
      drm/i915: Getter/setter for object attributes · f343c5f6
      Ben Widawsky 提交于
      Soon we want to gut a lot of our existing assumptions how many address
      spaces an object can live in, and in doing so, embed the drm_mm_node in
      the object (and later the VMA).
      
      It's possible in the future we'll want to add more getter/setter
      methods, but for now this is enough to enable the VMAs.
      
      v2: Reworked commit message (Ben)
      Added comments to the main functions (Ben)
      sed -i "s/i915_gem_obj_set_color/i915_gem_obj_ggtt_set_color/" drivers/gpu/drm/i915/*.[ch]
      sed -i "s/i915_gem_obj_bound/i915_gem_obj_ggtt_bound/" drivers/gpu/drm/i915/*.[ch]
      sed -i "s/i915_gem_obj_size/i915_gem_obj_ggtt_size/" drivers/gpu/drm/i915/*.[ch]
      sed -i "s/i915_gem_obj_offset/i915_gem_obj_ggtt_offset/" drivers/gpu/drm/i915/*.[ch]
      (Daniel)
      
      v3: Rebased on new reserve_node patch
      Changed DRM_DEBUG_KMS to actually work (will need fixing later)
      Signed-off-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      f343c5f6
  6. 06 7月, 2013 1 次提交
  7. 02 7月, 2013 1 次提交
  8. 01 7月, 2013 13 次提交
  9. 18 6月, 2013 1 次提交
  10. 13 6月, 2013 1 次提交