i915_gem_execbuffer.c 49.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30
#include <drm/drmP.h>
#include <drm/i915_drm.h>
31 32 33
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
34
#include <linux/dma_remapping.h>
35
#include <linux/uaccess.h>
36

37 38 39 40 41
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
42 43

#define BATCH_OFFSET_BIAS (256*1024)
44

45 46
struct eb_vmas {
	struct list_head vmas;
47
	int and;
48
	union {
49
		struct i915_vma *lut[0];
50 51
		struct hlist_head buckets[0];
	};
52 53
};

54
static struct eb_vmas *
B
Ben Widawsky 已提交
55
eb_create(struct drm_i915_gem_execbuffer2 *args)
56
{
57
	struct eb_vmas *eb = NULL;
58 59

	if (args->flags & I915_EXEC_HANDLE_LUT) {
60
		unsigned size = args->buffer_count;
61 62
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
63 64 65 66
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
67 68
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
69
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
70 71 72
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
73
			     sizeof(struct eb_vmas),
74 75 76 77 78 79 80 81
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

82
	INIT_LIST_HEAD(&eb->vmas);
83 84 85 86
	return eb;
}

static void
87
eb_reset(struct eb_vmas *eb)
88
{
89 90
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
91 92
}

93
static int
94 95 96 97 98
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
99
{
100 101
	struct drm_i915_gem_object *obj;
	struct list_head objects;
102
	int i, ret;
103

104
	INIT_LIST_HEAD(&objects);
105
	spin_lock(&file->table_lock);
106 107
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
108
	for (i = 0; i < args->buffer_count; i++) {
109 110 111 112 113
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
114
			ret = -ENOENT;
115
			goto err;
116 117
		}

118
		if (!list_empty(&obj->obj_exec_link)) {
119 120 121
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
122
			ret = -EINVAL;
123
			goto err;
124 125 126
		}

		drm_gem_object_reference(&obj->base);
127 128 129
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
130

131
	i = 0;
132
	while (!list_empty(&objects)) {
133
		struct i915_vma *vma;
134

135 136 137 138
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

139 140 141 142 143 144 145 146
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
147
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
148 149 150
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
151
			goto err;
152 153
		}

154
		/* Transfer ownership from the objects list to the vmas list. */
155
		list_add_tail(&vma->exec_list, &eb->vmas);
156
		list_del_init(&obj->obj_exec_link);
157 158

		vma->exec_entry = &exec[i];
159
		if (eb->and < 0) {
160
			eb->lut[i] = vma;
161 162
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
163 164
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
165 166
				       &eb->buckets[handle & eb->and]);
		}
167
		++i;
168 169
	}

170
	return 0;
171 172


173
err:
174 175 176 177 178
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
179
		drm_gem_object_unreference(&obj->base);
180
	}
181 182 183 184 185
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

186
	return ret;
187 188
}

189
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
190
{
191 192 193 194 195 196
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
197
		struct i915_vma *vma;
198

199
		head = &eb->buckets[handle & eb->and];
200
		hlist_for_each_entry(vma, head, exec_node) {
201 202
			if (vma->exec_handle == handle)
				return vma;
203 204 205
		}
		return NULL;
	}
206 207
}

208 209 210 211 212 213 214 215 216 217 218 219 220 221 222
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
223
		vma->pin_count--;
224

C
Chris Wilson 已提交
225
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
226 227 228 229
}

static void eb_destroy(struct eb_vmas *eb)
{
230 231
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
232

233 234
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
235
				       exec_list);
236
		list_del_init(&vma->exec_list);
237
		i915_gem_execbuffer_unreserve_vma(vma);
238
		drm_gem_object_unreference(&vma->obj->base);
239
	}
240 241 242
	kfree(eb);
}

243 244
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
245 246
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
247 248 249
		obj->cache_level != I915_CACHE_NONE);
}

250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

275 276
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
277 278
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
279
{
280
	struct drm_device *dev = obj->base.dev;
281
	uint32_t page_offset = offset_in_page(reloc->offset);
282
	uint64_t delta = relocation_target(reloc, target_offset);
283
	char *vaddr;
284
	int ret;
285

286
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
287 288 289
	if (ret)
		return ret;

290
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
291
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
292
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
293 294 295 296 297 298

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
299
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
300 301 302
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
303
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
304 305
	}

306 307 308 309 310 311 312
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
313 314
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
315 316
{
	struct drm_device *dev = obj->base.dev;
317 318
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
319
	uint64_t delta = relocation_target(reloc, target_offset);
320
	uint64_t offset;
321
	void __iomem *reloc_page;
322
	int ret;
323 324 325 326 327 328 329 330 331 332

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
333 334
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
335
	reloc_page = io_mapping_map_atomic_wc(ggtt->mappable,
336 337
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
338 339

	if (INTEL_INFO(dev)->gen >= 8) {
340
		offset += sizeof(uint32_t);
341

342
		if (offset_in_page(offset) == 0) {
343
			io_mapping_unmap_atomic(reloc_page);
344
			reloc_page =
345
				io_mapping_map_atomic_wc(ggtt->mappable,
346
							 offset);
347 348
		}

349 350
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
351 352
	}

353 354 355 356 357
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
374
	uint64_t delta = relocation_target(reloc, target_offset);
375 376 377 378 379 380 381
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

382
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
383 384 385 386 387 388 389 390
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
391
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
392 393 394 395 396 397 398 399 400 401 402
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

403 404
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
405
				   struct eb_vmas *eb,
406
				   struct drm_i915_gem_relocation_entry *reloc)
407 408 409
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
410
	struct drm_i915_gem_object *target_i915_obj;
411
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
412
	uint64_t target_offset;
413
	int ret;
414

415
	/* we've already hold a reference to all valid objects */
416 417
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
418
		return -ENOENT;
419 420
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
421

422
	target_offset = gen8_canonical_addr(target_vma->node.start);
423

424 425 426 427
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
428
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
429
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
430
				    PIN_GLOBAL);
431 432 433
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
434

435
	/* Validate that the target is in a valid r/w GPU domain */
436
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
437
		DRM_DEBUG("reloc with multiple write domains: "
438 439 440 441 442 443
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
444
		return -EINVAL;
445
	}
446 447
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
448
		DRM_DEBUG("reloc with read/write non-GPU domains: "
449 450 451 452 453 454
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
455
		return -EINVAL;
456 457 458 459 460 461 462 463 464
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
465
		return 0;
466 467

	/* Check that the relocation address is valid... */
468 469
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
470
		DRM_DEBUG("Relocation beyond object bounds: "
471 472 473 474
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
475
		return -EINVAL;
476
	}
477
	if (unlikely(reloc->offset & 3)) {
478
		DRM_DEBUG("Relocation not 4-byte aligned: "
479 480 481
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
482
		return -EINVAL;
483 484
	}

485
	/* We can't wait for rendering with pagefaults disabled */
486
	if (obj->active && pagefault_disabled())
487 488
		return -EFAULT;

489
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
490
		ret = relocate_entry_cpu(obj, reloc, target_offset);
491
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
492
		ret = relocate_entry_gtt(obj, reloc, target_offset);
493
	else if (static_cpu_has(X86_FEATURE_CLFLUSH))
494 495 496 497 498
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
499

500 501 502
	if (ret)
		return ret;

503 504 505
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

506
	return 0;
507 508 509
}

static int
510 511
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
512
{
513 514
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
515
	struct drm_i915_gem_relocation_entry __user *user_relocs;
516
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
517
	int remain, ret;
518

519
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
520

521 522 523 524 525 526 527 528 529
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
530 531
			return -EFAULT;

532 533
		do {
			u64 offset = r->presumed_offset;
534

535
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
536 537 538 539
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
540
			    __put_user(r->presumed_offset, &user_relocs->presumed_offset)) {
541 542 543 544 545 546
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
547 548 549
	}

	return 0;
550
#undef N_RELOC
551 552 553
}

static int
554 555 556
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
557
{
558
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
559 560 561
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
562
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
563 564 565 566 567 568 569 570
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
571
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
572
{
573
	struct i915_vma *vma;
574 575 576 577 578 579 580 581 582 583
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
584 585
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
586
		if (ret)
587
			break;
588
	}
589
	pagefault_enable();
590

591
	return ret;
592 593
}

594 595 596 597 598 599
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

600
static int
601
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
602
				struct intel_engine_cs *engine,
603
				bool *need_reloc)
604
{
605
	struct drm_i915_gem_object *obj = vma->obj;
606
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
607
	uint64_t flags;
608 609
	int ret;

610
	flags = PIN_USER;
611 612 613
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

614
	if (!drm_mm_node_allocated(&vma->node)) {
615 616 617 618 619
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
620 621 622 623
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
624 625
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
626 627
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
628
	}
629 630

	ret = i915_gem_object_pin(obj, vma->vm, entry->alignment, flags);
631 632 633 634
	if ((ret == -ENOSPC  || ret == -E2BIG) &&
	    only_mappable_for_reloc(entry->flags))
		ret = i915_gem_object_pin(obj, vma->vm,
					  entry->alignment,
635
					  flags & ~PIN_MAPPABLE);
636 637 638
	if (ret)
		return ret;

639 640
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

641 642 643 644
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
645

646 647
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
648 649
	}

650 651
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
652 653 654 655 656 657 658 659
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

660
	return 0;
661
}
662

663
static bool
664
need_reloc_mappable(struct i915_vma *vma)
665 666 667
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

668 669 670
	if (entry->relocation_count == 0)
		return false;

671
	if (!vma->is_ggtt)
672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
689

690
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP && !vma->is_ggtt);
691 692 693 694 695

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

696 697 698 699
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

700 701 702 703
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

704 705 706 707
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

708 709 710 711
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

712 713 714
	return false;
}

715
static int
716
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
717
			    struct list_head *vmas,
718
			    struct i915_gem_context *ctx,
719
			    bool *need_relocs)
720
{
721
	struct drm_i915_gem_object *obj;
722
	struct i915_vma *vma;
723
	struct i915_address_space *vm;
724
	struct list_head ordered_vmas;
725
	struct list_head pinned_vmas;
726
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
727
	int retry;
728

729
	i915_gem_retire_requests_ring(engine);
730

731 732
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

733
	INIT_LIST_HEAD(&ordered_vmas);
734
	INIT_LIST_HEAD(&pinned_vmas);
735
	while (!list_empty(vmas)) {
736 737 738
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

739 740 741
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
742

743 744 745
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

746 747
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
748 749 750
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
			obj->tiling_mode != I915_TILING_NONE;
751
		need_mappable = need_fence || need_reloc_mappable(vma);
752

753 754 755
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
756
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
757
			list_move(&vma->exec_list, &ordered_vmas);
758
		} else
759
			list_move_tail(&vma->exec_list, &ordered_vmas);
760

761
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
762
		obj->base.pending_write_domain = 0;
763
	}
764
	list_splice(&ordered_vmas, vmas);
765
	list_splice(&pinned_vmas, vmas);
766 767 768 769 770 771 772 773 774 775

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
776
	 * This avoid unnecessary unbinding of later objects in order to make
777 778 779 780
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
781
		int ret = 0;
782 783

		/* Unbind any ill-fitting objects or pin. */
784 785
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
786 787
				continue;

788
			if (eb_vma_misplaced(vma))
789
				ret = i915_vma_unbind(vma);
790
			else
791 792 793
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
794
			if (ret)
795 796 797 798
				goto err;
		}

		/* Bind fresh objects */
799 800
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
801
				continue;
802

803 804
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
805 806
			if (ret)
				goto err;
807 808
		}

809
err:
C
Chris Wilson 已提交
810
		if (ret != -ENOSPC || retry++)
811 812
			return ret;

813 814 815 816
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

817
		ret = i915_gem_evict_vm(vm, true);
818 819 820 821 822 823 824
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
825
				  struct drm_i915_gem_execbuffer2 *args,
826
				  struct drm_file *file,
827
				  struct intel_engine_cs *engine,
828
				  struct eb_vmas *eb,
829
				  struct drm_i915_gem_exec_object2 *exec,
830
				  struct i915_gem_context *ctx)
831 832
{
	struct drm_i915_gem_relocation_entry *reloc;
833 834
	struct i915_address_space *vm;
	struct i915_vma *vma;
835
	bool need_relocs;
836
	int *reloc_offset;
837
	int i, total, ret;
838
	unsigned count = args->buffer_count;
839

840 841
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

842
	/* We may process another execbuffer during the unlock... */
843 844 845
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
846
		i915_gem_execbuffer_unreserve_vma(vma);
847
		drm_gem_object_unreference(&vma->obj->base);
848 849
	}

850 851 852 853
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
854
		total += exec[i].relocation_count;
855

856
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
857
	reloc = drm_malloc_ab(total, sizeof(*reloc));
858 859 860
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
861 862 863 864 865 866 867
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
868 869
		u64 invalid_offset = (u64)-1;
		int j;
870

871
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
872 873

		if (copy_from_user(reloc+total, user_relocs,
874
				   exec[i].relocation_count * sizeof(*reloc))) {
875 876 877 878 879
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

880 881 882 883 884 885 886 887 888 889
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
890 891 892
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
893 894 895 896 897 898
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

899
		reloc_offset[i] = total;
900
		total += exec[i].relocation_count;
901 902 903 904 905 906 907 908
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

909 910
	/* reacquire the objects */
	eb_reset(eb);
911
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
912 913
	if (ret)
		goto err;
914

915
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
916 917
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
918 919 920
	if (ret)
		goto err;

921 922 923 924
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
925 926 927 928 929 930 931 932 933 934 935 936
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
937
	drm_free_large(reloc_offset);
938 939 940 941
	return ret;
}

static int
942
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
943
				struct list_head *vmas)
944
{
945
	const unsigned other_rings = ~intel_engine_flag(req->engine);
946
	struct i915_vma *vma;
947
	uint32_t flush_domains = 0;
948
	bool flush_chipset = false;
949
	int ret;
950

951 952
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
953 954

		if (obj->active & other_rings) {
955
			ret = i915_gem_object_sync(obj, req->engine, &req);
956 957 958
			if (ret)
				return ret;
		}
959 960

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
961
			flush_chipset |= i915_gem_clflush_object(obj, false);
962 963

		flush_domains |= obj->base.write_domain;
964 965
	}

966
	if (flush_chipset)
967
		i915_gem_chipset_flush(req->engine->i915);
968 969 970 971

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

972 973 974
	/* Unconditionally invalidate gpu caches and ensure that we do flush
	 * any residual writes from the previous batch.
	 */
975
	return intel_ring_invalidate_all_caches(req);
976 977
}

978 979
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
980
{
981 982 983
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
999 1000 1001
}

static int
1002 1003
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1004 1005
		   int count)
{
1006 1007
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1008 1009 1010
	unsigned invalid_flags;
	int i;

1011 1012 1013
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1014 1015 1016
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1017 1018

	for (i = 0; i < count; i++) {
1019
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1020 1021
		int length; /* limited by fault_in_pages_readable() */

1022
		if (exec[i].flags & invalid_flags)
1023 1024
			return -EINVAL;

1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1040 1041 1042
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1043 1044 1045 1046 1047
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1048
			return -EINVAL;
1049
		relocs_total += exec[i].relocation_count;
1050 1051 1052

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1053 1054 1055 1056 1057
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1058 1059 1060
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1061
		if (likely(!i915.prefault_disable)) {
1062 1063 1064
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1065 1066 1067 1068 1069
	}

	return 0;
}

1070
static struct i915_gem_context *
1071
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1072
			  struct intel_engine_cs *engine, const u32 ctx_id)
1073
{
1074
	struct i915_gem_context *ctx = NULL;
1075 1076
	struct i915_ctx_hang_stats *hs;

1077
	if (engine->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1078 1079
		return ERR_PTR(-EINVAL);

1080
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1081
	if (IS_ERR(ctx))
1082
		return ctx;
1083

1084
	hs = &ctx->hang_stats;
1085 1086
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1087
		return ERR_PTR(-EIO);
1088 1089
	}

1090
	return ctx;
1091 1092
}

1093
void
1094
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1095
				   struct drm_i915_gem_request *req)
1096
{
1097
	struct intel_engine_cs *engine = i915_gem_request_get_engine(req);
1098
	struct i915_vma *vma;
1099

1100
	list_for_each_entry(vma, vmas, exec_list) {
1101
		struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
1102
		struct drm_i915_gem_object *obj = vma->obj;
1103 1104
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1105

1106
		obj->dirty = 1; /* be paranoid  */
1107
		obj->base.write_domain = obj->base.pending_write_domain;
1108 1109 1110
		if (obj->base.write_domain == 0)
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1111

1112
		i915_vma_move_to_active(vma, req);
1113
		if (obj->base.write_domain) {
1114
			i915_gem_request_assign(&obj->last_write_req, req);
1115

1116
			intel_fb_obj_invalidate(obj, ORIGIN_CS);
1117 1118 1119

			/* update for the implicit flush after a batch */
			obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1120
		}
1121
		if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
1122
			i915_gem_request_assign(&obj->last_fenced_req, req);
1123
			if (entry->flags & __EXEC_OBJECT_HAS_FENCE) {
1124
				struct drm_i915_private *dev_priv = engine->i915;
1125 1126 1127 1128
				list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
					       &dev_priv->mm.fence_list);
			}
		}
1129

C
Chris Wilson 已提交
1130
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1131 1132 1133
	}
}

1134
static void
1135
i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)
1136
{
1137
	/* Unconditionally force add_request to emit a full flush. */
1138
	params->engine->gpu_caches_dirty = true;
1139

1140
	/* Add a breadcrumb for the completion of the batch buffer */
1141
	__i915_add_request(params->request, params->batch_obj, true);
1142
}
1143

1144 1145
static int
i915_reset_gen7_sol_offsets(struct drm_device *dev,
1146
			    struct drm_i915_gem_request *req)
1147
{
1148
	struct intel_engine_cs *engine = req->engine;
1149
	struct drm_i915_private *dev_priv = to_i915(dev);
1150 1151
	int ret, i;

1152
	if (!IS_GEN7(dev) || engine != &dev_priv->engine[RCS]) {
1153 1154 1155
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1156

1157
	ret = intel_ring_begin(req, 4 * 3);
1158 1159 1160 1161
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1162 1163 1164
		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(engine, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(engine, 0);
1165 1166
	}

1167
	intel_ring_advance(engine);
1168 1169 1170 1171

	return 0;
}

1172
static struct drm_i915_gem_object*
1173
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1174 1175 1176 1177 1178
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct eb_vmas *eb,
			  struct drm_i915_gem_object *batch_obj,
			  u32 batch_start_offset,
			  u32 batch_len,
1179
			  bool is_master)
1180 1181
{
	struct drm_i915_gem_object *shadow_batch_obj;
1182
	struct i915_vma *vma;
1183 1184
	int ret;

1185
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1186
						   PAGE_ALIGN(batch_len));
1187 1188 1189
	if (IS_ERR(shadow_batch_obj))
		return shadow_batch_obj;

1190
	ret = i915_parse_cmds(engine,
1191 1192 1193 1194 1195
			      batch_obj,
			      shadow_batch_obj,
			      batch_start_offset,
			      batch_len,
			      is_master);
1196 1197
	if (ret)
		goto err;
1198

1199 1200 1201
	ret = i915_gem_obj_ggtt_pin(shadow_batch_obj, 0, 0);
	if (ret)
		goto err;
1202

C
Chris Wilson 已提交
1203 1204
	i915_gem_object_unpin_pages(shadow_batch_obj);

1205
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1206

1207 1208
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1209
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1210 1211
	drm_gem_object_reference(&shadow_batch_obj->base);
	list_add_tail(&vma->exec_list, &eb->vmas);
1212

1213 1214 1215
	shadow_batch_obj->base.pending_read_domains = I915_GEM_DOMAIN_COMMAND;

	return shadow_batch_obj;
1216

1217
err:
C
Chris Wilson 已提交
1218
	i915_gem_object_unpin_pages(shadow_batch_obj);
1219 1220 1221 1222
	if (ret == -EACCES) /* unhandled chained batch */
		return batch_obj;
	else
		return ERR_PTR(ret);
1223
}
1224

1225
int
1226
i915_gem_ringbuffer_submission(struct i915_execbuffer_params *params,
1227
			       struct drm_i915_gem_execbuffer2 *args,
1228
			       struct list_head *vmas)
1229
{
1230
	struct drm_device *dev = params->dev;
1231
	struct intel_engine_cs *engine = params->engine;
1232
	struct drm_i915_private *dev_priv = to_i915(dev);
1233
	u64 exec_start, exec_len;
1234 1235
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1236
	int ret;
1237

1238
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1239
	if (ret)
C
Chris Wilson 已提交
1240
		return ret;
1241

1242
	ret = i915_switch_context(params->request);
1243
	if (ret)
C
Chris Wilson 已提交
1244
		return ret;
1245

1246 1247
	WARN(params->ctx->ppgtt && params->ctx->ppgtt->pd_dirty_rings & (1<<engine->id),
	     "%s didn't clear reload\n", engine->name);
1248

1249 1250 1251 1252 1253 1254
	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1255
		if (instp_mode != 0 && engine != &dev_priv->engine[RCS]) {
1256
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1257
			return -EINVAL;
1258 1259 1260 1261 1262
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
			if (INTEL_INFO(dev)->gen < 4) {
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1263
				return -EINVAL;
1264 1265 1266 1267 1268
			}

			if (INTEL_INFO(dev)->gen > 5 &&
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1269
				return -EINVAL;
1270 1271 1272 1273 1274 1275 1276 1277 1278
			}

			/* The HW changed the meaning on this bit on gen6 */
			if (INTEL_INFO(dev)->gen >= 6)
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1279
		return -EINVAL;
1280 1281
	}

1282
	if (engine == &dev_priv->engine[RCS] &&
C
Chris Wilson 已提交
1283
	    instp_mode != dev_priv->relative_constants_mode) {
1284
		ret = intel_ring_begin(params->request, 4);
1285
		if (ret)
C
Chris Wilson 已提交
1286
			return ret;
1287

1288 1289 1290 1291 1292
		intel_ring_emit(engine, MI_NOOP);
		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(engine, INSTPM);
		intel_ring_emit(engine, instp_mask << 16 | instp_mode);
		intel_ring_advance(engine);
1293 1294 1295 1296 1297

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1298
		ret = i915_reset_gen7_sol_offsets(dev, params->request);
1299
		if (ret)
C
Chris Wilson 已提交
1300
			return ret;
1301 1302
	}

1303 1304 1305 1306
	exec_len   = args->batch_len;
	exec_start = params->batch_obj_vm_offset +
		     params->args_batch_start_offset;

1307 1308 1309
	if (exec_len == 0)
		exec_len = params->batch_obj->base.size;

1310
	ret = engine->dispatch_execbuffer(params->request,
C
Chris Wilson 已提交
1311 1312 1313 1314
					exec_start, exec_len,
					params->dispatch_flags);
	if (ret)
		return ret;
1315

1316
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1317

1318
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1319

C
Chris Wilson 已提交
1320
	return 0;
1321 1322
}

1323 1324
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1325
 * The ring index is returned.
1326
 */
1327 1328
static unsigned int
gen8_dispatch_bsd_ring(struct drm_i915_private *dev_priv, struct drm_file *file)
1329 1330 1331
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1332 1333 1334
	/* Check whether the file_priv has already selected one ring. */
	if ((int)file_priv->bsd_ring < 0) {
		/* If not, use the ping-pong mechanism to select one. */
1335
		mutex_lock(&dev_priv->drm.struct_mutex);
1336 1337
		file_priv->bsd_ring = dev_priv->mm.bsd_ring_dispatch_index;
		dev_priv->mm.bsd_ring_dispatch_index ^= 1;
1338
		mutex_unlock(&dev_priv->drm.struct_mutex);
1339
	}
1340 1341

	return file_priv->bsd_ring;
1342 1343
}

1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357
static struct drm_i915_gem_object *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
1358 1359
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;
1360 1361 1362 1363

	return vma->obj;
}

1364 1365
#define I915_USER_RINGS (4)

1366
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

static int
eb_select_ring(struct drm_i915_private *dev_priv,
	       struct drm_file *file,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct intel_engine_cs **ring)
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
		return -EINVAL;
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
		return -EINVAL;
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
			bsd_idx = gen8_dispatch_bsd_ring(dev_priv, file);
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1401
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1402 1403 1404 1405 1406 1407 1408
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
			return -EINVAL;
		}

1409
		*ring = &dev_priv->engine[_VCS(bsd_idx)];
1410
	} else {
1411
		*ring = &dev_priv->engine[user_ring_map[user_ring_id]];
1412 1413
	}

1414
	if (!intel_engine_initialized(*ring)) {
1415 1416 1417 1418 1419 1420 1421
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
		return -EINVAL;
	}

	return 0;
}

1422 1423 1424 1425
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1426
		       struct drm_i915_gem_exec_object2 *exec)
1427
{
1428 1429
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1430
	struct drm_i915_gem_request *req = NULL;
1431
	struct eb_vmas *eb;
1432
	struct drm_i915_gem_object *batch_obj;
1433
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1434
	struct intel_engine_cs *engine;
1435
	struct i915_gem_context *ctx;
1436
	struct i915_address_space *vm;
1437 1438
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1439
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1440
	u32 dispatch_flags;
1441
	int ret;
1442
	bool need_relocs;
1443

1444
	if (!i915_gem_check_execbuffer(args))
1445 1446
		return -EINVAL;

1447
	ret = validate_exec_list(dev, exec, args->buffer_count);
1448 1449 1450
	if (ret)
		return ret;

1451
	dispatch_flags = 0;
1452
	if (args->flags & I915_EXEC_SECURE) {
1453
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1454 1455
		    return -EPERM;

1456
		dispatch_flags |= I915_DISPATCH_SECURE;
1457
	}
1458
	if (args->flags & I915_EXEC_IS_PINNED)
1459
		dispatch_flags |= I915_DISPATCH_PINNED;
1460

1461
	ret = eb_select_ring(dev_priv, file, args, &engine);
1462 1463
	if (ret)
		return ret;
1464 1465

	if (args->buffer_count < 1) {
1466
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1467 1468 1469
		return -EINVAL;
	}

1470 1471 1472 1473 1474
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1475
		if (engine->id != RCS) {
1476
			DRM_DEBUG("RS is not available on %s\n",
1477
				 engine->name);
1478 1479 1480 1481 1482 1483
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1484 1485 1486 1487 1488 1489
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1490 1491
	intel_runtime_pm_get(dev_priv);

1492 1493 1494 1495
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1496
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1497
	if (IS_ERR(ctx)) {
1498
		mutex_unlock(&dev->struct_mutex);
1499
		ret = PTR_ERR(ctx);
1500
		goto pre_mutex_err;
1501
	}
1502 1503 1504

	i915_gem_context_reference(ctx);

1505 1506 1507
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1508
		vm = &ggtt->base;
1509

1510 1511
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1512
	eb = eb_create(args);
1513
	if (eb == NULL) {
1514
		i915_gem_context_unreference(ctx);
1515 1516 1517 1518 1519
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1520
	/* Look up object handles */
1521
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1522 1523
	if (ret)
		goto err;
1524

1525
	/* take note of the batch buffer before we might reorder the lists */
1526
	batch_obj = eb_get_batch(eb);
1527

1528
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1529
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1530 1531
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1532 1533 1534 1535
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1536
	if (need_relocs)
B
Ben Widawsky 已提交
1537
		ret = i915_gem_execbuffer_relocate(eb);
1538 1539
	if (ret) {
		if (ret == -EFAULT) {
1540 1541
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1542
								eb, exec, ctx);
1543 1544 1545 1546 1547 1548 1549 1550
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
	if (batch_obj->base.pending_write_domain) {
1551
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1552 1553 1554 1555
		ret = -EINVAL;
		goto err;
	}

1556
	params->args_batch_start_offset = args->batch_start_offset;
1557
	if (i915_needs_cmd_parser(engine) && args->batch_len) {
1558 1559
		struct drm_i915_gem_object *parsed_batch_obj;

1560 1561 1562 1563 1564 1565
		parsed_batch_obj = i915_gem_execbuffer_parse(engine,
							     &shadow_exec_entry,
							     eb,
							     batch_obj,
							     args->batch_start_offset,
							     args->batch_len,
1566
							     drm_is_current_master(file));
1567 1568
		if (IS_ERR(parsed_batch_obj)) {
			ret = PTR_ERR(parsed_batch_obj);
1569 1570
			goto err;
		}
1571 1572

		/*
1573 1574
		 * parsed_batch_obj == batch_obj means batch not fully parsed:
		 * Accept, but don't promote to secure.
1575 1576
		 */

1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587
		if (parsed_batch_obj != batch_obj) {
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1588
			params->args_batch_start_offset = 0;
1589 1590
			batch_obj = parsed_batch_obj;
		}
1591 1592
	}

1593 1594
	batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;

1595 1596
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1597
	 * hsw should have this fixed, but bdw mucks it up again. */
1598
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1599 1600 1601 1602 1603 1604
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1605
		 *   so we don't really have issues with multiple objects not
1606 1607 1608 1609 1610 1611
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
		ret = i915_gem_obj_ggtt_pin(batch_obj, 0, 0);
		if (ret)
			goto err;
1612

1613
		params->batch_obj_vm_offset = i915_gem_obj_ggtt_offset(batch_obj);
1614
	} else
1615
		params->batch_obj_vm_offset = i915_gem_obj_offset(batch_obj, vm);
1616

1617
	/* Allocate a request for this batch buffer nice and early. */
1618
	req = i915_gem_request_alloc(engine, ctx);
1619 1620
	if (IS_ERR(req)) {
		ret = PTR_ERR(req);
1621
		goto err_batch_unpin;
1622
	}
1623

1624
	ret = i915_gem_request_add_to_client(req, file);
1625
	if (ret)
1626
		goto err_request;
1627

1628 1629 1630 1631 1632 1633 1634 1635
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1636
	params->engine                    = engine;
1637 1638 1639
	params->dispatch_flags          = dispatch_flags;
	params->batch_obj               = batch_obj;
	params->ctx                     = ctx;
1640
	params->request                 = req;
1641 1642

	ret = dev_priv->gt.execbuf_submit(params, args, &eb->vmas);
1643 1644
err_request:
	i915_gem_execbuffer_retire_commands(params);
1645

1646
err_batch_unpin:
1647 1648 1649 1650 1651 1652
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1653
	if (dispatch_flags & I915_DISPATCH_SECURE)
1654
		i915_gem_object_ggtt_unpin(batch_obj);
1655

1656
err:
1657 1658
	/* the request owns the ref now */
	i915_gem_context_unreference(ctx);
1659
	eb_destroy(eb);
1660 1661 1662 1663

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1664 1665 1666
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1685
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1686 1687 1688 1689 1690 1691 1692
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1693
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1694 1695 1696 1697 1698 1699
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1700
			     u64_to_user_ptr(args->buffers_ptr),
1701 1702
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1703
		DRM_DEBUG("copy %d exec entries failed %d\n",
1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1731
	i915_execbuffer2_set_context_id(exec2, 0);
1732

1733
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1734
	if (!ret) {
1735
		struct drm_i915_gem_exec_object __user *user_exec_list =
1736
			u64_to_user_ptr(args->buffers_ptr);
1737

1738
		/* Copy the new buffer offsets back to the user's exec list. */
1739
		for (i = 0; i < args->buffer_count; i++) {
1740 1741
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1742 1743 1744 1745 1746 1747 1748 1749 1750 1751
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1768 1769
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1770
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1771 1772 1773
		return -EINVAL;
	}

1774 1775 1776 1777 1778
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1779 1780 1781
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1782
	if (exec2_list == NULL) {
1783
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1784 1785 1786 1787
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1788
			     u64_to_user_ptr(args->buffers_ptr),
1789 1790
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1791
		DRM_DEBUG("copy %d exec entries failed %d\n",
1792 1793 1794 1795 1796
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1797
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1798 1799
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1800
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1801
				   u64_to_user_ptr(args->buffers_ptr);
1802 1803 1804
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1805 1806
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1807 1808 1809 1810 1811 1812 1813 1814 1815 1816
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1817 1818 1819 1820 1821 1822
		}
	}

	drm_free_large(exec2_list);
	return ret;
}