mv_xor.c 33.0 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
/*
 * offload engine driver for the Marvell XOR engine
 * Copyright (C) 2007, 2008, Marvell International Ltd.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms and conditions of the GNU General Public License,
 * version 2, as published by the Free Software Foundation.
 *
 * This program is distributed in the hope it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
 */

#include <linux/init.h>
#include <linux/module.h>
21
#include <linux/slab.h>
22 23 24 25 26 27
#include <linux/delay.h>
#include <linux/dma-mapping.h>
#include <linux/spinlock.h>
#include <linux/interrupt.h>
#include <linux/platform_device.h>
#include <linux/memory.h>
28
#include <linux/clk.h>
29 30 31
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/irqdomain.h>
32
#include <linux/platform_data/dma-mv_xor.h>
33 34

#include "dmaengine.h"
35 36 37 38 39
#include "mv_xor.h"

static void mv_xor_issue_pending(struct dma_chan *chan);

#define to_mv_xor_chan(chan)		\
40
	container_of(chan, struct mv_xor_chan, dmachan)
41 42 43 44

#define to_mv_xor_slot(tx)		\
	container_of(tx, struct mv_xor_desc_slot, async_tx)

45
#define mv_chan_to_devp(chan)           \
46
	((chan)->dmadev.dev)
47

48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101
static void mv_desc_init(struct mv_xor_desc_slot *desc, unsigned long flags)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;

	hw_desc->status = (1 << 31);
	hw_desc->phy_next_desc = 0;
	hw_desc->desc_command = (1 << 31);
}

static u32 mv_desc_get_dest_addr(struct mv_xor_desc_slot *desc)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
	return hw_desc->phy_dest_addr;
}

static void mv_desc_set_byte_count(struct mv_xor_desc_slot *desc,
				   u32 byte_count)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
	hw_desc->byte_count = byte_count;
}

static void mv_desc_set_next_desc(struct mv_xor_desc_slot *desc,
				  u32 next_desc_addr)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
	BUG_ON(hw_desc->phy_next_desc);
	hw_desc->phy_next_desc = next_desc_addr;
}

static void mv_desc_clear_next_desc(struct mv_xor_desc_slot *desc)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
	hw_desc->phy_next_desc = 0;
}

static void mv_desc_set_dest_addr(struct mv_xor_desc_slot *desc,
				  dma_addr_t addr)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
	hw_desc->phy_dest_addr = addr;
}

static int mv_chan_memset_slot_count(size_t len)
{
	return 1;
}

#define mv_chan_memcpy_slot_count(c) mv_chan_memset_slot_count(c)

static void mv_desc_set_src_addr(struct mv_xor_desc_slot *desc,
				 int index, dma_addr_t addr)
{
	struct mv_xor_desc *hw_desc = desc->hw_desc;
102
	hw_desc->phy_src_addr[mv_phy_src_idx(index)] = addr;
103 104 105 106 107 108
	if (desc->type == DMA_XOR)
		hw_desc->desc_command |= (1 << index);
}

static u32 mv_chan_get_current_desc(struct mv_xor_chan *chan)
{
109
	return readl_relaxed(XOR_CURR_DESC(chan));
110 111 112 113 114
}

static void mv_chan_set_next_descriptor(struct mv_xor_chan *chan,
					u32 next_desc_addr)
{
115
	writel_relaxed(next_desc_addr, XOR_NEXT_DESC(chan));
116 117 118 119
}

static void mv_chan_unmask_interrupts(struct mv_xor_chan *chan)
{
120
	u32 val = readl_relaxed(XOR_INTR_MASK(chan));
121
	val |= XOR_INTR_MASK_VALUE << (chan->idx * 16);
122
	writel_relaxed(val, XOR_INTR_MASK(chan));
123 124 125 126
}

static u32 mv_chan_get_intr_cause(struct mv_xor_chan *chan)
{
127
	u32 intr_cause = readl_relaxed(XOR_INTR_CAUSE(chan));
128 129 130 131 132 133 134 135 136 137 138 139 140 141
	intr_cause = (intr_cause >> (chan->idx * 16)) & 0xFFFF;
	return intr_cause;
}

static int mv_is_err_intr(u32 intr_cause)
{
	if (intr_cause & ((1<<4)|(1<<5)|(1<<6)|(1<<7)|(1<<8)|(1<<9)))
		return 1;

	return 0;
}

static void mv_xor_device_clear_eoc_cause(struct mv_xor_chan *chan)
{
142
	u32 val = ~(1 << (chan->idx * 16));
143
	dev_dbg(mv_chan_to_devp(chan), "%s, val 0x%08x\n", __func__, val);
144
	writel_relaxed(val, XOR_INTR_CAUSE(chan));
145 146 147 148 149
}

static void mv_xor_device_clear_err_status(struct mv_xor_chan *chan)
{
	u32 val = 0xFFFF0000 >> (chan->idx * 16);
150
	writel_relaxed(val, XOR_INTR_CAUSE(chan));
151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167
}

static int mv_can_chain(struct mv_xor_desc_slot *desc)
{
	struct mv_xor_desc_slot *chain_old_tail = list_entry(
		desc->chain_node.prev, struct mv_xor_desc_slot, chain_node);

	if (chain_old_tail->type != desc->type)
		return 0;

	return 1;
}

static void mv_set_mode(struct mv_xor_chan *chan,
			       enum dma_transaction_type type)
{
	u32 op_mode;
168
	u32 config = readl_relaxed(XOR_CONFIG(chan));
169 170 171 172 173 174 175 176 177

	switch (type) {
	case DMA_XOR:
		op_mode = XOR_OPERATION_MODE_XOR;
		break;
	case DMA_MEMCPY:
		op_mode = XOR_OPERATION_MODE_MEMCPY;
		break;
	default:
178
		dev_err(mv_chan_to_devp(chan),
179
			"error: unsupported operation %d\n",
180
			type);
181 182 183 184 185 186
		BUG();
		return;
	}

	config &= ~0x7;
	config |= op_mode;
187 188 189 190 191 192 193

#if defined(__BIG_ENDIAN)
	config |= XOR_DESCRIPTOR_SWAP;
#else
	config &= ~XOR_DESCRIPTOR_SWAP;
#endif

194
	writel_relaxed(config, XOR_CONFIG(chan));
195 196 197 198 199 200 201
	chan->current_type = type;
}

static void mv_chan_activate(struct mv_xor_chan *chan)
{
	u32 activation;

202
	dev_dbg(mv_chan_to_devp(chan), " activate chan.\n");
203
	activation = readl_relaxed(XOR_ACTIVATION(chan));
204
	activation |= 0x1;
205
	writel_relaxed(activation, XOR_ACTIVATION(chan));
206 207 208 209
}

static char mv_chan_is_busy(struct mv_xor_chan *chan)
{
210
	u32 state = readl_relaxed(XOR_ACTIVATION(chan));
211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229

	state = (state >> 4) & 0x3;

	return (state == 1) ? 1 : 0;
}

static int mv_chan_xor_slot_count(size_t len, int src_cnt)
{
	return 1;
}

/**
 * mv_xor_free_slots - flags descriptor slots for reuse
 * @slot: Slot to free
 * Caller must hold &mv_chan->lock while calling this function
 */
static void mv_xor_free_slots(struct mv_xor_chan *mv_chan,
			      struct mv_xor_desc_slot *slot)
{
230
	dev_dbg(mv_chan_to_devp(mv_chan), "%s %d slot %p\n",
231 232 233 234 235 236 237 238 239 240 241 242 243 244
		__func__, __LINE__, slot);

	slot->slots_per_op = 0;

}

/*
 * mv_xor_start_new_chain - program the engine to operate on new chain headed by
 * sw_desc
 * Caller must hold &mv_chan->lock while calling this function
 */
static void mv_xor_start_new_chain(struct mv_xor_chan *mv_chan,
				   struct mv_xor_desc_slot *sw_desc)
{
245
	dev_dbg(mv_chan_to_devp(mv_chan), "%s %d: sw_desc %p\n",
246 247 248 249
		__func__, __LINE__, sw_desc);
	if (sw_desc->type != mv_chan->current_type)
		mv_set_mode(mv_chan, sw_desc->type);

250 251 252
	/* set the hardware chain */
	mv_chan_set_next_descriptor(mv_chan, sw_desc->async_tx.phys);

253
	mv_chan->pending += sw_desc->slot_cnt;
254
	mv_xor_issue_pending(&mv_chan->dmachan);
255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272
}

static dma_cookie_t
mv_xor_run_tx_complete_actions(struct mv_xor_desc_slot *desc,
	struct mv_xor_chan *mv_chan, dma_cookie_t cookie)
{
	BUG_ON(desc->async_tx.cookie < 0);

	if (desc->async_tx.cookie > 0) {
		cookie = desc->async_tx.cookie;

		/* call the callback (must not sleep or submit new
		 * operations to this channel)
		 */
		if (desc->async_tx.callback)
			desc->async_tx.callback(
				desc->async_tx.callback_param);

273
		dma_descriptor_unmap(&desc->async_tx);
274
		if (desc->group_head)
275 276 277 278
			desc->group_head = NULL;
	}

	/* run dependent operations */
279
	dma_run_dependencies(&desc->async_tx);
280 281 282 283 284 285 286 287 288

	return cookie;
}

static int
mv_xor_clean_completed_slots(struct mv_xor_chan *mv_chan)
{
	struct mv_xor_desc_slot *iter, *_iter;

289
	dev_dbg(mv_chan_to_devp(mv_chan), "%s %d\n", __func__, __LINE__);
290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
	list_for_each_entry_safe(iter, _iter, &mv_chan->completed_slots,
				 completed_node) {

		if (async_tx_test_ack(&iter->async_tx)) {
			list_del(&iter->completed_node);
			mv_xor_free_slots(mv_chan, iter);
		}
	}
	return 0;
}

static int
mv_xor_clean_slot(struct mv_xor_desc_slot *desc,
	struct mv_xor_chan *mv_chan)
{
305
	dev_dbg(mv_chan_to_devp(mv_chan), "%s %d: desc %p flags %d\n",
306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328
		__func__, __LINE__, desc, desc->async_tx.flags);
	list_del(&desc->chain_node);
	/* the client is allowed to attach dependent operations
	 * until 'ack' is set
	 */
	if (!async_tx_test_ack(&desc->async_tx)) {
		/* move this slot to the completed_slots */
		list_add_tail(&desc->completed_node, &mv_chan->completed_slots);
		return 0;
	}

	mv_xor_free_slots(mv_chan, desc);
	return 0;
}

static void __mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
{
	struct mv_xor_desc_slot *iter, *_iter;
	dma_cookie_t cookie = 0;
	int busy = mv_chan_is_busy(mv_chan);
	u32 current_desc = mv_chan_get_current_desc(mv_chan);
	int seen_current = 0;

329 330
	dev_dbg(mv_chan_to_devp(mv_chan), "%s %d\n", __func__, __LINE__);
	dev_dbg(mv_chan_to_devp(mv_chan), "current_desc %x\n", current_desc);
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
	mv_xor_clean_completed_slots(mv_chan);

	/* free completed slots from the chain starting with
	 * the oldest descriptor
	 */

	list_for_each_entry_safe(iter, _iter, &mv_chan->chain,
					chain_node) {
		prefetch(_iter);
		prefetch(&_iter->async_tx);

		/* do not advance past the current descriptor loaded into the
		 * hardware channel, subsequent descriptors are either in
		 * process or have not been submitted
		 */
		if (seen_current)
			break;

		/* stop the search if we reach the current descriptor and the
		 * channel is busy
		 */
		if (iter->async_tx.phys == current_desc) {
			seen_current = 1;
			if (busy)
				break;
		}

		cookie = mv_xor_run_tx_complete_actions(iter, mv_chan, cookie);

		if (mv_xor_clean_slot(iter, mv_chan))
			break;
	}

	if ((busy == 0) && !list_empty(&mv_chan->chain)) {
		struct mv_xor_desc_slot *chain_head;
		chain_head = list_entry(mv_chan->chain.next,
					struct mv_xor_desc_slot,
					chain_node);

		mv_xor_start_new_chain(mv_chan, chain_head);
	}

	if (cookie > 0)
374
		mv_chan->dmachan.completed_cookie = cookie;
375 376 377 378 379 380 381 382 383 384 385 386 387
}

static void
mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
{
	spin_lock_bh(&mv_chan->lock);
	__mv_xor_slot_cleanup(mv_chan);
	spin_unlock_bh(&mv_chan->lock);
}

static void mv_xor_tasklet(unsigned long data)
{
	struct mv_xor_chan *chan = (struct mv_xor_chan *) data;
388
	mv_xor_slot_cleanup(chan);
389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456
}

static struct mv_xor_desc_slot *
mv_xor_alloc_slots(struct mv_xor_chan *mv_chan, int num_slots,
		    int slots_per_op)
{
	struct mv_xor_desc_slot *iter, *_iter, *alloc_start = NULL;
	LIST_HEAD(chain);
	int slots_found, retry = 0;

	/* start search from the last allocated descrtiptor
	 * if a contiguous allocation can not be found start searching
	 * from the beginning of the list
	 */
retry:
	slots_found = 0;
	if (retry == 0)
		iter = mv_chan->last_used;
	else
		iter = list_entry(&mv_chan->all_slots,
			struct mv_xor_desc_slot,
			slot_node);

	list_for_each_entry_safe_continue(
		iter, _iter, &mv_chan->all_slots, slot_node) {
		prefetch(_iter);
		prefetch(&_iter->async_tx);
		if (iter->slots_per_op) {
			/* give up after finding the first busy slot
			 * on the second pass through the list
			 */
			if (retry)
				break;

			slots_found = 0;
			continue;
		}

		/* start the allocation if the slot is correctly aligned */
		if (!slots_found++)
			alloc_start = iter;

		if (slots_found == num_slots) {
			struct mv_xor_desc_slot *alloc_tail = NULL;
			struct mv_xor_desc_slot *last_used = NULL;
			iter = alloc_start;
			while (num_slots) {
				int i;

				/* pre-ack all but the last descriptor */
				async_tx_ack(&iter->async_tx);

				list_add_tail(&iter->chain_node, &chain);
				alloc_tail = iter;
				iter->async_tx.cookie = 0;
				iter->slot_cnt = num_slots;
				iter->xor_check_result = NULL;
				for (i = 0; i < slots_per_op; i++) {
					iter->slots_per_op = slots_per_op - i;
					last_used = iter;
					iter = list_entry(iter->slot_node.next,
						struct mv_xor_desc_slot,
						slot_node);
				}
				num_slots -= slots_per_op;
			}
			alloc_tail->group_head = alloc_start;
			alloc_tail->async_tx.cookie = -EBUSY;
457
			list_splice(&chain, &alloc_tail->tx_list);
458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482
			mv_chan->last_used = last_used;
			mv_desc_clear_next_desc(alloc_start);
			mv_desc_clear_next_desc(alloc_tail);
			return alloc_tail;
		}
	}
	if (!retry++)
		goto retry;

	/* try to free some slots if the allocation fails */
	tasklet_schedule(&mv_chan->irq_tasklet);

	return NULL;
}

/************************ DMA engine API functions ****************************/
static dma_cookie_t
mv_xor_tx_submit(struct dma_async_tx_descriptor *tx)
{
	struct mv_xor_desc_slot *sw_desc = to_mv_xor_slot(tx);
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(tx->chan);
	struct mv_xor_desc_slot *grp_start, *old_chain_tail;
	dma_cookie_t cookie;
	int new_hw_chain = 1;

483
	dev_dbg(mv_chan_to_devp(mv_chan),
484 485 486 487 488 489
		"%s sw_desc %p: async_tx %p\n",
		__func__, sw_desc, &sw_desc->async_tx);

	grp_start = sw_desc->group_head;

	spin_lock_bh(&mv_chan->lock);
490
	cookie = dma_cookie_assign(tx);
491 492

	if (list_empty(&mv_chan->chain))
493
		list_splice_init(&sw_desc->tx_list, &mv_chan->chain);
494 495 496 497 498 499
	else {
		new_hw_chain = 0;

		old_chain_tail = list_entry(mv_chan->chain.prev,
					    struct mv_xor_desc_slot,
					    chain_node);
500
		list_splice_init(&grp_start->tx_list,
501 502 503 504 505
				 &old_chain_tail->chain_node);

		if (!mv_can_chain(grp_start))
			goto submit_done;

506
		dev_dbg(mv_chan_to_devp(mv_chan), "Append to last desc %x\n",
507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
			old_chain_tail->async_tx.phys);

		/* fix up the hardware chain */
		mv_desc_set_next_desc(old_chain_tail, grp_start->async_tx.phys);

		/* if the channel is not busy */
		if (!mv_chan_is_busy(mv_chan)) {
			u32 current_desc = mv_chan_get_current_desc(mv_chan);
			/*
			 * and the curren desc is the end of the chain before
			 * the append, then we need to start the channel
			 */
			if (current_desc == old_chain_tail->async_tx.phys)
				new_hw_chain = 1;
		}
	}

	if (new_hw_chain)
		mv_xor_start_new_chain(mv_chan, grp_start);

submit_done:
	spin_unlock_bh(&mv_chan->lock);

	return cookie;
}

/* returns the number of allocated descriptors */
534
static int mv_xor_alloc_chan_resources(struct dma_chan *chan)
535 536 537 538 539
{
	char *hw_desc;
	int idx;
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
	struct mv_xor_desc_slot *slot = NULL;
540
	int num_descs_in_pool = MV_XOR_POOL_SIZE/MV_XOR_SLOT_SIZE;
541 542 543 544 545 546 547 548 549 550

	/* Allocate descriptor slots */
	idx = mv_chan->slots_allocated;
	while (idx < num_descs_in_pool) {
		slot = kzalloc(sizeof(*slot), GFP_KERNEL);
		if (!slot) {
			printk(KERN_INFO "MV XOR Channel only initialized"
				" %d descriptor slots", idx);
			break;
		}
551
		hw_desc = (char *) mv_chan->dma_desc_pool_virt;
552 553 554 555 556 557
		slot->hw_desc = (void *) &hw_desc[idx * MV_XOR_SLOT_SIZE];

		dma_async_tx_descriptor_init(&slot->async_tx, chan);
		slot->async_tx.tx_submit = mv_xor_tx_submit;
		INIT_LIST_HEAD(&slot->chain_node);
		INIT_LIST_HEAD(&slot->slot_node);
558
		INIT_LIST_HEAD(&slot->tx_list);
559
		hw_desc = (char *) mv_chan->dma_desc_pool;
560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
		slot->async_tx.phys =
			(dma_addr_t) &hw_desc[idx * MV_XOR_SLOT_SIZE];
		slot->idx = idx++;

		spin_lock_bh(&mv_chan->lock);
		mv_chan->slots_allocated = idx;
		list_add_tail(&slot->slot_node, &mv_chan->all_slots);
		spin_unlock_bh(&mv_chan->lock);
	}

	if (mv_chan->slots_allocated && !mv_chan->last_used)
		mv_chan->last_used = list_entry(mv_chan->all_slots.next,
					struct mv_xor_desc_slot,
					slot_node);

575
	dev_dbg(mv_chan_to_devp(mv_chan),
576 577 578 579 580 581 582 583 584 585 586 587 588 589
		"allocated %d descriptor slots last_used: %p\n",
		mv_chan->slots_allocated, mv_chan->last_used);

	return mv_chan->slots_allocated ? : -ENOMEM;
}

static struct dma_async_tx_descriptor *
mv_xor_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
		size_t len, unsigned long flags)
{
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
	struct mv_xor_desc_slot *sw_desc, *grp_start;
	int slot_cnt;

590
	dev_dbg(mv_chan_to_devp(mv_chan),
591 592 593 594 595
		"%s dest: %x src %x len: %u flags: %ld\n",
		__func__, dest, src, len, flags);
	if (unlikely(len < MV_XOR_MIN_BYTE_COUNT))
		return NULL;

596
	BUG_ON(len > MV_XOR_MAX_BYTE_COUNT);
597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613

	spin_lock_bh(&mv_chan->lock);
	slot_cnt = mv_chan_memcpy_slot_count(len);
	sw_desc = mv_xor_alloc_slots(mv_chan, slot_cnt, 1);
	if (sw_desc) {
		sw_desc->type = DMA_MEMCPY;
		sw_desc->async_tx.flags = flags;
		grp_start = sw_desc->group_head;
		mv_desc_init(grp_start, flags);
		mv_desc_set_byte_count(grp_start, len);
		mv_desc_set_dest_addr(sw_desc->group_head, dest);
		mv_desc_set_src_addr(grp_start, 0, src);
		sw_desc->unmap_src_cnt = 1;
		sw_desc->unmap_len = len;
	}
	spin_unlock_bh(&mv_chan->lock);

614
	dev_dbg(mv_chan_to_devp(mv_chan),
615
		"%s sw_desc %p async_tx %p\n",
J
Jingoo Han 已提交
616
		__func__, sw_desc, sw_desc ? &sw_desc->async_tx : NULL);
617 618 619 620 621 622 623 624 625 626 627 628 629 630 631

	return sw_desc ? &sw_desc->async_tx : NULL;
}

static struct dma_async_tx_descriptor *
mv_xor_prep_dma_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src,
		    unsigned int src_cnt, size_t len, unsigned long flags)
{
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
	struct mv_xor_desc_slot *sw_desc, *grp_start;
	int slot_cnt;

	if (unlikely(len < MV_XOR_MIN_BYTE_COUNT))
		return NULL;

632
	BUG_ON(len > MV_XOR_MAX_BYTE_COUNT);
633

634
	dev_dbg(mv_chan_to_devp(mv_chan),
635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654
		"%s src_cnt: %d len: dest %x %u flags: %ld\n",
		__func__, src_cnt, len, dest, flags);

	spin_lock_bh(&mv_chan->lock);
	slot_cnt = mv_chan_xor_slot_count(len, src_cnt);
	sw_desc = mv_xor_alloc_slots(mv_chan, slot_cnt, 1);
	if (sw_desc) {
		sw_desc->type = DMA_XOR;
		sw_desc->async_tx.flags = flags;
		grp_start = sw_desc->group_head;
		mv_desc_init(grp_start, flags);
		/* the byte count field is the same as in memcpy desc*/
		mv_desc_set_byte_count(grp_start, len);
		mv_desc_set_dest_addr(sw_desc->group_head, dest);
		sw_desc->unmap_src_cnt = src_cnt;
		sw_desc->unmap_len = len;
		while (src_cnt--)
			mv_desc_set_src_addr(grp_start, src_cnt, src[src_cnt]);
	}
	spin_unlock_bh(&mv_chan->lock);
655
	dev_dbg(mv_chan_to_devp(mv_chan),
656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687
		"%s sw_desc %p async_tx %p \n",
		__func__, sw_desc, &sw_desc->async_tx);
	return sw_desc ? &sw_desc->async_tx : NULL;
}

static void mv_xor_free_chan_resources(struct dma_chan *chan)
{
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
	struct mv_xor_desc_slot *iter, *_iter;
	int in_use_descs = 0;

	mv_xor_slot_cleanup(mv_chan);

	spin_lock_bh(&mv_chan->lock);
	list_for_each_entry_safe(iter, _iter, &mv_chan->chain,
					chain_node) {
		in_use_descs++;
		list_del(&iter->chain_node);
	}
	list_for_each_entry_safe(iter, _iter, &mv_chan->completed_slots,
				 completed_node) {
		in_use_descs++;
		list_del(&iter->completed_node);
	}
	list_for_each_entry_safe_reverse(
		iter, _iter, &mv_chan->all_slots, slot_node) {
		list_del(&iter->slot_node);
		kfree(iter);
		mv_chan->slots_allocated--;
	}
	mv_chan->last_used = NULL;

688
	dev_dbg(mv_chan_to_devp(mv_chan), "%s slots_allocated %d\n",
689 690 691 692
		__func__, mv_chan->slots_allocated);
	spin_unlock_bh(&mv_chan->lock);

	if (in_use_descs)
693
		dev_err(mv_chan_to_devp(mv_chan),
694 695 696 697
			"freeing %d in use descriptors!\n", in_use_descs);
}

/**
698
 * mv_xor_status - poll the status of an XOR transaction
699 700
 * @chan: XOR channel handle
 * @cookie: XOR transaction identifier
701
 * @txstate: XOR transactions state holder (or NULL)
702
 */
703
static enum dma_status mv_xor_status(struct dma_chan *chan,
704
					  dma_cookie_t cookie,
705
					  struct dma_tx_state *txstate)
706 707 708 709
{
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
	enum dma_status ret;

710
	ret = dma_cookie_status(chan, cookie, txstate);
711 712 713 714 715 716
	if (ret == DMA_SUCCESS) {
		mv_xor_clean_completed_slots(mv_chan);
		return ret;
	}
	mv_xor_slot_cleanup(mv_chan);

717
	return dma_cookie_status(chan, cookie, txstate);
718 719 720 721 722 723
}

static void mv_dump_xor_regs(struct mv_xor_chan *chan)
{
	u32 val;

724
	val = readl_relaxed(XOR_CONFIG(chan));
725
	dev_err(mv_chan_to_devp(chan), "config       0x%08x\n", val);
726

727
	val = readl_relaxed(XOR_ACTIVATION(chan));
728
	dev_err(mv_chan_to_devp(chan), "activation   0x%08x\n", val);
729

730
	val = readl_relaxed(XOR_INTR_CAUSE(chan));
731
	dev_err(mv_chan_to_devp(chan), "intr cause   0x%08x\n", val);
732

733
	val = readl_relaxed(XOR_INTR_MASK(chan));
734
	dev_err(mv_chan_to_devp(chan), "intr mask    0x%08x\n", val);
735

736
	val = readl_relaxed(XOR_ERROR_CAUSE(chan));
737
	dev_err(mv_chan_to_devp(chan), "error cause  0x%08x\n", val);
738

739
	val = readl_relaxed(XOR_ERROR_ADDR(chan));
740
	dev_err(mv_chan_to_devp(chan), "error addr   0x%08x\n", val);
741 742 743 744 745 746
}

static void mv_xor_err_interrupt_handler(struct mv_xor_chan *chan,
					 u32 intr_cause)
{
	if (intr_cause & (1 << 4)) {
747
	     dev_dbg(mv_chan_to_devp(chan),
748 749 750 751
		     "ignore this error\n");
	     return;
	}

752
	dev_err(mv_chan_to_devp(chan),
753
		"error on chan %d. intr cause 0x%08x\n",
754
		chan->idx, intr_cause);
755 756 757 758 759 760 761 762 763 764

	mv_dump_xor_regs(chan);
	BUG();
}

static irqreturn_t mv_xor_interrupt_handler(int irq, void *data)
{
	struct mv_xor_chan *chan = data;
	u32 intr_cause = mv_chan_get_intr_cause(chan);

765
	dev_dbg(mv_chan_to_devp(chan), "intr cause %x\n", intr_cause);
766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791

	if (mv_is_err_intr(intr_cause))
		mv_xor_err_interrupt_handler(chan, intr_cause);

	tasklet_schedule(&chan->irq_tasklet);

	mv_xor_device_clear_eoc_cause(chan);

	return IRQ_HANDLED;
}

static void mv_xor_issue_pending(struct dma_chan *chan)
{
	struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);

	if (mv_chan->pending >= MV_XOR_THRESHOLD) {
		mv_chan->pending = 0;
		mv_chan_activate(mv_chan);
	}
}

/*
 * Perform a transaction to verify the HW works.
 */
#define MV_XOR_TEST_SIZE 2000

792
static int mv_xor_memcpy_self_test(struct mv_xor_chan *mv_chan)
793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815
{
	int i;
	void *src, *dest;
	dma_addr_t src_dma, dest_dma;
	struct dma_chan *dma_chan;
	dma_cookie_t cookie;
	struct dma_async_tx_descriptor *tx;
	int err = 0;

	src = kmalloc(sizeof(u8) * MV_XOR_TEST_SIZE, GFP_KERNEL);
	if (!src)
		return -ENOMEM;

	dest = kzalloc(sizeof(u8) * MV_XOR_TEST_SIZE, GFP_KERNEL);
	if (!dest) {
		kfree(src);
		return -ENOMEM;
	}

	/* Fill in src buffer */
	for (i = 0; i < MV_XOR_TEST_SIZE; i++)
		((u8 *) src)[i] = (u8)i;

816
	dma_chan = &mv_chan->dmachan;
817
	if (mv_xor_alloc_chan_resources(dma_chan) < 1) {
818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834
		err = -ENODEV;
		goto out;
	}

	dest_dma = dma_map_single(dma_chan->device->dev, dest,
				  MV_XOR_TEST_SIZE, DMA_FROM_DEVICE);

	src_dma = dma_map_single(dma_chan->device->dev, src,
				 MV_XOR_TEST_SIZE, DMA_TO_DEVICE);

	tx = mv_xor_prep_dma_memcpy(dma_chan, dest_dma, src_dma,
				    MV_XOR_TEST_SIZE, 0);
	cookie = mv_xor_tx_submit(tx);
	mv_xor_issue_pending(dma_chan);
	async_tx_ack(tx);
	msleep(1);

835
	if (mv_xor_status(dma_chan, cookie, NULL) !=
836
	    DMA_SUCCESS) {
837 838
		dev_err(dma_chan->device->dev,
			"Self-test copy timed out, disabling\n");
839 840 841 842
		err = -ENODEV;
		goto free_resources;
	}

843
	dma_sync_single_for_cpu(dma_chan->device->dev, dest_dma,
844 845
				MV_XOR_TEST_SIZE, DMA_FROM_DEVICE);
	if (memcmp(src, dest, MV_XOR_TEST_SIZE)) {
846 847
		dev_err(dma_chan->device->dev,
			"Self-test copy failed compare, disabling\n");
848 849 850 851 852 853 854 855 856 857 858 859 860
		err = -ENODEV;
		goto free_resources;
	}

free_resources:
	mv_xor_free_chan_resources(dma_chan);
out:
	kfree(src);
	kfree(dest);
	return err;
}

#define MV_XOR_NUM_SRC_TEST 4 /* must be <= 15 */
B
Bill Pemberton 已提交
861
static int
862
mv_xor_xor_self_test(struct mv_xor_chan *mv_chan)
863 864 865 866 867 868 869 870 871 872 873 874 875 876 877
{
	int i, src_idx;
	struct page *dest;
	struct page *xor_srcs[MV_XOR_NUM_SRC_TEST];
	dma_addr_t dma_srcs[MV_XOR_NUM_SRC_TEST];
	dma_addr_t dest_dma;
	struct dma_async_tx_descriptor *tx;
	struct dma_chan *dma_chan;
	dma_cookie_t cookie;
	u8 cmp_byte = 0;
	u32 cmp_word;
	int err = 0;

	for (src_idx = 0; src_idx < MV_XOR_NUM_SRC_TEST; src_idx++) {
		xor_srcs[src_idx] = alloc_page(GFP_KERNEL);
878 879
		if (!xor_srcs[src_idx]) {
			while (src_idx--)
880
				__free_page(xor_srcs[src_idx]);
881 882
			return -ENOMEM;
		}
883 884 885
	}

	dest = alloc_page(GFP_KERNEL);
886 887
	if (!dest) {
		while (src_idx--)
888
			__free_page(xor_srcs[src_idx]);
889 890
		return -ENOMEM;
	}
891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906

	/* Fill in src buffers */
	for (src_idx = 0; src_idx < MV_XOR_NUM_SRC_TEST; src_idx++) {
		u8 *ptr = page_address(xor_srcs[src_idx]);
		for (i = 0; i < PAGE_SIZE; i++)
			ptr[i] = (1 << src_idx);
	}

	for (src_idx = 0; src_idx < MV_XOR_NUM_SRC_TEST; src_idx++)
		cmp_byte ^= (u8) (1 << src_idx);

	cmp_word = (cmp_byte << 24) | (cmp_byte << 16) |
		(cmp_byte << 8) | cmp_byte;

	memset(page_address(dest), 0, PAGE_SIZE);

907
	dma_chan = &mv_chan->dmachan;
908
	if (mv_xor_alloc_chan_resources(dma_chan) < 1) {
909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928
		err = -ENODEV;
		goto out;
	}

	/* test xor */
	dest_dma = dma_map_page(dma_chan->device->dev, dest, 0, PAGE_SIZE,
				DMA_FROM_DEVICE);

	for (i = 0; i < MV_XOR_NUM_SRC_TEST; i++)
		dma_srcs[i] = dma_map_page(dma_chan->device->dev, xor_srcs[i],
					   0, PAGE_SIZE, DMA_TO_DEVICE);

	tx = mv_xor_prep_dma_xor(dma_chan, dest_dma, dma_srcs,
				 MV_XOR_NUM_SRC_TEST, PAGE_SIZE, 0);

	cookie = mv_xor_tx_submit(tx);
	mv_xor_issue_pending(dma_chan);
	async_tx_ack(tx);
	msleep(8);

929
	if (mv_xor_status(dma_chan, cookie, NULL) !=
930
	    DMA_SUCCESS) {
931 932
		dev_err(dma_chan->device->dev,
			"Self-test xor timed out, disabling\n");
933 934 935 936
		err = -ENODEV;
		goto free_resources;
	}

937
	dma_sync_single_for_cpu(dma_chan->device->dev, dest_dma,
938 939 940 941
				PAGE_SIZE, DMA_FROM_DEVICE);
	for (i = 0; i < (PAGE_SIZE / sizeof(u32)); i++) {
		u32 *ptr = page_address(dest);
		if (ptr[i] != cmp_word) {
942
			dev_err(dma_chan->device->dev,
943 944
				"Self-test xor failed compare, disabling. index %d, data %x, expected %x\n",
				i, ptr[i], cmp_word);
945 946 947 948 949 950 951 952 953 954 955 956 957 958 959
			err = -ENODEV;
			goto free_resources;
		}
	}

free_resources:
	mv_xor_free_chan_resources(dma_chan);
out:
	src_idx = MV_XOR_NUM_SRC_TEST;
	while (src_idx--)
		__free_page(xor_srcs[src_idx]);
	__free_page(dest);
	return err;
}

960 961 962 963 964 965 966 967
/* This driver does not implement any of the optional DMA operations. */
static int
mv_xor_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
	       unsigned long arg)
{
	return -ENOSYS;
}

968
static int mv_xor_channel_remove(struct mv_xor_chan *mv_chan)
969 970
{
	struct dma_chan *chan, *_chan;
971
	struct device *dev = mv_chan->dmadev.dev;
972

973
	dma_async_device_unregister(&mv_chan->dmadev);
974

975
	dma_free_coherent(dev, MV_XOR_POOL_SIZE,
976
			  mv_chan->dma_desc_pool_virt, mv_chan->dma_desc_pool);
977

978
	list_for_each_entry_safe(chan, _chan, &mv_chan->dmadev.channels,
979
				 device_node) {
980 981 982
		list_del(&chan->device_node);
	}

983 984
	free_irq(mv_chan->irq, mv_chan);

985 986 987
	return 0;
}

988
static struct mv_xor_chan *
989
mv_xor_channel_add(struct mv_xor_device *xordev,
990
		   struct platform_device *pdev,
991
		   int idx, dma_cap_mask_t cap_mask, int irq)
992 993 994 995 996
{
	int ret = 0;
	struct mv_xor_chan *mv_chan;
	struct dma_device *dma_dev;

997
	mv_chan = devm_kzalloc(&pdev->dev, sizeof(*mv_chan), GFP_KERNEL);
998 999
	if (!mv_chan)
		return ERR_PTR(-ENOMEM);
1000

1001
	mv_chan->idx = idx;
1002
	mv_chan->irq = irq;
1003

1004
	dma_dev = &mv_chan->dmadev;
1005 1006 1007 1008 1009

	/* allocate coherent memory for hardware descriptors
	 * note: writecombine gives slightly better performance, but
	 * requires that we explicitly flush the writes
	 */
1010
	mv_chan->dma_desc_pool_virt =
1011
	  dma_alloc_writecombine(&pdev->dev, MV_XOR_POOL_SIZE,
1012 1013
				 &mv_chan->dma_desc_pool, GFP_KERNEL);
	if (!mv_chan->dma_desc_pool_virt)
1014
		return ERR_PTR(-ENOMEM);
1015 1016

	/* discover transaction capabilites from the platform data */
1017
	dma_dev->cap_mask = cap_mask;
1018 1019 1020 1021 1022 1023

	INIT_LIST_HEAD(&dma_dev->channels);

	/* set base routines */
	dma_dev->device_alloc_chan_resources = mv_xor_alloc_chan_resources;
	dma_dev->device_free_chan_resources = mv_xor_free_chan_resources;
1024
	dma_dev->device_tx_status = mv_xor_status;
1025
	dma_dev->device_issue_pending = mv_xor_issue_pending;
1026
	dma_dev->device_control = mv_xor_control;
1027 1028 1029 1030 1031 1032
	dma_dev->dev = &pdev->dev;

	/* set prep routines based on capability */
	if (dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask))
		dma_dev->device_prep_dma_memcpy = mv_xor_prep_dma_memcpy;
	if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) {
1033
		dma_dev->max_xor = 8;
1034 1035 1036
		dma_dev->device_prep_dma_xor = mv_xor_prep_dma_xor;
	}

1037
	mv_chan->mmr_base = xordev->xor_base;
1038 1039 1040 1041 1042 1043 1044 1045 1046 1047
	if (!mv_chan->mmr_base) {
		ret = -ENOMEM;
		goto err_free_dma;
	}
	tasklet_init(&mv_chan->irq_tasklet, mv_xor_tasklet, (unsigned long)
		     mv_chan);

	/* clear errors before enabling interrupts */
	mv_xor_device_clear_err_status(mv_chan);

1048 1049
	ret = request_irq(mv_chan->irq, mv_xor_interrupt_handler,
			  0, dev_name(&pdev->dev), mv_chan);
1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060
	if (ret)
		goto err_free_dma;

	mv_chan_unmask_interrupts(mv_chan);

	mv_set_mode(mv_chan, DMA_MEMCPY);

	spin_lock_init(&mv_chan->lock);
	INIT_LIST_HEAD(&mv_chan->chain);
	INIT_LIST_HEAD(&mv_chan->completed_slots);
	INIT_LIST_HEAD(&mv_chan->all_slots);
1061 1062
	mv_chan->dmachan.device = dma_dev;
	dma_cookie_init(&mv_chan->dmachan);
1063

1064
	list_add_tail(&mv_chan->dmachan.device_node, &dma_dev->channels);
1065 1066

	if (dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask)) {
1067
		ret = mv_xor_memcpy_self_test(mv_chan);
1068 1069
		dev_dbg(&pdev->dev, "memcpy self test returned %d\n", ret);
		if (ret)
1070
			goto err_free_irq;
1071 1072 1073
	}

	if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) {
1074
		ret = mv_xor_xor_self_test(mv_chan);
1075 1076
		dev_dbg(&pdev->dev, "xor self test returned %d\n", ret);
		if (ret)
1077
			goto err_free_irq;
1078 1079
	}

1080
	dev_info(&pdev->dev, "Marvell XOR: ( %s%s%s)\n",
1081 1082 1083
		 dma_has_cap(DMA_XOR, dma_dev->cap_mask) ? "xor " : "",
		 dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask) ? "cpy " : "",
		 dma_has_cap(DMA_INTERRUPT, dma_dev->cap_mask) ? "intr " : "");
1084 1085

	dma_async_device_register(dma_dev);
1086
	return mv_chan;
1087

1088 1089
err_free_irq:
	free_irq(mv_chan->irq, mv_chan);
1090
 err_free_dma:
1091
	dma_free_coherent(&pdev->dev, MV_XOR_POOL_SIZE,
1092
			  mv_chan->dma_desc_pool_virt, mv_chan->dma_desc_pool);
1093
	return ERR_PTR(ret);
1094 1095 1096
}

static void
1097
mv_xor_conf_mbus_windows(struct mv_xor_device *xordev,
1098
			 const struct mbus_dram_target_info *dram)
1099
{
1100
	void __iomem *base = xordev->xor_base;
1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
	u32 win_enable = 0;
	int i;

	for (i = 0; i < 8; i++) {
		writel(0, base + WINDOW_BASE(i));
		writel(0, base + WINDOW_SIZE(i));
		if (i < 4)
			writel(0, base + WINDOW_REMAP_HIGH(i));
	}

	for (i = 0; i < dram->num_cs; i++) {
1112
		const struct mbus_dram_window *cs = dram->cs + i;
1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124

		writel((cs->base & 0xffff0000) |
		       (cs->mbus_attr << 8) |
		       dram->mbus_dram_target_id, base + WINDOW_BASE(i));
		writel((cs->size - 1) & 0xffff0000, base + WINDOW_SIZE(i));

		win_enable |= (1 << i);
		win_enable |= 3 << (16 + (2 * i));
	}

	writel(win_enable, base + WINDOW_BAR_ENABLE(0));
	writel(win_enable, base + WINDOW_BAR_ENABLE(1));
1125 1126
	writel(0, base + WINDOW_OVERRIDE_CTRL(0));
	writel(0, base + WINDOW_OVERRIDE_CTRL(1));
1127 1128
}

1129
static int mv_xor_probe(struct platform_device *pdev)
1130
{
1131
	const struct mbus_dram_target_info *dram;
1132
	struct mv_xor_device *xordev;
J
Jingoo Han 已提交
1133
	struct mv_xor_platform_data *pdata = dev_get_platdata(&pdev->dev);
1134
	struct resource *res;
1135
	int i, ret;
1136

1137
	dev_notice(&pdev->dev, "Marvell shared XOR driver\n");
1138

1139 1140
	xordev = devm_kzalloc(&pdev->dev, sizeof(*xordev), GFP_KERNEL);
	if (!xordev)
1141 1142 1143 1144 1145 1146
		return -ENOMEM;

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	if (!res)
		return -ENODEV;

1147 1148 1149
	xordev->xor_base = devm_ioremap(&pdev->dev, res->start,
					resource_size(res));
	if (!xordev->xor_base)
1150 1151 1152 1153 1154 1155
		return -EBUSY;

	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
	if (!res)
		return -ENODEV;

1156 1157 1158
	xordev->xor_high_base = devm_ioremap(&pdev->dev, res->start,
					     resource_size(res));
	if (!xordev->xor_high_base)
1159 1160
		return -EBUSY;

1161
	platform_set_drvdata(pdev, xordev);
1162 1163 1164 1165

	/*
	 * (Re-)program MBUS remapping windows if we are asked to.
	 */
1166 1167
	dram = mv_mbus_dram_info();
	if (dram)
1168
		mv_xor_conf_mbus_windows(xordev, dram);
1169

1170 1171 1172
	/* Not all platforms can gate the clock, so it is not
	 * an error if the clock does not exists.
	 */
1173 1174 1175
	xordev->clk = clk_get(&pdev->dev, NULL);
	if (!IS_ERR(xordev->clk))
		clk_prepare_enable(xordev->clk);
1176

1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193
	if (pdev->dev.of_node) {
		struct device_node *np;
		int i = 0;

		for_each_child_of_node(pdev->dev.of_node, np) {
			dma_cap_mask_t cap_mask;
			int irq;

			dma_cap_zero(cap_mask);
			if (of_property_read_bool(np, "dmacap,memcpy"))
				dma_cap_set(DMA_MEMCPY, cap_mask);
			if (of_property_read_bool(np, "dmacap,xor"))
				dma_cap_set(DMA_XOR, cap_mask);
			if (of_property_read_bool(np, "dmacap,interrupt"))
				dma_cap_set(DMA_INTERRUPT, cap_mask);

			irq = irq_of_parse_and_map(np, 0);
1194 1195
			if (!irq) {
				ret = -ENODEV;
1196 1197 1198 1199 1200 1201 1202 1203
				goto err_channel_add;
			}

			xordev->channels[i] =
				mv_xor_channel_add(xordev, pdev, i,
						   cap_mask, irq);
			if (IS_ERR(xordev->channels[i])) {
				ret = PTR_ERR(xordev->channels[i]);
1204
				xordev->channels[i] = NULL;
1205 1206 1207 1208 1209 1210 1211
				irq_dispose_mapping(irq);
				goto err_channel_add;
			}

			i++;
		}
	} else if (pdata && pdata->channels) {
1212
		for (i = 0; i < MV_XOR_MAX_CHANNELS; i++) {
1213
			struct mv_xor_channel_data *cd;
1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227
			int irq;

			cd = &pdata->channels[i];
			if (!cd) {
				ret = -ENODEV;
				goto err_channel_add;
			}

			irq = platform_get_irq(pdev, i);
			if (irq < 0) {
				ret = irq;
				goto err_channel_add;
			}

1228
			xordev->channels[i] =
1229
				mv_xor_channel_add(xordev, pdev, i,
1230
						   cd->cap_mask, irq);
1231 1232
			if (IS_ERR(xordev->channels[i])) {
				ret = PTR_ERR(xordev->channels[i]);
1233 1234 1235 1236
				goto err_channel_add;
			}
		}
	}
1237

1238
	return 0;
1239 1240 1241

err_channel_add:
	for (i = 0; i < MV_XOR_MAX_CHANNELS; i++)
1242
		if (xordev->channels[i]) {
1243
			mv_xor_channel_remove(xordev->channels[i]);
1244 1245 1246
			if (pdev->dev.of_node)
				irq_dispose_mapping(xordev->channels[i]->irq);
		}
1247

1248 1249 1250 1251 1252
	if (!IS_ERR(xordev->clk)) {
		clk_disable_unprepare(xordev->clk);
		clk_put(xordev->clk);
	}

1253
	return ret;
1254 1255
}

1256
static int mv_xor_remove(struct platform_device *pdev)
1257
{
1258
	struct mv_xor_device *xordev = platform_get_drvdata(pdev);
1259 1260 1261
	int i;

	for (i = 0; i < MV_XOR_MAX_CHANNELS; i++) {
1262 1263
		if (xordev->channels[i])
			mv_xor_channel_remove(xordev->channels[i]);
1264
	}
1265

1266 1267 1268
	if (!IS_ERR(xordev->clk)) {
		clk_disable_unprepare(xordev->clk);
		clk_put(xordev->clk);
1269 1270
	}

1271 1272 1273
	return 0;
}

1274
#ifdef CONFIG_OF
1275
static struct of_device_id mv_xor_dt_ids[] = {
1276 1277 1278 1279 1280 1281
       { .compatible = "marvell,orion-xor", },
       {},
};
MODULE_DEVICE_TABLE(of, mv_xor_dt_ids);
#endif

1282 1283
static struct platform_driver mv_xor_driver = {
	.probe		= mv_xor_probe,
1284
	.remove		= mv_xor_remove,
1285
	.driver		= {
1286 1287 1288
		.owner	        = THIS_MODULE,
		.name	        = MV_XOR_NAME,
		.of_match_table = of_match_ptr(mv_xor_dt_ids),
1289 1290 1291 1292 1293 1294
	},
};


static int __init mv_xor_init(void)
{
1295
	return platform_driver_register(&mv_xor_driver);
1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312
}
module_init(mv_xor_init);

/* it's currently unsafe to unload this module */
#if 0
static void __exit mv_xor_exit(void)
{
	platform_driver_unregister(&mv_xor_driver);
	return;
}

module_exit(mv_xor_exit);
#endif

MODULE_AUTHOR("Saeed Bishara <saeed@marvell.com>");
MODULE_DESCRIPTION("DMA engine driver for Marvell's XOR engine");
MODULE_LICENSE("GPL");