1. 30 6月, 2020 1 次提交
  2. 27 6月, 2020 1 次提交
  3. 25 6月, 2020 3 次提交
  4. 30 3月, 2020 1 次提交
  5. 06 3月, 2020 1 次提交
  6. 27 2月, 2020 1 次提交
  7. 23 1月, 2020 1 次提交
  8. 06 2月, 2019 1 次提交
  9. 30 1月, 2019 1 次提交
  10. 11 1月, 2019 1 次提交
  11. 11 8月, 2018 1 次提交
    • J
      Remove spurious "cast is redundant" when accessing hidden member · 60ae70a0
      Joey Robichaud 提交于
      The AbstractSpeculationAnalyzer would check whether casting symbols
      used in Invocable expressions would break semantics. However it was not
      considering all MemberAccess to be potentially invokable. This Changes
      the IsInvokable check to consider all MemberAccess expressions.
      
      This fixes #28412.
      60ae70a0
  12. 26 8月, 2017 1 次提交
  13. 11 8月, 2017 1 次提交
  14. 02 8月, 2017 1 次提交
  15. 07 7月, 2017 1 次提交
  16. 29 6月, 2017 1 次提交
  17. 28 2月, 2017 1 次提交
  18. 09 12月, 2016 1 次提交
  19. 21 7月, 2016 1 次提交
  20. 26 1月, 2016 1 次提交
  21. 17 12月, 2015 1 次提交
    • J
      Switch tests unnecessarily using WpfFact to Fact · a226d9d2
      Jason Malinowski 提交于
      These tests were all using WpfFact, but not actually doing anything
      that required either WPF or an STA thread. We plan to enable
      parallelization of Facts (but not WpfFacts), and this ensures we can
      parallelize as many tests as possible.
      a226d9d2
  22. 18 11月, 2015 1 次提交
  23. 11 11月, 2015 1 次提交
  24. 16 10月, 2015 1 次提交
  25. 10 10月, 2015 1 次提交
  26. 07 7月, 2015 1 次提交
  27. 01 7月, 2015 1 次提交
  28. 10 6月, 2015 1 次提交
  29. 04 6月, 2015 2 次提交
    • J
      Responding to PR Feedback · bca5a252
      Jonathon Marolf 提交于
      Responding to peer review feedback. Updated to never consider user
      defined narrowing conversions unnecessary.
      bca5a252
    • J
      Correctly detect option strict on/off when determining if cast is redundant · fcd4ea01
      Jonathon Marolf 提交于
      Fixes #3161 and Fixes #3163
      
      User Scenario:
      User has code with narrowing conversion with an explicit cast.  We will
      offer to remove the cast even though this will cause the code to not
      compile.
      
      Fix Description:
      We previously never consulted optionstrict to determine if a
      user-defined narrowing cast was necessary.  The fix in CastAnalyzer.vb
      will check if the conversion is narrowing, if option strict is on, or if
      we generate a warning on implicit narrowing conversions.  We also offer
      to add a cast if an implicit conversion warning is given.
      
      Testing:  Added regression tests + existing tests
      fcd4ea01
  30. 03 6月, 2015 1 次提交
    • M
      Fix ITypeSymbolExtensions.IsOrDerivedFromExceptionType to handle type... · 3701a7f7
      Manish Vasani 提交于
      Fix ITypeSymbolExtensions.IsOrDerivedFromExceptionType to handle type parameters constrained on Exception type or its subtype
      
      Fixes https://github.com/dotnet/roslyn/issues/3254
      
      User scenario: User writes code where they have explicit casts to a type parameter deriving from Exception type or its subtype. We will offer incorrect cast removal fixes to remove these explicit casts. Removing such casts will cause their code to not compile. Even worse, if they apply a FixAll occurrences code fix, then all such casts across their (document/project/solution) will be removed, causing tons of compile errors.
      
      Fix description: IsOrDerivedFromExceptionType was only checking for base types of the given type symbol to detect if the type is an Exception type. We also need to handle type parameters which are constrained by Exception or its subtypes.
      
      Testing: Added regression tests + existing tests.
      3701a7f7
  31. 19 5月, 2015 1 次提交
    • M
      Dont offer cast simplification fixes for explicit reference conversions. · 6f906fa6
      Manish Vasani 提交于
      For code snippets such as below: "Base M(Base b) => (Derived)b;", we currently offer cast removal for cast to derived. However, this involves an explicit/narrowing conversion and hence can lead to an exception or data loss. The only way to detect such redundant casts is via flow analysis, which is not currently in our scope.
      
      Fix is to bail out early for such cast expressions. I have also fixed incorrect tests that were added to ensure the current behavior.
      
      Fixes #2761
      6f906fa6
  32. 21 2月, 2015 1 次提交
    • D
      Make VB Remove Unnecessary Cast a bit smarter in interpolations · fa0269b0
      Dustin Campbell 提交于
      There are legitimate cases where removing a cast inside a string
      interpolation can case the open brace of the interpolation to touch the
      open brace on an array literal, resulting in a broken parse (i.e. `{{`).
      
      This changes the Remove Unnecesary Cast code fix to add parentheses
      outside of the cast rather than around the inner expression. Then, the
      parenthesis simplifier has been updated to correctly handle the case
      where an array literal touches the start of an interpolation:
      
      Dim x = $"{({})}"
      
      Fixes Issue #739.
      fa0269b0
  33. 29 1月, 2015 1 次提交