Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
06aa0c3d
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
06aa0c3d
编写于
2月 05, 2019
作者:
D
David Barbet
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix check to look at inherited types as well.
上级
235a19f4
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
204 addition
and
4 deletion
+204
-4
src/EditorFeatures/VisualBasicTest/Diagnostics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
...stics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
+200
-2
src/Workspaces/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
...es/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
+4
-2
未找到文件。
src/EditorFeatures/VisualBasicTest/Diagnostics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
浏览文件 @
06aa0c3d
...
...
@@ -1363,7 +1363,7 @@ End Module
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryPredefinedCastWithGetType
()
As
Task
Public
Async
Function
TestDontRemoveNecessary
String
PredefinedCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
...
...
@@ -1378,7 +1378,37 @@ End Module
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryCTypeCastWithGetType
()
As
Task
Public
Async
Function
TestDontRemoveNecessaryWideningPredefinedCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CLng
(
a
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryNarrowingPredefinedCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CByte
(
a
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryStringCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
...
...
@@ -1391,6 +1421,174 @@ End Module
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryWideningCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CType
(
a
,
Long
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryNarrowingCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CType
(
a
,
Byte
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryUserDefinedCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CType
(
a
,
WeirdInt
).
GetType
()
|]
End
Sub
Public
Class
WeirdInt
Private
val
As
Integer
Public
Sub
New
(
ByVal
b
As
Integer
)
Me
.
val
=
b
End
Sub
Public
Shared
Widening
Operator
CType
(
ByVal
d
As
WeirdInt
)
As
Integer
Return
d
.
val
End
Operator
Public
Shared
Narrowing
Operator
CType
(
ByVal
i
As
Integer
)
As
WeirdInt
Return
New
WeirdInt
(
i
)
End
Operator
End
Class
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestRemoveUnnecessaryCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CType
(
a
,
Object
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Dim
expected
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
a
.
GetType
()
End
Sub
End
Module
</
File
>
Await
TestAsync
(
markup
,
expected
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestRemoveUnnecessaryInheritedCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
As
BaseClass
a
=
New
DerivedClass
()
Dim
b
=
[|
CType
(
a
,
BaseClass
).
GetType
()
|]
End
Sub
Public
Class
BaseClass
End
Class
Public
Class
DerivedClass
:
Inherits
BaseClass
End
Class
End
Module
</
File
>
Dim
expected
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
As
BaseClass
a
=
New
DerivedClass
()
Dim
b
=
a
.
GetType
()
End
Sub
Public
Class
BaseClass
End
Class
Public
Class
DerivedClass
:
Inherits
BaseClass
End
Class
End
Module
</
File
>
Await
TestAsync
(
markup
,
expected
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestRemoveUnnecessaryDirectCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
DirectCast
(
a
,
Object
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Dim
expected
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
a
.
GetType
()
End
Sub
End
Module
</
File
>
Await
TestAsync
(
markup
,
expected
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestRemoveUnnecessaryTryCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
TryCast
(
a
,
Object
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Dim
expected
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
a
.
GetType
()
End
Sub
End
Module
</
File
>
Await
TestAsync
(
markup
,
expected
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryPredefinedCastWithToString
()
As
Task
...
...
src/Workspaces/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
浏览文件 @
06aa0c3d
...
...
@@ -540,8 +540,10 @@ private bool ReplacementBreaksSystemObjectMethodResolution(SyntaxNode currentOri
{
var
previousOriginalType
=
this
.
OriginalSemanticModel
.
GetTypeInfo
(
previousOriginalNode
).
Type
;
var
previousReplacedType
=
this
.
SpeculativeSemanticModel
.
GetTypeInfo
(
previousReplacedNode
).
Type
;
return
!
Equals
(
previousOriginalType
,
previousReplacedType
);
if
(
previousReplacedType
!=
null
&&
previousOriginalType
!=
null
)
{
return
!
previousReplacedType
.
InheritsFromOrEquals
(
previousOriginalType
);
}
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录