Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
f10ddd4f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f10ddd4f
编写于
1月 29, 2019
作者:
D
David Barbet
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Added failing tests for vb cast with get type.
上级
7a333f52
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
49 addition
and
0 deletion
+49
-0
src/EditorFeatures/VisualBasicTest/Diagnostics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
...stics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
+45
-0
src/Workspaces/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
...es/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
+4
-0
未找到文件。
src/EditorFeatures/VisualBasicTest/Diagnostics/RemoveUnnecessaryCast/RemoveUnnecessaryCastTests.vb
浏览文件 @
f10ddd4f
...
...
@@ -1361,6 +1361,51 @@ End Module
Await
TestAsync
(
markup
,
expected
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryPredefinedCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CStr
(
a
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryCTypeCastWithGetType
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CType
(
a
,
String
).
GetType
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
32399
,
"https://github.com/dotnet/roslyn/issues/32399"
)
>
Public
Async
Function
TestDontRemoveNecessaryPredefinedCastWithToString
()
As
Task
Dim
markup
=
<
File
>
Module
Program
Sub
Main
()
Dim
a
=
2
Dim
b
=
[|
CStr
(
a
).
ToString
()
|]
End
Sub
End
Module
</
File
>
Await
TestMissingAsync
(
markup
)
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnnecessaryCast
)
>
<
WorkItem
(
30617
,
"https://github.com/dotnet/roslyn/issues/30617"
)
>
Public
Async
Function
TestDontRemoveNecessaryPredefinedCastInWithStatement
()
As
Task
...
...
src/Workspaces/Core/Portable/Utilities/AbstractSpeculationAnalyzer.cs
浏览文件 @
f10ddd4f
...
...
@@ -670,6 +670,10 @@ private bool ReplacementBreaksExpression(TExpressionSyntax expression, TExpressi
var
symbol
=
originalSymbolInfo
.
Symbol
;
var
newSymbol
=
newSymbolInfo
.
Symbol
;
var
originalTypeInfo
=
_semanticModel
.
GetTypeInfo
(
expression
);
//_semanticModel.Get
//var newTypeInfo = this.SpeculativeSemanticModel.GetTypeInfo(newExpression);
if
(
SymbolInfosAreCompatible
(
originalSymbolInfo
,
newSymbolInfo
))
{
// Original and new symbols for the invocation expression are compatible.
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录