提交 f10ddd4f 编写于 作者: D David Barbet

Added failing tests for vb cast with get type.

上级 7a333f52
......@@ -1361,6 +1361,51 @@ End Module
Await TestAsync(markup, expected)
End Function
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnnecessaryCast)>
<WorkItem(32399, "https://github.com/dotnet/roslyn/issues/32399")>
Public Async Function TestDontRemoveNecessaryPredefinedCastWithGetType() As Task
Dim markup =
<File>
Module Program
Sub Main()
Dim a = 2
Dim b = [|CStr(a).GetType()|]
End Sub
End Module
</File>
Await TestMissingAsync(markup)
End Function
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnnecessaryCast)>
<WorkItem(32399, "https://github.com/dotnet/roslyn/issues/32399")>
Public Async Function TestDontRemoveNecessaryCTypeCastWithGetType() As Task
Dim markup =
<File>
Module Program
Sub Main()
Dim a = 2
Dim b = [|CType(a, String).GetType()|]
End Sub
End Module
</File>
Await TestMissingAsync(markup)
End Function
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnnecessaryCast)>
<WorkItem(32399, "https://github.com/dotnet/roslyn/issues/32399")>
Public Async Function TestDontRemoveNecessaryPredefinedCastWithToString() As Task
Dim markup =
<File>
Module Program
Sub Main()
Dim a = 2
Dim b = [|CStr(a).ToString()|]
End Sub
End Module
</File>
Await TestMissingAsync(markup)
End Function
<Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnnecessaryCast)>
<WorkItem(30617, "https://github.com/dotnet/roslyn/issues/30617")>
Public Async Function TestDontRemoveNecessaryPredefinedCastInWithStatement() As Task
......
......@@ -670,6 +670,10 @@ private bool ReplacementBreaksExpression(TExpressionSyntax expression, TExpressi
var symbol = originalSymbolInfo.Symbol;
var newSymbol = newSymbolInfo.Symbol;
var originalTypeInfo = _semanticModel.GetTypeInfo(expression);
//_semanticModel.Get
//var newTypeInfo = this.SpeculativeSemanticModel.GetTypeInfo(newExpression);
if (SymbolInfosAreCompatible(originalSymbolInfo, newSymbolInfo))
{
// Original and new symbols for the invocation expression are compatible.
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册