Bug 911913 - Squiggle location for Unimplemented Interface Method diagnostic changed to reflect interface rather than class - matching VB implementation. (changeset 1252208)

Rolling back changeset that switched async state machine to a class. Investigating some issues.  (changeset 1252130)

Features the new syntax ('= expr;'), new rules around required accessors, and allows auto property and field initializers in structs. (changeset 1251890)

 Currently the async state machine is a struct. Struct is better for performance (no allocation) but prevents us to modify local variables in the async method in EnC. The CLR doesn't support adding fields to a struct.

     This change switches the state machine to a class when emitting unoptimized debug code (/debug:full /optimize-). It keeps it struct otherwise. (changeset 1251785)

 (changeset 1251701)

Address code review feeedback for changeset 1251270 (Add "CustomTags" property to DiagnosticDescriptor and Diagnostic types) (changeset 1251448)

Adjusted conditions under which using statement target should be parsed as an expression. Fixes https://roslyn.codeplex.com/workitem/11. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/8903c0ed35c40f5ff3354e30b996a862d736192b. (changeset 1251406)

Fixes VB data flow analysis to stop reporting 'unused variable' errors for variables that the compiler synthesizes when the code contains syntax errors. For example, VB reports bogus (Unused variable '') error for the following code -

Module Module1
Sub Main
Dim
End Sub
End Module

Current fix is to suppress the error if the variable has an empty name. Also added a test + fixed up couple of tests that were relying on the bad error. (changeset 1251396)

We had some cases where we were build against different MSBuild assemblies from different versions from MSBuild. This caused runtime errors when we tried to run tests. (changeset 1251361)

Add support for declaration expressions in constructor initializer. Fixes https://roslyn.codeplex.com/workitem/6. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/36e1c380c3caffdc1c0978a23308b4c4a5a7bf77. (changeset 1251337)

Add "CustomTags" property to DiagnosticDescriptor and Diagnostic types. This will enable DiagnosticAnalyzers to generate diagnostics with custom tags providing additional metadata information about the diagnostic. (changeset 1251270)

A Declaration Expression should not be treated as a primary-expression by the language parser. Fixes https://roslyn.codeplex.com/workitem/18. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/d5f905aefda0b465c8e32d990430f5da5ecdeb45. (changeset 1251223)

If an open file is a linked file and that document or its project is unloaded, then we determine the new active context document for that linked file and switch the context. Following the same process during solution close may fail because the host document for the new active context document may have already been removed. There is no need to set the updated document context during solution close so we now skip this step in that case. (changeset 1251204)

Implementing Equals and GetHashCode on AnalyzerFileReference instead of AnalyzerReference since reference equality makes sense for other AnalyzerReferences. (changeset 1251164)

Provide option to opt-in to deterministic (non-zero) timestamp using "/features:deterministic". (changeset 1250882)

Ensure each lambda, including an implicit lambda in a query expression, has its own scope for declaration expressions within it. Fixes https://roslyn.codeplex.com/workitem/2. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/e79e272450264fb41a2f7f39b3fbaf3a0e73021b. (changeset 1250867)

Enumerate the set of top-level and nested types in the base PeWriter class.
 (changeset 1250804)

Enable assignment to a declaration expression. Fixes https://roslyn.codeplex.com/workitem/18. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/0d51dfd01a7ff479cdae0bb90837dfa3770e6562. (changeset 1250584)

Report ERR_MethodArgCantBeRefAny for “out var” declarations without initializers. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/4b562c0061233f3e3a76de510ecd68b2d37fa1b1. (changeset 1250556)

Report name collision for “out var” declarations without initializers. Fixes http://roslyn.codeplex.com/workitem/42. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/c8c365cfa05594119a2bf4d269fbf23b2ae51d33. (changeset 1250509)

Improve CS0523 error message for backing fields of primary constructor parameters. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/2e28a89593fe4941209c87215855e5ae08775da2. (changeset 1250498)

Factor generating of custom debug information to a separate class. Remove mutable state from PEWriter related to custom debug info generation. (changeset 1250467)

Report an error if an argument list is provided for an implemented interface. Fixes https://roslyn.codeplex.com/workitem/4. This is a port of https://roslyn.codeplex.com/SourceControl/changeset/f930b49714dc268a0e9df96d213d5516634a6450. (changeset 1250419)

interface I
{
static void M(this object o);
}

Result:
(3,17): error CS0106: The modifier 'static' is not valid for this item
(3,17): error CS1105: Extension methods must be static

Expected:
(3,17): error CS0106: The modifier 'static' is not valid for this item
(3,17): error CS1106: Extension method must be defined in a non-generic static class

The fix was simple - I simply switched the order in which the above extension method errors are reported. However, this has a small side-effect in that it changes the error reporting for the following case. The change seems acceptable (i.e. user would anyways have hit the new error that we report now as soon as they fixed the error that the old compiler was reporting in this case). I've fixed up the couple of tests that were validating the old error for this case.

class C
{
void M(this object o) { }
}

Old (Native as well as Roslyn):
Test.cs(3,10): error CS1105: Extension method must be static

New:
Test.cs(1,7): error CS1106: Extension method must be defined in a non-generic static class (changeset 1250408)

Bug 687246: fix NumberStyles overlooked in previous checkin (thanks Chuck found out) (changeset 1250362)

Bug fix (923303): check null parameter and throw for API - GetAnnotations(...) (changeset 1250335)

The analyzers for CA1309, CA2213, CA2214, CA2200 were all calling GetSymbolInfo earlier and/or more often than they needed to and were slowing down analysis.  This change adds checks before the offending calls to GetSymbolInfo.  This also corrects the behavior of the CA2214 analyzer, which was previously producing warnings for all virtual methods called from within a constructor, not just for virtual methods defined in the class containing the constructor. (changeset 1250296)

Migrated state of “Declaration Expressions” implementation equivalent to https://roslyn.codeplex.com/SourceControl/changeset/b7fd08a5695e21cd4d23b8b70815c53656dab65f. (changeset 1249879)

Use ImmutableArray instead if IEnumerable. (changeset 1249786)

Migrated state of “Primary Constructors” implementation equivalent to https://roslyn.codeplex.com/SourceControl/changeset/af3db25146a74523fbb2cf11ef00ddec6c0c3690. (changeset 1249690)