1. 04 1月, 2019 1 次提交
  2. 20 12月, 2018 1 次提交
  3. 18 12月, 2018 1 次提交
  4. 17 12月, 2018 1 次提交
  5. 07 12月, 2018 1 次提交
    • M
      Workaround for #19965 · 9cc8b0c5
      Manish Vasani 提交于
      Detect references to method/property in bound method group/property group using semantic model APIs. Also provide a different message for methods which have name only references.
      9cc8b0c5
  6. 06 12月, 2018 1 次提交
  7. 20 11月, 2018 1 次提交
  8. 14 11月, 2018 1 次提交
  9. 13 11月, 2018 1 次提交
  10. 11 11月, 2018 1 次提交
  11. 10 11月, 2018 1 次提交
  12. 07 11月, 2018 1 次提交
  13. 01 11月, 2018 1 次提交
  14. 31 10月, 2018 1 次提交
  15. 26 10月, 2018 1 次提交
  16. 23 10月, 2018 1 次提交
  17. 19 10月, 2018 1 次提交
    • C
      Do not crash ExtractMethod when we run into a dataflowanalysis result we... · 19d3a815
      CyrusNajmabadi 提交于
      Do not crash ExtractMethod when we run into a dataflowanalysis result we didn't account for. (#30554)
      
      * Do not crash when we run into a dataflowanalysis result we didn't account for.
      
      * Add comment.
      
      * remove
      
      * Improve error strings.
      
      * Simplify.
      
      * Assume the variable is read.
      
      * Add test.
      
      * KeyValueMessage.
      19d3a815
  18. 12 10月, 2018 1 次提交
  19. 11 10月, 2018 1 次提交
  20. 10 10月, 2018 2 次提交
  21. 19 9月, 2018 1 次提交
  22. 17 9月, 2018 2 次提交
  23. 16 9月, 2018 1 次提交
  24. 15 9月, 2018 1 次提交
  25. 14 9月, 2018 1 次提交
    • M
      Change RemoveUnusedMembersAnalyzers to be a non-Style analyzer · ae2428eb
      Manish Vasani 提交于
      It was initially implemented as a potential code style analyzer, but we have agreed on it being a code quality analyzer, with no special IDE options/preferences logic.
      I have switched the analyzer to be implemented just like a regular third party analyzer.
      This cleans up the implementation quite a bit, and also fixes the issue where we reported hidden diagnostics for this analyzer instead of suggestion diagnostics as the default code style diagnostic severity is hidden.
      I have also reverted AbstractCodeStyleDiagnosticAnalyzer.cs to the state before this analyzer was implemented.
      ae2428eb
  26. 29 8月, 2018 2 次提交
  27. 28 8月, 2018 1 次提交
    • M
      Address PR Feedback: · a6db5441
      Manish Vasani 提交于
      1. Break the analyzer into two separate diagnostics for flagging unused and unread members. Latter rule has no code fix.
      2. Remove all UI option elements for the added diagnostics and turn the rules off by default for now.
      3. Bail out for invalid operations and syntax errors.
      4. Handle doc comments and nameof - report unread member diagostics instead of unused member diagnostics if referenced in non-read/write context.
      a6db5441
  28. 25 8月, 2018 2 次提交
    • M
      Address PR feedback · c1c54cc9
      Manish Vasani 提交于
      c1c54cc9
    • M
      Add analyzer/fixer to flag and remove unused private members (fields/methods/properties/events) · 76f4c480
      Manish Vasani 提交于
      Analyzer flags two cases: members with no read/writes and members with only writes.
      
      1. Members with no read or writes: `Type '{0}' has an unused private member '{1}' which can be removed.`
      2. Only writes: `Type '{0}' has a private member '{1}' which can be removed as the value assigned to it is never used.`
      
      Code fix removes the unused member declaration.
      Fixes #24225
      
      Open questions:
      1. Current analyzer design uses a single code style option for all members and both the above kinds of unused members. We can potentially have multiple options, but this should probably be done based on feedback.
      2. Should the analyzer use different diagnostic IDs for the above two kinds of unused members? This will mean that the FixAll experience will need multiple iterations for removing unused members.
      3. Should we update the code fix (or have an additional code fix) that also updates the write references for the case (2) above? Or is it better to leave the references to break the code so the user can analyze if the value being assigned can also be removed. The PR current chooses the latter approach as it is more conservative and unlikely to cause silent breaks.
      76f4c480
  29. 21 8月, 2018 2 次提交
    • M
      PR feedback · fb2cc98f
      Manish Vasani 提交于
      fb2cc98f
    • M
      Add refactoring to convert foreach loop into linq invocations (Select,... · 4b8785a5
      Manish Vasani 提交于
      Add refactoring to convert foreach loop into linq invocations (Select, SelectMany and Where invocations)
      
      Adds one of the refactorings mentioned in #8953
      
      ```
      //
      // INPUT:
      //   foreach (var n1 in c1)
      //      foreach (var n2 in c2)
      //          if (n1 > n2)
      //              yield return n1 + n2;
      //
      // OUTPUT:
      //   c1.SelectMany(n1 => c2.Where(n2 => n1 > n2).Select(n2 => n1 + n2))
      //
      ```
      4b8785a5
  30. 20 8月, 2018 1 次提交
  31. 17 8月, 2018 1 次提交
  32. 07 8月, 2018 1 次提交
  33. 21 7月, 2018 1 次提交
  34. 17 7月, 2018 1 次提交
  35. 14 7月, 2018 1 次提交