提交 fb2cc98f 编写于 作者: M Manish Vasani

PR feedback

上级 156a56a3
......@@ -184,7 +184,7 @@ private static QueryClauseSyntax CreateQueryClause(ExtendedSyntaxNode node)
// OR
// c1.SelectMany(n1 => ...
//
var invokedMethodName = !hasForEachChild ? "Select" : "SelectMany";
var invokedMethodName = !hasForEachChild ? nameof(Enumerable.Select) : nameof(Enumerable.SelectMany);
return SyntaxFactory.InvocationExpression(
SyntaxFactory.MemberAccessExpression(
SyntaxKind.SimpleMemberAccessExpression,
......@@ -265,7 +265,7 @@ private static QueryClauseSyntax CreateQueryClause(ExtendedSyntaxNode node)
SyntaxFactory.MemberAccessExpression(
SyntaxKind.SimpleMemberAccessExpression,
receiver.Parenthesize(),
SyntaxFactory.IdentifierName("Where")),
SyntaxFactory.IdentifierName(nameof(Enumerable.Where))),
SyntaxFactory.ArgumentList(SyntaxFactory.SingletonSeparatedList(
SyntaxFactory.Argument(lambda))));
......
......@@ -95,7 +95,7 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte
return;
}
// Offer refactoring to convert foreach to query expression. For example:
// Offer refactoring to convert foreach to LINQ query expression. For example:
//
// INPUT:
// foreach (var n1 in c1)
......@@ -111,10 +111,10 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte
//
context.RegisterRefactoring(
new ForEachToLinqQueryCodeAction(
FeaturesResources.Convert_to_query,
FeaturesResources.Convert_to_linq,
c => ApplyConversion(queryConverter, document, convertToQuery: true, c)));
// Offer refactoring to convert foreach to linq invocation expression. For example:
// Offer refactoring to convert foreach to LINQ invocation expression. For example:
//
// INPUT:
// foreach (var n1 in c1)
......@@ -132,7 +132,7 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte
{
context.RegisterRefactoring(
new ForEachToLinqQueryCodeAction(
FeaturesResources.Convert_to_linq,
FeaturesResources.Convert_to_linq_call_form,
c => ApplyConversion(linqConverter, document, convertToQuery: false, c)));
}
}
......
......@@ -934,7 +934,7 @@ internal class FeaturesResources {
}
/// <summary>
/// Looks up a localized string similar to Convert to linq.
/// Looks up a localized string similar to Convert to LINQ.
/// </summary>
internal static string Convert_to_linq {
get {
......@@ -943,11 +943,11 @@ internal class FeaturesResources {
}
/// <summary>
/// Looks up a localized string similar to Convert to query.
/// Looks up a localized string similar to Convert to LINQ (call form).
/// </summary>
internal static string Convert_to_query {
internal static string Convert_to_linq_call_form {
get {
return ResourceManager.GetString("Convert_to_query", resourceCulture);
return ResourceManager.GetString("Convert_to_linq_call_form", resourceCulture);
}
}
......
......@@ -1376,8 +1376,8 @@ This version used in: {2}</value>
<data name="Convert_to_conditional_expression" xml:space="preserve">
<value>Convert to conditional expression</value>
</data>
<data name="Convert_to_query" xml:space="preserve">
<value>Convert to query</value>
<data name="Convert_to_linq" xml:space="preserve">
<value>Convert to LINQ</value>
</data>
<data name="Convert_to_tuple" xml:space="preserve">
<value>Convert to tuple</value>
......@@ -1403,7 +1403,7 @@ This version used in: {2}</value>
<data name="Formatting_document" xml:space="preserve">
<value>Formatting document</value>
</data>
<data name="Convert_to_linq" xml:space="preserve">
<value>Convert to linq</value>
<data name="Convert_to_linq_call_form" xml:space="preserve">
<value>Convert to LINQ (call form)</value>
</data>
</root>
\ No newline at end of file
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
......@@ -23,13 +23,8 @@
<note />
</trans-unit>
<trans-unit id="Convert_to_linq">
<source>Convert to linq</source>
<target state="new">Convert to linq</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_query">
<source>Convert to query</source>
<target state="new">Convert to query</target>
<source>Convert to LINQ</source>
<target state="new">Convert to LINQ</target>
<note />
</trans-unit>
<trans-unit id="Add_to_0">
......@@ -42,6 +37,11 @@
<target state="new">Convert to class</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_linq_call_form">
<source>Convert to LINQ (call form)</source>
<target state="new">Convert to LINQ (call form)</target>
<note />
</trans-unit>
<trans-unit id="Convert_to_struct">
<source>Convert to struct</source>
<target state="new">Convert to struct</target>
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册