issues_controller.rb 8.7 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include SpammableActions
8

9 10
  prepend_before_action :authenticate_user!, only: [:new]

11
  before_action :check_issues_available!
12
  before_action :issue, except: [:index, :new, :create, :bulk_update]
D
Dmitriy Zaporozhets 已提交
13 14

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
15
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
16 17

  # Allow modify issue
18
  before_action :authorize_update_issue!, only: [:edit, :update, :move]
D
Dmitriy Zaporozhets 已提交
19

20 21 22
  # Allow create a new branch and empty WIP merge request from current issue
  before_action :authorize_create_merge_request!, only: [:create_merge_request]

D
Dmitriy Zaporozhets 已提交
23
  respond_to :html
G
gitlabhq 已提交
24 25

  def index
26 27 28
    @collection_type    = "Issue"
    @issues             = issues_collection
    @issues             = @issues.page(params[:page])
29
    @issuable_meta_data = issuable_meta_data(@issues, @collection_type)
30
    @total_pages        = issues_page_count(@issues)
31

32
    return if redirect_out_of_range(@issues, @total_pages)
33

34
    if params[:label_name].present?
35 36
      @labels = LabelsFinder.new(current_user, project_id: @project.id, title: params[:label_name]).execute
    end
G
gitlabhq 已提交
37

38 39 40 41 42 43 44 45 46 47 48 49
    @users = []

    if params[:assignee_id].present?
      assignee = User.find_by_id(params[:assignee_id])
      @users.push(assignee) if assignee
    end

    if params[:author_id].present?
      author = User.find_by_id(params[:author_id])
      @users.push(author) if author
    end

G
gitlabhq 已提交
50
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
51
      format.html
52
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
53 54
      format.json do
        render json: {
55
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
56
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
57 58
        }
      end
G
gitlabhq 已提交
59 60 61 62
    end
  end

  def new
63
    params[:issue] ||= ActionController::Parameters.new(
64
      assignee_ids: ""
65
    )
66
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
67
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
68
      discussion_to_resolve: params[:discussion_to_resolve]
69
    )
70
    service = Issues::BuildService.new(project, current_user, build_params)
71

72
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
73
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
74
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
75

G
gitlabhq 已提交
76 77 78 79 80 81 82 83
    respond_with(@issue)
  end

  def edit
    respond_with(@issue)
  end

  def show
84
    @noteable = @issue
85
    @note     = @project.notes.new(noteable: @issue)
G
gitlabhq 已提交
86

87
    @discussions = @issue.discussions
88
    @notes = prepare_notes_for_rendering(@discussions.flat_map(&:notes), @noteable)
89

90 91 92
    respond_to do |format|
      format.html
      format.json do
D
Douwe Maan 已提交
93
        render json: serializer.represent(@issue)
94 95
      end
    end
G
gitlabhq 已提交
96 97
  end

98
  def discussions
99 100 101 102 103 104
    notes = @issue.notes
      .inc_relations_for_view
      .includes(:noteable)
      .fresh
      .reject { |n| n.cross_reference_not_visible_for?(current_user) }

105 106
    prepare_notes_for_rendering(notes)

107
    discussions = Discussion.build_collection(notes, @issue)
108

109
    render json: DiscussionSerializer.new(project: @project, noteable: @issue, current_user: current_user).represent(discussions)
110 111
  end

G
gitlabhq 已提交
112
  def create
113
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
114
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
115 116 117
      discussion_to_resolve: params[:discussion_to_resolve]
    )

118 119 120
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

121
    if service.discussions_to_resolve.count(&:resolved?) > 0
122
      flash[:notice] = if service.discussion_to_resolve_id
123 124 125 126
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
127
    end
G
gitlabhq 已提交
128

129
    respond_to do |format|
130
      format.html do
131
        recaptcha_check_with_fallback { render :new }
132
      end
133
      format.js do
134 135
        @link = @issue.attachment.url.to_js
      end
136
    end
G
gitlabhq 已提交
137 138 139
  end

  def update
140 141 142
    update_params = issue_params.merge(spammable_params)

    @issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
G
gitlabhq 已提交
143

144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
    respond_to do |format|
      format.html do
        recaptcha_check_with_fallback { render :edit }
      end

      format.json do
        render_issue_json
      end
    end

  rescue ActiveRecord::StaleObjectError
    render_conflict_response
  end

  def move
    params.require(:move_to_project_id)

161 162
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
163 164
      return render_404 unless issue.can_move?(current_user, new_project)

165
      @issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
166
    end
G
gitlabhq 已提交
167 168

    respond_to do |format|
169
      format.json do
170
        render_issue_json
171
      end
G
gitlabhq 已提交
172
    end
173 174

  rescue ActiveRecord::StaleObjectError
175
    render_conflict_response
G
gitlabhq 已提交
176 177
  end

178 179 180 181 182 183 184 185 186 187 188 189 190 191
  def referenced_merge_requests
    @merge_requests = @issue.referenced_merge_requests(current_user)
    @closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
192
    @related_branches = @issue.related_branches(current_user)
193 194 195 196 197 198 199 200 201 202

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

203 204 205 206 207 208 209
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
      @issue.can_be_worked_on?(current_user)

    respond_to do |format|
      format.json do
210
        render json: { can_create_branch: can_create, has_related_branch: @issue.has_related_branch? }
211 212 213 214
      end
    end
  end

215
  def realtime_changes
R
Regis Boudinot 已提交
216
    Gitlab::PollingInterval.set_header(response, interval: 3_000)
R
Regis 已提交
217

218
    response = {
219
      title: view_context.markdown_field(@issue, :title),
R
Regis 已提交
220
      title_text: @issue.title,
221 222
      description: view_context.markdown_field(@issue, :description),
      description_text: @issue.description,
223
      task_status: @issue.task_status
224
    }
225

226
    if @issue.edited?
227 228 229 230 231 232
      response[:updated_at] = @issue.updated_at
      response[:updated_by_name] = @issue.last_edited_by.name
      response[:updated_by_path] = user_path(@issue.last_edited_by)
    end

    render json: response
R
Regis Boudinot 已提交
233 234
  end

235
  def create_merge_request
236
    result = ::MergeRequests::CreateFromIssueService.new(project, current_user, issue_iid: issue.iid).execute
237 238 239 240 241 242 243 244

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
245
  protected
G
gitlabhq 已提交
246 247

  def issue
248
    return @issue if defined?(@issue)
249
    # The Sortable default scope causes performance issues when used with find_by
250
    @noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take!
251 252 253 254

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
255
  end
256
  alias_method :subscribable_resource, :issue
257
  alias_method :issuable, :issue
258
  alias_method :awardable, :issue
259
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
260

261 262 263 264
  def spammable_path
    project_issue_path(@project, @issue)
  end

D
Dmitriy Zaporozhets 已提交
265
  def authorize_update_issue!
266
    render_404 unless can?(current_user, :update_issue, @issue)
D
Dmitriy Zaporozhets 已提交
267 268
  end

D
Dmitriy Zaporozhets 已提交
269
  def authorize_admin_issues!
270
    render_404 unless can?(current_user, :admin_issue, @project)
D
Dmitriy Zaporozhets 已提交
271
  end
272

273
  def authorize_create_merge_request!
274
    render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?(current_user)
275 276
  end

277
  def check_issues_available!
278
    return render_404 unless @project.feature_available?(:issues, current_user)
279
  end
280

281 282 283 284 285 286 287 288
  def render_issue_json
    if @issue.valid?
      render json: serializer.represent(@issue)
    else
      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
    end
  end

289
  def issue_params
290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
    ] + [{ label_ids: [], assignee_ids: [] }]
306
  end
307 308 309 310 311 312

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

313 314 315 316
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end

317 318
    redirect_to new_user_session_path, notice: notice
  end
D
Douwe Maan 已提交
319 320 321 322

  def serializer
    IssueSerializer.new(current_user: current_user, project: issue.project)
  end
G
gitlabhq 已提交
323
end